Skip to content

Add hasProductChangeEvent check to isEmpty#8402

Merged
jandro996 merged 2 commits intomasterfrom
alejandro.gonzalez/empty-product-change-bug
Feb 18, 2025
Merged

Add hasProductChangeEvent check to isEmpty#8402
jandro996 merged 2 commits intomasterfrom
alejandro.gonzalez/empty-product-change-bug

Conversation

@jandro996
Copy link
Copy Markdown
Member

@jandro996 jandro996 commented Feb 17, 2025

What Does This Do

When support for product change events was added, it was not included in the isEmpty method.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@jandro996 jandro996 added type: bug Bug report and fix tag: no release notes Changes to exclude from release notes comp: telemetry Telemetry labels Feb 17, 2025
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Feb 17, 2025

Benchmarks

Startup

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-02-17T15:17:08 2025-02-17T15:24:14
git_branch master alejandro.gonzalez/empty-product-change-bug
git_commit_date 1739796033 1739804435
git_commit_sha 5b9a331 859df20
release_version 1.47.0-SNAPSHOT~5b9a331fd8 1.47.0-SNAPSHOT~859df2016e
start_time 2025-02-17T15:16:54 2025-02-17T15:24:00
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1739806214 1739806214
ci_job_id 810854517 810854517
ci_pipeline_id 56082181 56082181
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-bqrkrfyj-project-304-concurrent-2-fsi1k511 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-bqrkrfyj-project-304-concurrent-2-fsi1k511 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~859df2016e, baseline=1.47.0-SNAPSHOT~5b9a331fd8
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.362 ms) : 1342, 1383
.   : milestone, 1362,
appsec (1.774 ms) : 1750, 1797
.   : milestone, 1774,
appsec_no_iast (1.785 ms) : 1761, 1808
.   : milestone, 1785,
iast (1.509 ms) : 1485, 1533
.   : milestone, 1509,
profiling (1.499 ms) : 1475, 1523
.   : milestone, 1499,
tracing (1.516 ms) : 1492, 1541
.   : milestone, 1516,
section candidate
no_agent (1.364 ms) : 1344, 1383
.   : milestone, 1364,
appsec (1.751 ms) : 1727, 1775
.   : milestone, 1751,
appsec_no_iast (1.754 ms) : 1730, 1779
.   : milestone, 1754,
iast (1.529 ms) : 1504, 1554
.   : milestone, 1529,
profiling (1.551 ms) : 1526, 1575
.   : milestone, 1551,
tracing (1.489 ms) : 1465, 1513
.   : milestone, 1489,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.362 ms [1.342 ms, 1.383 ms] -
appsec 1.774 ms [1.75 ms, 1.797 ms] 411.568 µs (30.2%)
appsec_no_iast 1.785 ms [1.761 ms, 1.808 ms] 422.49 µs (31.0%)
iast 1.509 ms [1.485 ms, 1.533 ms] 146.707 µs (10.8%)
profiling 1.499 ms [1.475 ms, 1.523 ms] 137.015 µs (10.1%)
tracing 1.516 ms [1.492 ms, 1.541 ms] 154.054 µs (11.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.364 ms [1.344 ms, 1.383 ms] -
appsec 1.751 ms [1.727 ms, 1.775 ms] 387.15 µs (28.4%)
appsec_no_iast 1.754 ms [1.73 ms, 1.779 ms] 390.653 µs (28.6%)
iast 1.529 ms [1.504 ms, 1.554 ms] 165.093 µs (12.1%)
profiling 1.551 ms [1.526 ms, 1.575 ms] 186.924 µs (13.7%)
tracing 1.489 ms [1.465 ms, 1.513 ms] 125.389 µs (9.2%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~859df2016e, baseline=1.47.0-SNAPSHOT~5b9a331fd8
    dateFormat X
    axisFormat %s
section baseline
no_agent (387.601 µs) : 368, 407
.   : milestone, 388,
iast (509.157 µs) : 487, 532
.   : milestone, 509,
iast_FULL (746.176 µs) : 724, 768
.   : milestone, 746,
iast_GLOBAL (559.438 µs) : 537, 582
.   : milestone, 559,
iast_HARDCODED_SECRET_DISABLED (508.164 µs) : 485, 531
.   : milestone, 508,
iast_INACTIVE (459.42 µs) : 439, 480
.   : milestone, 459,
iast_TELEMETRY_OFF (496.371 µs) : 474, 519
.   : milestone, 496,
tracing (452.653 µs) : 432, 473
.   : milestone, 453,
section candidate
no_agent (385.973 µs) : 366, 406
.   : milestone, 386,
iast (510.195 µs) : 487, 533
.   : milestone, 510,
iast_FULL (745.391 µs) : 724, 767
.   : milestone, 745,
iast_GLOBAL (567.744 µs) : 545, 590
.   : milestone, 568,
iast_HARDCODED_SECRET_DISABLED (513.406 µs) : 490, 536
.   : milestone, 513,
iast_INACTIVE (463.897 µs) : 442, 485
.   : milestone, 464,
iast_TELEMETRY_OFF (502.106 µs) : 479, 525
.   : milestone, 502,
tracing (456.898 µs) : 435, 478
.   : milestone, 457,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 387.601 µs [368.003 µs, 407.199 µs] -
iast 509.157 µs [486.526 µs, 531.787 µs] 121.556 µs (31.4%)
iast_FULL 746.176 µs [724.325 µs, 768.027 µs] 358.575 µs (92.5%)
iast_GLOBAL 559.438 µs [537.084 µs, 581.793 µs] 171.838 µs (44.3%)
iast_HARDCODED_SECRET_DISABLED 508.164 µs [485.235 µs, 531.093 µs] 120.563 µs (31.1%)
iast_INACTIVE 459.42 µs [438.524 µs, 480.316 µs] 71.82 µs (18.5%)
iast_TELEMETRY_OFF 496.371 µs [474.217 µs, 518.525 µs] 108.77 µs (28.1%)
tracing 452.653 µs [431.867 µs, 473.44 µs] 65.053 µs (16.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 385.973 µs [365.895 µs, 406.051 µs] -
iast 510.195 µs [487.459 µs, 532.931 µs] 124.222 µs (32.2%)
iast_FULL 745.391 µs [723.57 µs, 767.212 µs] 359.418 µs (93.1%)
iast_GLOBAL 567.744 µs [545.341 µs, 590.147 µs] 181.771 µs (47.1%)
iast_HARDCODED_SECRET_DISABLED 513.406 µs [490.355 µs, 536.456 µs] 127.433 µs (33.0%)
iast_INACTIVE 463.897 µs [442.421 µs, 485.373 µs] 77.924 µs (20.2%)
iast_TELEMETRY_OFF 502.106 µs [478.833 µs, 525.379 µs] 116.133 µs (30.1%)
tracing 456.898 µs [435.436 µs, 478.36 µs] 70.925 µs (18.4%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master alejandro.gonzalez/empty-product-change-bug
git_commit_date 1739796033 1739804435
git_commit_sha 5b9a331 859df20
release_version 1.47.0-SNAPSHOT~5b9a331fd8 1.47.0-SNAPSHOT~859df2016e
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1739806790 1739806790
ci_job_id 810854518 810854518
ci_pipeline_id 56082181 56082181
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-emwfzakh-project-304-concurrent-0-fylusoy1 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-emwfzakh-project-304-concurrent-0-fylusoy1 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~859df2016e, baseline=1.47.0-SNAPSHOT~5b9a331fd8
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.595 s) : 15595000, 15595000
.   : milestone, 15595000,
appsec (15.027 s) : 15027000, 15027000
.   : milestone, 15027000,
iast (19.065 s) : 19065000, 19065000
.   : milestone, 19065000,
iast_GLOBAL (17.997 s) : 17997000, 17997000
.   : milestone, 17997000,
profiling (15.011 s) : 15011000, 15011000
.   : milestone, 15011000,
tracing (14.808 s) : 14808000, 14808000
.   : milestone, 14808000,
section candidate
no_agent (14.985 s) : 14985000, 14985000
.   : milestone, 14985000,
appsec (15.249 s) : 15249000, 15249000
.   : milestone, 15249000,
iast (18.292 s) : 18292000, 18292000
.   : milestone, 18292000,
iast_GLOBAL (18.219 s) : 18219000, 18219000
.   : milestone, 18219000,
profiling (15.156 s) : 15156000, 15156000
.   : milestone, 15156000,
tracing (14.915 s) : 14915000, 14915000
.   : milestone, 14915000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.595 s [15.595 s, 15.595 s] -
appsec 15.027 s [15.027 s, 15.027 s] -568.0 ms (-3.6%)
iast 19.065 s [19.065 s, 19.065 s] 3.47 s (22.3%)
iast_GLOBAL 17.997 s [17.997 s, 17.997 s] 2.402 s (15.4%)
profiling 15.011 s [15.011 s, 15.011 s] -584.0 ms (-3.7%)
tracing 14.808 s [14.808 s, 14.808 s] -787.0 ms (-5.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.985 s [14.985 s, 14.985 s] -
appsec 15.249 s [15.249 s, 15.249 s] 264.0 ms (1.8%)
iast 18.292 s [18.292 s, 18.292 s] 3.307 s (22.1%)
iast_GLOBAL 18.219 s [18.219 s, 18.219 s] 3.234 s (21.6%)
profiling 15.156 s [15.156 s, 15.156 s] 171.0 ms (1.1%)
tracing 14.915 s [14.915 s, 14.915 s] -70.0 ms (-0.5%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~859df2016e, baseline=1.47.0-SNAPSHOT~5b9a331fd8
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.472 ms) : 1461, 1484
.   : milestone, 1472,
appsec (2.36 ms) : 2317, 2404
.   : milestone, 2360,
iast (2.113 ms) : 2057, 2169
.   : milestone, 2113,
iast_GLOBAL (2.161 ms) : 2105, 2217
.   : milestone, 2161,
profiling (1.982 ms) : 1937, 2026
.   : milestone, 1982,
tracing (1.948 ms) : 1905, 1990
.   : milestone, 1948,
section candidate
no_agent (1.472 ms) : 1460, 1483
.   : milestone, 1472,
appsec (2.357 ms) : 2314, 2401
.   : milestone, 2357,
iast (2.11 ms) : 2055, 2165
.   : milestone, 2110,
iast_GLOBAL (2.153 ms) : 2098, 2208
.   : milestone, 2153,
profiling (1.96 ms) : 1916, 2003
.   : milestone, 1960,
tracing (1.942 ms) : 1899, 1984
.   : milestone, 1942,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.472 ms [1.461 ms, 1.484 ms] -
appsec 2.36 ms [2.317 ms, 2.404 ms] 888.152 µs (60.3%)
iast 2.113 ms [2.057 ms, 2.169 ms] 640.943 µs (43.5%)
iast_GLOBAL 2.161 ms [2.105 ms, 2.217 ms] 689.109 µs (46.8%)
profiling 1.982 ms [1.937 ms, 2.026 ms] 509.466 µs (34.6%)
tracing 1.948 ms [1.905 ms, 1.99 ms] 475.685 µs (32.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.472 ms [1.46 ms, 1.483 ms] -
appsec 2.357 ms [2.314 ms, 2.401 ms] 885.575 µs (60.2%)
iast 2.11 ms [2.055 ms, 2.165 ms] 638.245 µs (43.4%)
iast_GLOBAL 2.153 ms [2.098 ms, 2.208 ms] 680.837 µs (46.3%)
profiling 1.96 ms [1.916 ms, 2.003 ms] 487.77 µs (33.1%)
tracing 1.942 ms [1.899 ms, 1.984 ms] 469.686 µs (31.9%)

@jandro996 jandro996 marked this pull request as ready for review February 18, 2025 06:27
@jandro996 jandro996 requested a review from a team as a code owner February 18, 2025 06:27
@jandro996 jandro996 merged commit eeba960 into master Feb 18, 2025
@jandro996 jandro996 deleted the alejandro.gonzalez/empty-product-change-bug branch February 18, 2025 08:49
@github-actions github-actions Bot added this to the 1.47.0 milestone Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manuel-alvarez-alvarez manuel-alvarez-alvarez manuel-alvarez-alvarez approved these changes

Assignees

No one assigned

Labels

comp: telemetry Telemetry tag: no release notes Changes to exclude from release notes type: bug Bug report and fix

Projects

None yet

Milestone

1.47.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jandro996 @manuel-alvarez-alvarez