Skip to content

Computes cutoff/threshold once in DeterministicSampler.#8395

Merged
yuanyuanzhao3 merged 2 commits intomasterfrom
yuanyuan.zhao/deterministic-sampler
Feb 26, 2025
Merged

Computes cutoff/threshold once in DeterministicSampler.#8395
yuanyuanzhao3 merged 2 commits intomasterfrom
yuanyuan.zhao/deterministic-sampler

Conversation

@yuanyuanzhao3
Copy link
Copy Markdown
Contributor

@yuanyuanzhao3 yuanyuanzhao3 commented Feb 15, 2025

What Does This Do

Computes cutoff/threshold of the DeterministicSampler only once in constructor.

Motivation

More efficient.

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@yuanyuanzhao3 yuanyuanzhao3 added the type: enhancement Enhancements and improvements label Feb 15, 2025
@yuanyuanzhao3 yuanyuanzhao3 requested a review from a team as a code owner February 15, 2025 03:22
@yuanyuanzhao3 yuanyuanzhao3 requested a review from smola February 15, 2025 03:22
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 15, 2025

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@yuanyuanzhao3 yuanyuanzhao3 added the tag: no release notes Changes to exclude from release notes label Feb 15, 2025
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Feb 15, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master yuanyuan.zhao/deterministic-sampler
git_commit_date 1740587569 1740591462
git_commit_sha ea9e744 f28115c
release_version 1.47.0-SNAPSHOT~ea9e744092 1.47.0-SNAPSHOT~f28115c684
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1740593876 1740593876
ci_job_id 824486990 824486990
ci_pipeline_id 57087029 57087029
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-vtotqy1x-project-304-concurrent-0-0hqqmteb 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-vtotqy1x-project-304-concurrent-0-0hqqmteb 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 4 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~f28115c684, baseline=1.47.0-SNAPSHOT~ea9e744092

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1045529
Total [baseline] (10.629 s) : 0, 10629141
Agent [candidate] (1.053 s) : 0, 1052678
Total [candidate] (10.399 s) : 0, 10399385
section appsec
Agent [baseline] (1.18 s) : 0, 1180348
Total [baseline] (10.758 s) : 0, 10757984
Agent [candidate] (1.182 s) : 0, 1181660
Total [candidate] (10.795 s) : 0, 10794673
section iast
Agent [baseline] (1.177 s) : 0, 1176574
Total [baseline] (11.011 s) : 0, 11011438
Agent [candidate] (1.167 s) : 0, 1167215
Total [candidate] (10.953 s) : 0, 10952947
section profiling
Agent [baseline] (1.26 s) : 0, 1259775
Total [baseline] (10.827 s) : 0, 10827334
Agent [candidate] (1.262 s) : 0, 1261754
Total [candidate] (10.846 s) : 0, 10846239
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.046 s -
Agent appsec 1.18 s 134.819 ms (12.9%)
Agent iast 1.177 s 131.045 ms (12.5%)
Agent profiling 1.26 s 214.246 ms (20.5%)
Total tracing 10.629 s -
Total appsec 10.758 s 128.843 ms (1.2%)
Total iast 11.011 s 382.296 ms (3.6%)
Total profiling 10.827 s 198.193 ms (1.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.053 s -
Agent appsec 1.182 s 128.983 ms (12.3%)
Agent iast 1.167 s 114.538 ms (10.9%)
Agent profiling 1.262 s 209.076 ms (19.9%)
Total tracing 10.399 s -
Total appsec 10.795 s 395.288 ms (3.8%)
Total iast 10.953 s 553.562 ms (5.3%)
Total profiling 10.846 s 446.854 ms (4.3%) 
gantt
    title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~f28115c684, baseline=1.47.0-SNAPSHOT~ea9e744092

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (721.308 ms) : 0, 721308
BytebuddyAgent [candidate] (725.549 ms) : 0, 725549
GlobalTracer [baseline] (242.051 ms) : 0, 242051
GlobalTracer [candidate] (241.517 ms) : 0, 241517
AppSec [baseline] (56.204 ms) : 0, 56204
AppSec [candidate] (56.055 ms) : 0, 56055
Remote Config [baseline] (703.382 µs) : 0, 703
Remote Config [candidate] (703.753 µs) : 0, 704
Telemetry [baseline] (10.151 ms) : 0, 10151
Telemetry [candidate] (13.688 ms) : 0, 13688
section appsec
BytebuddyAgent [baseline] (732.874 ms) : 0, 732874
BytebuddyAgent [candidate] (733.1 ms) : 0, 733100
GlobalTracer [baseline] (235.602 ms) : 0, 235602
GlobalTracer [candidate] (236.559 ms) : 0, 236559
IAST [baseline] (21.697 ms) : 0, 21697
IAST [candidate] (21.581 ms) : 0, 21581
AppSec [baseline] (177.177 ms) : 0, 177177
AppSec [candidate] (177.281 ms) : 0, 177281
Remote Config [baseline] (651.371 µs) : 0, 651
Remote Config [candidate] (658.663 µs) : 0, 659
Telemetry [baseline] (8.279 ms) : 0, 8279
Telemetry [candidate] (8.308 ms) : 0, 8308
section iast
BytebuddyAgent [baseline] (841.528 ms) : 0, 841528
BytebuddyAgent [candidate] (834.217 ms) : 0, 834217
GlobalTracer [baseline] (229.752 ms) : 0, 229752
GlobalTracer [candidate] (229.392 ms) : 0, 229392
IAST [baseline] (22.756 ms) : 0, 22756
IAST [candidate] (22.72 ms) : 0, 22720
AppSec [baseline] (57.959 ms) : 0, 57959
AppSec [candidate] (56.667 ms) : 0, 56667
Remote Config [baseline] (623.933 µs) : 0, 624
Remote Config [candidate] (620.382 µs) : 0, 620
Telemetry [baseline] (8.923 ms) : 0, 8923
Telemetry [candidate] (8.677 ms) : 0, 8677
section profiling
BytebuddyAgent [baseline] (707.622 ms) : 0, 707622
BytebuddyAgent [candidate] (709.336 ms) : 0, 709336
GlobalTracer [baseline] (349.312 ms) : 0, 349312
GlobalTracer [candidate] (350.669 ms) : 0, 350669
AppSec [baseline] (55.615 ms) : 0, 55615
AppSec [candidate] (55.125 ms) : 0, 55125
Remote Config [baseline] (670.835 µs) : 0, 671
Remote Config [candidate] (671.19 µs) : 0, 671
Telemetry [baseline] (8.914 ms) : 0, 8914
Telemetry [candidate] (8.915 ms) : 0, 8915
ProfilingAgent [baseline] (97.4 ms) : 0, 97400
ProfilingAgent [candidate] (96.599 ms) : 0, 96599
Profiling [baseline] (97.425 ms) : 0, 97425
Profiling [candidate] (96.624 ms) : 0, 96624
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~f28115c684, baseline=1.47.0-SNAPSHOT~ea9e744092

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.039 s) : 0, 1039466
Total [baseline] (8.662 s) : 0, 8661539
Agent [candidate] (1.044 s) : 0, 1044365
Total [candidate] (8.673 s) : 0, 8672865
section iast
Agent [baseline] (1.165 s) : 0, 1165316
Total [baseline] (9.186 s) : 0, 9186119
Agent [candidate] (1.169 s) : 0, 1168647
Total [candidate] (9.238 s) : 0, 9238180
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.168 s) : 0, 1167910
Total [baseline] (9.21 s) : 0, 9210492
Agent [candidate] (1.172 s) : 0, 1171644
Total [candidate] (9.203 s) : 0, 9202997
section iast_TELEMETRY_OFF
Agent [baseline] (1.168 s) : 0, 1168037
Total [baseline] (9.22 s) : 0, 9219915
Agent [candidate] (1.175 s) : 0, 1175072
Total [candidate] (9.238 s) : 0, 9237869
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.039 s -
Agent iast 1.165 s 125.85 ms (12.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.168 s 128.444 ms (12.4%)
Agent iast_TELEMETRY_OFF 1.168 s 128.57 ms (12.4%)
Total tracing 8.662 s -
Total iast 9.186 s 524.58 ms (6.1%)
Total iast_HARDCODED_SECRET_DISABLED 9.21 s 548.952 ms (6.3%)
Total iast_TELEMETRY_OFF 9.22 s 558.376 ms (6.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.044 s -
Agent iast 1.169 s 124.282 ms (11.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.172 s 127.279 ms (12.2%)
Agent iast_TELEMETRY_OFF 1.175 s 130.707 ms (12.5%)
Total tracing 8.673 s -
Total iast 9.238 s 565.315 ms (6.5%)
Total iast_HARDCODED_SECRET_DISABLED 9.203 s 530.132 ms (6.1%)
Total iast_TELEMETRY_OFF 9.238 s 565.003 ms (6.5%) 
gantt
    title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~f28115c684, baseline=1.47.0-SNAPSHOT~ea9e744092

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.364 ms) : 0, 717364
BytebuddyAgent [candidate] (720.604 ms) : 0, 720604
GlobalTracer [baseline] (238.49 ms) : 0, 238490
GlobalTracer [candidate] (240.046 ms) : 0, 240046
AppSec [baseline] (55.766 ms) : 0, 55766
AppSec [candidate] (55.787 ms) : 0, 55787
Remote Config [baseline] (693.787 µs) : 0, 694
Remote Config [candidate] (694.689 µs) : 0, 695
Telemetry [baseline] (12.159 ms) : 0, 12159
Telemetry [candidate] (12.207 ms) : 0, 12207
section iast
BytebuddyAgent [baseline] (832.435 ms) : 0, 832435
BytebuddyAgent [candidate] (835.23 ms) : 0, 835230
GlobalTracer [baseline] (229.065 ms) : 0, 229065
GlobalTracer [candidate] (229.794 ms) : 0, 229794
IAST [baseline] (22.548 ms) : 0, 22548
IAST [candidate] (22.513 ms) : 0, 22513
AppSec [baseline] (57.07 ms) : 0, 57070
AppSec [candidate] (56.976 ms) : 0, 56976
Remote Config [baseline] (610.373 µs) : 0, 610
Remote Config [candidate] (607.105 µs) : 0, 607
Telemetry [baseline] (8.687 ms) : 0, 8687
Telemetry [candidate] (8.674 ms) : 0, 8674
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (834.245 ms) : 0, 834245
BytebuddyAgent [candidate] (836.542 ms) : 0, 836542
GlobalTracer [baseline] (229.257 ms) : 0, 229257
GlobalTracer [candidate] (230.32 ms) : 0, 230320
IAST [baseline] (22.82 ms) : 0, 22820
IAST [candidate] (22.942 ms) : 0, 22942
AppSec [baseline] (57.372 ms) : 0, 57372
AppSec [candidate] (57.391 ms) : 0, 57391
Remote Config [baseline] (608.643 µs) : 0, 609
Remote Config [candidate] (621.318 µs) : 0, 621
Telemetry [baseline] (8.564 ms) : 0, 8564
Telemetry [candidate] (8.797 ms) : 0, 8797
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (836.063 ms) : 0, 836063
BytebuddyAgent [candidate] (839.228 ms) : 0, 839228
GlobalTracer [baseline] (228.953 ms) : 0, 228953
GlobalTracer [candidate] (231.697 ms) : 0, 231697
IAST [baseline] (25.228 ms) : 0, 25228
IAST [candidate] (24.802 ms) : 0, 24802
AppSec [baseline] (53.653 ms) : 0, 53653
AppSec [candidate] (55.115 ms) : 0, 55115
Remote Config [baseline] (602.745 µs) : 0, 603
Remote Config [candidate] (631.895 µs) : 0, 632
Telemetry [baseline] (8.569 ms) : 0, 8569
Telemetry [candidate] (8.602 ms) : 0, 8602
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-02-26T17:48:03 2025-02-26T17:55:47
git_branch master yuanyuan.zhao/deterministic-sampler
git_commit_date 1740587569 1740591462
git_commit_sha ea9e744 f28115c
release_version 1.47.0-SNAPSHOT~ea9e744092 1.47.0-SNAPSHOT~f28115c684
start_time 2025-02-26T17:47:49 2025-02-26T17:55:33
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1740592946 1740592946
ci_job_id 824486992 824486992
ci_pipeline_id 57087029 57087029
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-gyqeaxyt-project-304-concurrent-0-m15rw2dy 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-gyqeaxyt-project-304-concurrent-0-m15rw2dy 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~f28115c684, baseline=1.47.0-SNAPSHOT~ea9e744092
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.372 ms) : 1351, 1392
.   : milestone, 1372,
appsec (1.761 ms) : 1737, 1784
.   : milestone, 1761,
appsec_no_iast (1.745 ms) : 1717, 1773
.   : milestone, 1745,
code_origins (1.688 ms) : 1654, 1722
.   : milestone, 1688,
iast (1.518 ms) : 1494, 1542
.   : milestone, 1518,
profiling (1.495 ms) : 1471, 1518
.   : milestone, 1495,
tracing (1.486 ms) : 1461, 1511
.   : milestone, 1486,
section candidate
no_agent (1.343 ms) : 1324, 1363
.   : milestone, 1343,
appsec (1.748 ms) : 1725, 1772
.   : milestone, 1748,
appsec_no_iast (1.745 ms) : 1720, 1770
.   : milestone, 1745,
code_origins (1.672 ms) : 1638, 1706
.   : milestone, 1672,
iast (1.512 ms) : 1488, 1537
.   : milestone, 1512,
profiling (1.551 ms) : 1525, 1576
.   : milestone, 1551,
tracing (1.504 ms) : 1479, 1528
.   : milestone, 1504,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.372 ms [1.351 ms, 1.392 ms] -
appsec 1.761 ms [1.737 ms, 1.784 ms] 388.817 µs (28.3%)
appsec_no_iast 1.745 ms [1.717 ms, 1.773 ms] 372.946 µs (27.2%)
code_origins 1.688 ms [1.654 ms, 1.722 ms] 316.155 µs (23.0%)
iast 1.518 ms [1.494 ms, 1.542 ms] 146.526 µs (10.7%)
profiling 1.495 ms [1.471 ms, 1.518 ms] 122.781 µs (9.0%)
tracing 1.486 ms [1.461 ms, 1.511 ms] 114.567 µs (8.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.343 ms [1.324 ms, 1.363 ms] -
appsec 1.748 ms [1.725 ms, 1.772 ms] 405.05 µs (30.2%)
appsec_no_iast 1.745 ms [1.72 ms, 1.77 ms] 402.043 µs (29.9%)
code_origins 1.672 ms [1.638 ms, 1.706 ms] 329.199 µs (24.5%)
iast 1.512 ms [1.488 ms, 1.537 ms] 169.059 µs (12.6%)
profiling 1.551 ms [1.525 ms, 1.576 ms] 207.427 µs (15.4%)
tracing 1.504 ms [1.479 ms, 1.528 ms] 160.366 µs (11.9%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~f28115c684, baseline=1.47.0-SNAPSHOT~ea9e744092
    dateFormat X
    axisFormat %s
section baseline
no_agent (378.219 µs) : 358, 398
.   : milestone, 378,
iast (512.017 µs) : 490, 534
.   : milestone, 512,
iast_FULL (727.897 µs) : 706, 750
.   : milestone, 728,
iast_GLOBAL (554.919 µs) : 533, 577
.   : milestone, 555,
iast_HARDCODED_SECRET_DISABLED (508.773 µs) : 487, 531
.   : milestone, 509,
iast_INACTIVE (463.13 µs) : 442, 485
.   : milestone, 463,
iast_TELEMETRY_OFF (498.976 µs) : 476, 522
.   : milestone, 499,
tracing (458.439 µs) : 437, 480
.   : milestone, 458,
section candidate
no_agent (383.719 µs) : 364, 404
.   : milestone, 384,
iast (509.347 µs) : 487, 532
.   : milestone, 509,
iast_FULL (730.634 µs) : 709, 753
.   : milestone, 731,
iast_GLOBAL (556.494 µs) : 535, 578
.   : milestone, 556,
iast_HARDCODED_SECRET_DISABLED (515.458 µs) : 493, 538
.   : milestone, 515,
iast_INACTIVE (458.262 µs) : 437, 480
.   : milestone, 458,
iast_TELEMETRY_OFF (496.695 µs) : 475, 518
.   : milestone, 497,
tracing (460.544 µs) : 440, 481
.   : milestone, 461,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 378.219 µs [358.213 µs, 398.225 µs] -
iast 512.017 µs [490.147 µs, 533.888 µs] 133.798 µs (35.4%)
iast_FULL 727.897 µs [705.942 µs, 749.852 µs] 349.678 µs (92.5%)
iast_GLOBAL 554.919 µs [533.277 µs, 576.561 µs] 176.7 µs (46.7%)
iast_HARDCODED_SECRET_DISABLED 508.773 µs [486.95 µs, 530.597 µs] 130.554 µs (34.5%)
iast_INACTIVE 463.13 µs [441.723 µs, 484.536 µs] 84.91 µs (22.5%)
iast_TELEMETRY_OFF 498.976 µs [475.558 µs, 522.394 µs] 120.757 µs (31.9%)
tracing 458.439 µs [437.222 µs, 479.656 µs] 80.22 µs (21.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 383.719 µs [363.769 µs, 403.669 µs] -
iast 509.347 µs [486.82 µs, 531.875 µs] 125.628 µs (32.7%)
iast_FULL 730.634 µs [708.564 µs, 752.705 µs] 346.915 µs (90.4%)
iast_GLOBAL 556.494 µs [534.759 µs, 578.229 µs] 172.774 µs (45.0%)
iast_HARDCODED_SECRET_DISABLED 515.458 µs [492.809 µs, 538.107 µs] 131.739 µs (34.3%)
iast_INACTIVE 458.262 µs [436.893 µs, 479.631 µs] 74.543 µs (19.4%)
iast_TELEMETRY_OFF 496.695 µs [474.986 µs, 518.404 µs] 112.976 µs (29.4%)
tracing 460.544 µs [439.681 µs, 481.407 µs] 76.825 µs (20.0%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master yuanyuan.zhao/deterministic-sampler
git_commit_date 1740587569 1740591462
git_commit_sha ea9e744 f28115c
release_version 1.47.0-SNAPSHOT~ea9e744092 1.47.0-SNAPSHOT~f28115c684
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1740593479 1740593479
ci_job_id 824486994 824486994
ci_pipeline_id 57087029 57087029
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-vtotqy1x-project-304-concurrent-1-tztsekv6 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-vtotqy1x-project-304-concurrent-1-tztsekv6 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~f28115c684, baseline=1.47.0-SNAPSHOT~ea9e744092
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.987 s) : 14987000, 14987000
.   : milestone, 14987000,
appsec (15.026 s) : 15026000, 15026000
.   : milestone, 15026000,
iast (18.881 s) : 18881000, 18881000
.   : milestone, 18881000,
iast_GLOBAL (18.326 s) : 18326000, 18326000
.   : milestone, 18326000,
profiling (14.847 s) : 14847000, 14847000
.   : milestone, 14847000,
tracing (14.908 s) : 14908000, 14908000
.   : milestone, 14908000,
section candidate
no_agent (15.258 s) : 15258000, 15258000
.   : milestone, 15258000,
appsec (14.766 s) : 14766000, 14766000
.   : milestone, 14766000,
iast (18.379 s) : 18379000, 18379000
.   : milestone, 18379000,
iast_GLOBAL (17.92 s) : 17920000, 17920000
.   : milestone, 17920000,
profiling (15.094 s) : 15094000, 15094000
.   : milestone, 15094000,
tracing (14.659 s) : 14659000, 14659000
.   : milestone, 14659000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.987 s [14.987 s, 14.987 s] -
appsec 15.026 s [15.026 s, 15.026 s] 39.0 ms (0.3%)
iast 18.881 s [18.881 s, 18.881 s] 3.894 s (26.0%)
iast_GLOBAL 18.326 s [18.326 s, 18.326 s] 3.339 s (22.3%)
profiling 14.847 s [14.847 s, 14.847 s] -140.0 ms (-0.9%)
tracing 14.908 s [14.908 s, 14.908 s] -79.0 ms (-0.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.258 s [15.258 s, 15.258 s] -
appsec 14.766 s [14.766 s, 14.766 s] -492.0 ms (-3.2%)
iast 18.379 s [18.379 s, 18.379 s] 3.121 s (20.5%)
iast_GLOBAL 17.92 s [17.92 s, 17.92 s] 2.662 s (17.4%)
profiling 15.094 s [15.094 s, 15.094 s] -164.0 ms (-1.1%)
tracing 14.659 s [14.659 s, 14.659 s] -599.0 ms (-3.9%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~f28115c684, baseline=1.47.0-SNAPSHOT~ea9e744092
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.468 ms) : 1457, 1480
.   : milestone, 1468,
appsec (2.361 ms) : 2318, 2404
.   : milestone, 2361,
iast (2.104 ms) : 2049, 2159
.   : milestone, 2104,
iast_GLOBAL (2.148 ms) : 2093, 2203
.   : milestone, 2148,
profiling (1.988 ms) : 1944, 2033
.   : milestone, 1988,
tracing (1.932 ms) : 1890, 1973
.   : milestone, 1932,
section candidate
no_agent (1.475 ms) : 1464, 1487
.   : milestone, 1475,
appsec (2.357 ms) : 2314, 2401
.   : milestone, 2357,
iast (2.112 ms) : 2057, 2167
.   : milestone, 2112,
iast_GLOBAL (2.153 ms) : 2098, 2209
.   : milestone, 2153,
profiling (1.958 ms) : 1915, 2001
.   : milestone, 1958,
tracing (1.943 ms) : 1900, 1985
.   : milestone, 1943,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.468 ms [1.457 ms, 1.48 ms] -
appsec 2.361 ms [2.318 ms, 2.404 ms] 892.485 µs (60.8%)
iast 2.104 ms [2.049 ms, 2.159 ms] 635.459 µs (43.3%)
iast_GLOBAL 2.148 ms [2.093 ms, 2.203 ms] 679.573 µs (46.3%)
profiling 1.988 ms [1.944 ms, 2.033 ms] 520.109 µs (35.4%)
tracing 1.932 ms [1.89 ms, 1.973 ms] 463.425 µs (31.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.475 ms [1.464 ms, 1.487 ms] -
appsec 2.357 ms [2.314 ms, 2.401 ms] 882.087 µs (59.8%)
iast 2.112 ms [2.057 ms, 2.167 ms] 636.738 µs (43.2%)
iast_GLOBAL 2.153 ms [2.098 ms, 2.209 ms] 678.133 µs (46.0%)
profiling 1.958 ms [1.915 ms, 2.001 ms] 482.817 µs (32.7%)
tracing 1.943 ms [1.9 ms, 1.985 ms] 467.302 µs (31.7%)

PerfectSlayer
PerfectSlayer approved these changes Feb 21, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense. Thanks for the improvement

@yuanyuanzhao3 yuanyuanzhao3 merged commit 9e4966b into master Feb 26, 2025
@yuanyuanzhao3 yuanyuanzhao3 deleted the yuanyuan.zhao/deterministic-sampler branch February 26, 2025 19:52
@github-actions github-actions Bot added this to the 1.47.0 milestone Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smola smola smola approved these changes

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

Assignees

No one assigned

Labels

tag: no release notes Changes to exclude from release notes type: enhancement Enhancements and improvements

Projects

None yet

Milestone

1.47.0

Development

Successfully merging this pull request may close these issues.

3 participants

@yuanyuanzhao3 @smola @PerfectSlayer