Fix service name overrides in consumers by piochelepiotr · Pull Request #8387 · DataDog/dd-trace-java

piochelepiotr · 2025-02-14T02:58:19Z

What Does This Do

Service name override used to be fixed in Extractor / Propagator, which are not created in the same thread as the thread where extraction is happening.
This lead to incorrect service name overrides.

This was reported as a bug on Snowflake sink connectors, where we failed to override service names properly.

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

github-actions · 2025-02-14T02:58:32Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

pr-commenter · 2025-02-14T03:40:25Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	piotr-wolski/data-streams-fix-bug-service-name-override
git_commit_date	1739907811	1739916166
git_commit_sha	`5b7780b`	`0b0527f`
release_version	1.47.0-SNAPSHOT~5b7780bc05	1.47.0-SNAPSHOT~0b0527fc85

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1739918627	1739918627
ci_job_id	813056016	813056016
ci_pipeline_id	56223907	56223907
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-e4e1bto-project-304-concurrent-0-4ne5vgs5 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-e4e1bto-project-304-concurrent-0-4ne5vgs5 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 5 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~0b0527fc85, baseline=1.47.0-SNAPSHOT~5b7780bc05

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1047105
Total [baseline] (8.673 s) : 0, 8672572
Agent [candidate] (1.04 s) : 0, 1039961
Total [candidate] (8.66 s) : 0, 8660255
section iast
Agent [baseline] (1.168 s) : 0, 1167778
Total [baseline] (9.233 s) : 0, 9233200
Agent [candidate] (1.185 s) : 0, 1184683
Total [candidate] (9.325 s) : 0, 9325131
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.172 s) : 0, 1172387
Total [baseline] (9.202 s) : 0, 9202384
Agent [candidate] (1.179 s) : 0, 1178967
Total [candidate] (9.258 s) : 0, 9257876
section iast_TELEMETRY_OFF
Agent [baseline] (1.174 s) : 0, 1174379
Total [baseline] (9.27 s) : 0, 9269883
Agent [candidate] (1.17 s) : 0, 1169914
Total [candidate] (9.21 s) : 0, 9209954

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.047 s	-
Agent	iast	1.168 s	120.673 ms (11.5%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.172 s	125.282 ms (12.0%)
Agent	iast_TELEMETRY_OFF	1.174 s	127.274 ms (12.2%)
Total	tracing	8.673 s	-
Total	iast	9.233 s	560.628 ms (6.5%)
Total	iast_HARDCODED_SECRET_DISABLED	9.202 s	529.812 ms (6.1%)
Total	iast_TELEMETRY_OFF	9.27 s	597.311 ms (6.9%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.04 s	-
Agent	iast	1.185 s	144.722 ms (13.9%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.179 s	139.006 ms (13.4%)
Agent	iast_TELEMETRY_OFF	1.17 s	129.953 ms (12.5%)
Total	tracing	8.66 s	-
Total	iast	9.325 s	664.877 ms (7.7%)
Total	iast_HARDCODED_SECRET_DISABLED	9.258 s	597.622 ms (6.9%)
Total	iast_TELEMETRY_OFF	9.21 s	549.7 ms (6.3%)

gantt
    title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~0b0527fc85, baseline=1.47.0-SNAPSHOT~5b7780bc05

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (721.89 ms) : 0, 721890
BytebuddyAgent [candidate] (715.624 ms) : 0, 715624
GlobalTracer [baseline] (241.074 ms) : 0, 241074
GlobalTracer [candidate] (241.105 ms) : 0, 241105
AppSec [baseline] (55.804 ms) : 0, 55804
AppSec [candidate] (55.361 ms) : 0, 55361
Remote Config [baseline] (697.167 µs) : 0, 697
Remote Config [candidate] (707.033 µs) : 0, 707
Telemetry [baseline] (12.349 ms) : 0, 12349
Telemetry [candidate] (12.077 ms) : 0, 12077
section iast
BytebuddyAgent [baseline] (834.11 ms) : 0, 834110
BytebuddyAgent [candidate] (844.355 ms) : 0, 844355
GlobalTracer [baseline] (229.827 ms) : 0, 229827
GlobalTracer [candidate] (234.709 ms) : 0, 234709
IAST [baseline] (22.736 ms) : 0, 22736
IAST [candidate] (23.331 ms) : 0, 23331
AppSec [baseline] (56.744 ms) : 0, 56744
AppSec [candidate] (57.54 ms) : 0, 57540
Remote Config [baseline] (599.642 µs) : 0, 600
Remote Config [candidate] (616.918 µs) : 0, 617
Telemetry [baseline] (8.606 ms) : 0, 8606
Telemetry [candidate] (8.83 ms) : 0, 8830
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (837.0 ms) : 0, 837000
BytebuddyAgent [candidate] (840.804 ms) : 0, 840804
GlobalTracer [baseline] (231.252 ms) : 0, 231252
GlobalTracer [candidate] (232.976 ms) : 0, 232976
IAST [baseline] (22.719 ms) : 0, 22719
IAST [candidate] (22.946 ms) : 0, 22946
AppSec [baseline] (56.834 ms) : 0, 56834
AppSec [candidate] (57.455 ms) : 0, 57455
Remote Config [baseline] (597.471 µs) : 0, 597
Remote Config [candidate] (623.887 µs) : 0, 624
Telemetry [baseline] (8.674 ms) : 0, 8674
Telemetry [candidate] (8.773 ms) : 0, 8773
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (838.864 ms) : 0, 838864
BytebuddyAgent [candidate] (834.882 ms) : 0, 834882
GlobalTracer [baseline] (231.335 ms) : 0, 231335
GlobalTracer [candidate] (231.657 ms) : 0, 231657
IAST [baseline] (24.122 ms) : 0, 24122
IAST [candidate] (24.55 ms) : 0, 24550
AppSec [baseline] (55.43 ms) : 0, 55430
AppSec [candidate] (54.412 ms) : 0, 54412
Remote Config [baseline] (613.727 µs) : 0, 614
Remote Config [candidate] (601.701 µs) : 0, 602
Telemetry [baseline] (8.703 ms) : 0, 8703
Telemetry [candidate] (8.593 ms) : 0, 8593

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~0b0527fc85, baseline=1.47.0-SNAPSHOT~5b7780bc05

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.042 s) : 0, 1041650
Total [baseline] (10.466 s) : 0, 10466212
Agent [candidate] (1.042 s) : 0, 1042101
Total [candidate] (10.446 s) : 0, 10445556
section appsec
Agent [baseline] (1.184 s) : 0, 1183916
Total [baseline] (10.756 s) : 0, 10756196
Agent [candidate] (1.184 s) : 0, 1183655
Total [candidate] (10.729 s) : 0, 10729281
section iast
Agent [baseline] (1.171 s) : 0, 1170935
Total [baseline] (10.959 s) : 0, 10958676
Agent [candidate] (1.177 s) : 0, 1176609
Total [candidate] (10.988 s) : 0, 10987720
section profiling
Agent [baseline] (1.259 s) : 0, 1259217
Total [baseline] (10.936 s) : 0, 10935665
Agent [candidate] (1.262 s) : 0, 1262201
Total [candidate] (10.892 s) : 0, 10892182

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.042 s	-
Agent	appsec	1.184 s	142.266 ms (13.7%)
Agent	iast	1.171 s	129.285 ms (12.4%)
Agent	profiling	1.259 s	217.567 ms (20.9%)
Total	tracing	10.466 s	-
Total	appsec	10.756 s	289.983 ms (2.8%)
Total	iast	10.959 s	492.464 ms (4.7%)
Total	profiling	10.936 s	469.453 ms (4.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.042 s	-
Agent	appsec	1.184 s	141.554 ms (13.6%)
Agent	iast	1.177 s	134.508 ms (12.9%)
Agent	profiling	1.262 s	220.099 ms (21.1%)
Total	tracing	10.446 s	-
Total	appsec	10.729 s	283.725 ms (2.7%)
Total	iast	10.988 s	542.164 ms (5.2%)
Total	profiling	10.892 s	446.627 ms (4.3%)

gantt
    title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~0b0527fc85, baseline=1.47.0-SNAPSHOT~5b7780bc05

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.149 ms) : 0, 718149
BytebuddyAgent [candidate] (716.847 ms) : 0, 716847
GlobalTracer [baseline] (239.988 ms) : 0, 239988
GlobalTracer [candidate] (241.161 ms) : 0, 241161
AppSec [baseline] (55.299 ms) : 0, 55299
AppSec [candidate] (55.339 ms) : 0, 55339
Remote Config [baseline] (688.4 µs) : 0, 688
Remote Config [candidate] (705.495 µs) : 0, 705
Telemetry [baseline] (12.217 ms) : 0, 12217
Telemetry [candidate] (12.898 ms) : 0, 12898
section appsec
BytebuddyAgent [baseline] (734.911 ms) : 0, 734911
BytebuddyAgent [candidate] (734.475 ms) : 0, 734475
GlobalTracer [baseline] (237.123 ms) : 0, 237123
GlobalTracer [candidate] (237.873 ms) : 0, 237873
AppSec [baseline] (177.027 ms) : 0, 177027
AppSec [candidate] (176.343 ms) : 0, 176343
Remote Config [baseline] (658.356 µs) : 0, 658
Remote Config [candidate] (650.018 µs) : 0, 650
Telemetry [baseline] (8.229 ms) : 0, 8229
Telemetry [candidate] (8.241 ms) : 0, 8241
IAST [baseline] (21.543 ms) : 0, 21543
IAST [candidate] (21.637 ms) : 0, 21637
section iast
BytebuddyAgent [baseline] (836.609 ms) : 0, 836609
BytebuddyAgent [candidate] (839.265 ms) : 0, 839265
GlobalTracer [baseline] (230.473 ms) : 0, 230473
GlobalTracer [candidate] (232.197 ms) : 0, 232197
AppSec [baseline] (56.699 ms) : 0, 56699
AppSec [candidate] (57.448 ms) : 0, 57448
Remote Config [baseline] (599.255 µs) : 0, 599
Remote Config [candidate] (618.758 µs) : 0, 619
Telemetry [baseline] (8.658 ms) : 0, 8658
Telemetry [candidate] (8.727 ms) : 0, 8727
IAST [baseline] (22.586 ms) : 0, 22586
IAST [candidate] (23.017 ms) : 0, 23017
section profiling
BytebuddyAgent [baseline] (707.038 ms) : 0, 707038
BytebuddyAgent [candidate] (707.965 ms) : 0, 707965
GlobalTracer [baseline] (349.439 ms) : 0, 349439
GlobalTracer [candidate] (351.595 ms) : 0, 351595
AppSec [baseline] (55.627 ms) : 0, 55627
AppSec [candidate] (54.626 ms) : 0, 54626
Remote Config [baseline] (683.155 µs) : 0, 683
Remote Config [candidate] (697.14 µs) : 0, 697
Telemetry [baseline] (8.872 ms) : 0, 8872
Telemetry [candidate] (8.888 ms) : 0, 8888
ProfilingAgent [baseline] (95.255 ms) : 0, 95255
ProfilingAgent [candidate] (96.005 ms) : 0, 96005
Profiling [baseline] (95.28 ms) : 0, 95280
Profiling [candidate] (96.029 ms) : 0, 96029

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-02-18T22:13:40	2025-02-18T22:20:42
git_branch	master	piotr-wolski/data-streams-fix-bug-service-name-override
git_commit_date	1739907811	1739916166
git_commit_sha	`5b7780b`	`0b0527f`
release_version	1.47.0-SNAPSHOT~5b7780bc05	1.47.0-SNAPSHOT~0b0527fc85
start_time	2025-02-18T22:13:26	2025-02-18T22:20:28

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1739917600	1739917600
ci_job_id	813056017	813056017
ci_pipeline_id	56223907	56223907
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zgkpwvox-project-304-concurrent-0-pfau5wjo 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zgkpwvox-project-304-concurrent-0-pfau5wjo 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 17 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:petclinic:profiling	worse [+70.260µs; +123.129µs] or [+4.760%; +8.341%]	unstable [-692.940op/s; +465.020op/s] or [-22.521%; +15.113%]	1.573ms	2962.963op/s	1.476ms	3076.923op/s

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~0b0527fc85, baseline=1.47.0-SNAPSHOT~5b7780bc05
    dateFormat X
    axisFormat %s
section baseline
no_agent (379.531 µs) : 360, 399
.   : milestone, 380,
iast (507.142 µs) : 485, 529
.   : milestone, 507,
iast_FULL (731.974 µs) : 710, 754
.   : milestone, 732,
iast_GLOBAL (555.567 µs) : 533, 578
.   : milestone, 556,
iast_HARDCODED_SECRET_DISABLED (506.38 µs) : 484, 529
.   : milestone, 506,
iast_INACTIVE (457.533 µs) : 436, 479
.   : milestone, 458,
iast_TELEMETRY_OFF (495.622 µs) : 472, 519
.   : milestone, 496,
tracing (455.171 µs) : 432, 479
.   : milestone, 455,
section candidate
no_agent (377.642 µs) : 356, 399
.   : milestone, 378,
iast (505.572 µs) : 484, 527
.   : milestone, 506,
iast_FULL (741.206 µs) : 719, 763
.   : milestone, 741,
iast_GLOBAL (545.123 µs) : 524, 567
.   : milestone, 545,
iast_HARDCODED_SECRET_DISABLED (507.655 µs) : 485, 530
.   : milestone, 508,
iast_INACTIVE (460.237 µs) : 439, 482
.   : milestone, 460,
iast_TELEMETRY_OFF (494.973 µs) : 472, 518
.   : milestone, 495,
tracing (451.703 µs) : 430, 473
.   : milestone, 452,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	379.531 µs [359.979 µs, 399.082 µs]	-
iast	507.142 µs [485.279 µs, 529.005 µs]	127.612 µs (33.6%)
iast_FULL	731.974 µs [709.858 µs, 754.091 µs]	352.444 µs (92.9%)
iast_GLOBAL	555.567 µs [532.913 µs, 578.221 µs]	176.037 µs (46.4%)
iast_HARDCODED_SECRET_DISABLED	506.38 µs [484.174 µs, 528.586 µs]	126.85 µs (33.4%)
iast_INACTIVE	457.533 µs [436.393 µs, 478.674 µs]	78.003 µs (20.6%)
iast_TELEMETRY_OFF	495.622 µs [472.004 µs, 519.24 µs]	116.091 µs (30.6%)
tracing	455.171 µs [431.656 µs, 478.686 µs]	75.641 µs (19.9%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	377.642 µs [356.453 µs, 398.83 µs]	-
iast	505.572 µs [483.964 µs, 527.179 µs]	127.93 µs (33.9%)
iast_FULL	741.206 µs [719.062 µs, 763.349 µs]	363.564 µs (96.3%)
iast_GLOBAL	545.123 µs [523.503 µs, 566.744 µs]	167.482 µs (44.3%)
iast_HARDCODED_SECRET_DISABLED	507.655 µs [485.209 µs, 530.1 µs]	130.013 µs (34.4%)
iast_INACTIVE	460.237 µs [438.896 µs, 481.579 µs]	82.596 µs (21.9%)
iast_TELEMETRY_OFF	494.973 µs [471.55 µs, 518.396 µs]	117.332 µs (31.1%)
tracing	451.703 µs [430.246 µs, 473.159 µs]	74.061 µs (19.6%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~0b0527fc85, baseline=1.47.0-SNAPSHOT~5b7780bc05
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.329 ms) : 1310, 1349
.   : milestone, 1329,
appsec (1.772 ms) : 1750, 1795
.   : milestone, 1772,
appsec_no_iast (1.736 ms) : 1711, 1761
.   : milestone, 1736,
iast (1.496 ms) : 1472, 1519
.   : milestone, 1496,
profiling (1.476 ms) : 1452, 1500
.   : milestone, 1476,
tracing (1.475 ms) : 1450, 1499
.   : milestone, 1475,
section candidate
no_agent (1.361 ms) : 1342, 1381
.   : milestone, 1361,
appsec (1.743 ms) : 1719, 1767
.   : milestone, 1743,
appsec_no_iast (1.741 ms) : 1717, 1765
.   : milestone, 1741,
iast (1.506 ms) : 1481, 1531
.   : milestone, 1506,
profiling (1.573 ms) : 1547, 1598
.   : milestone, 1573,
tracing (1.486 ms) : 1461, 1511
.   : milestone, 1486,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.329 ms [1.31 ms, 1.349 ms]	-
appsec	1.772 ms [1.75 ms, 1.795 ms]	442.698 µs (33.3%)
appsec_no_iast	1.736 ms [1.711 ms, 1.761 ms]	406.657 µs (30.6%)
iast	1.496 ms [1.472 ms, 1.519 ms]	166.137 µs (12.5%)
profiling	1.476 ms [1.452 ms, 1.5 ms]	146.691 µs (11.0%)
tracing	1.475 ms [1.45 ms, 1.499 ms]	145.164 µs (10.9%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.361 ms [1.342 ms, 1.381 ms]	-
appsec	1.743 ms [1.719 ms, 1.767 ms]	381.582 µs (28.0%)
appsec_no_iast	1.741 ms [1.717 ms, 1.765 ms]	379.352 µs (27.9%)
iast	1.506 ms [1.481 ms, 1.531 ms]	144.767 µs (10.6%)
profiling	1.573 ms [1.547 ms, 1.598 ms]	211.497 µs (15.5%)
tracing	1.486 ms [1.461 ms, 1.511 ms]	124.951 µs (9.2%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	piotr-wolski/data-streams-fix-bug-service-name-override
git_commit_date	1739907811	1739916166
git_commit_sha	`5b7780b`	`0b0527f`
release_version	1.47.0-SNAPSHOT~5b7780bc05	1.47.0-SNAPSHOT~0b0527fc85

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1739918131	1739918131
ci_job_id	813056018	813056018
ci_pipeline_id	56223907	56223907
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-e4e1bto-project-304-concurrent-1-3rjtjec0 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-e4e1bto-project-304-concurrent-1-3rjtjec0 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~0b0527fc85, baseline=1.47.0-SNAPSHOT~5b7780bc05
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.462 s) : 15462000, 15462000
.   : milestone, 15462000,
appsec (14.991 s) : 14991000, 14991000
.   : milestone, 14991000,
iast (18.463 s) : 18463000, 18463000
.   : milestone, 18463000,
iast_GLOBAL (17.8 s) : 17800000, 17800000
.   : milestone, 17800000,
profiling (14.996 s) : 14996000, 14996000
.   : milestone, 14996000,
tracing (14.991 s) : 14991000, 14991000
.   : milestone, 14991000,
section candidate
no_agent (15.206 s) : 15206000, 15206000
.   : milestone, 15206000,
appsec (14.99 s) : 14990000, 14990000
.   : milestone, 14990000,
iast (18.494 s) : 18494000, 18494000
.   : milestone, 18494000,
iast_GLOBAL (18.049 s) : 18049000, 18049000
.   : milestone, 18049000,
profiling (15.063 s) : 15063000, 15063000
.   : milestone, 15063000,
tracing (15.203 s) : 15203000, 15203000
.   : milestone, 15203000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.462 s [15.462 s, 15.462 s]	-
appsec	14.991 s [14.991 s, 14.991 s]	-471.0 ms (-3.0%)
iast	18.463 s [18.463 s, 18.463 s]	3.001 s (19.4%)
iast_GLOBAL	17.8 s [17.8 s, 17.8 s]	2.338 s (15.1%)
profiling	14.996 s [14.996 s, 14.996 s]	-466.0 ms (-3.0%)
tracing	14.991 s [14.991 s, 14.991 s]	-471.0 ms (-3.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.206 s [15.206 s, 15.206 s]	-
appsec	14.99 s [14.99 s, 14.99 s]	-216.0 ms (-1.4%)
iast	18.494 s [18.494 s, 18.494 s]	3.288 s (21.6%)
iast_GLOBAL	18.049 s [18.049 s, 18.049 s]	2.843 s (18.7%)
profiling	15.063 s [15.063 s, 15.063 s]	-143.0 ms (-0.9%)
tracing	15.203 s [15.203 s, 15.203 s]	-3.0 ms (-0.0%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~0b0527fc85, baseline=1.47.0-SNAPSHOT~5b7780bc05
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.484 ms) : 1472, 1496
.   : milestone, 1484,
appsec (2.385 ms) : 2342, 2429
.   : milestone, 2385,
iast (2.133 ms) : 2078, 2189
.   : milestone, 2133,
iast_GLOBAL (2.167 ms) : 2111, 2223
.   : milestone, 2167,
profiling (1.999 ms) : 1953, 2044
.   : milestone, 1999,
tracing (1.969 ms) : 1926, 2012
.   : milestone, 1969,
section candidate
no_agent (1.486 ms) : 1474, 1497
.   : milestone, 1486,
appsec (2.377 ms) : 2334, 2420
.   : milestone, 2377,
iast (2.114 ms) : 2059, 2170
.   : milestone, 2114,
iast_GLOBAL (2.171 ms) : 2115, 2227
.   : milestone, 2171,
profiling (1.992 ms) : 1948, 2036
.   : milestone, 1992,
tracing (1.96 ms) : 1918, 2003
.   : milestone, 1960,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.484 ms [1.472 ms, 1.496 ms]	-
appsec	2.385 ms [2.342 ms, 2.429 ms]	901.177 µs (60.7%)
iast	2.133 ms [2.078 ms, 2.189 ms]	649.427 µs (43.8%)
iast_GLOBAL	2.167 ms [2.111 ms, 2.223 ms]	682.976 µs (46.0%)
profiling	1.999 ms [1.953 ms, 2.044 ms]	514.64 µs (34.7%)
tracing	1.969 ms [1.926 ms, 2.012 ms]	485.029 µs (32.7%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.486 ms [1.474 ms, 1.497 ms]	-
appsec	2.377 ms [2.334 ms, 2.42 ms]	891.119 µs (60.0%)
iast	2.114 ms [2.059 ms, 2.17 ms]	628.651 µs (42.3%)
iast_GLOBAL	2.171 ms [2.115 ms, 2.227 ms]	685.289 µs (46.1%)
profiling	1.992 ms [1.948 ms, 2.036 ms]	505.917 µs (34.1%)
tracing	1.96 ms [1.918 ms, 2.003 ms]	474.597 µs (31.9%)

PerfectSlayer · 2025-02-14T07:32:24Z

Hey @piochelepiotr

Missing some tests right now.

Should I wait for them before reviewing then?

PerfectSlayer

Any update on the test side?

piochelepiotr · 2025-02-18T22:11:21Z

Any update on the test side?

Sorry @PerfectSlayer , I was OOO, I shouldn't have marked it has ready for review since the test was missing.
I've added it now (and checked that the test fails before this fix) 🙇

pr-commenter · 2025-02-18T22:38:24Z

Kafka / producer-benchmark

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	piotr-wolski/data-streams-fix-bug-service-name-override
git_commit_date	1739453354	1739916166
git_commit_sha	`dcf73eb`	`0b0527f`

See matching parameters

	Baseline	Candidate
ci_job_date	1739917215	1739917215
ci_job_id	813056020	813056020
ci_pipeline_id	56223907	56223907
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion	11.0.25	11.0.25
jmhVersion	1.36	1.36
jvm	/usr/lib/jvm/java-11-openjdk-amd64/bin/java	/usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs	-Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant	-Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName	OpenJDK 64-Bit Server VM	OpenJDK 64-Bit Server VM
vmVersion	11.0.25+9-post-Ubuntu-1ubuntu122.04	11.0.25+9-post-Ubuntu-1ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results

scenario	Δ mean throughput
scenario:not-instrumented/KafkaProduceBenchmark.benchProduce	same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaProduceBenchmark.benchProduce	same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaProduceBenchmark.benchProduce	same

pr-commenter · 2025-02-18T22:51:01Z

Kafka / consumer-benchmark

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	piotr-wolski/data-streams-fix-bug-service-name-override
git_commit_date	1739453354	1739916166
git_commit_sha	`dcf73eb`	`0b0527f`

See matching parameters

	Baseline	Candidate
ci_job_date	1739917250	1739917250
ci_job_id	813056021	813056021
ci_pipeline_id	56223907	56223907
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion	11.0.25	11.0.25
jmhVersion	1.36	1.36
jvm	/usr/lib/jvm/java-11-openjdk-amd64/bin/java	/usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs	-Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant	-Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName	OpenJDK 64-Bit Server VM	OpenJDK 64-Bit Server VM
vmVersion	11.0.25+9-post-Ubuntu-1ubuntu122.04	11.0.25+9-post-Ubuntu-1ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results

scenario	Δ mean throughput
scenario:not-instrumented/KafkaConsumerBenchmark.benchConsume	same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaConsumerBenchmark.benchConsume	same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaConsumerBenchmark.benchConsume	same

PerfectSlayer · 2025-02-19T10:50:38Z

I was OOO, I shouldn't have marked it has ready for review since the test was missing.

No problem. This looks good overall but will conflict with #8383 I introduced earlier.
How do you want to proceed? Did you already had a look this PR?

Fix service name overrides in consumers

d7e270f

piochelepiotr requested a review from a team as a code owner February 14, 2025 02:58

piochelepiotr requested a review from PerfectSlayer February 14, 2025 02:58

piochelepiotr added type: bug Bug report and fix comp: data streams Data Streams Monitoring labels Feb 14, 2025

piochelepiotr added this to the 1.47.0 milestone Feb 14, 2025

PerfectSlayer removed this from the 1.47.0 milestone Feb 14, 2025

PerfectSlayer reviewed Feb 17, 2025

View reviewed changes

Add test for sink connector to test service name overrides

0b0527f

piochelepiotr requested a review from a team as a code owner February 18, 2025 22:02

PerfectSlayer approved these changes Feb 19, 2025

View reviewed changes

piochelepiotr merged commit e6c6eaf into master Feb 19, 2025

piochelepiotr deleted the piotr-wolski/data-streams-fix-bug-service-name-override branch February 19, 2025 16:46

github-actions Bot added this to the 1.47.0 milestone Feb 19, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix service name overrides in consumers#8387

Fix service name overrides in consumers#8387
piochelepiotr merged 2 commits intomasterfrom
piotr-wolski/data-streams-fix-bug-service-name-override

piochelepiotr commented Feb 14, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Feb 14, 2025

Uh oh!

pr-commenter Bot commented Feb 14, 2025 •

edited

Loading

Uh oh!

PerfectSlayer commented Feb 14, 2025

Uh oh!

PerfectSlayer left a comment

Uh oh!

piochelepiotr commented Feb 18, 2025

Uh oh!

pr-commenter Bot commented Feb 18, 2025

Uh oh!

pr-commenter Bot commented Feb 18, 2025

Uh oh!

PerfectSlayer commented Feb 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

piochelepiotr commented Feb 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

github-actions Bot commented Feb 14, 2025

Uh oh!

pr-commenter Bot commented Feb 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

PerfectSlayer commented Feb 14, 2025

Uh oh!

PerfectSlayer left a comment

Choose a reason for hiding this comment

Uh oh!

piochelepiotr commented Feb 18, 2025

Uh oh!

pr-commenter Bot commented Feb 18, 2025

Kafka / producer-benchmark

Parameters

Summary

Uh oh!

pr-commenter Bot commented Feb 18, 2025

Kafka / consumer-benchmark

Parameters

Summary

Uh oh!

PerfectSlayer commented Feb 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

piochelepiotr commented Feb 14, 2025 •

edited

Loading

pr-commenter Bot commented Feb 14, 2025 •

edited

Loading