Fix blocked PR checks #8309
Merged
PerfectSlayer merged 1 commit intomasterfrom Feb 4, 2025
Merged
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 9 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~1e069c4b3b, baseline=1.47.0-SNAPSHOT~b9533be551
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.045 s) : 0, 1045129
Total [baseline] (8.671 s) : 0, 8670771
Agent [candidate] (1.045 s) : 0, 1045245
Total [candidate] (8.666 s) : 0, 8666398
section iast
Agent [baseline] (1.179 s) : 0, 1179090
Total [baseline] (9.279 s) : 0, 9278877
Agent [candidate] (1.175 s) : 0, 1174993
Total [candidate] (9.203 s) : 0, 9202641
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.173 s) : 0, 1172929
Total [baseline] (9.189 s) : 0, 9188993
Agent [candidate] (1.173 s) : 0, 1172825
Total [candidate] (9.214 s) : 0, 9214464
section iast_TELEMETRY_OFF
Agent [baseline] (1.167 s) : 0, 1166517
Total [baseline] (9.232 s) : 0, 9232340
Agent [candidate] (1.177 s) : 0, 1177000
Total [candidate] (9.212 s) : 0, 9211560
gantt
title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~1e069c4b3b, baseline=1.47.0-SNAPSHOT~b9533be551
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (716.505 ms) : 0, 716505
BytebuddyAgent [candidate] (716.051 ms) : 0, 716051
GlobalTracer [baseline] (244.161 ms) : 0, 244161
GlobalTracer [candidate] (244.947 ms) : 0, 244947
AppSec [baseline] (55.374 ms) : 0, 55374
AppSec [candidate] (55.386 ms) : 0, 55386
Remote Config [baseline] (727.211 µs) : 0, 727
Remote Config [candidate] (726.122 µs) : 0, 726
Telemetry [baseline] (13.161 ms) : 0, 13161
Telemetry [candidate] (12.961 ms) : 0, 12961
section iast
BytebuddyAgent [baseline] (839.449 ms) : 0, 839449
BytebuddyAgent [candidate] (837.297 ms) : 0, 837297
GlobalTracer [baseline] (235.141 ms) : 0, 235141
GlobalTracer [candidate] (233.548 ms) : 0, 233548
IAST [baseline] (23.334 ms) : 0, 23334
IAST [candidate] (22.414 ms) : 0, 22414
AppSec [baseline] (56.469 ms) : 0, 56469
AppSec [candidate] (57.15 ms) : 0, 57150
Remote Config [baseline] (627.93 µs) : 0, 628
Remote Config [candidate] (634.363 µs) : 0, 634
Telemetry [baseline] (8.752 ms) : 0, 8752
Telemetry [candidate] (8.677 ms) : 0, 8677
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (834.706 ms) : 0, 834706
BytebuddyAgent [candidate] (834.114 ms) : 0, 834114
GlobalTracer [baseline] (234.023 ms) : 0, 234023
GlobalTracer [candidate] (234.389 ms) : 0, 234389
IAST [baseline] (25.81 ms) : 0, 25810
IAST [candidate] (24.998 ms) : 0, 24998
AppSec [baseline] (53.931 ms) : 0, 53931
AppSec [candidate] (54.79 ms) : 0, 54790
Remote Config [baseline] (610.657 µs) : 0, 611
Remote Config [candidate] (621.173 µs) : 0, 621
Telemetry [baseline] (8.684 ms) : 0, 8684
Telemetry [candidate] (8.733 ms) : 0, 8733
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (829.675 ms) : 0, 829675
BytebuddyAgent [candidate] (837.08 ms) : 0, 837080
GlobalTracer [baseline] (233.564 ms) : 0, 233564
GlobalTracer [candidate] (235.176 ms) : 0, 235176
IAST [baseline] (26.057 ms) : 0, 26057
IAST [candidate] (24.107 ms) : 0, 24107
AppSec [baseline] (52.841 ms) : 0, 52841
AppSec [candidate] (55.976 ms) : 0, 55976
Remote Config [baseline] (621.493 µs) : 0, 621
Remote Config [candidate] (642.173 µs) : 0, 642
Telemetry [baseline] (8.57 ms) : 0, 8570
Telemetry [candidate] (8.771 ms) : 0, 8771
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~1e069c4b3b, baseline=1.47.0-SNAPSHOT~b9533be551
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.043 s) : 0, 1042586
Total [baseline] (10.557 s) : 0, 10556799
Agent [candidate] (1.048 s) : 0, 1048398
Total [candidate] (10.522 s) : 0, 10521707
section appsec
Agent [baseline] (1.181 s) : 0, 1181355
Total [baseline] (10.714 s) : 0, 10714391
Agent [candidate] (1.183 s) : 0, 1183010
Total [candidate] (10.811 s) : 0, 10810818
section iast
Agent [baseline] (1.172 s) : 0, 1171866
Total [baseline] (10.983 s) : 0, 10982856
Agent [candidate] (1.18 s) : 0, 1180365
Total [candidate] (10.986 s) : 0, 10985924
section profiling
Agent [baseline] (1.261 s) : 0, 1261108
Total [baseline] (10.861 s) : 0, 10860724
Agent [candidate] (1.275 s) : 0, 1274812
Total [candidate] (10.912 s) : 0, 10911583
gantt
title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~1e069c4b3b, baseline=1.47.0-SNAPSHOT~b9533be551
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (715.338 ms) : 0, 715338
BytebuddyAgent [candidate] (719.441 ms) : 0, 719441
GlobalTracer [baseline] (243.166 ms) : 0, 243166
GlobalTracer [candidate] (244.659 ms) : 0, 244659
AppSec [baseline] (55.165 ms) : 0, 55165
AppSec [candidate] (55.388 ms) : 0, 55388
Remote Config [baseline] (719.332 µs) : 0, 719
Remote Config [candidate] (732.293 µs) : 0, 732
Telemetry [baseline] (13.048 ms) : 0, 13048
Telemetry [candidate] (12.946 ms) : 0, 12946
section appsec
BytebuddyAgent [baseline] (731.027 ms) : 0, 731027
BytebuddyAgent [candidate] (732.172 ms) : 0, 732172
GlobalTracer [baseline] (240.076 ms) : 0, 240076
GlobalTracer [candidate] (240.445 ms) : 0, 240445
IAST [baseline] (21.342 ms) : 0, 21342
IAST [candidate] (21.65 ms) : 0, 21650
AppSec [baseline] (175.494 ms) : 0, 175494
AppSec [candidate] (175.134 ms) : 0, 175134
Remote Config [baseline] (659.836 µs) : 0, 660
Remote Config [candidate] (655.72 µs) : 0, 656
Telemetry [baseline] (8.27 ms) : 0, 8270
Telemetry [candidate] (8.603 ms) : 0, 8603
section iast
BytebuddyAgent [baseline] (834.124 ms) : 0, 834124
BytebuddyAgent [candidate] (840.914 ms) : 0, 840914
GlobalTracer [baseline] (233.263 ms) : 0, 233263
GlobalTracer [candidate] (235.1 ms) : 0, 235100
IAST [baseline] (22.546 ms) : 0, 22546
IAST [candidate] (26.663 ms) : 0, 26663
AppSec [baseline] (57.308 ms) : 0, 57308
AppSec [candidate] (53.016 ms) : 0, 53016
Remote Config [baseline] (625.508 µs) : 0, 626
Remote Config [candidate] (616.393 µs) : 0, 616
Telemetry [baseline] (8.789 ms) : 0, 8789
Telemetry [candidate] (8.796 ms) : 0, 8796
section profiling
BytebuddyAgent [baseline] (705.581 ms) : 0, 705581
BytebuddyAgent [candidate] (712.275 ms) : 0, 712275
GlobalTracer [baseline] (352.86 ms) : 0, 352860
GlobalTracer [candidate] (357.562 ms) : 0, 357562
AppSec [baseline] (55.065 ms) : 0, 55065
AppSec [candidate] (55.276 ms) : 0, 55276
Remote Config [baseline] (691.856 µs) : 0, 692
Remote Config [candidate] (717.626 µs) : 0, 718
Telemetry [baseline] (8.874 ms) : 0, 8874
Telemetry [candidate] (9.05 ms) : 0, 9050
ProfilingAgent [baseline] (95.767 ms) : 0, 95767
ProfilingAgent [candidate] (97.377 ms) : 0, 97377
Profiling [baseline] (95.791 ms) : 0, 95791
Profiling [candidate] (97.401 ms) : 0, 97401
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~1e069c4b3b, baseline=1.47.0-SNAPSHOT~b9533be551
dateFormat X
axisFormat %s
section baseline
no_agent (1.353 ms) : 1334, 1372
. : milestone, 1353,
appsec (1.769 ms) : 1746, 1793
. : milestone, 1769,
appsec_no_iast (1.748 ms) : 1721, 1774
. : milestone, 1748,
iast (1.528 ms) : 1503, 1552
. : milestone, 1528,
profiling (1.517 ms) : 1494, 1540
. : milestone, 1517,
tracing (1.476 ms) : 1450, 1502
. : milestone, 1476,
section candidate
no_agent (1.371 ms) : 1351, 1391
. : milestone, 1371,
appsec (1.757 ms) : 1733, 1781
. : milestone, 1757,
appsec_no_iast (1.75 ms) : 1726, 1775
. : milestone, 1750,
iast (1.52 ms) : 1495, 1545
. : milestone, 1520,
profiling (1.515 ms) : 1492, 1538
. : milestone, 1515,
tracing (1.504 ms) : 1480, 1528
. : milestone, 1504,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~1e069c4b3b, baseline=1.47.0-SNAPSHOT~b9533be551
dateFormat X
axisFormat %s
section baseline
no_agent (382.465 µs) : 363, 402
. : milestone, 382,
iast (509.031 µs) : 488, 531
. : milestone, 509,
iast_FULL (752.692 µs) : 731, 775
. : milestone, 753,
iast_GLOBAL (557.477 µs) : 536, 579
. : milestone, 557,
iast_HARDCODED_SECRET_DISABLED (513.191 µs) : 492, 535
. : milestone, 513,
iast_INACTIVE (465.566 µs) : 444, 487
. : milestone, 466,
iast_TELEMETRY_OFF (500.895 µs) : 478, 523
. : milestone, 501,
tracing (461.91 µs) : 440, 484
. : milestone, 462,
section candidate
no_agent (380.491 µs) : 360, 401
. : milestone, 380,
iast (506.915 µs) : 485, 528
. : milestone, 507,
iast_FULL (747.464 µs) : 725, 770
. : milestone, 747,
iast_GLOBAL (567.897 µs) : 545, 591
. : milestone, 568,
iast_HARDCODED_SECRET_DISABLED (514.834 µs) : 493, 536
. : milestone, 515,
iast_INACTIVE (462.803 µs) : 441, 484
. : milestone, 463,
iast_TELEMETRY_OFF (501.168 µs) : 479, 524
. : milestone, 501,
tracing (460.397 µs) : 439, 482
. : milestone, 460,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~1e069c4b3b, baseline=1.47.0-SNAPSHOT~b9533be551
dateFormat X
axisFormat %s
section baseline
no_agent (14.779 s) : 14779000, 14779000
. : milestone, 14779000,
appsec (15.095 s) : 15095000, 15095000
. : milestone, 15095000,
iast (18.9 s) : 18900000, 18900000
. : milestone, 18900000,
iast_GLOBAL (18.009 s) : 18009000, 18009000
. : milestone, 18009000,
profiling (15.193 s) : 15193000, 15193000
. : milestone, 15193000,
tracing (15.133 s) : 15133000, 15133000
. : milestone, 15133000,
section candidate
no_agent (15.483 s) : 15483000, 15483000
. : milestone, 15483000,
appsec (14.974 s) : 14974000, 14974000
. : milestone, 14974000,
iast (18.851 s) : 18851000, 18851000
. : milestone, 18851000,
iast_GLOBAL (17.982 s) : 17982000, 17982000
. : milestone, 17982000,
profiling (15.764 s) : 15764000, 15764000
. : milestone, 15764000,
tracing (14.587 s) : 14587000, 14587000
. : milestone, 14587000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~1e069c4b3b, baseline=1.47.0-SNAPSHOT~b9533be551
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (2.346 ms) : 2303, 2389
. : milestone, 2346,
iast (2.106 ms) : 2051, 2161
. : milestone, 2106,
iast_GLOBAL (2.145 ms) : 2090, 2200
. : milestone, 2145,
profiling (1.954 ms) : 1910, 1997
. : milestone, 1954,
tracing (1.948 ms) : 1906, 1991
. : milestone, 1948,
section candidate
no_agent (1.469 ms) : 1457, 1480
. : milestone, 1469,
appsec (2.363 ms) : 2320, 2407
. : milestone, 2363,
iast (2.107 ms) : 2052, 2162
. : milestone, 2107,
iast_GLOBAL (2.152 ms) : 2097, 2207
. : milestone, 2152,
profiling (2.43 ms) : 2183, 2677
. : milestone, 2430,
tracing (1.946 ms) : 1903, 1988
. : milestone, 1946,
|
With better concurrency setting, try to add synchronize event back to prevent blocked PR checks
28c1e40 to
1e069c4
Compare
smola
approved these changes
Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Try to fix blocked PR with waiting checks.
Motivation
With better concurrency setting, try to add synchronize event back to prevent blocked PR checks.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: LANGPLAT-116