Re-enable profiler for Java9ModulesSmokeTest#8257
Merged
Conversation
smola
approved these changes
Jan 21, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 3 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~3a6c3c0ddc, baseline=1.46.0-SNAPSHOT~b63b852c6d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1068831
Total [baseline] (10.524 s) : 0, 10524020
Agent [candidate] (1.054 s) : 0, 1054396
Total [candidate] (10.432 s) : 0, 10431524
section appsec
Agent [baseline] (1.194 s) : 0, 1194383
Total [baseline] (10.727 s) : 0, 10727007
Agent [candidate] (1.187 s) : 0, 1186974
Total [candidate] (10.706 s) : 0, 10706061
section iast
Agent [baseline] (1.181 s) : 0, 1180917
Total [baseline] (10.904 s) : 0, 10904272
Agent [candidate] (1.198 s) : 0, 1198369
Total [candidate] (11.027 s) : 0, 11026823
section profiling
Agent [baseline] (1.263 s) : 0, 1262755
Total [baseline] (10.751 s) : 0, 10751414
Agent [candidate] (1.262 s) : 0, 1261606
Total [candidate] (10.905 s) : 0, 10904541
gantt
title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~3a6c3c0ddc, baseline=1.46.0-SNAPSHOT~b63b852c6d
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (723.855 ms) : 0, 723855
BytebuddyAgent [candidate] (713.24 ms) : 0, 713240
GlobalTracer [baseline] (258.082 ms) : 0, 258082
GlobalTracer [candidate] (255.206 ms) : 0, 255206
AppSec [baseline] (56.115 ms) : 0, 56115
AppSec [candidate] (56.21 ms) : 0, 56210
Remote Config [baseline] (746.931 µs) : 0, 747
Remote Config [candidate] (733.1 µs) : 0, 733
Telemetry [baseline] (14.937 ms) : 0, 14937
Telemetry [candidate] (14.036 ms) : 0, 14036
section appsec
BytebuddyAgent [baseline] (735.144 ms) : 0, 735144
BytebuddyAgent [candidate] (730.691 ms) : 0, 730691
GlobalTracer [baseline] (254.519 ms) : 0, 254519
GlobalTracer [candidate] (252.293 ms) : 0, 252293
AppSec [baseline] (171.068 ms) : 0, 171068
AppSec [candidate] (170.537 ms) : 0, 170537
IAST [baseline] (19.466 ms) : 0, 19466
IAST [candidate] (19.318 ms) : 0, 19318
Remote Config [baseline] (671.675 µs) : 0, 672
Remote Config [candidate] (659.831 µs) : 0, 660
Telemetry [baseline] (8.221 ms) : 0, 8221
Telemetry [candidate] (8.171 ms) : 0, 8171
section iast
BytebuddyAgent [baseline] (830.671 ms) : 0, 830671
BytebuddyAgent [candidate] (844.019 ms) : 0, 844019
GlobalTracer [baseline] (246.218 ms) : 0, 246218
GlobalTracer [candidate] (249.234 ms) : 0, 249234
AppSec [baseline] (57.985 ms) : 0, 57985
AppSec [candidate] (58.502 ms) : 0, 58502
IAST [baseline] (21.661 ms) : 0, 21661
IAST [candidate] (21.83 ms) : 0, 21830
Remote Config [baseline] (687.527 µs) : 0, 688
Remote Config [candidate] (671.926 µs) : 0, 672
Telemetry [baseline] (8.748 ms) : 0, 8748
Telemetry [candidate] (8.966 ms) : 0, 8966
section profiling
BytebuddyAgent [baseline] (707.593 ms) : 0, 707593
BytebuddyAgent [candidate] (707.98 ms) : 0, 707980
GlobalTracer [baseline] (351.425 ms) : 0, 351425
GlobalTracer [candidate] (351.719 ms) : 0, 351719
AppSec [baseline] (55.296 ms) : 0, 55296
AppSec [candidate] (54.207 ms) : 0, 54207
Remote Config [baseline] (724.203 µs) : 0, 724
Remote Config [candidate] (713.115 µs) : 0, 713
Telemetry [baseline] (8.893 ms) : 0, 8893
Telemetry [candidate] (8.883 ms) : 0, 8883
ProfilingAgent [baseline] (96.678 ms) : 0, 96678
ProfilingAgent [candidate] (95.894 ms) : 0, 95894
Profiling [baseline] (96.703 ms) : 0, 96703
Profiling [candidate] (95.919 ms) : 0, 95919
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~3a6c3c0ddc, baseline=1.46.0-SNAPSHOT~b63b852c6d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.076 s) : 0, 1076337
Total [baseline] (8.7 s) : 0, 8699779
Agent [candidate] (1.054 s) : 0, 1053640
Total [candidate] (8.606 s) : 0, 8606360
section iast
Agent [baseline] (1.198 s) : 0, 1197622
Total [baseline] (9.243 s) : 0, 9243257
Agent [candidate] (1.183 s) : 0, 1183230
Total [candidate] (9.238 s) : 0, 9237598
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.182 s) : 0, 1182199
Total [baseline] (9.15 s) : 0, 9149506
Agent [candidate] (1.183 s) : 0, 1183056
Total [candidate] (9.162 s) : 0, 9161559
section iast_TELEMETRY_OFF
Agent [baseline] (1.179 s) : 0, 1179263
Total [baseline] (9.169 s) : 0, 9168880
Agent [candidate] (1.177 s) : 0, 1177034
Total [candidate] (9.185 s) : 0, 9184822
gantt
title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~3a6c3c0ddc, baseline=1.46.0-SNAPSHOT~b63b852c6d
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (728.582 ms) : 0, 728582
BytebuddyAgent [candidate] (713.943 ms) : 0, 713943
GlobalTracer [baseline] (259.033 ms) : 0, 259033
GlobalTracer [candidate] (255.083 ms) : 0, 255083
AppSec [baseline] (59.717 ms) : 0, 59717
AppSec [candidate] (55.418 ms) : 0, 55418
Remote Config [baseline] (751.827 µs) : 0, 752
Remote Config [candidate] (734.009 µs) : 0, 734
Telemetry [baseline] (13.125 ms) : 0, 13125
Telemetry [candidate] (13.521 ms) : 0, 13521
section iast
BytebuddyAgent [baseline] (843.606 ms) : 0, 843606
BytebuddyAgent [candidate] (832.685 ms) : 0, 832685
GlobalTracer [baseline] (248.717 ms) : 0, 248717
GlobalTracer [candidate] (246.446 ms) : 0, 246446
AppSec [baseline] (58.477 ms) : 0, 58477
AppSec [candidate] (58.21 ms) : 0, 58210
IAST [baseline] (21.874 ms) : 0, 21874
IAST [candidate] (21.5 ms) : 0, 21500
Remote Config [baseline] (686.712 µs) : 0, 687
Remote Config [candidate] (661.234 µs) : 0, 661
Telemetry [baseline] (9.067 ms) : 0, 9067
Telemetry [candidate] (8.733 ms) : 0, 8733
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (832.071 ms) : 0, 832071
BytebuddyAgent [candidate] (832.189 ms) : 0, 832189
GlobalTracer [baseline] (246.163 ms) : 0, 246163
GlobalTracer [candidate] (246.865 ms) : 0, 246865
AppSec [baseline] (58.014 ms) : 0, 58014
AppSec [candidate] (58.2 ms) : 0, 58200
IAST [baseline] (21.522 ms) : 0, 21522
IAST [candidate] (21.45 ms) : 0, 21450
Remote Config [baseline] (670.487 µs) : 0, 670
Remote Config [candidate] (660.064 µs) : 0, 660
Telemetry [baseline] (8.744 ms) : 0, 8744
Telemetry [candidate] (8.724 ms) : 0, 8724
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (829.363 ms) : 0, 829363
BytebuddyAgent [candidate] (827.999 ms) : 0, 827999
GlobalTracer [baseline] (246.904 ms) : 0, 246904
GlobalTracer [candidate] (245.889 ms) : 0, 245889
AppSec [baseline] (57.836 ms) : 0, 57836
AppSec [candidate] (58.089 ms) : 0, 58089
IAST [baseline] (20.919 ms) : 0, 20919
IAST [candidate] (20.828 ms) : 0, 20828
Remote Config [baseline] (655.53 µs) : 0, 656
Remote Config [candidate] (651.924 µs) : 0, 652
Telemetry [baseline] (8.613 ms) : 0, 8613
Telemetry [candidate] (8.57 ms) : 0, 8570
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~3a6c3c0ddc, baseline=1.46.0-SNAPSHOT~b63b852c6d
dateFormat X
axisFormat %s
section baseline
no_agent (1.357 ms) : 1337, 1376
. : milestone, 1357,
appsec (1.734 ms) : 1710, 1758
. : milestone, 1734,
appsec_no_iast (1.752 ms) : 1729, 1774
. : milestone, 1752,
iast (1.508 ms) : 1482, 1533
. : milestone, 1508,
profiling (1.489 ms) : 1464, 1513
. : milestone, 1489,
tracing (1.483 ms) : 1459, 1507
. : milestone, 1483,
section candidate
no_agent (1.338 ms) : 1318, 1359
. : milestone, 1338,
appsec (1.745 ms) : 1722, 1769
. : milestone, 1745,
appsec_no_iast (1.744 ms) : 1719, 1769
. : milestone, 1744,
iast (1.504 ms) : 1479, 1528
. : milestone, 1504,
profiling (1.511 ms) : 1487, 1534
. : milestone, 1511,
tracing (1.49 ms) : 1465, 1516
. : milestone, 1490,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~3a6c3c0ddc, baseline=1.46.0-SNAPSHOT~b63b852c6d
dateFormat X
axisFormat %s
section baseline
no_agent (370.941 µs) : 351, 391
. : milestone, 371,
iast (497.705 µs) : 476, 520
. : milestone, 498,
iast_FULL (735.786 µs) : 714, 758
. : milestone, 736,
iast_GLOBAL (556.488 µs) : 533, 580
. : milestone, 556,
iast_HARDCODED_SECRET_DISABLED (496.603 µs) : 475, 518
. : milestone, 497,
iast_INACTIVE (458.497 µs) : 436, 481
. : milestone, 458,
iast_TELEMETRY_OFF (485.014 µs) : 464, 506
. : milestone, 485,
tracing (449.546 µs) : 428, 471
. : milestone, 450,
section candidate
no_agent (377.849 µs) : 358, 397
. : milestone, 378,
iast (500.756 µs) : 479, 523
. : milestone, 501,
iast_FULL (733.174 µs) : 711, 755
. : milestone, 733,
iast_GLOBAL (547.559 µs) : 526, 570
. : milestone, 548,
iast_HARDCODED_SECRET_DISABLED (500.58 µs) : 479, 523
. : milestone, 501,
iast_INACTIVE (451.523 µs) : 430, 473
. : milestone, 452,
iast_TELEMETRY_OFF (490.647 µs) : 469, 513
. : milestone, 491,
tracing (445.439 µs) : 425, 466
. : milestone, 445,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~3a6c3c0ddc, baseline=1.46.0-SNAPSHOT~b63b852c6d
dateFormat X
axisFormat %s
section baseline
no_agent (15.036 s) : 15036000, 15036000
. : milestone, 15036000,
appsec (15.134 s) : 15134000, 15134000
. : milestone, 15134000,
iast (19.031 s) : 19031000, 19031000
. : milestone, 19031000,
iast_GLOBAL (18.147 s) : 18147000, 18147000
. : milestone, 18147000,
profiling (15.006 s) : 15006000, 15006000
. : milestone, 15006000,
tracing (14.95 s) : 14950000, 14950000
. : milestone, 14950000,
section candidate
no_agent (14.856 s) : 14856000, 14856000
. : milestone, 14856000,
appsec (15.165 s) : 15165000, 15165000
. : milestone, 15165000,
iast (18.949 s) : 18949000, 18949000
. : milestone, 18949000,
iast_GLOBAL (17.846 s) : 17846000, 17846000
. : milestone, 17846000,
profiling (15.288 s) : 15288000, 15288000
. : milestone, 15288000,
tracing (14.998 s) : 14998000, 14998000
. : milestone, 14998000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~3a6c3c0ddc, baseline=1.46.0-SNAPSHOT~b63b852c6d
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (2.37 ms) : 2326, 2413
. : milestone, 2370,
iast (2.107 ms) : 2053, 2162
. : milestone, 2107,
iast_GLOBAL (2.151 ms) : 2097, 2206
. : milestone, 2151,
profiling (1.958 ms) : 1915, 2001
. : milestone, 1958,
tracing (1.947 ms) : 1904, 1989
. : milestone, 1947,
section candidate
no_agent (1.468 ms) : 1456, 1479
. : milestone, 1468,
appsec (2.367 ms) : 2324, 2410
. : milestone, 2367,
iast (2.108 ms) : 2054, 2163
. : milestone, 2108,
iast_GLOBAL (2.151 ms) : 2096, 2205
. : milestone, 2151,
profiling (1.968 ms) : 1924, 2012
. : milestone, 1968,
tracing (1.955 ms) : 1913, 1997
. : milestone, 1955,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
It reverts the change disabling profiling in Java9ModulesSmokeTest
Motivation
The underlying bug in the profiler was fixed so it is safe to enable it again such that we have also profiling coverage.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: PROF-11080