Decouple test JDK and gradle JDK in selenium latestDepTest#8236
Merged
Decouple test JDK and gradle JDK in selenium latestDepTest#8236
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 4 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~3669f80511, baseline=1.46.0-SNAPSHOT~fbb36f9b5b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.057 s) : 0, 1056758
Total [baseline] (10.474 s) : 0, 10473540
Agent [candidate] (1.067 s) : 0, 1066864
Total [candidate] (10.556 s) : 0, 10556270
section appsec
Agent [baseline] (1.192 s) : 0, 1191983
Total [baseline] (10.764 s) : 0, 10763792
Agent [candidate] (1.193 s) : 0, 1193130
Total [candidate] (10.769 s) : 0, 10768667
section iast
Agent [baseline] (1.186 s) : 0, 1186269
Total [baseline] (11.01 s) : 0, 11010015
Agent [candidate] (1.189 s) : 0, 1189183
Total [candidate] (11.029 s) : 0, 11029313
section profiling
Agent [baseline] (1.264 s) : 0, 1263722
Total [baseline] (10.902 s) : 0, 10902175
Agent [candidate] (1.258 s) : 0, 1257699
Total [candidate] (10.803 s) : 0, 10803414
gantt
title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~3669f80511, baseline=1.46.0-SNAPSHOT~fbb36f9b5b
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (714.219 ms) : 0, 714219
BytebuddyAgent [candidate] (722.293 ms) : 0, 722293
GlobalTracer [baseline] (256.539 ms) : 0, 256539
GlobalTracer [candidate] (258.475 ms) : 0, 258475
AppSec [baseline] (56.6 ms) : 0, 56600
AppSec [candidate] (55.729 ms) : 0, 55729
Remote Config [baseline] (740.954 µs) : 0, 741
Remote Config [candidate] (730.661 µs) : 0, 731
Telemetry [baseline] (13.581 ms) : 0, 13581
Telemetry [candidate] (14.454 ms) : 0, 14454
section appsec
BytebuddyAgent [baseline] (733.268 ms) : 0, 733268
BytebuddyAgent [candidate] (733.234 ms) : 0, 733234
GlobalTracer [baseline] (254.061 ms) : 0, 254061
GlobalTracer [candidate] (254.528 ms) : 0, 254528
AppSec [baseline] (170.729 ms) : 0, 170729
AppSec [candidate] (171.631 ms) : 0, 171631
IAST [baseline] (19.421 ms) : 0, 19421
IAST [candidate] (19.468 ms) : 0, 19468
Remote Config [baseline] (669.315 µs) : 0, 669
Remote Config [candidate] (675.468 µs) : 0, 675
Telemetry [baseline] (8.555 ms) : 0, 8555
Telemetry [candidate] (8.285 ms) : 0, 8285
section iast
BytebuddyAgent [baseline] (834.205 ms) : 0, 834205
BytebuddyAgent [candidate] (834.891 ms) : 0, 834891
GlobalTracer [baseline] (247.467 ms) : 0, 247467
GlobalTracer [candidate] (249.434 ms) : 0, 249434
AppSec [baseline] (58.36 ms) : 0, 58360
AppSec [candidate] (58.45 ms) : 0, 58450
IAST [baseline] (21.654 ms) : 0, 21654
IAST [candidate] (21.781 ms) : 0, 21781
Remote Config [baseline] (662.45 µs) : 0, 662
Remote Config [candidate] (674.363 µs) : 0, 674
Telemetry [baseline] (8.858 ms) : 0, 8858
Telemetry [candidate] (8.88 ms) : 0, 8880
section profiling
BytebuddyAgent [baseline] (708.033 ms) : 0, 708033
BytebuddyAgent [candidate] (706.02 ms) : 0, 706020
GlobalTracer [baseline] (351.784 ms) : 0, 351784
GlobalTracer [candidate] (350.493 ms) : 0, 350493
AppSec [baseline] (54.79 ms) : 0, 54790
AppSec [candidate] (54.507 ms) : 0, 54507
Remote Config [baseline] (722.048 µs) : 0, 722
Remote Config [candidate] (648.136 µs) : 0, 648
Telemetry [baseline] (9.581 ms) : 0, 9581
Telemetry [candidate] (8.857 ms) : 0, 8857
ProfilingAgent [baseline] (96.571 ms) : 0, 96571
ProfilingAgent [candidate] (95.09 ms) : 0, 95090
Profiling [baseline] (96.597 ms) : 0, 96597
Profiling [candidate] (95.118 ms) : 0, 95118
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~3669f80511, baseline=1.46.0-SNAPSHOT~fbb36f9b5b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1061045
Total [baseline] (8.629 s) : 0, 8628586
Agent [candidate] (1.07 s) : 0, 1069713
Total [candidate] (8.65 s) : 0, 8649864
section iast
Agent [baseline] (1.183 s) : 0, 1183405
Total [baseline] (9.193 s) : 0, 9193412
Agent [candidate] (1.187 s) : 0, 1186532
Total [candidate] (9.252 s) : 0, 9252400
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.182 s) : 0, 1182276
Total [baseline] (9.192 s) : 0, 9192402
Agent [candidate] (1.186 s) : 0, 1185813
Total [candidate] (9.164 s) : 0, 9163616
section iast_TELEMETRY_OFF
Agent [baseline] (1.178 s) : 0, 1177895
Total [baseline] (9.222 s) : 0, 9221859
Agent [candidate] (1.181 s) : 0, 1181141
Total [candidate] (9.203 s) : 0, 9203052
gantt
title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~3669f80511, baseline=1.46.0-SNAPSHOT~fbb36f9b5b
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.212 ms) : 0, 718212
BytebuddyAgent [candidate] (723.74 ms) : 0, 723740
GlobalTracer [baseline] (257.093 ms) : 0, 257093
GlobalTracer [candidate] (259.761 ms) : 0, 259761
AppSec [baseline] (55.941 ms) : 0, 55941
AppSec [candidate] (56.839 ms) : 0, 56839
Remote Config [baseline] (738.767 µs) : 0, 739
Remote Config [candidate] (732.301 µs) : 0, 732
Telemetry [baseline] (14.01 ms) : 0, 14010
Telemetry [candidate] (13.435 ms) : 0, 13435
section iast
BytebuddyAgent [baseline] (832.389 ms) : 0, 832389
BytebuddyAgent [candidate] (834.383 ms) : 0, 834383
GlobalTracer [baseline] (247.166 ms) : 0, 247166
GlobalTracer [candidate] (247.91 ms) : 0, 247910
AppSec [baseline] (57.985 ms) : 0, 57985
AppSec [candidate] (58.152 ms) : 0, 58152
IAST [baseline] (21.512 ms) : 0, 21512
IAST [candidate] (21.568 ms) : 0, 21568
Remote Config [baseline] (653.217 µs) : 0, 653
Remote Config [candidate] (670.142 µs) : 0, 670
Telemetry [baseline] (8.727 ms) : 0, 8727
Telemetry [candidate] (8.778 ms) : 0, 8778
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (831.481 ms) : 0, 831481
BytebuddyAgent [candidate] (833.601 ms) : 0, 833601
GlobalTracer [baseline] (246.668 ms) : 0, 246668
GlobalTracer [candidate] (247.401 ms) : 0, 247401
AppSec [baseline] (58.116 ms) : 0, 58116
AppSec [candidate] (58.559 ms) : 0, 58559
IAST [baseline] (21.56 ms) : 0, 21560
IAST [candidate] (21.683 ms) : 0, 21683
Remote Config [baseline] (657.608 µs) : 0, 658
Remote Config [candidate] (674.709 µs) : 0, 675
Telemetry [baseline] (8.768 ms) : 0, 8768
Telemetry [candidate] (8.907 ms) : 0, 8907
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (828.227 ms) : 0, 828227
BytebuddyAgent [candidate] (830.246 ms) : 0, 830246
GlobalTracer [baseline] (246.813 ms) : 0, 246813
GlobalTracer [candidate] (247.422 ms) : 0, 247422
AppSec [baseline] (57.722 ms) : 0, 57722
AppSec [candidate] (57.888 ms) : 0, 57888
IAST [baseline] (20.888 ms) : 0, 20888
IAST [candidate] (21.109 ms) : 0, 21109
Remote Config [baseline] (667.055 µs) : 0, 667
Remote Config [candidate] (696.351 µs) : 0, 696
Telemetry [baseline] (8.667 ms) : 0, 8667
Telemetry [candidate] (8.738 ms) : 0, 8738
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~3669f80511, baseline=1.46.0-SNAPSHOT~fbb36f9b5b
dateFormat X
axisFormat %s
section baseline
no_agent (387.108 µs) : 367, 408
. : milestone, 387,
iast (519.796 µs) : 498, 542
. : milestone, 520,
iast_FULL (749.513 µs) : 728, 772
. : milestone, 750,
iast_GLOBAL (567.487 µs) : 545, 590
. : milestone, 567,
iast_HARDCODED_SECRET_DISABLED (518.988 µs) : 497, 541
. : milestone, 519,
iast_INACTIVE (473.421 µs) : 451, 496
. : milestone, 473,
iast_TELEMETRY_OFF (497.999 µs) : 477, 519
. : milestone, 498,
tracing (461.315 µs) : 440, 482
. : milestone, 461,
section candidate
no_agent (388.128 µs) : 367, 410
. : milestone, 388,
iast (517.368 µs) : 496, 539
. : milestone, 517,
iast_FULL (751.875 µs) : 730, 774
. : milestone, 752,
iast_GLOBAL (565.198 µs) : 542, 588
. : milestone, 565,
iast_HARDCODED_SECRET_DISABLED (519.664 µs) : 498, 541
. : milestone, 520,
iast_INACTIVE (466.971 µs) : 446, 488
. : milestone, 467,
iast_TELEMETRY_OFF (507.415 µs) : 486, 529
. : milestone, 507,
tracing (464.49 µs) : 444, 485
. : milestone, 464,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~3669f80511, baseline=1.46.0-SNAPSHOT~fbb36f9b5b
dateFormat X
axisFormat %s
section baseline
no_agent (1.365 ms) : 1346, 1385
. : milestone, 1365,
appsec (1.746 ms) : 1722, 1770
. : milestone, 1746,
appsec_no_iast (1.788 ms) : 1765, 1812
. : milestone, 1788,
iast (1.536 ms) : 1512, 1560
. : milestone, 1536,
profiling (1.528 ms) : 1504, 1551
. : milestone, 1528,
tracing (1.505 ms) : 1481, 1529
. : milestone, 1505,
section candidate
no_agent (1.376 ms) : 1356, 1395
. : milestone, 1376,
appsec (1.755 ms) : 1730, 1779
. : milestone, 1755,
appsec_no_iast (1.764 ms) : 1739, 1789
. : milestone, 1764,
iast (1.505 ms) : 1481, 1530
. : milestone, 1505,
profiling (1.513 ms) : 1490, 1536
. : milestone, 1513,
tracing (1.502 ms) : 1476, 1528
. : milestone, 1502,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~3669f80511, baseline=1.46.0-SNAPSHOT~fbb36f9b5b
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (2.384 ms) : 2340, 2428
. : milestone, 2384,
iast (2.119 ms) : 2063, 2174
. : milestone, 2119,
iast_GLOBAL (2.167 ms) : 2111, 2222
. : milestone, 2167,
profiling (1.996 ms) : 1950, 2041
. : milestone, 1996,
tracing (1.969 ms) : 1926, 2013
. : milestone, 1969,
section candidate
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (2.382 ms) : 2338, 2426
. : milestone, 2382,
iast (2.124 ms) : 2069, 2180
. : milestone, 2124,
iast_GLOBAL (2.174 ms) : 2119, 2230
. : milestone, 2174,
profiling (1.987 ms) : 1942, 2032
. : milestone, 1987,
tracing (1.963 ms) : 1920, 2005
. : milestone, 1963,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~3669f80511, baseline=1.46.0-SNAPSHOT~fbb36f9b5b
dateFormat X
axisFormat %s
section baseline
no_agent (14.858 s) : 14858000, 14858000
. : milestone, 14858000,
appsec (15.255 s) : 15255000, 15255000
. : milestone, 15255000,
iast (18.872 s) : 18872000, 18872000
. : milestone, 18872000,
iast_GLOBAL (18.079 s) : 18079000, 18079000
. : milestone, 18079000,
profiling (15.806 s) : 15806000, 15806000
. : milestone, 15806000,
tracing (15.006 s) : 15006000, 15006000
. : milestone, 15006000,
section candidate
no_agent (15.68 s) : 15680000, 15680000
. : milestone, 15680000,
appsec (14.937 s) : 14937000, 14937000
. : milestone, 14937000,
iast (19.14 s) : 19140000, 19140000
. : milestone, 19140000,
iast_GLOBAL (17.878 s) : 17878000, 17878000
. : milestone, 17878000,
profiling (15.07 s) : 15070000, 15070000
. : milestone, 15070000,
tracing (14.798 s) : 14798000, 14798000
. : milestone, 14798000,
|
smola
commented
Jan 17, 2025
nikita-tkachenko-datadog
approved these changes
Jan 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Similar to #8234. Effectively enables tests for latest Selenium version in CI.
Motivation
Part of fixes to decouple the JDK used for compile/test from the one used by gradle.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: APMJAVA-1342