Fix Docker build image update automation#8224
Merged
PerfectSlayer merged 1 commit intomasterfrom Jan 24, 2025
Merged
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 5 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~cec10308c9, baseline=1.46.0-SNAPSHOT~148aef92ab
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.058 s) : 0, 1057686
Total [baseline] (8.652 s) : 0, 8651532
Agent [candidate] (1.058 s) : 0, 1058489
Total [candidate] (8.638 s) : 0, 8637560
section iast
Agent [baseline] (1.185 s) : 0, 1184585
Total [baseline] (9.245 s) : 0, 9244507
Agent [candidate] (1.196 s) : 0, 1196031
Total [candidate] (9.3 s) : 0, 9300221
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.188 s) : 0, 1187610
Total [baseline] (9.212 s) : 0, 9211931
Agent [candidate] (1.187 s) : 0, 1187323
Total [candidate] (9.204 s) : 0, 9203889
section iast_TELEMETRY_OFF
Agent [baseline] (1.194 s) : 0, 1194000
Total [baseline] (9.246 s) : 0, 9245654
Agent [candidate] (1.183 s) : 0, 1183276
Total [candidate] (9.22 s) : 0, 9219595
gantt
title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~cec10308c9, baseline=1.46.0-SNAPSHOT~148aef92ab
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (714.798 ms) : 0, 714798
BytebuddyAgent [candidate] (716.268 ms) : 0, 716268
GlobalTracer [baseline] (257.091 ms) : 0, 257091
GlobalTracer [candidate] (257.191 ms) : 0, 257191
AppSec [baseline] (57.088 ms) : 0, 57088
AppSec [candidate] (55.277 ms) : 0, 55277
Remote Config [baseline] (720.698 µs) : 0, 721
Remote Config [candidate] (719.953 µs) : 0, 720
Telemetry [baseline] (13.0 ms) : 0, 13000
Telemetry [candidate] (13.933 ms) : 0, 13933
section iast
BytebuddyAgent [baseline] (832.494 ms) : 0, 832494
BytebuddyAgent [candidate] (840.708 ms) : 0, 840708
GlobalTracer [baseline] (248.142 ms) : 0, 248142
GlobalTracer [candidate] (249.934 ms) : 0, 249934
AppSec [baseline] (58.071 ms) : 0, 58071
AppSec [candidate] (58.582 ms) : 0, 58582
Remote Config [baseline] (681.424 µs) : 0, 681
Remote Config [candidate] (699.353 µs) : 0, 699
Telemetry [baseline] (8.881 ms) : 0, 8881
Telemetry [candidate] (8.937 ms) : 0, 8937
IAST [baseline] (21.325 ms) : 0, 21325
IAST [candidate] (21.846 ms) : 0, 21846
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (834.671 ms) : 0, 834671
BytebuddyAgent [candidate] (834.107 ms) : 0, 834107
GlobalTracer [baseline] (248.321 ms) : 0, 248321
GlobalTracer [candidate] (248.525 ms) : 0, 248525
AppSec [baseline] (58.483 ms) : 0, 58483
AppSec [candidate] (58.241 ms) : 0, 58241
Remote Config [baseline] (680.476 µs) : 0, 680
Remote Config [candidate] (701.639 µs) : 0, 702
Telemetry [baseline] (8.837 ms) : 0, 8837
Telemetry [candidate] (8.879 ms) : 0, 8879
IAST [baseline] (21.493 ms) : 0, 21493
IAST [candidate] (21.818 ms) : 0, 21818
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (841.197 ms) : 0, 841197
BytebuddyAgent [candidate] (831.179 ms) : 0, 831179
GlobalTracer [baseline] (248.756 ms) : 0, 248756
GlobalTracer [candidate] (248.359 ms) : 0, 248359
AppSec [baseline] (58.242 ms) : 0, 58242
AppSec [candidate] (58.194 ms) : 0, 58194
Remote Config [baseline] (685.839 µs) : 0, 686
Remote Config [candidate] (666.255 µs) : 0, 666
Telemetry [baseline] (8.778 ms) : 0, 8778
Telemetry [candidate] (8.73 ms) : 0, 8730
IAST [baseline] (21.135 ms) : 0, 21135
IAST [candidate] (21.1 ms) : 0, 21100
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~cec10308c9, baseline=1.46.0-SNAPSHOT~148aef92ab
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1055670
Total [baseline] (10.556 s) : 0, 10556096
Agent [candidate] (1.058 s) : 0, 1058132
Total [candidate] (10.475 s) : 0, 10475162
section appsec
Agent [baseline] (1.195 s) : 0, 1195414
Total [baseline] (10.82 s) : 0, 10820459
Agent [candidate] (1.202 s) : 0, 1202172
Total [candidate] (10.769 s) : 0, 10768988
section iast
Agent [baseline] (1.189 s) : 0, 1189174
Total [baseline] (11.044 s) : 0, 11043525
Agent [candidate] (1.199 s) : 0, 1198892
Total [candidate] (11.006 s) : 0, 11006065
section profiling
Agent [baseline] (1.256 s) : 0, 1256158
Total [baseline] (10.853 s) : 0, 10852958
Agent [candidate] (1.279 s) : 0, 1279377
Total [candidate] (10.947 s) : 0, 10947463
gantt
title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~cec10308c9, baseline=1.46.0-SNAPSHOT~148aef92ab
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (715.058 ms) : 0, 715058
BytebuddyAgent [candidate] (715.506 ms) : 0, 715506
GlobalTracer [baseline] (256.777 ms) : 0, 256777
GlobalTracer [candidate] (256.917 ms) : 0, 256917
AppSec [baseline] (55.898 ms) : 0, 55898
AppSec [candidate] (55.496 ms) : 0, 55496
Remote Config [baseline] (720.33 µs) : 0, 720
Remote Config [candidate] (720.36 µs) : 0, 720
Telemetry [baseline] (12.228 ms) : 0, 12228
Telemetry [candidate] (14.439 ms) : 0, 14439
section appsec
BytebuddyAgent [baseline] (735.005 ms) : 0, 735005
BytebuddyAgent [candidate] (739.578 ms) : 0, 739578
GlobalTracer [baseline] (255.292 ms) : 0, 255292
GlobalTracer [candidate] (256.036 ms) : 0, 256036
AppSec [baseline] (171.402 ms) : 0, 171402
AppSec [candidate] (172.153 ms) : 0, 172153
Remote Config [baseline] (673.852 µs) : 0, 674
Remote Config [candidate] (670.367 µs) : 0, 670
Telemetry [baseline] (8.239 ms) : 0, 8239
Telemetry [candidate] (8.677 ms) : 0, 8677
IAST [baseline] (19.531 ms) : 0, 19531
IAST [candidate] (19.824 ms) : 0, 19824
section iast
BytebuddyAgent [baseline] (835.97 ms) : 0, 835970
BytebuddyAgent [candidate] (844.397 ms) : 0, 844397
GlobalTracer [baseline] (248.815 ms) : 0, 248815
GlobalTracer [candidate] (249.64 ms) : 0, 249640
AppSec [baseline] (58.094 ms) : 0, 58094
AppSec [candidate] (58.5 ms) : 0, 58500
Remote Config [baseline] (674.492 µs) : 0, 674
Remote Config [candidate] (668.854 µs) : 0, 669
Telemetry [baseline] (8.885 ms) : 0, 8885
Telemetry [candidate] (8.829 ms) : 0, 8829
IAST [baseline] (21.718 ms) : 0, 21718
IAST [candidate] (21.637 ms) : 0, 21637
section profiling
BytebuddyAgent [baseline] (704.497 ms) : 0, 704497
BytebuddyAgent [candidate] (719.263 ms) : 0, 719263
GlobalTracer [baseline] (350.794 ms) : 0, 350794
GlobalTracer [candidate] (355.929 ms) : 0, 355929
AppSec [baseline] (54.565 ms) : 0, 54565
AppSec [candidate] (54.285 ms) : 0, 54285
Remote Config [baseline] (658.624 µs) : 0, 659
Remote Config [candidate] (675.285 µs) : 0, 675
Telemetry [baseline] (8.821 ms) : 0, 8821
Telemetry [candidate] (8.993 ms) : 0, 8993
ProfilingAgent [baseline] (94.949 ms) : 0, 94949
ProfilingAgent [candidate] (97.365 ms) : 0, 97365
Profiling [baseline] (94.973 ms) : 0, 94973
Profiling [candidate] (97.389 ms) : 0, 97389
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~cec10308c9, baseline=1.46.0-SNAPSHOT~148aef92ab
dateFormat X
axisFormat %s
section baseline
no_agent (377.787 µs) : 358, 398
. : milestone, 378,
iast (503.9 µs) : 482, 526
. : milestone, 504,
iast_FULL (735.292 µs) : 713, 757
. : milestone, 735,
iast_GLOBAL (553.328 µs) : 531, 576
. : milestone, 553,
iast_HARDCODED_SECRET_DISABLED (502.452 µs) : 481, 524
. : milestone, 502,
iast_INACTIVE (451.557 µs) : 430, 473
. : milestone, 452,
iast_TELEMETRY_OFF (491.349 µs) : 470, 513
. : milestone, 491,
tracing (442.96 µs) : 422, 464
. : milestone, 443,
section candidate
no_agent (379.813 µs) : 360, 399
. : milestone, 380,
iast (499.272 µs) : 478, 521
. : milestone, 499,
iast_FULL (738.259 µs) : 716, 760
. : milestone, 738,
iast_GLOBAL (538.968 µs) : 517, 561
. : milestone, 539,
iast_HARDCODED_SECRET_DISABLED (501.857 µs) : 480, 523
. : milestone, 502,
iast_INACTIVE (456.758 µs) : 435, 479
. : milestone, 457,
iast_TELEMETRY_OFF (483.937 µs) : 462, 505
. : milestone, 484,
tracing (441.481 µs) : 421, 462
. : milestone, 441,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~cec10308c9, baseline=1.46.0-SNAPSHOT~148aef92ab
dateFormat X
axisFormat %s
section baseline
no_agent (1.344 ms) : 1325, 1364
. : milestone, 1344,
appsec (1.742 ms) : 1718, 1766
. : milestone, 1742,
appsec_no_iast (1.758 ms) : 1733, 1782
. : milestone, 1758,
iast (1.491 ms) : 1466, 1516
. : milestone, 1491,
profiling (1.542 ms) : 1517, 1567
. : milestone, 1542,
tracing (1.488 ms) : 1464, 1511
. : milestone, 1488,
section candidate
no_agent (1.36 ms) : 1341, 1380
. : milestone, 1360,
appsec (1.749 ms) : 1725, 1774
. : milestone, 1749,
appsec_no_iast (1.733 ms) : 1710, 1757
. : milestone, 1733,
iast (1.487 ms) : 1463, 1512
. : milestone, 1487,
profiling (1.498 ms) : 1474, 1521
. : milestone, 1498,
tracing (1.5 ms) : 1476, 1524
. : milestone, 1500,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~cec10308c9, baseline=1.46.0-SNAPSHOT~148aef92ab
dateFormat X
axisFormat %s
section baseline
no_agent (15.436 s) : 15436000, 15436000
. : milestone, 15436000,
appsec (15.051 s) : 15051000, 15051000
. : milestone, 15051000,
iast (18.66 s) : 18660000, 18660000
. : milestone, 18660000,
iast_GLOBAL (18.213 s) : 18213000, 18213000
. : milestone, 18213000,
profiling (15.68 s) : 15680000, 15680000
. : milestone, 15680000,
tracing (15.067 s) : 15067000, 15067000
. : milestone, 15067000,
section candidate
no_agent (14.947 s) : 14947000, 14947000
. : milestone, 14947000,
appsec (15.094 s) : 15094000, 15094000
. : milestone, 15094000,
iast (18.891 s) : 18891000, 18891000
. : milestone, 18891000,
iast_GLOBAL (18.127 s) : 18127000, 18127000
. : milestone, 18127000,
profiling (15.027 s) : 15027000, 15027000
. : milestone, 15027000,
tracing (14.718 s) : 14718000, 14718000
. : milestone, 14718000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~cec10308c9, baseline=1.46.0-SNAPSHOT~148aef92ab
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (2.367 ms) : 2324, 2410
. : milestone, 2367,
iast (2.109 ms) : 2055, 2164
. : milestone, 2109,
iast_GLOBAL (2.155 ms) : 2100, 2209
. : milestone, 2155,
profiling (2.462 ms) : 2274, 2649
. : milestone, 2462,
tracing (1.948 ms) : 1906, 1989
. : milestone, 1948,
section candidate
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (2.367 ms) : 2324, 2410
. : milestone, 2367,
iast (2.102 ms) : 2048, 2157
. : milestone, 2102,
iast_GLOBAL (2.15 ms) : 2096, 2205
. : milestone, 2150,
profiling (1.961 ms) : 1917, 2004
. : milestone, 1961,
tracing (1.934 ms) : 1893, 1975
. : milestone, 1934,
|
mcculls
approved these changes
Jan 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR fixes the CircleCI builder image configuration (no
-baseshould be included, only the base of the tag)Motivation
Additional Notes
This is a follow up PR of #8206
I could not find a way to test locally without messing with repository PRs.
At some point, I stopped testing on prod and this bug slipped in 😬
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: LANGPLAT-82