Skip to content

Make sure background/shutdown threads are in AGENT_THREAD_GROUP#8217

Merged
mcculls merged 1 commit intomasterfrom
mcculls/shutdown-threads-should-be-in-agent-thread-group
Jan 16, 2025
Merged

Make sure background/shutdown threads are in AGENT_THREAD_GROUP#8217
mcculls merged 1 commit intomasterfrom
mcculls/shutdown-threads-should-be-in-agent-thread-group

Conversation

@mcculls
Copy link
Copy Markdown
Contributor

@mcculls mcculls commented Jan 15, 2025 •
edited
Loading

Motivation

We use the thread group to avoid doing certain work (such as exception profiling) on our own threads.

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@mcculls mcculls added type: enhancement Enhancements and improvements comp: core Tracer core tag: no release notes Changes to exclude from release notes labels Jan 15, 2025
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Jan 15, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/shutdown-threads-should-be-in-agent-thread-group
git_commit_date 1736975505 1736979509
git_commit_sha 6ece325 a3ab61d
release_version 1.46.0-SNAPSHOT~6ece325a84 1.46.0-SNAPSHOT~a3ab61d264
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1736982151 1736982151
ci_job_id 768272803 768272803
ci_pipeline_id 53137092 53137092
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 4 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~a3ab61d264, baseline=1.46.0-SNAPSHOT~6ece325a84

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1056297
Total [baseline] (10.475 s) : 0, 10475168
Agent [candidate] (1.069 s) : 0, 1068893
Total [candidate] (10.528 s) : 0, 10527738
section appsec
Agent [baseline] (1.195 s) : 0, 1194699
Total [baseline] (10.726 s) : 0, 10726417
Agent [candidate] (1.192 s) : 0, 1192129
Total [candidate] (10.729 s) : 0, 10728765
section iast
Agent [baseline] (1.185 s) : 0, 1185347
Total [baseline] (10.997 s) : 0, 10997168
Agent [candidate] (1.197 s) : 0, 1196769
Total [candidate] (11.093 s) : 0, 11092514
section profiling
Agent [baseline] (1.256 s) : 0, 1256076
Total [baseline] (10.76 s) : 0, 10759763
Agent [candidate] (1.268 s) : 0, 1268479
Total [candidate] (10.926 s) : 0, 10926107
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.056 s -
Agent appsec 1.195 s 138.402 ms (13.1%)
Agent iast 1.185 s 129.05 ms (12.2%)
Agent profiling 1.256 s 199.779 ms (18.9%)
Total tracing 10.475 s -
Total appsec 10.726 s 251.249 ms (2.4%)
Total iast 10.997 s 522.0 ms (5.0%)
Total profiling 10.76 s 284.595 ms (2.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.069 s -
Agent appsec 1.192 s 123.236 ms (11.5%)
Agent iast 1.197 s 127.876 ms (12.0%)
Agent profiling 1.268 s 199.586 ms (18.7%)
Total tracing 10.528 s -
Total appsec 10.729 s 201.028 ms (1.9%)
Total iast 11.093 s 564.776 ms (5.4%)
Total profiling 10.926 s 398.369 ms (3.8%) 
gantt
    title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~a3ab61d264, baseline=1.46.0-SNAPSHOT~6ece325a84

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (714.124 ms) : 0, 714124
BytebuddyAgent [candidate] (723.183 ms) : 0, 723183
GlobalTracer [baseline] (255.392 ms) : 0, 255392
GlobalTracer [candidate] (259.547 ms) : 0, 259547
AppSec [baseline] (55.929 ms) : 0, 55929
AppSec [candidate] (56.176 ms) : 0, 56176
Remote Config [baseline] (718.315 µs) : 0, 718
Remote Config [candidate] (741.404 µs) : 0, 741
Telemetry [baseline] (15.094 ms) : 0, 15094
Telemetry [candidate] (13.965 ms) : 0, 13965
section appsec
BytebuddyAgent [baseline] (735.965 ms) : 0, 735965
BytebuddyAgent [candidate] (733.137 ms) : 0, 733137
GlobalTracer [baseline] (254.469 ms) : 0, 254469
GlobalTracer [candidate] (254.105 ms) : 0, 254105
AppSec [baseline] (170.661 ms) : 0, 170661
AppSec [candidate] (171.199 ms) : 0, 171199
Remote Config [baseline] (668.558 µs) : 0, 669
Remote Config [candidate] (665.581 µs) : 0, 666
Telemetry [baseline] (8.183 ms) : 0, 8183
Telemetry [candidate] (8.223 ms) : 0, 8223
IAST [baseline] (19.342 ms) : 0, 19342
IAST [candidate] (19.481 ms) : 0, 19481
section iast
BytebuddyAgent [baseline] (833.288 ms) : 0, 833288
BytebuddyAgent [candidate] (841.859 ms) : 0, 841859
GlobalTracer [baseline] (247.707 ms) : 0, 247707
GlobalTracer [candidate] (249.278 ms) : 0, 249278
AppSec [baseline] (58.073 ms) : 0, 58073
AppSec [candidate] (58.706 ms) : 0, 58706
Remote Config [baseline] (683.084 µs) : 0, 683
Remote Config [candidate] (688.138 µs) : 0, 688
Telemetry [baseline] (8.842 ms) : 0, 8842
Telemetry [candidate] (8.967 ms) : 0, 8967
IAST [baseline] (21.71 ms) : 0, 21710
IAST [candidate] (22.029 ms) : 0, 22029
section profiling
BytebuddyAgent [baseline] (703.901 ms) : 0, 703901
BytebuddyAgent [candidate] (711.166 ms) : 0, 711166
GlobalTracer [baseline] (350.381 ms) : 0, 350381
GlobalTracer [candidate] (353.552 ms) : 0, 353552
AppSec [baseline] (54.801 ms) : 0, 54801
AppSec [candidate] (54.787 ms) : 0, 54787
Remote Config [baseline] (675.783 µs) : 0, 676
Remote Config [candidate] (680.537 µs) : 0, 681
Telemetry [baseline] (8.886 ms) : 0, 8886
Telemetry [candidate] (9.041 ms) : 0, 9041
ProfilingAgent [baseline] (95.521 ms) : 0, 95521
ProfilingAgent [candidate] (96.915 ms) : 0, 96915
Profiling [baseline] (95.548 ms) : 0, 95548
Profiling [candidate] (96.944 ms) : 0, 96944
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~a3ab61d264, baseline=1.46.0-SNAPSHOT~6ece325a84

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.057 s) : 0, 1056548
Total [baseline] (8.644 s) : 0, 8644406
Agent [candidate] (1.055 s) : 0, 1055289
Total [candidate] (8.683 s) : 0, 8683002
section iast
Agent [baseline] (1.193 s) : 0, 1192873
Total [baseline] (9.287 s) : 0, 9287487
Agent [candidate] (1.192 s) : 0, 1191667
Total [candidate] (9.277 s) : 0, 9277443
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.184 s) : 0, 1184498
Total [baseline] (9.186 s) : 0, 9186031
Agent [candidate] (1.192 s) : 0, 1191934
Total [candidate] (9.245 s) : 0, 9245361
section iast_TELEMETRY_OFF
Agent [baseline] (1.181 s) : 0, 1180941
Total [baseline] (9.308 s) : 0, 9307912
Agent [candidate] (1.193 s) : 0, 1192900
Total [candidate] (9.249 s) : 0, 9248914
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.057 s -
Agent iast 1.193 s 136.326 ms (12.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.184 s 127.95 ms (12.1%)
Agent iast_TELEMETRY_OFF 1.181 s 124.393 ms (11.8%)
Total tracing 8.644 s -
Total iast 9.287 s 643.082 ms (7.4%)
Total iast_HARDCODED_SECRET_DISABLED 9.186 s 541.625 ms (6.3%)
Total iast_TELEMETRY_OFF 9.308 s 663.506 ms (7.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.055 s -
Agent iast 1.192 s 136.378 ms (12.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.192 s 136.646 ms (12.9%)
Agent iast_TELEMETRY_OFF 1.193 s 137.611 ms (13.0%)
Total tracing 8.683 s -
Total iast 9.277 s 594.441 ms (6.8%)
Total iast_HARDCODED_SECRET_DISABLED 9.245 s 562.359 ms (6.5%)
Total iast_TELEMETRY_OFF 9.249 s 565.912 ms (6.5%) 
gantt
    title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~a3ab61d264, baseline=1.46.0-SNAPSHOT~6ece325a84

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (714.679 ms) : 0, 714679
BytebuddyAgent [candidate] (715.314 ms) : 0, 715314
GlobalTracer [baseline] (256.244 ms) : 0, 256244
GlobalTracer [candidate] (255.825 ms) : 0, 255825
AppSec [baseline] (56.728 ms) : 0, 56728
AppSec [candidate] (56.193 ms) : 0, 56193
Remote Config [baseline] (746.068 µs) : 0, 746
Remote Config [candidate] (716.221 µs) : 0, 716
Telemetry [baseline] (13.174 ms) : 0, 13174
Telemetry [candidate] (12.255 ms) : 0, 12255
section iast
BytebuddyAgent [baseline] (839.682 ms) : 0, 839682
BytebuddyAgent [candidate] (836.514 ms) : 0, 836514
GlobalTracer [baseline] (248.598 ms) : 0, 248598
GlobalTracer [candidate] (249.706 ms) : 0, 249706
AppSec [baseline] (58.21 ms) : 0, 58210
AppSec [candidate] (58.613 ms) : 0, 58613
Remote Config [baseline] (682.341 µs) : 0, 682
Remote Config [candidate] (689.785 µs) : 0, 690
Telemetry [baseline] (8.867 ms) : 0, 8867
Telemetry [candidate] (8.979 ms) : 0, 8979
IAST [baseline] (21.633 ms) : 0, 21633
IAST [candidate] (22.08 ms) : 0, 22080
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (833.38 ms) : 0, 833380
BytebuddyAgent [candidate] (838.986 ms) : 0, 838986
GlobalTracer [baseline] (246.964 ms) : 0, 246964
GlobalTracer [candidate] (247.86 ms) : 0, 247860
AppSec [baseline] (57.976 ms) : 0, 57976
AppSec [candidate] (58.646 ms) : 0, 58646
Remote Config [baseline] (683.681 µs) : 0, 684
Remote Config [candidate] (671.43 µs) : 0, 671
Telemetry [baseline] (8.839 ms) : 0, 8839
Telemetry [candidate] (8.917 ms) : 0, 8917
IAST [baseline] (21.619 ms) : 0, 21619
IAST [candidate] (21.646 ms) : 0, 21646
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (828.855 ms) : 0, 828855
BytebuddyAgent [candidate] (839.166 ms) : 0, 839166
GlobalTracer [baseline] (248.488 ms) : 0, 248488
GlobalTracer [candidate] (249.189 ms) : 0, 249189
AppSec [baseline] (58.086 ms) : 0, 58086
AppSec [candidate] (58.447 ms) : 0, 58447
Remote Config [baseline] (677.915 µs) : 0, 678
Remote Config [candidate] (697.187 µs) : 0, 697
Telemetry [baseline] (8.719 ms) : 0, 8719
Telemetry [candidate] (8.79 ms) : 0, 8790
IAST [baseline] (21.148 ms) : 0, 21148
IAST [candidate] (21.404 ms) : 0, 21404
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-01-15T22:32:25 2025-01-15T22:39:33
git_branch master mcculls/shutdown-threads-should-be-in-agent-thread-group
git_commit_date 1736975505 1736979509
git_commit_sha 6ece325 a3ab61d
release_version 1.46.0-SNAPSHOT~6ece325a84 1.46.0-SNAPSHOT~a3ab61d264
start_time 2025-01-15T22:32:10 2025-01-15T22:39:19
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1736981133 1736981133
ci_job_id 768272804 768272804
ci_pipeline_id 53137092 53137092
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~a3ab61d264, baseline=1.46.0-SNAPSHOT~6ece325a84
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.376 ms) : 1356, 1395
.   : milestone, 1376,
appsec (1.755 ms) : 1731, 1779
.   : milestone, 1755,
appsec_no_iast (1.769 ms) : 1746, 1792
.   : milestone, 1769,
iast (1.538 ms) : 1514, 1562
.   : milestone, 1538,
profiling (1.553 ms) : 1527, 1578
.   : milestone, 1553,
tracing (1.527 ms) : 1499, 1555
.   : milestone, 1527,
section candidate
no_agent (1.362 ms) : 1342, 1381
.   : milestone, 1362,
appsec (1.748 ms) : 1724, 1771
.   : milestone, 1748,
appsec_no_iast (1.8 ms) : 1777, 1823
.   : milestone, 1800,
iast (1.522 ms) : 1497, 1547
.   : milestone, 1522,
profiling (1.518 ms) : 1495, 1541
.   : milestone, 1518,
tracing (1.513 ms) : 1489, 1537
.   : milestone, 1513,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.376 ms [1.356 ms, 1.395 ms] -
appsec 1.755 ms [1.731 ms, 1.779 ms] 378.922 µs (27.5%)
appsec_no_iast 1.769 ms [1.746 ms, 1.792 ms] 393.192 µs (28.6%)
iast 1.538 ms [1.514 ms, 1.562 ms] 162.464 µs (11.8%)
profiling 1.553 ms [1.527 ms, 1.578 ms] 177.151 µs (12.9%)
tracing 1.527 ms [1.499 ms, 1.555 ms] 151.228 µs (11.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.362 ms [1.342 ms, 1.381 ms] -
appsec 1.748 ms [1.724 ms, 1.771 ms] 386.003 µs (28.3%)
appsec_no_iast 1.8 ms [1.777 ms, 1.823 ms] 437.83 µs (32.2%)
iast 1.522 ms [1.497 ms, 1.547 ms] 160.084 µs (11.8%)
profiling 1.518 ms [1.495 ms, 1.541 ms] 156.038 µs (11.5%)
tracing 1.513 ms [1.489 ms, 1.537 ms] 151.213 µs (11.1%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~a3ab61d264, baseline=1.46.0-SNAPSHOT~6ece325a84
    dateFormat X
    axisFormat %s
section baseline
no_agent (384.95 µs) : 364, 406
.   : milestone, 385,
iast (516.043 µs) : 494, 538
.   : milestone, 516,
iast_FULL (747.86 µs) : 725, 771
.   : milestone, 748,
iast_GLOBAL (558.527 µs) : 537, 580
.   : milestone, 559,
iast_HARDCODED_SECRET_DISABLED (516.647 µs) : 495, 538
.   : milestone, 517,
iast_INACTIVE (473.093 µs) : 451, 495
.   : milestone, 473,
iast_TELEMETRY_OFF (501.811 µs) : 480, 523
.   : milestone, 502,
tracing (459.222 µs) : 438, 480
.   : milestone, 459,
section candidate
no_agent (385.118 µs) : 365, 406
.   : milestone, 385,
iast (514.926 µs) : 492, 538
.   : milestone, 515,
iast_FULL (747.989 µs) : 726, 770
.   : milestone, 748,
iast_GLOBAL (566.419 µs) : 543, 590
.   : milestone, 566,
iast_HARDCODED_SECRET_DISABLED (515.694 µs) : 494, 537
.   : milestone, 516,
iast_INACTIVE (465.169 µs) : 443, 487
.   : milestone, 465,
iast_TELEMETRY_OFF (497.847 µs) : 476, 519
.   : milestone, 498,
tracing (458.795 µs) : 438, 480
.   : milestone, 459,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 384.95 µs [364.09 µs, 405.811 µs] -
iast 516.043 µs [493.742 µs, 538.344 µs] 131.092 µs (34.1%)
iast_FULL 747.86 µs [724.721 µs, 770.998 µs] 362.91 µs (94.3%)
iast_GLOBAL 558.527 µs [536.872 µs, 580.182 µs] 173.576 µs (45.1%)
iast_HARDCODED_SECRET_DISABLED 516.647 µs [495.004 µs, 538.29 µs] 131.697 µs (34.2%)
iast_INACTIVE 473.093 µs [451.113 µs, 495.073 µs] 88.143 µs (22.9%)
iast_TELEMETRY_OFF 501.811 µs [480.449 µs, 523.172 µs] 116.86 µs (30.4%)
tracing 459.222 µs [438.434 µs, 480.01 µs] 74.272 µs (19.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 385.118 µs [364.713 µs, 405.524 µs] -
iast 514.926 µs [492.096 µs, 537.757 µs] 129.808 µs (33.7%)
iast_FULL 747.989 µs [725.923 µs, 770.054 µs] 362.87 µs (94.2%)
iast_GLOBAL 566.419 µs [543.107 µs, 589.731 µs] 181.301 µs (47.1%)
iast_HARDCODED_SECRET_DISABLED 515.694 µs [493.986 µs, 537.401 µs] 130.575 µs (33.9%)
iast_INACTIVE 465.169 µs [442.943 µs, 487.395 µs] 80.05 µs (20.8%)
iast_TELEMETRY_OFF 497.847 µs [476.333 µs, 519.361 µs] 112.729 µs (29.3%)
tracing 458.795 µs [437.941 µs, 479.65 µs] 73.677 µs (19.1%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/shutdown-threads-should-be-in-agent-thread-group
git_commit_date 1736975505 1736979509
git_commit_sha 6ece325 a3ab61d
release_version 1.46.0-SNAPSHOT~6ece325a84 1.46.0-SNAPSHOT~a3ab61d264
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1736981704 1736981704
ci_job_id 768272805 768272805
ci_pipeline_id 53137092 53137092
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~a3ab61d264, baseline=1.46.0-SNAPSHOT~6ece325a84
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.886 s) : 14886000, 14886000
.   : milestone, 14886000,
appsec (15.211 s) : 15211000, 15211000
.   : milestone, 15211000,
iast (18.944 s) : 18944000, 18944000
.   : milestone, 18944000,
iast_GLOBAL (17.982 s) : 17982000, 17982000
.   : milestone, 17982000,
profiling (15.155 s) : 15155000, 15155000
.   : milestone, 15155000,
tracing (14.938 s) : 14938000, 14938000
.   : milestone, 14938000,
section candidate
no_agent (15.442 s) : 15442000, 15442000
.   : milestone, 15442000,
appsec (15.056 s) : 15056000, 15056000
.   : milestone, 15056000,
iast (18.952 s) : 18952000, 18952000
.   : milestone, 18952000,
iast_GLOBAL (18.114 s) : 18114000, 18114000
.   : milestone, 18114000,
profiling (15.067 s) : 15067000, 15067000
.   : milestone, 15067000,
tracing (15.019 s) : 15019000, 15019000
.   : milestone, 15019000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.886 s [14.886 s, 14.886 s] -
appsec 15.211 s [15.211 s, 15.211 s] 325.0 ms (2.2%)
iast 18.944 s [18.944 s, 18.944 s] 4.058 s (27.3%)
iast_GLOBAL 17.982 s [17.982 s, 17.982 s] 3.096 s (20.8%)
profiling 15.155 s [15.155 s, 15.155 s] 269.0 ms (1.8%)
tracing 14.938 s [14.938 s, 14.938 s] 52.0 ms (0.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.442 s [15.442 s, 15.442 s] -
appsec 15.056 s [15.056 s, 15.056 s] -386.0 ms (-2.5%)
iast 18.952 s [18.952 s, 18.952 s] 3.51 s (22.7%)
iast_GLOBAL 18.114 s [18.114 s, 18.114 s] 2.672 s (17.3%)
profiling 15.067 s [15.067 s, 15.067 s] -375.0 ms (-2.4%)
tracing 15.019 s [15.019 s, 15.019 s] -423.0 ms (-2.7%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~a3ab61d264, baseline=1.46.0-SNAPSHOT~6ece325a84
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.467 ms) : 1456, 1478
.   : milestone, 1467,
appsec (2.348 ms) : 2305, 2391
.   : milestone, 2348,
iast (2.108 ms) : 2053, 2162
.   : milestone, 2108,
iast_GLOBAL (2.152 ms) : 2097, 2207
.   : milestone, 2152,
profiling (1.987 ms) : 1942, 2031
.   : milestone, 1987,
tracing (1.943 ms) : 1901, 1984
.   : milestone, 1943,
section candidate
no_agent (1.471 ms) : 1459, 1482
.   : milestone, 1471,
appsec (2.357 ms) : 2314, 2400
.   : milestone, 2357,
iast (2.109 ms) : 2055, 2164
.   : milestone, 2109,
iast_GLOBAL (2.141 ms) : 2086, 2196
.   : milestone, 2141,
profiling (1.959 ms) : 1916, 2002
.   : milestone, 1959,
tracing (1.937 ms) : 1896, 1979
.   : milestone, 1937,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.467 ms [1.456 ms, 1.478 ms] -
appsec 2.348 ms [2.305 ms, 2.391 ms] 881.224 µs (60.1%)
iast 2.108 ms [2.053 ms, 2.162 ms] 640.982 µs (43.7%)
iast_GLOBAL 2.152 ms [2.097 ms, 2.207 ms] 685.127 µs (46.7%)
profiling 1.987 ms [1.942 ms, 2.031 ms] 519.763 µs (35.4%)
tracing 1.943 ms [1.901 ms, 1.984 ms] 475.673 µs (32.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.471 ms [1.459 ms, 1.482 ms] -
appsec 2.357 ms [2.314 ms, 2.4 ms] 886.014 µs (60.2%)
iast 2.109 ms [2.055 ms, 2.164 ms] 638.733 µs (43.4%)
iast_GLOBAL 2.141 ms [2.086 ms, 2.196 ms] 670.327 µs (45.6%)
profiling 1.959 ms [1.916 ms, 2.002 ms] 488.552 µs (33.2%)
tracing 1.937 ms [1.896 ms, 1.979 ms] 466.701 µs (31.7%)

@mcculls mcculls marked this pull request as ready for review January 16, 2025 01:09
@mcculls mcculls requested a review from a team as a code owner January 16, 2025 01:09
@mcculls mcculls enabled auto-merge (squash) January 16, 2025 01:09
amarziali
amarziali approved these changes Jan 16, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@amarziali amarziali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@mcculls mcculls merged commit 9b06903 into master Jan 16, 2025
@mcculls mcculls deleted the mcculls/shutdown-threads-should-be-in-agent-thread-group branch January 16, 2025 08:55
@github-actions github-actions Bot added this to the 1.46.0 milestone Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amarziali amarziali amarziali approved these changes

Assignees

No one assigned

Labels

comp: core Tracer core tag: no release notes Changes to exclude from release notes type: enhancement Enhancements and improvements

Projects

None yet

Milestone

1.46.0

Development

Successfully merging this pull request may close these issues.

2 participants

@mcculls @amarziali