Fix NPE in logic that parses flaky tests list#8070
Merged
nikita-tkachenko-datadog merged 2 commits intomasterfrom Dec 9, 2024
Merged
Fix NPE in logic that parses flaky tests list#8070nikita-tkachenko-datadog merged 2 commits intomasterfrom
nikita-tkachenko-datadog merged 2 commits intomasterfrom
Conversation
romainkomorn-exdatadog
approved these changes
Dec 9, 2024
daniel-mohedano
approved these changes
Dec 9, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.44.0-SNAPSHOT~e90472b827, baseline=1.44.0-SNAPSHOT~88c9405c96
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.093 s) : 0, 1093109
Total [baseline] (8.687 s) : 0, 8687191
Agent [candidate] (1.102 s) : 0, 1101700
Total [candidate] (8.681 s) : 0, 8680504
section iast
Agent [baseline] (1.223 s) : 0, 1222824
Total [baseline] (9.218 s) : 0, 9218067
Agent [candidate] (1.229 s) : 0, 1229251
Total [candidate] (9.246 s) : 0, 9245670
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.22 s) : 0, 1220061
Total [baseline] (9.17 s) : 0, 9170003
Agent [candidate] (1.219 s) : 0, 1219066
Total [candidate] (9.161 s) : 0, 9161292
section iast_TELEMETRY_OFF
Agent [baseline] (1.222 s) : 0, 1221692
Total [baseline] (9.209 s) : 0, 9208523
Agent [candidate] (1.218 s) : 0, 1218353
Total [candidate] (9.181 s) : 0, 9180985
gantt
title insecure-bank - break down per module: candidate=1.44.0-SNAPSHOT~e90472b827, baseline=1.44.0-SNAPSHOT~88c9405c96
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (695.996 ms) : 0, 695996
BytebuddyAgent [candidate] (700.581 ms) : 0, 700581
GlobalTracer [baseline] (318.652 ms) : 0, 318652
GlobalTracer [candidate] (320.847 ms) : 0, 320847
AppSec [baseline] (54.741 ms) : 0, 54741
AppSec [candidate] (55.137 ms) : 0, 55137
Remote Config [baseline] (695.171 µs) : 0, 695
Remote Config [candidate] (699.096 µs) : 0, 699
Telemetry [baseline] (9.268 ms) : 0, 9268
Telemetry [candidate] (10.543 ms) : 0, 10543
section iast
BytebuddyAgent [baseline] (814.306 ms) : 0, 814306
BytebuddyAgent [candidate] (818.962 ms) : 0, 818962
GlobalTracer [baseline] (306.999 ms) : 0, 306999
GlobalTracer [candidate] (308.565 ms) : 0, 308565
AppSec [baseline] (56.576 ms) : 0, 56576
AppSec [candidate] (57.492 ms) : 0, 57492
IAST [baseline] (22.922 ms) : 0, 22922
IAST [candidate] (22.003 ms) : 0, 22003
Remote Config [baseline] (635.84 µs) : 0, 636
Remote Config [candidate] (643.765 µs) : 0, 644
Telemetry [baseline] (7.602 ms) : 0, 7602
Telemetry [candidate] (7.646 ms) : 0, 7646
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (812.659 ms) : 0, 812659
BytebuddyAgent [candidate] (811.916 ms) : 0, 811916
GlobalTracer [baseline] (306.556 ms) : 0, 306556
GlobalTracer [candidate] (306.47 ms) : 0, 306470
AppSec [baseline] (57.182 ms) : 0, 57182
AppSec [candidate] (56.874 ms) : 0, 56874
IAST [baseline] (21.688 ms) : 0, 21688
IAST [candidate] (21.833 ms) : 0, 21833
Remote Config [baseline] (634.74 µs) : 0, 635
Remote Config [candidate] (633.057 µs) : 0, 633
Telemetry [baseline] (7.557 ms) : 0, 7557
Telemetry [candidate] (7.544 ms) : 0, 7544
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (812.158 ms) : 0, 812158
BytebuddyAgent [candidate] (811.091 ms) : 0, 811091
GlobalTracer [baseline] (308.368 ms) : 0, 308368
GlobalTracer [candidate] (307.132 ms) : 0, 307132
AppSec [baseline] (57.547 ms) : 0, 57547
AppSec [candidate] (57.994 ms) : 0, 57994
IAST [baseline] (21.592 ms) : 0, 21592
IAST [candidate] (20.333 ms) : 0, 20333
Remote Config [baseline] (649.227 µs) : 0, 649
Remote Config [candidate] (618.949 µs) : 0, 619
Telemetry [baseline] (7.574 ms) : 0, 7574
Telemetry [candidate] (7.396 ms) : 0, 7396
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.44.0-SNAPSHOT~e90472b827, baseline=1.44.0-SNAPSHOT~88c9405c96
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.092 s) : 0, 1091588
Total [baseline] (10.397 s) : 0, 10397103
Agent [candidate] (1.091 s) : 0, 1091044
Total [candidate] (10.437 s) : 0, 10436999
section appsec
Agent [baseline] (1.226 s) : 0, 1225578
Total [baseline] (10.696 s) : 0, 10695812
Agent [candidate] (1.232 s) : 0, 1231563
Total [candidate] (10.774 s) : 0, 10774261
section iast
Agent [baseline] (1.232 s) : 0, 1232195
Total [baseline] (10.964 s) : 0, 10963663
Agent [candidate] (1.222 s) : 0, 1221794
Total [candidate] (10.948 s) : 0, 10947888
section profiling
Agent [baseline] (1.327 s) : 0, 1327077
Total [baseline] (10.823 s) : 0, 10822644
Agent [candidate] (1.323 s) : 0, 1323491
Total [candidate] (10.842 s) : 0, 10842483
gantt
title petclinic - break down per module: candidate=1.44.0-SNAPSHOT~e90472b827, baseline=1.44.0-SNAPSHOT~88c9405c96
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (693.934 ms) : 0, 693934
BytebuddyAgent [candidate] (695.603 ms) : 0, 695603
GlobalTracer [baseline] (317.94 ms) : 0, 317940
GlobalTracer [candidate] (318.462 ms) : 0, 318462
AppSec [baseline] (54.66 ms) : 0, 54660
AppSec [candidate] (54.772 ms) : 0, 54772
Remote Config [baseline] (698.332 µs) : 0, 698
Remote Config [candidate] (687.279 µs) : 0, 687
Telemetry [baseline] (10.626 ms) : 0, 10626
Telemetry [candidate] (7.723 ms) : 0, 7723
section appsec
BytebuddyAgent [baseline] (711.715 ms) : 0, 711715
BytebuddyAgent [candidate] (714.883 ms) : 0, 714883
GlobalTracer [baseline] (314.447 ms) : 0, 314447
GlobalTracer [candidate] (316.787 ms) : 0, 316787
AppSec [baseline] (166.222 ms) : 0, 166222
AppSec [candidate] (168.087 ms) : 0, 168087
IAST [baseline] (21.274 ms) : 0, 21274
IAST [candidate] (19.08 ms) : 0, 19080
Remote Config [baseline] (682.414 µs) : 0, 682
Remote Config [candidate] (647.797 µs) : 0, 648
Telemetry [baseline] (8.113 ms) : 0, 8113
Telemetry [candidate] (7.784 ms) : 0, 7784
section iast
BytebuddyAgent [baseline] (821.25 ms) : 0, 821250
BytebuddyAgent [candidate] (813.945 ms) : 0, 813945
GlobalTracer [baseline] (308.824 ms) : 0, 308824
GlobalTracer [candidate] (306.703 ms) : 0, 306703
AppSec [baseline] (58.655 ms) : 0, 58655
AppSec [candidate] (57.24 ms) : 0, 57240
IAST [baseline] (21.242 ms) : 0, 21242
IAST [candidate] (21.892 ms) : 0, 21892
Remote Config [baseline] (653.731 µs) : 0, 654
Remote Config [candidate] (655.436 µs) : 0, 655
Telemetry [baseline] (7.641 ms) : 0, 7641
Telemetry [candidate] (7.575 ms) : 0, 7575
section profiling
BytebuddyAgent [baseline] (694.97 ms) : 0, 694970
BytebuddyAgent [candidate] (694.03 ms) : 0, 694030
GlobalTracer [baseline] (435.543 ms) : 0, 435543
GlobalTracer [candidate] (433.933 ms) : 0, 433933
AppSec [baseline] (53.885 ms) : 0, 53885
AppSec [candidate] (53.693 ms) : 0, 53693
Remote Config [baseline] (665.271 µs) : 0, 665
Remote Config [candidate] (665.813 µs) : 0, 666
Telemetry [baseline] (7.801 ms) : 0, 7801
Telemetry [candidate] (7.694 ms) : 0, 7694
ProfilingAgent [baseline] (94.699 ms) : 0, 94699
ProfilingAgent [candidate] (94.017 ms) : 0, 94017
Profiling [baseline] (94.723 ms) : 0, 94723
Profiling [candidate] (94.041 ms) : 0, 94041
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~e90472b827, baseline=1.44.0-SNAPSHOT~88c9405c96
dateFormat X
axisFormat %s
section baseline
no_agent (1.355 ms) : 1335, 1375
. : milestone, 1355,
appsec (1.736 ms) : 1710, 1761
. : milestone, 1736,
appsec_no_iast (1.743 ms) : 1718, 1768
. : milestone, 1743,
iast (1.503 ms) : 1480, 1526
. : milestone, 1503,
profiling (1.497 ms) : 1473, 1520
. : milestone, 1497,
tracing (1.494 ms) : 1470, 1518
. : milestone, 1494,
section candidate
no_agent (1.357 ms) : 1338, 1377
. : milestone, 1357,
appsec (1.763 ms) : 1739, 1786
. : milestone, 1763,
appsec_no_iast (1.721 ms) : 1696, 1746
. : milestone, 1721,
iast (1.52 ms) : 1498, 1543
. : milestone, 1520,
profiling (1.511 ms) : 1488, 1535
. : milestone, 1511,
tracing (1.484 ms) : 1459, 1508
. : milestone, 1484,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~e90472b827, baseline=1.44.0-SNAPSHOT~88c9405c96
dateFormat X
axisFormat %s
section baseline
no_agent (372.078 µs) : 353, 392
. : milestone, 372,
iast (489.689 µs) : 468, 511
. : milestone, 490,
iast_FULL (652.876 µs) : 631, 674
. : milestone, 653,
iast_GLOBAL (523.693 µs) : 501, 546
. : milestone, 524,
iast_HARDCODED_SECRET_DISABLED (494.68 µs) : 472, 517
. : milestone, 495,
iast_INACTIVE (443.752 µs) : 423, 464
. : milestone, 444,
iast_TELEMETRY_OFF (479.932 µs) : 458, 502
. : milestone, 480,
tracing (451.648 µs) : 431, 473
. : milestone, 452,
section candidate
no_agent (375.783 µs) : 356, 395
. : milestone, 376,
iast (491.327 µs) : 470, 513
. : milestone, 491,
iast_FULL (647.848 µs) : 626, 669
. : milestone, 648,
iast_GLOBAL (521.789 µs) : 499, 544
. : milestone, 522,
iast_HARDCODED_SECRET_DISABLED (496.376 µs) : 475, 518
. : milestone, 496,
iast_INACTIVE (452.617 µs) : 432, 474
. : milestone, 453,
iast_TELEMETRY_OFF (476.296 µs) : 455, 498
. : milestone, 476,
tracing (451.638 µs) : 430, 474
. : milestone, 452,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~e90472b827, baseline=1.44.0-SNAPSHOT~88c9405c96
dateFormat X
axisFormat %s
section baseline
no_agent (15.356 s) : 15356000, 15356000
. : milestone, 15356000,
appsec (15.045 s) : 15045000, 15045000
. : milestone, 15045000,
iast (18.712 s) : 18712000, 18712000
. : milestone, 18712000,
iast_GLOBAL (18.052 s) : 18052000, 18052000
. : milestone, 18052000,
profiling (15.109 s) : 15109000, 15109000
. : milestone, 15109000,
tracing (15.048 s) : 15048000, 15048000
. : milestone, 15048000,
section candidate
no_agent (15.484 s) : 15484000, 15484000
. : milestone, 15484000,
appsec (14.837 s) : 14837000, 14837000
. : milestone, 14837000,
iast (19.178 s) : 19178000, 19178000
. : milestone, 19178000,
iast_GLOBAL (17.964 s) : 17964000, 17964000
. : milestone, 17964000,
profiling (14.97 s) : 14970000, 14970000
. : milestone, 14970000,
tracing (15.137 s) : 15137000, 15137000
. : milestone, 15137000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~e90472b827, baseline=1.44.0-SNAPSHOT~88c9405c96
dateFormat X
axisFormat %s
section baseline
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (2.368 ms) : 2326, 2410
. : milestone, 2368,
iast (2.097 ms) : 2044, 2151
. : milestone, 2097,
iast_GLOBAL (2.134 ms) : 2081, 2186
. : milestone, 2134,
profiling (1.956 ms) : 1914, 1998
. : milestone, 1956,
tracing (1.93 ms) : 1889, 1970
. : milestone, 1930,
section candidate
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (2.358 ms) : 2316, 2399
. : milestone, 2358,
iast (2.101 ms) : 2049, 2154
. : milestone, 2101,
iast_GLOBAL (2.139 ms) : 2087, 2192
. : milestone, 2139,
profiling (2.421 ms) : 2248, 2594
. : milestone, 2421,
tracing (1.94 ms) : 1900, 1981
. : milestone, 1940,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Fixes NPE in logic that parses the list of flaky tests received from the backend.
The error only happens when a "partial build" is run for a single module.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]