Skip to content

Only check that the first frame tags are present. #8049

Merged
evanchooly merged 2 commits intomasterfrom
evanchooly/grpc
Dec 3, 2024
Merged

Only check that the first frame tags are present. #8049
evanchooly merged 2 commits intomasterfrom
evanchooly/grpc

Conversation

@evanchooly
Copy link
Copy Markdown
Contributor

@evanchooly evanchooly commented Dec 3, 2024

What Does This Do

Simplifies the test to check a smaller set of data that we need to actively worry about.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@evanchooly evanchooly requested a review from a team as a code owner December 3, 2024 14:38
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 3, 2024

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@mcculls mcculls added type: bug Bug report and fix tag: no release notes Changes to exclude from release notes comp: debugger Dynamic Instrumentation labels Dec 3, 2024
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Dec 3, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master evanchooly/grpc
git_commit_date 1733220724 1733236499
git_commit_sha 64347d6 6360692
release_version 1.44.0-SNAPSHOT~64347d6daf 1.44.0-SNAPSHOT~6360692eef
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1733238957 1733238957
ci_job_id 725662118 725662118
ci_pipeline_id 50269429 50269429
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 7 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.44.0-SNAPSHOT~6360692eef, baseline=1.44.0-SNAPSHOT~64347d6daf

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.091 s) : 0, 1091270
Total [baseline] (10.481 s) : 0, 10480624
Agent [candidate] (1.097 s) : 0, 1097296
Total [candidate] (10.436 s) : 0, 10435657
section appsec
Agent [baseline] (1.223 s) : 0, 1222538
Total [baseline] (10.741 s) : 0, 10740723
Agent [candidate] (1.229 s) : 0, 1229144
Total [candidate] (10.727 s) : 0, 10727457
section iast
Agent [baseline] (1.219 s) : 0, 1218600
Total [baseline] (10.941 s) : 0, 10940687
Agent [candidate] (1.221 s) : 0, 1221301
Total [candidate] (10.943 s) : 0, 10942598
section profiling
Agent [baseline] (1.321 s) : 0, 1321476
Total [baseline] (10.773 s) : 0, 10773419
Agent [candidate] (1.324 s) : 0, 1323605
Total [candidate] (10.811 s) : 0, 10811270
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.091 s -
Agent appsec 1.223 s 131.269 ms (12.0%)
Agent iast 1.219 s 127.33 ms (11.7%)
Agent profiling 1.321 s 230.206 ms (21.1%)
Total tracing 10.481 s -
Total appsec 10.741 s 260.098 ms (2.5%)
Total iast 10.941 s 460.063 ms (4.4%)
Total profiling 10.773 s 292.795 ms (2.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.097 s -
Agent appsec 1.229 s 131.848 ms (12.0%)
Agent iast 1.221 s 124.006 ms (11.3%)
Agent profiling 1.324 s 226.31 ms (20.6%)
Total tracing 10.436 s -
Total appsec 10.727 s 291.8 ms (2.8%)
Total iast 10.943 s 506.941 ms (4.9%)
Total profiling 10.811 s 375.613 ms (3.6%) 
gantt
    title petclinic - break down per module: candidate=1.44.0-SNAPSHOT~6360692eef, baseline=1.44.0-SNAPSHOT~64347d6daf

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (694.711 ms) : 0, 694711
BytebuddyAgent [candidate] (697.893 ms) : 0, 697893
GlobalTracer [baseline] (316.721 ms) : 0, 316721
GlobalTracer [candidate] (318.466 ms) : 0, 318466
AppSec [baseline] (54.783 ms) : 0, 54783
AppSec [candidate] (55.07 ms) : 0, 55070
Remote Config [baseline] (681.522 µs) : 0, 682
Remote Config [candidate] (680.361 µs) : 0, 680
Telemetry [baseline] (10.654 ms) : 0, 10654
Telemetry [candidate] (11.431 ms) : 0, 11431
section appsec
BytebuddyAgent [baseline] (709.317 ms) : 0, 709317
BytebuddyAgent [candidate] (714.096 ms) : 0, 714096
GlobalTracer [baseline] (313.763 ms) : 0, 313763
GlobalTracer [candidate] (315.744 ms) : 0, 315744
AppSec [baseline] (166.788 ms) : 0, 166788
AppSec [candidate] (167.436 ms) : 0, 167436
Remote Config [baseline] (639.128 µs) : 0, 639
Remote Config [candidate] (643.628 µs) : 0, 644
Telemetry [baseline] (8.909 ms) : 0, 8909
Telemetry [candidate] (7.829 ms) : 0, 7829
IAST [baseline] (18.905 ms) : 0, 18905
IAST [candidate] (19.232 ms) : 0, 19232
section iast
BytebuddyAgent [baseline] (811.425 ms) : 0, 811425
BytebuddyAgent [candidate] (815.157 ms) : 0, 815157
GlobalTracer [baseline] (306.201 ms) : 0, 306201
GlobalTracer [candidate] (305.657 ms) : 0, 305657
AppSec [baseline] (57.185 ms) : 0, 57185
AppSec [candidate] (57.742 ms) : 0, 57742
Remote Config [baseline] (618.864 µs) : 0, 619
Remote Config [candidate] (628.357 µs) : 0, 628
Telemetry [baseline] (7.534 ms) : 0, 7534
Telemetry [candidate] (7.508 ms) : 0, 7508
IAST [baseline] (21.944 ms) : 0, 21944
IAST [candidate] (20.857 ms) : 0, 20857
section profiling
BytebuddyAgent [baseline] (687.696 ms) : 0, 687696
BytebuddyAgent [candidate] (692.021 ms) : 0, 692021
GlobalTracer [baseline] (437.993 ms) : 0, 437993
GlobalTracer [candidate] (435.926 ms) : 0, 435926
AppSec [baseline] (54.374 ms) : 0, 54374
AppSec [candidate] (54.266 ms) : 0, 54266
Remote Config [baseline] (674.832 µs) : 0, 675
Remote Config [candidate] (670.229 µs) : 0, 670
Telemetry [baseline] (7.736 ms) : 0, 7736
Telemetry [candidate] (7.786 ms) : 0, 7786
ProfilingAgent [baseline] (93.993 ms) : 0, 93993
ProfilingAgent [candidate] (93.69 ms) : 0, 93690
Profiling [baseline] (94.017 ms) : 0, 94017
Profiling [candidate] (93.713 ms) : 0, 93713
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.44.0-SNAPSHOT~6360692eef, baseline=1.44.0-SNAPSHOT~64347d6daf

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.092 s) : 0, 1091788
Total [baseline] (8.625 s) : 0, 8625011
Agent [candidate] (1.089 s) : 0, 1088804
Total [candidate] (8.692 s) : 0, 8692222
section iast
Agent [baseline] (1.216 s) : 0, 1215716
Total [baseline] (9.185 s) : 0, 9185278
Agent [candidate] (1.223 s) : 0, 1222670
Total [candidate] (9.239 s) : 0, 9239481
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.217 s) : 0, 1216968
Total [baseline] (9.163 s) : 0, 9163083
Agent [candidate] (1.217 s) : 0, 1217377
Total [candidate] (9.152 s) : 0, 9152125
section iast_TELEMETRY_OFF
Agent [baseline] (1.212 s) : 0, 1212048
Total [baseline] (9.203 s) : 0, 9202759
Agent [candidate] (1.216 s) : 0, 1215581
Total [candidate] (9.172 s) : 0, 9172327
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.092 s -
Agent iast 1.216 s 123.928 ms (11.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.217 s 125.18 ms (11.5%)
Agent iast_TELEMETRY_OFF 1.212 s 120.26 ms (11.0%)
Total tracing 8.625 s -
Total iast 9.185 s 560.267 ms (6.5%)
Total iast_HARDCODED_SECRET_DISABLED 9.163 s 538.071 ms (6.2%)
Total iast_TELEMETRY_OFF 9.203 s 577.748 ms (6.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.089 s -
Agent iast 1.223 s 133.866 ms (12.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.217 s 128.573 ms (11.8%)
Agent iast_TELEMETRY_OFF 1.216 s 126.777 ms (11.6%)
Total tracing 8.692 s -
Total iast 9.239 s 547.259 ms (6.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.152 s 459.903 ms (5.3%)
Total iast_TELEMETRY_OFF 9.172 s 480.105 ms (5.5%) 
gantt
    title insecure-bank - break down per module: candidate=1.44.0-SNAPSHOT~6360692eef, baseline=1.44.0-SNAPSHOT~64347d6daf

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (694.154 ms) : 0, 694154
BytebuddyAgent [candidate] (692.847 ms) : 0, 692847
GlobalTracer [baseline] (316.495 ms) : 0, 316495
GlobalTracer [candidate] (316.606 ms) : 0, 316606
AppSec [baseline] (54.721 ms) : 0, 54721
AppSec [candidate] (54.968 ms) : 0, 54968
Remote Config [baseline] (692.408 µs) : 0, 692
Remote Config [candidate] (682.128 µs) : 0, 682
Telemetry [baseline] (12.028 ms) : 0, 12028
Telemetry [candidate] (9.993 ms) : 0, 9993
section iast
BytebuddyAgent [baseline] (809.995 ms) : 0, 809995
BytebuddyAgent [candidate] (813.7 ms) : 0, 813700
GlobalTracer [baseline] (305.291 ms) : 0, 305291
GlobalTracer [candidate] (307.572 ms) : 0, 307572
AppSec [baseline] (57.255 ms) : 0, 57255
AppSec [candidate] (58.45 ms) : 0, 58450
Remote Config [baseline] (622.911 µs) : 0, 623
Remote Config [candidate] (640.38 µs) : 0, 640
Telemetry [baseline] (7.438 ms) : 0, 7438
Telemetry [candidate] (7.55 ms) : 0, 7550
IAST [baseline] (21.476 ms) : 0, 21476
IAST [candidate] (21.056 ms) : 0, 21056
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (811.702 ms) : 0, 811702
BytebuddyAgent [candidate] (811.665 ms) : 0, 811665
GlobalTracer [baseline] (304.745 ms) : 0, 304745
GlobalTracer [candidate] (305.242 ms) : 0, 305242
AppSec [baseline] (58.03 ms) : 0, 58030
AppSec [candidate] (57.668 ms) : 0, 57668
Remote Config [baseline] (624.885 µs) : 0, 625
Remote Config [candidate] (634.43 µs) : 0, 634
Telemetry [baseline] (7.431 ms) : 0, 7431
Telemetry [candidate] (7.513 ms) : 0, 7513
IAST [baseline] (20.75 ms) : 0, 20750
IAST [candidate] (20.963 ms) : 0, 20963
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (806.865 ms) : 0, 806865
BytebuddyAgent [candidate] (809.647 ms) : 0, 809647
GlobalTracer [baseline] (304.827 ms) : 0, 304827
GlobalTracer [candidate] (305.786 ms) : 0, 305786
AppSec [baseline] (55.797 ms) : 0, 55797
AppSec [candidate] (55.416 ms) : 0, 55416
Remote Config [baseline] (621.505 µs) : 0, 622
Remote Config [candidate] (623.477 µs) : 0, 623
Telemetry [baseline] (7.368 ms) : 0, 7368
Telemetry [candidate] (7.382 ms) : 0, 7382
IAST [baseline] (22.888 ms) : 0, 22888
IAST [candidate] (23.018 ms) : 0, 23018
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-12-03T14:46:08 2024-12-03T14:53:10
git_branch master evanchooly/grpc
git_commit_date 1733220724 1733236499
git_commit_sha 64347d6 6360692
release_version 1.44.0-SNAPSHOT~64347d6daf 1.44.0-SNAPSHOT~6360692eef
start_time 2024-12-03T14:45:55 2024-12-03T14:52:56
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1733237945 1733237945
ci_job_id 725662119 725662119
ci_pipeline_id 50269429 50269429
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~6360692eef, baseline=1.44.0-SNAPSHOT~64347d6daf
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.366 ms) : 1345, 1387
.   : milestone, 1366,
appsec (1.739 ms) : 1714, 1764
.   : milestone, 1739,
appsec_no_iast (1.771 ms) : 1747, 1795
.   : milestone, 1771,
iast (1.506 ms) : 1482, 1529
.   : milestone, 1506,
profiling (1.556 ms) : 1531, 1581
.   : milestone, 1556,
tracing (1.504 ms) : 1480, 1528
.   : milestone, 1504,
section candidate
no_agent (1.368 ms) : 1349, 1388
.   : milestone, 1368,
appsec (1.774 ms) : 1749, 1799
.   : milestone, 1774,
appsec_no_iast (1.758 ms) : 1734, 1783
.   : milestone, 1758,
iast (1.509 ms) : 1485, 1532
.   : milestone, 1509,
profiling (1.5 ms) : 1476, 1523
.   : milestone, 1500,
tracing (1.504 ms) : 1480, 1529
.   : milestone, 1504,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.366 ms [1.345 ms, 1.387 ms] -
appsec 1.739 ms [1.714 ms, 1.764 ms] 372.817 µs (27.3%)
appsec_no_iast 1.771 ms [1.747 ms, 1.795 ms] 405.042 µs (29.7%)
iast 1.506 ms [1.482 ms, 1.529 ms] 139.66 µs (10.2%)
profiling 1.556 ms [1.531 ms, 1.581 ms] 190.162 µs (13.9%)
tracing 1.504 ms [1.48 ms, 1.528 ms] 138.224 µs (10.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.368 ms [1.349 ms, 1.388 ms] -
appsec 1.774 ms [1.749 ms, 1.799 ms] 405.219 µs (29.6%)
appsec_no_iast 1.758 ms [1.734 ms, 1.783 ms] 389.824 µs (28.5%)
iast 1.509 ms [1.485 ms, 1.532 ms] 140.186 µs (10.2%)
profiling 1.5 ms [1.476 ms, 1.523 ms] 131.463 µs (9.6%)
tracing 1.504 ms [1.48 ms, 1.529 ms] 136.051 µs (9.9%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~6360692eef, baseline=1.44.0-SNAPSHOT~64347d6daf
    dateFormat X
    axisFormat %s
section baseline
no_agent (384.216 µs) : 365, 404
.   : milestone, 384,
iast (496.444 µs) : 475, 518
.   : milestone, 496,
iast_FULL (656.527 µs) : 635, 678
.   : milestone, 657,
iast_GLOBAL (524.013 µs) : 502, 546
.   : milestone, 524,
iast_HARDCODED_SECRET_DISABLED (498.017 µs) : 476, 520
.   : milestone, 498,
iast_INACTIVE (454.788 µs) : 434, 476
.   : milestone, 455,
iast_TELEMETRY_OFF (492.47 µs) : 471, 514
.   : milestone, 492,
tracing (458.223 µs) : 437, 479
.   : milestone, 458,
section candidate
no_agent (377.598 µs) : 357, 398
.   : milestone, 378,
iast (491.765 µs) : 470, 513
.   : milestone, 492,
iast_FULL (657.743 µs) : 636, 679
.   : milestone, 658,
iast_GLOBAL (529.607 µs) : 507, 552
.   : milestone, 530,
iast_HARDCODED_SECRET_DISABLED (494.901 µs) : 473, 517
.   : milestone, 495,
iast_INACTIVE (460.842 µs) : 439, 483
.   : milestone, 461,
iast_TELEMETRY_OFF (484.403 µs) : 463, 506
.   : milestone, 484,
tracing (457.312 µs) : 436, 478
.   : milestone, 457,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 384.216 µs [364.62 µs, 403.811 µs] -
iast 496.444 µs [474.953 µs, 517.934 µs] 112.228 µs (29.2%)
iast_FULL 656.527 µs [635.021 µs, 678.033 µs] 272.311 µs (70.9%)
iast_GLOBAL 524.013 µs [502.181 µs, 545.844 µs] 139.797 µs (36.4%)
iast_HARDCODED_SECRET_DISABLED 498.017 µs [476.095 µs, 519.94 µs] 113.802 µs (29.6%)
iast_INACTIVE 454.788 µs [433.885 µs, 475.69 µs] 70.572 µs (18.4%)
iast_TELEMETRY_OFF 492.47 µs [470.578 µs, 514.362 µs] 108.254 µs (28.2%)
tracing 458.223 µs [437.108 µs, 479.338 µs] 74.008 µs (19.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 377.598 µs [356.821 µs, 398.375 µs] -
iast 491.765 µs [470.282 µs, 513.248 µs] 114.167 µs (30.2%)
iast_FULL 657.743 µs [636.073 µs, 679.413 µs] 280.145 µs (74.2%)
iast_GLOBAL 529.607 µs [507.091 µs, 552.122 µs] 152.009 µs (40.3%)
iast_HARDCODED_SECRET_DISABLED 494.901 µs [472.989 µs, 516.812 µs] 117.303 µs (31.1%)
iast_INACTIVE 460.842 µs [439.065 µs, 482.619 µs] 83.244 µs (22.0%)
iast_TELEMETRY_OFF 484.403 µs [463.071 µs, 505.736 µs] 106.806 µs (28.3%)
tracing 457.312 µs [436.208 µs, 478.416 µs] 79.714 µs (21.1%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master evanchooly/grpc
git_commit_date 1733220724 1733236499
git_commit_sha 64347d6 6360692
release_version 1.44.0-SNAPSHOT~64347d6daf 1.44.0-SNAPSHOT~6360692eef
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1733238519 1733238519
ci_job_id 725662120 725662120
ci_pipeline_id 50269429 50269429
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~6360692eef, baseline=1.44.0-SNAPSHOT~64347d6daf
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.472 ms) : 1460, 1483
.   : milestone, 1472,
appsec (2.355 ms) : 2314, 2397
.   : milestone, 2355,
iast (2.096 ms) : 2043, 2149
.   : milestone, 2096,
iast_GLOBAL (2.141 ms) : 2088, 2195
.   : milestone, 2141,
profiling (1.99 ms) : 1947, 2033
.   : milestone, 1990,
tracing (1.93 ms) : 1890, 1971
.   : milestone, 1930,
section candidate
no_agent (1.48 ms) : 1468, 1491
.   : milestone, 1480,
appsec (2.351 ms) : 2310, 2392
.   : milestone, 2351,
iast (2.101 ms) : 2048, 2154
.   : milestone, 2101,
iast_GLOBAL (2.137 ms) : 2085, 2190
.   : milestone, 2137,
profiling (1.956 ms) : 1914, 1998
.   : milestone, 1956,
tracing (1.936 ms) : 1896, 1976
.   : milestone, 1936,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.472 ms [1.46 ms, 1.483 ms] -
appsec 2.355 ms [2.314 ms, 2.397 ms] 883.687 µs (60.0%)
iast 2.096 ms [2.043 ms, 2.149 ms] 624.367 µs (42.4%)
iast_GLOBAL 2.141 ms [2.088 ms, 2.195 ms] 669.643 µs (45.5%)
profiling 1.99 ms [1.947 ms, 2.033 ms] 518.075 µs (35.2%)
tracing 1.93 ms [1.89 ms, 1.971 ms] 458.538 µs (31.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.48 ms [1.468 ms, 1.491 ms] -
appsec 2.351 ms [2.31 ms, 2.392 ms] 871.51 µs (58.9%)
iast 2.101 ms [2.048 ms, 2.154 ms] 621.171 µs (42.0%)
iast_GLOBAL 2.137 ms [2.085 ms, 2.19 ms] 657.621 µs (44.4%)
profiling 1.956 ms [1.914 ms, 1.998 ms] 476.027 µs (32.2%)
tracing 1.936 ms [1.896 ms, 1.976 ms] 456.434 µs (30.8%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~6360692eef, baseline=1.44.0-SNAPSHOT~64347d6daf
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.468 s) : 15468000, 15468000
.   : milestone, 15468000,
appsec (14.912 s) : 14912000, 14912000
.   : milestone, 14912000,
iast (18.34 s) : 18340000, 18340000
.   : milestone, 18340000,
iast_GLOBAL (18.106 s) : 18106000, 18106000
.   : milestone, 18106000,
profiling (15.172 s) : 15172000, 15172000
.   : milestone, 15172000,
tracing (15.101 s) : 15101000, 15101000
.   : milestone, 15101000,
section candidate
no_agent (15.231 s) : 15231000, 15231000
.   : milestone, 15231000,
appsec (15.007 s) : 15007000, 15007000
.   : milestone, 15007000,
iast (18.79 s) : 18790000, 18790000
.   : milestone, 18790000,
iast_GLOBAL (17.862 s) : 17862000, 17862000
.   : milestone, 17862000,
profiling (15.235 s) : 15235000, 15235000
.   : milestone, 15235000,
tracing (15.02 s) : 15020000, 15020000
.   : milestone, 15020000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.468 s [15.468 s, 15.468 s] -
appsec 14.912 s [14.912 s, 14.912 s] -556.0 ms (-3.6%)
iast 18.34 s [18.34 s, 18.34 s] 2.872 s (18.6%)
iast_GLOBAL 18.106 s [18.106 s, 18.106 s] 2.638 s (17.1%)
profiling 15.172 s [15.172 s, 15.172 s] -296.0 ms (-1.9%)
tracing 15.101 s [15.101 s, 15.101 s] -367.0 ms (-2.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.231 s [15.231 s, 15.231 s] -
appsec 15.007 s [15.007 s, 15.007 s] -224.0 ms (-1.5%)
iast 18.79 s [18.79 s, 18.79 s] 3.559 s (23.4%)
iast_GLOBAL 17.862 s [17.862 s, 17.862 s] 2.631 s (17.3%)
profiling 15.235 s [15.235 s, 15.235 s] 4.0 ms (0.0%)
tracing 15.02 s [15.02 s, 15.02 s] -211.0 ms (-1.4%)

@evanchooly
mock the code origin recorder and simply check for invocations
174a934 
restrict the test dep to a narrower scope
@evanchooly
Copy link
Copy Markdown
Contributor Author

evanchooly commented Dec 3, 2024

I had to do a little deep diving to get at the verification I wanted but it seems to work. I'm not a mockito guy so if there's an expert among us that wants to weigh in on that verification, it would be much appreciated.

amarziali
amarziali approved these changes Dec 3, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@amarziali amarziali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm it can be merged to unlock master

@evanchooly evanchooly merged commit 7698f2f into master Dec 3, 2024
@evanchooly evanchooly deleted the evanchooly/grpc branch December 3, 2024 17:14
@github-actions github-actions Bot added this to the 1.44.0 milestone Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcculls mcculls mcculls approved these changes

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@amarziali amarziali amarziali approved these changes

@smola smola Awaiting requested review from smola

@jpbempel jpbempel Awaiting requested review from jpbempel

Assignees

No one assigned

Labels

comp: debugger Dynamic Instrumentation tag: no release notes Changes to exclude from release notes type: bug Bug report and fix

Projects

None yet

Milestone

1.44.0

Development

Successfully merging this pull request may close these issues.

4 participants

@evanchooly @mcculls @PerfectSlayer @amarziali