Refactor tests of StringBuffer substring#8000
Merged
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~a8a72975c1, baseline=1.43.0-SNAPSHOT~adf9784bfd
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.087 s) : 0, 1086918
Total [baseline] (10.416 s) : 0, 10416116
Agent [candidate] (1.107 s) : 0, 1107278
Total [candidate] (10.533 s) : 0, 10532573
section appsec
Agent [baseline] (1.218 s) : 0, 1218351
Total [baseline] (10.687 s) : 0, 10686692
Agent [candidate] (1.224 s) : 0, 1223659
Total [candidate] (10.721 s) : 0, 10720609
section iast
Agent [baseline] (1.215 s) : 0, 1215008
Total [baseline] (10.929 s) : 0, 10929467
Agent [candidate] (1.222 s) : 0, 1221669
Total [candidate] (10.94 s) : 0, 10939992
section profiling
Agent [baseline] (1.285 s) : 0, 1285328
Total [baseline] (10.781 s) : 0, 10780595
Agent [candidate] (1.301 s) : 0, 1301159
Total [candidate] (10.823 s) : 0, 10822931
gantt
title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~a8a72975c1, baseline=1.43.0-SNAPSHOT~adf9784bfd
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (690.294 ms) : 0, 690294
BytebuddyAgent [candidate] (705.439 ms) : 0, 705439
GlobalTracer [baseline] (316.302 ms) : 0, 316302
GlobalTracer [candidate] (322.285 ms) : 0, 322285
AppSec [baseline] (54.475 ms) : 0, 54475
AppSec [candidate] (55.486 ms) : 0, 55486
Remote Config [baseline] (692.056 µs) : 0, 692
Remote Config [candidate] (701.356 µs) : 0, 701
Telemetry [baseline] (11.53 ms) : 0, 11530
Telemetry [candidate] (9.397 ms) : 0, 9397
section appsec
BytebuddyAgent [baseline] (706.566 ms) : 0, 706566
BytebuddyAgent [candidate] (710.024 ms) : 0, 710024
GlobalTracer [baseline] (313.427 ms) : 0, 313427
GlobalTracer [candidate] (314.471 ms) : 0, 314471
AppSec [baseline] (166.143 ms) : 0, 166143
AppSec [candidate] (167.03 ms) : 0, 167030
Remote Config [baseline] (642.028 µs) : 0, 642
Remote Config [candidate] (644.013 µs) : 0, 644
Telemetry [baseline] (7.452 ms) : 0, 7452
Telemetry [candidate] (7.881 ms) : 0, 7881
IAST [baseline] (21.02 ms) : 0, 21020
IAST [candidate] (19.769 ms) : 0, 19769
section iast
BytebuddyAgent [baseline] (808.104 ms) : 0, 808104
BytebuddyAgent [candidate] (813.185 ms) : 0, 813185
GlobalTracer [baseline] (306.464 ms) : 0, 306464
GlobalTracer [candidate] (307.454 ms) : 0, 307454
AppSec [baseline] (57.465 ms) : 0, 57465
AppSec [candidate] (57.525 ms) : 0, 57525
Remote Config [baseline] (615.442 µs) : 0, 615
Remote Config [candidate] (621.513 µs) : 0, 622
Telemetry [baseline] (7.437 ms) : 0, 7437
Telemetry [candidate] (7.527 ms) : 0, 7527
IAST [baseline] (21.27 ms) : 0, 21270
IAST [candidate] (21.527 ms) : 0, 21527
section profiling
BytebuddyAgent [baseline] (685.937 ms) : 0, 685937
BytebuddyAgent [candidate] (695.065 ms) : 0, 695065
GlobalTracer [baseline] (399.892 ms) : 0, 399892
GlobalTracer [candidate] (403.825 ms) : 0, 403825
AppSec [baseline] (55.3 ms) : 0, 55300
AppSec [candidate] (55.94 ms) : 0, 55940
Remote Config [baseline] (662.523 µs) : 0, 663
Remote Config [candidate] (688.194 µs) : 0, 688
Telemetry [baseline] (13.419 ms) : 0, 13419
Telemetry [candidate] (13.517 ms) : 0, 13517
ProfilingAgent [baseline] (91.18 ms) : 0, 91180
ProfilingAgent [candidate] (92.578 ms) : 0, 92578
Profiling [baseline] (91.203 ms) : 0, 91203
Profiling [candidate] (92.601 ms) : 0, 92601
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~a8a72975c1, baseline=1.43.0-SNAPSHOT~adf9784bfd
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.09 s) : 0, 1089521
Total [baseline] (8.67 s) : 0, 8670158
Agent [candidate] (1.093 s) : 0, 1093132
Total [candidate] (8.643 s) : 0, 8642937
section iast
Agent [baseline] (1.214 s) : 0, 1213885
Total [baseline] (9.203 s) : 0, 9203428
Agent [candidate] (1.219 s) : 0, 1219308
Total [candidate] (9.216 s) : 0, 9215902
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.216 s) : 0, 1216478
Total [baseline] (9.188 s) : 0, 9187536
Agent [candidate] (1.225 s) : 0, 1225081
Total [candidate] (9.209 s) : 0, 9208681
section iast_TELEMETRY_OFF
Agent [baseline] (1.213 s) : 0, 1212775
Total [baseline] (9.14 s) : 0, 9139794
Agent [candidate] (1.221 s) : 0, 1220560
Total [candidate] (9.154 s) : 0, 9153675
gantt
title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~a8a72975c1, baseline=1.43.0-SNAPSHOT~adf9784bfd
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (694.605 ms) : 0, 694605
BytebuddyAgent [candidate] (694.82 ms) : 0, 694820
GlobalTracer [baseline] (316.529 ms) : 0, 316529
GlobalTracer [candidate] (317.712 ms) : 0, 317712
AppSec [baseline] (54.688 ms) : 0, 54688
AppSec [candidate] (54.809 ms) : 0, 54809
Remote Config [baseline] (677.801 µs) : 0, 678
Remote Config [candidate] (688.603 µs) : 0, 689
Telemetry [baseline] (9.249 ms) : 0, 9249
Telemetry [candidate] (11.366 ms) : 0, 11366
section iast
BytebuddyAgent [baseline] (807.974 ms) : 0, 807974
BytebuddyAgent [candidate] (812.319 ms) : 0, 812319
GlobalTracer [baseline] (305.122 ms) : 0, 305122
GlobalTracer [candidate] (306.885 ms) : 0, 306885
AppSec [baseline] (57.24 ms) : 0, 57240
AppSec [candidate] (57.938 ms) : 0, 57938
IAST [baseline] (21.78 ms) : 0, 21780
IAST [candidate] (20.47 ms) : 0, 20470
Remote Config [baseline] (617.865 µs) : 0, 618
Remote Config [candidate] (598.767 µs) : 0, 599
Telemetry [baseline] (7.498 ms) : 0, 7498
Telemetry [candidate] (7.369 ms) : 0, 7369
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (809.353 ms) : 0, 809353
BytebuddyAgent [candidate] (815.241 ms) : 0, 815241
GlobalTracer [baseline] (306.434 ms) : 0, 306434
GlobalTracer [candidate] (308.173 ms) : 0, 308173
AppSec [baseline] (56.333 ms) : 0, 56333
AppSec [candidate] (56.984 ms) : 0, 56984
IAST [baseline] (22.555 ms) : 0, 22555
IAST [candidate] (22.728 ms) : 0, 22728
Remote Config [baseline] (620.099 µs) : 0, 620
Remote Config [candidate] (622.742 µs) : 0, 623
Telemetry [baseline] (7.506 ms) : 0, 7506
Telemetry [candidate] (7.52 ms) : 0, 7520
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (805.932 ms) : 0, 805932
BytebuddyAgent [candidate] (813.076 ms) : 0, 813076
GlobalTracer [baseline] (306.596 ms) : 0, 306596
GlobalTracer [candidate] (307.715 ms) : 0, 307715
AppSec [baseline] (57.408 ms) : 0, 57408
AppSec [candidate] (57.471 ms) : 0, 57471
IAST [baseline] (21.228 ms) : 0, 21228
IAST [candidate] (20.498 ms) : 0, 20498
Remote Config [baseline] (614.241 µs) : 0, 614
Remote Config [candidate] (635.703 µs) : 0, 636
Telemetry [baseline] (7.357 ms) : 0, 7357
Telemetry [candidate] (7.389 ms) : 0, 7389
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~a8a72975c1, baseline=1.43.0-SNAPSHOT~adf9784bfd
dateFormat X
axisFormat %s
section baseline
no_agent (1.375 ms) : 1356, 1394
. : milestone, 1375,
appsec (1.739 ms) : 1714, 1764
. : milestone, 1739,
appsec_no_iast (1.745 ms) : 1720, 1770
. : milestone, 1745,
iast (1.498 ms) : 1476, 1521
. : milestone, 1498,
profiling (1.522 ms) : 1497, 1546
. : milestone, 1522,
tracing (1.482 ms) : 1455, 1509
. : milestone, 1482,
section candidate
no_agent (1.359 ms) : 1338, 1379
. : milestone, 1359,
appsec (1.723 ms) : 1698, 1748
. : milestone, 1723,
appsec_no_iast (1.755 ms) : 1731, 1779
. : milestone, 1755,
iast (1.48 ms) : 1458, 1503
. : milestone, 1480,
profiling (1.493 ms) : 1471, 1516
. : milestone, 1493,
tracing (1.486 ms) : 1461, 1511
. : milestone, 1486,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~a8a72975c1, baseline=1.43.0-SNAPSHOT~adf9784bfd
dateFormat X
axisFormat %s
section baseline
no_agent (367.282 µs) : 346, 388
. : milestone, 367,
iast (480.642 µs) : 459, 502
. : milestone, 481,
iast_FULL (645.885 µs) : 624, 667
. : milestone, 646,
iast_GLOBAL (513.134 µs) : 491, 535
. : milestone, 513,
iast_HARDCODED_SECRET_DISABLED (480.366 µs) : 459, 501
. : milestone, 480,
iast_INACTIVE (444.288 µs) : 423, 466
. : milestone, 444,
iast_TELEMETRY_OFF (472.378 µs) : 451, 494
. : milestone, 472,
tracing (456.025 µs) : 435, 477
. : milestone, 456,
section candidate
no_agent (367.835 µs) : 348, 388
. : milestone, 368,
iast (486.025 µs) : 464, 508
. : milestone, 486,
iast_FULL (641.253 µs) : 620, 663
. : milestone, 641,
iast_GLOBAL (513.919 µs) : 492, 536
. : milestone, 514,
iast_HARDCODED_SECRET_DISABLED (482.344 µs) : 461, 504
. : milestone, 482,
iast_INACTIVE (444.636 µs) : 424, 465
. : milestone, 445,
iast_TELEMETRY_OFF (479.616 µs) : 457, 502
. : milestone, 480,
tracing (437.922 µs) : 417, 459
. : milestone, 438,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~a8a72975c1, baseline=1.43.0-SNAPSHOT~adf9784bfd
dateFormat X
axisFormat %s
section baseline
no_agent (1.458 ms) : 1447, 1469
. : milestone, 1458,
appsec (2.313 ms) : 2271, 2354
. : milestone, 2313,
iast (2.073 ms) : 2021, 2126
. : milestone, 2073,
iast_GLOBAL (2.119 ms) : 2066, 2172
. : milestone, 2119,
profiling (1.933 ms) : 1891, 1975
. : milestone, 1933,
tracing (1.911 ms) : 1871, 1951
. : milestone, 1911,
section candidate
no_agent (1.46 ms) : 1449, 1471
. : milestone, 1460,
appsec (2.336 ms) : 2294, 2377
. : milestone, 2336,
iast (2.072 ms) : 2020, 2125
. : milestone, 2072,
iast_GLOBAL (2.11 ms) : 2057, 2162
. : milestone, 2110,
profiling (1.965 ms) : 1922, 2008
. : milestone, 1965,
tracing (1.911 ms) : 1871, 1952
. : milestone, 1911,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~a8a72975c1, baseline=1.43.0-SNAPSHOT~adf9784bfd
dateFormat X
axisFormat %s
section baseline
no_agent (14.854 s) : 14854000, 14854000
. : milestone, 14854000,
appsec (15.026 s) : 15026000, 15026000
. : milestone, 15026000,
iast (18.966 s) : 18966000, 18966000
. : milestone, 18966000,
iast_GLOBAL (18.106 s) : 18106000, 18106000
. : milestone, 18106000,
profiling (15.132 s) : 15132000, 15132000
. : milestone, 15132000,
tracing (14.887 s) : 14887000, 14887000
. : milestone, 14887000,
section candidate
no_agent (14.934 s) : 14934000, 14934000
. : milestone, 14934000,
appsec (15.112 s) : 15112000, 15112000
. : milestone, 15112000,
iast (18.767 s) : 18767000, 18767000
. : milestone, 18767000,
iast_GLOBAL (17.774 s) : 17774000, 17774000
. : milestone, 17774000,
profiling (14.89 s) : 14890000, 14890000
. : milestone, 14890000,
tracing (14.791 s) : 14791000, 14791000
. : milestone, 14791000,
|
smola
approved these changes
Nov 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
This refactors the test suite of the
StringBufferto his proper file. Previously was inside theStringBuildertest suiteMotivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: APPSEC-55369