Skip to content

Remove Strings.join API in favor of JDK String.join#7974

Merged
PerfectSlayer merged 1 commit intomasterfrom
bbujon/cleanup
Nov 20, 2024
Merged

Remove Strings.join API in favor of JDK String.join#7974
PerfectSlayer merged 1 commit intomasterfrom
bbujon/cleanup

Conversation

@PerfectSlayer
Copy link
Copy Markdown
Contributor

@PerfectSlayer PerfectSlayer commented Nov 19, 2024 •
edited
Loading

What Does This Do

This PR cleans up custom Strings.join to use the JDK String.join instead.

Motivation

This API should date from pre 1.0 which was Java 7 compatible while String.join was introduced in Java 8.
The JDK method pass our custom Strings.join tests too.

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@PerfectSlayer PerfectSlayer requested review from a team as code owners November 19, 2024 11:02
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Nov 19, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/cleanup
git_commit_date 1732012226 1732019457
git_commit_sha ff8ee85 b4d3e03
release_version 1.43.0-SNAPSHOT~ff8ee85501 1.43.0-SNAPSHOT~b4d3e03b18
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1732021962 1732021962
ci_job_id 711980816 711980816
ci_pipeline_id 49361729 49361729
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 8 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~b4d3e03b18, baseline=1.43.0-SNAPSHOT~ff8ee85501

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.079 s) : 0, 1078999
Total [baseline] (10.468 s) : 0, 10467843
Agent [candidate] (1.083 s) : 0, 1082994
Total [candidate] (10.413 s) : 0, 10412518
section appsec
Agent [baseline] (1.215 s) : 0, 1214528
Total [baseline] (10.699 s) : 0, 10699386
Agent [candidate] (1.222 s) : 0, 1222422
Total [candidate] (10.733 s) : 0, 10732752
section iast
Agent [baseline] (1.215 s) : 0, 1214749
Total [baseline] (10.949 s) : 0, 10948973
Agent [candidate] (1.225 s) : 0, 1224865
Total [candidate] (10.896 s) : 0, 10896463
section profiling
Agent [baseline] (1.294 s) : 0, 1294473
Total [baseline] (10.837 s) : 0, 10837268
Agent [candidate] (1.276 s) : 0, 1275670
Total [candidate] (10.736 s) : 0, 10735563
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.079 s -
Agent appsec 1.215 s 135.53 ms (12.6%)
Agent iast 1.215 s 135.75 ms (12.6%)
Agent profiling 1.294 s 215.475 ms (20.0%)
Total tracing 10.468 s -
Total appsec 10.699 s 231.543 ms (2.2%)
Total iast 10.949 s 481.13 ms (4.6%)
Total profiling 10.837 s 369.426 ms (3.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.083 s -
Agent appsec 1.222 s 139.427 ms (12.9%)
Agent iast 1.225 s 141.871 ms (13.1%)
Agent profiling 1.276 s 192.676 ms (17.8%)
Total tracing 10.413 s -
Total appsec 10.733 s 320.234 ms (3.1%)
Total iast 10.896 s 483.946 ms (4.6%)
Total profiling 10.736 s 323.045 ms (3.1%) 
gantt
    title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~b4d3e03b18, baseline=1.43.0-SNAPSHOT~ff8ee85501

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.376 ms) : 0, 686376
BytebuddyAgent [candidate] (689.781 ms) : 0, 689781
GlobalTracer [baseline] (315.047 ms) : 0, 315047
GlobalTracer [candidate] (314.067 ms) : 0, 314067
AppSec [baseline] (54.057 ms) : 0, 54057
AppSec [candidate] (54.118 ms) : 0, 54118
Remote Config [baseline] (689.483 µs) : 0, 689
Remote Config [candidate] (675.475 µs) : 0, 675
Telemetry [baseline] (9.2 ms) : 0, 9200
Telemetry [candidate] (10.637 ms) : 0, 10637
section appsec
BytebuddyAgent [baseline] (703.464 ms) : 0, 703464
BytebuddyAgent [candidate] (708.177 ms) : 0, 708177
GlobalTracer [baseline] (312.614 ms) : 0, 312614
GlobalTracer [candidate] (315.006 ms) : 0, 315006
AppSec [baseline] (166.286 ms) : 0, 166286
AppSec [candidate] (166.527 ms) : 0, 166527
IAST [baseline] (20.226 ms) : 0, 20226
IAST [candidate] (20.427 ms) : 0, 20427
Remote Config [baseline] (633.88 µs) : 0, 634
Remote Config [candidate] (639.176 µs) : 0, 639
Telemetry [baseline] (7.811 ms) : 0, 7811
Telemetry [candidate] (8.149 ms) : 0, 8149
section iast
BytebuddyAgent [baseline] (809.597 ms) : 0, 809597
BytebuddyAgent [candidate] (815.675 ms) : 0, 815675
GlobalTracer [baseline] (305.198 ms) : 0, 305198
GlobalTracer [candidate] (308.238 ms) : 0, 308238
AppSec [baseline] (57.135 ms) : 0, 57135
AppSec [candidate] (57.027 ms) : 0, 57027
IAST [baseline] (20.957 ms) : 0, 20957
IAST [candidate] (21.944 ms) : 0, 21944
Remote Config [baseline] (616.331 µs) : 0, 616
Remote Config [candidate] (626.711 µs) : 0, 627
Telemetry [baseline] (7.507 ms) : 0, 7507
Telemetry [candidate] (7.509 ms) : 0, 7509
section profiling
BytebuddyAgent [baseline] (690.69 ms) : 0, 690690
BytebuddyAgent [candidate] (680.617 ms) : 0, 680617
GlobalTracer [baseline] (402.437 ms) : 0, 402437
GlobalTracer [candidate] (397.321 ms) : 0, 397321
AppSec [baseline] (55.101 ms) : 0, 55101
AppSec [candidate] (54.662 ms) : 0, 54662
Remote Config [baseline] (678.717 µs) : 0, 679
Remote Config [candidate] (660.897 µs) : 0, 661
Telemetry [baseline] (12.934 ms) : 0, 12934
Telemetry [candidate] (12.615 ms) : 0, 12615
ProfilingAgent [baseline] (93.272 ms) : 0, 93272
ProfilingAgent [candidate] (91.086 ms) : 0, 91086
Profiling [baseline] (93.296 ms) : 0, 93296
Profiling [candidate] (91.11 ms) : 0, 91110
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~b4d3e03b18, baseline=1.43.0-SNAPSHOT~ff8ee85501

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.096 s) : 0, 1096376
Total [baseline] (8.606 s) : 0, 8605831
Agent [candidate] (1.078 s) : 0, 1078036
Total [candidate] (8.59 s) : 0, 8589779
section iast
Agent [baseline] (1.212 s) : 0, 1212149
Total [baseline] (9.126 s) : 0, 9126031
Agent [candidate] (1.214 s) : 0, 1214415
Total [candidate] (9.182 s) : 0, 9181583
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.204 s) : 0, 1203647
Total [baseline] (9.107 s) : 0, 9106597
Agent [candidate] (1.216 s) : 0, 1216079
Total [candidate] (9.118 s) : 0, 9117772
section iast_TELEMETRY_OFF
Agent [baseline] (1.202 s) : 0, 1201952
Total [baseline] (9.15 s) : 0, 9150184
Agent [candidate] (1.203 s) : 0, 1203116
Total [candidate] (9.143 s) : 0, 9142760
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.096 s -
Agent iast 1.212 s 115.773 ms (10.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.204 s 107.271 ms (9.8%)
Agent iast_TELEMETRY_OFF 1.202 s 105.576 ms (9.6%)
Total tracing 8.606 s -
Total iast 9.126 s 520.2 ms (6.0%)
Total iast_HARDCODED_SECRET_DISABLED 9.107 s 500.767 ms (5.8%)
Total iast_TELEMETRY_OFF 9.15 s 544.354 ms (6.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.078 s -
Agent iast 1.214 s 136.379 ms (12.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.216 s 138.044 ms (12.8%)
Agent iast_TELEMETRY_OFF 1.203 s 125.08 ms (11.6%)
Total tracing 8.59 s -
Total iast 9.182 s 591.804 ms (6.9%)
Total iast_HARDCODED_SECRET_DISABLED 9.118 s 527.993 ms (6.1%)
Total iast_TELEMETRY_OFF 9.143 s 552.982 ms (6.4%) 
gantt
    title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~b4d3e03b18, baseline=1.43.0-SNAPSHOT~ff8ee85501

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (696.599 ms) : 0, 696599
BytebuddyAgent [candidate] (686.004 ms) : 0, 686004
GlobalTracer [baseline] (318.923 ms) : 0, 318923
GlobalTracer [candidate] (314.154 ms) : 0, 314154
AppSec [baseline] (54.825 ms) : 0, 54825
AppSec [candidate] (54.318 ms) : 0, 54318
Remote Config [baseline] (694.682 µs) : 0, 695
Remote Config [candidate] (679.177 µs) : 0, 679
Telemetry [baseline] (11.486 ms) : 0, 11486
Telemetry [candidate] (9.269 ms) : 0, 9269
section iast
BytebuddyAgent [baseline] (808.575 ms) : 0, 808575
BytebuddyAgent [candidate] (808.268 ms) : 0, 808268
GlobalTracer [baseline] (304.128 ms) : 0, 304128
GlobalTracer [candidate] (305.715 ms) : 0, 305715
AppSec [baseline] (57.089 ms) : 0, 57089
AppSec [candidate] (57.622 ms) : 0, 57622
IAST [baseline] (20.583 ms) : 0, 20583
IAST [candidate] (20.995 ms) : 0, 20995
Remote Config [baseline] (605.01 µs) : 0, 605
Remote Config [candidate] (613.794 µs) : 0, 614
Telemetry [baseline] (7.411 ms) : 0, 7411
Telemetry [candidate] (7.475 ms) : 0, 7475
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (800.454 ms) : 0, 800454
BytebuddyAgent [candidate] (808.919 ms) : 0, 808919
GlobalTracer [baseline] (304.017 ms) : 0, 304017
GlobalTracer [candidate] (306.478 ms) : 0, 306478
AppSec [baseline] (57.311 ms) : 0, 57311
AppSec [candidate] (57.069 ms) : 0, 57069
IAST [baseline] (20.26 ms) : 0, 20260
IAST [candidate] (21.667 ms) : 0, 21667
Remote Config [baseline] (595.447 µs) : 0, 595
Remote Config [candidate] (623.336 µs) : 0, 623
Telemetry [baseline] (7.391 ms) : 0, 7391
Telemetry [candidate] (7.572 ms) : 0, 7572
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (798.908 ms) : 0, 798908
BytebuddyAgent [candidate] (798.877 ms) : 0, 798877
GlobalTracer [baseline] (303.92 ms) : 0, 303920
GlobalTracer [candidate] (304.283 ms) : 0, 304283
AppSec [baseline] (57.493 ms) : 0, 57493
AppSec [candidate] (58.05 ms) : 0, 58050
IAST [baseline] (20.073 ms) : 0, 20073
IAST [candidate] (20.243 ms) : 0, 20243
Remote Config [baseline] (605.376 µs) : 0, 605
Remote Config [candidate] (614.138 µs) : 0, 614
Telemetry [baseline] (7.348 ms) : 0, 7348
Telemetry [candidate] (7.455 ms) : 0, 7455
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-11-19T12:42:55 2024-11-19T12:49:51
git_branch master bbujon/cleanup
git_commit_date 1732012226 1732019457
git_commit_sha ff8ee85 b4d3e03
release_version 1.43.0-SNAPSHOT~ff8ee85501 1.43.0-SNAPSHOT~b4d3e03b18
start_time 2024-11-19T12:42:41 2024-11-19T12:49:38
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1732020943 1732020943
ci_job_id 711980817 711980817
ci_pipeline_id 49361729 49361729
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~b4d3e03b18, baseline=1.43.0-SNAPSHOT~ff8ee85501
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.337 ms) : 1318, 1357
.   : milestone, 1337,
appsec (1.749 ms) : 1724, 1773
.   : milestone, 1749,
appsec_no_iast (1.731 ms) : 1706, 1755
.   : milestone, 1731,
iast (1.493 ms) : 1470, 1516
.   : milestone, 1493,
profiling (1.524 ms) : 1500, 1548
.   : milestone, 1524,
tracing (1.473 ms) : 1448, 1498
.   : milestone, 1473,
section candidate
no_agent (1.344 ms) : 1324, 1364
.   : milestone, 1344,
appsec (1.765 ms) : 1742, 1789
.   : milestone, 1765,
appsec_no_iast (1.746 ms) : 1722, 1771
.   : milestone, 1746,
iast (1.487 ms) : 1463, 1510
.   : milestone, 1487,
profiling (1.538 ms) : 1514, 1561
.   : milestone, 1538,
tracing (1.489 ms) : 1465, 1513
.   : milestone, 1489,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.337 ms [1.318 ms, 1.357 ms] -
appsec 1.749 ms [1.724 ms, 1.773 ms] 411.216 µs (30.7%)
appsec_no_iast 1.731 ms [1.706 ms, 1.755 ms] 393.242 µs (29.4%)
iast 1.493 ms [1.47 ms, 1.516 ms] 155.489 µs (11.6%)
profiling 1.524 ms [1.5 ms, 1.548 ms] 186.56 µs (13.9%)
tracing 1.473 ms [1.448 ms, 1.498 ms] 135.865 µs (10.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.344 ms [1.324 ms, 1.364 ms] -
appsec 1.765 ms [1.742 ms, 1.789 ms] 421.401 µs (31.4%)
appsec_no_iast 1.746 ms [1.722 ms, 1.771 ms] 402.332 µs (29.9%)
iast 1.487 ms [1.463 ms, 1.51 ms] 142.609 µs (10.6%)
profiling 1.538 ms [1.514 ms, 1.561 ms] 193.532 µs (14.4%)
tracing 1.489 ms [1.465 ms, 1.513 ms] 145.161 µs (10.8%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~b4d3e03b18, baseline=1.43.0-SNAPSHOT~ff8ee85501
    dateFormat X
    axisFormat %s
section baseline
no_agent (373.568 µs) : 354, 393
.   : milestone, 374,
iast (494.835 µs) : 473, 517
.   : milestone, 495,
iast_FULL (649.471 µs) : 628, 671
.   : milestone, 649,
iast_GLOBAL (514.453 µs) : 494, 535
.   : milestone, 514,
iast_HARDCODED_SECRET_DISABLED (489.348 µs) : 468, 511
.   : milestone, 489,
iast_INACTIVE (453.458 µs) : 432, 475
.   : milestone, 453,
iast_TELEMETRY_OFF (481.423 µs) : 460, 503
.   : milestone, 481,
tracing (447.514 µs) : 427, 468
.   : milestone, 448,
section candidate
no_agent (371.772 µs) : 352, 391
.   : milestone, 372,
iast (493.74 µs) : 472, 515
.   : milestone, 494,
iast_FULL (647.058 µs) : 626, 668
.   : milestone, 647,
iast_GLOBAL (525.585 µs) : 503, 548
.   : milestone, 526,
iast_HARDCODED_SECRET_DISABLED (487.229 µs) : 466, 508
.   : milestone, 487,
iast_INACTIVE (444.804 µs) : 424, 465
.   : milestone, 445,
iast_TELEMETRY_OFF (482.689 µs) : 461, 504
.   : milestone, 483,
tracing (449.473 µs) : 428, 471
.   : milestone, 449,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 373.568 µs [354.197 µs, 392.939 µs] -
iast 494.835 µs [472.657 µs, 517.013 µs] 121.267 µs (32.5%)
iast_FULL 649.471 µs [628.245 µs, 670.696 µs] 275.903 µs (73.9%)
iast_GLOBAL 514.453 µs [493.504 µs, 535.402 µs] 140.885 µs (37.7%)
iast_HARDCODED_SECRET_DISABLED 489.348 µs [468.166 µs, 510.531 µs] 115.78 µs (31.0%)
iast_INACTIVE 453.458 µs [432.043 µs, 474.873 µs] 79.89 µs (21.4%)
iast_TELEMETRY_OFF 481.423 µs [459.752 µs, 503.095 µs] 107.855 µs (28.9%)
tracing 447.514 µs [426.861 µs, 468.168 µs] 73.946 µs (19.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 371.772 µs [352.378 µs, 391.166 µs] -
iast 493.74 µs [472.382 µs, 515.098 µs] 121.968 µs (32.8%)
iast_FULL 647.058 µs [625.789 µs, 668.328 µs] 275.286 µs (74.0%)
iast_GLOBAL 525.585 µs [502.842 µs, 548.329 µs] 153.813 µs (41.4%)
iast_HARDCODED_SECRET_DISABLED 487.229 µs [466.021 µs, 508.437 µs] 115.457 µs (31.1%)
iast_INACTIVE 444.804 µs [424.165 µs, 465.444 µs] 73.032 µs (19.6%)
iast_TELEMETRY_OFF 482.689 µs [461.485 µs, 503.892 µs] 110.917 µs (29.8%)
tracing 449.473 µs [428.445 µs, 470.5 µs] 77.7 µs (20.9%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/cleanup
git_commit_date 1732012226 1732019457
git_commit_sha ff8ee85 b4d3e03
release_version 1.43.0-SNAPSHOT~ff8ee85501 1.43.0-SNAPSHOT~b4d3e03b18
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1732021456 1732021456
ci_job_id 711980818 711980818
ci_pipeline_id 49361729 49361729
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~b4d3e03b18, baseline=1.43.0-SNAPSHOT~ff8ee85501
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.466 ms) : 1454, 1477
.   : milestone, 1466,
appsec (2.331 ms) : 2289, 2372
.   : milestone, 2331,
iast (2.053 ms) : 2002, 2104
.   : milestone, 2053,
iast_GLOBAL (2.11 ms) : 2058, 2162
.   : milestone, 2110,
profiling (1.938 ms) : 1896, 1981
.   : milestone, 1938,
tracing (1.91 ms) : 1870, 1950
.   : milestone, 1910,
section candidate
no_agent (1.467 ms) : 1456, 1479
.   : milestone, 1467,
appsec (2.33 ms) : 2288, 2371
.   : milestone, 2330,
iast (2.071 ms) : 2019, 2123
.   : milestone, 2071,
iast_GLOBAL (2.113 ms) : 2060, 2165
.   : milestone, 2113,
profiling (1.947 ms) : 1905, 1989
.   : milestone, 1947,
tracing (1.914 ms) : 1875, 1953
.   : milestone, 1914,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.466 ms [1.454 ms, 1.477 ms] -
appsec 2.331 ms [2.289 ms, 2.372 ms] 865.358 µs (59.0%)
iast 2.053 ms [2.002 ms, 2.104 ms] 587.388 µs (40.1%)
iast_GLOBAL 2.11 ms [2.058 ms, 2.162 ms] 644.26 µs (44.0%)
profiling 1.938 ms [1.896 ms, 1.981 ms] 472.877 µs (32.3%)
tracing 1.91 ms [1.87 ms, 1.95 ms] 444.607 µs (30.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.467 ms [1.456 ms, 1.479 ms] -
appsec 2.33 ms [2.288 ms, 2.371 ms] 862.086 µs (58.7%)
iast 2.071 ms [2.019 ms, 2.123 ms] 603.59 µs (41.1%)
iast_GLOBAL 2.113 ms [2.06 ms, 2.165 ms] 645.091 µs (44.0%)
profiling 1.947 ms [1.905 ms, 1.989 ms] 479.741 µs (32.7%)
tracing 1.914 ms [1.875 ms, 1.953 ms] 446.564 µs (30.4%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~b4d3e03b18, baseline=1.43.0-SNAPSHOT~ff8ee85501
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.106 s) : 15106000, 15106000
.   : milestone, 15106000,
appsec (15.273 s) : 15273000, 15273000
.   : milestone, 15273000,
iast (18.436 s) : 18436000, 18436000
.   : milestone, 18436000,
iast_GLOBAL (18.24 s) : 18240000, 18240000
.   : milestone, 18240000,
profiling (15.203 s) : 15203000, 15203000
.   : milestone, 15203000,
tracing (14.975 s) : 14975000, 14975000
.   : milestone, 14975000,
section candidate
no_agent (15.74 s) : 15740000, 15740000
.   : milestone, 15740000,
appsec (15.418 s) : 15418000, 15418000
.   : milestone, 15418000,
iast (18.854 s) : 18854000, 18854000
.   : milestone, 18854000,
iast_GLOBAL (17.783 s) : 17783000, 17783000
.   : milestone, 17783000,
profiling (15.569 s) : 15569000, 15569000
.   : milestone, 15569000,
tracing (15.004 s) : 15004000, 15004000
.   : milestone, 15004000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.106 s [15.106 s, 15.106 s] -
appsec 15.273 s [15.273 s, 15.273 s] 167.0 ms (1.1%)
iast 18.436 s [18.436 s, 18.436 s] 3.33 s (22.0%)
iast_GLOBAL 18.24 s [18.24 s, 18.24 s] 3.134 s (20.7%)
profiling 15.203 s [15.203 s, 15.203 s] 97.0 ms (0.6%)
tracing 14.975 s [14.975 s, 14.975 s] -131.0 ms (-0.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.74 s [15.74 s, 15.74 s] -
appsec 15.418 s [15.418 s, 15.418 s] -322.0 ms (-2.0%)
iast 18.854 s [18.854 s, 18.854 s] 3.114 s (19.8%)
iast_GLOBAL 17.783 s [17.783 s, 17.783 s] 2.043 s (13.0%)
profiling 15.569 s [15.569 s, 15.569 s] -171.0 ms (-1.1%)
tracing 15.004 s [15.004 s, 15.004 s] -736.0 ms (-4.7%)

@PerfectSlayer PerfectSlayer merged commit df51f63 into master Nov 20, 2024
@PerfectSlayer PerfectSlayer deleted the bbujon/cleanup branch November 20, 2024 17:03
@github-actions github-actions Bot added this to the 1.43.0 milestone Nov 20, 2024
@mcculls mcculls added the tag: no release notes Changes to exclude from release notes label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manuel-alvarez-alvarez manuel-alvarez-alvarez manuel-alvarez-alvarez approved these changes

@nikita-tkachenko-datadog nikita-tkachenko-datadog nikita-tkachenko-datadog approved these changes

@jandro996 jandro996 Awaiting requested review from jandro996 jandro996 is a code owner automatically assigned from DataDog/asm-java

Assignees

No one assigned

Labels

comp: api Tracer public API tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Milestone

1.43.0

Development

Successfully merging this pull request may close these issues.

4 participants

@PerfectSlayer @manuel-alvarez-alvarez @nikita-tkachenko-datadog @mcculls