Avoid DATADOG_API_KEY in test visibility upload by smola · Pull Request #7952 · DataDog/dd-trace-java

smola · 2024-11-14T10:29:58Z

What Does This Do

Avoid DATADOG_API_KEY in test visibility upload, just in case it's picked up by the upload script.

Motivation

We have a legacy DATADOG_API_KEY in Circle CI env. This might be the cause of results not being uploaded to prod.

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Squash your commits prior merging or merge using GitHub's Squash and merge
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: APMSP-1519

pr-commenter · 2024-11-14T11:10:11Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	smola/dd-api-key-ci-viz
git_commit_date	1731578914	1731590228
git_commit_sha	`e7571fd`	`8869164`
release_version	1.43.0-SNAPSHOT~e7571fd2ee	1.43.0-SNAPSHOT~8869164416

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1731592680	1731592680
ci_job_id	706905395	706905395
ci_pipeline_id	49009232	49009232
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 7 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~8869164416, baseline=1.43.0-SNAPSHOT~e7571fd2ee

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.08 s) : 0, 1079932
Total [baseline] (8.546 s) : 0, 8545885
Agent [candidate] (1.079 s) : 0, 1079240
Total [candidate] (8.54 s) : 0, 8539861
section iast
Agent [baseline] (1.202 s) : 0, 1202414
Total [baseline] (9.096 s) : 0, 9096216
Agent [candidate] (1.208 s) : 0, 1208211
Total [candidate] (9.129 s) : 0, 9129104
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.203 s) : 0, 1203159
Total [baseline] (9.084 s) : 0, 9084040
Agent [candidate] (1.205 s) : 0, 1204669
Total [candidate] (9.077 s) : 0, 9077349
section iast_TELEMETRY_OFF
Agent [baseline] (1.202 s) : 0, 1202496
Total [baseline] (9.095 s) : 0, 9095360
Agent [candidate] (1.199 s) : 0, 1199152
Total [candidate] (9.108 s) : 0, 9107716

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.08 s	-
Agent	iast	1.202 s	122.482 ms (11.3%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.203 s	123.227 ms (11.4%)
Agent	iast_TELEMETRY_OFF	1.202 s	122.564 ms (11.3%)
Total	tracing	8.546 s	-
Total	iast	9.096 s	550.331 ms (6.4%)
Total	iast_HARDCODED_SECRET_DISABLED	9.084 s	538.155 ms (6.3%)
Total	iast_TELEMETRY_OFF	9.095 s	549.475 ms (6.4%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.079 s	-
Agent	iast	1.208 s	128.971 ms (12.0%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.205 s	125.43 ms (11.6%)
Agent	iast_TELEMETRY_OFF	1.199 s	119.913 ms (11.1%)
Total	tracing	8.54 s	-
Total	iast	9.129 s	589.243 ms (6.9%)
Total	iast_HARDCODED_SECRET_DISABLED	9.077 s	537.488 ms (6.3%)
Total	iast_TELEMETRY_OFF	9.108 s	567.855 ms (6.6%)

gantt
    title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~8869164416, baseline=1.43.0-SNAPSHOT~e7571fd2ee

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.491 ms) : 0, 686491
BytebuddyAgent [candidate] (686.099 ms) : 0, 686099
GlobalTracer [baseline] (314.411 ms) : 0, 314411
GlobalTracer [candidate] (313.735 ms) : 0, 313735
AppSec [baseline] (54.141 ms) : 0, 54141
AppSec [candidate] (53.942 ms) : 0, 53942
Remote Config [baseline] (684.829 µs) : 0, 685
Remote Config [candidate] (666.453 µs) : 0, 666
Telemetry [baseline] (10.58 ms) : 0, 10580
Telemetry [candidate] (11.201 ms) : 0, 11201
section iast
BytebuddyAgent [baseline] (800.329 ms) : 0, 800329
BytebuddyAgent [candidate] (804.815 ms) : 0, 804815
GlobalTracer [baseline] (303.299 ms) : 0, 303299
GlobalTracer [candidate] (303.729 ms) : 0, 303729
AppSec [baseline] (56.87 ms) : 0, 56870
AppSec [candidate] (57.398 ms) : 0, 57398
IAST [baseline] (20.317 ms) : 0, 20317
IAST [candidate] (20.52 ms) : 0, 20520
Remote Config [baseline] (619.938 µs) : 0, 620
Remote Config [candidate] (614.025 µs) : 0, 614
Telemetry [baseline] (7.363 ms) : 0, 7363
Telemetry [candidate] (7.408 ms) : 0, 7408
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (800.78 ms) : 0, 800780
BytebuddyAgent [candidate] (801.612 ms) : 0, 801612
GlobalTracer [baseline] (303.085 ms) : 0, 303085
GlobalTracer [candidate] (303.586 ms) : 0, 303586
AppSec [baseline] (55.601 ms) : 0, 55601
AppSec [candidate] (56.43 ms) : 0, 56430
IAST [baseline] (22.129 ms) : 0, 22129
IAST [candidate] (21.412 ms) : 0, 21412
Remote Config [baseline] (603.532 µs) : 0, 604
Remote Config [candidate] (599.171 µs) : 0, 599
Telemetry [baseline] (7.327 ms) : 0, 7327
Telemetry [candidate] (7.379 ms) : 0, 7379
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (799.941 ms) : 0, 799941
BytebuddyAgent [candidate] (797.295 ms) : 0, 797295
GlobalTracer [baseline] (303.156 ms) : 0, 303156
GlobalTracer [candidate] (302.434 ms) : 0, 302434
AppSec [baseline] (56.069 ms) : 0, 56069
AppSec [candidate] (56.93 ms) : 0, 56930
IAST [baseline] (21.838 ms) : 0, 21838
IAST [candidate] (20.929 ms) : 0, 20929
Remote Config [baseline] (599.389 µs) : 0, 599
Remote Config [candidate] (598.023 µs) : 0, 598
Telemetry [baseline] (7.267 ms) : 0, 7267
Telemetry [candidate] (7.34 ms) : 0, 7340

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~8869164416, baseline=1.43.0-SNAPSHOT~e7571fd2ee

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.076 s) : 0, 1075833
Total [baseline] (10.402 s) : 0, 10401788
Agent [candidate] (1.086 s) : 0, 1086413
Total [candidate] (10.418 s) : 0, 10418294
section appsec
Agent [baseline] (1.214 s) : 0, 1213621
Total [baseline] (10.637 s) : 0, 10636595
Agent [candidate] (1.22 s) : 0, 1219720
Total [candidate] (10.642 s) : 0, 10641680
section iast
Agent [baseline] (1.217 s) : 0, 1217289
Total [baseline] (10.8 s) : 0, 10800088
Agent [candidate] (1.203 s) : 0, 1202604
Total [candidate] (10.852 s) : 0, 10852310
section profiling
Agent [baseline] (1.284 s) : 0, 1284052
Total [baseline] (10.707 s) : 0, 10706893
Agent [candidate] (1.272 s) : 0, 1271797
Total [candidate] (10.658 s) : 0, 10657599

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.076 s	-
Agent	appsec	1.214 s	137.788 ms (12.8%)
Agent	iast	1.217 s	141.456 ms (13.1%)
Agent	profiling	1.284 s	208.219 ms (19.4%)
Total	tracing	10.402 s	-
Total	appsec	10.637 s	234.806 ms (2.3%)
Total	iast	10.8 s	398.299 ms (3.8%)
Total	profiling	10.707 s	305.105 ms (2.9%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.086 s	-
Agent	appsec	1.22 s	133.307 ms (12.3%)
Agent	iast	1.203 s	116.191 ms (10.7%)
Agent	profiling	1.272 s	185.384 ms (17.1%)
Total	tracing	10.418 s	-
Total	appsec	10.642 s	223.386 ms (2.1%)
Total	iast	10.852 s	434.015 ms (4.2%)
Total	profiling	10.658 s	239.305 ms (2.3%)

gantt
    title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~8869164416, baseline=1.43.0-SNAPSHOT~e7571fd2ee

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.468 ms) : 0, 683468
BytebuddyAgent [candidate] (690.071 ms) : 0, 690071
GlobalTracer [baseline] (313.168 ms) : 0, 313168
GlobalTracer [candidate] (315.127 ms) : 0, 315127
AppSec [baseline] (53.722 ms) : 0, 53722
AppSec [candidate] (54.633 ms) : 0, 54633
Remote Config [baseline] (667.571 µs) : 0, 668
Remote Config [candidate] (677.721 µs) : 0, 678
Telemetry [baseline] (11.226 ms) : 0, 11226
Telemetry [candidate] (12.203 ms) : 0, 12203
section appsec
BytebuddyAgent [baseline] (704.264 ms) : 0, 704264
BytebuddyAgent [candidate] (706.616 ms) : 0, 706616
GlobalTracer [baseline] (312.247 ms) : 0, 312247
GlobalTracer [candidate] (314.056 ms) : 0, 314056
AppSec [baseline] (165.474 ms) : 0, 165474
AppSec [candidate] (165.294 ms) : 0, 165294
Remote Config [baseline] (637.364 µs) : 0, 637
Remote Config [candidate] (649.141 µs) : 0, 649
Telemetry [baseline] (7.393 ms) : 0, 7393
Telemetry [candidate] (8.856 ms) : 0, 8856
IAST [baseline] (20.001 ms) : 0, 20001
IAST [candidate] (21.142 ms) : 0, 21142
section iast
BytebuddyAgent [baseline] (811.007 ms) : 0, 811007
BytebuddyAgent [candidate] (800.134 ms) : 0, 800134
GlobalTracer [baseline] (305.525 ms) : 0, 305525
GlobalTracer [candidate] (302.728 ms) : 0, 302728
AppSec [baseline] (57.94 ms) : 0, 57940
AppSec [candidate] (57.52 ms) : 0, 57520
Remote Config [baseline] (622.879 µs) : 0, 623
Remote Config [candidate] (610.939 µs) : 0, 611
Telemetry [baseline] (7.557 ms) : 0, 7557
Telemetry [candidate] (7.461 ms) : 0, 7461
IAST [baseline] (20.849 ms) : 0, 20849
IAST [candidate] (20.549 ms) : 0, 20549
section profiling
BytebuddyAgent [baseline] (685.179 ms) : 0, 685179
BytebuddyAgent [candidate] (677.91 ms) : 0, 677910
GlobalTracer [baseline] (400.385 ms) : 0, 400385
GlobalTracer [candidate] (396.498 ms) : 0, 396498
AppSec [baseline] (54.734 ms) : 0, 54734
AppSec [candidate] (54.244 ms) : 0, 54244
Remote Config [baseline] (661.514 µs) : 0, 662
Remote Config [candidate] (656.133 µs) : 0, 656
Telemetry [baseline] (11.914 ms) : 0, 11914
Telemetry [candidate] (13.903 ms) : 0, 13903
ProfilingAgent [baseline] (92.081 ms) : 0, 92081
ProfilingAgent [candidate] (89.803 ms) : 0, 89803
Profiling [baseline] (92.105 ms) : 0, 92105
Profiling [candidate] (89.826 ms) : 0, 89826

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-11-14T13:28:26	2024-11-14T13:35:20
git_branch	master	smola/dd-api-key-ci-viz
git_commit_date	1731578914	1731590228
git_commit_sha	`e7571fd`	`8869164`
release_version	1.43.0-SNAPSHOT~e7571fd2ee	1.43.0-SNAPSHOT~8869164416
start_time	2024-11-14T13:28:13	2024-11-14T13:35:07

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1731591669	1731591669
ci_job_id	706905396	706905396
ci_pipeline_id	49009232	49009232
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~8869164416, baseline=1.43.0-SNAPSHOT~e7571fd2ee
    dateFormat X
    axisFormat %s
section baseline
no_agent (372.564 µs) : 352, 393
.   : milestone, 373,
iast (486.008 µs) : 465, 507
.   : milestone, 486,
iast_FULL (643.084 µs) : 622, 664
.   : milestone, 643,
iast_GLOBAL (522.52 µs) : 500, 545
.   : milestone, 523,
iast_HARDCODED_SECRET_DISABLED (487.866 µs) : 467, 509
.   : milestone, 488,
iast_INACTIVE (443.943 µs) : 423, 464
.   : milestone, 444,
iast_TELEMETRY_OFF (481.925 µs) : 460, 504
.   : milestone, 482,
tracing (445.752 µs) : 425, 466
.   : milestone, 446,
section candidate
no_agent (378.449 µs) : 358, 399
.   : milestone, 378,
iast (485.506 µs) : 464, 507
.   : milestone, 486,
iast_FULL (648.424 µs) : 627, 670
.   : milestone, 648,
iast_GLOBAL (519.078 µs) : 497, 541
.   : milestone, 519,
iast_HARDCODED_SECRET_DISABLED (481.226 µs) : 460, 502
.   : milestone, 481,
iast_INACTIVE (444.67 µs) : 424, 466
.   : milestone, 445,
iast_TELEMETRY_OFF (481.364 µs) : 460, 503
.   : milestone, 481,
tracing (451.074 µs) : 430, 472
.   : milestone, 451,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	372.564 µs [352.313 µs, 392.814 µs]	-
iast	486.008 µs [464.836 µs, 507.18 µs]	113.445 µs (30.4%)
iast_FULL	643.084 µs [621.758 µs, 664.41 µs]	270.521 µs (72.6%)
iast_GLOBAL	522.52 µs [499.702 µs, 545.337 µs]	149.956 µs (40.2%)
iast_HARDCODED_SECRET_DISABLED	487.866 µs [466.614 µs, 509.118 µs]	115.302 µs (30.9%)
iast_INACTIVE	443.943 µs [423.498 µs, 464.389 µs]	71.38 µs (19.2%)
iast_TELEMETRY_OFF	481.925 µs [460.233 µs, 503.617 µs]	109.361 µs (29.4%)
tracing	445.752 µs [425.125 µs, 466.379 µs]	73.188 µs (19.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	378.449 µs [357.921 µs, 398.976 µs]	-
iast	485.506 µs [464.285 µs, 506.727 µs]	107.058 µs (28.3%)
iast_FULL	648.424 µs [627.335 µs, 669.512 µs]	269.975 µs (71.3%)
iast_GLOBAL	519.078 µs [497.108 µs, 541.048 µs]	140.63 µs (37.2%)
iast_HARDCODED_SECRET_DISABLED	481.226 µs [460.171 µs, 502.281 µs]	102.777 µs (27.2%)
iast_INACTIVE	444.67 µs [423.567 µs, 465.772 µs]	66.221 µs (17.5%)
iast_TELEMETRY_OFF	481.364 µs [459.61 µs, 503.118 µs]	102.916 µs (27.2%)
tracing	451.074 µs [429.797 µs, 472.352 µs]	72.626 µs (19.2%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~8869164416, baseline=1.43.0-SNAPSHOT~e7571fd2ee
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.359 ms) : 1339, 1380
.   : milestone, 1359,
appsec (1.726 ms) : 1702, 1750
.   : milestone, 1726,
appsec_no_iast (1.726 ms) : 1701, 1750
.   : milestone, 1726,
iast (1.479 ms) : 1457, 1502
.   : milestone, 1479,
profiling (1.47 ms) : 1447, 1493
.   : milestone, 1470,
tracing (1.476 ms) : 1451, 1502
.   : milestone, 1476,
section candidate
no_agent (1.319 ms) : 1299, 1339
.   : milestone, 1319,
appsec (1.729 ms) : 1704, 1753
.   : milestone, 1729,
appsec_no_iast (1.739 ms) : 1715, 1764
.   : milestone, 1739,
iast (1.479 ms) : 1457, 1502
.   : milestone, 1479,
profiling (1.484 ms) : 1462, 1507
.   : milestone, 1484,
tracing (1.457 ms) : 1433, 1481
.   : milestone, 1457,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.359 ms [1.339 ms, 1.38 ms]	-
appsec	1.726 ms [1.702 ms, 1.75 ms]	366.47 µs (27.0%)
appsec_no_iast	1.726 ms [1.701 ms, 1.75 ms]	366.254 µs (26.9%)
iast	1.479 ms [1.457 ms, 1.502 ms]	119.88 µs (8.8%)
profiling	1.47 ms [1.447 ms, 1.493 ms]	110.81 µs (8.2%)
tracing	1.476 ms [1.451 ms, 1.502 ms]	117.066 µs (8.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.319 ms [1.299 ms, 1.339 ms]	-
appsec	1.729 ms [1.704 ms, 1.753 ms]	409.615 µs (31.1%)
appsec_no_iast	1.739 ms [1.715 ms, 1.764 ms]	420.57 µs (31.9%)
iast	1.479 ms [1.457 ms, 1.502 ms]	160.387 µs (12.2%)
profiling	1.484 ms [1.462 ms, 1.507 ms]	165.441 µs (12.5%)
tracing	1.457 ms [1.433 ms, 1.481 ms]	137.992 µs (10.5%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	smola/dd-api-key-ci-viz
git_commit_date	1731578914	1731590228
git_commit_sha	`e7571fd`	`8869164`
release_version	1.43.0-SNAPSHOT~e7571fd2ee	1.43.0-SNAPSHOT~8869164416

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1731592063	1731592063
ci_job_id	706905398	706905398
ci_pipeline_id	49009232	49009232
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~8869164416, baseline=1.43.0-SNAPSHOT~e7571fd2ee
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.473 ms) : 1461, 1485
.   : milestone, 1473,
appsec (2.322 ms) : 2281, 2363
.   : milestone, 2322,
iast (2.065 ms) : 2014, 2117
.   : milestone, 2065,
iast_GLOBAL (2.103 ms) : 2051, 2154
.   : milestone, 2103,
profiling (1.933 ms) : 1892, 1975
.   : milestone, 1933,
tracing (1.904 ms) : 1864, 1943
.   : milestone, 1904,
section candidate
no_agent (1.466 ms) : 1455, 1478
.   : milestone, 1466,
appsec (2.331 ms) : 2290, 2372
.   : milestone, 2331,
iast (2.068 ms) : 2016, 2120
.   : milestone, 2068,
iast_GLOBAL (2.109 ms) : 2057, 2161
.   : milestone, 2109,
profiling (1.926 ms) : 1886, 1967
.   : milestone, 1926,
tracing (1.919 ms) : 1879, 1958
.   : milestone, 1919,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.473 ms [1.461 ms, 1.485 ms]	-
appsec	2.322 ms [2.281 ms, 2.363 ms]	848.606 µs (57.6%)
iast	2.065 ms [2.014 ms, 2.117 ms]	592.308 µs (40.2%)
iast_GLOBAL	2.103 ms [2.051 ms, 2.154 ms]	629.414 µs (42.7%)
profiling	1.933 ms [1.892 ms, 1.975 ms]	460.024 µs (31.2%)
tracing	1.904 ms [1.864 ms, 1.943 ms]	430.476 µs (29.2%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.466 ms [1.455 ms, 1.478 ms]	-
appsec	2.331 ms [2.29 ms, 2.372 ms]	864.673 µs (59.0%)
iast	2.068 ms [2.016 ms, 2.12 ms]	601.898 µs (41.0%)
iast_GLOBAL	2.109 ms [2.057 ms, 2.161 ms]	642.547 µs (43.8%)
profiling	1.926 ms [1.886 ms, 1.967 ms]	460.143 µs (31.4%)
tracing	1.919 ms [1.879 ms, 1.958 ms]	452.544 µs (30.9%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~8869164416, baseline=1.43.0-SNAPSHOT~e7571fd2ee
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.091 s) : 15091000, 15091000
.   : milestone, 15091000,
appsec (15.26 s) : 15260000, 15260000
.   : milestone, 15260000,
iast (18.556 s) : 18556000, 18556000
.   : milestone, 18556000,
iast_GLOBAL (18.144 s) : 18144000, 18144000
.   : milestone, 18144000,
profiling (14.869 s) : 14869000, 14869000
.   : milestone, 14869000,
tracing (14.972 s) : 14972000, 14972000
.   : milestone, 14972000,
section candidate
no_agent (15.11 s) : 15110000, 15110000
.   : milestone, 15110000,
appsec (15.294 s) : 15294000, 15294000
.   : milestone, 15294000,
iast (18.744 s) : 18744000, 18744000
.   : milestone, 18744000,
iast_GLOBAL (18.229 s) : 18229000, 18229000
.   : milestone, 18229000,
profiling (15.117 s) : 15117000, 15117000
.   : milestone, 15117000,
tracing (15.296 s) : 15296000, 15296000
.   : milestone, 15296000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.091 s [15.091 s, 15.091 s]	-
appsec	15.26 s [15.26 s, 15.26 s]	169.0 ms (1.1%)
iast	18.556 s [18.556 s, 18.556 s]	3.465 s (23.0%)
iast_GLOBAL	18.144 s [18.144 s, 18.144 s]	3.053 s (20.2%)
profiling	14.869 s [14.869 s, 14.869 s]	-222.0 ms (-1.5%)
tracing	14.972 s [14.972 s, 14.972 s]	-119.0 ms (-0.8%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.11 s [15.11 s, 15.11 s]	-
appsec	15.294 s [15.294 s, 15.294 s]	184.0 ms (1.2%)
iast	18.744 s [18.744 s, 18.744 s]	3.634 s (24.1%)
iast_GLOBAL	18.229 s [18.229 s, 18.229 s]	3.119 s (20.6%)
profiling	15.117 s [15.117 s, 15.117 s]	7.0 ms (0.0%)
tracing	15.296 s [15.296 s, 15.296 s]	186.0 ms (1.2%)

PerfectSlayer

Minor change proposal

Co-authored-by: Bruce Bujon <[email protected]>

PerfectSlayer

LGTM, thanks for bringing the idea!

Avoid DATADOG_API_KEY in test visibility upload

0fcdcae

smola added comp: testing Testing tag: no release notes Changes to exclude from release notes labels Nov 14, 2024

smola requested a review from a team as a code owner November 14, 2024 10:29

smola requested a review from nayeem-kamal November 14, 2024 10:29

smola enabled auto-merge (squash) November 14, 2024 11:55

PerfectSlayer reviewed Nov 14, 2024

View reviewed changes

Comment thread .circleci/upload_ciapp.sh Outdated

Update .circleci/upload_ciapp.sh

8869164

Co-authored-by: Bruce Bujon <[email protected]>

smola disabled auto-merge November 14, 2024 13:17

PerfectSlayer approved these changes Nov 14, 2024

View reviewed changes

smola merged commit ea008a2 into master Nov 14, 2024

smola deleted the smola/dd-api-key-ci-viz branch November 14, 2024 14:25

github-actions Bot added this to the 1.43.0 milestone Nov 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Avoid DATADOG_API_KEY in test visibility upload#7952

Avoid DATADOG_API_KEY in test visibility upload#7952
smola merged 2 commits intomasterfrom
smola/dd-api-key-ci-viz

smola commented Nov 14, 2024 •

edited by atlassian Bot

Loading

Uh oh!

pr-commenter Bot commented Nov 14, 2024 •

edited

Loading

Uh oh!

PerfectSlayer left a comment

Uh oh!

Uh oh!

PerfectSlayer left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

smola commented Nov 14, 2024 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

pr-commenter Bot commented Nov 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

PerfectSlayer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

PerfectSlayer left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

smola commented Nov 14, 2024 •

edited by atlassian Bot

Loading

pr-commenter Bot commented Nov 14, 2024 •

edited

Loading