Fix duplicate PR check comments#7894
Merged
PerfectSlayer merged 1 commit intomasterfrom Nov 8, 2024
Merged
Conversation
9e7bb1d to
f826006
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 7 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~f82600651b, baseline=1.43.0-SNAPSHOT~21c0b2df63
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.083 s) : 0, 1082977
Total [baseline] (8.618 s) : 0, 8617891
Agent [candidate] (1.091 s) : 0, 1091084
Total [candidate] (8.608 s) : 0, 8607944
section iast
Agent [baseline] (1.207 s) : 0, 1207046
Total [baseline] (9.174 s) : 0, 9173891
Agent [candidate] (1.211 s) : 0, 1211420
Total [candidate] (9.194 s) : 0, 9194456
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.212 s) : 0, 1212053
Total [baseline] (9.142 s) : 0, 9141533
Agent [candidate] (1.21 s) : 0, 1210032
Total [candidate] (9.155 s) : 0, 9155057
section iast_TELEMETRY_OFF
Agent [baseline] (1.207 s) : 0, 1206568
Total [baseline] (9.139 s) : 0, 9138773
Agent [candidate] (1.217 s) : 0, 1216931
Total [candidate] (9.27 s) : 0, 9269677
gantt
title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~f82600651b, baseline=1.43.0-SNAPSHOT~21c0b2df63
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.609 ms) : 0, 687609
BytebuddyAgent [candidate] (693.663 ms) : 0, 693663
GlobalTracer [baseline] (316.576 ms) : 0, 316576
GlobalTracer [candidate] (318.848 ms) : 0, 318848
AppSec [baseline] (54.435 ms) : 0, 54435
AppSec [candidate] (54.217 ms) : 0, 54217
Remote Config [baseline] (676.643 µs) : 0, 677
Remote Config [candidate] (673.66 µs) : 0, 674
Telemetry [baseline] (9.938 ms) : 0, 9938
Telemetry [candidate] (9.78 ms) : 0, 9780
section iast
BytebuddyAgent [baseline] (801.918 ms) : 0, 801918
BytebuddyAgent [candidate] (804.678 ms) : 0, 804678
GlobalTracer [baseline] (305.02 ms) : 0, 305020
GlobalTracer [candidate] (306.427 ms) : 0, 306427
AppSec [baseline] (57.512 ms) : 0, 57512
AppSec [candidate] (57.621 ms) : 0, 57621
Remote Config [baseline] (616.639 µs) : 0, 617
Remote Config [candidate] (626.195 µs) : 0, 626
Telemetry [baseline] (7.525 ms) : 0, 7525
Telemetry [candidate] (7.616 ms) : 0, 7616
IAST [baseline] (20.664 ms) : 0, 20664
IAST [candidate] (20.606 ms) : 0, 20606
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (804.751 ms) : 0, 804751
BytebuddyAgent [candidate] (803.288 ms) : 0, 803288
GlobalTracer [baseline] (306.455 ms) : 0, 306455
GlobalTracer [candidate] (306.551 ms) : 0, 306551
AppSec [baseline] (57.821 ms) : 0, 57821
AppSec [candidate] (57.668 ms) : 0, 57668
Remote Config [baseline] (639.931 µs) : 0, 640
Remote Config [candidate] (624.423 µs) : 0, 624
Telemetry [baseline] (7.651 ms) : 0, 7651
Telemetry [candidate] (7.484 ms) : 0, 7484
IAST [baseline] (20.894 ms) : 0, 20894
IAST [candidate] (20.577 ms) : 0, 20577
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (800.224 ms) : 0, 800224
BytebuddyAgent [candidate] (806.826 ms) : 0, 806826
GlobalTracer [baseline] (305.523 ms) : 0, 305523
GlobalTracer [candidate] (308.109 ms) : 0, 308109
AppSec [baseline] (57.913 ms) : 0, 57913
AppSec [candidate] (56.546 ms) : 0, 56546
Remote Config [baseline] (604.995 µs) : 0, 605
Remote Config [candidate] (633.23 µs) : 0, 633
Telemetry [baseline] (7.44 ms) : 0, 7440
Telemetry [candidate] (7.608 ms) : 0, 7608
IAST [baseline] (21.091 ms) : 0, 21091
IAST [candidate] (23.301 ms) : 0, 23301
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~f82600651b, baseline=1.43.0-SNAPSHOT~21c0b2df63
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.085 s) : 0, 1084916
Total [baseline] (10.408 s) : 0, 10408267
Agent [candidate] (1.091 s) : 0, 1091386
Total [candidate] (10.414 s) : 0, 10413806
section appsec
Agent [baseline] (1.227 s) : 0, 1227419
Total [baseline] (10.729 s) : 0, 10728676
Agent [candidate] (1.223 s) : 0, 1222820
Total [candidate] (10.718 s) : 0, 10718062
section iast
Agent [baseline] (1.218 s) : 0, 1218307
Total [baseline] (11.011 s) : 0, 11010964
Agent [candidate] (1.21 s) : 0, 1210414
Total [candidate] (10.921 s) : 0, 10921321
section profiling
Agent [baseline] (1.283 s) : 0, 1282951
Total [baseline] (10.763 s) : 0, 10763245
Agent [candidate] (1.29 s) : 0, 1290025
Total [candidate] (10.854 s) : 0, 10854132
gantt
title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~f82600651b, baseline=1.43.0-SNAPSHOT~21c0b2df63
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.371 ms) : 0, 688371
BytebuddyAgent [candidate] (693.373 ms) : 0, 693373
GlobalTracer [baseline] (317.315 ms) : 0, 317315
GlobalTracer [candidate] (319.305 ms) : 0, 319305
AppSec [baseline] (54.28 ms) : 0, 54280
AppSec [candidate] (54.373 ms) : 0, 54373
Remote Config [baseline] (666.912 µs) : 0, 667
Remote Config [candidate] (666.548 µs) : 0, 667
Telemetry [baseline] (10.514 ms) : 0, 10514
Telemetry [candidate] (9.862 ms) : 0, 9862
section appsec
BytebuddyAgent [baseline] (711.651 ms) : 0, 711651
BytebuddyAgent [candidate] (708.361 ms) : 0, 708361
GlobalTracer [baseline] (316.773 ms) : 0, 316773
GlobalTracer [candidate] (315.516 ms) : 0, 315516
AppSec [baseline] (167.066 ms) : 0, 167066
AppSec [candidate] (165.476 ms) : 0, 165476
Remote Config [baseline] (642.67 µs) : 0, 643
Remote Config [candidate] (646.661 µs) : 0, 647
Telemetry [baseline] (8.176 ms) : 0, 8176
Telemetry [candidate] (8.552 ms) : 0, 8552
IAST [baseline] (18.514 ms) : 0, 18514
IAST [candidate] (20.933 ms) : 0, 20933
section iast
BytebuddyAgent [baseline] (811.211 ms) : 0, 811211
BytebuddyAgent [candidate] (804.582 ms) : 0, 804582
GlobalTracer [baseline] (306.48 ms) : 0, 306480
GlobalTracer [candidate] (306.005 ms) : 0, 306005
AppSec [baseline] (56.31 ms) : 0, 56310
AppSec [candidate] (57.24 ms) : 0, 57240
Remote Config [baseline] (621.483 µs) : 0, 621
Remote Config [candidate] (619.317 µs) : 0, 619
Telemetry [baseline] (7.519 ms) : 0, 7519
Telemetry [candidate] (7.477 ms) : 0, 7477
IAST [baseline] (22.271 ms) : 0, 22271
IAST [candidate] (20.711 ms) : 0, 20711
section profiling
BytebuddyAgent [baseline] (683.2 ms) : 0, 683200
BytebuddyAgent [candidate] (687.44 ms) : 0, 687440
GlobalTracer [baseline] (399.699 ms) : 0, 399699
GlobalTracer [candidate] (402.1 ms) : 0, 402100
AppSec [baseline] (54.694 ms) : 0, 54694
AppSec [candidate] (54.959 ms) : 0, 54959
Remote Config [baseline] (685.412 µs) : 0, 685
Remote Config [candidate] (688.001 µs) : 0, 688
Telemetry [baseline] (10.787 ms) : 0, 10787
Telemetry [candidate] (9.392 ms) : 0, 9392
ProfilingAgent [baseline] (94.712 ms) : 0, 94712
ProfilingAgent [candidate] (96.016 ms) : 0, 96016
Profiling [baseline] (94.736 ms) : 0, 94736
Profiling [candidate] (96.039 ms) : 0, 96039
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~f82600651b, baseline=1.43.0-SNAPSHOT~21c0b2df63
dateFormat X
axisFormat %s
section baseline
no_agent (367.924 µs) : 348, 387
. : milestone, 368,
iast (484.188 µs) : 463, 506
. : milestone, 484,
iast_FULL (636.876 µs) : 616, 658
. : milestone, 637,
iast_GLOBAL (508.704 µs) : 487, 530
. : milestone, 509,
iast_HARDCODED_SECRET_DISABLED (484.424 µs) : 463, 506
. : milestone, 484,
iast_INACTIVE (455.186 µs) : 435, 476
. : milestone, 455,
iast_TELEMETRY_OFF (474.575 µs) : 453, 496
. : milestone, 475,
tracing (438.599 µs) : 418, 459
. : milestone, 439,
section candidate
no_agent (360.643 µs) : 341, 380
. : milestone, 361,
iast (483.575 µs) : 462, 506
. : milestone, 484,
iast_FULL (639.226 µs) : 618, 661
. : milestone, 639,
iast_GLOBAL (509.569 µs) : 488, 531
. : milestone, 510,
iast_HARDCODED_SECRET_DISABLED (480.082 µs) : 459, 501
. : milestone, 480,
iast_INACTIVE (445.502 µs) : 425, 466
. : milestone, 446,
iast_TELEMETRY_OFF (471.182 µs) : 450, 493
. : milestone, 471,
tracing (437.046 µs) : 416, 458
. : milestone, 437,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~f82600651b, baseline=1.43.0-SNAPSHOT~21c0b2df63
dateFormat X
axisFormat %s
section baseline
no_agent (1.337 ms) : 1317, 1358
. : milestone, 1337,
appsec (1.709 ms) : 1684, 1734
. : milestone, 1709,
appsec_no_iast (1.71 ms) : 1685, 1734
. : milestone, 1710,
iast (1.484 ms) : 1460, 1508
. : milestone, 1484,
profiling (1.476 ms) : 1453, 1499
. : milestone, 1476,
tracing (1.457 ms) : 1433, 1481
. : milestone, 1457,
section candidate
no_agent (1.329 ms) : 1310, 1349
. : milestone, 1329,
appsec (1.741 ms) : 1719, 1764
. : milestone, 1741,
appsec_no_iast (1.714 ms) : 1689, 1739
. : milestone, 1714,
iast (1.47 ms) : 1446, 1493
. : milestone, 1470,
profiling (1.467 ms) : 1444, 1491
. : milestone, 1467,
tracing (1.464 ms) : 1440, 1488
. : milestone, 1464,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~f82600651b, baseline=1.43.0-SNAPSHOT~21c0b2df63
dateFormat X
axisFormat %s
section baseline
no_agent (15.078 s) : 15078000, 15078000
. : milestone, 15078000,
appsec (15.38 s) : 15380000, 15380000
. : milestone, 15380000,
iast (18.665 s) : 18665000, 18665000
. : milestone, 18665000,
iast_GLOBAL (18.522 s) : 18522000, 18522000
. : milestone, 18522000,
profiling (15.638 s) : 15638000, 15638000
. : milestone, 15638000,
tracing (15.172 s) : 15172000, 15172000
. : milestone, 15172000,
section candidate
no_agent (15.015 s) : 15015000, 15015000
. : milestone, 15015000,
appsec (15.275 s) : 15275000, 15275000
. : milestone, 15275000,
iast (18.67 s) : 18670000, 18670000
. : milestone, 18670000,
iast_GLOBAL (18.171 s) : 18171000, 18171000
. : milestone, 18171000,
profiling (15.161 s) : 15161000, 15161000
. : milestone, 15161000,
tracing (15.122 s) : 15122000, 15122000
. : milestone, 15122000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~f82600651b, baseline=1.43.0-SNAPSHOT~21c0b2df63
dateFormat X
axisFormat %s
section baseline
no_agent (1.47 ms) : 1458, 1481
. : milestone, 1470,
appsec (2.347 ms) : 2306, 2388
. : milestone, 2347,
iast (2.086 ms) : 2034, 2138
. : milestone, 2086,
iast_GLOBAL (2.132 ms) : 2079, 2184
. : milestone, 2132,
profiling (1.971 ms) : 1928, 2014
. : milestone, 1971,
tracing (1.936 ms) : 1895, 1976
. : milestone, 1936,
section candidate
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (2.369 ms) : 2327, 2411
. : milestone, 2369,
iast (2.094 ms) : 2041, 2147
. : milestone, 2094,
iast_GLOBAL (2.139 ms) : 2086, 2193
. : milestone, 2139,
profiling (1.954 ms) : 1911, 1997
. : milestone, 1954,
tracing (1.946 ms) : 1906, 1987
. : milestone, 1946,
|
amarziali
approved these changes
Nov 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR will avoid duplicating PR check messages by updating the original one.
Motivation
GitHub workflow trigger event are somewhat messy to keep track of.
So the last run will update the message accordingly.
Additional Notes
The workflow is disabled until the fix PR is merged.
Originally reported by @amarziali
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]