Skip to content

Fix AWS Payload Tagging prefix generation related to SdkPojo#7882

Merged
ygree merged 2 commits intomasterfrom
ygree/aws-payload-tagging-fix-pojo-tag-generation
Nov 5, 2024
Merged

Fix AWS Payload Tagging prefix generation related to SdkPojo#7882
ygree merged 2 commits intomasterfrom
ygree/aws-payload-tagging-fix-pojo-tag-generation

Conversation

@ygree
Copy link
Copy Markdown
Contributor

@ygree ygree commented Nov 5, 2024 •
edited
Loading

What Does This Do

Fix AWS Payload Tagging prefix generation related to SdkPojo field traversal.

Motivation

Fix the bug.

Additional Notes

Original Feature PR: #7811

Examples

Activated with:

export DD_TRACE_CLOUD_REQUEST_PAYLOAD_TAGGING=all
export DD_TRACE_CLOUD_RESPONSE_PAYLOAD_TAGGING=all

Default S3

image

Manually enabled Sso with custom redaction rules

Additional custom settings:

export DD_TRACE_CLOUD_PAYLOAD_TAGGING_SERVICES=S3,Sso
export DD_TRACE_CLOUD_REQUEST_PAYLOAD_TAGGING='$.accessToken'
export DD_TRACE_CLOUD_RESPONSE_PAYLOAD_TAGGING='$.roleCredentials.secretAccessKey,$.roleCredentials.sessionToken'
image

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@ygree ygree added type: bug Bug report and fix inst: aws sdk AWS SDK instrumentation labels Nov 5, 2024
@ygree ygree self-assigned this Nov 5, 2024
@ygree ygree requested a review from a team as a code owner November 5, 2024 07:27
@ygree ygree added this to the 1.42.1 milestone Nov 5, 2024
@ygree ygree force-pushed the ygree/aws-payload-tagging-fix-pojo-tag-generation branch from b04b404 to 1f337a7 Compare November 5, 2024 07:29
@ygree ygree requested a review from amarziali November 5, 2024 07:41
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Nov 5, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master ygree/aws-payload-tagging-fix-pojo-tag-generation
git_commit_date 1730748321 1730791768
git_commit_sha f49ac98 1f337a7
release_version 1.43.0-SNAPSHOT~f49ac98c70 1.43.0-SNAPSHOT~1f337a74cc
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1730794240 1730794240
ci_job_id 695153782 695153782
ci_pipeline_id 48225912 48225912
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~1f337a74cc, baseline=1.43.0-SNAPSHOT~f49ac98c70

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1080727
Total [baseline] (10.362 s) : 0, 10361787
Agent [candidate] (1.081 s) : 0, 1080705
Total [candidate] (10.325 s) : 0, 10325043
section appsec
Agent [baseline] (1.219 s) : 0, 1219127
Total [baseline] (10.63 s) : 0, 10630301
Agent [candidate] (1.212 s) : 0, 1212059
Total [candidate] (10.697 s) : 0, 10697287
section iast
Agent [baseline] (1.204 s) : 0, 1203865
Total [baseline] (10.926 s) : 0, 10926338
Agent [candidate] (1.206 s) : 0, 1205884
Total [candidate] (10.928 s) : 0, 10928126
section profiling
Agent [baseline] (1.284 s) : 0, 1283805
Total [baseline] (10.755 s) : 0, 10754694
Agent [candidate] (1.285 s) : 0, 1285057
Total [candidate] (10.669 s) : 0, 10669461
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.081 s -
Agent appsec 1.219 s 138.4 ms (12.8%)
Agent iast 1.204 s 123.138 ms (11.4%)
Agent profiling 1.284 s 203.077 ms (18.8%)
Total tracing 10.362 s -
Total appsec 10.63 s 268.514 ms (2.6%)
Total iast 10.926 s 564.551 ms (5.4%)
Total profiling 10.755 s 392.907 ms (3.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.081 s -
Agent appsec 1.212 s 131.354 ms (12.2%)
Agent iast 1.206 s 125.178 ms (11.6%)
Agent profiling 1.285 s 204.351 ms (18.9%)
Total tracing 10.325 s -
Total appsec 10.697 s 372.243 ms (3.6%)
Total iast 10.928 s 603.083 ms (5.8%)
Total profiling 10.669 s 344.417 ms (3.3%) 
gantt
    title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~1f337a74cc, baseline=1.43.0-SNAPSHOT~f49ac98c70

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.451 ms) : 0, 687451
BytebuddyAgent [candidate] (686.208 ms) : 0, 686208
GlobalTracer [baseline] (315.367 ms) : 0, 315367
GlobalTracer [candidate] (315.449 ms) : 0, 315449
AppSec [baseline] (54.439 ms) : 0, 54439
AppSec [candidate] (54.172 ms) : 0, 54172
Remote Config [baseline] (672.705 µs) : 0, 673
Remote Config [candidate] (656.493 µs) : 0, 656
Telemetry [baseline] (9.149 ms) : 0, 9149
Telemetry [candidate] (10.6 ms) : 0, 10600
section appsec
BytebuddyAgent [baseline] (706.935 ms) : 0, 706935
BytebuddyAgent [candidate] (702.794 ms) : 0, 702794
GlobalTracer [baseline] (313.49 ms) : 0, 313490
GlobalTracer [candidate] (311.969 ms) : 0, 311969
AppSec [baseline] (166.117 ms) : 0, 166117
AppSec [candidate] (165.286 ms) : 0, 165286
Remote Config [baseline] (637.849 µs) : 0, 638
Remote Config [candidate] (643.015 µs) : 0, 643
Telemetry [baseline] (8.119 ms) : 0, 8119
Telemetry [candidate] (7.421 ms) : 0, 7421
IAST [baseline] (20.331 ms) : 0, 20331
IAST [candidate] (20.782 ms) : 0, 20782
section iast
BytebuddyAgent [baseline] (800.472 ms) : 0, 800472
BytebuddyAgent [candidate] (801.882 ms) : 0, 801882
GlobalTracer [baseline] (303.828 ms) : 0, 303828
GlobalTracer [candidate] (304.328 ms) : 0, 304328
AppSec [baseline] (56.654 ms) : 0, 56654
AppSec [candidate] (57.13 ms) : 0, 57130
Remote Config [baseline] (603.759 µs) : 0, 604
Remote Config [candidate] (608.805 µs) : 0, 609
Telemetry [baseline] (7.436 ms) : 0, 7436
Telemetry [candidate] (7.464 ms) : 0, 7464
IAST [baseline] (21.28 ms) : 0, 21280
IAST [candidate] (20.822 ms) : 0, 20822
section profiling
BytebuddyAgent [baseline] (685.155 ms) : 0, 685155
BytebuddyAgent [candidate] (684.653 ms) : 0, 684653
GlobalTracer [baseline] (399.332 ms) : 0, 399332
GlobalTracer [candidate] (399.938 ms) : 0, 399938
AppSec [baseline] (54.684 ms) : 0, 54684
AppSec [candidate] (54.896 ms) : 0, 54896
Remote Config [baseline] (679.317 µs) : 0, 679
Remote Config [candidate] (685.698 µs) : 0, 686
Telemetry [baseline] (12.096 ms) : 0, 12096
Telemetry [candidate] (12.75 ms) : 0, 12750
ProfilingAgent [baseline] (92.757 ms) : 0, 92757
ProfilingAgent [candidate] (93.068 ms) : 0, 93068
Profiling [baseline] (92.781 ms) : 0, 92781
Profiling [candidate] (93.092 ms) : 0, 93092
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~1f337a74cc, baseline=1.43.0-SNAPSHOT~f49ac98c70

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.083 s) : 0, 1083107
Total [baseline] (8.6 s) : 0, 8599889
Agent [candidate] (1.081 s) : 0, 1080853
Total [candidate] (8.576 s) : 0, 8576357
section iast
Agent [baseline] (1.201 s) : 0, 1200610
Total [baseline] (9.13 s) : 0, 9130138
Agent [candidate] (1.205 s) : 0, 1205430
Total [candidate] (9.123 s) : 0, 9122980
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.205 s) : 0, 1205301
Total [baseline] (9.088 s) : 0, 9087668
Agent [candidate] (1.205 s) : 0, 1205197
Total [candidate] (9.128 s) : 0, 9128069
section iast_TELEMETRY_OFF
Agent [baseline] (1.201 s) : 0, 1200991
Total [baseline] (9.1 s) : 0, 9100451
Agent [candidate] (1.201 s) : 0, 1201331
Total [candidate] (9.093 s) : 0, 9092571
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.083 s -
Agent iast 1.201 s 117.503 ms (10.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.205 s 122.195 ms (11.3%)
Agent iast_TELEMETRY_OFF 1.201 s 117.884 ms (10.9%)
Total tracing 8.6 s -
Total iast 9.13 s 530.249 ms (6.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.088 s 487.779 ms (5.7%)
Total iast_TELEMETRY_OFF 9.1 s 500.562 ms (5.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.081 s -
Agent iast 1.205 s 124.577 ms (11.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.205 s 124.345 ms (11.5%)
Agent iast_TELEMETRY_OFF 1.201 s 120.478 ms (11.1%)
Total tracing 8.576 s -
Total iast 9.123 s 546.623 ms (6.4%)
Total iast_HARDCODED_SECRET_DISABLED 9.128 s 551.713 ms (6.4%)
Total iast_TELEMETRY_OFF 9.093 s 516.214 ms (6.0%) 
gantt
    title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~1f337a74cc, baseline=1.43.0-SNAPSHOT~f49ac98c70

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.111 ms) : 0, 688111
BytebuddyAgent [candidate] (687.334 ms) : 0, 687334
GlobalTracer [baseline] (316.16 ms) : 0, 316160
GlobalTracer [candidate] (315.535 ms) : 0, 315535
AppSec [baseline] (54.053 ms) : 0, 54053
AppSec [candidate] (53.91 ms) : 0, 53910
Remote Config [baseline] (657.052 µs) : 0, 657
Remote Config [candidate] (664.659 µs) : 0, 665
Telemetry [baseline] (10.511 ms) : 0, 10511
Telemetry [candidate] (9.755 ms) : 0, 9755
section iast
BytebuddyAgent [baseline] (798.985 ms) : 0, 798985
BytebuddyAgent [candidate] (801.362 ms) : 0, 801362
GlobalTracer [baseline] (302.465 ms) : 0, 302465
GlobalTracer [candidate] (303.98 ms) : 0, 303980
AppSec [baseline] (57.166 ms) : 0, 57166
AppSec [candidate] (55.477 ms) : 0, 55477
IAST [baseline] (20.356 ms) : 0, 20356
IAST [candidate] (22.856 ms) : 0, 22856
Remote Config [baseline] (599.594 µs) : 0, 600
Remote Config [candidate] (611.561 µs) : 0, 612
Telemetry [baseline] (7.458 ms) : 0, 7458
Telemetry [candidate] (7.451 ms) : 0, 7451
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (802.071 ms) : 0, 802071
BytebuddyAgent [candidate] (801.172 ms) : 0, 801172
GlobalTracer [baseline] (303.612 ms) : 0, 303612
GlobalTracer [candidate] (304.417 ms) : 0, 304417
AppSec [baseline] (56.435 ms) : 0, 56435
AppSec [candidate] (56.098 ms) : 0, 56098
IAST [baseline] (21.347 ms) : 0, 21347
IAST [candidate] (21.86 ms) : 0, 21860
Remote Config [baseline] (662.286 µs) : 0, 662
Remote Config [candidate] (595.707 µs) : 0, 596
Telemetry [baseline] (7.536 ms) : 0, 7536
Telemetry [candidate] (7.391 ms) : 0, 7391
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (797.857 ms) : 0, 797857
BytebuddyAgent [candidate] (798.011 ms) : 0, 798011
GlobalTracer [baseline] (303.756 ms) : 0, 303756
GlobalTracer [candidate] (304.386 ms) : 0, 304386
AppSec [baseline] (56.914 ms) : 0, 56914
AppSec [candidate] (57.082 ms) : 0, 57082
IAST [baseline] (20.905 ms) : 0, 20905
IAST [candidate] (20.249 ms) : 0, 20249
Remote Config [baseline] (594.43 µs) : 0, 594
Remote Config [candidate] (600.226 µs) : 0, 600
Telemetry [baseline] (7.382 ms) : 0, 7382
Telemetry [candidate] (7.365 ms) : 0, 7365
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-11-05T07:41:03 2024-11-05T07:47:58
git_branch master ygree/aws-payload-tagging-fix-pojo-tag-generation
git_commit_date 1730748321 1730791768
git_commit_sha f49ac98 1f337a7
release_version 1.43.0-SNAPSHOT~f49ac98c70 1.43.0-SNAPSHOT~1f337a74cc
start_time 2024-11-05T07:40:50 2024-11-05T07:47:45
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1730793229 1730793229
ci_job_id 695153783 695153783
ci_pipeline_id 48225912 48225912
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~1f337a74cc, baseline=1.43.0-SNAPSHOT~f49ac98c70
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.343 ms) : 1323, 1362
.   : milestone, 1343,
appsec (1.721 ms) : 1698, 1745
.   : milestone, 1721,
appsec_no_iast (1.708 ms) : 1684, 1733
.   : milestone, 1708,
iast (1.478 ms) : 1455, 1501
.   : milestone, 1478,
profiling (1.525 ms) : 1502, 1549
.   : milestone, 1525,
tracing (1.481 ms) : 1456, 1505
.   : milestone, 1481,
section candidate
no_agent (1.347 ms) : 1327, 1367
.   : milestone, 1347,
appsec (1.726 ms) : 1703, 1749
.   : milestone, 1726,
appsec_no_iast (1.721 ms) : 1696, 1746
.   : milestone, 1721,
iast (1.486 ms) : 1463, 1509
.   : milestone, 1486,
profiling (1.544 ms) : 1519, 1568
.   : milestone, 1544,
tracing (1.478 ms) : 1454, 1501
.   : milestone, 1478,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.343 ms [1.323 ms, 1.362 ms] -
appsec 1.721 ms [1.698 ms, 1.745 ms] 378.573 µs (28.2%)
appsec_no_iast 1.708 ms [1.684 ms, 1.733 ms] 365.654 µs (27.2%)
iast 1.478 ms [1.455 ms, 1.501 ms] 135.235 µs (10.1%)
profiling 1.525 ms [1.502 ms, 1.549 ms] 182.834 µs (13.6%)
tracing 1.481 ms [1.456 ms, 1.505 ms] 138.276 µs (10.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.347 ms [1.327 ms, 1.367 ms] -
appsec 1.726 ms [1.703 ms, 1.749 ms] 379.113 µs (28.2%)
appsec_no_iast 1.721 ms [1.696 ms, 1.746 ms] 374.086 µs (27.8%)
iast 1.486 ms [1.463 ms, 1.509 ms] 139.277 µs (10.3%)
profiling 1.544 ms [1.519 ms, 1.568 ms] 196.829 µs (14.6%)
tracing 1.478 ms [1.454 ms, 1.501 ms] 131.122 µs (9.7%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~1f337a74cc, baseline=1.43.0-SNAPSHOT~f49ac98c70
    dateFormat X
    axisFormat %s
section baseline
no_agent (376.925 µs) : 357, 397
.   : milestone, 377,
iast (486.049 µs) : 464, 508
.   : milestone, 486,
iast_FULL (642.313 µs) : 621, 664
.   : milestone, 642,
iast_GLOBAL (511.006 µs) : 489, 533
.   : milestone, 511,
iast_HARDCODED_SECRET_DISABLED (482.395 µs) : 461, 504
.   : milestone, 482,
iast_INACTIVE (446.281 µs) : 426, 467
.   : milestone, 446,
iast_TELEMETRY_OFF (477.383 µs) : 456, 498
.   : milestone, 477,
tracing (449.441 µs) : 427, 471
.   : milestone, 449,
section candidate
no_agent (374.284 µs) : 354, 395
.   : milestone, 374,
iast (492.013 µs) : 470, 514
.   : milestone, 492,
iast_FULL (641.067 µs) : 620, 662
.   : milestone, 641,
iast_GLOBAL (514.777 µs) : 493, 537
.   : milestone, 515,
iast_HARDCODED_SECRET_DISABLED (482.377 µs) : 461, 504
.   : milestone, 482,
iast_INACTIVE (456.78 µs) : 435, 478
.   : milestone, 457,
iast_TELEMETRY_OFF (479.157 µs) : 458, 500
.   : milestone, 479,
tracing (442.074 µs) : 422, 462
.   : milestone, 442,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 376.925 µs [357.045 µs, 396.806 µs] -
iast 486.049 µs [463.787 µs, 508.311 µs] 109.124 µs (29.0%)
iast_FULL 642.313 µs [620.913 µs, 663.713 µs] 265.388 µs (70.4%)
iast_GLOBAL 511.006 µs [489.275 µs, 532.738 µs] 134.081 µs (35.6%)
iast_HARDCODED_SECRET_DISABLED 482.395 µs [461.024 µs, 503.766 µs] 105.469 µs (28.0%)
iast_INACTIVE 446.281 µs [425.513 µs, 467.048 µs] 69.355 µs (18.4%)
iast_TELEMETRY_OFF 477.383 µs [456.285 µs, 498.481 µs] 100.458 µs (26.7%)
tracing 449.441 µs [427.443 µs, 471.44 µs] 72.516 µs (19.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 374.284 µs [353.814 µs, 394.755 µs] -
iast 492.013 µs [469.946 µs, 514.081 µs] 117.729 µs (31.5%)
iast_FULL 641.067 µs [619.843 µs, 662.291 µs] 266.783 µs (71.3%)
iast_GLOBAL 514.777 µs [492.584 µs, 536.971 µs] 140.493 µs (37.5%)
iast_HARDCODED_SECRET_DISABLED 482.377 µs [461.107 µs, 503.646 µs] 108.093 µs (28.9%)
iast_INACTIVE 456.78 µs [435.11 µs, 478.451 µs] 82.496 µs (22.0%)
iast_TELEMETRY_OFF 479.157 µs [457.978 µs, 500.336 µs] 104.873 µs (28.0%)
tracing 442.074 µs [421.868 µs, 462.28 µs] 67.79 µs (18.1%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master ygree/aws-payload-tagging-fix-pojo-tag-generation
git_commit_date 1730748321 1730791768
git_commit_sha f49ac98 1f337a7
release_version 1.43.0-SNAPSHOT~f49ac98c70 1.43.0-SNAPSHOT~1f337a74cc
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1730794391 1730794391
ci_job_id 695153784 695153784
ci_pipeline_id 48225912 48225912
cpu_model Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~1f337a74cc, baseline=1.43.0-SNAPSHOT~f49ac98c70
    dateFormat X
    axisFormat %s
section baseline
no_agent (20.67 s) : 20670000, 20670000
.   : milestone, 20670000,
appsec (21.102 s) : 21102000, 21102000
.   : milestone, 21102000,
iast (24.878 s) : 24878000, 24878000
.   : milestone, 24878000,
iast_GLOBAL (24.996 s) : 24996000, 24996000
.   : milestone, 24996000,
profiling (20.715 s) : 20715000, 20715000
.   : milestone, 20715000,
tracing (21.045 s) : 21045000, 21045000
.   : milestone, 21045000,
section candidate
no_agent (20.444 s) : 20444000, 20444000
.   : milestone, 20444000,
appsec (21.3 s) : 21300000, 21300000
.   : milestone, 21300000,
iast (24.428 s) : 24428000, 24428000
.   : milestone, 24428000,
iast_GLOBAL (25.237 s) : 25237000, 25237000
.   : milestone, 25237000,
profiling (21.218 s) : 21218000, 21218000
.   : milestone, 21218000,
tracing (21.331 s) : 21331000, 21331000
.   : milestone, 21331000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 20.67 s [20.67 s, 20.67 s] -
appsec 21.102 s [21.102 s, 21.102 s] 432.0 ms (2.1%)
iast 24.878 s [24.878 s, 24.878 s] 4.208 s (20.4%)
iast_GLOBAL 24.996 s [24.996 s, 24.996 s] 4.326 s (20.9%)
profiling 20.715 s [20.715 s, 20.715 s] 45.0 ms (0.2%)
tracing 21.045 s [21.045 s, 21.045 s] 375.0 ms (1.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 20.444 s [20.444 s, 20.444 s] -
appsec 21.3 s [21.3 s, 21.3 s] 856.0 ms (4.2%)
iast 24.428 s [24.428 s, 24.428 s] 3.984 s (19.5%)
iast_GLOBAL 25.237 s [25.237 s, 25.237 s] 4.793 s (23.4%)
profiling 21.218 s [21.218 s, 21.218 s] 774.0 ms (3.8%)
tracing 21.331 s [21.331 s, 21.331 s] 887.0 ms (4.3%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~1f337a74cc, baseline=1.43.0-SNAPSHOT~f49ac98c70
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.544 ms) : 1531, 1557
.   : milestone, 1544,
appsec (2.887 ms) : 2815, 2960
.   : milestone, 2887,
iast (2.508 ms) : 2419, 2598
.   : milestone, 2508,
iast_GLOBAL (2.591 ms) : 2501, 2681
.   : milestone, 2591,
profiling (2.348 ms) : 2273, 2423
.   : milestone, 2348,
tracing (2.305 ms) : 2233, 2377
.   : milestone, 2305,
section candidate
no_agent (1.548 ms) : 1535, 1561
.   : milestone, 1548,
appsec (2.895 ms) : 2822, 2968
.   : milestone, 2895,
iast (2.527 ms) : 2437, 2617
.   : milestone, 2527,
iast_GLOBAL (2.58 ms) : 2490, 2670
.   : milestone, 2580,
profiling (2.337 ms) : 2264, 2410
.   : milestone, 2337,
tracing (2.29 ms) : 2219, 2360
.   : milestone, 2290,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.544 ms [1.531 ms, 1.557 ms] -
appsec 2.887 ms [2.815 ms, 2.96 ms] 1.344 ms (87.0%)
iast 2.508 ms [2.419 ms, 2.598 ms] 964.455 µs (62.5%)
iast_GLOBAL 2.591 ms [2.501 ms, 2.681 ms] 1.047 ms (67.8%)
profiling 2.348 ms [2.273 ms, 2.423 ms] 804.369 µs (52.1%)
tracing 2.305 ms [2.233 ms, 2.377 ms] 761.29 µs (49.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.548 ms [1.535 ms, 1.561 ms] -
appsec 2.895 ms [2.822 ms, 2.968 ms] 1.347 ms (87.0%)
iast 2.527 ms [2.437 ms, 2.617 ms] 978.942 µs (63.2%)
iast_GLOBAL 2.58 ms [2.49 ms, 2.67 ms] 1.032 ms (66.7%)
profiling 2.337 ms [2.264 ms, 2.41 ms] 788.783 µs (50.9%)
tracing 2.29 ms [2.219 ms, 2.36 ms] 741.484 µs (47.9%)

@ygree ygree enabled auto-merge (squash) November 5, 2024 08:40
@ygree ygree merged commit 318e5c8 into master Nov 5, 2024
@ygree ygree deleted the ygree/aws-payload-tagging-fix-pojo-tag-generation branch November 5, 2024 09:05
@ygree ygree modified the milestones: 1.42.1, 1.43.0 Nov 5, 2024
ygree added a commit that referenced this pull request Nov 5, 2024
@ygree
Fix AWS Payload Tagging prefix generation related to SdkPojo (#7882)
29e158b 
* Fix nested SdkPojo fields ordering for tag generation.
* Do not collect null values from AWS SdkPojos
@ygree ygree restored the ygree/aws-payload-tagging-fix-pojo-tag-generation branch November 5, 2024 22:05
ygree added a commit that referenced this pull request Nov 6, 2024
@ygree
Fix AWS Payload Tagging prefix generation related to SdkPojo (#7882)
b17e13d 
* Fix nested SdkPojo fields ordering for tag generation.
* Do not collect null values from AWS SdkPojos
This was referenced Nov 6, 2024
Closed
Merged
@ygree ygree modified the milestones: 1.43.0, 1.42.1 Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@datadog-datadog-prod-us1 datadog-datadog-prod-us1[bot] datadog-datadog-prod-us1[bot] left review comments

@amarziali amarziali amarziali approved these changes

Assignees

@ygree ygree

Labels

inst: aws sdk AWS SDK instrumentation type: bug Bug report and fix

Projects

None yet

Milestone

1.43.0

Development

Successfully merging this pull request may close these issues.

2 participants

@ygree @amarziali