Stable test names in Mongo instrumentation tests#7650
Merged
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~3689e11bcd, baseline=1.40.0-SNAPSHOT~92a664b5b9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.07 s) : 0, 1069828
Total [baseline] (8.556 s) : 0, 8555876
Agent [candidate] (1.068 s) : 0, 1068084
Total [candidate] (8.572 s) : 0, 8572385
section iast
Agent [baseline] (1.193 s) : 0, 1193122
Total [baseline] (9.025 s) : 0, 9025163
Agent [candidate] (1.193 s) : 0, 1192872
Total [candidate] (9.015 s) : 0, 9015432
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.202 s) : 0, 1201503
Total [baseline] (9.022 s) : 0, 9022450
Agent [candidate] (1.2 s) : 0, 1200274
Total [candidate] (9.011 s) : 0, 9011076
section iast_TELEMETRY_OFF
Agent [baseline] (1.189 s) : 0, 1188610
Total [baseline] (9.028 s) : 0, 9028086
Agent [candidate] (1.191 s) : 0, 1190738
Total [candidate] (9.107 s) : 0, 9106649
gantt
title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~3689e11bcd, baseline=1.40.0-SNAPSHOT~92a664b5b9
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (681.778 ms) : 0, 681778
BytebuddyAgent [candidate] (680.468 ms) : 0, 680468
GlobalTracer [baseline] (311.711 ms) : 0, 311711
GlobalTracer [candidate] (311.629 ms) : 0, 311629
AppSec [baseline] (54.142 ms) : 0, 54142
AppSec [candidate] (53.916 ms) : 0, 53916
Remote Config [baseline] (674.723 µs) : 0, 675
Remote Config [candidate] (670.207 µs) : 0, 670
Telemetry [baseline] (7.723 ms) : 0, 7723
Telemetry [candidate] (7.628 ms) : 0, 7628
section iast
BytebuddyAgent [baseline] (792.87 ms) : 0, 792870
BytebuddyAgent [candidate] (793.293 ms) : 0, 793293
GlobalTracer [baseline] (300.135 ms) : 0, 300135
GlobalTracer [candidate] (300.087 ms) : 0, 300087
AppSec [baseline] (54.752 ms) : 0, 54752
AppSec [candidate] (55.319 ms) : 0, 55319
Remote Config [baseline] (609.301 µs) : 0, 609
Remote Config [candidate] (628.285 µs) : 0, 628
Telemetry [baseline] (7.365 ms) : 0, 7365
Telemetry [candidate] (7.49 ms) : 0, 7490
IAST [baseline] (23.601 ms) : 0, 23601
IAST [candidate] (22.206 ms) : 0, 22206
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (798.67 ms) : 0, 798670
BytebuddyAgent [candidate] (798.103 ms) : 0, 798103
GlobalTracer [baseline] (302.161 ms) : 0, 302161
GlobalTracer [candidate] (301.686 ms) : 0, 301686
AppSec [baseline] (56.53 ms) : 0, 56530
AppSec [candidate] (56.632 ms) : 0, 56632
Remote Config [baseline] (612.967 µs) : 0, 613
Remote Config [candidate] (650.564 µs) : 0, 651
Telemetry [baseline] (7.496 ms) : 0, 7496
Telemetry [candidate] (7.396 ms) : 0, 7396
IAST [baseline] (22.179 ms) : 0, 22179
IAST [candidate] (21.943 ms) : 0, 21943
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (788.245 ms) : 0, 788245
BytebuddyAgent [candidate] (789.852 ms) : 0, 789852
GlobalTracer [baseline] (300.178 ms) : 0, 300178
GlobalTracer [candidate] (300.44 ms) : 0, 300440
AppSec [baseline] (54.439 ms) : 0, 54439
AppSec [candidate] (53.88 ms) : 0, 53880
Remote Config [baseline] (1.448 ms) : 0, 1448
Remote Config [candidate] (609.553 µs) : 0, 610
Telemetry [baseline] (7.227 ms) : 0, 7227
Telemetry [candidate] (7.223 ms) : 0, 7223
IAST [baseline] (23.287 ms) : 0, 23287
IAST [candidate] (24.96 ms) : 0, 24960
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~3689e11bcd, baseline=1.40.0-SNAPSHOT~92a664b5b9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.073 s) : 0, 1072662
Total [baseline] (10.382 s) : 0, 10381702
Agent [candidate] (1.068 s) : 0, 1067557
Total [candidate] (10.421 s) : 0, 10420871
section appsec
Agent [baseline] (1.208 s) : 0, 1207832
Total [baseline] (10.702 s) : 0, 10702449
Agent [candidate] (1.205 s) : 0, 1205157
Total [candidate] (10.754 s) : 0, 10753730
section iast
Agent [baseline] (1.202 s) : 0, 1201582
Total [baseline] (10.902 s) : 0, 10901784
Agent [candidate] (1.209 s) : 0, 1208523
Total [candidate] (10.868 s) : 0, 10867627
section profiling
Agent [baseline] (1.278 s) : 0, 1277718
Total [baseline] (10.636 s) : 0, 10635529
Agent [candidate] (1.286 s) : 0, 1285681
Total [candidate] (10.681 s) : 0, 10680827
gantt
title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~3689e11bcd, baseline=1.40.0-SNAPSHOT~92a664b5b9
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (684.36 ms) : 0, 684360
BytebuddyAgent [candidate] (680.342 ms) : 0, 680342
GlobalTracer [baseline] (312.147 ms) : 0, 312147
GlobalTracer [candidate] (311.52 ms) : 0, 311520
AppSec [baseline] (54.021 ms) : 0, 54021
AppSec [candidate] (53.619 ms) : 0, 53619
Remote Config [baseline] (668.533 µs) : 0, 669
Remote Config [candidate] (667.837 µs) : 0, 668
Telemetry [baseline] (7.647 ms) : 0, 7647
Telemetry [candidate] (7.671 ms) : 0, 7671
section appsec
BytebuddyAgent [baseline] (705.44 ms) : 0, 705440
BytebuddyAgent [candidate] (703.052 ms) : 0, 703052
GlobalTracer [baseline] (305.862 ms) : 0, 305862
GlobalTracer [candidate] (304.512 ms) : 0, 304512
AppSec [baseline] (163.141 ms) : 0, 163141
AppSec [candidate] (162.573 ms) : 0, 162573
IAST [baseline] (20.128 ms) : 0, 20128
IAST [candidate] (22.968 ms) : 0, 22968
Remote Config [baseline] (649.457 µs) : 0, 649
Remote Config [candidate] (646.836 µs) : 0, 647
Telemetry [baseline] (8.898 ms) : 0, 8898
Telemetry [candidate] (9.149 ms) : 0, 9149
section iast
BytebuddyAgent [baseline] (798.956 ms) : 0, 798956
BytebuddyAgent [candidate] (802.465 ms) : 0, 802465
GlobalTracer [baseline] (302.065 ms) : 0, 302065
GlobalTracer [candidate] (304.518 ms) : 0, 304518
AppSec [baseline] (56.736 ms) : 0, 56736
AppSec [candidate] (55.62 ms) : 0, 55620
IAST [baseline] (21.986 ms) : 0, 21986
IAST [candidate] (23.927 ms) : 0, 23927
Remote Config [baseline] (614.189 µs) : 0, 614
Remote Config [candidate] (632.127 µs) : 0, 632
Telemetry [baseline] (7.358 ms) : 0, 7358
Telemetry [candidate] (7.48 ms) : 0, 7480
section profiling
BytebuddyAgent [baseline] (679.653 ms) : 0, 679653
BytebuddyAgent [candidate] (684.484 ms) : 0, 684484
GlobalTracer [baseline] (399.584 ms) : 0, 399584
GlobalTracer [candidate] (400.008 ms) : 0, 400008
AppSec [baseline] (54.824 ms) : 0, 54824
AppSec [candidate] (55.44 ms) : 0, 55440
Remote Config [baseline] (662.62 µs) : 0, 663
Remote Config [candidate] (672.927 µs) : 0, 673
Telemetry [baseline] (7.557 ms) : 0, 7557
Telemetry [candidate] (7.643 ms) : 0, 7643
ProfilingAgent [baseline] (96.784 ms) : 0, 96784
ProfilingAgent [candidate] (98.567 ms) : 0, 98567
Profiling [baseline] (96.809 ms) : 0, 96809
Profiling [candidate] (98.591 ms) : 0, 98591
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 18 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~3689e11bcd, baseline=1.40.0-SNAPSHOT~92a664b5b9
dateFormat X
axisFormat %s
section baseline
no_agent (1.354 ms) : 1334, 1374
. : milestone, 1354,
appsec (1.691 ms) : 1665, 1717
. : milestone, 1691,
appsec_no_iast (1.723 ms) : 1700, 1747
. : milestone, 1723,
iast (1.467 ms) : 1444, 1489
. : milestone, 1467,
profiling (1.466 ms) : 1441, 1491
. : milestone, 1466,
tracing (1.479 ms) : 1455, 1504
. : milestone, 1479,
section candidate
no_agent (1.335 ms) : 1316, 1355
. : milestone, 1335,
appsec (1.713 ms) : 1689, 1737
. : milestone, 1713,
appsec_no_iast (1.718 ms) : 1695, 1741
. : milestone, 1718,
iast (1.483 ms) : 1460, 1505
. : milestone, 1483,
profiling (1.516 ms) : 1490, 1542
. : milestone, 1516,
tracing (1.468 ms) : 1443, 1493
. : milestone, 1468,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~3689e11bcd, baseline=1.40.0-SNAPSHOT~92a664b5b9
dateFormat X
axisFormat %s
section baseline
no_agent (373.039 µs) : 351, 395
. : milestone, 373,
iast (483.128 µs) : 462, 505
. : milestone, 483,
iast_FULL (554.828 µs) : 533, 576
. : milestone, 555,
iast_GLOBAL (507.126 µs) : 485, 529
. : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (483.212 µs) : 462, 504
. : milestone, 483,
iast_INACTIVE (448.495 µs) : 427, 470
. : milestone, 448,
iast_TELEMETRY_OFF (472.215 µs) : 449, 495
. : milestone, 472,
tracing (440.055 µs) : 419, 461
. : milestone, 440,
section candidate
no_agent (368.351 µs) : 349, 388
. : milestone, 368,
iast (484.724 µs) : 463, 506
. : milestone, 485,
iast_FULL (551.134 µs) : 530, 572
. : milestone, 551,
iast_GLOBAL (507.058 µs) : 485, 529
. : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (478.312 µs) : 457, 500
. : milestone, 478,
iast_INACTIVE (451.697 µs) : 430, 473
. : milestone, 452,
iast_TELEMETRY_OFF (471.391 µs) : 449, 494
. : milestone, 471,
tracing (439.543 µs) : 419, 460
. : milestone, 440,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~3689e11bcd, baseline=1.40.0-SNAPSHOT~92a664b5b9
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1467, 1491
. : milestone, 1479,
appsec (2.338 ms) : 2296, 2379
. : milestone, 2338,
iast (2.084 ms) : 2033, 2136
. : milestone, 2084,
iast_GLOBAL (2.118 ms) : 2066, 2169
. : milestone, 2118,
profiling (1.95 ms) : 1909, 1991
. : milestone, 1950,
tracing (1.926 ms) : 1887, 1964
. : milestone, 1926,
section candidate
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (2.329 ms) : 2288, 2370
. : milestone, 2329,
iast (2.059 ms) : 2010, 2109
. : milestone, 2059,
iast_GLOBAL (2.108 ms) : 2058, 2158
. : milestone, 2108,
profiling (1.935 ms) : 1895, 1974
. : milestone, 1935,
tracing (1.913 ms) : 1874, 1951
. : milestone, 1913,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~3689e11bcd, baseline=1.40.0-SNAPSHOT~92a664b5b9
dateFormat X
axisFormat %s
section baseline
no_agent (15.455 s) : 15455000, 15455000
. : milestone, 15455000,
appsec (15.23 s) : 15230000, 15230000
. : milestone, 15230000,
iast (18.995 s) : 18995000, 18995000
. : milestone, 18995000,
iast_GLOBAL (18.216 s) : 18216000, 18216000
. : milestone, 18216000,
profiling (15.257 s) : 15257000, 15257000
. : milestone, 15257000,
tracing (15.092 s) : 15092000, 15092000
. : milestone, 15092000,
section candidate
no_agent (14.816 s) : 14816000, 14816000
. : milestone, 14816000,
appsec (15.284 s) : 15284000, 15284000
. : milestone, 15284000,
iast (18.811 s) : 18811000, 18811000
. : milestone, 18811000,
iast_GLOBAL (18.025 s) : 18025000, 18025000
. : milestone, 18025000,
profiling (15.712 s) : 15712000, 15712000
. : milestone, 15712000,
tracing (15.105 s) : 15105000, 15105000
. : milestone, 15105000,
|
amarziali
approved these changes
Sep 20, 2024
PerfectSlayer
approved these changes
Sep 20, 2024
Contributor
PerfectSlayer
left a comment
There was a problem hiding this comment.
Thanks for the improvement!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Avoid unstable test names, such as
test create collection [collectionName: testCollection-806d900f-caae-483d-ad69-df899f2169bc, renameService: false, #0]. These prevent flakiness detection.Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issue[ ] Update the public documentation in case of new configuration flag or behavior