Refactor freemarker instrumentation folder#7533
Merged
Conversation
smola
approved these changes
Aug 30, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~2974ef5378, baseline=1.39.0-SNAPSHOT~f31ddbb0a5
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1059253
Total [baseline] (10.378 s) : 0, 10377721
Agent [candidate] (1.052 s) : 0, 1052028
Total [candidate] (10.354 s) : 0, 10354426
section appsec
Agent [baseline] (1.191 s) : 0, 1190638
Total [baseline] (10.594 s) : 0, 10593934
Agent [candidate] (1.181 s) : 0, 1180920
Total [candidate] (10.564 s) : 0, 10563918
section iast
Agent [baseline] (1.177 s) : 0, 1177061
Total [baseline] (10.846 s) : 0, 10845555
Agent [candidate] (1.189 s) : 0, 1189429
Total [candidate] (10.891 s) : 0, 10890742
section profiling
Agent [baseline] (1.249 s) : 0, 1249251
Total [baseline] (10.616 s) : 0, 10615637
Agent [candidate] (1.249 s) : 0, 1249250
Total [candidate] (10.6 s) : 0, 10600296
gantt
title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~2974ef5378, baseline=1.39.0-SNAPSHOT~f31ddbb0a5
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (676.15 ms) : 0, 676150
BytebuddyAgent [candidate] (670.786 ms) : 0, 670786
GlobalTracer [baseline] (309.193 ms) : 0, 309193
GlobalTracer [candidate] (307.875 ms) : 0, 307875
AppSec [baseline] (51.882 ms) : 0, 51882
AppSec [candidate] (51.542 ms) : 0, 51542
Remote Config [baseline] (687.357 µs) : 0, 687
Remote Config [candidate] (676.917 µs) : 0, 677
Telemetry [baseline] (7.625 ms) : 0, 7625
Telemetry [candidate] (7.52 ms) : 0, 7520
section appsec
BytebuddyAgent [baseline] (693.232 ms) : 0, 693232
BytebuddyAgent [candidate] (687.567 ms) : 0, 687567
GlobalTracer [baseline] (303.008 ms) : 0, 303008
GlobalTracer [candidate] (300.962 ms) : 0, 300962
AppSec [baseline] (161.267 ms) : 0, 161267
AppSec [candidate] (158.781 ms) : 0, 158781
Remote Config [baseline] (607.127 µs) : 0, 607
Remote Config [candidate] (610.579 µs) : 0, 611
Telemetry [baseline] (8.812 ms) : 0, 8812
Telemetry [candidate] (8.211 ms) : 0, 8211
IAST [baseline] (20.127 ms) : 0, 20127
IAST [candidate] (22.413 ms) : 0, 22413
section iast
BytebuddyAgent [baseline] (782.146 ms) : 0, 782146
BytebuddyAgent [candidate] (790.017 ms) : 0, 790017
GlobalTracer [baseline] (296.998 ms) : 0, 296998
GlobalTracer [candidate] (300.723 ms) : 0, 300723
AppSec [baseline] (52.819 ms) : 0, 52819
AppSec [candidate] (51.332 ms) : 0, 51332
Remote Config [baseline] (589.055 µs) : 0, 589
Remote Config [candidate] (611.066 µs) : 0, 611
Telemetry [baseline] (8.098 ms) : 0, 8098
Telemetry [candidate] (9.82 ms) : 0, 9820
IAST [baseline] (22.769 ms) : 0, 22769
IAST [candidate] (23.173 ms) : 0, 23173
section profiling
BytebuddyAgent [baseline] (665.489 ms) : 0, 665489
BytebuddyAgent [candidate] (665.403 ms) : 0, 665403
GlobalTracer [baseline] (389.458 ms) : 0, 389458
GlobalTracer [candidate] (389.448 ms) : 0, 389448
AppSec [baseline] (52.087 ms) : 0, 52087
AppSec [candidate] (52.027 ms) : 0, 52027
Remote Config [baseline] (681.424 µs) : 0, 681
Remote Config [candidate] (677.61 µs) : 0, 678
Telemetry [baseline] (7.37 ms) : 0, 7370
Telemetry [candidate] (7.423 ms) : 0, 7423
ProfilingAgent [baseline] (96.298 ms) : 0, 96298
ProfilingAgent [candidate] (96.314 ms) : 0, 96314
Profiling [baseline] (96.321 ms) : 0, 96321
Profiling [candidate] (96.339 ms) : 0, 96339
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~2974ef5378, baseline=1.39.0-SNAPSHOT~f31ddbb0a5
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1053931
Total [baseline] (8.491 s) : 0, 8491375
Agent [candidate] (1.051 s) : 0, 1051413
Total [candidate] (8.493 s) : 0, 8492959
section iast
Agent [baseline] (1.174 s) : 0, 1174419
Total [baseline] (8.953 s) : 0, 8952733
Agent [candidate] (1.177 s) : 0, 1176970
Total [candidate] (8.958 s) : 0, 8958067
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.202 s) : 0, 1202214
Total [baseline] (8.977 s) : 0, 8976879
Agent [candidate] (1.186 s) : 0, 1185768
Total [candidate] (8.994 s) : 0, 8994309
section iast_TELEMETRY_OFF
Agent [baseline] (1.17 s) : 0, 1169857
Total [baseline] (8.983 s) : 0, 8982651
Agent [candidate] (1.182 s) : 0, 1181631
Total [candidate] (8.99 s) : 0, 8990080
gantt
title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~2974ef5378, baseline=1.39.0-SNAPSHOT~f31ddbb0a5
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (672.212 ms) : 0, 672212
BytebuddyAgent [candidate] (670.018 ms) : 0, 670018
GlobalTracer [baseline] (308.264 ms) : 0, 308264
GlobalTracer [candidate] (308.291 ms) : 0, 308291
AppSec [baseline] (51.613 ms) : 0, 51613
AppSec [candidate] (51.32 ms) : 0, 51320
Remote Config [baseline] (665.978 µs) : 0, 666
Remote Config [candidate] (673.418 µs) : 0, 673
Telemetry [baseline] (7.519 ms) : 0, 7519
Telemetry [candidate] (7.479 ms) : 0, 7479
section iast
BytebuddyAgent [baseline] (780.046 ms) : 0, 780046
BytebuddyAgent [candidate] (781.801 ms) : 0, 781801
GlobalTracer [baseline] (295.946 ms) : 0, 295946
GlobalTracer [candidate] (296.842 ms) : 0, 296842
AppSec [baseline] (52.284 ms) : 0, 52284
AppSec [candidate] (52.241 ms) : 0, 52241
IAST [baseline] (23.848 ms) : 0, 23848
IAST [candidate] (24.524 ms) : 0, 24524
Remote Config [baseline] (601.161 µs) : 0, 601
Remote Config [candidate] (591.666 µs) : 0, 592
Telemetry [baseline] (8.09 ms) : 0, 8090
Telemetry [candidate] (7.31 ms) : 0, 7310
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (799.905 ms) : 0, 799905
BytebuddyAgent [candidate] (787.909 ms) : 0, 787909
GlobalTracer [baseline] (302.586 ms) : 0, 302586
GlobalTracer [candidate] (299.039 ms) : 0, 299039
AppSec [baseline] (54.38 ms) : 0, 54380
AppSec [candidate] (51.686 ms) : 0, 51686
IAST [baseline] (22.492 ms) : 0, 22492
IAST [candidate] (25.32 ms) : 0, 25320
Remote Config [baseline] (597.506 µs) : 0, 598
Remote Config [candidate] (585.893 µs) : 0, 586
Telemetry [baseline] (8.282 ms) : 0, 8282
Telemetry [candidate] (7.41 ms) : 0, 7410
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (776.533 ms) : 0, 776533
BytebuddyAgent [candidate] (784.47 ms) : 0, 784470
GlobalTracer [baseline] (295.861 ms) : 0, 295861
GlobalTracer [candidate] (298.675 ms) : 0, 298675
AppSec [baseline] (52.702 ms) : 0, 52702
AppSec [candidate] (51.744 ms) : 0, 51744
IAST [baseline] (23.346 ms) : 0, 23346
IAST [candidate] (25.031 ms) : 0, 25031
Remote Config [baseline] (577.342 µs) : 0, 577
Remote Config [candidate] (590.638 µs) : 0, 591
Telemetry [baseline] (7.194 ms) : 0, 7194
Telemetry [candidate] (7.336 ms) : 0, 7336
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 18 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~2974ef5378, baseline=1.39.0-SNAPSHOT~f31ddbb0a5
dateFormat X
axisFormat %s
section baseline
no_agent (361.027 µs) : 342, 380
. : milestone, 361,
iast (474.748 µs) : 452, 497
. : milestone, 475,
iast_FULL (549.771 µs) : 529, 571
. : milestone, 550,
iast_GLOBAL (504.687 µs) : 483, 526
. : milestone, 505,
iast_HARDCODED_SECRET_DISABLED (481.045 µs) : 459, 504
. : milestone, 481,
iast_INACTIVE (442.041 µs) : 422, 462
. : milestone, 442,
iast_TELEMETRY_OFF (469.829 µs) : 448, 492
. : milestone, 470,
tracing (448.262 µs) : 428, 469
. : milestone, 448,
section candidate
no_agent (372.653 µs) : 352, 393
. : milestone, 373,
iast (476.582 µs) : 453, 500
. : milestone, 477,
iast_FULL (545.959 µs) : 525, 567
. : milestone, 546,
iast_GLOBAL (499.696 µs) : 479, 521
. : milestone, 500,
iast_HARDCODED_SECRET_DISABLED (484.823 µs) : 462, 507
. : milestone, 485,
iast_INACTIVE (436.062 µs) : 416, 456
. : milestone, 436,
iast_TELEMETRY_OFF (472.355 µs) : 450, 495
. : milestone, 472,
tracing (436.224 µs) : 416, 457
. : milestone, 436,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~2974ef5378, baseline=1.39.0-SNAPSHOT~f31ddbb0a5
dateFormat X
axisFormat %s
section baseline
no_agent (1.341 ms) : 1321, 1360
. : milestone, 1341,
appsec (1.707 ms) : 1682, 1731
. : milestone, 1707,
appsec_no_iast (1.737 ms) : 1713, 1762
. : milestone, 1737,
iast (1.478 ms) : 1455, 1500
. : milestone, 1478,
profiling (1.48 ms) : 1457, 1502
. : milestone, 1480,
tracing (1.464 ms) : 1440, 1489
. : milestone, 1464,
section candidate
no_agent (1.342 ms) : 1322, 1361
. : milestone, 1342,
appsec (1.69 ms) : 1665, 1714
. : milestone, 1690,
appsec_no_iast (1.719 ms) : 1695, 1743
. : milestone, 1719,
iast (1.473 ms) : 1450, 1496
. : milestone, 1473,
profiling (1.47 ms) : 1447, 1493
. : milestone, 1470,
tracing (1.461 ms) : 1436, 1487
. : milestone, 1461,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~2974ef5378, baseline=1.39.0-SNAPSHOT~f31ddbb0a5
dateFormat X
axisFormat %s
section baseline
no_agent (1.462 ms) : 1450, 1473
. : milestone, 1462,
appsec (2.214 ms) : 2178, 2249
. : milestone, 2214,
iast (1.977 ms) : 1933, 2020
. : milestone, 1977,
iast_GLOBAL (2.021 ms) : 1977, 2065
. : milestone, 2021,
profiling (1.865 ms) : 1831, 1900
. : milestone, 1865,
tracing (1.836 ms) : 1803, 1869
. : milestone, 1836,
section candidate
no_agent (1.449 ms) : 1437, 1460
. : milestone, 1449,
appsec (2.225 ms) : 2189, 2261
. : milestone, 2225,
iast (1.967 ms) : 1924, 2010
. : milestone, 1967,
iast_GLOBAL (2.018 ms) : 1975, 2062
. : milestone, 2018,
profiling (1.858 ms) : 1823, 1892
. : milestone, 1858,
tracing (1.838 ms) : 1805, 1871
. : milestone, 1838,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~2974ef5378, baseline=1.39.0-SNAPSHOT~f31ddbb0a5
dateFormat X
axisFormat %s
section baseline
no_agent (15.202 s) : 15202000, 15202000
. : milestone, 15202000,
appsec (15.281 s) : 15281000, 15281000
. : milestone, 15281000,
iast (19.069 s) : 19069000, 19069000
. : milestone, 19069000,
iast_GLOBAL (18.125 s) : 18125000, 18125000
. : milestone, 18125000,
profiling (15.345 s) : 15345000, 15345000
. : milestone, 15345000,
tracing (15.106 s) : 15106000, 15106000
. : milestone, 15106000,
section candidate
no_agent (15.211 s) : 15211000, 15211000
. : milestone, 15211000,
appsec (15.368 s) : 15368000, 15368000
. : milestone, 15368000,
iast (18.656 s) : 18656000, 18656000
. : milestone, 18656000,
iast_GLOBAL (17.663 s) : 17663000, 17663000
. : milestone, 17663000,
profiling (15.362 s) : 15362000, 15362000
. : milestone, 15362000,
tracing (15.157 s) : 15157000, 15157000
. : milestone, 15157000,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
This aims to make more visible which versions is instrumenting at the moment
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: APPSEC-11285