Set DD_APPSEC_RASP_ENABLED to true by default#7528
Merged
Conversation
3ef5847 to
e3aebe4
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 15 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~e3aebe40d9, baseline=1.39.0-SNAPSHOT~b7907a264e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1055680
Total [baseline] (10.459 s) : 0, 10459287
Agent [candidate] (1.049 s) : 0, 1048523
Total [candidate] (10.397 s) : 0, 10397416
section appsec
Agent [baseline] (1.182 s) : 0, 1181947
Total [baseline] (10.483 s) : 0, 10483236
Agent [candidate] (1.186 s) : 0, 1186306
Total [candidate] (10.645 s) : 0, 10644897
section iast
Agent [baseline] (1.174 s) : 0, 1173981
Total [baseline] (10.869 s) : 0, 10869313
Agent [candidate] (1.174 s) : 0, 1174333
Total [candidate] (10.889 s) : 0, 10889303
section profiling
Agent [baseline] (1.248 s) : 0, 1247673
Total [baseline] (10.578 s) : 0, 10578065
Agent [candidate] (1.253 s) : 0, 1253052
Total [candidate] (10.644 s) : 0, 10643547
gantt
title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~e3aebe40d9, baseline=1.39.0-SNAPSHOT~b7907a264e
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (673.649 ms) : 0, 673649
BytebuddyAgent [candidate] (668.72 ms) : 0, 668720
GlobalTracer [baseline] (308.46 ms) : 0, 308460
GlobalTracer [candidate] (306.647 ms) : 0, 306647
AppSec [baseline] (51.689 ms) : 0, 51689
AppSec [candidate] (51.401 ms) : 0, 51401
Remote Config [baseline] (672.437 µs) : 0, 672
Remote Config [candidate] (671.546 µs) : 0, 672
Telemetry [baseline] (7.547 ms) : 0, 7547
Telemetry [candidate] (7.521 ms) : 0, 7521
section appsec
BytebuddyAgent [baseline] (685.179 ms) : 0, 685179
BytebuddyAgent [candidate] (689.79 ms) : 0, 689790
GlobalTracer [baseline] (303.163 ms) : 0, 303163
GlobalTracer [candidate] (302.55 ms) : 0, 302550
AppSec [baseline] (162.647 ms) : 0, 162647
AppSec [candidate] (161.281 ms) : 0, 161281
Remote Config [baseline] (629.949 µs) : 0, 630
Remote Config [candidate] (621.104 µs) : 0, 621
Telemetry [baseline] (7.421 ms) : 0, 7421
Telemetry [candidate] (8.52 ms) : 0, 8520
IAST [baseline] (18.424 ms) : 0, 18424
IAST [candidate] (19.782 ms) : 0, 19782
section iast
BytebuddyAgent [baseline] (778.895 ms) : 0, 778895
BytebuddyAgent [candidate] (778.572 ms) : 0, 778572
GlobalTracer [baseline] (296.757 ms) : 0, 296757
GlobalTracer [candidate] (297.767 ms) : 0, 297767
AppSec [baseline] (51.324 ms) : 0, 51324
AppSec [candidate] (49.177 ms) : 0, 49177
Remote Config [baseline] (589.388 µs) : 0, 589
Remote Config [candidate] (588.216 µs) : 0, 588
Telemetry [baseline] (8.719 ms) : 0, 8719
Telemetry [candidate] (8.746 ms) : 0, 8746
IAST [baseline] (24.1 ms) : 0, 24100
IAST [candidate] (25.868 ms) : 0, 25868
section profiling
BytebuddyAgent [baseline] (664.089 ms) : 0, 664089
BytebuddyAgent [candidate] (668.63 ms) : 0, 668630
GlobalTracer [baseline] (389.825 ms) : 0, 389825
GlobalTracer [candidate] (389.971 ms) : 0, 389971
AppSec [baseline] (52.296 ms) : 0, 52296
AppSec [candidate] (52.606 ms) : 0, 52606
Remote Config [baseline] (690.187 µs) : 0, 690
Remote Config [candidate] (691.952 µs) : 0, 692
Telemetry [baseline] (7.341 ms) : 0, 7341
Telemetry [candidate] (7.347 ms) : 0, 7347
ProfilingAgent [baseline] (96.092 ms) : 0, 96092
ProfilingAgent [candidate] (96.198 ms) : 0, 96198
Profiling [baseline] (96.115 ms) : 0, 96115
Profiling [candidate] (96.222 ms) : 0, 96222
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~e3aebe40d9, baseline=1.39.0-SNAPSHOT~b7907a264e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1064980
Total [baseline] (8.528 s) : 0, 8528084
Agent [candidate] (1.049 s) : 0, 1049153
Total [candidate] (8.487 s) : 0, 8486505
section iast
Agent [baseline] (1.172 s) : 0, 1172079
Total [baseline] (9.038 s) : 0, 9037834
Agent [candidate] (1.174 s) : 0, 1173867
Total [candidate] (8.969 s) : 0, 8969211
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.174 s) : 0, 1174044
Total [baseline] (8.972 s) : 0, 8971793
Agent [candidate] (1.174 s) : 0, 1174287
Total [candidate] (8.949 s) : 0, 8949108
section iast_TELEMETRY_OFF
Agent [baseline] (1.171 s) : 0, 1170922
Total [baseline] (8.962 s) : 0, 8962492
Agent [candidate] (1.167 s) : 0, 1167261
Total [candidate] (8.957 s) : 0, 8957140
gantt
title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~e3aebe40d9, baseline=1.39.0-SNAPSHOT~b7907a264e
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (679.675 ms) : 0, 679675
BytebuddyAgent [candidate] (669.455 ms) : 0, 669455
GlobalTracer [baseline] (310.945 ms) : 0, 310945
GlobalTracer [candidate] (306.488 ms) : 0, 306488
AppSec [baseline] (52.269 ms) : 0, 52269
AppSec [candidate] (51.404 ms) : 0, 51404
Remote Config [baseline] (680.068 µs) : 0, 680
Remote Config [candidate] (664.399 µs) : 0, 664
Telemetry [baseline] (7.626 ms) : 0, 7626
Telemetry [candidate] (7.539 ms) : 0, 7539
section iast
BytebuddyAgent [baseline] (777.549 ms) : 0, 777549
BytebuddyAgent [candidate] (780.32 ms) : 0, 780320
GlobalTracer [baseline] (295.995 ms) : 0, 295995
GlobalTracer [candidate] (295.841 ms) : 0, 295841
AppSec [baseline] (49.871 ms) : 0, 49871
AppSec [candidate] (49.874 ms) : 0, 49874
IAST [baseline] (27.306 ms) : 0, 27306
IAST [candidate] (25.632 ms) : 0, 25632
Remote Config [baseline] (595.175 µs) : 0, 595
Remote Config [candidate] (597.007 µs) : 0, 597
Telemetry [baseline] (7.218 ms) : 0, 7218
Telemetry [candidate] (7.962 ms) : 0, 7962
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (779.269 ms) : 0, 779269
BytebuddyAgent [candidate] (778.966 ms) : 0, 778966
GlobalTracer [baseline] (296.394 ms) : 0, 296394
GlobalTracer [candidate] (297.012 ms) : 0, 297012
AppSec [baseline] (48.996 ms) : 0, 48996
AppSec [candidate] (52.891 ms) : 0, 52891
IAST [baseline] (25.666 ms) : 0, 25666
IAST [candidate] (23.979 ms) : 0, 23979
Remote Config [baseline] (590.256 µs) : 0, 590
Remote Config [candidate] (584.982 µs) : 0, 585
Telemetry [baseline] (9.554 ms) : 0, 9554
Telemetry [candidate] (7.244 ms) : 0, 7244
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (777.532 ms) : 0, 777532
BytebuddyAgent [candidate] (773.631 ms) : 0, 773631
GlobalTracer [baseline] (296.862 ms) : 0, 296862
GlobalTracer [candidate] (296.052 ms) : 0, 296052
AppSec [baseline] (49.733 ms) : 0, 49733
AppSec [candidate] (50.178 ms) : 0, 50178
IAST [baseline] (24.773 ms) : 0, 24773
IAST [candidate] (24.763 ms) : 0, 24763
Remote Config [baseline] (598.017 µs) : 0, 598
Remote Config [candidate] (577.248 µs) : 0, 577
Telemetry [baseline] (7.809 ms) : 0, 7809
Telemetry [candidate] (8.474 ms) : 0, 8474
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 18 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~e3aebe40d9, baseline=1.39.0-SNAPSHOT~b7907a264e
dateFormat X
axisFormat %s
section baseline
no_agent (368.259 µs) : 349, 388
. : milestone, 368,
iast (490.385 µs) : 468, 513
. : milestone, 490,
iast_FULL (554.137 µs) : 533, 575
. : milestone, 554,
iast_GLOBAL (506.4 µs) : 485, 528
. : milestone, 506,
iast_HARDCODED_SECRET_DISABLED (482.039 µs) : 460, 504
. : milestone, 482,
iast_INACTIVE (446.23 µs) : 425, 467
. : milestone, 446,
iast_TELEMETRY_OFF (476.063 µs) : 454, 498
. : milestone, 476,
tracing (445.153 µs) : 424, 466
. : milestone, 445,
section candidate
no_agent (371.789 µs) : 353, 391
. : milestone, 372,
iast (487.135 µs) : 465, 510
. : milestone, 487,
iast_FULL (553.797 µs) : 532, 575
. : milestone, 554,
iast_GLOBAL (512.864 µs) : 490, 536
. : milestone, 513,
iast_HARDCODED_SECRET_DISABLED (484.273 µs) : 462, 507
. : milestone, 484,
iast_INACTIVE (446.729 µs) : 426, 468
. : milestone, 447,
iast_TELEMETRY_OFF (477.928 µs) : 456, 500
. : milestone, 478,
tracing (442.762 µs) : 422, 463
. : milestone, 443,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~e3aebe40d9, baseline=1.39.0-SNAPSHOT~b7907a264e
dateFormat X
axisFormat %s
section baseline
no_agent (1.352 ms) : 1332, 1372
. : milestone, 1352,
appsec (1.724 ms) : 1701, 1748
. : milestone, 1724,
appsec_no_iast (1.721 ms) : 1697, 1745
. : milestone, 1721,
iast (1.474 ms) : 1451, 1496
. : milestone, 1474,
profiling (1.482 ms) : 1458, 1505
. : milestone, 1482,
tracing (1.478 ms) : 1454, 1502
. : milestone, 1478,
section candidate
no_agent (1.338 ms) : 1319, 1358
. : milestone, 1338,
appsec (1.716 ms) : 1693, 1740
. : milestone, 1716,
appsec_no_iast (1.726 ms) : 1703, 1750
. : milestone, 1726,
iast (1.48 ms) : 1458, 1502
. : milestone, 1480,
profiling (1.486 ms) : 1464, 1509
. : milestone, 1486,
tracing (1.469 ms) : 1444, 1494
. : milestone, 1469,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~e3aebe40d9, baseline=1.39.0-SNAPSHOT~b7907a264e
dateFormat X
axisFormat %s
section baseline
no_agent (1.461 ms) : 1449, 1473
. : milestone, 1461,
appsec (2.224 ms) : 2189, 2259
. : milestone, 2224,
iast (1.98 ms) : 1937, 2022
. : milestone, 1980,
iast_GLOBAL (2.014 ms) : 1970, 2057
. : milestone, 2014,
profiling (1.849 ms) : 1815, 1883
. : milestone, 1849,
tracing (1.84 ms) : 1806, 1873
. : milestone, 1840,
section candidate
no_agent (1.454 ms) : 1442, 1465
. : milestone, 1454,
appsec (2.217 ms) : 2182, 2251
. : milestone, 2217,
iast (1.98 ms) : 1937, 2022
. : milestone, 1980,
iast_GLOBAL (2.013 ms) : 1969, 2057
. : milestone, 2013,
profiling (1.855 ms) : 1821, 1889
. : milestone, 1855,
tracing (1.831 ms) : 1798, 1863
. : milestone, 1831,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~e3aebe40d9, baseline=1.39.0-SNAPSHOT~b7907a264e
dateFormat X
axisFormat %s
section baseline
no_agent (15.269 s) : 15269000, 15269000
. : milestone, 15269000,
appsec (14.922 s) : 14922000, 14922000
. : milestone, 14922000,
iast (18.507 s) : 18507000, 18507000
. : milestone, 18507000,
iast_GLOBAL (17.611 s) : 17611000, 17611000
. : milestone, 17611000,
profiling (15.147 s) : 15147000, 15147000
. : milestone, 15147000,
tracing (14.953 s) : 14953000, 14953000
. : milestone, 14953000,
section candidate
no_agent (15.331 s) : 15331000, 15331000
. : milestone, 15331000,
appsec (14.896 s) : 14896000, 14896000
. : milestone, 14896000,
iast (18.631 s) : 18631000, 18631000
. : milestone, 18631000,
iast_GLOBAL (17.892 s) : 17892000, 17892000
. : milestone, 17892000,
profiling (15.531 s) : 15531000, 15531000
. : milestone, 15531000,
tracing (15.089 s) : 15089000, 15089000
. : milestone, 15089000,
|
jandro996
approved these changes
Aug 29, 2024
ValentinZakharov
approved these changes
Aug 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Sets
DD_APPSEC_RASP_ENABLED=trueby default. Only effective whenDD_APPSEC_ENABLED=true(or enabled at runtime by remote config).Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issue[ ] Update the public documentation in case of new configuration flag or behaviorJira ticket: APPSEC-53837