Split Gradle instrumentations into different modules#7523
Merged
nikita-tkachenko-datadog merged 2 commits intomasterfrom Aug 28, 2024
Merged
Split Gradle instrumentations into different modules#7523nikita-tkachenko-datadog merged 2 commits intomasterfrom
nikita-tkachenko-datadog merged 2 commits intomasterfrom
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 15 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~9096cda658, baseline=1.39.0-SNAPSHOT~01d9133076
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.048 s) : 0, 1048181
Total [baseline] (10.382 s) : 0, 10382213
Agent [candidate] (1.049 s) : 0, 1048936
Total [candidate] (10.417 s) : 0, 10416808
section appsec
Agent [baseline] (1.174 s) : 0, 1173688
Total [baseline] (10.481 s) : 0, 10481042
Agent [candidate] (1.177 s) : 0, 1176837
Total [candidate] (10.481 s) : 0, 10480756
section iast
Agent [baseline] (1.173 s) : 0, 1173417
Total [baseline] (10.798 s) : 0, 10798483
Agent [candidate] (1.17 s) : 0, 1169864
Total [candidate] (10.818 s) : 0, 10818199
section profiling
Agent [baseline] (1.245 s) : 0, 1245385
Total [baseline] (10.711 s) : 0, 10711421
Agent [candidate] (1.246 s) : 0, 1245554
Total [candidate] (10.653 s) : 0, 10653100
gantt
title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~9096cda658, baseline=1.39.0-SNAPSHOT~01d9133076
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (668.92 ms) : 0, 668920
BytebuddyAgent [candidate] (669.37 ms) : 0, 669370
GlobalTracer [baseline] (306.609 ms) : 0, 306609
GlobalTracer [candidate] (306.508 ms) : 0, 306508
AppSec [baseline] (51.01 ms) : 0, 51010
AppSec [candidate] (51.397 ms) : 0, 51397
Remote Config [baseline] (657.893 µs) : 0, 658
Remote Config [candidate] (660.941 µs) : 0, 661
Telemetry [baseline] (7.451 ms) : 0, 7451
Telemetry [candidate] (7.444 ms) : 0, 7444
section appsec
BytebuddyAgent [baseline] (679.622 ms) : 0, 679622
BytebuddyAgent [candidate] (683.432 ms) : 0, 683432
GlobalTracer [baseline] (302.128 ms) : 0, 302128
GlobalTracer [candidate] (302.436 ms) : 0, 302436
AppSec [baseline] (161.065 ms) : 0, 161065
AppSec [candidate] (159.529 ms) : 0, 159529
Remote Config [baseline] (636.523 µs) : 0, 637
Remote Config [candidate] (625.695 µs) : 0, 626
Telemetry [baseline] (7.422 ms) : 0, 7422
Telemetry [candidate] (7.814 ms) : 0, 7814
IAST [baseline] (18.461 ms) : 0, 18461
IAST [candidate] (18.679 ms) : 0, 18679
section iast
BytebuddyAgent [baseline] (778.677 ms) : 0, 778677
BytebuddyAgent [candidate] (777.454 ms) : 0, 777454
GlobalTracer [baseline] (296.323 ms) : 0, 296323
GlobalTracer [candidate] (295.895 ms) : 0, 295895
AppSec [baseline] (50.566 ms) : 0, 50566
AppSec [candidate] (49.801 ms) : 0, 49801
Remote Config [baseline] (596.82 µs) : 0, 597
Remote Config [candidate] (607.176 µs) : 0, 607
Telemetry [baseline] (9.497 ms) : 0, 9497
Telemetry [candidate] (9.662 ms) : 0, 9662
IAST [baseline] (24.205 ms) : 0, 24205
IAST [candidate] (22.847 ms) : 0, 22847
section profiling
BytebuddyAgent [baseline] (662.428 ms) : 0, 662428
BytebuddyAgent [candidate] (663.63 ms) : 0, 663630
GlobalTracer [baseline] (389.655 ms) : 0, 389655
GlobalTracer [candidate] (389.283 ms) : 0, 389283
AppSec [baseline] (52.286 ms) : 0, 52286
AppSec [candidate] (51.757 ms) : 0, 51757
Remote Config [baseline] (670.938 µs) : 0, 671
Remote Config [candidate] (677.37 µs) : 0, 677
Telemetry [baseline] (7.295 ms) : 0, 7295
Telemetry [candidate] (7.291 ms) : 0, 7291
ProfilingAgent [baseline] (95.833 ms) : 0, 95833
ProfilingAgent [candidate] (95.531 ms) : 0, 95531
Profiling [baseline] (95.857 ms) : 0, 95857
Profiling [candidate] (95.554 ms) : 0, 95554
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~9096cda658, baseline=1.39.0-SNAPSHOT~01d9133076
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1046125
Total [baseline] (8.503 s) : 0, 8503228
Agent [candidate] (1.046 s) : 0, 1046036
Total [candidate] (8.512 s) : 0, 8511626
section iast
Agent [baseline] (1.175 s) : 0, 1175345
Total [baseline] (8.993 s) : 0, 8992777
Agent [candidate] (1.169 s) : 0, 1169219
Total [candidate] (8.983 s) : 0, 8983027
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.173 s) : 0, 1172870
Total [baseline] (8.96 s) : 0, 8959537
Agent [candidate] (1.174 s) : 0, 1174297
Total [candidate] (9.016 s) : 0, 9016484
section iast_TELEMETRY_OFF
Agent [baseline] (1.17 s) : 0, 1170498
Total [baseline] (8.966 s) : 0, 8965516
Agent [candidate] (1.17 s) : 0, 1169708
Total [candidate] (8.962 s) : 0, 8961667
gantt
title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~9096cda658, baseline=1.39.0-SNAPSHOT~01d9133076
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (666.935 ms) : 0, 666935
BytebuddyAgent [candidate] (666.579 ms) : 0, 666579
GlobalTracer [baseline] (306.313 ms) : 0, 306313
GlobalTracer [candidate] (306.466 ms) : 0, 306466
AppSec [baseline] (51.222 ms) : 0, 51222
AppSec [candidate] (51.326 ms) : 0, 51326
Remote Config [baseline] (663.249 µs) : 0, 663
Remote Config [candidate] (666.128 µs) : 0, 666
Telemetry [baseline] (7.477 ms) : 0, 7477
Telemetry [candidate] (7.475 ms) : 0, 7475
section iast
BytebuddyAgent [baseline] (780.032 ms) : 0, 780032
BytebuddyAgent [candidate] (776.235 ms) : 0, 776235
GlobalTracer [baseline] (296.948 ms) : 0, 296948
GlobalTracer [candidate] (296.063 ms) : 0, 296063
AppSec [baseline] (51.838 ms) : 0, 51838
AppSec [candidate] (50.258 ms) : 0, 50258
IAST [baseline] (25.107 ms) : 0, 25107
IAST [candidate] (23.655 ms) : 0, 23655
Remote Config [baseline] (600.445 µs) : 0, 600
Remote Config [candidate] (613.571 µs) : 0, 614
Telemetry [baseline] (7.231 ms) : 0, 7231
Telemetry [candidate] (8.834 ms) : 0, 8834
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (778.197 ms) : 0, 778197
BytebuddyAgent [candidate] (778.398 ms) : 0, 778398
GlobalTracer [baseline] (296.767 ms) : 0, 296767
GlobalTracer [candidate] (297.775 ms) : 0, 297775
AppSec [baseline] (48.637 ms) : 0, 48637
AppSec [candidate] (50.927 ms) : 0, 50927
IAST [baseline] (27.193 ms) : 0, 27193
IAST [candidate] (23.496 ms) : 0, 23496
Remote Config [baseline] (579.517 µs) : 0, 580
Remote Config [candidate] (601.216 µs) : 0, 601
Telemetry [baseline] (7.911 ms) : 0, 7911
Telemetry [candidate] (9.504 ms) : 0, 9504
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (776.212 ms) : 0, 776212
BytebuddyAgent [candidate] (775.671 ms) : 0, 775671
GlobalTracer [baseline] (296.284 ms) : 0, 296284
GlobalTracer [candidate] (296.595 ms) : 0, 296595
AppSec [baseline] (50.676 ms) : 0, 50676
AppSec [candidate] (52.165 ms) : 0, 52165
IAST [baseline] (23.809 ms) : 0, 23809
IAST [candidate] (23.223 ms) : 0, 23223
Remote Config [baseline] (586.196 µs) : 0, 586
Remote Config [candidate] (591.43 µs) : 0, 591
Telemetry [baseline] (9.371 ms) : 0, 9371
Telemetry [candidate] (7.859 ms) : 0, 7859
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 20 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~9096cda658, baseline=1.39.0-SNAPSHOT~01d9133076
dateFormat X
axisFormat %s
section baseline
no_agent (365.911 µs) : 346, 386
. : milestone, 366,
iast (472.913 µs) : 451, 495
. : milestone, 473,
iast_FULL (544.854 µs) : 524, 566
. : milestone, 545,
iast_GLOBAL (503.041 µs) : 481, 525
. : milestone, 503,
iast_HARDCODED_SECRET_DISABLED (479.767 µs) : 458, 502
. : milestone, 480,
iast_INACTIVE (444.172 µs) : 423, 465
. : milestone, 444,
iast_TELEMETRY_OFF (468.655 µs) : 446, 491
. : milestone, 469,
tracing (442.796 µs) : 421, 464
. : milestone, 443,
section candidate
no_agent (361.801 µs) : 341, 382
. : milestone, 362,
iast (484.197 µs) : 462, 507
. : milestone, 484,
iast_FULL (549.476 µs) : 528, 571
. : milestone, 549,
iast_GLOBAL (498.479 µs) : 476, 521
. : milestone, 498,
iast_HARDCODED_SECRET_DISABLED (477.033 µs) : 455, 500
. : milestone, 477,
iast_INACTIVE (442.309 µs) : 421, 463
. : milestone, 442,
iast_TELEMETRY_OFF (468.44 µs) : 446, 491
. : milestone, 468,
tracing (435.549 µs) : 415, 456
. : milestone, 436,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~9096cda658, baseline=1.39.0-SNAPSHOT~01d9133076
dateFormat X
axisFormat %s
section baseline
no_agent (1.348 ms) : 1328, 1369
. : milestone, 1348,
appsec (1.725 ms) : 1702, 1748
. : milestone, 1725,
appsec_no_iast (1.707 ms) : 1683, 1732
. : milestone, 1707,
iast (1.455 ms) : 1433, 1478
. : milestone, 1455,
profiling (1.48 ms) : 1456, 1504
. : milestone, 1480,
tracing (1.448 ms) : 1423, 1472
. : milestone, 1448,
section candidate
no_agent (1.344 ms) : 1325, 1363
. : milestone, 1344,
appsec (1.707 ms) : 1685, 1730
. : milestone, 1707,
appsec_no_iast (1.711 ms) : 1686, 1736
. : milestone, 1711,
iast (1.488 ms) : 1465, 1510
. : milestone, 1488,
profiling (1.477 ms) : 1454, 1500
. : milestone, 1477,
tracing (1.453 ms) : 1428, 1477
. : milestone, 1453,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~9096cda658, baseline=1.39.0-SNAPSHOT~01d9133076
dateFormat X
axisFormat %s
section baseline
no_agent (15.374 s) : 15374000, 15374000
. : milestone, 15374000,
appsec (15.184 s) : 15184000, 15184000
. : milestone, 15184000,
iast (18.483 s) : 18483000, 18483000
. : milestone, 18483000,
iast_GLOBAL (17.824 s) : 17824000, 17824000
. : milestone, 17824000,
profiling (15.029 s) : 15029000, 15029000
. : milestone, 15029000,
tracing (15.329 s) : 15329000, 15329000
. : milestone, 15329000,
section candidate
no_agent (14.949 s) : 14949000, 14949000
. : milestone, 14949000,
appsec (15.19 s) : 15190000, 15190000
. : milestone, 15190000,
iast (18.942 s) : 18942000, 18942000
. : milestone, 18942000,
iast_GLOBAL (18.235 s) : 18235000, 18235000
. : milestone, 18235000,
profiling (15.437 s) : 15437000, 15437000
. : milestone, 15437000,
tracing (14.915 s) : 14915000, 14915000
. : milestone, 14915000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~9096cda658, baseline=1.39.0-SNAPSHOT~01d9133076
dateFormat X
axisFormat %s
section baseline
no_agent (1.467 ms) : 1456, 1479
. : milestone, 1467,
appsec (2.234 ms) : 2199, 2269
. : milestone, 2234,
iast (1.991 ms) : 1948, 2034
. : milestone, 1991,
iast_GLOBAL (2.032 ms) : 1989, 2075
. : milestone, 2032,
profiling (1.872 ms) : 1838, 1907
. : milestone, 1872,
tracing (1.84 ms) : 1807, 1873
. : milestone, 1840,
section candidate
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (2.238 ms) : 2203, 2274
. : milestone, 2238,
iast (1.972 ms) : 1930, 2015
. : milestone, 1972,
iast_GLOBAL (2.039 ms) : 1995, 2083
. : milestone, 2039,
profiling (1.875 ms) : 1840, 1910
. : milestone, 1875,
tracing (1.847 ms) : 1815, 1880
. : milestone, 1847,
|
amarziali
approved these changes
Aug 28, 2024
smola
approved these changes
Aug 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Splits Gradle instrumentations module into two: one for Gradle 8.3+ instrumentations, the other for older Gradle 3.0+ instrumentations.
Motivation
Organising the code.
Allowing Muzzle to generate
Instrumentation$Muzzleclasses for newer Gradle instrumentation module.Previously all the code for Gradle instrumentations was located in
groovysource root.Muzzle classes are not generated for this source root.
Creating a
javasource root and moving the Java classes there does not help, as the build fails when an instrumentation module has multiple source roots.Additional Details
Instrumentation$Muzzleclasses are generated at build time and are included in the tracer JAR.They are then used at runtime to determine whether an instrumentation can be applied.
If such class is missing, and error is logged.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: SDTEST-763