Enable WAF generate_stack action by default by smola · Pull Request #7518 · DataDog/dd-trace-java

smola · 2024-08-27T12:56:16Z

What Does This Do

Enable generate_stack WAF action by default. These will only be emitted by RASP (aka Exploit Prevention) at the moment.

To support smoke tests, also added support to decode meta_struct in SpanV04.

Motivation

There is little reason for anyone to disable this, except the need to troubleshoot or workaround a bug.

This PR is part of enabling RASP for AppSec users.

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Squash your commits prior merging or merge using GitHub's Squash and merge
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
~~[ ] Update the public documentation in case of new configuration flag or behavior~~

Jira ticket: APPSEC-53837 (partially)

pr-commenter · 2024-08-27T13:35:25Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	smola/enable-rasp-stacktrace
git_commit_date	1724849893	1724851370
git_commit_sha	`e0a335c`	`3b32ad1`
release_version	1.39.0-SNAPSHOT~e0a335cbd2	1.39.0-SNAPSHOT~3b32ad1f06

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1724853622	1724853622
ci_job_id	619944970	619944970
ci_pipeline_id	43029880	43029880
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~3b32ad1f06, baseline=1.39.0-SNAPSHOT~e0a335cbd2

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1049790
Total [baseline] (8.508 s) : 0, 8507600
Agent [candidate] (1.057 s) : 0, 1057260
Total [candidate] (8.512 s) : 0, 8511618
section iast
Agent [baseline] (1.182 s) : 0, 1181636
Total [baseline] (9.03 s) : 0, 9029995
Agent [candidate] (1.181 s) : 0, 1181493
Total [candidate] (9.061 s) : 0, 9060990
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.174 s) : 0, 1174195
Total [baseline] (8.951 s) : 0, 8951061
Agent [candidate] (1.172 s) : 0, 1172443
Total [candidate] (8.968 s) : 0, 8968099
section iast_TELEMETRY_OFF
Agent [baseline] (1.17 s) : 0, 1170352
Total [baseline] (8.964 s) : 0, 8963777
Agent [candidate] (1.178 s) : 0, 1177998
Total [candidate] (8.974 s) : 0, 8973865

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.05 s	-
Agent	iast	1.182 s	131.846 ms (12.6%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.174 s	124.405 ms (11.9%)
Agent	iast_TELEMETRY_OFF	1.17 s	120.562 ms (11.5%)
Total	tracing	8.508 s	-
Total	iast	9.03 s	522.396 ms (6.1%)
Total	iast_HARDCODED_SECRET_DISABLED	8.951 s	443.461 ms (5.2%)
Total	iast_TELEMETRY_OFF	8.964 s	456.177 ms (5.4%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.057 s	-
Agent	iast	1.181 s	124.234 ms (11.8%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.172 s	115.184 ms (10.9%)
Agent	iast_TELEMETRY_OFF	1.178 s	120.738 ms (11.4%)
Total	tracing	8.512 s	-
Total	iast	9.061 s	549.372 ms (6.5%)
Total	iast_HARDCODED_SECRET_DISABLED	8.968 s	456.482 ms (5.4%)
Total	iast_TELEMETRY_OFF	8.974 s	462.247 ms (5.4%)

gantt
    title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~3b32ad1f06, baseline=1.39.0-SNAPSHOT~e0a335cbd2

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (669.798 ms) : 0, 669798
BytebuddyAgent [candidate] (674.98 ms) : 0, 674980
GlobalTracer [baseline] (307.01 ms) : 0, 307010
GlobalTracer [candidate] (308.701 ms) : 0, 308701
AppSec [baseline] (51.284 ms) : 0, 51284
AppSec [candidate] (51.686 ms) : 0, 51686
Remote Config [baseline] (666.081 µs) : 0, 666
Remote Config [candidate] (665.694 µs) : 0, 666
Telemetry [baseline] (7.471 ms) : 0, 7471
Telemetry [candidate] (7.511 ms) : 0, 7511
section iast
BytebuddyAgent [baseline] (784.454 ms) : 0, 784454
BytebuddyAgent [candidate] (785.144 ms) : 0, 785144
GlobalTracer [baseline] (298.28 ms) : 0, 298280
GlobalTracer [candidate] (298.657 ms) : 0, 298657
AppSec [baseline] (50.614 ms) : 0, 50614
AppSec [candidate] (51.522 ms) : 0, 51522
IAST [baseline] (25.217 ms) : 0, 25217
IAST [candidate] (24.41 ms) : 0, 24410
Remote Config [baseline] (593.52 µs) : 0, 594
Remote Config [candidate] (614.021 µs) : 0, 614
Telemetry [baseline] (8.796 ms) : 0, 8796
Telemetry [candidate] (7.419 ms) : 0, 7419
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (780.068 ms) : 0, 780068
BytebuddyAgent [candidate] (779.508 ms) : 0, 779508
GlobalTracer [baseline] (296.864 ms) : 0, 296864
GlobalTracer [candidate] (296.565 ms) : 0, 296565
AppSec [baseline] (50.758 ms) : 0, 50758
AppSec [candidate] (48.421 ms) : 0, 48421
IAST [baseline] (22.714 ms) : 0, 22714
IAST [candidate] (25.744 ms) : 0, 25744
Remote Config [baseline] (611.905 µs) : 0, 612
Remote Config [candidate] (593.918 µs) : 0, 594
Telemetry [baseline] (9.56 ms) : 0, 9560
Telemetry [candidate] (7.973 ms) : 0, 7973
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (776.43 ms) : 0, 776430
BytebuddyAgent [candidate] (781.411 ms) : 0, 781411
GlobalTracer [baseline] (296.369 ms) : 0, 296369
GlobalTracer [candidate] (298.496 ms) : 0, 298496
AppSec [baseline] (51.519 ms) : 0, 51519
AppSec [candidate] (51.56 ms) : 0, 51560
IAST [baseline] (22.396 ms) : 0, 22396
IAST [candidate] (22.832 ms) : 0, 22832
Remote Config [baseline] (600.945 µs) : 0, 601
Remote Config [candidate] (590.983 µs) : 0, 591
Telemetry [baseline] (9.435 ms) : 0, 9435
Telemetry [candidate] (9.413 ms) : 0, 9413

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~3b32ad1f06, baseline=1.39.0-SNAPSHOT~e0a335cbd2

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.057 s) : 0, 1056555
Total [baseline] (10.433 s) : 0, 10432662
Agent [candidate] (1.059 s) : 0, 1059181
Total [candidate] (10.446 s) : 0, 10445525
section appsec
Agent [baseline] (1.171 s) : 0, 1171064
Total [baseline] (10.497 s) : 0, 10497090
Agent [candidate] (1.174 s) : 0, 1173716
Total [candidate] (10.481 s) : 0, 10481105
section iast
Agent [baseline] (1.183 s) : 0, 1182761
Total [baseline] (10.882 s) : 0, 10881690
Agent [candidate] (1.173 s) : 0, 1172756
Total [candidate] (10.817 s) : 0, 10817368
section profiling
Agent [baseline] (1.265 s) : 0, 1264832
Total [baseline] (10.657 s) : 0, 10656535
Agent [candidate] (1.249 s) : 0, 1248974
Total [candidate] (10.599 s) : 0, 10598717

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.057 s	-
Agent	appsec	1.171 s	114.51 ms (10.8%)
Agent	iast	1.183 s	126.206 ms (11.9%)
Agent	profiling	1.265 s	208.278 ms (19.7%)
Total	tracing	10.433 s	-
Total	appsec	10.497 s	64.428 ms (0.6%)
Total	iast	10.882 s	449.027 ms (4.3%)
Total	profiling	10.657 s	223.873 ms (2.1%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.059 s	-
Agent	appsec	1.174 s	114.535 ms (10.8%)
Agent	iast	1.173 s	113.575 ms (10.7%)
Agent	profiling	1.249 s	189.793 ms (17.9%)
Total	tracing	10.446 s	-
Total	appsec	10.481 s	35.58 ms (0.3%)
Total	iast	10.817 s	371.843 ms (3.6%)
Total	profiling	10.599 s	153.192 ms (1.5%)

gantt
    title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~3b32ad1f06, baseline=1.39.0-SNAPSHOT~e0a335cbd2

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (674.457 ms) : 0, 674457
BytebuddyAgent [candidate] (675.908 ms) : 0, 675908
GlobalTracer [baseline] (308.661 ms) : 0, 308661
GlobalTracer [candidate] (309.517 ms) : 0, 309517
AppSec [baseline] (51.545 ms) : 0, 51545
AppSec [candidate] (51.798 ms) : 0, 51798
Remote Config [baseline] (672.192 µs) : 0, 672
Remote Config [candidate] (671.672 µs) : 0, 672
Telemetry [baseline] (7.545 ms) : 0, 7545
Telemetry [candidate] (7.545 ms) : 0, 7545
section appsec
BytebuddyAgent [baseline] (679.197 ms) : 0, 679197
BytebuddyAgent [candidate] (680.348 ms) : 0, 680348
GlobalTracer [baseline] (300.984 ms) : 0, 300984
GlobalTracer [candidate] (301.438 ms) : 0, 301438
AppSec [baseline] (158.918 ms) : 0, 158918
AppSec [candidate] (161.279 ms) : 0, 161279
Remote Config [baseline] (617.074 µs) : 0, 617
Remote Config [candidate] (622.005 µs) : 0, 622
Telemetry [baseline] (8.468 ms) : 0, 8468
Telemetry [candidate] (7.137 ms) : 0, 7137
IAST [baseline] (18.626 ms) : 0, 18626
IAST [candidate] (18.457 ms) : 0, 18457
section iast
BytebuddyAgent [baseline] (785.653 ms) : 0, 785653
BytebuddyAgent [candidate] (778.153 ms) : 0, 778153
GlobalTracer [baseline] (298.262 ms) : 0, 298262
GlobalTracer [candidate] (296.241 ms) : 0, 296241
AppSec [baseline] (52.428 ms) : 0, 52428
AppSec [candidate] (50.572 ms) : 0, 50572
Remote Config [baseline] (613.532 µs) : 0, 614
Remote Config [candidate] (592.18 µs) : 0, 592
Telemetry [baseline] (8.119 ms) : 0, 8119
Telemetry [candidate] (8.625 ms) : 0, 8625
IAST [baseline] (23.981 ms) : 0, 23981
IAST [candidate] (24.927 ms) : 0, 24927
section profiling
BytebuddyAgent [baseline] (674.308 ms) : 0, 674308
BytebuddyAgent [candidate] (665.384 ms) : 0, 665384
GlobalTracer [baseline] (394.524 ms) : 0, 394524
GlobalTracer [candidate] (389.993 ms) : 0, 389993
AppSec [baseline] (52.91 ms) : 0, 52910
AppSec [candidate] (52.252 ms) : 0, 52252
Remote Config [baseline] (723.043 µs) : 0, 723
Remote Config [candidate] (684.66 µs) : 0, 685
Telemetry [baseline] (7.489 ms) : 0, 7489
Telemetry [candidate] (7.36 ms) : 0, 7360
ProfilingAgent [baseline] (96.978 ms) : 0, 96978
ProfilingAgent [candidate] (95.843 ms) : 0, 95843
Profiling [baseline] (97.001 ms) : 0, 97001
Profiling [candidate] (95.867 ms) : 0, 95867

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-08-28T13:33:03	2024-08-28T13:39:54
git_branch	master	smola/enable-rasp-stacktrace
git_commit_date	1724849893	1724851370
git_commit_sha	`e0a335c`	`3b32ad1`
release_version	1.39.0-SNAPSHOT~e0a335cbd2	1.39.0-SNAPSHOT~3b32ad1f06
start_time	2024-08-28T13:32:50	2024-08-28T13:39:41

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1724852741	1724852741
ci_job_id	619944972	619944972
ci_pipeline_id	43029880	43029880
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~3b32ad1f06, baseline=1.39.0-SNAPSHOT~e0a335cbd2
    dateFormat X
    axisFormat %s
section baseline
no_agent (373.806 µs) : 353, 394
.   : milestone, 374,
iast (492.544 µs) : 470, 515
.   : milestone, 493,
iast_FULL (552.241 µs) : 531, 573
.   : milestone, 552,
iast_GLOBAL (508.984 µs) : 488, 530
.   : milestone, 509,
iast_HARDCODED_SECRET_DISABLED (488.551 µs) : 466, 511
.   : milestone, 489,
iast_INACTIVE (460.004 µs) : 439, 481
.   : milestone, 460,
iast_TELEMETRY_OFF (484.022 µs) : 461, 507
.   : milestone, 484,
tracing (454.633 µs) : 434, 475
.   : milestone, 455,
section candidate
no_agent (374.404 µs) : 354, 394
.   : milestone, 374,
iast (493.049 µs) : 470, 516
.   : milestone, 493,
iast_FULL (563.473 µs) : 542, 585
.   : milestone, 563,
iast_GLOBAL (516.929 µs) : 495, 539
.   : milestone, 517,
iast_HARDCODED_SECRET_DISABLED (491.815 µs) : 470, 514
.   : milestone, 492,
iast_INACTIVE (458.596 µs) : 437, 480
.   : milestone, 459,
iast_TELEMETRY_OFF (488.255 µs) : 466, 511
.   : milestone, 488,
tracing (452.776 µs) : 432, 473
.   : milestone, 453,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	373.806 µs [353.19 µs, 394.422 µs]	-
iast	492.544 µs [469.988 µs, 515.101 µs]	118.738 µs (31.8%)
iast_FULL	552.241 µs [531.242 µs, 573.24 µs]	178.435 µs (47.7%)
iast_GLOBAL	508.984 µs [487.952 µs, 530.016 µs]	135.178 µs (36.2%)
iast_HARDCODED_SECRET_DISABLED	488.551 µs [466.432 µs, 510.669 µs]	114.745 µs (30.7%)
iast_INACTIVE	460.004 µs [438.611 µs, 481.396 µs]	86.198 µs (23.1%)
iast_TELEMETRY_OFF	484.022 µs [461.319 µs, 506.725 µs]	110.216 µs (29.5%)
tracing	454.633 µs [433.907 µs, 475.358 µs]	80.827 µs (21.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	374.404 µs [354.478 µs, 394.33 µs]	-
iast	493.049 µs [470.499 µs, 515.599 µs]	118.645 µs (31.7%)
iast_FULL	563.473 µs [542.153 µs, 584.793 µs]	189.069 µs (50.5%)
iast_GLOBAL	516.929 µs [494.756 µs, 539.102 µs]	142.525 µs (38.1%)
iast_HARDCODED_SECRET_DISABLED	491.815 µs [469.661 µs, 513.969 µs]	117.411 µs (31.4%)
iast_INACTIVE	458.596 µs [437.268 µs, 479.925 µs]	84.192 µs (22.5%)
iast_TELEMETRY_OFF	488.255 µs [465.608 µs, 510.902 µs]	113.851 µs (30.4%)
tracing	452.776 µs [432.363 µs, 473.188 µs]	78.372 µs (20.9%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~3b32ad1f06, baseline=1.39.0-SNAPSHOT~e0a335cbd2
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.353 ms) : 1334, 1373
.   : milestone, 1353,
appsec (1.737 ms) : 1713, 1761
.   : milestone, 1737,
appsec_no_iast (1.731 ms) : 1707, 1756
.   : milestone, 1731,
iast (1.476 ms) : 1454, 1499
.   : milestone, 1476,
profiling (1.486 ms) : 1463, 1509
.   : milestone, 1486,
tracing (1.464 ms) : 1439, 1489
.   : milestone, 1464,
section candidate
no_agent (1.369 ms) : 1349, 1389
.   : milestone, 1369,
appsec (1.736 ms) : 1712, 1759
.   : milestone, 1736,
appsec_no_iast (1.748 ms) : 1724, 1772
.   : milestone, 1748,
iast (1.496 ms) : 1473, 1518
.   : milestone, 1496,
profiling (1.491 ms) : 1468, 1513
.   : milestone, 1491,
tracing (1.468 ms) : 1444, 1492
.   : milestone, 1468,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.353 ms [1.334 ms, 1.373 ms]	-
appsec	1.737 ms [1.713 ms, 1.761 ms]	383.293 µs (28.3%)
appsec_no_iast	1.731 ms [1.707 ms, 1.756 ms]	377.967 µs (27.9%)
iast	1.476 ms [1.454 ms, 1.499 ms]	122.718 µs (9.1%)
profiling	1.486 ms [1.463 ms, 1.509 ms]	132.164 µs (9.8%)
tracing	1.464 ms [1.439 ms, 1.489 ms]	110.332 µs (8.2%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.369 ms [1.349 ms, 1.389 ms]	-
appsec	1.736 ms [1.712 ms, 1.759 ms]	366.889 µs (26.8%)
appsec_no_iast	1.748 ms [1.724 ms, 1.772 ms]	379.376 µs (27.7%)
iast	1.496 ms [1.473 ms, 1.518 ms]	126.959 µs (9.3%)
profiling	1.491 ms [1.468 ms, 1.513 ms]	121.87 µs (8.9%)
tracing	1.468 ms [1.444 ms, 1.492 ms]	99.42 µs (7.3%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	smola/enable-rasp-stacktrace
git_commit_date	1724849893	1724851370
git_commit_sha	`e0a335c`	`3b32ad1`
release_version	1.39.0-SNAPSHOT~e0a335cbd2	1.39.0-SNAPSHOT~3b32ad1f06

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1724853263	1724853263
ci_job_id	619944974	619944974
ci_pipeline_id	43029880	43029880
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~3b32ad1f06, baseline=1.39.0-SNAPSHOT~e0a335cbd2
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.463 ms) : 1452, 1475
.   : milestone, 1463,
appsec (2.229 ms) : 2195, 2264
.   : milestone, 2229,
iast (1.973 ms) : 1931, 2016
.   : milestone, 1973,
iast_GLOBAL (2.031 ms) : 1987, 2074
.   : milestone, 2031,
profiling (2.317 ms) : 2135, 2499
.   : milestone, 2317,
tracing (1.842 ms) : 1809, 1875
.   : milestone, 1842,
section candidate
no_agent (1.464 ms) : 1453, 1476
.   : milestone, 1464,
appsec (2.238 ms) : 2202, 2273
.   : milestone, 2238,
iast (1.987 ms) : 1943, 2031
.   : milestone, 1987,
iast_GLOBAL (2.024 ms) : 1981, 2068
.   : milestone, 2024,
profiling (1.867 ms) : 1832, 1902
.   : milestone, 1867,
tracing (1.842 ms) : 1809, 1875
.   : milestone, 1842,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.463 ms [1.452 ms, 1.475 ms]	-
appsec	2.229 ms [2.195 ms, 2.264 ms]	765.906 µs (52.3%)
iast	1.973 ms [1.931 ms, 2.016 ms]	510.083 µs (34.9%)
iast_GLOBAL	2.031 ms [1.987 ms, 2.074 ms]	567.262 µs (38.8%)
profiling	2.317 ms [2.135 ms, 2.499 ms]	854.215 µs (58.4%)
tracing	1.842 ms [1.809 ms, 1.875 ms]	378.609 µs (25.9%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.464 ms [1.453 ms, 1.476 ms]	-
appsec	2.238 ms [2.202 ms, 2.273 ms]	773.204 µs (52.8%)
iast	1.987 ms [1.943 ms, 2.031 ms]	522.478 µs (35.7%)
iast_GLOBAL	2.024 ms [1.981 ms, 2.068 ms]	560.013 µs (38.2%)
profiling	1.867 ms [1.832 ms, 1.902 ms]	402.788 µs (27.5%)
tracing	1.842 ms [1.809 ms, 1.875 ms]	377.442 µs (25.8%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~3b32ad1f06, baseline=1.39.0-SNAPSHOT~e0a335cbd2
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.466 s) : 15466000, 15466000
.   : milestone, 15466000,
appsec (15.011 s) : 15011000, 15011000
.   : milestone, 15011000,
iast (19.005 s) : 19005000, 19005000
.   : milestone, 19005000,
iast_GLOBAL (17.91 s) : 17910000, 17910000
.   : milestone, 17910000,
profiling (15.784 s) : 15784000, 15784000
.   : milestone, 15784000,
tracing (14.962 s) : 14962000, 14962000
.   : milestone, 14962000,
section candidate
no_agent (15.359 s) : 15359000, 15359000
.   : milestone, 15359000,
appsec (15.414 s) : 15414000, 15414000
.   : milestone, 15414000,
iast (18.78 s) : 18780000, 18780000
.   : milestone, 18780000,
iast_GLOBAL (17.665 s) : 17665000, 17665000
.   : milestone, 17665000,
profiling (15.704 s) : 15704000, 15704000
.   : milestone, 15704000,
tracing (14.975 s) : 14975000, 14975000
.   : milestone, 14975000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.466 s [15.466 s, 15.466 s]	-
appsec	15.011 s [15.011 s, 15.011 s]	-455.0 ms (-2.9%)
iast	19.005 s [19.005 s, 19.005 s]	3.539 s (22.9%)
iast_GLOBAL	17.91 s [17.91 s, 17.91 s]	2.444 s (15.8%)
profiling	15.784 s [15.784 s, 15.784 s]	318.0 ms (2.1%)
tracing	14.962 s [14.962 s, 14.962 s]	-504.0 ms (-3.3%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.359 s [15.359 s, 15.359 s]	-
appsec	15.414 s [15.414 s, 15.414 s]	55.0 ms (0.4%)
iast	18.78 s [18.78 s, 18.78 s]	3.421 s (22.3%)
iast_GLOBAL	17.665 s [17.665 s, 17.665 s]	2.306 s (15.0%)
profiling	15.704 s [15.704 s, 15.704 s]	345.0 ms (2.2%)
tracing	14.975 s [14.975 s, 14.975 s]	-384.0 ms (-2.5%)

manuel-alvarez-alvarez · 2024-08-28T14:34:54Z

    try {
      int size = unpacker.unpackMapHeader();
-      if (size != 12) {
+      if (size != 12 && size != 13) {


My bad, I should have added support here when I did the meta struct part, sorry!

No problem. I noticed only now when we got smoke tests actually generating this.

smola added the comp: asm waf Application Security Management (WAF) label Aug 27, 2024

smola force-pushed the smola/enable-rasp-stacktrace branch 3 times, most recently from 8be4a80 to 04dd0a6 Compare August 28, 2024 12:50

Enable WAF generate_stack action by default

3b32ad1

smola force-pushed the smola/enable-rasp-stacktrace branch from 04dd0a6 to 3b32ad1 Compare August 28, 2024 13:22

smola marked this pull request as ready for review August 28, 2024 13:27

smola requested review from a team as code owners August 28, 2024 13:27

smola requested review from jandro996 and manuel-alvarez-alvarez August 28, 2024 13:27

manuel-alvarez-alvarez reviewed Aug 28, 2024

View reviewed changes

manuel-alvarez-alvarez approved these changes Aug 28, 2024

View reviewed changes

smola enabled auto-merge (squash) August 28, 2024 14:36

smola merged commit 1283079 into master Aug 28, 2024

smola deleted the smola/enable-rasp-stacktrace branch August 28, 2024 14:58

github-actions Bot added this to the 1.39.0 milestone Aug 28, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable WAF generate_stack action by default#7518

Enable WAF generate_stack action by default#7518
smola merged 1 commit intomasterfrom
smola/enable-rasp-stacktrace

smola commented Aug 27, 2024 •

edited

Loading

Uh oh!

pr-commenter Bot commented Aug 27, 2024 •

edited

Loading

Uh oh!

manuel-alvarez-alvarez Aug 28, 2024

Uh oh!

smola Aug 28, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

smola commented Aug 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

pr-commenter Bot commented Aug 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

manuel-alvarez-alvarez Aug 28, 2024

Choose a reason for hiding this comment

Uh oh!

smola Aug 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

smola commented Aug 27, 2024 •

edited

Loading

pr-commenter Bot commented Aug 27, 2024 •

edited

Loading

smola Aug 28, 2024 •

edited

Loading