Skip to content

Make the warning in ScriptInitializer less scary#7514

Merged
jbachorik merged 1 commit intomasterfrom
jb/crash_tracker_warning_log
Aug 27, 2024
Merged

Make the warning in ScriptInitializer less scary#7514
jbachorik merged 1 commit intomasterfrom
jb/crash_tracker_warning_log

Conversation

@jbachorik
Copy link
Copy Markdown
Contributor

@jbachorik jbachorik commented Aug 27, 2024 •
edited by atlassian Bot
Loading

What Does This Do

Stop printing the caught exception stacktrace unless logging at debug level.

Motivation

Customers are scared and mislead by the exception stack tracer, mistaking it for application going down because of the exception.

Additional Notes

Most of the work was already done in #7427 - this PR is just changing not to log full stacktrace for completely unexpected exceptions.

Contributor Checklist

Jira ticket: PROF-10405

@jbachorik jbachorik requested a review from a team as a code owner August 27, 2024 09:03
@jbachorik jbachorik force-pushed the jb/crash_tracker_warning_log branch from e4ac7a0 to 6de92f1 Compare August 27, 2024 09:13
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Aug 27, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jb/crash_tracker_warning_log
git_commit_date 1724748799 1724749989
git_commit_sha bb9b598 6de92f1
release_version 1.39.0-SNAPSHOT~bb9b598987 1.39.0-SNAPSHOT~6de92f18ed
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1724752250 1724752250
ci_job_id 618102318 618102318
ci_pipeline_id 42903117 42903117
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 15 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~6de92f18ed, baseline=1.39.0-SNAPSHOT~bb9b598987

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1049532
Total [baseline] (10.431 s) : 0, 10431409
Agent [candidate] (1.053 s) : 0, 1052942
Total [candidate] (10.497 s) : 0, 10497494
section appsec
Agent [baseline] (1.176 s) : 0, 1175612
Total [baseline] (10.498 s) : 0, 10498069
Agent [candidate] (1.181 s) : 0, 1181089
Total [candidate] (10.494 s) : 0, 10493801
section iast
Agent [baseline] (1.177 s) : 0, 1177083
Total [baseline] (10.83 s) : 0, 10829828
Agent [candidate] (1.192 s) : 0, 1191709
Total [candidate] (10.906 s) : 0, 10905674
section profiling
Agent [baseline] (1.245 s) : 0, 1245479
Total [baseline] (10.607 s) : 0, 10606960
Agent [candidate] (1.257 s) : 0, 1256733
Total [candidate] (10.625 s) : 0, 10625144
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.05 s -
Agent appsec 1.176 s 126.08 ms (12.0%)
Agent iast 1.177 s 127.551 ms (12.2%)
Agent profiling 1.245 s 195.947 ms (18.7%)
Total tracing 10.431 s -
Total appsec 10.498 s 66.66 ms (0.6%)
Total iast 10.83 s 398.419 ms (3.8%)
Total profiling 10.607 s 175.551 ms (1.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.053 s -
Agent appsec 1.181 s 128.147 ms (12.2%)
Agent iast 1.192 s 138.768 ms (13.2%)
Agent profiling 1.257 s 203.792 ms (19.4%)
Total tracing 10.497 s -
Total appsec 10.494 s -3.693 ms (-0.0%)
Total iast 10.906 s 408.181 ms (3.9%)
Total profiling 10.625 s 127.651 ms (1.2%) 
gantt
    title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~6de92f18ed, baseline=1.39.0-SNAPSHOT~bb9b598987

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (669.59 ms) : 0, 669590
BytebuddyAgent [candidate] (670.372 ms) : 0, 670372
GlobalTracer [baseline] (306.981 ms) : 0, 306981
GlobalTracer [candidate] (308.761 ms) : 0, 308761
AppSec [baseline] (51.323 ms) : 0, 51323
AppSec [candidate] (51.998 ms) : 0, 51998
Remote Config [baseline] (671.205 µs) : 0, 671
Remote Config [candidate] (684.047 µs) : 0, 684
Telemetry [baseline] (7.451 ms) : 0, 7451
Telemetry [candidate] (7.573 ms) : 0, 7573
section appsec
BytebuddyAgent [baseline] (681.754 ms) : 0, 681754
BytebuddyAgent [candidate] (686.565 ms) : 0, 686565
GlobalTracer [baseline] (301.611 ms) : 0, 301611
GlobalTracer [candidate] (302.142 ms) : 0, 302142
AppSec [baseline] (160.624 ms) : 0, 160624
AppSec [candidate] (161.215 ms) : 0, 161215
Remote Config [baseline] (637.904 µs) : 0, 638
Remote Config [candidate] (643.984 µs) : 0, 644
Telemetry [baseline] (8.106 ms) : 0, 8106
Telemetry [candidate] (7.483 ms) : 0, 7483
IAST [baseline] (18.54 ms) : 0, 18540
IAST [candidate] (18.698 ms) : 0, 18698
section iast
BytebuddyAgent [baseline] (780.29 ms) : 0, 780290
BytebuddyAgent [candidate] (791.789 ms) : 0, 791789
GlobalTracer [baseline] (298.496 ms) : 0, 298496
GlobalTracer [candidate] (300.521 ms) : 0, 300521
AppSec [baseline] (51.721 ms) : 0, 51721
AppSec [candidate] (51.669 ms) : 0, 51669
Remote Config [baseline] (606.365 µs) : 0, 606
Remote Config [candidate] (607.505 µs) : 0, 608
Telemetry [baseline] (9.548 ms) : 0, 9548
Telemetry [candidate] (10.436 ms) : 0, 10436
IAST [baseline] (22.857 ms) : 0, 22857
IAST [candidate] (22.938 ms) : 0, 22938
section profiling
ProfilingAgent [baseline] (95.99 ms) : 0, 95990
ProfilingAgent [candidate] (97.268 ms) : 0, 97268
BytebuddyAgent [baseline] (663.288 ms) : 0, 663288
BytebuddyAgent [candidate] (669.121 ms) : 0, 669121
GlobalTracer [baseline] (388.88 ms) : 0, 388880
GlobalTracer [candidate] (391.774 ms) : 0, 391774
AppSec [baseline] (52.062 ms) : 0, 52062
AppSec [candidate] (52.802 ms) : 0, 52802
Remote Config [baseline] (684.187 µs) : 0, 684
Remote Config [candidate] (699.956 µs) : 0, 700
Telemetry [baseline] (7.307 ms) : 0, 7307
Telemetry [candidate] (7.464 ms) : 0, 7464
Profiling [baseline] (96.013 ms) : 0, 96013
Profiling [candidate] (97.293 ms) : 0, 97293
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~6de92f18ed, baseline=1.39.0-SNAPSHOT~bb9b598987

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.048 s) : 0, 1047676
Total [baseline] (8.507 s) : 0, 8506948
Agent [candidate] (1.049 s) : 0, 1048536
Total [candidate] (8.501 s) : 0, 8500557
section iast
Agent [baseline] (1.181 s) : 0, 1181271
Total [baseline] (9.001 s) : 0, 9000622
Agent [candidate] (1.172 s) : 0, 1172314
Total [candidate] (8.96 s) : 0, 8959775
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.171 s) : 0, 1170755
Total [baseline] (8.97 s) : 0, 8970046
Agent [candidate] (1.182 s) : 0, 1181973
Total [candidate] (8.97 s) : 0, 8969692
section iast_TELEMETRY_OFF
Agent [baseline] (1.18 s) : 0, 1179648
Total [baseline] (8.98 s) : 0, 8979715
Agent [candidate] (1.169 s) : 0, 1169078
Total [candidate] (8.971 s) : 0, 8971142
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.048 s -
Agent iast 1.181 s 133.595 ms (12.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.171 s 123.079 ms (11.7%)
Agent iast_TELEMETRY_OFF 1.18 s 131.972 ms (12.6%)
Total tracing 8.507 s -
Total iast 9.001 s 493.674 ms (5.8%)
Total iast_HARDCODED_SECRET_DISABLED 8.97 s 463.098 ms (5.4%)
Total iast_TELEMETRY_OFF 8.98 s 472.768 ms (5.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.049 s -
Agent iast 1.172 s 123.778 ms (11.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.182 s 133.437 ms (12.7%)
Agent iast_TELEMETRY_OFF 1.169 s 120.541 ms (11.5%)
Total tracing 8.501 s -
Total iast 8.96 s 459.218 ms (5.4%)
Total iast_HARDCODED_SECRET_DISABLED 8.97 s 469.135 ms (5.5%)
Total iast_TELEMETRY_OFF 8.971 s 470.585 ms (5.5%) 
gantt
    title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~6de92f18ed, baseline=1.39.0-SNAPSHOT~bb9b598987

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (667.827 ms) : 0, 667827
BytebuddyAgent [candidate] (668.875 ms) : 0, 668875
GlobalTracer [baseline] (306.726 ms) : 0, 306726
GlobalTracer [candidate] (306.655 ms) : 0, 306655
AppSec [baseline] (51.466 ms) : 0, 51466
AppSec [candidate] (51.355 ms) : 0, 51355
Remote Config [baseline] (675.132 µs) : 0, 675
Remote Config [candidate] (664.311 µs) : 0, 664
Telemetry [baseline] (7.48 ms) : 0, 7480
Telemetry [candidate] (7.46 ms) : 0, 7460
section iast
BytebuddyAgent [baseline] (784.515 ms) : 0, 784515
BytebuddyAgent [candidate] (778.869 ms) : 0, 778869
GlobalTracer [baseline] (298.382 ms) : 0, 298382
GlobalTracer [candidate] (296.369 ms) : 0, 296369
AppSec [baseline] (51.499 ms) : 0, 51499
AppSec [candidate] (48.492 ms) : 0, 48492
Remote Config [baseline] (603.408 µs) : 0, 603
Remote Config [candidate] (615.053 µs) : 0, 615
Telemetry [baseline] (7.327 ms) : 0, 7327
Telemetry [candidate] (7.993 ms) : 0, 7993
IAST [baseline] (25.281 ms) : 0, 25281
IAST [candidate] (26.404 ms) : 0, 26404
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (776.806 ms) : 0, 776806
BytebuddyAgent [candidate] (784.975 ms) : 0, 784975
GlobalTracer [baseline] (295.914 ms) : 0, 295914
GlobalTracer [candidate] (298.988 ms) : 0, 298988
AppSec [baseline] (49.056 ms) : 0, 49056
AppSec [candidate] (49.319 ms) : 0, 49319
Remote Config [baseline] (615.196 µs) : 0, 615
Remote Config [candidate] (591.634 µs) : 0, 592
Telemetry [baseline] (10.437 ms) : 0, 10437
Telemetry [candidate] (9.517 ms) : 0, 9517
IAST [baseline] (24.404 ms) : 0, 24404
IAST [candidate] (24.911 ms) : 0, 24911
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (782.091 ms) : 0, 782091
BytebuddyAgent [candidate] (774.779 ms) : 0, 774779
GlobalTracer [baseline] (298.914 ms) : 0, 298914
GlobalTracer [candidate] (296.236 ms) : 0, 296236
AppSec [baseline] (51.46 ms) : 0, 51460
AppSec [candidate] (51.363 ms) : 0, 51363
Remote Config [baseline] (597.112 µs) : 0, 597
Remote Config [candidate] (589.217 µs) : 0, 589
Telemetry [baseline] (7.895 ms) : 0, 7895
Telemetry [candidate] (9.425 ms) : 0, 9425
IAST [baseline] (25.045 ms) : 0, 25045
IAST [candidate] (23.135 ms) : 0, 23135
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-08-27T09:21:33 2024-08-27T09:28:21
git_branch master jb/crash_tracker_warning_log
git_commit_date 1724748799 1724749989
git_commit_sha bb9b598 6de92f1
release_version 1.39.0-SNAPSHOT~bb9b598987 1.39.0-SNAPSHOT~6de92f18ed
start_time 2024-08-27T09:21:20 2024-08-27T09:28:08
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1724751243 1724751243
ci_job_id 618102319 618102319
ci_pipeline_id 42903117 42903117
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 19 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:profiling better
[-97.033µs; -46.130µs] or [-6.323%; -3.006%]		 unstable
[-360.876op/s; +834.950op/s] or [-12.180%; +28.180%]		 1.463ms 3200.000op/s 1.535ms 2962.963op/s
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~6de92f18ed, baseline=1.39.0-SNAPSHOT~bb9b598987
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.315 ms) : 1296, 1334
.   : milestone, 1315,
appsec (1.719 ms) : 1696, 1743
.   : milestone, 1719,
appsec_no_iast (1.708 ms) : 1683, 1732
.   : milestone, 1708,
iast (1.469 ms) : 1446, 1492
.   : milestone, 1469,
profiling (1.535 ms) : 1510, 1559
.   : milestone, 1535,
tracing (1.473 ms) : 1449, 1497
.   : milestone, 1473,
section candidate
no_agent (1.335 ms) : 1314, 1355
.   : milestone, 1335,
appsec (1.722 ms) : 1699, 1746
.   : milestone, 1722,
appsec_no_iast (1.717 ms) : 1694, 1741
.   : milestone, 1717,
iast (1.474 ms) : 1452, 1497
.   : milestone, 1474,
profiling (1.463 ms) : 1440, 1486
.   : milestone, 1463,
tracing (1.467 ms) : 1443, 1491
.   : milestone, 1467,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.315 ms [1.296 ms, 1.334 ms] -
appsec 1.719 ms [1.696 ms, 1.743 ms] 404.336 µs (30.8%)
appsec_no_iast 1.708 ms [1.683 ms, 1.732 ms] 392.936 µs (29.9%)
iast 1.469 ms [1.446 ms, 1.492 ms] 154.574 µs (11.8%)
profiling 1.535 ms [1.51 ms, 1.559 ms] 219.818 µs (16.7%)
tracing 1.473 ms [1.449 ms, 1.497 ms] 157.989 µs (12.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.335 ms [1.314 ms, 1.355 ms] -
appsec 1.722 ms [1.699 ms, 1.746 ms] 387.631 µs (29.0%)
appsec_no_iast 1.717 ms [1.694 ms, 1.741 ms] 382.682 µs (28.7%)
iast 1.474 ms [1.452 ms, 1.497 ms] 139.601 µs (10.5%)
profiling 1.463 ms [1.44 ms, 1.486 ms] 128.361 µs (9.6%)
tracing 1.467 ms [1.443 ms, 1.491 ms] 132.222 µs (9.9%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~6de92f18ed, baseline=1.39.0-SNAPSHOT~bb9b598987
    dateFormat X
    axisFormat %s
section baseline
no_agent (371.35 µs) : 351, 392
.   : milestone, 371,
iast (480.546 µs) : 458, 503
.   : milestone, 481,
iast_FULL (545.82 µs) : 525, 567
.   : milestone, 546,
iast_GLOBAL (501.873 µs) : 480, 524
.   : milestone, 502,
iast_HARDCODED_SECRET_DISABLED (476.796 µs) : 455, 499
.   : milestone, 477,
iast_INACTIVE (444.293 µs) : 423, 466
.   : milestone, 444,
iast_TELEMETRY_OFF (467.155 µs) : 445, 490
.   : milestone, 467,
tracing (435.535 µs) : 415, 456
.   : milestone, 436,
section candidate
no_agent (364.153 µs) : 345, 383
.   : milestone, 364,
iast (476.609 µs) : 454, 499
.   : milestone, 477,
iast_FULL (542.782 µs) : 522, 564
.   : milestone, 543,
iast_GLOBAL (500.903 µs) : 479, 523
.   : milestone, 501,
iast_HARDCODED_SECRET_DISABLED (473.631 µs) : 451, 496
.   : milestone, 474,
iast_INACTIVE (436.802 µs) : 416, 458
.   : milestone, 437,
iast_TELEMETRY_OFF (466.476 µs) : 444, 489
.   : milestone, 466,
tracing (436.787 µs) : 415, 458
.   : milestone, 437,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 371.35 µs [350.751 µs, 391.95 µs] -
iast 480.546 µs [458.157 µs, 502.936 µs] 109.196 µs (29.4%)
iast_FULL 545.82 µs [524.528 µs, 567.112 µs] 174.47 µs (47.0%)
iast_GLOBAL 501.873 µs [480.106 µs, 523.64 µs] 130.522 µs (35.1%)
iast_HARDCODED_SECRET_DISABLED 476.796 µs [454.804 µs, 498.787 µs] 105.445 µs (28.4%)
iast_INACTIVE 444.293 µs [422.867 µs, 465.718 µs] 72.942 µs (19.6%)
iast_TELEMETRY_OFF 467.155 µs [444.731 µs, 489.58 µs] 95.805 µs (25.8%)
tracing 435.535 µs [415.115 µs, 455.954 µs] 64.184 µs (17.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 364.153 µs [344.85 µs, 383.456 µs] -
iast 476.609 µs [454.259 µs, 498.959 µs] 112.456 µs (30.9%)
iast_FULL 542.782 µs [521.725 µs, 563.839 µs] 178.629 µs (49.1%)
iast_GLOBAL 500.903 µs [478.798 µs, 523.008 µs] 136.75 µs (37.6%)
iast_HARDCODED_SECRET_DISABLED 473.631 µs [451.469 µs, 495.792 µs] 109.477 µs (30.1%)
iast_INACTIVE 436.802 µs [416.065 µs, 457.539 µs] 72.649 µs (20.0%)
iast_TELEMETRY_OFF 466.476 µs [444.058 µs, 488.895 µs] 102.323 µs (28.1%)
tracing 436.787 µs [415.394 µs, 458.181 µs] 72.634 µs (19.9%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jb/crash_tracker_warning_log
git_commit_date 1724748799 1724749989
git_commit_sha bb9b598 6de92f1
release_version 1.39.0-SNAPSHOT~bb9b598987 1.39.0-SNAPSHOT~6de92f18ed
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1724751760 1724751760
ci_job_id 618102320 618102320
ci_pipeline_id 42903117 42903117
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~6de92f18ed, baseline=1.39.0-SNAPSHOT~bb9b598987
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.072 s) : 15072000, 15072000
.   : milestone, 15072000,
appsec (15.015 s) : 15015000, 15015000
.   : milestone, 15015000,
iast (18.904 s) : 18904000, 18904000
.   : milestone, 18904000,
iast_GLOBAL (17.822 s) : 17822000, 17822000
.   : milestone, 17822000,
profiling (15.275 s) : 15275000, 15275000
.   : milestone, 15275000,
tracing (15.232 s) : 15232000, 15232000
.   : milestone, 15232000,
section candidate
no_agent (15.355 s) : 15355000, 15355000
.   : milestone, 15355000,
appsec (15.265 s) : 15265000, 15265000
.   : milestone, 15265000,
iast (18.888 s) : 18888000, 18888000
.   : milestone, 18888000,
iast_GLOBAL (17.937 s) : 17937000, 17937000
.   : milestone, 17937000,
profiling (15.075 s) : 15075000, 15075000
.   : milestone, 15075000,
tracing (15.261 s) : 15261000, 15261000
.   : milestone, 15261000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.072 s [15.072 s, 15.072 s] -
appsec 15.015 s [15.015 s, 15.015 s] -57.0 ms (-0.4%)
iast 18.904 s [18.904 s, 18.904 s] 3.832 s (25.4%)
iast_GLOBAL 17.822 s [17.822 s, 17.822 s] 2.75 s (18.2%)
profiling 15.275 s [15.275 s, 15.275 s] 203.0 ms (1.3%)
tracing 15.232 s [15.232 s, 15.232 s] 160.0 ms (1.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.355 s [15.355 s, 15.355 s] -
appsec 15.265 s [15.265 s, 15.265 s] -90.0 ms (-0.6%)
iast 18.888 s [18.888 s, 18.888 s] 3.533 s (23.0%)
iast_GLOBAL 17.937 s [17.937 s, 17.937 s] 2.582 s (16.8%)
profiling 15.075 s [15.075 s, 15.075 s] -280.0 ms (-1.8%)
tracing 15.261 s [15.261 s, 15.261 s] -94.0 ms (-0.6%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~6de92f18ed, baseline=1.39.0-SNAPSHOT~bb9b598987
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.459 ms) : 1447, 1470
.   : milestone, 1459,
appsec (2.244 ms) : 2208, 2280
.   : milestone, 2244,
iast (1.968 ms) : 1926, 2010
.   : milestone, 1968,
iast_GLOBAL (2.027 ms) : 1983, 2071
.   : milestone, 2027,
profiling (1.87 ms) : 1835, 1904
.   : milestone, 1870,
tracing (1.844 ms) : 1811, 1878
.   : milestone, 1844,
section candidate
no_agent (1.454 ms) : 1443, 1466
.   : milestone, 1454,
appsec (2.219 ms) : 2185, 2254
.   : milestone, 2219,
iast (1.966 ms) : 1923, 2009
.   : milestone, 1966,
iast_GLOBAL (2.028 ms) : 1984, 2072
.   : milestone, 2028,
profiling (1.874 ms) : 1838, 1910
.   : milestone, 1874,
tracing (1.842 ms) : 1808, 1875
.   : milestone, 1842,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.459 ms [1.447 ms, 1.47 ms] -
appsec 2.244 ms [2.208 ms, 2.28 ms] 785.206 µs (53.8%)
iast 1.968 ms [1.926 ms, 2.01 ms] 509.719 µs (34.9%)
iast_GLOBAL 2.027 ms [1.983 ms, 2.071 ms] 568.065 µs (38.9%)
profiling 1.87 ms [1.835 ms, 1.904 ms] 411.096 µs (28.2%)
tracing 1.844 ms [1.811 ms, 1.878 ms] 385.495 µs (26.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.454 ms [1.443 ms, 1.466 ms] -
appsec 2.219 ms [2.185 ms, 2.254 ms] 765.137 µs (52.6%)
iast 1.966 ms [1.923 ms, 2.009 ms] 511.731 µs (35.2%)
iast_GLOBAL 2.028 ms [1.984 ms, 2.072 ms] 573.659 µs (39.4%)
profiling 1.874 ms [1.838 ms, 1.91 ms] 420.02 µs (28.9%)
tracing 1.842 ms [1.808 ms, 1.875 ms] 387.279 µs (26.6%)

@jbachorik jbachorik enabled auto-merge (squash) August 27, 2024 10:10
@jbachorik jbachorik added the comp: crash tracking Crash Tracking label Aug 27, 2024
@jbachorik jbachorik merged commit ec821c1 into master Aug 27, 2024
@jbachorik jbachorik deleted the jb/crash_tracker_warning_log branch August 27, 2024 12:03
@github-actions github-actions Bot added this to the 1.39.0 milestone Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

Assignees

No one assigned

Labels

comp: crash tracking Crash Tracking

Projects

None yet

Milestone

1.39.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jbachorik @PerfectSlayer