Log a warning when profiling enablement is misconfigured.#7511
Merged
Log a warning when profiling enablement is misconfigured.#7511
Conversation
8adf0fa to
b286d99
Compare
amarziali
approved these changes
Aug 26, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 13 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~8adf0fa90f, baseline=1.39.0-SNAPSHOT~074bc9bc4e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1054867
Total [baseline] (8.509 s) : 0, 8509178
Agent [candidate] (1.056 s) : 0, 1055977
Total [candidate] (8.512 s) : 0, 8512311
section iast
Agent [baseline] (1.179 s) : 0, 1178821
Total [baseline] (8.993 s) : 0, 8993471
Agent [candidate] (1.171 s) : 0, 1170913
Total [candidate] (8.961 s) : 0, 8960833
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.178 s) : 0, 1177856
Total [baseline] (8.971 s) : 0, 8971378
Agent [candidate] (1.177 s) : 0, 1177380
Total [candidate] (8.933 s) : 0, 8932770
section iast_TELEMETRY_OFF
Agent [baseline] (1.183 s) : 0, 1182886
Total [baseline] (8.999 s) : 0, 8998762
Agent [candidate] (1.176 s) : 0, 1175857
Total [candidate] (8.957 s) : 0, 8957138
gantt
title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~8adf0fa90f, baseline=1.39.0-SNAPSHOT~074bc9bc4e
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (672.844 ms) : 0, 672844
BytebuddyAgent [candidate] (674.028 ms) : 0, 674028
GlobalTracer [baseline] (308.619 ms) : 0, 308619
GlobalTracer [candidate] (308.199 ms) : 0, 308199
AppSec [baseline] (51.638 ms) : 0, 51638
AppSec [candidate] (51.749 ms) : 0, 51749
Remote Config [baseline] (673.695 µs) : 0, 674
Remote Config [candidate] (690.51 µs) : 0, 691
Telemetry [baseline] (7.55 ms) : 0, 7550
Telemetry [candidate] (7.65 ms) : 0, 7650
section iast
BytebuddyAgent [baseline] (783.042 ms) : 0, 783042
BytebuddyAgent [candidate] (777.714 ms) : 0, 777714
GlobalTracer [baseline] (297.49 ms) : 0, 297490
GlobalTracer [candidate] (295.831 ms) : 0, 295831
AppSec [baseline] (54.964 ms) : 0, 54964
AppSec [candidate] (50.398 ms) : 0, 50398
IAST [baseline] (21.207 ms) : 0, 21207
IAST [candidate] (25.616 ms) : 0, 25616
Remote Config [baseline] (593.767 µs) : 0, 594
Remote Config [candidate] (592.319 µs) : 0, 592
Telemetry [baseline] (8.003 ms) : 0, 8003
Telemetry [candidate] (7.206 ms) : 0, 7206
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (783.749 ms) : 0, 783749
BytebuddyAgent [candidate] (782.065 ms) : 0, 782065
GlobalTracer [baseline] (296.837 ms) : 0, 296837
GlobalTracer [candidate] (297.126 ms) : 0, 297126
AppSec [baseline] (49.002 ms) : 0, 49002
AppSec [candidate] (49.164 ms) : 0, 49164
IAST [baseline] (25.388 ms) : 0, 25388
IAST [candidate] (25.202 ms) : 0, 25202
Remote Config [baseline] (593.175 µs) : 0, 593
Remote Config [candidate] (602.619 µs) : 0, 603
Telemetry [baseline] (8.707 ms) : 0, 8707
Telemetry [candidate] (9.568 ms) : 0, 9568
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (784.671 ms) : 0, 784671
BytebuddyAgent [candidate] (780.365 ms) : 0, 780365
GlobalTracer [baseline] (299.414 ms) : 0, 299414
GlobalTracer [candidate] (297.806 ms) : 0, 297806
AppSec [baseline] (50.653 ms) : 0, 50653
AppSec [candidate] (49.084 ms) : 0, 49084
IAST [baseline] (23.675 ms) : 0, 23675
IAST [candidate] (24.282 ms) : 0, 24282
Remote Config [baseline] (604.683 µs) : 0, 605
Remote Config [candidate] (604.079 µs) : 0, 604
Telemetry [baseline] (10.329 ms) : 0, 10329
Telemetry [candidate] (10.055 ms) : 0, 10055
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~8adf0fa90f, baseline=1.39.0-SNAPSHOT~074bc9bc4e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.058 s) : 0, 1057781
Total [baseline] (10.472 s) : 0, 10471869
Agent [candidate] (1.053 s) : 0, 1052921
Total [candidate] (10.406 s) : 0, 10406335
section appsec
Agent [baseline] (1.17 s) : 0, 1169714
Total [baseline] (10.445 s) : 0, 10445012
Agent [candidate] (1.171 s) : 0, 1170704
Total [candidate] (10.399 s) : 0, 10399395
section iast
Agent [baseline] (1.175 s) : 0, 1174789
Total [baseline] (10.801 s) : 0, 10801222
Agent [candidate] (1.183 s) : 0, 1183269
Total [candidate] (10.87 s) : 0, 10869937
section profiling
Agent [baseline] (1.256 s) : 0, 1256077
Total [baseline] (10.54 s) : 0, 10539564
Agent [candidate] (1.245 s) : 0, 1244504
Total [candidate] (10.639 s) : 0, 10639065
gantt
title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~8adf0fa90f, baseline=1.39.0-SNAPSHOT~074bc9bc4e
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (675.149 ms) : 0, 675149
BytebuddyAgent [candidate] (672.072 ms) : 0, 672072
GlobalTracer [baseline] (309.07 ms) : 0, 309070
GlobalTracer [candidate] (307.668 ms) : 0, 307668
AppSec [baseline] (51.868 ms) : 0, 51868
AppSec [candidate] (51.477 ms) : 0, 51477
Remote Config [baseline] (671.022 µs) : 0, 671
Remote Config [candidate] (666.416 µs) : 0, 666
Telemetry [baseline] (7.494 ms) : 0, 7494
Telemetry [candidate] (7.465 ms) : 0, 7465
section appsec
BytebuddyAgent [baseline] (679.463 ms) : 0, 679463
BytebuddyAgent [candidate] (678.92 ms) : 0, 678920
GlobalTracer [baseline] (300.33 ms) : 0, 300330
GlobalTracer [candidate] (299.902 ms) : 0, 299902
AppSec [baseline] (159.261 ms) : 0, 159261
AppSec [candidate] (161.067 ms) : 0, 161067
Remote Config [baseline] (618.801 µs) : 0, 619
Remote Config [candidate] (642.49 µs) : 0, 642
Telemetry [baseline] (7.44 ms) : 0, 7440
Telemetry [candidate] (7.388 ms) : 0, 7388
IAST [baseline] (18.245 ms) : 0, 18245
IAST [candidate] (18.455 ms) : 0, 18455
section iast
BytebuddyAgent [baseline] (780.425 ms) : 0, 780425
BytebuddyAgent [candidate] (785.469 ms) : 0, 785469
GlobalTracer [baseline] (296.759 ms) : 0, 296759
GlobalTracer [candidate] (298.602 ms) : 0, 298602
AppSec [baseline] (50.874 ms) : 0, 50874
AppSec [candidate] (53.283 ms) : 0, 53283
Remote Config [baseline] (573.152 µs) : 0, 573
Remote Config [candidate] (610.335 µs) : 0, 610
Telemetry [baseline] (7.777 ms) : 0, 7777
Telemetry [candidate] (10.387 ms) : 0, 10387
IAST [baseline] (24.855 ms) : 0, 24855
IAST [candidate] (21.245 ms) : 0, 21245
section profiling
BytebuddyAgent [baseline] (669.049 ms) : 0, 669049
BytebuddyAgent [candidate] (662.534 ms) : 0, 662534
GlobalTracer [baseline] (391.483 ms) : 0, 391483
GlobalTracer [candidate] (388.636 ms) : 0, 388636
AppSec [baseline] (52.574 ms) : 0, 52574
AppSec [candidate] (52.246 ms) : 0, 52246
Remote Config [baseline] (688.867 µs) : 0, 689
Remote Config [candidate] (678.039 µs) : 0, 678
Telemetry [baseline] (7.427 ms) : 0, 7427
Telemetry [candidate] (7.301 ms) : 0, 7301
ProfilingAgent [baseline] (97.275 ms) : 0, 97275
ProfilingAgent [candidate] (95.84 ms) : 0, 95840
Profiling [baseline] (97.299 ms) : 0, 97299
Profiling [candidate] (95.863 ms) : 0, 95863
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 19 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~8adf0fa90f, baseline=1.39.0-SNAPSHOT~074bc9bc4e
dateFormat X
axisFormat %s
section baseline
no_agent (1.333 ms) : 1314, 1352
. : milestone, 1333,
appsec (1.715 ms) : 1690, 1740
. : milestone, 1715,
appsec_no_iast (1.737 ms) : 1713, 1761
. : milestone, 1737,
iast (1.465 ms) : 1442, 1488
. : milestone, 1465,
profiling (1.488 ms) : 1463, 1514
. : milestone, 1488,
tracing (1.446 ms) : 1421, 1471
. : milestone, 1446,
section candidate
no_agent (1.332 ms) : 1312, 1352
. : milestone, 1332,
appsec (1.718 ms) : 1693, 1742
. : milestone, 1718,
appsec_no_iast (1.716 ms) : 1691, 1741
. : milestone, 1716,
iast (1.474 ms) : 1451, 1496
. : milestone, 1474,
profiling (1.484 ms) : 1459, 1508
. : milestone, 1484,
tracing (1.457 ms) : 1433, 1482
. : milestone, 1457,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~8adf0fa90f, baseline=1.39.0-SNAPSHOT~074bc9bc4e
dateFormat X
axisFormat %s
section baseline
no_agent (366.259 µs) : 347, 386
. : milestone, 366,
iast (485.293 µs) : 463, 508
. : milestone, 485,
iast_FULL (551.821 µs) : 531, 573
. : milestone, 552,
iast_GLOBAL (501.81 µs) : 481, 523
. : milestone, 502,
iast_HARDCODED_SECRET_DISABLED (486.484 µs) : 464, 509
. : milestone, 486,
iast_INACTIVE (443.648 µs) : 423, 465
. : milestone, 444,
iast_TELEMETRY_OFF (474.277 µs) : 452, 497
. : milestone, 474,
tracing (435.59 µs) : 416, 456
. : milestone, 436,
section candidate
no_agent (367.91 µs) : 348, 387
. : milestone, 368,
iast (484.152 µs) : 461, 507
. : milestone, 484,
iast_FULL (553.982 µs) : 532, 575
. : milestone, 554,
iast_GLOBAL (516.707 µs) : 494, 539
. : milestone, 517,
iast_HARDCODED_SECRET_DISABLED (479.992 µs) : 458, 502
. : milestone, 480,
iast_INACTIVE (447.367 µs) : 426, 469
. : milestone, 447,
iast_TELEMETRY_OFF (472.376 µs) : 449, 495
. : milestone, 472,
tracing (442.964 µs) : 422, 464
. : milestone, 443,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~8adf0fa90f, baseline=1.39.0-SNAPSHOT~074bc9bc4e
dateFormat X
axisFormat %s
section baseline
no_agent (15.505 s) : 15505000, 15505000
. : milestone, 15505000,
appsec (15.098 s) : 15098000, 15098000
. : milestone, 15098000,
iast (18.704 s) : 18704000, 18704000
. : milestone, 18704000,
iast_GLOBAL (17.676 s) : 17676000, 17676000
. : milestone, 17676000,
profiling (15.929 s) : 15929000, 15929000
. : milestone, 15929000,
tracing (15.152 s) : 15152000, 15152000
. : milestone, 15152000,
section candidate
no_agent (15.324 s) : 15324000, 15324000
. : milestone, 15324000,
appsec (14.965 s) : 14965000, 14965000
. : milestone, 14965000,
iast (18.711 s) : 18711000, 18711000
. : milestone, 18711000,
iast_GLOBAL (17.917 s) : 17917000, 17917000
. : milestone, 17917000,
profiling (15.276 s) : 15276000, 15276000
. : milestone, 15276000,
tracing (15.263 s) : 15263000, 15263000
. : milestone, 15263000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~8adf0fa90f, baseline=1.39.0-SNAPSHOT~074bc9bc4e
dateFormat X
axisFormat %s
section baseline
no_agent (1.452 ms) : 1441, 1464
. : milestone, 1452,
appsec (2.224 ms) : 2189, 2259
. : milestone, 2224,
iast (1.958 ms) : 1915, 2000
. : milestone, 1958,
iast_GLOBAL (2.018 ms) : 1974, 2063
. : milestone, 2018,
profiling (1.856 ms) : 1822, 1891
. : milestone, 1856,
tracing (1.829 ms) : 1797, 1862
. : milestone, 1829,
section candidate
no_agent (1.456 ms) : 1445, 1468
. : milestone, 1456,
appsec (2.222 ms) : 2187, 2257
. : milestone, 2222,
iast (1.958 ms) : 1916, 2000
. : milestone, 1958,
iast_GLOBAL (2.008 ms) : 1964, 2051
. : milestone, 2008,
profiling (1.857 ms) : 1822, 1892
. : milestone, 1857,
tracing (1.842 ms) : 1809, 1876
. : milestone, 1842,
|
manuel-alvarez-alvarez
approved these changes
Aug 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
It validates the profiler enablement config and emits a warning when it is not on of the expected values.
Motivation
We can see that there are users with accidentally misconfigured profiler enablement. This is to help them to identify and fix the problem.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: PROF-10402