Skip to content

OpenTelemetry drop-in fixes for Apache Pulsar#7500

Merged
mcculls merged 1 commit intomasterfrom
mcculls/otel-dropin-pulsar-mapping
Aug 23, 2024
Merged

OpenTelemetry drop-in fixes for Apache Pulsar#7500
mcculls merged 1 commit intomasterfrom
mcculls/otel-dropin-pulsar-mapping

Conversation

@mcculls
Copy link
Copy Markdown
Contributor

@mcculls mcculls commented Aug 23, 2024

  • Include OTel instrumentation-api incubator types for messaging

@mcculls mcculls added inst: others All other instrumentations inst: opentelemetry OpenTelemetry instrumentation labels Aug 23, 2024
@mcculls mcculls marked this pull request as ready for review August 23, 2024 13:30
@mcculls mcculls requested a review from a team as a code owner August 23, 2024 13:30
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Aug 23, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/otel-dropin-pulsar-mapping
git_commit_date 1724414464 1724419462
git_commit_sha 0720a77 28ab4ca802
release_version 1.39.0-SNAPSHOT~0720a7754a 1.39.0-SNAPSHOT~28ab4ca802
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1724422557 1724422557
ci_job_id 615239426 615239426
ci_pipeline_id 42678024 42678024
cpu_model Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~28ab4ca802, baseline=1.39.0-SNAPSHOT~0720a7754a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.549 s) : 0, 1548531
Total [baseline] (14.285 s) : 0, 14285172
Agent [candidate] (1.55 s) : 0, 1550341
Total [candidate] (14.318 s) : 0, 14318468
section appsec
Agent [baseline] (1.735 s) : 0, 1735154
Total [baseline] (14.391 s) : 0, 14390801
Agent [candidate] (1.737 s) : 0, 1737474
Total [candidate] (14.424 s) : 0, 14423773
section iast
Agent [baseline] (1.72 s) : 0, 1719573
Total [baseline] (14.796 s) : 0, 14796448
Agent [candidate] (1.721 s) : 0, 1720987
Total [candidate] (14.885 s) : 0, 14884577
section profiling
Agent [baseline] (1.857 s) : 0, 1857292
Total [baseline] (14.592 s) : 0, 14591675
Agent [candidate] (1.865 s) : 0, 1865381
Total [candidate] (14.552 s) : 0, 14552322
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.549 s -
Agent appsec 1.735 s 186.624 ms (12.1%)
Agent iast 1.72 s 171.043 ms (11.0%)
Agent profiling 1.857 s 308.761 ms (19.9%)
Total tracing 14.285 s -
Total appsec 14.391 s 105.629 ms (0.7%)
Total iast 14.796 s 511.276 ms (3.6%)
Total profiling 14.592 s 306.502 ms (2.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.55 s -
Agent appsec 1.737 s 187.133 ms (12.1%)
Agent iast 1.721 s 170.646 ms (11.0%)
Agent profiling 1.865 s 315.04 ms (20.3%)
Total tracing 14.318 s -
Total appsec 14.424 s 105.305 ms (0.7%)
Total iast 14.885 s 566.108 ms (4.0%)
Total profiling 14.552 s 233.854 ms (1.6%) 
gantt
    title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~28ab4ca802, baseline=1.39.0-SNAPSHOT~0720a7754a

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (992.479 ms) : 0, 992479
BytebuddyAgent [candidate] (992.376 ms) : 0, 992376
GlobalTracer [baseline] (453.447 ms) : 0, 453447
GlobalTracer [candidate] (454.721 ms) : 0, 454721
AppSec [baseline] (72.03 ms) : 0, 72030
AppSec [candidate] (72.524 ms) : 0, 72524
Remote Config [baseline] (833.323 µs) : 0, 833
Remote Config [candidate] (825.919 µs) : 0, 826
Telemetry [baseline] (9.738 ms) : 0, 9738
Telemetry [candidate] (9.835 ms) : 0, 9835
section appsec
BytebuddyAgent [baseline] (1.009 s) : 0, 1008888
BytebuddyAgent [candidate] (1.01 s) : 0, 1010141
GlobalTracer [baseline] (447.409 ms) : 0, 447409
GlobalTracer [candidate] (447.713 ms) : 0, 447713
AppSec [baseline] (234.907 ms) : 0, 234907
AppSec [candidate] (235.085 ms) : 0, 235085
IAST [baseline] (26.07 ms) : 0, 26070
IAST [candidate] (26.283 ms) : 0, 26283
Remote Config [baseline] (756.008 µs) : 0, 756
Remote Config [candidate] (752.151 µs) : 0, 752
Telemetry [baseline] (10.188 ms) : 0, 10188
Telemetry [candidate] (10.578 ms) : 0, 10578
section iast
BytebuddyAgent [baseline] (1.151 s) : 0, 1150507
BytebuddyAgent [candidate] (1.151 s) : 0, 1150767
GlobalTracer [baseline] (435.304 ms) : 0, 435304
GlobalTracer [candidate] (436.158 ms) : 0, 436158
AppSec [baseline] (73.937 ms) : 0, 73937
AppSec [candidate] (72.134 ms) : 0, 72134
IAST [baseline] (28.253 ms) : 0, 28253
IAST [candidate] (30.208 ms) : 0, 30208
Remote Config [baseline] (751.439 µs) : 0, 751
Remote Config [candidate] (744.477 µs) : 0, 744
Telemetry [baseline] (10.799 ms) : 0, 10799
Telemetry [candidate] (10.84 ms) : 0, 10840
section profiling
BytebuddyAgent [baseline] (985.048 ms) : 0, 985048
BytebuddyAgent [candidate] (988.766 ms) : 0, 988766
GlobalTracer [baseline] (583.613 ms) : 0, 583613
GlobalTracer [candidate] (585.64 ms) : 0, 585640
AppSec [baseline] (73.396 ms) : 0, 73396
AppSec [candidate] (73.847 ms) : 0, 73847
Remote Config [baseline] (890.807 µs) : 0, 891
Remote Config [candidate] (894.345 µs) : 0, 894
Telemetry [baseline] (9.405 ms) : 0, 9405
Telemetry [candidate] (9.514 ms) : 0, 9514
ProfilingAgent [baseline] (148.972 ms) : 0, 148972
ProfilingAgent [candidate] (150.723 ms) : 0, 150723
Profiling [baseline] (149.033 ms) : 0, 149033
Profiling [candidate] (150.786 ms) : 0, 150786
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~28ab4ca802, baseline=1.39.0-SNAPSHOT~0720a7754a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.554 s) : 0, 1554001
Total [baseline] (11.851 s) : 0, 11850673
Agent [candidate] (1.55 s) : 0, 1549552
Total [candidate] (11.819 s) : 0, 11819236
section iast
Agent [baseline] (1.717 s) : 0, 1716686
Total [baseline] (12.509 s) : 0, 12509117
Agent [candidate] (1.717 s) : 0, 1717242
Total [candidate] (12.596 s) : 0, 12595547
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.72 s) : 0, 1720371
Total [baseline] (12.496 s) : 0, 12495722
Agent [candidate] (1.718 s) : 0, 1717574
Total [candidate] (12.456 s) : 0, 12455535
section iast_TELEMETRY_OFF
Agent [baseline] (1.713 s) : 0, 1713020
Total [baseline] (12.497 s) : 0, 12497027
Agent [candidate] (1.714 s) : 0, 1713877
Total [candidate] (12.488 s) : 0, 12488054
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.554 s -
Agent iast 1.717 s 162.685 ms (10.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.72 s 166.37 ms (10.7%)
Agent iast_TELEMETRY_OFF 1.713 s 159.019 ms (10.2%)
Total tracing 11.851 s -
Total iast 12.509 s 658.445 ms (5.6%)
Total iast_HARDCODED_SECRET_DISABLED 12.496 s 645.049 ms (5.4%)
Total iast_TELEMETRY_OFF 12.497 s 646.355 ms (5.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.55 s -
Agent iast 1.717 s 167.689 ms (10.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.718 s 168.022 ms (10.8%)
Agent iast_TELEMETRY_OFF 1.714 s 164.324 ms (10.6%)
Total tracing 11.819 s -
Total iast 12.596 s 776.312 ms (6.6%)
Total iast_HARDCODED_SECRET_DISABLED 12.456 s 636.299 ms (5.4%)
Total iast_TELEMETRY_OFF 12.488 s 668.818 ms (5.7%) 
gantt
    title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~28ab4ca802, baseline=1.39.0-SNAPSHOT~0720a7754a

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (995.961 ms) : 0, 995961
BytebuddyAgent [candidate] (993.306 ms) : 0, 993306
GlobalTracer [baseline] (454.749 ms) : 0, 454749
GlobalTracer [candidate] (453.394 ms) : 0, 453394
AppSec [baseline] (72.543 ms) : 0, 72543
AppSec [candidate] (72.094 ms) : 0, 72094
Remote Config [baseline] (836.411 µs) : 0, 836
Remote Config [candidate] (832.5 µs) : 0, 832
Telemetry [baseline] (9.866 ms) : 0, 9866
Telemetry [candidate] (9.817 ms) : 0, 9817
section iast
BytebuddyAgent [baseline] (1.148 s) : 0, 1148144
BytebuddyAgent [candidate] (1.149 s) : 0, 1148578
GlobalTracer [baseline] (435.051 ms) : 0, 435051
GlobalTracer [candidate] (435.809 ms) : 0, 435809
AppSec [baseline] (74.583 ms) : 0, 74583
AppSec [candidate] (70.08 ms) : 0, 70080
IAST [baseline] (28.163 ms) : 0, 28163
IAST [candidate] (27.675 ms) : 0, 27675
Remote Config [baseline] (735.834 µs) : 0, 736
Remote Config [candidate] (749.686 µs) : 0, 750
Telemetry [baseline] (10.014 ms) : 0, 10014
Telemetry [candidate] (14.218 ms) : 0, 14218
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (1.151 s) : 0, 1150567
BytebuddyAgent [candidate] (1.149 s) : 0, 1148752
GlobalTracer [baseline] (436.394 ms) : 0, 436394
GlobalTracer [candidate] (435.02 ms) : 0, 435020
AppSec [baseline] (73.081 ms) : 0, 73081
AppSec [candidate] (70.202 ms) : 0, 70202
IAST [baseline] (27.672 ms) : 0, 27672
IAST [candidate] (31.033 ms) : 0, 31033
Remote Config [baseline] (747.7 µs) : 0, 748
Remote Config [candidate] (733.102 µs) : 0, 733
Telemetry [baseline] (11.81 ms) : 0, 11810
Telemetry [candidate] (11.688 ms) : 0, 11688
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (1.145 s) : 0, 1145347
BytebuddyAgent [candidate] (1.145 s) : 0, 1144933
GlobalTracer [baseline] (435.519 ms) : 0, 435519
GlobalTracer [candidate] (435.262 ms) : 0, 435262
AppSec [baseline] (72.592 ms) : 0, 72592
AppSec [candidate] (70.648 ms) : 0, 70648
IAST [baseline] (27.873 ms) : 0, 27873
IAST [candidate] (32.193 ms) : 0, 32193
Remote Config [baseline] (731.137 µs) : 0, 731
Remote Config [candidate] (741.122 µs) : 0, 741
Telemetry [baseline] (10.925 ms) : 0, 10925
Telemetry [candidate] (9.97 ms) : 0, 9970
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-08-23T13:35:31 2024-08-23T13:44:28
git_branch master mcculls/otel-dropin-pulsar-mapping
git_commit_date 1724414464 1724419462
git_commit_sha 0720a77 28ab4ca802
release_version 1.39.0-SNAPSHOT~0720a7754a 1.39.0-SNAPSHOT~28ab4ca802
start_time 2024-08-23T13:35:15 2024-08-23T13:44:12
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1724421124 1724421124
ci_job_id 615239427 615239427
ci_pipeline_id 42678024 42678024
cpu_model Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 5 metrics, 22 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:profiling worse
[+104.662µs; +179.364µs] or [+5.671%; +9.718%]		 unstable
[-542.591op/s; +229.786op/s] or [-21.025%; +8.904%]		 1.988ms 2424.242op/s 1.846ms 2580.645op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~28ab4ca802, baseline=1.39.0-SNAPSHOT~0720a7754a
    dateFormat X
    axisFormat %s
section baseline
no_agent (446.6 µs) : 418, 476
.   : milestone, 447,
iast (582.663 µs) : 549, 616
.   : milestone, 583,
iast_FULL (676.489 µs) : 643, 710
.   : milestone, 676,
iast_GLOBAL (610.131 µs) : 577, 643
.   : milestone, 610,
iast_HARDCODED_SECRET_DISABLED (595.341 µs) : 563, 628
.   : milestone, 595,
iast_INACTIVE (539.105 µs) : 509, 569
.   : milestone, 539,
iast_TELEMETRY_OFF (571.059 µs) : 538, 604
.   : milestone, 571,
tracing (536.472 µs) : 506, 566
.   : milestone, 536,
section candidate
no_agent (444.654 µs) : 416, 473
.   : milestone, 445,
iast (582.214 µs) : 549, 616
.   : milestone, 582,
iast_FULL (685.731 µs) : 653, 718
.   : milestone, 686,
iast_GLOBAL (616.061 µs) : 583, 649
.   : milestone, 616,
iast_HARDCODED_SECRET_DISABLED (584.263 µs) : 551, 617
.   : milestone, 584,
iast_INACTIVE (537.711 µs) : 505, 570
.   : milestone, 538,
iast_TELEMETRY_OFF (571.127 µs) : 538, 604
.   : milestone, 571,
tracing (528.298 µs) : 499, 558
.   : milestone, 528,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 446.6 µs [417.537 µs, 475.663 µs] -
iast 582.663 µs [549.365 µs, 615.96 µs] 136.062 µs (30.5%)
iast_FULL 676.489 µs [643.231 µs, 709.747 µs] 229.888 µs (51.5%)
iast_GLOBAL 610.131 µs [577.093 µs, 643.168 µs] 163.53 µs (36.6%)
iast_HARDCODED_SECRET_DISABLED 595.341 µs [562.604 µs, 628.078 µs] 148.741 µs (33.3%)
iast_INACTIVE 539.105 µs [509.026 µs, 569.184 µs] 92.505 µs (20.7%)
iast_TELEMETRY_OFF 571.059 µs [537.627 µs, 604.491 µs] 124.458 µs (27.9%)
tracing 536.472 µs [506.481 µs, 566.462 µs] 89.872 µs (20.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 444.654 µs [416.114 µs, 473.194 µs] -
iast 582.214 µs [548.836 µs, 615.593 µs] 137.561 µs (30.9%)
iast_FULL 685.731 µs [653.42 µs, 718.043 µs] 241.077 µs (54.2%)
iast_GLOBAL 616.061 µs [583.098 µs, 649.024 µs] 171.407 µs (38.5%)
iast_HARDCODED_SECRET_DISABLED 584.263 µs [551.38 µs, 617.146 µs] 139.609 µs (31.4%)
iast_INACTIVE 537.711 µs [505.431 µs, 569.99 µs] 93.057 µs (20.9%)
iast_TELEMETRY_OFF 571.127 µs [538.116 µs, 604.138 µs] 126.473 µs (28.4%)
tracing 528.298 µs [498.604 µs, 557.992 µs] 83.644 µs (18.8%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~28ab4ca802, baseline=1.39.0-SNAPSHOT~0720a7754a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.711 ms) : 1686, 1736
.   : milestone, 1711,
appsec (2.196 ms) : 2165, 2228
.   : milestone, 2196,
appsec_no_iast (2.184 ms) : 2152, 2215
.   : milestone, 2184,
iast (1.871 ms) : 1842, 1901
.   : milestone, 1871,
profiling (1.846 ms) : 1813, 1879
.   : milestone, 1846,
tracing (1.841 ms) : 1809, 1872
.   : milestone, 1841,
section candidate
no_agent (1.7 ms) : 1676, 1725
.   : milestone, 1700,
appsec (2.16 ms) : 2129, 2191
.   : milestone, 2160,
appsec_no_iast (2.149 ms) : 2118, 2179
.   : milestone, 2149,
iast (1.878 ms) : 1848, 1907
.   : milestone, 1878,
profiling (1.988 ms) : 1952, 2024
.   : milestone, 1988,
tracing (1.876 ms) : 1843, 1909
.   : milestone, 1876,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.711 ms [1.686 ms, 1.736 ms] -
appsec 2.196 ms [2.165 ms, 2.228 ms] 485.319 µs (28.4%)
appsec_no_iast 2.184 ms [2.152 ms, 2.215 ms] 472.715 µs (27.6%)
iast 1.871 ms [1.842 ms, 1.901 ms] 160.137 µs (9.4%)
profiling 1.846 ms [1.813 ms, 1.879 ms] 134.631 µs (7.9%)
tracing 1.841 ms [1.809 ms, 1.872 ms] 129.537 µs (7.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.7 ms [1.676 ms, 1.725 ms] -
appsec 2.16 ms [2.129 ms, 2.191 ms] 459.592 µs (27.0%)
appsec_no_iast 2.149 ms [2.118 ms, 2.179 ms] 448.26 µs (26.4%)
iast 1.878 ms [1.848 ms, 1.907 ms] 177.229 µs (10.4%)
profiling 1.988 ms [1.952 ms, 2.024 ms] 287.426 µs (16.9%)
tracing 1.876 ms [1.843 ms, 1.909 ms] 175.77 µs (10.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/otel-dropin-pulsar-mapping
git_commit_date 1724414464 1724419462
git_commit_sha 0720a77 28ab4ca802
release_version 1.39.0-SNAPSHOT~0720a7754a 1.39.0-SNAPSHOT~28ab4ca802
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1724421949 1724421949
ci_job_id 615239428 615239428
ci_pipeline_id 42678024 42678024
cpu_model Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~28ab4ca802, baseline=1.39.0-SNAPSHOT~0720a7754a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.539 ms) : 1527, 1552
.   : milestone, 1539,
appsec (2.727 ms) : 2664, 2789
.   : milestone, 2727,
iast (2.393 ms) : 2317, 2469
.   : milestone, 2393,
iast_GLOBAL (2.444 ms) : 2367, 2521
.   : milestone, 2444,
profiling (2.223 ms) : 2159, 2286
.   : milestone, 2223,
tracing (2.194 ms) : 2134, 2255
.   : milestone, 2194,
section candidate
no_agent (1.539 ms) : 1527, 1552
.   : milestone, 1539,
appsec (2.714 ms) : 2652, 2777
.   : milestone, 2714,
iast (2.365 ms) : 2290, 2439
.   : milestone, 2365,
iast_GLOBAL (2.423 ms) : 2348, 2499
.   : milestone, 2423,
profiling (2.245 ms) : 2180, 2310
.   : milestone, 2245,
tracing (2.169 ms) : 2111, 2228
.   : milestone, 2169,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.539 ms [1.527 ms, 1.552 ms] -
appsec 2.727 ms [2.664 ms, 2.789 ms] 1.187 ms (77.1%)
iast 2.393 ms [2.317 ms, 2.469 ms] 853.577 µs (55.4%)
iast_GLOBAL 2.444 ms [2.367 ms, 2.521 ms] 904.315 µs (58.7%)
profiling 2.223 ms [2.159 ms, 2.286 ms] 683.213 µs (44.4%)
tracing 2.194 ms [2.134 ms, 2.255 ms] 654.753 µs (42.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.539 ms [1.527 ms, 1.552 ms] -
appsec 2.714 ms [2.652 ms, 2.777 ms] 1.175 ms (76.3%)
iast 2.365 ms [2.29 ms, 2.439 ms] 825.219 µs (53.6%)
iast_GLOBAL 2.423 ms [2.348 ms, 2.499 ms] 884.018 µs (57.4%)
profiling 2.245 ms [2.18 ms, 2.31 ms] 705.896 µs (45.9%)
tracing 2.169 ms [2.111 ms, 2.228 ms] 629.746 µs (40.9%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~28ab4ca802, baseline=1.39.0-SNAPSHOT~0720a7754a
    dateFormat X
    axisFormat %s
section baseline
no_agent (20.557 s) : 20557000, 20557000
.   : milestone, 20557000,
appsec (21.162 s) : 21162000, 21162000
.   : milestone, 21162000,
iast (24.316 s) : 24316000, 24316000
.   : milestone, 24316000,
iast_GLOBAL (24.64 s) : 24640000, 24640000
.   : milestone, 24640000,
profiling (21.12 s) : 21120000, 21120000
.   : milestone, 21120000,
tracing (21.032 s) : 21032000, 21032000
.   : milestone, 21032000,
section candidate
no_agent (21.081 s) : 21081000, 21081000
.   : milestone, 21081000,
appsec (21.796 s) : 21796000, 21796000
.   : milestone, 21796000,
iast (24.65 s) : 24650000, 24650000
.   : milestone, 24650000,
iast_GLOBAL (24.771 s) : 24771000, 24771000
.   : milestone, 24771000,
profiling (21.14 s) : 21140000, 21140000
.   : milestone, 21140000,
tracing (21.395 s) : 21395000, 21395000
.   : milestone, 21395000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 20.557 s [20.557 s, 20.557 s] -
appsec 21.162 s [21.162 s, 21.162 s] 605.0 ms (2.9%)
iast 24.316 s [24.316 s, 24.316 s] 3.759 s (18.3%)
iast_GLOBAL 24.64 s [24.64 s, 24.64 s] 4.083 s (19.9%)
profiling 21.12 s [21.12 s, 21.12 s] 563.0 ms (2.7%)
tracing 21.032 s [21.032 s, 21.032 s] 475.0 ms (2.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 21.081 s [21.081 s, 21.081 s] -
appsec 21.796 s [21.796 s, 21.796 s] 715.0 ms (3.4%)
iast 24.65 s [24.65 s, 24.65 s] 3.569 s (16.9%)
iast_GLOBAL 24.771 s [24.771 s, 24.771 s] 3.69 s (17.5%)
profiling 21.14 s [21.14 s, 21.14 s] 59.0 ms (0.3%)
tracing 21.395 s [21.395 s, 21.395 s] 314.0 ms (1.5%)

@mcculls
OpenTelemetry drop-in fixes for Apache Pulsar
f9334a8 
* Include OTel instrumentation-api incubator types for messaging
@mcculls mcculls force-pushed the mcculls/otel-dropin-pulsar-mapping branch from 28ab4ca to f9334a8 Compare August 23, 2024 15:01
@mcculls mcculls merged commit 62eb0c2 into master Aug 23, 2024
@mcculls mcculls deleted the mcculls/otel-dropin-pulsar-mapping branch August 23, 2024 15:44
@github-actions github-actions Bot added this to the 1.39.0 milestone Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@dougqh dougqh Awaiting requested review from dougqh dougqh was automatically assigned from DataDog/apm-java

@amarziali amarziali Awaiting requested review from amarziali

Assignees

No one assigned

Labels

inst: opentelemetry OpenTelemetry instrumentation inst: others All other instrumentations

Projects

None yet

Milestone

1.39.0

Development

Successfully merging this pull request may close these issues.

2 participants

@mcculls @PerfectSlayer