OpenTelemetry drop-in fixes for Apache Dubbo#7499
Merged
Conversation
Contributor
mcculls
commented
Aug 23, 2024
- Include OTel instrumentation-api incubator types for RPC
* Include OTel instrumentation-api incubator types for RPC
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~2c1072d202, baseline=1.39.0-SNAPSHOT~0720a7754a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.553 s) : 0, 1552844
Total [baseline] (11.844 s) : 0, 11844304
Agent [candidate] (1.555 s) : 0, 1555242
Total [candidate] (11.836 s) : 0, 11836132
section iast
Agent [baseline] (1.722 s) : 0, 1721785
Total [baseline] (12.509 s) : 0, 12509353
Agent [candidate] (1.719 s) : 0, 1718711
Total [candidate] (12.497 s) : 0, 12496702
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.714 s) : 0, 1714380
Total [baseline] (12.445 s) : 0, 12444723
Agent [candidate] (1.719 s) : 0, 1719430
Total [candidate] (12.49 s) : 0, 12489559
section iast_TELEMETRY_OFF
Agent [baseline] (1.715 s) : 0, 1714667
Total [baseline] (12.52 s) : 0, 12520473
Agent [candidate] (1.714 s) : 0, 1713642
Total [candidate] (12.499 s) : 0, 12498650
gantt
title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~2c1072d202, baseline=1.39.0-SNAPSHOT~0720a7754a
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (994.572 ms) : 0, 994572
BytebuddyAgent [candidate] (996.436 ms) : 0, 996436
GlobalTracer [baseline] (454.639 ms) : 0, 454639
GlobalTracer [candidate] (455.426 ms) : 0, 455426
AppSec [baseline] (72.739 ms) : 0, 72739
AppSec [candidate] (72.57 ms) : 0, 72570
Remote Config [baseline] (842.675 µs) : 0, 843
Remote Config [candidate] (826.59 µs) : 0, 827
Telemetry [baseline] (9.933 ms) : 0, 9933
Telemetry [candidate] (9.838 ms) : 0, 9838
section iast
BytebuddyAgent [baseline] (1.151 s) : 0, 1151071
BytebuddyAgent [candidate] (1.15 s) : 0, 1149642
GlobalTracer [baseline] (436.214 ms) : 0, 436214
GlobalTracer [candidate] (435.629 ms) : 0, 435629
AppSec [baseline] (73.978 ms) : 0, 73978
AppSec [candidate] (70.476 ms) : 0, 70476
Remote Config [baseline] (746.699 µs) : 0, 747
Remote Config [candidate] (750.503 µs) : 0, 751
Telemetry [baseline] (10.138 ms) : 0, 10138
Telemetry [candidate] (12.66 ms) : 0, 12660
IAST [baseline] (29.576 ms) : 0, 29576
IAST [candidate] (29.454 ms) : 0, 29454
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (1.147 s) : 0, 1146923
BytebuddyAgent [candidate] (1.149 s) : 0, 1149040
GlobalTracer [baseline] (435.058 ms) : 0, 435058
GlobalTracer [candidate] (436.054 ms) : 0, 436054
AppSec [baseline] (72.715 ms) : 0, 72715
AppSec [candidate] (71.599 ms) : 0, 71599
Remote Config [baseline] (717.464 µs) : 0, 717
Remote Config [candidate] (740.79 µs) : 0, 741
Telemetry [baseline] (9.144 ms) : 0, 9144
Telemetry [candidate] (12.5 ms) : 0, 12500
IAST [baseline] (29.777 ms) : 0, 29777
IAST [candidate] (29.346 ms) : 0, 29346
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (1.146 s) : 0, 1145970
BytebuddyAgent [candidate] (1.146 s) : 0, 1145554
GlobalTracer [baseline] (436.132 ms) : 0, 436132
GlobalTracer [candidate] (434.895 ms) : 0, 434895
AppSec [baseline] (72.927 ms) : 0, 72927
AppSec [candidate] (73.663 ms) : 0, 73663
Remote Config [baseline] (751.681 µs) : 0, 752
Remote Config [candidate] (730.27 µs) : 0, 730
Telemetry [baseline] (10.968 ms) : 0, 10968
Telemetry [candidate] (10.172 ms) : 0, 10172
IAST [baseline] (27.874 ms) : 0, 27874
IAST [candidate] (28.524 ms) : 0, 28524
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~2c1072d202, baseline=1.39.0-SNAPSHOT~0720a7754a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.56 s) : 0, 1559905
Total [baseline] (14.286 s) : 0, 14285700
Agent [candidate] (1.548 s) : 0, 1547901
Total [candidate] (14.201 s) : 0, 14200806
section appsec
Agent [baseline] (1.736 s) : 0, 1735988
Total [baseline] (14.412 s) : 0, 14411715
Agent [candidate] (1.739 s) : 0, 1738930
Total [candidate] (14.45 s) : 0, 14449708
section iast
Agent [baseline] (1.724 s) : 0, 1723799
Total [baseline] (14.873 s) : 0, 14873438
Agent [candidate] (1.717 s) : 0, 1717495
Total [candidate] (14.817 s) : 0, 14816698
section profiling
Agent [baseline] (1.866 s) : 0, 1866236
Total [baseline] (14.739 s) : 0, 14738789
Agent [candidate] (1.86 s) : 0, 1860160
Total [candidate] (14.526 s) : 0, 14526344
gantt
title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~2c1072d202, baseline=1.39.0-SNAPSHOT~0720a7754a
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (1.0 s) : 0, 1000338
BytebuddyAgent [candidate] (991.891 ms) : 0, 991891
GlobalTracer [baseline] (456.235 ms) : 0, 456235
GlobalTracer [candidate] (452.982 ms) : 0, 452982
AppSec [baseline] (72.516 ms) : 0, 72516
AppSec [candidate] (72.276 ms) : 0, 72276
Remote Config [baseline] (837.377 µs) : 0, 837
Remote Config [candidate] (836.081 µs) : 0, 836
Telemetry [baseline] (9.837 ms) : 0, 9837
Telemetry [candidate] (9.836 ms) : 0, 9836
section appsec
BytebuddyAgent [baseline] (1.009 s) : 0, 1008510
BytebuddyAgent [candidate] (1.009 s) : 0, 1008822
GlobalTracer [baseline] (448.079 ms) : 0, 448079
GlobalTracer [candidate] (448.332 ms) : 0, 448332
AppSec [baseline] (234.989 ms) : 0, 234989
AppSec [candidate] (235.62 ms) : 0, 235620
Remote Config [baseline] (752.251 µs) : 0, 752
Remote Config [candidate] (761.525 µs) : 0, 762
Telemetry [baseline] (10.942 ms) : 0, 10942
Telemetry [candidate] (12.015 ms) : 0, 12015
IAST [baseline] (25.449 ms) : 0, 25449
IAST [candidate] (26.592 ms) : 0, 26592
section iast
BytebuddyAgent [baseline] (1.153 s) : 0, 1152762
BytebuddyAgent [candidate] (1.148 s) : 0, 1148263
GlobalTracer [baseline] (437.416 ms) : 0, 437416
GlobalTracer [candidate] (435.258 ms) : 0, 435258
AppSec [baseline] (74.255 ms) : 0, 74255
AppSec [candidate] (71.984 ms) : 0, 71984
Remote Config [baseline] (749.297 µs) : 0, 749
Remote Config [candidate] (748.412 µs) : 0, 748
Telemetry [baseline] (9.27 ms) : 0, 9270
Telemetry [candidate] (10.938 ms) : 0, 10938
IAST [baseline] (29.234 ms) : 0, 29234
IAST [candidate] (30.22 ms) : 0, 30220
section profiling
ProfilingAgent [baseline] (152.442 ms) : 0, 152442
ProfilingAgent [candidate] (151.336 ms) : 0, 151336
BytebuddyAgent [baseline] (987.149 ms) : 0, 987149
BytebuddyAgent [candidate] (985.095 ms) : 0, 985095
GlobalTracer [baseline] (586.526 ms) : 0, 586526
GlobalTracer [candidate] (583.752 ms) : 0, 583752
AppSec [baseline] (73.835 ms) : 0, 73835
AppSec [candidate] (73.676 ms) : 0, 73676
Remote Config [baseline] (890.111 µs) : 0, 890
Remote Config [candidate] (901.388 µs) : 0, 901
Telemetry [baseline] (9.506 ms) : 0, 9506
Telemetry [candidate] (9.402 ms) : 0, 9402
Profiling [baseline] (152.512 ms) : 0, 152512
Profiling [candidate] (151.414 ms) : 0, 151414
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~2c1072d202, baseline=1.39.0-SNAPSHOT~0720a7754a
dateFormat X
axisFormat %s
section baseline
no_agent (370.547 µs) : 351, 390
. : milestone, 371,
iast (481.389 µs) : 459, 504
. : milestone, 481,
iast_FULL (555.064 µs) : 532, 578
. : milestone, 555,
iast_GLOBAL (516.308 µs) : 493, 540
. : milestone, 516,
iast_HARDCODED_SECRET_DISABLED (486.526 µs) : 464, 509
. : milestone, 487,
iast_INACTIVE (442.61 µs) : 422, 463
. : milestone, 443,
iast_TELEMETRY_OFF (468.009 µs) : 447, 489
. : milestone, 468,
tracing (441.897 µs) : 421, 463
. : milestone, 442,
section candidate
no_agent (364.535 µs) : 345, 384
. : milestone, 365,
iast (484.667 µs) : 460, 509
. : milestone, 485,
iast_FULL (544.878 µs) : 523, 567
. : milestone, 545,
iast_GLOBAL (500.79 µs) : 478, 523
. : milestone, 501,
iast_HARDCODED_SECRET_DISABLED (478.811 µs) : 457, 501
. : milestone, 479,
iast_INACTIVE (440.676 µs) : 420, 461
. : milestone, 441,
iast_TELEMETRY_OFF (473.15 µs) : 452, 495
. : milestone, 473,
tracing (438.264 µs) : 418, 459
. : milestone, 438,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~2c1072d202, baseline=1.39.0-SNAPSHOT~0720a7754a
dateFormat X
axisFormat %s
section baseline
no_agent (1.34 ms) : 1321, 1360
. : milestone, 1340,
appsec (1.733 ms) : 1709, 1757
. : milestone, 1733,
appsec_no_iast (1.715 ms) : 1691, 1740
. : milestone, 1715,
iast (1.451 ms) : 1429, 1474
. : milestone, 1451,
profiling (1.48 ms) : 1455, 1504
. : milestone, 1480,
tracing (1.467 ms) : 1443, 1492
. : milestone, 1467,
section candidate
no_agent (1.348 ms) : 1329, 1367
. : milestone, 1348,
appsec (1.727 ms) : 1704, 1751
. : milestone, 1727,
appsec_no_iast (1.704 ms) : 1679, 1729
. : milestone, 1704,
iast (1.463 ms) : 1440, 1485
. : milestone, 1463,
profiling (1.488 ms) : 1462, 1514
. : milestone, 1488,
tracing (1.458 ms) : 1434, 1481
. : milestone, 1458,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~2c1072d202, baseline=1.39.0-SNAPSHOT~0720a7754a
dateFormat X
axisFormat %s
section baseline
no_agent (1.46 ms) : 1449, 1472
. : milestone, 1460,
appsec (2.215 ms) : 2180, 2249
. : milestone, 2215,
iast (1.961 ms) : 1919, 2004
. : milestone, 1961,
iast_GLOBAL (2.015 ms) : 1971, 2059
. : milestone, 2015,
profiling (1.847 ms) : 1812, 1882
. : milestone, 1847,
tracing (1.835 ms) : 1801, 1868
. : milestone, 1835,
section candidate
no_agent (1.456 ms) : 1445, 1467
. : milestone, 1456,
appsec (2.216 ms) : 2181, 2251
. : milestone, 2216,
iast (1.978 ms) : 1936, 2021
. : milestone, 1978,
iast_GLOBAL (2.027 ms) : 1983, 2071
. : milestone, 2027,
profiling (1.854 ms) : 1819, 1889
. : milestone, 1854,
tracing (1.837 ms) : 1804, 1870
. : milestone, 1837,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~2c1072d202, baseline=1.39.0-SNAPSHOT~0720a7754a
dateFormat X
axisFormat %s
section baseline
no_agent (15.226 s) : 15226000, 15226000
. : milestone, 15226000,
appsec (15.195 s) : 15195000, 15195000
. : milestone, 15195000,
iast (18.582 s) : 18582000, 18582000
. : milestone, 18582000,
iast_GLOBAL (17.994 s) : 17994000, 17994000
. : milestone, 17994000,
profiling (15.005 s) : 15005000, 15005000
. : milestone, 15005000,
tracing (14.942 s) : 14942000, 14942000
. : milestone, 14942000,
section candidate
no_agent (15.286 s) : 15286000, 15286000
. : milestone, 15286000,
appsec (14.888 s) : 14888000, 14888000
. : milestone, 14888000,
iast (18.743 s) : 18743000, 18743000
. : milestone, 18743000,
iast_GLOBAL (17.652 s) : 17652000, 17652000
. : milestone, 17652000,
profiling (15.198 s) : 15198000, 15198000
. : milestone, 15198000,
tracing (14.915 s) : 14915000, 14915000
. : milestone, 14915000,
|
PerfectSlayer
approved these changes
Aug 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.