Skip to content

OpenTelemetry drop-in fixes for Armeria HTTP#7498

Merged
mcculls merged 1 commit intomasterfrom
mcculls/otel-dropin-armeria-mapping
Aug 23, 2024
Merged

OpenTelemetry drop-in fixes for Armeria HTTP#7498
mcculls merged 1 commit intomasterfrom
mcculls/otel-dropin-armeria-mapping

Conversation

@mcculls
Copy link
Copy Markdown
Contributor

@mcculls mcculls commented Aug 23, 2024 •
edited by atlassian Bot
Loading

  • Include OTel instrumentation-api incubator types for HTTP
  • Include OTel api incubator types for metrics

Jira ticket: APMS-13078

@mcculls
OpenTelemetry drop-in fixes for Armeria HTTP
915b090 
* Include OTel instrumentation-api incubator types for HTTP
* Include OTel api incubator types for metrics
@mcculls mcculls added inst: armeria Armeria Instrumentation inst: opentelemetry OpenTelemetry instrumentation labels Aug 23, 2024
@mcculls mcculls marked this pull request as ready for review August 23, 2024 13:30
@mcculls mcculls requested a review from a team as a code owner August 23, 2024 13:30
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Aug 23, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/otel-dropin-armeria-mapping
git_commit_date 1724414464 1724415144
git_commit_sha 0720a77 915b090
release_version 1.39.0-SNAPSHOT~0720a7754a 1.39.0-SNAPSHOT~915b0906d0
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1724422031 1724422031
ci_job_id 615230650 615230650
ci_pipeline_id 42677608 42677608
cpu_model Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~915b0906d0, baseline=1.39.0-SNAPSHOT~0720a7754a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.55 s) : 0, 1550234
Total [baseline] (14.311 s) : 0, 14311309
Agent [candidate] (1.547 s) : 0, 1546520
Total [candidate] (14.322 s) : 0, 14321515
section appsec
Agent [baseline] (1.739 s) : 0, 1739137
Total [baseline] (14.462 s) : 0, 14461554
Agent [candidate] (1.739 s) : 0, 1738924
Total [candidate] (14.36 s) : 0, 14359563
section iast
Agent [baseline] (1.721 s) : 0, 1720775
Total [baseline] (14.847 s) : 0, 14847048
Agent [candidate] (1.725 s) : 0, 1725487
Total [candidate] (14.988 s) : 0, 14987737
section profiling
Agent [baseline] (1.862 s) : 0, 1861616
Total [baseline] (14.648 s) : 0, 14648437
Agent [candidate] (1.864 s) : 0, 1863550
Total [candidate] (14.618 s) : 0, 14617717
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.55 s -
Agent appsec 1.739 s 188.903 ms (12.2%)
Agent iast 1.721 s 170.541 ms (11.0%)
Agent profiling 1.862 s 311.383 ms (20.1%)
Total tracing 14.311 s -
Total appsec 14.462 s 150.245 ms (1.0%)
Total iast 14.847 s 535.739 ms (3.7%)
Total profiling 14.648 s 337.128 ms (2.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.547 s -
Agent appsec 1.739 s 192.405 ms (12.4%)
Agent iast 1.725 s 178.967 ms (11.6%)
Agent profiling 1.864 s 317.03 ms (20.5%)
Total tracing 14.322 s -
Total appsec 14.36 s 38.048 ms (0.3%)
Total iast 14.988 s 666.222 ms (4.7%)
Total profiling 14.618 s 296.202 ms (2.1%) 
gantt
    title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~915b0906d0, baseline=1.39.0-SNAPSHOT~0720a7754a

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (993.193 ms) : 0, 993193
BytebuddyAgent [candidate] (990.37 ms) : 0, 990370
GlobalTracer [baseline] (454.206 ms) : 0, 454206
GlobalTracer [candidate] (453.256 ms) : 0, 453256
AppSec [baseline] (72.253 ms) : 0, 72253
AppSec [candidate] (72.309 ms) : 0, 72309
Remote Config [baseline] (819.863 µs) : 0, 820
Remote Config [candidate] (820.355 µs) : 0, 820
Telemetry [baseline] (9.724 ms) : 0, 9724
Telemetry [candidate] (9.722 ms) : 0, 9722
section appsec
BytebuddyAgent [baseline] (1.011 s) : 0, 1010624
BytebuddyAgent [candidate] (1.011 s) : 0, 1011473
GlobalTracer [baseline] (448.742 ms) : 0, 448742
GlobalTracer [candidate] (448.759 ms) : 0, 448759
AppSec [baseline] (235.11 ms) : 0, 235110
AppSec [candidate] (235.29 ms) : 0, 235290
Remote Config [baseline] (754.948 µs) : 0, 755
Remote Config [candidate] (759.614 µs) : 0, 760
Telemetry [baseline] (10.146 ms) : 0, 10146
Telemetry [candidate] (9.521 ms) : 0, 9521
IAST [baseline] (27.514 ms) : 0, 27514
IAST [candidate] (26.024 ms) : 0, 26024
section iast
BytebuddyAgent [baseline] (1.151 s) : 0, 1150981
BytebuddyAgent [candidate] (1.154 s) : 0, 1154357
GlobalTracer [baseline] (436.694 ms) : 0, 436694
GlobalTracer [candidate] (437.31 ms) : 0, 437310
AppSec [baseline] (70.718 ms) : 0, 70718
AppSec [candidate] (73.685 ms) : 0, 73685
Remote Config [baseline] (747.415 µs) : 0, 747
Remote Config [candidate] (728.684 µs) : 0, 729
Telemetry [baseline] (9.313 ms) : 0, 9313
Telemetry [candidate] (9.225 ms) : 0, 9225
IAST [baseline] (32.268 ms) : 0, 32268
IAST [candidate] (29.993 ms) : 0, 29993
section profiling
BytebuddyAgent [baseline] (986.302 ms) : 0, 986302
BytebuddyAgent [candidate] (984.89 ms) : 0, 984890
GlobalTracer [baseline] (584.798 ms) : 0, 584798
GlobalTracer [candidate] (585.542 ms) : 0, 585542
AppSec [baseline] (73.685 ms) : 0, 73685
AppSec [candidate] (73.828 ms) : 0, 73828
Remote Config [baseline] (896.243 µs) : 0, 896
Remote Config [candidate] (892.901 µs) : 0, 893
Telemetry [baseline] (9.406 ms) : 0, 9406
Telemetry [candidate] (9.358 ms) : 0, 9358
ProfilingAgent [baseline] (150.724 ms) : 0, 150724
ProfilingAgent [candidate] (153.213 ms) : 0, 153213
Profiling [baseline] (150.808 ms) : 0, 150808
Profiling [candidate] (153.281 ms) : 0, 153281
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~915b0906d0, baseline=1.39.0-SNAPSHOT~0720a7754a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.551 s) : 0, 1550562
Total [baseline] (11.802 s) : 0, 11802328
Agent [candidate] (1.548 s) : 0, 1548077
Total [candidate] (11.803 s) : 0, 11802746
section iast
Agent [baseline] (1.723 s) : 0, 1723485
Total [baseline] (12.49 s) : 0, 12489957
Agent [candidate] (1.714 s) : 0, 1713904
Total [candidate] (12.494 s) : 0, 12493795
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.718 s) : 0, 1717584
Total [baseline] (12.468 s) : 0, 12468419
Agent [candidate] (1.723 s) : 0, 1723446
Total [candidate] (12.439 s) : 0, 12439283
section iast_TELEMETRY_OFF
Agent [baseline] (1.714 s) : 0, 1713693
Total [baseline] (12.491 s) : 0, 12491180
Agent [candidate] (1.712 s) : 0, 1712143
Total [candidate] (12.462 s) : 0, 12461688
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.551 s -
Agent iast 1.723 s 172.923 ms (11.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.718 s 167.022 ms (10.8%)
Agent iast_TELEMETRY_OFF 1.714 s 163.131 ms (10.5%)
Total tracing 11.802 s -
Total iast 12.49 s 687.629 ms (5.8%)
Total iast_HARDCODED_SECRET_DISABLED 12.468 s 666.091 ms (5.6%)
Total iast_TELEMETRY_OFF 12.491 s 688.852 ms (5.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.548 s -
Agent iast 1.714 s 165.828 ms (10.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.723 s 175.369 ms (11.3%)
Agent iast_TELEMETRY_OFF 1.712 s 164.066 ms (10.6%)
Total tracing 11.803 s -
Total iast 12.494 s 691.049 ms (5.9%)
Total iast_HARDCODED_SECRET_DISABLED 12.439 s 636.537 ms (5.4%)
Total iast_TELEMETRY_OFF 12.462 s 658.942 ms (5.6%) 
gantt
    title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~915b0906d0, baseline=1.39.0-SNAPSHOT~0720a7754a

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (993.439 ms) : 0, 993439
BytebuddyAgent [candidate] (991.87 ms) : 0, 991870
GlobalTracer [baseline] (453.873 ms) : 0, 453873
GlobalTracer [candidate] (453.209 ms) : 0, 453209
AppSec [baseline] (72.506 ms) : 0, 72506
AppSec [candidate] (72.351 ms) : 0, 72351
Remote Config [baseline] (834.091 µs) : 0, 834
Remote Config [candidate] (821.276 µs) : 0, 821
Telemetry [baseline] (9.838 ms) : 0, 9838
Telemetry [candidate] (9.771 ms) : 0, 9771
section iast
BytebuddyAgent [baseline] (1.153 s) : 0, 1152531
BytebuddyAgent [candidate] (1.148 s) : 0, 1147536
GlobalTracer [baseline] (436.77 ms) : 0, 436770
GlobalTracer [candidate] (434.624 ms) : 0, 434624
AppSec [baseline] (73.043 ms) : 0, 73043
AppSec [candidate] (71.628 ms) : 0, 71628
IAST [baseline] (28.538 ms) : 0, 28538
IAST [candidate] (29.074 ms) : 0, 29074
Remote Config [baseline] (748.472 µs) : 0, 748
Remote Config [candidate] (738.836 µs) : 0, 739
Telemetry [baseline] (11.763 ms) : 0, 11763
Telemetry [candidate] (10.2 ms) : 0, 10200
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (1.148 s) : 0, 1147781
BytebuddyAgent [candidate] (1.153 s) : 0, 1153075
GlobalTracer [baseline] (435.897 ms) : 0, 435897
GlobalTracer [candidate] (437.578 ms) : 0, 437578
AppSec [baseline] (72.108 ms) : 0, 72108
AppSec [candidate] (71.463 ms) : 0, 71463
IAST [baseline] (30.151 ms) : 0, 30151
IAST [candidate] (29.48 ms) : 0, 29480
Remote Config [baseline] (735.429 µs) : 0, 735
Remote Config [candidate] (747.667 µs) : 0, 748
Telemetry [baseline] (10.851 ms) : 0, 10851
Telemetry [candidate] (10.921 ms) : 0, 10921
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (1.144 s) : 0, 1144496
BytebuddyAgent [candidate] (1.145 s) : 0, 1144723
GlobalTracer [baseline] (436.266 ms) : 0, 436266
GlobalTracer [candidate] (435.427 ms) : 0, 435427
AppSec [baseline] (71.971 ms) : 0, 71971
AppSec [candidate] (70.841 ms) : 0, 70841
IAST [baseline] (30.163 ms) : 0, 30163
IAST [candidate] (28.737 ms) : 0, 28737
Remote Config [baseline] (785.315 µs) : 0, 785
Remote Config [candidate] (726.775 µs) : 0, 727
Telemetry [baseline] (9.974 ms) : 0, 9974
Telemetry [candidate] (11.6 ms) : 0, 11600
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-08-23T13:26:41 2024-08-23T13:35:40
git_branch master mcculls/otel-dropin-armeria-mapping
git_commit_date 1724414464 1724415144
git_commit_sha 0720a77 915b090
release_version 1.39.0-SNAPSHOT~0720a7754a 1.39.0-SNAPSHOT~915b0906d0
start_time 2024-08-23T13:26:25 2024-08-23T13:35:24
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1724420597 1724420597
ci_job_id 615230651 615230651
ci_pipeline_id 42677608 42677608
cpu_model Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 5 metrics, 22 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:profiling worse
[+46.035µs; +140.517µs] or [+2.428%; +7.413%]		 unstable
[-450.618op/s; +299.103op/s] or [-18.025%; +11.964%]		 1.989ms 2424.242op/s 1.896ms 2500.000op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~915b0906d0, baseline=1.39.0-SNAPSHOT~0720a7754a
    dateFormat X
    axisFormat %s
section baseline
no_agent (447.293 µs) : 418, 476
.   : milestone, 447,
iast (583.025 µs) : 551, 615
.   : milestone, 583,
iast_FULL (683.085 µs) : 650, 716
.   : milestone, 683,
iast_GLOBAL (610.124 µs) : 578, 643
.   : milestone, 610,
iast_HARDCODED_SECRET_DISABLED (581.9 µs) : 549, 615
.   : milestone, 582,
iast_INACTIVE (539.864 µs) : 509, 571
.   : milestone, 540,
iast_TELEMETRY_OFF (577.102 µs) : 545, 609
.   : milestone, 577,
tracing (534.334 µs) : 504, 564
.   : milestone, 534,
section candidate
no_agent (449.437 µs) : 421, 478
.   : milestone, 449,
iast (587.154 µs) : 554, 620
.   : milestone, 587,
iast_FULL (683.76 µs) : 650, 717
.   : milestone, 684,
iast_GLOBAL (626.183 µs) : 593, 659
.   : milestone, 626,
iast_HARDCODED_SECRET_DISABLED (582.796 µs) : 550, 616
.   : milestone, 583,
iast_INACTIVE (541.429 µs) : 511, 572
.   : milestone, 541,
iast_TELEMETRY_OFF (576.498 µs) : 543, 610
.   : milestone, 576,
tracing (534.835 µs) : 505, 565
.   : milestone, 535,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 447.293 µs [418.498 µs, 476.088 µs] -
iast 583.025 µs [550.561 µs, 615.488 µs] 135.731 µs (30.3%)
iast_FULL 683.085 µs [650.186 µs, 715.983 µs] 235.791 µs (52.7%)
iast_GLOBAL 610.124 µs [577.682 µs, 642.566 µs] 162.831 µs (36.4%)
iast_HARDCODED_SECRET_DISABLED 581.9 µs [548.866 µs, 614.933 µs] 134.606 µs (30.1%)
iast_INACTIVE 539.864 µs [509.098 µs, 570.63 µs] 92.571 µs (20.7%)
iast_TELEMETRY_OFF 577.102 µs [544.973 µs, 609.23 µs] 129.808 µs (29.0%)
tracing 534.334 µs [504.482 µs, 564.187 µs] 87.041 µs (19.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 449.437 µs [420.548 µs, 478.325 µs] -
iast 587.154 µs [553.919 µs, 620.389 µs] 137.717 µs (30.6%)
iast_FULL 683.76 µs [650.491 µs, 717.029 µs] 234.323 µs (52.1%)
iast_GLOBAL 626.183 µs [593.331 µs, 659.034 µs] 176.746 µs (39.3%)
iast_HARDCODED_SECRET_DISABLED 582.796 µs [549.787 µs, 615.806 µs] 133.359 µs (29.7%)
iast_INACTIVE 541.429 µs [511.251 µs, 571.607 µs] 91.992 µs (20.5%)
iast_TELEMETRY_OFF 576.498 µs [543.357 µs, 609.64 µs] 127.061 µs (28.3%)
tracing 534.835 µs [504.781 µs, 564.889 µs] 85.398 µs (19.0%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~915b0906d0, baseline=1.39.0-SNAPSHOT~0720a7754a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.704 ms) : 1679, 1729
.   : milestone, 1704,
appsec (2.178 ms) : 2147, 2209
.   : milestone, 2178,
appsec_no_iast (2.158 ms) : 2127, 2190
.   : milestone, 2158,
iast (1.905 ms) : 1876, 1935
.   : milestone, 1905,
profiling (1.896 ms) : 1863, 1929
.   : milestone, 1896,
tracing (1.896 ms) : 1865, 1928
.   : milestone, 1896,
section candidate
no_agent (1.704 ms) : 1679, 1729
.   : milestone, 1704,
appsec (2.168 ms) : 2136, 2200
.   : milestone, 2168,
appsec_no_iast (2.197 ms) : 2166, 2229
.   : milestone, 2197,
iast (1.858 ms) : 1828, 1887
.   : milestone, 1858,
profiling (1.989 ms) : 1936, 2041
.   : milestone, 1989,
tracing (1.856 ms) : 1823, 1889
.   : milestone, 1856,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.704 ms [1.679 ms, 1.729 ms] -
appsec 2.178 ms [2.147 ms, 2.209 ms] 474.467 µs (27.8%)
appsec_no_iast 2.158 ms [2.127 ms, 2.19 ms] 454.345 µs (26.7%)
iast 1.905 ms [1.876 ms, 1.935 ms] 201.454 µs (11.8%)
profiling 1.896 ms [1.863 ms, 1.929 ms] 191.93 µs (11.3%)
tracing 1.896 ms [1.865 ms, 1.928 ms] 192.499 µs (11.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.704 ms [1.679 ms, 1.729 ms] -
appsec 2.168 ms [2.136 ms, 2.2 ms] 463.542 µs (27.2%)
appsec_no_iast 2.197 ms [2.166 ms, 2.229 ms] 493.345 µs (29.0%)
iast 1.858 ms [1.828 ms, 1.887 ms] 153.445 µs (9.0%)
profiling 1.989 ms [1.936 ms, 2.041 ms] 284.811 µs (16.7%)
tracing 1.856 ms [1.823 ms, 1.889 ms] 152.129 µs (8.9%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/otel-dropin-armeria-mapping
git_commit_date 1724414464 1724415144
git_commit_sha 0720a77 915b090
release_version 1.39.0-SNAPSHOT~0720a7754a 1.39.0-SNAPSHOT~915b0906d0
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1724420866 1724420866
ci_job_id 615230652 615230652
ci_pipeline_id 42677608 42677608
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~915b0906d0, baseline=1.39.0-SNAPSHOT~0720a7754a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.453 ms) : 1442, 1464
.   : milestone, 1453,
appsec (2.229 ms) : 2193, 2265
.   : milestone, 2229,
iast (1.964 ms) : 1921, 2006
.   : milestone, 1964,
iast_GLOBAL (2.018 ms) : 1974, 2063
.   : milestone, 2018,
profiling (1.86 ms) : 1824, 1896
.   : milestone, 1860,
tracing (1.835 ms) : 1802, 1868
.   : milestone, 1835,
section candidate
no_agent (1.451 ms) : 1440, 1462
.   : milestone, 1451,
appsec (2.214 ms) : 2179, 2250
.   : milestone, 2214,
iast (1.965 ms) : 1922, 2007
.   : milestone, 1965,
iast_GLOBAL (2.002 ms) : 1959, 2045
.   : milestone, 2002,
profiling (1.854 ms) : 1818, 1889
.   : milestone, 1854,
tracing (1.825 ms) : 1792, 1857
.   : milestone, 1825,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.453 ms [1.442 ms, 1.464 ms] -
appsec 2.229 ms [2.193 ms, 2.265 ms] 776.057 µs (53.4%)
iast 1.964 ms [1.921 ms, 2.006 ms] 510.604 µs (35.1%)
iast_GLOBAL 2.018 ms [1.974 ms, 2.063 ms] 565.29 µs (38.9%)
profiling 1.86 ms [1.824 ms, 1.896 ms] 407.23 µs (28.0%)
tracing 1.835 ms [1.802 ms, 1.868 ms] 382.136 µs (26.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.451 ms [1.44 ms, 1.462 ms] -
appsec 2.214 ms [2.179 ms, 2.25 ms] 763.008 µs (52.6%)
iast 1.965 ms [1.922 ms, 2.007 ms] 513.453 µs (35.4%)
iast_GLOBAL 2.002 ms [1.959 ms, 2.045 ms] 550.803 µs (38.0%)
profiling 1.854 ms [1.818 ms, 1.889 ms] 402.391 µs (27.7%)
tracing 1.825 ms [1.792 ms, 1.857 ms] 373.697 µs (25.8%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~915b0906d0, baseline=1.39.0-SNAPSHOT~0720a7754a
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.195 s) : 15195000, 15195000
.   : milestone, 15195000,
appsec (15.19 s) : 15190000, 15190000
.   : milestone, 15190000,
iast (19.584 s) : 19584000, 19584000
.   : milestone, 19584000,
iast_GLOBAL (17.884 s) : 17884000, 17884000
.   : milestone, 17884000,
profiling (15.175 s) : 15175000, 15175000
.   : milestone, 15175000,
tracing (15.235 s) : 15235000, 15235000
.   : milestone, 15235000,
section candidate
no_agent (15.398 s) : 15398000, 15398000
.   : milestone, 15398000,
appsec (15.115 s) : 15115000, 15115000
.   : milestone, 15115000,
iast (18.938 s) : 18938000, 18938000
.   : milestone, 18938000,
iast_GLOBAL (18.022 s) : 18022000, 18022000
.   : milestone, 18022000,
profiling (15.244 s) : 15244000, 15244000
.   : milestone, 15244000,
tracing (15.148 s) : 15148000, 15148000
.   : milestone, 15148000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.195 s [15.195 s, 15.195 s] -
appsec 15.19 s [15.19 s, 15.19 s] -5.0 ms (-0.0%)
iast 19.584 s [19.584 s, 19.584 s] 4.389 s (28.9%)
iast_GLOBAL 17.884 s [17.884 s, 17.884 s] 2.689 s (17.7%)
profiling 15.175 s [15.175 s, 15.175 s] -20.0 ms (-0.1%)
tracing 15.235 s [15.235 s, 15.235 s] 40.0 ms (0.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.398 s [15.398 s, 15.398 s] -
appsec 15.115 s [15.115 s, 15.115 s] -283.0 ms (-1.8%)
iast 18.938 s [18.938 s, 18.938 s] 3.54 s (23.0%)
iast_GLOBAL 18.022 s [18.022 s, 18.022 s] 2.624 s (17.0%)
profiling 15.244 s [15.244 s, 15.244 s] -154.0 ms (-1.0%)
tracing 15.148 s [15.148 s, 15.148 s] -250.0 ms (-1.6%)

PerfectSlayer
PerfectSlayer approved these changes Aug 23, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the customer would have to disable or own instrumentation first?

@mcculls
Copy link
Copy Markdown
Contributor Author

mcculls commented Aug 23, 2024

@PerfectSlayer our current instrumentation is limited to jetty-armeria, with the spans being created by the native jetty integration. Users installing the OTel armeria instrumentation without Jetty will not need to disable anything, while those using it with Jetty may decide to disable the jetty spans (they won't conflict with the OTel instrumentation but may not provide much additional value.)

@mcculls mcculls merged commit 5e1a552 into master Aug 23, 2024
@mcculls mcculls deleted the mcculls/otel-dropin-armeria-mapping branch August 23, 2024 14:57
@github-actions github-actions Bot added this to the 1.39.0 milestone Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@amarziali amarziali amarziali approved these changes

@dougqh dougqh Awaiting requested review from dougqh dougqh was automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

inst: armeria Armeria Instrumentation inst: opentelemetry OpenTelemetry instrumentation

Projects

None yet

Milestone

1.39.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mcculls @PerfectSlayer @amarziali