Skip to content

Suppress internal exceptions in tomcat stacktrace leak detection#7488

Merged
smola merged 1 commit intomasterfrom
smola/suppress-exceptions-on-tomcat-stacktraceleak-advice
Aug 22, 2024
Merged

Suppress internal exceptions in tomcat stacktrace leak detection#7488
smola merged 1 commit intomasterfrom
smola/suppress-exceptions-on-tomcat-stacktraceleak-advice

Conversation

@smola
Copy link
Copy Markdown
Member

@smola smola commented Aug 22, 2024

What Does This Do

Suppress internal exceptions from ErrorReportValueAdvice.

Motivation

Unclear if this has ever happened, but there's a support case where this could be the case and we do not have any debug logs.

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@smola smola added type: enhancement Enhancements and improvements comp: asm iast Application Security Management (IAST) labels Aug 22, 2024
@smola smola changed the title Suppress internal exceptions in tomcat stacktraceleak detection Suppress internal exceptions in tomcat stacktrace leak detection Aug 22, 2024
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Aug 22, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master smola/suppress-exceptions-on-tomcat-stacktraceleak-advice
git_commit_date 1724310250 1724312701
git_commit_sha 594a2a4 b440771
release_version 1.39.0-SNAPSHOT~594a2a4428 1.39.0-SNAPSHOT~b440771f38
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1724314976 1724314976
ci_job_id 613281159 613281159
ci_pipeline_id 42529038 42529038
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 15 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~b440771f38, baseline=1.39.0-SNAPSHOT~594a2a4428

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1049284
Total [baseline] (8.5 s) : 0, 8500040
Agent [candidate] (1.057 s) : 0, 1056969
Total [candidate] (8.522 s) : 0, 8522338
section iast
Agent [baseline] (1.17 s) : 0, 1170070
Total [baseline] (8.988 s) : 0, 8988498
Agent [candidate] (1.175 s) : 0, 1174712
Total [candidate] (8.955 s) : 0, 8954514
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.172 s) : 0, 1171715
Total [baseline] (8.937 s) : 0, 8937170
Agent [candidate] (1.179 s) : 0, 1179259
Total [candidate] (8.977 s) : 0, 8976814
section iast_TELEMETRY_OFF
Agent [baseline] (1.172 s) : 0, 1171659
Total [baseline] (9.006 s) : 0, 9005730
Agent [candidate] (1.17 s) : 0, 1170447
Total [candidate] (8.988 s) : 0, 8987911
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.049 s -
Agent iast 1.17 s 120.787 ms (11.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.172 s 122.432 ms (11.7%)
Agent iast_TELEMETRY_OFF 1.172 s 122.376 ms (11.7%)
Total tracing 8.5 s -
Total iast 8.988 s 488.458 ms (5.7%)
Total iast_HARDCODED_SECRET_DISABLED 8.937 s 437.13 ms (5.1%)
Total iast_TELEMETRY_OFF 9.006 s 505.69 ms (5.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.057 s -
Agent iast 1.175 s 117.743 ms (11.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.179 s 122.29 ms (11.6%)
Agent iast_TELEMETRY_OFF 1.17 s 113.478 ms (10.7%)
Total tracing 8.522 s -
Total iast 8.955 s 432.176 ms (5.1%)
Total iast_HARDCODED_SECRET_DISABLED 8.977 s 454.476 ms (5.3%)
Total iast_TELEMETRY_OFF 8.988 s 465.572 ms (5.5%) 
gantt
    title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~b440771f38, baseline=1.39.0-SNAPSHOT~594a2a4428

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (668.949 ms) : 0, 668949
BytebuddyAgent [candidate] (674.816 ms) : 0, 674816
GlobalTracer [baseline] (307.192 ms) : 0, 307192
GlobalTracer [candidate] (308.632 ms) : 0, 308632
AppSec [baseline] (51.512 ms) : 0, 51512
AppSec [candidate] (51.647 ms) : 0, 51647
Remote Config [baseline] (662.049 µs) : 0, 662
Remote Config [candidate] (664.779 µs) : 0, 665
Telemetry [baseline] (7.532 ms) : 0, 7532
Telemetry [candidate] (7.594 ms) : 0, 7594
section iast
BytebuddyAgent [baseline] (777.983 ms) : 0, 777983
BytebuddyAgent [candidate] (779.531 ms) : 0, 779531
GlobalTracer [baseline] (296.157 ms) : 0, 296157
GlobalTracer [candidate] (297.077 ms) : 0, 297077
AppSec [baseline] (49.371 ms) : 0, 49371
AppSec [candidate] (50.173 ms) : 0, 50173
IAST [baseline] (24.655 ms) : 0, 24655
IAST [candidate] (24.338 ms) : 0, 24338
Remote Config [baseline] (568.282 µs) : 0, 568
Remote Config [candidate] (583.029 µs) : 0, 583
Telemetry [baseline] (7.866 ms) : 0, 7866
Telemetry [candidate] (9.516 ms) : 0, 9516
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (777.912 ms) : 0, 777912
BytebuddyAgent [candidate] (782.673 ms) : 0, 782673
GlobalTracer [baseline] (296.552 ms) : 0, 296552
GlobalTracer [candidate] (298.494 ms) : 0, 298494
AppSec [baseline] (50.882 ms) : 0, 50882
AppSec [candidate] (50.776 ms) : 0, 50776
IAST [baseline] (22.725 ms) : 0, 22725
IAST [candidate] (24.338 ms) : 0, 24338
Remote Config [baseline] (592.457 µs) : 0, 592
Remote Config [candidate] (578.293 µs) : 0, 578
Telemetry [baseline] (9.578 ms) : 0, 9578
Telemetry [candidate] (8.793 ms) : 0, 8793
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (779.942 ms) : 0, 779942
BytebuddyAgent [candidate] (777.843 ms) : 0, 777843
GlobalTracer [baseline] (296.99 ms) : 0, 296990
GlobalTracer [candidate] (297.308 ms) : 0, 297308
AppSec [baseline] (51.099 ms) : 0, 51099
AppSec [candidate] (50.16 ms) : 0, 50160
IAST [baseline] (21.56 ms) : 0, 21560
IAST [candidate] (23.803 ms) : 0, 23803
Remote Config [baseline] (1.314 ms) : 0, 1314
Remote Config [candidate] (586.489 µs) : 0, 586
Telemetry [baseline] (7.221 ms) : 0, 7221
Telemetry [candidate] (7.173 ms) : 0, 7173
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~b440771f38, baseline=1.39.0-SNAPSHOT~594a2a4428

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1049990
Total [baseline] (10.431 s) : 0, 10431077
Agent [candidate] (1.049 s) : 0, 1048643
Total [candidate] (10.379 s) : 0, 10378913
section appsec
Agent [baseline] (1.169 s) : 0, 1168741
Total [baseline] (10.443 s) : 0, 10443109
Agent [candidate] (1.172 s) : 0, 1172152
Total [candidate] (10.51 s) : 0, 10509521
section iast
Agent [baseline] (1.18 s) : 0, 1180236
Total [baseline] (10.838 s) : 0, 10837733
Agent [candidate] (1.172 s) : 0, 1171816
Total [candidate] (10.863 s) : 0, 10862729
section profiling
Agent [baseline] (1.246 s) : 0, 1246258
Total [baseline] (10.58 s) : 0, 10579875
Agent [candidate] (1.249 s) : 0, 1249312
Total [candidate] (10.711 s) : 0, 10710923
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.05 s -
Agent appsec 1.169 s 118.751 ms (11.3%)
Agent iast 1.18 s 130.247 ms (12.4%)
Agent profiling 1.246 s 196.268 ms (18.7%)
Total tracing 10.431 s -
Total appsec 10.443 s 12.032 ms (0.1%)
Total iast 10.838 s 406.657 ms (3.9%)
Total profiling 10.58 s 148.798 ms (1.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.049 s -
Agent appsec 1.172 s 123.509 ms (11.8%)
Agent iast 1.172 s 123.172 ms (11.7%)
Agent profiling 1.249 s 200.668 ms (19.1%)
Total tracing 10.379 s -
Total appsec 10.51 s 130.608 ms (1.3%)
Total iast 10.863 s 483.816 ms (4.7%)
Total profiling 10.711 s 332.01 ms (3.2%) 
gantt
    title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~b440771f38, baseline=1.39.0-SNAPSHOT~594a2a4428

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (669.113 ms) : 0, 669113
BytebuddyAgent [candidate] (668.461 ms) : 0, 668461
GlobalTracer [baseline] (307.538 ms) : 0, 307538
GlobalTracer [candidate] (307.067 ms) : 0, 307067
AppSec [baseline] (51.726 ms) : 0, 51726
AppSec [candidate] (51.478 ms) : 0, 51478
Remote Config [baseline] (667.175 µs) : 0, 667
Remote Config [candidate] (675.75 µs) : 0, 676
Telemetry [baseline] (7.505 ms) : 0, 7505
Telemetry [candidate] (7.477 ms) : 0, 7477
section appsec
BytebuddyAgent [baseline] (678.239 ms) : 0, 678239
BytebuddyAgent [candidate] (680.053 ms) : 0, 680053
GlobalTracer [baseline] (300.081 ms) : 0, 300081
GlobalTracer [candidate] (301.202 ms) : 0, 301202
AppSec [baseline] (156.906 ms) : 0, 156906
AppSec [candidate] (157.265 ms) : 0, 157265
Remote Config [baseline] (605.259 µs) : 0, 605
Remote Config [candidate] (609.007 µs) : 0, 609
Telemetry [baseline] (9.014 ms) : 0, 9014
Telemetry [candidate] (9.982 ms) : 0, 9982
IAST [baseline] (20.807 ms) : 0, 20807
IAST [candidate] (19.042 ms) : 0, 19042
section iast
BytebuddyAgent [baseline] (783.623 ms) : 0, 783623
BytebuddyAgent [candidate] (777.08 ms) : 0, 777080
GlobalTracer [baseline] (298.411 ms) : 0, 298411
GlobalTracer [candidate] (296.719 ms) : 0, 296719
AppSec [baseline] (51.213 ms) : 0, 51213
AppSec [candidate] (50.082 ms) : 0, 50082
Remote Config [baseline] (590.098 µs) : 0, 590
Remote Config [candidate] (572.944 µs) : 0, 573
Telemetry [baseline] (7.12 ms) : 0, 7120
Telemetry [candidate] (9.546 ms) : 0, 9546
IAST [baseline] (25.722 ms) : 0, 25722
IAST [candidate] (24.306 ms) : 0, 24306
section profiling
ProfilingAgent [baseline] (95.5 ms) : 0, 95500
ProfilingAgent [candidate] (95.414 ms) : 0, 95414
BytebuddyAgent [baseline] (663.753 ms) : 0, 663753
BytebuddyAgent [candidate] (665.541 ms) : 0, 665541
GlobalTracer [baseline] (388.915 ms) : 0, 388915
GlobalTracer [candidate] (390.418 ms) : 0, 390418
AppSec [baseline] (52.674 ms) : 0, 52674
AppSec [candidate] (52.504 ms) : 0, 52504
Remote Config [baseline] (694.613 µs) : 0, 695
Remote Config [candidate] (675.566 µs) : 0, 676
Telemetry [baseline] (7.447 ms) : 0, 7447
Telemetry [candidate] (7.399 ms) : 0, 7399
Profiling [baseline] (95.524 ms) : 0, 95524
Profiling [candidate] (95.439 ms) : 0, 95439
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-08-22T07:53:35 2024-08-22T08:00:21
git_branch master smola/suppress-exceptions-on-tomcat-stacktraceleak-advice
git_commit_date 1724310250 1724312701
git_commit_sha 594a2a4 b440771
release_version 1.39.0-SNAPSHOT~594a2a4428 1.39.0-SNAPSHOT~b440771f38
start_time 2024-08-22T07:53:22 2024-08-22T08:00:08
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1724313964 1724313964
ci_job_id 613281160 613281160
ci_pipeline_id 42529038 42529038
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 18 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~b440771f38, baseline=1.39.0-SNAPSHOT~594a2a4428
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.351 ms) : 1331, 1371
.   : milestone, 1351,
appsec (1.724 ms) : 1700, 1747
.   : milestone, 1724,
appsec_no_iast (1.696 ms) : 1672, 1721
.   : milestone, 1696,
iast (1.483 ms) : 1460, 1505
.   : milestone, 1483,
profiling (1.482 ms) : 1458, 1507
.   : milestone, 1482,
tracing (1.431 ms) : 1406, 1456
.   : milestone, 1431,
section candidate
no_agent (1.333 ms) : 1313, 1353
.   : milestone, 1333,
appsec (1.735 ms) : 1712, 1759
.   : milestone, 1735,
appsec_no_iast (1.722 ms) : 1698, 1746
.   : milestone, 1722,
iast (1.451 ms) : 1428, 1474
.   : milestone, 1451,
profiling (1.482 ms) : 1457, 1508
.   : milestone, 1482,
tracing (1.452 ms) : 1427, 1478
.   : milestone, 1452,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.351 ms [1.331 ms, 1.371 ms] -
appsec 1.724 ms [1.7 ms, 1.747 ms] 372.728 µs (27.6%)
appsec_no_iast 1.696 ms [1.672 ms, 1.721 ms] 345.539 µs (25.6%)
iast 1.483 ms [1.46 ms, 1.505 ms] 131.804 µs (9.8%)
profiling 1.482 ms [1.458 ms, 1.507 ms] 131.554 µs (9.7%)
tracing 1.431 ms [1.406 ms, 1.456 ms] 80.185 µs (5.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.333 ms [1.313 ms, 1.353 ms] -
appsec 1.735 ms [1.712 ms, 1.759 ms] 401.91 µs (30.1%)
appsec_no_iast 1.722 ms [1.698 ms, 1.746 ms] 388.22 µs (29.1%)
iast 1.451 ms [1.428 ms, 1.474 ms] 117.417 µs (8.8%)
profiling 1.482 ms [1.457 ms, 1.508 ms] 148.895 µs (11.2%)
tracing 1.452 ms [1.427 ms, 1.478 ms] 118.795 µs (8.9%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~b440771f38, baseline=1.39.0-SNAPSHOT~594a2a4428
    dateFormat X
    axisFormat %s
section baseline
no_agent (360.557 µs) : 341, 380
.   : milestone, 361,
iast (473.297 µs) : 451, 496
.   : milestone, 473,
iast_FULL (541.013 µs) : 519, 563
.   : milestone, 541,
iast_GLOBAL (503.681 µs) : 481, 527
.   : milestone, 504,
iast_HARDCODED_SECRET_DISABLED (481.807 µs) : 459, 504
.   : milestone, 482,
iast_INACTIVE (444.793 µs) : 424, 465
.   : milestone, 445,
iast_TELEMETRY_OFF (464.093 µs) : 443, 486
.   : milestone, 464,
tracing (439.858 µs) : 418, 461
.   : milestone, 440,
section candidate
no_agent (367.448 µs) : 346, 388
.   : milestone, 367,
iast (473.951 µs) : 452, 496
.   : milestone, 474,
iast_FULL (543.638 µs) : 522, 565
.   : milestone, 544,
iast_GLOBAL (500.251 µs) : 478, 522
.   : milestone, 500,
iast_HARDCODED_SECRET_DISABLED (483.251 µs) : 460, 506
.   : milestone, 483,
iast_INACTIVE (429.592 µs) : 409, 450
.   : milestone, 430,
iast_TELEMETRY_OFF (464.764 µs) : 443, 486
.   : milestone, 465,
tracing (441.658 µs) : 422, 462
.   : milestone, 442,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 360.557 µs [340.9 µs, 380.214 µs] -
iast 473.297 µs [451.032 µs, 495.563 µs] 112.74 µs (31.3%)
iast_FULL 541.013 µs [519.237 µs, 562.789 µs] 180.456 µs (50.0%)
iast_GLOBAL 503.681 µs [480.743 µs, 526.618 µs] 143.123 µs (39.7%)
iast_HARDCODED_SECRET_DISABLED 481.807 µs [459.216 µs, 504.397 µs] 121.25 µs (33.6%)
iast_INACTIVE 444.793 µs [424.19 µs, 465.396 µs] 84.236 µs (23.4%)
iast_TELEMETRY_OFF 464.093 µs [442.678 µs, 485.509 µs] 103.536 µs (28.7%)
tracing 439.858 µs [418.405 µs, 461.311 µs] 79.301 µs (22.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 367.448 µs [346.402 µs, 388.494 µs] -
iast 473.951 µs [452.039 µs, 495.863 µs] 106.503 µs (29.0%)
iast_FULL 543.638 µs [521.925 µs, 565.351 µs] 176.19 µs (47.9%)
iast_GLOBAL 500.251 µs [478.034 µs, 522.469 µs] 132.803 µs (36.1%)
iast_HARDCODED_SECRET_DISABLED 483.251 µs [460.386 µs, 506.116 µs] 115.803 µs (31.5%)
iast_INACTIVE 429.592 µs [409.367 µs, 449.816 µs] 62.144 µs (16.9%)
iast_TELEMETRY_OFF 464.764 µs [443.268 µs, 486.26 µs] 97.316 µs (26.5%)
tracing 441.658 µs [421.719 µs, 461.597 µs] 74.21 µs (20.2%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master smola/suppress-exceptions-on-tomcat-stacktraceleak-advice
git_commit_date 1724310250 1724312701
git_commit_sha 594a2a4 b440771
release_version 1.39.0-SNAPSHOT~594a2a4428 1.39.0-SNAPSHOT~b440771f38
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1724314486 1724314486
ci_job_id 613281161 613281161
ci_pipeline_id 42529038 42529038
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~b440771f38, baseline=1.39.0-SNAPSHOT~594a2a4428
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.459 ms) : 1448, 1470
.   : milestone, 1459,
appsec (2.225 ms) : 2190, 2260
.   : milestone, 2225,
iast (1.958 ms) : 1917, 2000
.   : milestone, 1958,
iast_GLOBAL (2.023 ms) : 1980, 2067
.   : milestone, 2023,
profiling (1.852 ms) : 1818, 1886
.   : milestone, 1852,
tracing (1.843 ms) : 1811, 1876
.   : milestone, 1843,
section candidate
no_agent (1.458 ms) : 1447, 1470
.   : milestone, 1458,
appsec (2.227 ms) : 2192, 2262
.   : milestone, 2227,
iast (1.954 ms) : 1913, 1996
.   : milestone, 1954,
iast_GLOBAL (2.015 ms) : 1972, 2059
.   : milestone, 2015,
profiling (1.851 ms) : 1816, 1886
.   : milestone, 1851,
tracing (1.837 ms) : 1804, 1870
.   : milestone, 1837,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.459 ms [1.448 ms, 1.47 ms] -
appsec 2.225 ms [2.19 ms, 2.26 ms] 765.835 µs (52.5%)
iast 1.958 ms [1.917 ms, 2.0 ms] 499.343 µs (34.2%)
iast_GLOBAL 2.023 ms [1.98 ms, 2.067 ms] 564.158 µs (38.7%)
profiling 1.852 ms [1.818 ms, 1.886 ms] 393.078 µs (26.9%)
tracing 1.843 ms [1.811 ms, 1.876 ms] 384.384 µs (26.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.458 ms [1.447 ms, 1.47 ms] -
appsec 2.227 ms [2.192 ms, 2.262 ms] 768.662 µs (52.7%)
iast 1.954 ms [1.913 ms, 1.996 ms] 496.356 µs (34.0%)
iast_GLOBAL 2.015 ms [1.972 ms, 2.059 ms] 556.964 µs (38.2%)
profiling 1.851 ms [1.816 ms, 1.886 ms] 392.852 µs (26.9%)
tracing 1.837 ms [1.804 ms, 1.87 ms] 378.734 µs (26.0%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~b440771f38, baseline=1.39.0-SNAPSHOT~594a2a4428
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.688 s) : 15688000, 15688000
.   : milestone, 15688000,
appsec (15.233 s) : 15233000, 15233000
.   : milestone, 15233000,
iast (18.818 s) : 18818000, 18818000
.   : milestone, 18818000,
iast_GLOBAL (17.849 s) : 17849000, 17849000
.   : milestone, 17849000,
profiling (14.941 s) : 14941000, 14941000
.   : milestone, 14941000,
tracing (15.175 s) : 15175000, 15175000
.   : milestone, 15175000,
section candidate
no_agent (15.458 s) : 15458000, 15458000
.   : milestone, 15458000,
appsec (14.735 s) : 14735000, 14735000
.   : milestone, 14735000,
iast (18.848 s) : 18848000, 18848000
.   : milestone, 18848000,
iast_GLOBAL (17.878 s) : 17878000, 17878000
.   : milestone, 17878000,
profiling (15.794 s) : 15794000, 15794000
.   : milestone, 15794000,
tracing (14.865 s) : 14865000, 14865000
.   : milestone, 14865000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.688 s [15.688 s, 15.688 s] -
appsec 15.233 s [15.233 s, 15.233 s] -455.0 ms (-2.9%)
iast 18.818 s [18.818 s, 18.818 s] 3.13 s (20.0%)
iast_GLOBAL 17.849 s [17.849 s, 17.849 s] 2.161 s (13.8%)
profiling 14.941 s [14.941 s, 14.941 s] -747.0 ms (-4.8%)
tracing 15.175 s [15.175 s, 15.175 s] -513.0 ms (-3.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.458 s [15.458 s, 15.458 s] -
appsec 14.735 s [14.735 s, 14.735 s] -723.0 ms (-4.7%)
iast 18.848 s [18.848 s, 18.848 s] 3.39 s (21.9%)
iast_GLOBAL 17.878 s [17.878 s, 17.878 s] 2.42 s (15.7%)
profiling 15.794 s [15.794 s, 15.794 s] 336.0 ms (2.2%)
tracing 14.865 s [14.865 s, 14.865 s] -593.0 ms (-3.8%)

@smola smola marked this pull request as ready for review August 22, 2024 08:53
@smola smola requested a review from a team as a code owner August 22, 2024 08:53
@smola smola merged commit 44f9079 into master Aug 22, 2024
@smola smola deleted the smola/suppress-exceptions-on-tomcat-stacktraceleak-advice branch August 22, 2024 13:28
smola added a commit that referenced this pull request Aug 22, 2024
@smola
Revert "Suppress internal exceptions in tomcat stacktraceleak detecti…
c84591e 
…on (#7488)"

This reverts commit 44f9079.
@github-actions github-actions Bot added this to the 1.39.0 milestone Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jandro996 jandro996 jandro996 approved these changes

@ValentinZakharov ValentinZakharov Awaiting requested review from ValentinZakharov

Assignees

No one assigned

Labels

comp: asm iast Application Security Management (IAST) type: enhancement Enhancements and improvements

Projects

None yet

Milestone

1.39.0

Development

Successfully merging this pull request may close these issues.

2 participants

@smola @jandro996