Skip to content

Apache http client 4: do not copy all request headers on redirect#7483

Merged
amarziali merged 6 commits intomasterfrom
andrea.marziali/httpheaders
Aug 22, 2024
Merged

Apache http client 4: do not copy all request headers on redirect#7483
amarziali merged 6 commits intomasterfrom
andrea.marziali/httpheaders

Conversation

@amarziali
Copy link
Copy Markdown
Contributor

@amarziali amarziali commented Aug 21, 2024 •
edited
Loading

What Does This Do

This PR avoids copying the original request headers when a redirect happen. The issue here is that the original request may contain headers like Host. In this case, if we copy it on the redirected one, apache http client will keep this one (which might be wrong).
This PR takes the request instead from the context. That request is always a Wrapped request. Having access to the wrapped request we can get the original one that contains only the headers manually added (by the user and by us) but not added by the library itself (i.e. Host, Content-Type, ...)

I also added the tag httpclient-redirect to that instrumentation in order to unplug easily in case of issues

Motivation

Additional Notes

Jira ticket: APMS-12746

@amarziali amarziali requested a review from a team as a code owner August 21, 2024 09:21
@amarziali amarziali added type: bug Bug report and fix inst: others All other instrumentations labels Aug 21, 2024
@amarziali amarziali requested a review from a team as a code owner August 21, 2024 09:58
@amarziali amarziali requested review from dougqh and mcculls August 21, 2024 09:58
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Aug 21, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/httpheaders
git_commit_date 1724321531 1724324163
git_commit_sha 77c6fbe d9adb08
release_version 1.39.0-SNAPSHOT~77c6fbe6b9 1.39.0-SNAPSHOT~d9adb08412
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1724326422 1724326422
ci_job_id 613506754 613506754
ci_pipeline_id 42541462 42541462
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 15 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~d9adb08412, baseline=1.39.0-SNAPSHOT~77c6fbe6b9

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1055121
Total [baseline] (10.42 s) : 0, 10419610
Agent [candidate] (1.048 s) : 0, 1048271
Total [candidate] (10.365 s) : 0, 10364704
section appsec
Agent [baseline] (1.176 s) : 0, 1176105
Total [baseline] (10.513 s) : 0, 10512884
Agent [candidate] (1.176 s) : 0, 1175537
Total [candidate] (10.543 s) : 0, 10542618
section iast
Agent [baseline] (1.173 s) : 0, 1172662
Total [baseline] (10.827 s) : 0, 10826847
Agent [candidate] (1.181 s) : 0, 1181138
Total [candidate] (10.9 s) : 0, 10900048
section profiling
Agent [baseline] (1.246 s) : 0, 1245747
Total [baseline] (10.619 s) : 0, 10619088
Agent [candidate] (1.247 s) : 0, 1247308
Total [candidate] (10.575 s) : 0, 10575234
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.055 s -
Agent appsec 1.176 s 120.983 ms (11.5%)
Agent iast 1.173 s 117.54 ms (11.1%)
Agent profiling 1.246 s 190.625 ms (18.1%)
Total tracing 10.42 s -
Total appsec 10.513 s 93.274 ms (0.9%)
Total iast 10.827 s 407.237 ms (3.9%)
Total profiling 10.619 s 199.477 ms (1.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.048 s -
Agent appsec 1.176 s 127.266 ms (12.1%)
Agent iast 1.181 s 132.867 ms (12.7%)
Agent profiling 1.247 s 199.038 ms (19.0%)
Total tracing 10.365 s -
Total appsec 10.543 s 177.914 ms (1.7%)
Total iast 10.9 s 535.344 ms (5.2%)
Total profiling 10.575 s 210.53 ms (2.0%) 
gantt
    title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~d9adb08412, baseline=1.39.0-SNAPSHOT~77c6fbe6b9

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (673.936 ms) : 0, 673936
BytebuddyAgent [candidate] (667.787 ms) : 0, 667787
GlobalTracer [baseline] (307.497 ms) : 0, 307497
GlobalTracer [candidate] (307.341 ms) : 0, 307341
AppSec [baseline] (51.872 ms) : 0, 51872
AppSec [candidate] (51.524 ms) : 0, 51524
Remote Config [baseline] (671.802 µs) : 0, 672
Remote Config [candidate] (660.59 µs) : 0, 661
Telemetry [baseline] (7.604 ms) : 0, 7604
Telemetry [candidate] (7.476 ms) : 0, 7476
section appsec
BytebuddyAgent [baseline] (682.375 ms) : 0, 682375
BytebuddyAgent [candidate] (681.634 ms) : 0, 681634
GlobalTracer [baseline] (302.512 ms) : 0, 302512
GlobalTracer [candidate] (301.227 ms) : 0, 301227
AppSec [baseline] (157.844 ms) : 0, 157844
AppSec [candidate] (157.777 ms) : 0, 157777
Remote Config [baseline] (614.303 µs) : 0, 614
Remote Config [candidate] (606.617 µs) : 0, 607
Telemetry [baseline] (8.772 ms) : 0, 8772
Telemetry [candidate] (9.283 ms) : 0, 9283
IAST [baseline] (20.935 ms) : 0, 20935
IAST [candidate] (22.901 ms) : 0, 22901
section iast
BytebuddyAgent [baseline] (778.256 ms) : 0, 778256
BytebuddyAgent [candidate] (783.756 ms) : 0, 783756
GlobalTracer [baseline] (296.345 ms) : 0, 296345
GlobalTracer [candidate] (298.909 ms) : 0, 298909
AppSec [baseline] (52.709 ms) : 0, 52709
AppSec [candidate] (52.042 ms) : 0, 52042
Remote Config [baseline] (576.192 µs) : 0, 576
Remote Config [candidate] (598.897 µs) : 0, 599
Telemetry [baseline] (8.784 ms) : 0, 8784
Telemetry [candidate] (11.116 ms) : 0, 11116
IAST [baseline] (22.53 ms) : 0, 22530
IAST [candidate] (21.101 ms) : 0, 21101
section profiling
BytebuddyAgent [baseline] (664.208 ms) : 0, 664208
BytebuddyAgent [candidate] (664.689 ms) : 0, 664689
GlobalTracer [baseline] (389.322 ms) : 0, 389322
GlobalTracer [candidate] (389.388 ms) : 0, 389388
AppSec [baseline] (52.428 ms) : 0, 52428
AppSec [candidate] (52.649 ms) : 0, 52649
Remote Config [baseline] (672.241 µs) : 0, 672
Remote Config [candidate] (687.518 µs) : 0, 688
Telemetry [baseline] (7.354 ms) : 0, 7354
Telemetry [candidate] (7.393 ms) : 0, 7393
ProfilingAgent [baseline] (94.601 ms) : 0, 94601
ProfilingAgent [candidate] (95.29 ms) : 0, 95290
Profiling [baseline] (94.626 ms) : 0, 94626
Profiling [candidate] (95.315 ms) : 0, 95315
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~d9adb08412, baseline=1.39.0-SNAPSHOT~77c6fbe6b9

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1050103
Total [baseline] (8.511 s) : 0, 8511198
Agent [candidate] (1.047 s) : 0, 1047126
Total [candidate] (8.503 s) : 0, 8503489
section iast
Agent [baseline] (1.182 s) : 0, 1181529
Total [baseline] (9.021 s) : 0, 9020590
Agent [candidate] (1.182 s) : 0, 1181963
Total [candidate] (8.995 s) : 0, 8995197
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.192 s) : 0, 1191641
Total [baseline] (9.009 s) : 0, 9009156
Agent [candidate] (1.171 s) : 0, 1170595
Total [candidate] (8.946 s) : 0, 8945794
section iast_TELEMETRY_OFF
Agent [baseline] (1.169 s) : 0, 1168637
Total [baseline] (8.964 s) : 0, 8963685
Agent [candidate] (1.184 s) : 0, 1183991
Total [candidate] (9.025 s) : 0, 9024925
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.05 s -
Agent iast 1.182 s 131.427 ms (12.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.192 s 141.539 ms (13.5%)
Agent iast_TELEMETRY_OFF 1.169 s 118.534 ms (11.3%)
Total tracing 8.511 s -
Total iast 9.021 s 509.392 ms (6.0%)
Total iast_HARDCODED_SECRET_DISABLED 9.009 s 497.958 ms (5.9%)
Total iast_TELEMETRY_OFF 8.964 s 452.487 ms (5.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.047 s -
Agent iast 1.182 s 134.837 ms (12.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.171 s 123.469 ms (11.8%)
Agent iast_TELEMETRY_OFF 1.184 s 136.865 ms (13.1%)
Total tracing 8.503 s -
Total iast 8.995 s 491.709 ms (5.8%)
Total iast_HARDCODED_SECRET_DISABLED 8.946 s 442.305 ms (5.2%)
Total iast_TELEMETRY_OFF 9.025 s 521.436 ms (6.1%) 
gantt
    title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~d9adb08412, baseline=1.39.0-SNAPSHOT~77c6fbe6b9

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (669.966 ms) : 0, 669966
BytebuddyAgent [candidate] (667.818 ms) : 0, 667818
GlobalTracer [baseline] (306.427 ms) : 0, 306427
GlobalTracer [candidate] (306.367 ms) : 0, 306367
AppSec [baseline] (52.004 ms) : 0, 52004
AppSec [candidate] (51.329 ms) : 0, 51329
Remote Config [baseline] (668.423 µs) : 0, 668
Remote Config [candidate] (664.341 µs) : 0, 664
Telemetry [baseline] (7.582 ms) : 0, 7582
Telemetry [candidate] (7.502 ms) : 0, 7502
section iast
BytebuddyAgent [baseline] (785.031 ms) : 0, 785031
BytebuddyAgent [candidate] (783.493 ms) : 0, 783493
GlobalTracer [baseline] (298.55 ms) : 0, 298550
GlobalTracer [candidate] (300.148 ms) : 0, 300148
AppSec [baseline] (49.156 ms) : 0, 49156
AppSec [candidate] (52.083 ms) : 0, 52083
IAST [baseline] (26.743 ms) : 0, 26743
IAST [candidate] (22.557 ms) : 0, 22557
Remote Config [baseline] (577.496 µs) : 0, 577
Remote Config [candidate] (583.46 µs) : 0, 583
Telemetry [baseline] (7.9 ms) : 0, 7900
Telemetry [candidate] (9.519 ms) : 0, 9519
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (791.809 ms) : 0, 791809
BytebuddyAgent [candidate] (776.981 ms) : 0, 776981
GlobalTracer [baseline] (300.97 ms) : 0, 300970
GlobalTracer [candidate] (296.179 ms) : 0, 296179
AppSec [baseline] (51.818 ms) : 0, 51818
AppSec [candidate] (50.306 ms) : 0, 50306
IAST [baseline] (23.065 ms) : 0, 23065
IAST [candidate] (22.599 ms) : 0, 22599
Remote Config [baseline] (608.834 µs) : 0, 609
Remote Config [candidate] (587.27 µs) : 0, 587
Telemetry [baseline] (9.684 ms) : 0, 9684
Telemetry [candidate] (10.463 ms) : 0, 10463
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (776.072 ms) : 0, 776072
BytebuddyAgent [candidate] (787.113 ms) : 0, 787113
GlobalTracer [baseline] (296.681 ms) : 0, 296681
GlobalTracer [candidate] (300.259 ms) : 0, 300259
AppSec [baseline] (50.941 ms) : 0, 50941
AppSec [candidate] (50.828 ms) : 0, 50828
IAST [baseline] (23.828 ms) : 0, 23828
IAST [candidate] (24.277 ms) : 0, 24277
Remote Config [baseline] (579.272 µs) : 0, 579
Remote Config [candidate] (598.166 µs) : 0, 598
Telemetry [baseline] (7.053 ms) : 0, 7053
Telemetry [candidate] (7.275 ms) : 0, 7275
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-08-22T11:04:24 2024-08-22T11:11:15
git_branch master andrea.marziali/httpheaders
git_commit_date 1724321531 1724324163
git_commit_sha 77c6fbe d9adb08
release_version 1.39.0-SNAPSHOT~77c6fbe6b9 1.39.0-SNAPSHOT~d9adb08412
start_time 2024-08-22T11:04:10 2024-08-22T11:11:02
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1724325421 1724325421
ci_job_id 613506755 613506755
ci_pipeline_id 42541462 42541462
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~d9adb08412, baseline=1.39.0-SNAPSHOT~77c6fbe6b9
    dateFormat X
    axisFormat %s
section baseline
no_agent (369.685 µs) : 349, 390
.   : milestone, 370,
iast (487.453 µs) : 464, 511
.   : milestone, 487,
iast_FULL (558.985 µs) : 537, 581
.   : milestone, 559,
iast_GLOBAL (509.04 µs) : 487, 532
.   : milestone, 509,
iast_HARDCODED_SECRET_DISABLED (489.158 µs) : 467, 512
.   : milestone, 489,
iast_INACTIVE (449.683 µs) : 429, 471
.   : milestone, 450,
iast_TELEMETRY_OFF (481.078 µs) : 460, 503
.   : milestone, 481,
tracing (447.751 µs) : 427, 468
.   : milestone, 448,
section candidate
no_agent (374.155 µs) : 353, 395
.   : milestone, 374,
iast (492.736 µs) : 470, 516
.   : milestone, 493,
iast_FULL (555.907 µs) : 534, 578
.   : milestone, 556,
iast_GLOBAL (518.983 µs) : 495, 543
.   : milestone, 519,
iast_HARDCODED_SECRET_DISABLED (483.835 µs) : 462, 505
.   : milestone, 484,
iast_INACTIVE (454.96 µs) : 434, 476
.   : milestone, 455,
iast_TELEMETRY_OFF (477.913 µs) : 457, 499
.   : milestone, 478,
tracing (448.884 µs) : 429, 469
.   : milestone, 449,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 369.685 µs [349.298 µs, 390.073 µs] -
iast 487.453 µs [464.33 µs, 510.576 µs] 117.767 µs (31.9%)
iast_FULL 558.985 µs [537.269 µs, 580.702 µs] 189.3 µs (51.2%)
iast_GLOBAL 509.04 µs [486.552 µs, 531.529 µs] 139.355 µs (37.7%)
iast_HARDCODED_SECRET_DISABLED 489.158 µs [466.524 µs, 511.793 µs] 119.473 µs (32.3%)
iast_INACTIVE 449.683 µs [428.577 µs, 470.788 µs] 79.997 µs (21.6%)
iast_TELEMETRY_OFF 481.078 µs [459.518 µs, 502.637 µs] 111.392 µs (30.1%)
tracing 447.751 µs [427.257 µs, 468.245 µs] 78.066 µs (21.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 374.155 µs [353.045 µs, 395.266 µs] -
iast 492.736 µs [469.906 µs, 515.566 µs] 118.581 µs (31.7%)
iast_FULL 555.907 µs [533.674 µs, 578.141 µs] 181.752 µs (48.6%)
iast_GLOBAL 518.983 µs [495.331 µs, 542.635 µs] 144.828 µs (38.7%)
iast_HARDCODED_SECRET_DISABLED 483.835 µs [462.18 µs, 505.491 µs] 109.68 µs (29.3%)
iast_INACTIVE 454.96 µs [434.162 µs, 475.759 µs] 80.805 µs (21.6%)
iast_TELEMETRY_OFF 477.913 µs [456.957 µs, 498.87 µs] 103.758 µs (27.7%)
tracing 448.884 µs [428.645 µs, 469.124 µs] 74.729 µs (20.0%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~d9adb08412, baseline=1.39.0-SNAPSHOT~77c6fbe6b9
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.349 ms) : 1329, 1369
.   : milestone, 1349,
appsec (1.762 ms) : 1738, 1786
.   : milestone, 1762,
appsec_no_iast (1.729 ms) : 1705, 1753
.   : milestone, 1729,
iast (1.474 ms) : 1452, 1497
.   : milestone, 1474,
profiling (1.524 ms) : 1498, 1550
.   : milestone, 1524,
tracing (1.472 ms) : 1447, 1497
.   : milestone, 1472,
section candidate
no_agent (1.349 ms) : 1330, 1368
.   : milestone, 1349,
appsec (1.729 ms) : 1705, 1753
.   : milestone, 1729,
appsec_no_iast (1.732 ms) : 1707, 1757
.   : milestone, 1732,
iast (1.496 ms) : 1474, 1519
.   : milestone, 1496,
profiling (1.507 ms) : 1481, 1532
.   : milestone, 1507,
tracing (1.474 ms) : 1449, 1498
.   : milestone, 1474,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.349 ms [1.329 ms, 1.369 ms] -
appsec 1.762 ms [1.738 ms, 1.786 ms] 413.22 µs (30.6%)
appsec_no_iast 1.729 ms [1.705 ms, 1.753 ms] 380.017 µs (28.2%)
iast 1.474 ms [1.452 ms, 1.497 ms] 125.456 µs (9.3%)
profiling 1.524 ms [1.498 ms, 1.55 ms] 175.072 µs (13.0%)
tracing 1.472 ms [1.447 ms, 1.497 ms] 123.363 µs (9.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.349 ms [1.33 ms, 1.368 ms] -
appsec 1.729 ms [1.705 ms, 1.753 ms] 380.224 µs (28.2%)
appsec_no_iast 1.732 ms [1.707 ms, 1.757 ms] 382.955 µs (28.4%)
iast 1.496 ms [1.474 ms, 1.519 ms] 147.564 µs (10.9%)
profiling 1.507 ms [1.481 ms, 1.532 ms] 157.982 µs (11.7%)
tracing 1.474 ms [1.449 ms, 1.498 ms] 124.888 µs (9.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/httpheaders
git_commit_date 1724321531 1724324163
git_commit_sha 77c6fbe d9adb08
release_version 1.39.0-SNAPSHOT~77c6fbe6b9 1.39.0-SNAPSHOT~d9adb08412
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1724325969 1724325969
ci_job_id 613506756 613506756
ci_pipeline_id 42541462 42541462
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~d9adb08412, baseline=1.39.0-SNAPSHOT~77c6fbe6b9
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.456 ms) : 1445, 1467
.   : milestone, 1456,
appsec (2.219 ms) : 2184, 2254
.   : milestone, 2219,
iast (1.967 ms) : 1924, 2009
.   : milestone, 1967,
iast_GLOBAL (2.02 ms) : 1976, 2063
.   : milestone, 2020,
profiling (1.843 ms) : 1808, 1878
.   : milestone, 1843,
tracing (1.835 ms) : 1802, 1868
.   : milestone, 1835,
section candidate
no_agent (1.459 ms) : 1447, 1470
.   : milestone, 1459,
appsec (2.228 ms) : 2193, 2264
.   : milestone, 2228,
iast (1.972 ms) : 1930, 2015
.   : milestone, 1972,
iast_GLOBAL (2.017 ms) : 1973, 2061
.   : milestone, 2017,
profiling (1.863 ms) : 1829, 1897
.   : milestone, 1863,
tracing (1.84 ms) : 1807, 1873
.   : milestone, 1840,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.456 ms [1.445 ms, 1.467 ms] -
appsec 2.219 ms [2.184 ms, 2.254 ms] 763.14 µs (52.4%)
iast 1.967 ms [1.924 ms, 2.009 ms] 510.566 µs (35.1%)
iast_GLOBAL 2.02 ms [1.976 ms, 2.063 ms] 563.524 µs (38.7%)
profiling 1.843 ms [1.808 ms, 1.878 ms] 386.886 µs (26.6%)
tracing 1.835 ms [1.802 ms, 1.868 ms] 379.092 µs (26.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.459 ms [1.447 ms, 1.47 ms] -
appsec 2.228 ms [2.193 ms, 2.264 ms] 769.803 µs (52.8%)
iast 1.972 ms [1.93 ms, 2.015 ms] 513.522 µs (35.2%)
iast_GLOBAL 2.017 ms [1.973 ms, 2.061 ms] 558.313 µs (38.3%)
profiling 1.863 ms [1.829 ms, 1.897 ms] 404.196 µs (27.7%)
tracing 1.84 ms [1.807 ms, 1.873 ms] 380.934 µs (26.1%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~d9adb08412, baseline=1.39.0-SNAPSHOT~77c6fbe6b9
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.471 s) : 15471000, 15471000
.   : milestone, 15471000,
appsec (15.01 s) : 15010000, 15010000
.   : milestone, 15010000,
iast (18.843 s) : 18843000, 18843000
.   : milestone, 18843000,
iast_GLOBAL (17.83 s) : 17830000, 17830000
.   : milestone, 17830000,
profiling (15.817 s) : 15817000, 15817000
.   : milestone, 15817000,
tracing (15.14 s) : 15140000, 15140000
.   : milestone, 15140000,
section candidate
no_agent (15.378 s) : 15378000, 15378000
.   : milestone, 15378000,
appsec (15.194 s) : 15194000, 15194000
.   : milestone, 15194000,
iast (18.989 s) : 18989000, 18989000
.   : milestone, 18989000,
iast_GLOBAL (17.802 s) : 17802000, 17802000
.   : milestone, 17802000,
profiling (15.104 s) : 15104000, 15104000
.   : milestone, 15104000,
tracing (14.964 s) : 14964000, 14964000
.   : milestone, 14964000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.471 s [15.471 s, 15.471 s] -
appsec 15.01 s [15.01 s, 15.01 s] -461.0 ms (-3.0%)
iast 18.843 s [18.843 s, 18.843 s] 3.372 s (21.8%)
iast_GLOBAL 17.83 s [17.83 s, 17.83 s] 2.359 s (15.2%)
profiling 15.817 s [15.817 s, 15.817 s] 346.0 ms (2.2%)
tracing 15.14 s [15.14 s, 15.14 s] -331.0 ms (-2.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.378 s [15.378 s, 15.378 s] -
appsec 15.194 s [15.194 s, 15.194 s] -184.0 ms (-1.2%)
iast 18.989 s [18.989 s, 18.989 s] 3.611 s (23.5%)
iast_GLOBAL 17.802 s [17.802 s, 17.802 s] 2.424 s (15.8%)
profiling 15.104 s [15.104 s, 15.104 s] -274.0 ms (-1.8%)
tracing 14.964 s [14.964 s, 14.964 s] -414.0 ms (-2.7%)

@amarziali amarziali marked this pull request as draft August 21, 2024 13:12
@amarziali amarziali force-pushed the andrea.marziali/httpheaders branch from 8598392 to 9549c58 Compare August 22, 2024 08:21
@amarziali amarziali marked this pull request as ready for review August 22, 2024 08:21
@amarziali amarziali force-pushed the andrea.marziali/httpheaders branch from 9549c58 to 8e4c6dd Compare August 22, 2024 08:22
@amarziali amarziali requested a review from mcculls August 22, 2024 08:24
mcculls
mcculls reviewed Aug 22, 2024
View reviewed changes
Comment thread internal-api/src/main/java/datadog/trace/util/PropagationUtils.java
mcculls
mcculls reviewed Aug 22, 2024
View reviewed changes
Comment thread internal-api/src/main/java/datadog/trace/util/PropagationUtils.java Outdated
mcculls
mcculls reviewed Aug 22, 2024
View reviewed changes
Comment thread internal-api/src/main/java/datadog/trace/util/PropagationUtils.java Outdated
mcculls
mcculls reviewed Aug 22, 2024
View reviewed changes
Comment thread internal-api/src/main/java/datadog/trace/util/PropagationUtils.java
mcculls
mcculls reviewed Aug 22, 2024
View reviewed changes
Comment thread internal-api/src/main/java/datadog/trace/util/PropagationUtils.java Outdated
mcculls
mcculls approved these changes Aug 22, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@mcculls mcculls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 just add a comment to KNOWN_PROPAGATION_HEADERS saying that all strings added here must be lowercase - thanks!

@amarziali amarziali enabled auto-merge (squash) August 22, 2024 13:26
@amarziali amarziali merged commit 2cf870d into master Aug 22, 2024
@amarziali amarziali deleted the andrea.marziali/httpheaders branch August 22, 2024 13:34
@github-actions github-actions Bot added this to the 1.39.0 milestone Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcculls mcculls mcculls approved these changes

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@dougqh dougqh Awaiting requested review from dougqh dougqh is a code owner automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

inst: others All other instrumentations type: bug Bug report and fix

Projects

None yet

Milestone

1.39.0

Development

Successfully merging this pull request may close these issues.

3 participants

@amarziali @mcculls @PerfectSlayer