Skip to content

Fix Cucumber JUnit 4 instrumentation to support empty scenario names#7470

Merged
nikita-tkachenko-datadog merged 2 commits intomasterfrom
nikita-tkachenko/cucumber-empty-names
Aug 22, 2024
Merged

Fix Cucumber JUnit 4 instrumentation to support empty scenario names#7470
nikita-tkachenko-datadog merged 2 commits intomasterfrom
nikita-tkachenko/cucumber-empty-names

Conversation

@nikita-tkachenko-datadog
Copy link
Copy Markdown
Contributor

@nikita-tkachenko-datadog nikita-tkachenko-datadog commented Aug 19, 2024 •
edited by atlassian Bot
Loading

What Does This Do

Fixes Cucumber JUnit 4 instrumentation to correctly work with scenarios that have no name.

Additional Notes

It is possible to declare a Cucumber scenario that has an empty name (this only works for JUnit4-backed Cucumber):

Feature: Name of the feature

  Scenario:
  ...

If the feature contains multiple scenarios that do not have names, Cucumber will assign synthetic names for them (#1, #2, etc).

However, if there is only one such scenario, its name will remain empty.
This causes problems in the backend, because scenario name maps to test name, and the latter is needed to calculate test fingerprint.

The solution is to update the tracing logic to generate synthetic names in case Cucumber does not do it.
The logic will try to calculate the line where scenario is declared and use that as the name (LINE:123) and if that fails an hard-coded string (EMPTY_NAME) is used.

Contributor Checklist

Jira ticket: SDTEST-700

@nikita-tkachenko-datadog nikita-tkachenko-datadog added type: bug Bug report and fix comp: ci visibility Continuous Integration Visibility labels Aug 19, 2024
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Aug 19, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/cucumber-empty-names
git_commit_date 1724315960 1724316758
git_commit_sha fd7f750 1008e77
release_version 1.39.0-SNAPSHOT~fd7f7504b2 1.39.0-SNAPSHOT~1008e7744a
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1724318971 1724318971
ci_job_id 613360118 613360118
ci_pipeline_id 42533826 42533826
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 47 metrics, 15 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:petclinic:tracing:Remote Config worse
[+17.633µs; +40.305µs] or [+2.682%; +6.131%]		 686.342µs 657.372µs
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~1008e7744a, baseline=1.39.0-SNAPSHOT~fd7f7504b2

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1047136
Total [baseline] (10.41 s) : 0, 10409686
Agent [candidate] (1.046 s) : 0, 1045712
Total [candidate] (10.275 s) : 0, 10274897
section appsec
Agent [baseline] (1.17 s) : 0, 1170042
Total [baseline] (10.492 s) : 0, 10491986
Agent [candidate] (1.167 s) : 0, 1166822
Total [candidate] (10.49 s) : 0, 10490128
section iast
Agent [baseline] (1.174 s) : 0, 1173564
Total [baseline] (10.861 s) : 0, 10860702
Agent [candidate] (1.175 s) : 0, 1174868
Total [candidate] (10.847 s) : 0, 10846607
section profiling
Agent [baseline] (1.247 s) : 0, 1246698
Total [baseline] (10.583 s) : 0, 10582946
Agent [candidate] (1.246 s) : 0, 1246237
Total [candidate] (10.597 s) : 0, 10597268
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.047 s -
Agent appsec 1.17 s 122.906 ms (11.7%)
Agent iast 1.174 s 126.428 ms (12.1%)
Agent profiling 1.247 s 199.562 ms (19.1%)
Total tracing 10.41 s -
Total appsec 10.492 s 82.3 ms (0.8%)
Total iast 10.861 s 451.016 ms (4.3%)
Total profiling 10.583 s 173.26 ms (1.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.046 s -
Agent appsec 1.167 s 121.11 ms (11.6%)
Agent iast 1.175 s 129.156 ms (12.4%)
Agent profiling 1.246 s 200.525 ms (19.2%)
Total tracing 10.275 s -
Total appsec 10.49 s 215.231 ms (2.1%)
Total iast 10.847 s 571.71 ms (5.6%)
Total profiling 10.597 s 322.371 ms (3.1%) 
gantt
    title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~1008e7744a, baseline=1.39.0-SNAPSHOT~fd7f7504b2

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (668.808 ms) : 0, 668808
BytebuddyAgent [candidate] (666.803 ms) : 0, 666803
GlobalTracer [baseline] (305.747 ms) : 0, 305747
GlobalTracer [candidate] (306.207 ms) : 0, 306207
AppSec [baseline] (51.068 ms) : 0, 51068
AppSec [candidate] (51.119 ms) : 0, 51119
Remote Config [baseline] (657.372 µs) : 0, 657
Remote Config [candidate] (686.342 µs) : 0, 686
Telemetry [baseline] (7.425 ms) : 0, 7425
Telemetry [candidate] (7.474 ms) : 0, 7474
section appsec
BytebuddyAgent [baseline] (679.354 ms) : 0, 679354
BytebuddyAgent [candidate] (676.678 ms) : 0, 676678
GlobalTracer [baseline] (299.788 ms) : 0, 299788
GlobalTracer [candidate] (299.516 ms) : 0, 299516
AppSec [baseline] (157.069 ms) : 0, 157069
AppSec [candidate] (157.458 ms) : 0, 157458
Remote Config [baseline] (610.396 µs) : 0, 610
Remote Config [candidate] (602.729 µs) : 0, 603
Telemetry [baseline] (8.389 ms) : 0, 8389
Telemetry [candidate] (8.995 ms) : 0, 8995
IAST [baseline] (22.693 ms) : 0, 22693
IAST [candidate] (20.199 ms) : 0, 20199
section iast
BytebuddyAgent [baseline] (778.835 ms) : 0, 778835
BytebuddyAgent [candidate] (781.72 ms) : 0, 781720
GlobalTracer [baseline] (296.358 ms) : 0, 296358
GlobalTracer [candidate] (296.156 ms) : 0, 296156
AppSec [baseline] (48.741 ms) : 0, 48741
AppSec [candidate] (52.577 ms) : 0, 52577
Remote Config [baseline] (593.131 µs) : 0, 593
Remote Config [candidate] (570.706 µs) : 0, 571
Telemetry [baseline] (9.451 ms) : 0, 9451
Telemetry [candidate] (7.099 ms) : 0, 7099
IAST [baseline] (26.1 ms) : 0, 26100
IAST [candidate] (23.261 ms) : 0, 23261
section profiling
ProfilingAgent [baseline] (94.416 ms) : 0, 94416
ProfilingAgent [candidate] (94.152 ms) : 0, 94152
BytebuddyAgent [baseline] (664.149 ms) : 0, 664149
BytebuddyAgent [candidate] (664.318 ms) : 0, 664318
GlobalTracer [baseline] (390.121 ms) : 0, 390121
GlobalTracer [candidate] (390.742 ms) : 0, 390742
AppSec [baseline] (52.858 ms) : 0, 52858
AppSec [candidate] (51.727 ms) : 0, 51727
Remote Config [baseline] (680.292 µs) : 0, 680
Remote Config [candidate] (689.157 µs) : 0, 689
Telemetry [baseline] (7.373 ms) : 0, 7373
Telemetry [candidate] (7.372 ms) : 0, 7372
Profiling [baseline] (94.44 ms) : 0, 94440
Profiling [candidate] (94.176 ms) : 0, 94176
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~1008e7744a, baseline=1.39.0-SNAPSHOT~fd7f7504b2

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1054009
Total [baseline] (8.5 s) : 0, 8500024
Agent [candidate] (1.046 s) : 0, 1046464
Total [candidate] (8.533 s) : 0, 8532943
section iast
Agent [baseline] (1.18 s) : 0, 1180125
Total [baseline] (9.008 s) : 0, 9008126
Agent [candidate] (1.175 s) : 0, 1174869
Total [candidate] (9.038 s) : 0, 9037657
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.174 s) : 0, 1174474
Total [baseline] (8.944 s) : 0, 8944424
Agent [candidate] (1.178 s) : 0, 1178399
Total [candidate] (9.005 s) : 0, 9005288
section iast_TELEMETRY_OFF
Agent [baseline] (1.166 s) : 0, 1165795
Total [baseline] (8.966 s) : 0, 8965590
Agent [candidate] (1.182 s) : 0, 1182093
Total [candidate] (8.985 s) : 0, 8985040
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.054 s -
Agent iast 1.18 s 126.117 ms (12.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.174 s 120.465 ms (11.4%)
Agent iast_TELEMETRY_OFF 1.166 s 111.786 ms (10.6%)
Total tracing 8.5 s -
Total iast 9.008 s 508.102 ms (6.0%)
Total iast_HARDCODED_SECRET_DISABLED 8.944 s 444.401 ms (5.2%)
Total iast_TELEMETRY_OFF 8.966 s 465.567 ms (5.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.046 s -
Agent iast 1.175 s 128.405 ms (12.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.178 s 131.935 ms (12.6%)
Agent iast_TELEMETRY_OFF 1.182 s 135.629 ms (13.0%)
Total tracing 8.533 s -
Total iast 9.038 s 504.714 ms (5.9%)
Total iast_HARDCODED_SECRET_DISABLED 9.005 s 472.346 ms (5.5%)
Total iast_TELEMETRY_OFF 8.985 s 452.097 ms (5.3%) 
gantt
    title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~1008e7744a, baseline=1.39.0-SNAPSHOT~fd7f7504b2

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (672.951 ms) : 0, 672951
BytebuddyAgent [candidate] (667.518 ms) : 0, 667518
GlobalTracer [baseline] (307.618 ms) : 0, 307618
GlobalTracer [candidate] (306.063 ms) : 0, 306063
AppSec [baseline] (51.707 ms) : 0, 51707
AppSec [candidate] (51.269 ms) : 0, 51269
Remote Config [baseline] (673.239 µs) : 0, 673
Remote Config [candidate] (683.212 µs) : 0, 683
Telemetry [baseline] (7.532 ms) : 0, 7532
Telemetry [candidate] (7.469 ms) : 0, 7469
section iast
BytebuddyAgent [baseline] (783.923 ms) : 0, 783923
BytebuddyAgent [candidate] (781.448 ms) : 0, 781448
GlobalTracer [baseline] (297.903 ms) : 0, 297903
GlobalTracer [candidate] (296.154 ms) : 0, 296154
AppSec [baseline] (49.908 ms) : 0, 49908
AppSec [candidate] (51.396 ms) : 0, 51396
IAST [baseline] (25.349 ms) : 0, 25349
IAST [candidate] (21.567 ms) : 0, 21567
Remote Config [baseline] (593.598 µs) : 0, 594
Remote Config [candidate] (573.065 µs) : 0, 573
Telemetry [baseline] (8.88 ms) : 0, 8880
Telemetry [candidate] (10.268 ms) : 0, 10268
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (779.431 ms) : 0, 779431
BytebuddyAgent [candidate] (783.779 ms) : 0, 783779
GlobalTracer [baseline] (296.777 ms) : 0, 296777
GlobalTracer [candidate] (297.564 ms) : 0, 297564
AppSec [baseline] (49.77 ms) : 0, 49770
AppSec [candidate] (48.897 ms) : 0, 48897
IAST [baseline] (24.017 ms) : 0, 24017
IAST [candidate] (24.42 ms) : 0, 24420
Remote Config [baseline] (610.231 µs) : 0, 610
Remote Config [candidate] (597.834 µs) : 0, 598
Telemetry [baseline] (10.356 ms) : 0, 10356
Telemetry [candidate] (9.591 ms) : 0, 9591
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (773.767 ms) : 0, 773767
BytebuddyAgent [candidate] (786.91 ms) : 0, 786910
GlobalTracer [baseline] (295.667 ms) : 0, 295667
GlobalTracer [candidate] (299.426 ms) : 0, 299426
AppSec [baseline] (53.203 ms) : 0, 53203
AppSec [candidate] (53.291 ms) : 0, 53291
IAST [baseline] (22.028 ms) : 0, 22028
IAST [candidate] (21.029 ms) : 0, 21029
Remote Config [baseline] (588.547 µs) : 0, 589
Remote Config [candidate] (631.944 µs) : 0, 632
Telemetry [baseline] (7.075 ms) : 0, 7075
Telemetry [candidate] (7.229 ms) : 0, 7229
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-08-22T09:00:04 2024-08-22T09:06:51
git_branch master nikita-tkachenko/cucumber-empty-names
git_commit_date 1724315960 1724316758
git_commit_sha fd7f750 1008e77
release_version 1.39.0-SNAPSHOT~fd7f7504b2 1.39.0-SNAPSHOT~1008e7744a
start_time 2024-08-22T08:59:51 2024-08-22T09:06:38
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1724317957 1724317957
ci_job_id 613360119 613360119
ci_pipeline_id 42533826 42533826
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~1008e7744a, baseline=1.39.0-SNAPSHOT~fd7f7504b2
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.344 ms) : 1325, 1364
.   : milestone, 1344,
appsec (1.714 ms) : 1690, 1739
.   : milestone, 1714,
appsec_no_iast (1.721 ms) : 1696, 1746
.   : milestone, 1721,
iast (1.47 ms) : 1448, 1493
.   : milestone, 1470,
profiling (1.46 ms) : 1435, 1485
.   : milestone, 1460,
tracing (1.465 ms) : 1440, 1490
.   : milestone, 1465,
section candidate
no_agent (1.345 ms) : 1326, 1364
.   : milestone, 1345,
appsec (1.73 ms) : 1706, 1753
.   : milestone, 1730,
appsec_no_iast (1.731 ms) : 1708, 1755
.   : milestone, 1731,
iast (1.476 ms) : 1454, 1498
.   : milestone, 1476,
profiling (1.492 ms) : 1467, 1517
.   : milestone, 1492,
tracing (1.467 ms) : 1443, 1490
.   : milestone, 1467,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.344 ms [1.325 ms, 1.364 ms] -
appsec 1.714 ms [1.69 ms, 1.739 ms] 369.861 µs (27.5%)
appsec_no_iast 1.721 ms [1.696 ms, 1.746 ms] 376.869 µs (28.0%)
iast 1.47 ms [1.448 ms, 1.493 ms] 126.085 µs (9.4%)
profiling 1.46 ms [1.435 ms, 1.485 ms] 115.797 µs (8.6%)
tracing 1.465 ms [1.44 ms, 1.49 ms] 120.634 µs (9.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.345 ms [1.326 ms, 1.364 ms] -
appsec 1.73 ms [1.706 ms, 1.753 ms] 384.91 µs (28.6%)
appsec_no_iast 1.731 ms [1.708 ms, 1.755 ms] 386.318 µs (28.7%)
iast 1.476 ms [1.454 ms, 1.498 ms] 131.179 µs (9.8%)
profiling 1.492 ms [1.467 ms, 1.517 ms] 146.913 µs (10.9%)
tracing 1.467 ms [1.443 ms, 1.49 ms] 121.804 µs (9.1%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~1008e7744a, baseline=1.39.0-SNAPSHOT~fd7f7504b2
    dateFormat X
    axisFormat %s
section baseline
no_agent (370.519 µs) : 350, 391
.   : milestone, 371,
iast (481.559 µs) : 459, 504
.   : milestone, 482,
iast_FULL (552.283 µs) : 531, 574
.   : milestone, 552,
iast_GLOBAL (497.399 µs) : 475, 520
.   : milestone, 497,
iast_HARDCODED_SECRET_DISABLED (478.241 µs) : 456, 500
.   : milestone, 478,
iast_INACTIVE (439.328 µs) : 419, 460
.   : milestone, 439,
iast_TELEMETRY_OFF (474.343 µs) : 453, 496
.   : milestone, 474,
tracing (438.306 µs) : 418, 459
.   : milestone, 438,
section candidate
no_agent (362.892 µs) : 342, 384
.   : milestone, 363,
iast (489.763 µs) : 468, 512
.   : milestone, 490,
iast_FULL (548.993 µs) : 526, 572
.   : milestone, 549,
iast_GLOBAL (497.791 µs) : 476, 520
.   : milestone, 498,
iast_HARDCODED_SECRET_DISABLED (486.883 µs) : 466, 508
.   : milestone, 487,
iast_INACTIVE (452.822 µs) : 430, 475
.   : milestone, 453,
iast_TELEMETRY_OFF (473.056 µs) : 451, 495
.   : milestone, 473,
tracing (438.484 µs) : 418, 459
.   : milestone, 438,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.519 µs [350.493 µs, 390.545 µs] -
iast 481.559 µs [459.275 µs, 503.842 µs] 111.04 µs (30.0%)
iast_FULL 552.283 µs [530.525 µs, 574.041 µs] 181.764 µs (49.1%)
iast_GLOBAL 497.399 µs [475.093 µs, 519.705 µs] 126.88 µs (34.2%)
iast_HARDCODED_SECRET_DISABLED 478.241 µs [456.099 µs, 500.383 µs] 107.722 µs (29.1%)
iast_INACTIVE 439.328 µs [419.033 µs, 459.623 µs] 68.809 µs (18.6%)
iast_TELEMETRY_OFF 474.343 µs [452.946 µs, 495.741 µs] 103.825 µs (28.0%)
tracing 438.306 µs [418.004 µs, 458.608 µs] 67.788 µs (18.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 362.892 µs [342.143 µs, 383.64 µs] -
iast 489.763 µs [467.93 µs, 511.596 µs] 126.871 µs (35.0%)
iast_FULL 548.993 µs [526.451 µs, 571.535 µs] 186.102 µs (51.3%)
iast_GLOBAL 497.791 µs [475.959 µs, 519.622 µs] 134.899 µs (37.2%)
iast_HARDCODED_SECRET_DISABLED 486.883 µs [465.779 µs, 507.987 µs] 123.992 µs (34.2%)
iast_INACTIVE 452.822 µs [430.219 µs, 475.426 µs] 89.931 µs (24.8%)
iast_TELEMETRY_OFF 473.056 µs [450.76 µs, 495.351 µs] 110.164 µs (30.4%)
tracing 438.484 µs [418.159 µs, 458.809 µs] 75.592 µs (20.8%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/cucumber-empty-names
git_commit_date 1724315960 1724316758
git_commit_sha fd7f750 1008e77
release_version 1.39.0-SNAPSHOT~fd7f7504b2 1.39.0-SNAPSHOT~1008e7744a
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1724318470 1724318470
ci_job_id 613360120 613360120
ci_pipeline_id 42533826 42533826
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~1008e7744a, baseline=1.39.0-SNAPSHOT~fd7f7504b2
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.97 s) : 14970000, 14970000
.   : milestone, 14970000,
appsec (15.016 s) : 15016000, 15016000
.   : milestone, 15016000,
iast (18.563 s) : 18563000, 18563000
.   : milestone, 18563000,
iast_GLOBAL (18.096 s) : 18096000, 18096000
.   : milestone, 18096000,
profiling (15.397 s) : 15397000, 15397000
.   : milestone, 15397000,
tracing (15.17 s) : 15170000, 15170000
.   : milestone, 15170000,
section candidate
no_agent (15.532 s) : 15532000, 15532000
.   : milestone, 15532000,
appsec (15.016 s) : 15016000, 15016000
.   : milestone, 15016000,
iast (18.769 s) : 18769000, 18769000
.   : milestone, 18769000,
iast_GLOBAL (17.961 s) : 17961000, 17961000
.   : milestone, 17961000,
profiling (15.099 s) : 15099000, 15099000
.   : milestone, 15099000,
tracing (14.994 s) : 14994000, 14994000
.   : milestone, 14994000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.97 s [14.97 s, 14.97 s] -
appsec 15.016 s [15.016 s, 15.016 s] 46.0 ms (0.3%)
iast 18.563 s [18.563 s, 18.563 s] 3.593 s (24.0%)
iast_GLOBAL 18.096 s [18.096 s, 18.096 s] 3.126 s (20.9%)
profiling 15.397 s [15.397 s, 15.397 s] 427.0 ms (2.9%)
tracing 15.17 s [15.17 s, 15.17 s] 200.0 ms (1.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.532 s [15.532 s, 15.532 s] -
appsec 15.016 s [15.016 s, 15.016 s] -516.0 ms (-3.3%)
iast 18.769 s [18.769 s, 18.769 s] 3.237 s (20.8%)
iast_GLOBAL 17.961 s [17.961 s, 17.961 s] 2.429 s (15.6%)
profiling 15.099 s [15.099 s, 15.099 s] -433.0 ms (-2.8%)
tracing 14.994 s [14.994 s, 14.994 s] -538.0 ms (-3.5%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~1008e7744a, baseline=1.39.0-SNAPSHOT~fd7f7504b2
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.459 ms) : 1447, 1470
.   : milestone, 1459,
appsec (2.223 ms) : 2188, 2259
.   : milestone, 2223,
iast (1.967 ms) : 1925, 2010
.   : milestone, 1967,
iast_GLOBAL (2.006 ms) : 1963, 2049
.   : milestone, 2006,
profiling (1.862 ms) : 1828, 1896
.   : milestone, 1862,
tracing (1.831 ms) : 1798, 1864
.   : milestone, 1831,
section candidate
no_agent (1.455 ms) : 1444, 1467
.   : milestone, 1455,
appsec (2.212 ms) : 2177, 2246
.   : milestone, 2212,
iast (1.968 ms) : 1926, 2010
.   : milestone, 1968,
iast_GLOBAL (2.018 ms) : 1975, 2061
.   : milestone, 2018,
profiling (1.862 ms) : 1828, 1896
.   : milestone, 1862,
tracing (1.835 ms) : 1803, 1868
.   : milestone, 1835,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.459 ms [1.447 ms, 1.47 ms] -
appsec 2.223 ms [2.188 ms, 2.259 ms] 764.914 µs (52.4%)
iast 1.967 ms [1.925 ms, 2.01 ms] 508.607 µs (34.9%)
iast_GLOBAL 2.006 ms [1.963 ms, 2.049 ms] 547.492 µs (37.5%)
profiling 1.862 ms [1.828 ms, 1.896 ms] 403.628 µs (27.7%)
tracing 1.831 ms [1.798 ms, 1.864 ms] 372.146 µs (25.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.455 ms [1.444 ms, 1.467 ms] -
appsec 2.212 ms [2.177 ms, 2.246 ms] 756.271 µs (52.0%)
iast 1.968 ms [1.926 ms, 2.01 ms] 512.884 µs (35.2%)
iast_GLOBAL 2.018 ms [1.975 ms, 2.061 ms] 562.672 µs (38.7%)
profiling 1.862 ms [1.828 ms, 1.896 ms] 406.675 µs (27.9%)
tracing 1.835 ms [1.803 ms, 1.868 ms] 380.198 µs (26.1%)

@nikita-tkachenko-datadog nikita-tkachenko-datadog marked this pull request as ready for review August 22, 2024 09:30
@nikita-tkachenko-datadog nikita-tkachenko-datadog requested a review from a team as a code owner August 22, 2024 09:30
@nikita-tkachenko-datadog nikita-tkachenko-datadog merged commit 77c6fbe into master Aug 22, 2024
@nikita-tkachenko-datadog nikita-tkachenko-datadog deleted the nikita-tkachenko/cucumber-empty-names branch August 22, 2024 10:12
@github-actions github-actions Bot added this to the 1.39.0 milestone Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@romainkomorn-exdatadog romainkomorn-exdatadog romainkomorn-exdatadog approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

comp: ci visibility Continuous Integration Visibility type: bug Bug report and fix

Projects

None yet

Milestone

1.39.0

Development

Successfully merging this pull request may close these issues.

2 participants

@nikita-tkachenko-datadog @romainkomorn-exdatadog