Skip to content

Fix concurrent modification#7469

Merged
jpbempel merged 1 commit intomasterfrom
jpbempel/fix-concurrent-modif
Aug 20, 2024
Merged

Fix concurrent modification#7469
jpbempel merged 1 commit intomasterfrom
jpbempel/fix-concurrent-modif

Conversation

@jpbempel
Copy link
Copy Markdown
Member

@jpbempel jpbempel commented Aug 19, 2024 •
edited by atlassian Bot
Loading

What Does This Do

need to clone the list in classNamesBySourceFile Map to avoid concurrent modification of it while registering a new class

Motivation

Additional Notes

Contributor Checklist

Jira ticket: DEBUG-2575

@jpbempel jpbempel requested a review from a team as a code owner August 19, 2024 09:58
@jpbempel jpbempel requested review from ojung and removed request for a team August 19, 2024 09:58
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Aug 19, 2024 •
edited
Loading

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1724065621 1724066013
end_time 2024-08-19T11:08:14 2024-08-19T11:14:47
git_branch master jpbempel/fix-concurrent-modif
git_commit_sha 5ae921b 536ee7b
start_time 2024-08-19T11:07:02 2024-08-19T11:13:34
See matching parameters
Baseline Candidate
ci_job_id 608594058 608594058
ci_pipeline_id 42101483 42101483
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1724065050 1724065050

Summary

Found 5 performance improvements and 0 performance regressions! Performance is the same for 4 metrics, 6 unstable metrics.

scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:loop better
[-674.139µs; -584.169µs] or [-6.132%; -5.314%]		 better
[-680.707µs; -577.262µs] or [-6.099%; -5.172%]		 better
[-688.325µs; -548.572µs] or [-6.117%; -4.875%]		 better
[-857.367µs; -275.826µs] or [-7.373%; -2.372%]		 better
[+4.348op/s; +6.445op/s] or [+4.913%; +7.283%]
See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-18.728µs; +23.971µs] or [-7.341%; +9.397%]		 unstable
[-30.991µs; +38.898µs] or [-10.723%; +13.458%]		 unstable
[-40.581µs; +52.188µs] or [-13.461%; +17.311%]		 unstable
[-75.186µs; +118.613µs] or [-11.824%; +18.654%]		 same
scenario:basic unsure
[-12.660µs; -1.158µs] or [-4.697%; -0.430%]		 same same unstable
[-40.011µs; +36.311µs] or [-6.768%; +6.143%]		 unstable
[-153.104op/s; +153.104op/s] or [-5.818%; +5.818%]
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (289.029 µs) : 258, 320
.   : milestone, 289,
basic (295.888 µs) : 287, 304
.   : milestone, 296,
loop (11.162 ms) : 11102, 11221
.   : milestone, 11162,
section candidate
noprobe (292.983 µs) : 257, 329
.   : milestone, 293,
basic (289.382 µs) : 280, 299
.   : milestone, 289,
loop (10.533 ms) : 10500, 10566
.   : milestone, 10533,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 289.029 µs [258.419 µs, 319.639 µs]
basic 295.888 µs [287.453 µs, 304.322 µs]
loop 11.162 ms [11.102 ms, 11.221 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 292.983 µs [257.102 µs, 328.864 µs]
basic 289.382 µs [280.189 µs, 298.576 µs]
loop 10.533 ms [10.5 ms, 10.566 ms]

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Aug 19, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/fix-concurrent-modif
git_commit_date 1724059733 1724065050
git_commit_sha 5ae921b 536ee7b
release_version 1.39.0-SNAPSHOT~5ae921b9c4 1.39.0-SNAPSHOT~536ee7b3bd
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1724067453 1724067453
ci_job_id 608594052 608594052
ci_pipeline_id 42101483 42101483
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~536ee7b3bd, baseline=1.39.0-SNAPSHOT~5ae921b9c4

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.048 s) : 0, 1048479
Total [baseline] (10.434 s) : 0, 10434332
Agent [candidate] (1.047 s) : 0, 1047340
Total [candidate] (10.368 s) : 0, 10368248
section appsec
Agent [baseline] (1.173 s) : 0, 1173048
Total [baseline] (10.469 s) : 0, 10469435
Agent [candidate] (1.168 s) : 0, 1168153
Total [candidate] (10.546 s) : 0, 10545996
section iast
Agent [baseline] (1.186 s) : 0, 1185590
Total [baseline] (10.898 s) : 0, 10898205
Agent [candidate] (1.188 s) : 0, 1188479
Total [candidate] (10.827 s) : 0, 10826892
section profiling
Agent [baseline] (1.247 s) : 0, 1247278
Total [baseline] (10.599 s) : 0, 10599287
Agent [candidate] (1.245 s) : 0, 1244607
Total [candidate] (10.679 s) : 0, 10679326
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.048 s -
Agent appsec 1.173 s 124.57 ms (11.9%)
Agent iast 1.186 s 137.111 ms (13.1%)
Agent profiling 1.247 s 198.8 ms (19.0%)
Total tracing 10.434 s -
Total appsec 10.469 s 35.103 ms (0.3%)
Total iast 10.898 s 463.873 ms (4.4%)
Total profiling 10.599 s 164.955 ms (1.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.047 s -
Agent appsec 1.168 s 120.813 ms (11.5%)
Agent iast 1.188 s 141.139 ms (13.5%)
Agent profiling 1.245 s 197.267 ms (18.8%)
Total tracing 10.368 s -
Total appsec 10.546 s 177.748 ms (1.7%)
Total iast 10.827 s 458.644 ms (4.4%)
Total profiling 10.679 s 311.078 ms (3.0%) 
gantt
    title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~536ee7b3bd, baseline=1.39.0-SNAPSHOT~5ae921b9c4

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (669.448 ms) : 0, 669448
BytebuddyAgent [candidate] (668.163 ms) : 0, 668163
GlobalTracer [baseline] (306.375 ms) : 0, 306375
GlobalTracer [candidate] (306.676 ms) : 0, 306676
AppSec [baseline] (50.959 ms) : 0, 50959
AppSec [candidate] (50.875 ms) : 0, 50875
Remote Config [baseline] (691.261 µs) : 0, 691
Remote Config [candidate] (686.346 µs) : 0, 686
Telemetry [baseline] (7.57 ms) : 0, 7570
Telemetry [candidate] (7.53 ms) : 0, 7530
section appsec
BytebuddyAgent [baseline] (680.916 ms) : 0, 680916
BytebuddyAgent [candidate] (677.97 ms) : 0, 677970
GlobalTracer [baseline] (300.725 ms) : 0, 300725
GlobalTracer [candidate] (299.848 ms) : 0, 299848
AppSec [baseline] (157.766 ms) : 0, 157766
AppSec [candidate] (157.168 ms) : 0, 157168
Remote Config [baseline] (603.657 µs) : 0, 604
Remote Config [candidate] (599.4 µs) : 0, 599
Telemetry [baseline] (9.685 ms) : 0, 9685
Telemetry [candidate] (7.791 ms) : 0, 7791
IAST [baseline] (19.696 ms) : 0, 19696
IAST [candidate] (22.64 ms) : 0, 22640
section iast
BytebuddyAgent [baseline] (789.818 ms) : 0, 789818
BytebuddyAgent [candidate] (791.06 ms) : 0, 791060
GlobalTracer [baseline] (298.937 ms) : 0, 298937
GlobalTracer [candidate] (299.056 ms) : 0, 299056
AppSec [baseline] (54.434 ms) : 0, 54434
AppSec [candidate] (52.993 ms) : 0, 52993
Remote Config [baseline] (582.915 µs) : 0, 583
Remote Config [candidate] (572.561 µs) : 0, 573
Telemetry [baseline] (7.239 ms) : 0, 7239
Telemetry [candidate] (8.659 ms) : 0, 8659
IAST [baseline] (21.003 ms) : 0, 21003
IAST [candidate] (22.502 ms) : 0, 22502
section profiling
BytebuddyAgent [baseline] (664.475 ms) : 0, 664475
BytebuddyAgent [candidate] (662.765 ms) : 0, 662765
GlobalTracer [baseline] (390.965 ms) : 0, 390965
GlobalTracer [candidate] (389.839 ms) : 0, 389839
AppSec [baseline] (52.208 ms) : 0, 52208
AppSec [candidate] (52.212 ms) : 0, 52212
Remote Config [baseline] (689.944 µs) : 0, 690
Remote Config [candidate] (685.988 µs) : 0, 686
Telemetry [baseline] (7.365 ms) : 0, 7365
Telemetry [candidate] (7.375 ms) : 0, 7375
ProfilingAgent [baseline] (94.444 ms) : 0, 94444
ProfilingAgent [candidate] (94.633 ms) : 0, 94633
Profiling [baseline] (94.469 ms) : 0, 94469
Profiling [candidate] (94.658 ms) : 0, 94658
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~536ee7b3bd, baseline=1.39.0-SNAPSHOT~5ae921b9c4

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.044 s) : 0, 1044142
Total [baseline] (8.502 s) : 0, 8501844
Agent [candidate] (1.047 s) : 0, 1047397
Total [candidate] (8.508 s) : 0, 8508037
section iast
Agent [baseline] (1.177 s) : 0, 1176838
Total [baseline] (9.015 s) : 0, 9014614
Agent [candidate] (1.176 s) : 0, 1175938
Total [candidate] (9.04 s) : 0, 9040472
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.178 s) : 0, 1178239
Total [baseline] (8.988 s) : 0, 8987652
Agent [candidate] (1.185 s) : 0, 1184607
Total [candidate] (8.973 s) : 0, 8972782
section iast_TELEMETRY_OFF
Agent [baseline] (1.174 s) : 0, 1174050
Total [baseline] (8.969 s) : 0, 8969481
Agent [candidate] (1.172 s) : 0, 1171959
Total [candidate] (8.966 s) : 0, 8965702
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.044 s -
Agent iast 1.177 s 132.696 ms (12.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.178 s 134.097 ms (12.8%)
Agent iast_TELEMETRY_OFF 1.174 s 129.908 ms (12.4%)
Total tracing 8.502 s -
Total iast 9.015 s 512.77 ms (6.0%)
Total iast_HARDCODED_SECRET_DISABLED 8.988 s 485.807 ms (5.7%)
Total iast_TELEMETRY_OFF 8.969 s 467.637 ms (5.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.047 s -
Agent iast 1.176 s 128.542 ms (12.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.185 s 137.21 ms (13.1%)
Agent iast_TELEMETRY_OFF 1.172 s 124.563 ms (11.9%)
Total tracing 8.508 s -
Total iast 9.04 s 532.435 ms (6.3%)
Total iast_HARDCODED_SECRET_DISABLED 8.973 s 464.745 ms (5.5%)
Total iast_TELEMETRY_OFF 8.966 s 457.665 ms (5.4%) 
gantt
    title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~536ee7b3bd, baseline=1.39.0-SNAPSHOT~5ae921b9c4

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (666.096 ms) : 0, 666096
BytebuddyAgent [candidate] (668.584 ms) : 0, 668584
GlobalTracer [baseline] (305.422 ms) : 0, 305422
GlobalTracer [candidate] (306.159 ms) : 0, 306159
AppSec [baseline] (51.034 ms) : 0, 51034
AppSec [candidate] (50.965 ms) : 0, 50965
Remote Config [baseline] (680.88 µs) : 0, 681
Remote Config [candidate] (676.458 µs) : 0, 676
Telemetry [baseline] (7.483 ms) : 0, 7483
Telemetry [candidate] (7.548 ms) : 0, 7548
section iast
BytebuddyAgent [baseline] (782.847 ms) : 0, 782847
BytebuddyAgent [candidate] (782.11 ms) : 0, 782110
GlobalTracer [baseline] (296.216 ms) : 0, 296216
GlobalTracer [candidate] (296.169 ms) : 0, 296169
AppSec [baseline] (53.242 ms) : 0, 53242
AppSec [candidate] (53.265 ms) : 0, 53265
IAST [baseline] (22.467 ms) : 0, 22467
IAST [candidate] (21.659 ms) : 0, 21659
Remote Config [baseline] (577.093 µs) : 0, 577
Remote Config [candidate] (573.946 µs) : 0, 574
Telemetry [baseline] (8.041 ms) : 0, 8041
Telemetry [candidate] (8.707 ms) : 0, 8707
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (783.056 ms) : 0, 783056
BytebuddyAgent [candidate] (787.831 ms) : 0, 787831
GlobalTracer [baseline] (297.266 ms) : 0, 297266
GlobalTracer [candidate] (298.911 ms) : 0, 298911
AppSec [baseline] (50.039 ms) : 0, 50039
AppSec [candidate] (50.05 ms) : 0, 50050
IAST [baseline] (24.996 ms) : 0, 24996
IAST [candidate] (25.741 ms) : 0, 25741
Remote Config [baseline] (567.508 µs) : 0, 568
Remote Config [candidate] (566.284 µs) : 0, 566
Telemetry [baseline] (8.753 ms) : 0, 8753
Telemetry [candidate] (7.9 ms) : 0, 7900
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (780.306 ms) : 0, 780306
BytebuddyAgent [candidate] (779.155 ms) : 0, 779155
GlobalTracer [baseline] (296.679 ms) : 0, 296679
GlobalTracer [candidate] (296.966 ms) : 0, 296966
AppSec [baseline] (53.034 ms) : 0, 53034
AppSec [candidate] (52.708 ms) : 0, 52708
IAST [baseline] (22.138 ms) : 0, 22138
IAST [candidate] (22.044 ms) : 0, 22044
Remote Config [baseline] (605.839 µs) : 0, 606
Remote Config [candidate] (604.324 µs) : 0, 604
Telemetry [baseline] (7.794 ms) : 0, 7794
Telemetry [candidate] (7.001 ms) : 0, 7001
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-08-19T11:08:13 2024-08-19T11:15:03
git_branch master jpbempel/fix-concurrent-modif
git_commit_date 1724059733 1724065050
git_commit_sha 5ae921b 536ee7b
release_version 1.39.0-SNAPSHOT~5ae921b9c4 1.39.0-SNAPSHOT~536ee7b3bd
start_time 2024-08-19T11:08:00 2024-08-19T11:14:50
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1724066447 1724066447
ci_job_id 608594053 608594053
ci_pipeline_id 42101483 42101483
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~536ee7b3bd, baseline=1.39.0-SNAPSHOT~5ae921b9c4
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.325 ms) : 1306, 1344
.   : milestone, 1325,
appsec (1.715 ms) : 1691, 1739
.   : milestone, 1715,
appsec_no_iast (1.692 ms) : 1666, 1717
.   : milestone, 1692,
iast (1.465 ms) : 1442, 1487
.   : milestone, 1465,
profiling (1.545 ms) : 1518, 1571
.   : milestone, 1545,
tracing (1.463 ms) : 1438, 1488
.   : milestone, 1463,
section candidate
no_agent (1.328 ms) : 1309, 1347
.   : milestone, 1328,
appsec (1.709 ms) : 1685, 1732
.   : milestone, 1709,
appsec_no_iast (1.706 ms) : 1682, 1731
.   : milestone, 1706,
iast (1.516 ms) : 1494, 1538
.   : milestone, 1516,
profiling (1.514 ms) : 1488, 1540
.   : milestone, 1514,
tracing (1.46 ms) : 1435, 1485
.   : milestone, 1460,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.325 ms [1.306 ms, 1.344 ms] -
appsec 1.715 ms [1.691 ms, 1.739 ms] 389.885 µs (29.4%)
appsec_no_iast 1.692 ms [1.666 ms, 1.717 ms] 366.917 µs (27.7%)
iast 1.465 ms [1.442 ms, 1.487 ms] 139.726 µs (10.5%)
profiling 1.545 ms [1.518 ms, 1.571 ms] 219.768 µs (16.6%)
tracing 1.463 ms [1.438 ms, 1.488 ms] 138.056 µs (10.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.328 ms [1.309 ms, 1.347 ms] -
appsec 1.709 ms [1.685 ms, 1.732 ms] 380.724 µs (28.7%)
appsec_no_iast 1.706 ms [1.682 ms, 1.731 ms] 378.59 µs (28.5%)
iast 1.516 ms [1.494 ms, 1.538 ms] 188.08 µs (14.2%)
profiling 1.514 ms [1.488 ms, 1.54 ms] 186.316 µs (14.0%)
tracing 1.46 ms [1.435 ms, 1.485 ms] 131.898 µs (9.9%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~536ee7b3bd, baseline=1.39.0-SNAPSHOT~5ae921b9c4
    dateFormat X
    axisFormat %s
section baseline
no_agent (374.109 µs) : 355, 394
.   : milestone, 374,
iast (480.562 µs) : 459, 502
.   : milestone, 481,
iast_FULL (548.974 µs) : 527, 571
.   : milestone, 549,
iast_GLOBAL (514.967 µs) : 492, 538
.   : milestone, 515,
iast_HARDCODED_SECRET_DISABLED (483.716 µs) : 462, 505
.   : milestone, 484,
iast_INACTIVE (457.802 µs) : 435, 481
.   : milestone, 458,
iast_TELEMETRY_OFF (470.109 µs) : 449, 491
.   : milestone, 470,
tracing (440.818 µs) : 421, 461
.   : milestone, 441,
section candidate
no_agent (371.935 µs) : 352, 392
.   : milestone, 372,
iast (476.825 µs) : 456, 498
.   : milestone, 477,
iast_FULL (550.286 µs) : 528, 573
.   : milestone, 550,
iast_GLOBAL (501.866 µs) : 480, 524
.   : milestone, 502,
iast_HARDCODED_SECRET_DISABLED (483.442 µs) : 462, 505
.   : milestone, 483,
iast_INACTIVE (454.732 µs) : 432, 477
.   : milestone, 455,
iast_TELEMETRY_OFF (464.032 µs) : 443, 485
.   : milestone, 464,
tracing (441.553 µs) : 421, 462
.   : milestone, 442,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 374.109 µs [354.616 µs, 393.601 µs] -
iast 480.562 µs [459.396 µs, 501.728 µs] 106.453 µs (28.5%)
iast_FULL 548.974 µs [526.694 µs, 571.254 µs] 174.866 µs (46.7%)
iast_GLOBAL 514.967 µs [491.73 µs, 538.203 µs] 140.858 µs (37.7%)
iast_HARDCODED_SECRET_DISABLED 483.716 µs [462.351 µs, 505.08 µs] 109.607 µs (29.3%)
iast_INACTIVE 457.802 µs [434.692 µs, 480.912 µs] 83.693 µs (22.4%)
iast_TELEMETRY_OFF 470.109 µs [449.034 µs, 491.184 µs] 96.001 µs (25.7%)
tracing 440.818 µs [420.514 µs, 461.122 µs] 66.709 µs (17.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 371.935 µs [351.699 µs, 392.171 µs] -
iast 476.825 µs [455.849 µs, 497.801 µs] 104.89 µs (28.2%)
iast_FULL 550.286 µs [527.773 µs, 572.798 µs] 178.351 µs (48.0%)
iast_GLOBAL 501.866 µs [479.569 µs, 524.163 µs] 129.931 µs (34.9%)
iast_HARDCODED_SECRET_DISABLED 483.442 µs [462.087 µs, 504.796 µs] 111.507 µs (30.0%)
iast_INACTIVE 454.732 µs [432.074 µs, 477.391 µs] 82.797 µs (22.3%)
iast_TELEMETRY_OFF 464.032 µs [443.369 µs, 484.695 µs] 92.097 µs (24.8%)
tracing 441.553 µs [421.033 µs, 462.072 µs] 69.618 µs (18.7%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/fix-concurrent-modif
git_commit_date 1724059733 1724065050
git_commit_sha 5ae921b 536ee7b
release_version 1.39.0-SNAPSHOT~5ae921b9c4 1.39.0-SNAPSHOT~536ee7b3bd
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1724066968 1724066968
ci_job_id 608594054 608594054
ci_pipeline_id 42101483 42101483
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~536ee7b3bd, baseline=1.39.0-SNAPSHOT~5ae921b9c4
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.46 ms) : 1449, 1472
.   : milestone, 1460,
appsec (2.213 ms) : 2178, 2249
.   : milestone, 2213,
iast (1.95 ms) : 1908, 1992
.   : milestone, 1950,
iast_GLOBAL (2.009 ms) : 1966, 2052
.   : milestone, 2009,
profiling (1.858 ms) : 1824, 1892
.   : milestone, 1858,
tracing (1.838 ms) : 1805, 1871
.   : milestone, 1838,
section candidate
no_agent (1.452 ms) : 1441, 1464
.   : milestone, 1452,
appsec (2.206 ms) : 2171, 2241
.   : milestone, 2206,
iast (1.965 ms) : 1923, 2007
.   : milestone, 1965,
iast_GLOBAL (2.002 ms) : 1960, 2044
.   : milestone, 2002,
profiling (1.853 ms) : 1818, 1888
.   : milestone, 1853,
tracing (1.826 ms) : 1793, 1859
.   : milestone, 1826,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.46 ms [1.449 ms, 1.472 ms] -
appsec 2.213 ms [2.178 ms, 2.249 ms] 753.401 µs (51.6%)
iast 1.95 ms [1.908 ms, 1.992 ms] 489.588 µs (33.5%)
iast_GLOBAL 2.009 ms [1.966 ms, 2.052 ms] 549.033 µs (37.6%)
profiling 1.858 ms [1.824 ms, 1.892 ms] 398.156 µs (27.3%)
tracing 1.838 ms [1.805 ms, 1.871 ms] 378.207 µs (25.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.452 ms [1.441 ms, 1.464 ms] -
appsec 2.206 ms [2.171 ms, 2.241 ms] 753.322 µs (51.9%)
iast 1.965 ms [1.923 ms, 2.007 ms] 512.525 µs (35.3%)
iast_GLOBAL 2.002 ms [1.96 ms, 2.044 ms] 549.618 µs (37.8%)
profiling 1.853 ms [1.818 ms, 1.888 ms] 400.333 µs (27.6%)
tracing 1.826 ms [1.793 ms, 1.859 ms] 373.478 µs (25.7%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~536ee7b3bd, baseline=1.39.0-SNAPSHOT~5ae921b9c4
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.368 s) : 15368000, 15368000
.   : milestone, 15368000,
appsec (15.279 s) : 15279000, 15279000
.   : milestone, 15279000,
iast (18.903 s) : 18903000, 18903000
.   : milestone, 18903000,
iast_GLOBAL (18.226 s) : 18226000, 18226000
.   : milestone, 18226000,
profiling (15.191 s) : 15191000, 15191000
.   : milestone, 15191000,
tracing (15.069 s) : 15069000, 15069000
.   : milestone, 15069000,
section candidate
no_agent (15.456 s) : 15456000, 15456000
.   : milestone, 15456000,
appsec (15.139 s) : 15139000, 15139000
.   : milestone, 15139000,
iast (18.684 s) : 18684000, 18684000
.   : milestone, 18684000,
iast_GLOBAL (17.623 s) : 17623000, 17623000
.   : milestone, 17623000,
profiling (15.184 s) : 15184000, 15184000
.   : milestone, 15184000,
tracing (15.011 s) : 15011000, 15011000
.   : milestone, 15011000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.368 s [15.368 s, 15.368 s] -
appsec 15.279 s [15.279 s, 15.279 s] -89.0 ms (-0.6%)
iast 18.903 s [18.903 s, 18.903 s] 3.535 s (23.0%)
iast_GLOBAL 18.226 s [18.226 s, 18.226 s] 2.858 s (18.6%)
profiling 15.191 s [15.191 s, 15.191 s] -177.0 ms (-1.2%)
tracing 15.069 s [15.069 s, 15.069 s] -299.0 ms (-1.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.456 s [15.456 s, 15.456 s] -
appsec 15.139 s [15.139 s, 15.139 s] -317.0 ms (-2.1%)
iast 18.684 s [18.684 s, 18.684 s] 3.228 s (20.9%)
iast_GLOBAL 17.623 s [17.623 s, 17.623 s] 2.167 s (14.0%)
profiling 15.184 s [15.184 s, 15.184 s] -272.0 ms (-1.8%)
tracing 15.011 s [15.011 s, 15.011 s] -445.0 ms (-2.9%)

@jpbempel
fix concurrent modification
536ee7b 
need to clone the list in classNamesBySourceFile Map to avoid
concurrent modification of it while registering a new class
@jpbempel jpbempel force-pushed the jpbempel/fix-concurrent-modif branch from eda47db to 536ee7b Compare August 19, 2024 10:57
@PerfectSlayer PerfectSlayer added type: bug Bug report and fix comp: debugger Dynamic Instrumentation labels Aug 19, 2024
@PerfectSlayer PerfectSlayer changed the title fix concurrent modification Fix concurrent modification Aug 19, 2024
@jpbempel jpbempel merged commit 31b5009 into master Aug 20, 2024
@jpbempel jpbempel deleted the jpbempel/fix-concurrent-modif branch August 20, 2024 15:11
@github-actions github-actions Bot added this to the 1.39.0 milestone Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ojung ojung Awaiting requested review from ojung ojung is a code owner automatically assigned from DataDog/debugger-java

1 more reviewer

@cimi cimi cimi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

comp: debugger Dynamic Instrumentation type: bug Bug report and fix

Projects

None yet

Milestone

1.39.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jpbempel @cimi @PerfectSlayer