Skip to content

Do not leak call depth threadlocal in jdbc instrumentation#7468

Merged
amarziali merged 1 commit intomasterfrom
andrea.marziali/jdbc-fix
Aug 19, 2024
Merged

Do not leak call depth threadlocal in jdbc instrumentation#7468
amarziali merged 1 commit intomasterfrom
andrea.marziali/jdbc-fix

Conversation

@amarziali
Copy link
Copy Markdown
Contributor

@amarziali amarziali commented Aug 19, 2024 •
edited by atlassian Bot
Loading

What Does This Do

If the query info is missing, the jdbc advice onEnter is returning a null scope but the threadlocal for its calldepth is not reset.
That means that subsequent queries done on the same thread will not be traced because the calldepth threadlocal is dirty

Motivation

Additional Notes

Jira ticket: APMS-12988

@amarziali amarziali requested a review from a team as a code owner August 19, 2024 08:12
@PerfectSlayer PerfectSlayer added type: bug Bug report and fix inst: jdbc JDBC instrumentation labels Aug 19, 2024
PerfectSlayer
PerfectSlayer approved these changes Aug 19, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Aug 19, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/jdbc-fix
git_commit_date 1724051186 1724054953
git_commit_sha 26bee84 2eb99a2
release_version 1.39.0-SNAPSHOT~26bee84a41 1.39.0-SNAPSHOT~2eb99a23d7
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1724057352 1724057352
ci_job_id 608393219 608393219
ci_pipeline_id 42091697 42091697
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 15 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~2eb99a23d7, baseline=1.39.0-SNAPSHOT~26bee84a41

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1047093
Total [baseline] (8.492 s) : 0, 8491701
Agent [candidate] (1.065 s) : 0, 1064629
Total [candidate] (8.551 s) : 0, 8550608
section iast
Agent [baseline] (1.188 s) : 0, 1188499
Total [baseline] (9.042 s) : 0, 9042137
Agent [candidate] (1.175 s) : 0, 1175350
Total [candidate] (8.99 s) : 0, 8990398
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.176 s) : 0, 1175690
Total [baseline] (8.958 s) : 0, 8958246
Agent [candidate] (1.178 s) : 0, 1178319
Total [candidate] (8.968 s) : 0, 8968203
section iast_TELEMETRY_OFF
Agent [baseline] (1.181 s) : 0, 1180734
Total [baseline] (9.032 s) : 0, 9032000
Agent [candidate] (1.171 s) : 0, 1171315
Total [candidate] (8.992 s) : 0, 8992153
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.047 s -
Agent iast 1.188 s 141.406 ms (13.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.176 s 128.597 ms (12.3%)
Agent iast_TELEMETRY_OFF 1.181 s 133.641 ms (12.8%)
Total tracing 8.492 s -
Total iast 9.042 s 550.436 ms (6.5%)
Total iast_HARDCODED_SECRET_DISABLED 8.958 s 466.546 ms (5.5%)
Total iast_TELEMETRY_OFF 9.032 s 540.299 ms (6.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.065 s -
Agent iast 1.175 s 110.721 ms (10.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.178 s 113.69 ms (10.7%)
Agent iast_TELEMETRY_OFF 1.171 s 106.686 ms (10.0%)
Total tracing 8.551 s -
Total iast 8.99 s 439.791 ms (5.1%)
Total iast_HARDCODED_SECRET_DISABLED 8.968 s 417.596 ms (4.9%)
Total iast_TELEMETRY_OFF 8.992 s 441.545 ms (5.2%) 
gantt
    title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~2eb99a23d7, baseline=1.39.0-SNAPSHOT~26bee84a41

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (667.978 ms) : 0, 667978
BytebuddyAgent [candidate] (679.927 ms) : 0, 679927
GlobalTracer [baseline] (306.201 ms) : 0, 306201
GlobalTracer [candidate] (310.916 ms) : 0, 310916
AppSec [baseline] (51.166 ms) : 0, 51166
AppSec [candidate] (51.766 ms) : 0, 51766
Remote Config [baseline] (690.129 µs) : 0, 690
Remote Config [candidate] (694.485 µs) : 0, 694
Telemetry [baseline] (7.58 ms) : 0, 7580
Telemetry [candidate] (7.589 ms) : 0, 7589
section iast
BytebuddyAgent [baseline] (790.549 ms) : 0, 790549
BytebuddyAgent [candidate] (781.952 ms) : 0, 781952
GlobalTracer [baseline] (299.421 ms) : 0, 299421
GlobalTracer [candidate] (295.947 ms) : 0, 295947
AppSec [baseline] (51.077 ms) : 0, 51077
AppSec [candidate] (51.251 ms) : 0, 51251
Remote Config [baseline] (585.254 µs) : 0, 585
Remote Config [candidate] (596.22 µs) : 0, 596
Telemetry [baseline] (10.406 ms) : 0, 10406
Telemetry [candidate] (9.486 ms) : 0, 9486
IAST [baseline] (22.843 ms) : 0, 22843
IAST [candidate] (22.612 ms) : 0, 22612
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (781.756 ms) : 0, 781756
BytebuddyAgent [candidate] (782.971 ms) : 0, 782971
GlobalTracer [baseline] (296.332 ms) : 0, 296332
GlobalTracer [candidate] (297.618 ms) : 0, 297618
AppSec [baseline] (48.596 ms) : 0, 48596
AppSec [candidate] (48.766 ms) : 0, 48766
Remote Config [baseline] (577.564 µs) : 0, 578
Remote Config [candidate] (571.358 µs) : 0, 571
Telemetry [baseline] (9.548 ms) : 0, 9548
Telemetry [candidate] (7.944 ms) : 0, 7944
IAST [baseline] (25.329 ms) : 0, 25329
IAST [candidate] (26.89 ms) : 0, 26890
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (785.759 ms) : 0, 785759
BytebuddyAgent [candidate] (780.927 ms) : 0, 780927
GlobalTracer [baseline] (298.544 ms) : 0, 298544
GlobalTracer [candidate] (297.191 ms) : 0, 297191
AppSec [baseline] (52.584 ms) : 0, 52584
AppSec [candidate] (50.487 ms) : 0, 50487
Remote Config [baseline] (625.024 µs) : 0, 625
Remote Config [candidate] (613.945 µs) : 0, 614
Telemetry [baseline] (7.95 ms) : 0, 7950
Telemetry [candidate] (7.125 ms) : 0, 7125
IAST [baseline] (21.62 ms) : 0, 21620
IAST [candidate] (21.384 ms) : 0, 21384
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~2eb99a23d7, baseline=1.39.0-SNAPSHOT~26bee84a41

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1048758
Total [baseline] (10.376 s) : 0, 10375679
Agent [candidate] (1.049 s) : 0, 1048726
Total [candidate] (10.339 s) : 0, 10339177
section appsec
Agent [baseline] (1.175 s) : 0, 1175400
Total [baseline] (10.508 s) : 0, 10507754
Agent [candidate] (1.172 s) : 0, 1172204
Total [candidate] (10.442 s) : 0, 10442013
section iast
Agent [baseline] (1.181 s) : 0, 1181222
Total [baseline] (10.901 s) : 0, 10901076
Agent [candidate] (1.187 s) : 0, 1187014
Total [candidate] (10.849 s) : 0, 10849144
section profiling
Agent [baseline] (1.249 s) : 0, 1248933
Total [baseline] (10.52 s) : 0, 10519598
Agent [candidate] (1.265 s) : 0, 1264745
Total [candidate] (10.698 s) : 0, 10697708
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.049 s -
Agent appsec 1.175 s 126.642 ms (12.1%)
Agent iast 1.181 s 132.464 ms (12.6%)
Agent profiling 1.249 s 200.175 ms (19.1%)
Total tracing 10.376 s -
Total appsec 10.508 s 132.075 ms (1.3%)
Total iast 10.901 s 525.397 ms (5.1%)
Total profiling 10.52 s 143.919 ms (1.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.049 s -
Agent appsec 1.172 s 123.478 ms (11.8%)
Agent iast 1.187 s 138.288 ms (13.2%)
Agent profiling 1.265 s 216.019 ms (20.6%)
Total tracing 10.339 s -
Total appsec 10.442 s 102.836 ms (1.0%)
Total iast 10.849 s 509.967 ms (4.9%)
Total profiling 10.698 s 358.531 ms (3.5%) 
gantt
    title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~2eb99a23d7, baseline=1.39.0-SNAPSHOT~26bee84a41

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (668.905 ms) : 0, 668905
BytebuddyAgent [candidate] (668.84 ms) : 0, 668840
GlobalTracer [baseline] (307.252 ms) : 0, 307252
GlobalTracer [candidate] (306.939 ms) : 0, 306939
AppSec [baseline] (50.932 ms) : 0, 50932
AppSec [candidate] (51.268 ms) : 0, 51268
Remote Config [baseline] (683.391 µs) : 0, 683
Remote Config [candidate] (684.896 µs) : 0, 685
Telemetry [baseline] (7.505 ms) : 0, 7505
Telemetry [candidate] (7.513 ms) : 0, 7513
section appsec
BytebuddyAgent [baseline] (682.447 ms) : 0, 682447
BytebuddyAgent [candidate] (680.419 ms) : 0, 680419
GlobalTracer [baseline] (301.365 ms) : 0, 301365
GlobalTracer [candidate] (300.915 ms) : 0, 300915
AppSec [baseline] (158.201 ms) : 0, 158201
AppSec [candidate] (157.043 ms) : 0, 157043
IAST [baseline] (22.044 ms) : 0, 22044
IAST [candidate] (22.152 ms) : 0, 22152
Remote Config [baseline] (605.084 µs) : 0, 605
Remote Config [candidate] (600.887 µs) : 0, 601
Telemetry [baseline] (8.16 ms) : 0, 8160
Telemetry [candidate] (8.644 ms) : 0, 8644
section iast
BytebuddyAgent [baseline] (785.71 ms) : 0, 785710
BytebuddyAgent [candidate] (789.408 ms) : 0, 789408
GlobalTracer [baseline] (297.721 ms) : 0, 297721
GlobalTracer [candidate] (298.986 ms) : 0, 298986
AppSec [baseline] (51.655 ms) : 0, 51655
AppSec [candidate] (51.935 ms) : 0, 51935
IAST [baseline] (22.549 ms) : 0, 22549
IAST [candidate] (22.834 ms) : 0, 22834
Remote Config [baseline] (594.583 µs) : 0, 595
Remote Config [candidate] (585.643 µs) : 0, 586
Telemetry [baseline] (9.432 ms) : 0, 9432
Telemetry [candidate] (9.624 ms) : 0, 9624
section profiling
BytebuddyAgent [baseline] (665.091 ms) : 0, 665091
BytebuddyAgent [candidate] (674.367 ms) : 0, 674367
GlobalTracer [baseline] (391.537 ms) : 0, 391537
GlobalTracer [candidate] (395.392 ms) : 0, 395392
AppSec [baseline] (52.315 ms) : 0, 52315
AppSec [candidate] (52.627 ms) : 0, 52627
Remote Config [baseline] (693.886 µs) : 0, 694
Remote Config [candidate] (703.928 µs) : 0, 704
Telemetry [baseline] (7.432 ms) : 0, 7432
Telemetry [candidate] (7.574 ms) : 0, 7574
ProfilingAgent [baseline] (94.602 ms) : 0, 94602
ProfilingAgent [candidate] (96.24 ms) : 0, 96240
Profiling [baseline] (94.626 ms) : 0, 94626
Profiling [candidate] (96.265 ms) : 0, 96265
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-08-19T08:17:46 2024-08-19T08:24:32
git_branch master andrea.marziali/jdbc-fix
git_commit_date 1724051186 1724054953
git_commit_sha 26bee84 2eb99a2
release_version 1.39.0-SNAPSHOT~26bee84a41 1.39.0-SNAPSHOT~2eb99a23d7
start_time 2024-08-19T08:17:33 2024-08-19T08:24:19
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1724056216 1724056216
ci_job_id 608393220 608393220
ci_pipeline_id 42091697 42091697
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~2eb99a23d7, baseline=1.39.0-SNAPSHOT~26bee84a41
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.341 ms) : 1322, 1361
.   : milestone, 1341,
appsec (1.706 ms) : 1681, 1730
.   : milestone, 1706,
appsec_no_iast (1.704 ms) : 1679, 1730
.   : milestone, 1704,
iast (1.475 ms) : 1452, 1498
.   : milestone, 1475,
profiling (1.478 ms) : 1453, 1503
.   : milestone, 1478,
tracing (1.451 ms) : 1426, 1476
.   : milestone, 1451,
section candidate
no_agent (1.336 ms) : 1317, 1356
.   : milestone, 1336,
appsec (1.731 ms) : 1708, 1755
.   : milestone, 1731,
appsec_no_iast (1.711 ms) : 1686, 1737
.   : milestone, 1711,
iast (1.482 ms) : 1461, 1504
.   : milestone, 1482,
profiling (1.499 ms) : 1473, 1526
.   : milestone, 1499,
tracing (1.463 ms) : 1437, 1488
.   : milestone, 1463,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.341 ms [1.322 ms, 1.361 ms] -
appsec 1.706 ms [1.681 ms, 1.73 ms] 364.185 µs (27.1%)
appsec_no_iast 1.704 ms [1.679 ms, 1.73 ms] 362.773 µs (27.0%)
iast 1.475 ms [1.452 ms, 1.498 ms] 133.818 µs (10.0%)
profiling 1.478 ms [1.453 ms, 1.503 ms] 136.702 µs (10.2%)
tracing 1.451 ms [1.426 ms, 1.476 ms] 109.874 µs (8.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.336 ms [1.317 ms, 1.356 ms] -
appsec 1.731 ms [1.708 ms, 1.755 ms] 394.756 µs (29.5%)
appsec_no_iast 1.711 ms [1.686 ms, 1.737 ms] 374.919 µs (28.1%)
iast 1.482 ms [1.461 ms, 1.504 ms] 145.899 µs (10.9%)
profiling 1.499 ms [1.473 ms, 1.526 ms] 162.58 µs (12.2%)
tracing 1.463 ms [1.437 ms, 1.488 ms] 126.145 µs (9.4%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~2eb99a23d7, baseline=1.39.0-SNAPSHOT~26bee84a41
    dateFormat X
    axisFormat %s
section baseline
no_agent (360.828 µs) : 341, 381
.   : milestone, 361,
iast (475.404 µs) : 454, 496
.   : milestone, 475,
iast_FULL (547.303 µs) : 525, 570
.   : milestone, 547,
iast_GLOBAL (501.277 µs) : 479, 524
.   : milestone, 501,
iast_HARDCODED_SECRET_DISABLED (469.198 µs) : 448, 490
.   : milestone, 469,
iast_INACTIVE (453.561 µs) : 431, 476
.   : milestone, 454,
iast_TELEMETRY_OFF (469.504 µs) : 448, 491
.   : milestone, 470,
tracing (435.003 µs) : 415, 455
.   : milestone, 435,
section candidate
no_agent (363.655 µs) : 344, 384
.   : milestone, 364,
iast (476.119 µs) : 455, 497
.   : milestone, 476,
iast_FULL (551.749 µs) : 529, 574
.   : milestone, 552,
iast_GLOBAL (498.464 µs) : 476, 521
.   : milestone, 498,
iast_HARDCODED_SECRET_DISABLED (471.156 µs) : 450, 492
.   : milestone, 471,
iast_INACTIVE (449.732 µs) : 428, 472
.   : milestone, 450,
iast_TELEMETRY_OFF (463.875 µs) : 443, 485
.   : milestone, 464,
tracing (436.842 µs) : 417, 457
.   : milestone, 437,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 360.828 µs [340.929 µs, 380.727 µs] -
iast 475.404 µs [454.482 µs, 496.325 µs] 114.576 µs (31.8%)
iast_FULL 547.303 µs [524.865 µs, 569.742 µs] 186.475 µs (51.7%)
iast_GLOBAL 501.277 µs [478.943 µs, 523.611 µs] 140.449 µs (38.9%)
iast_HARDCODED_SECRET_DISABLED 469.198 µs [448.04 µs, 490.355 µs] 108.37 µs (30.0%)
iast_INACTIVE 453.561 µs [430.887 µs, 476.234 µs] 92.733 µs (25.7%)
iast_TELEMETRY_OFF 469.504 µs [447.921 µs, 491.086 µs] 108.676 µs (30.1%)
tracing 435.003 µs [414.82 µs, 455.186 µs] 74.175 µs (20.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 363.655 µs [343.698 µs, 383.612 µs] -
iast 476.119 µs [455.032 µs, 497.206 µs] 112.464 µs (30.9%)
iast_FULL 551.749 µs [529.213 µs, 574.284 µs] 188.094 µs (51.7%)
iast_GLOBAL 498.464 µs [476.391 µs, 520.537 µs] 134.809 µs (37.1%)
iast_HARDCODED_SECRET_DISABLED 471.156 µs [450.317 µs, 491.996 µs] 107.502 µs (29.6%)
iast_INACTIVE 449.732 µs [427.692 µs, 471.771 µs] 86.077 µs (23.7%)
iast_TELEMETRY_OFF 463.875 µs [442.949 µs, 484.802 µs] 100.221 µs (27.6%)
tracing 436.842 µs [416.547 µs, 457.136 µs] 73.187 µs (20.1%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/jdbc-fix
git_commit_date 1724051186 1724054953
git_commit_sha 26bee84 2eb99a2
release_version 1.39.0-SNAPSHOT~26bee84a41 1.39.0-SNAPSHOT~2eb99a23d7
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1724056732 1724056732
ci_job_id 608393221 608393221
ci_pipeline_id 42091697 42091697
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~2eb99a23d7, baseline=1.39.0-SNAPSHOT~26bee84a41
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.459 ms) : 1448, 1470
.   : milestone, 1459,
appsec (2.229 ms) : 2194, 2263
.   : milestone, 2229,
iast (1.963 ms) : 1922, 2005
.   : milestone, 1963,
iast_GLOBAL (2.02 ms) : 1978, 2062
.   : milestone, 2020,
profiling (1.863 ms) : 1828, 1899
.   : milestone, 1863,
tracing (1.842 ms) : 1809, 1875
.   : milestone, 1842,
section candidate
no_agent (1.459 ms) : 1448, 1470
.   : milestone, 1459,
appsec (2.218 ms) : 2183, 2253
.   : milestone, 2218,
iast (1.968 ms) : 1927, 2010
.   : milestone, 1968,
iast_GLOBAL (2.015 ms) : 1972, 2058
.   : milestone, 2015,
profiling (1.858 ms) : 1823, 1892
.   : milestone, 1858,
tracing (1.842 ms) : 1809, 1875
.   : milestone, 1842,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.459 ms [1.448 ms, 1.47 ms] -
appsec 2.229 ms [2.194 ms, 2.263 ms] 769.467 µs (52.7%)
iast 1.963 ms [1.922 ms, 2.005 ms] 504.411 µs (34.6%)
iast_GLOBAL 2.02 ms [1.978 ms, 2.062 ms] 560.833 µs (38.4%)
profiling 1.863 ms [1.828 ms, 1.899 ms] 404.13 µs (27.7%)
tracing 1.842 ms [1.809 ms, 1.875 ms] 382.817 µs (26.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.459 ms [1.448 ms, 1.47 ms] -
appsec 2.218 ms [2.183 ms, 2.253 ms] 758.692 µs (52.0%)
iast 1.968 ms [1.927 ms, 2.01 ms] 509.143 µs (34.9%)
iast_GLOBAL 2.015 ms [1.972 ms, 2.058 ms] 555.764 µs (38.1%)
profiling 1.858 ms [1.823 ms, 1.892 ms] 398.482 µs (27.3%)
tracing 1.842 ms [1.809 ms, 1.875 ms] 382.869 µs (26.2%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~2eb99a23d7, baseline=1.39.0-SNAPSHOT~26bee84a41
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.08 s) : 15080000, 15080000
.   : milestone, 15080000,
appsec (15.222 s) : 15222000, 15222000
.   : milestone, 15222000,
iast (18.958 s) : 18958000, 18958000
.   : milestone, 18958000,
iast_GLOBAL (17.749 s) : 17749000, 17749000
.   : milestone, 17749000,
profiling (15.484 s) : 15484000, 15484000
.   : milestone, 15484000,
tracing (15.101 s) : 15101000, 15101000
.   : milestone, 15101000,
section candidate
no_agent (15.715 s) : 15715000, 15715000
.   : milestone, 15715000,
appsec (15.259 s) : 15259000, 15259000
.   : milestone, 15259000,
iast (18.67 s) : 18670000, 18670000
.   : milestone, 18670000,
iast_GLOBAL (17.979 s) : 17979000, 17979000
.   : milestone, 17979000,
profiling (15.871 s) : 15871000, 15871000
.   : milestone, 15871000,
tracing (14.851 s) : 14851000, 14851000
.   : milestone, 14851000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.08 s [15.08 s, 15.08 s] -
appsec 15.222 s [15.222 s, 15.222 s] 142.0 ms (0.9%)
iast 18.958 s [18.958 s, 18.958 s] 3.878 s (25.7%)
iast_GLOBAL 17.749 s [17.749 s, 17.749 s] 2.669 s (17.7%)
profiling 15.484 s [15.484 s, 15.484 s] 404.0 ms (2.7%)
tracing 15.101 s [15.101 s, 15.101 s] 21.0 ms (0.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.715 s [15.715 s, 15.715 s] -
appsec 15.259 s [15.259 s, 15.259 s] -456.0 ms (-2.9%)
iast 18.67 s [18.67 s, 18.67 s] 2.955 s (18.8%)
iast_GLOBAL 17.979 s [17.979 s, 17.979 s] 2.264 s (14.4%)
profiling 15.871 s [15.871 s, 15.871 s] 156.0 ms (1.0%)
tracing 14.851 s [14.851 s, 14.851 s] -864.0 ms (-5.5%)

@amarziali amarziali merged commit 5ae921b into master Aug 19, 2024
@amarziali amarziali deleted the andrea.marziali/jdbc-fix branch August 19, 2024 09:28
@github-actions github-actions Bot added this to the 1.39.0 milestone Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcculls mcculls mcculls approved these changes

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

Assignees

No one assigned

Labels

inst: jdbc JDBC instrumentation type: bug Bug report and fix

Projects

None yet

Milestone

1.39.0

Development

Successfully merging this pull request may close these issues.

3 participants

@amarziali @mcculls @PerfectSlayer