Skip to content

Tag span metrics with 'otel.library' when we know it was created by an OTel extension#7463

Merged
mcculls merged 1 commit intomasterfrom
mcculls/custom_instrumentation_telemetry
Aug 19, 2024
Merged

Tag span metrics with 'otel.library' when we know it was created by an OTel extension#7463
mcculls merged 1 commit intomasterfrom
mcculls/custom_instrumentation_telemetry

Conversation

@mcculls
Copy link
Copy Markdown
Contributor

@mcculls mcculls commented Aug 18, 2024 •
edited by atlassian Bot
Loading

Motivation

Helps distinguish span metrics from OTel extensions with those from manual OTel instrumentation.

Additional Notes

Metrics for spans created manually via the OTel API continue to be tagged with 'otel'.

Jira ticket: APMAPI-153

@mcculls mcculls added comp: telemetry Telemetry inst: opentelemetry OpenTelemetry instrumentation labels Aug 18, 2024
@mcculls
Tag span metrics with 'otel.library' when we know it was created by a…
f64a035 
…n OTel extension.

Metrics for spans created manually via the OTel API continue to be tagged with 'otel'.
@mcculls mcculls force-pushed the mcculls/custom_instrumentation_telemetry branch from 22c162d to f64a035 Compare August 18, 2024 15:38
@mcculls mcculls marked this pull request as ready for review August 18, 2024 16:03
@mcculls mcculls requested a review from a team as a code owner August 18, 2024 16:03
@mcculls mcculls requested review from dougqh and nayeem-kamal August 18, 2024 16:03
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Aug 18, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/custom_instrumentation_telemetry
git_commit_date 1723811562 1723995500
git_commit_sha 529f893 f64a035
release_version 1.39.0-SNAPSHOT~529f893c6a 1.39.0-SNAPSHOT~f64a035a77
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1723997899 1723997899
ci_job_id 608205539 608205539
ci_pipeline_id 42076548 42076548
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 16 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~f64a035a77, baseline=1.39.0-SNAPSHOT~529f893c6a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1046744
Total [baseline] (10.353 s) : 0, 10353226
Agent [candidate] (1.06 s) : 0, 1059682
Total [candidate] (10.386 s) : 0, 10386087
section appsec
Agent [baseline] (1.172 s) : 0, 1172123
Total [baseline] (10.51 s) : 0, 10510438
Agent [candidate] (1.176 s) : 0, 1176486
Total [candidate] (10.455 s) : 0, 10455187
section iast
Agent [baseline] (1.179 s) : 0, 1178707
Total [baseline] (10.864 s) : 0, 10863932
Agent [candidate] (1.186 s) : 0, 1186297
Total [candidate] (10.829 s) : 0, 10828685
section profiling
Agent [baseline] (1.246 s) : 0, 1246040
Total [baseline] (10.588 s) : 0, 10588153
Agent [candidate] (1.247 s) : 0, 1247486
Total [candidate] (10.575 s) : 0, 10575231
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.047 s -
Agent appsec 1.172 s 125.38 ms (12.0%)
Agent iast 1.179 s 131.963 ms (12.6%)
Agent profiling 1.246 s 199.296 ms (19.0%)
Total tracing 10.353 s -
Total appsec 10.51 s 157.212 ms (1.5%)
Total iast 10.864 s 510.706 ms (4.9%)
Total profiling 10.588 s 234.927 ms (2.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.06 s -
Agent appsec 1.176 s 116.803 ms (11.0%)
Agent iast 1.186 s 126.614 ms (11.9%)
Agent profiling 1.247 s 187.803 ms (17.7%)
Total tracing 10.386 s -
Total appsec 10.455 s 69.099 ms (0.7%)
Total iast 10.829 s 442.598 ms (4.3%)
Total profiling 10.575 s 189.144 ms (1.8%) 
gantt
    title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~f64a035a77, baseline=1.39.0-SNAPSHOT~529f893c6a

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (668.237 ms) : 0, 668237
BytebuddyAgent [candidate] (677.115 ms) : 0, 677115
GlobalTracer [baseline] (305.944 ms) : 0, 305944
GlobalTracer [candidate] (309.156 ms) : 0, 309156
AppSec [baseline] (50.941 ms) : 0, 50941
AppSec [candidate] (51.592 ms) : 0, 51592
Remote Config [baseline] (687.633 µs) : 0, 688
Remote Config [candidate] (698.907 µs) : 0, 699
Telemetry [baseline] (7.486 ms) : 0, 7486
Telemetry [candidate] (7.532 ms) : 0, 7532
section appsec
BytebuddyAgent [baseline] (680.701 ms) : 0, 680701
BytebuddyAgent [candidate] (683.179 ms) : 0, 683179
GlobalTracer [baseline] (300.567 ms) : 0, 300567
GlobalTracer [candidate] (301.675 ms) : 0, 301675
AppSec [baseline] (157.326 ms) : 0, 157326
AppSec [candidate] (157.988 ms) : 0, 157988
Remote Config [baseline] (600.076 µs) : 0, 600
Remote Config [candidate] (607.652 µs) : 0, 608
Telemetry [baseline] (8.389 ms) : 0, 8389
Telemetry [candidate] (8.412 ms) : 0, 8412
IAST [baseline] (22.036 ms) : 0, 22036
IAST [candidate] (22.055 ms) : 0, 22055
section iast
BytebuddyAgent [baseline] (783.672 ms) : 0, 783672
BytebuddyAgent [candidate] (788.879 ms) : 0, 788879
GlobalTracer [baseline] (297.275 ms) : 0, 297275
GlobalTracer [candidate] (298.863 ms) : 0, 298863
AppSec [baseline] (53.017 ms) : 0, 53017
AppSec [candidate] (52.0 ms) : 0, 52000
Remote Config [baseline] (584.122 µs) : 0, 584
Remote Config [candidate] (579.056 µs) : 0, 579
Telemetry [baseline] (8.079 ms) : 0, 8079
Telemetry [candidate] (8.016 ms) : 0, 8016
IAST [baseline] (22.564 ms) : 0, 22564
IAST [candidate] (24.356 ms) : 0, 24356
section profiling
BytebuddyAgent [baseline] (663.386 ms) : 0, 663386
BytebuddyAgent [candidate] (664.315 ms) : 0, 664315
GlobalTracer [baseline] (390.718 ms) : 0, 390718
GlobalTracer [candidate] (391.197 ms) : 0, 391197
AppSec [baseline] (52.282 ms) : 0, 52282
AppSec [candidate] (52.287 ms) : 0, 52287
Remote Config [baseline] (691.717 µs) : 0, 692
Remote Config [candidate] (693.656 µs) : 0, 694
Telemetry [baseline] (7.39 ms) : 0, 7390
Telemetry [candidate] (7.42 ms) : 0, 7420
ProfilingAgent [baseline] (94.465 ms) : 0, 94465
ProfilingAgent [candidate] (94.353 ms) : 0, 94353
Profiling [baseline] (94.49 ms) : 0, 94490
Profiling [candidate] (94.378 ms) : 0, 94378
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~f64a035a77, baseline=1.39.0-SNAPSHOT~529f893c6a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1052069
Total [baseline] (8.51 s) : 0, 8510347
Agent [candidate] (1.062 s) : 0, 1062253
Total [candidate] (8.545 s) : 0, 8545274
section iast
Agent [baseline] (1.176 s) : 0, 1175579
Total [baseline] (8.987 s) : 0, 8986569
Agent [candidate] (1.174 s) : 0, 1174027
Total [candidate] (8.982 s) : 0, 8982224
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.183 s) : 0, 1182926
Total [baseline] (9.019 s) : 0, 9018545
Agent [candidate] (1.182 s) : 0, 1181647
Total [candidate] (8.949 s) : 0, 8949301
section iast_TELEMETRY_OFF
Agent [baseline] (1.177 s) : 0, 1176900
Total [baseline] (9.014 s) : 0, 9013893
Agent [candidate] (1.175 s) : 0, 1174764
Total [candidate] (9.005 s) : 0, 9004922
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.052 s -
Agent iast 1.176 s 123.509 ms (11.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.183 s 130.857 ms (12.4%)
Agent iast_TELEMETRY_OFF 1.177 s 124.831 ms (11.9%)
Total tracing 8.51 s -
Total iast 8.987 s 476.222 ms (5.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.019 s 508.198 ms (6.0%)
Total iast_TELEMETRY_OFF 9.014 s 503.546 ms (5.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.062 s -
Agent iast 1.174 s 111.774 ms (10.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.182 s 119.395 ms (11.2%)
Agent iast_TELEMETRY_OFF 1.175 s 112.511 ms (10.6%)
Total tracing 8.545 s -
Total iast 8.982 s 436.95 ms (5.1%)
Total iast_HARDCODED_SECRET_DISABLED 8.949 s 404.027 ms (4.7%)
Total iast_TELEMETRY_OFF 9.005 s 459.647 ms (5.4%) 
gantt
    title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~f64a035a77, baseline=1.39.0-SNAPSHOT~529f893c6a

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (671.451 ms) : 0, 671451
BytebuddyAgent [candidate] (677.977 ms) : 0, 677977
GlobalTracer [baseline] (307.642 ms) : 0, 307642
GlobalTracer [candidate] (310.305 ms) : 0, 310305
AppSec [baseline] (51.259 ms) : 0, 51259
AppSec [candidate] (51.997 ms) : 0, 51997
Remote Config [baseline] (683.498 µs) : 0, 683
Remote Config [candidate] (689.982 µs) : 0, 690
Telemetry [baseline] (7.485 ms) : 0, 7485
Telemetry [candidate] (7.617 ms) : 0, 7617
section iast
BytebuddyAgent [baseline] (781.755 ms) : 0, 781755
BytebuddyAgent [candidate] (780.897 ms) : 0, 780897
GlobalTracer [baseline] (295.501 ms) : 0, 295501
GlobalTracer [candidate] (295.83 ms) : 0, 295830
AppSec [baseline] (50.124 ms) : 0, 50124
AppSec [candidate] (54.811 ms) : 0, 54811
IAST [baseline] (22.934 ms) : 0, 22934
IAST [candidate] (21.407 ms) : 0, 21407
Remote Config [baseline] (630.771 µs) : 0, 631
Remote Config [candidate] (564.319 µs) : 0, 564
Telemetry [baseline] (11.15 ms) : 0, 11150
Telemetry [candidate] (7.056 ms) : 0, 7056
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (788.043 ms) : 0, 788043
BytebuddyAgent [candidate] (786.634 ms) : 0, 786634
GlobalTracer [baseline] (298.215 ms) : 0, 298215
GlobalTracer [candidate] (298.233 ms) : 0, 298233
AppSec [baseline] (50.486 ms) : 0, 50486
AppSec [candidate] (48.576 ms) : 0, 48576
IAST [baseline] (23.028 ms) : 0, 23028
IAST [candidate] (24.454 ms) : 0, 24454
Remote Config [baseline] (601.527 µs) : 0, 602
Remote Config [candidate] (587.499 µs) : 0, 587
Telemetry [baseline] (8.942 ms) : 0, 8942
Telemetry [candidate] (9.573 ms) : 0, 9573
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (781.347 ms) : 0, 781347
BytebuddyAgent [candidate] (780.694 ms) : 0, 780694
GlobalTracer [baseline] (298.216 ms) : 0, 298216
GlobalTracer [candidate] (297.657 ms) : 0, 297657
AppSec [baseline] (54.426 ms) : 0, 54426
AppSec [candidate] (51.22 ms) : 0, 51220
IAST [baseline] (21.584 ms) : 0, 21584
IAST [candidate] (22.441 ms) : 0, 22441
Remote Config [baseline] (632.568 µs) : 0, 633
Remote Config [candidate] (615.408 µs) : 0, 615
Telemetry [baseline] (7.144 ms) : 0, 7144
Telemetry [candidate] (8.631 ms) : 0, 8631
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-08-18T15:49:01 2024-08-18T15:55:50
git_branch master mcculls/custom_instrumentation_telemetry
git_commit_date 1723811562 1723995500
git_commit_sha 529f893 f64a035
release_version 1.39.0-SNAPSHOT~529f893c6a 1.39.0-SNAPSHOT~f64a035a77
start_time 2024-08-18T15:48:47 2024-08-18T15:55:36
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1723996893 1723996893
ci_job_id 608205540 608205540
ci_pipeline_id 42076548 42076548
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 18 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~f64a035a77, baseline=1.39.0-SNAPSHOT~529f893c6a
    dateFormat X
    axisFormat %s
section baseline
no_agent (365.14 µs) : 346, 385
.   : milestone, 365,
iast (478.65 µs) : 457, 501
.   : milestone, 479,
iast_FULL (550.804 µs) : 528, 573
.   : milestone, 551,
iast_GLOBAL (507.116 µs) : 484, 530
.   : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (478.378 µs) : 457, 500
.   : milestone, 478,
iast_INACTIVE (455.222 µs) : 432, 478
.   : milestone, 455,
iast_TELEMETRY_OFF (467.544 µs) : 446, 489
.   : milestone, 468,
tracing (439.032 µs) : 418, 460
.   : milestone, 439,
section candidate
no_agent (358.609 µs) : 339, 378
.   : milestone, 359,
iast (487.378 µs) : 466, 509
.   : milestone, 487,
iast_FULL (544.936 µs) : 522, 567
.   : milestone, 545,
iast_GLOBAL (505.339 µs) : 483, 528
.   : milestone, 505,
iast_HARDCODED_SECRET_DISABLED (482.197 µs) : 461, 503
.   : milestone, 482,
iast_INACTIVE (457.353 µs) : 435, 480
.   : milestone, 457,
iast_TELEMETRY_OFF (472.435 µs) : 450, 495
.   : milestone, 472,
tracing (440.622 µs) : 420, 461
.   : milestone, 441,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 365.14 µs [345.698 µs, 384.582 µs] -
iast 478.65 µs [456.683 µs, 500.617 µs] 113.51 µs (31.1%)
iast_FULL 550.804 µs [528.299 µs, 573.309 µs] 185.664 µs (50.8%)
iast_GLOBAL 507.116 µs [483.801 µs, 530.431 µs] 141.976 µs (38.9%)
iast_HARDCODED_SECRET_DISABLED 478.378 µs [457.086 µs, 499.67 µs] 113.238 µs (31.0%)
iast_INACTIVE 455.222 µs [432.346 µs, 478.097 µs] 90.082 µs (24.7%)
iast_TELEMETRY_OFF 467.544 µs [446.268 µs, 488.82 µs] 102.404 µs (28.0%)
tracing 439.032 µs [418.094 µs, 459.971 µs] 73.892 µs (20.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 358.609 µs [339.216 µs, 378.002 µs] -
iast 487.378 µs [465.971 µs, 508.784 µs] 128.768 µs (35.9%)
iast_FULL 544.936 µs [522.44 µs, 567.433 µs] 186.327 µs (52.0%)
iast_GLOBAL 505.339 µs [482.515 µs, 528.163 µs] 146.73 µs (40.9%)
iast_HARDCODED_SECRET_DISABLED 482.197 µs [460.969 µs, 503.424 µs] 123.587 µs (34.5%)
iast_INACTIVE 457.353 µs [434.769 µs, 479.937 µs] 98.744 µs (27.5%)
iast_TELEMETRY_OFF 472.435 µs [450.26 µs, 494.61 µs] 113.826 µs (31.7%)
tracing 440.622 µs [420.412 µs, 460.831 µs] 82.012 µs (22.9%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~f64a035a77, baseline=1.39.0-SNAPSHOT~529f893c6a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.342 ms) : 1321, 1362
.   : milestone, 1342,
appsec (1.725 ms) : 1702, 1749
.   : milestone, 1725,
appsec_no_iast (1.713 ms) : 1689, 1738
.   : milestone, 1713,
iast (1.48 ms) : 1457, 1502
.   : milestone, 1480,
profiling (1.524 ms) : 1498, 1549
.   : milestone, 1524,
tracing (1.472 ms) : 1449, 1496
.   : milestone, 1472,
section candidate
no_agent (1.336 ms) : 1317, 1355
.   : milestone, 1336,
appsec (1.716 ms) : 1692, 1740
.   : milestone, 1716,
appsec_no_iast (1.714 ms) : 1689, 1739
.   : milestone, 1714,
iast (1.481 ms) : 1459, 1502
.   : milestone, 1481,
profiling (1.479 ms) : 1455, 1504
.   : milestone, 1479,
tracing (1.45 ms) : 1426, 1475
.   : milestone, 1450,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.342 ms [1.321 ms, 1.362 ms] -
appsec 1.725 ms [1.702 ms, 1.749 ms] 383.637 µs (28.6%)
appsec_no_iast 1.713 ms [1.689 ms, 1.738 ms] 371.69 µs (27.7%)
iast 1.48 ms [1.457 ms, 1.502 ms] 137.895 µs (10.3%)
profiling 1.524 ms [1.498 ms, 1.549 ms] 182.009 µs (13.6%)
tracing 1.472 ms [1.449 ms, 1.496 ms] 130.838 µs (9.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.336 ms [1.317 ms, 1.355 ms] -
appsec 1.716 ms [1.692 ms, 1.74 ms] 379.822 µs (28.4%)
appsec_no_iast 1.714 ms [1.689 ms, 1.739 ms] 377.705 µs (28.3%)
iast 1.481 ms [1.459 ms, 1.502 ms] 144.325 µs (10.8%)
profiling 1.479 ms [1.455 ms, 1.504 ms] 142.859 µs (10.7%)
tracing 1.45 ms [1.426 ms, 1.475 ms] 114.1 µs (8.5%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/custom_instrumentation_telemetry
git_commit_date 1723811562 1723995500
git_commit_sha 529f893 f64a035
release_version 1.39.0-SNAPSHOT~529f893c6a 1.39.0-SNAPSHOT~f64a035a77
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1723997414 1723997414
ci_job_id 608205541 608205541
ci_pipeline_id 42076548 42076548
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~f64a035a77, baseline=1.39.0-SNAPSHOT~529f893c6a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.459 ms) : 1448, 1471
.   : milestone, 1459,
appsec (2.213 ms) : 2178, 2248
.   : milestone, 2213,
iast (1.972 ms) : 1930, 2015
.   : milestone, 1972,
iast_GLOBAL (2.012 ms) : 1968, 2055
.   : milestone, 2012,
profiling (1.851 ms) : 1816, 1885
.   : milestone, 1851,
tracing (1.844 ms) : 1810, 1877
.   : milestone, 1844,
section candidate
no_agent (1.457 ms) : 1445, 1468
.   : milestone, 1457,
appsec (2.221 ms) : 2185, 2256
.   : milestone, 2221,
iast (1.969 ms) : 1927, 2011
.   : milestone, 1969,
iast_GLOBAL (2.009 ms) : 1965, 2052
.   : milestone, 2009,
profiling (1.859 ms) : 1825, 1894
.   : milestone, 1859,
tracing (1.822 ms) : 1789, 1854
.   : milestone, 1822,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.459 ms [1.448 ms, 1.471 ms] -
appsec 2.213 ms [2.178 ms, 2.248 ms] 753.749 µs (51.7%)
iast 1.972 ms [1.93 ms, 2.015 ms] 512.92 µs (35.1%)
iast_GLOBAL 2.012 ms [1.968 ms, 2.055 ms] 552.319 µs (37.8%)
profiling 1.851 ms [1.816 ms, 1.885 ms] 391.21 µs (26.8%)
tracing 1.844 ms [1.81 ms, 1.877 ms] 384.604 µs (26.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.457 ms [1.445 ms, 1.468 ms] -
appsec 2.221 ms [2.185 ms, 2.256 ms] 763.985 µs (52.4%)
iast 1.969 ms [1.927 ms, 2.011 ms] 512.416 µs (35.2%)
iast_GLOBAL 2.009 ms [1.965 ms, 2.052 ms] 551.852 µs (37.9%)
profiling 1.859 ms [1.825 ms, 1.894 ms] 402.673 µs (27.6%)
tracing 1.822 ms [1.789 ms, 1.854 ms] 364.916 µs (25.1%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~f64a035a77, baseline=1.39.0-SNAPSHOT~529f893c6a
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.991 s) : 14991000, 14991000
.   : milestone, 14991000,
appsec (15.288 s) : 15288000, 15288000
.   : milestone, 15288000,
iast (18.871 s) : 18871000, 18871000
.   : milestone, 18871000,
iast_GLOBAL (18.05 s) : 18050000, 18050000
.   : milestone, 18050000,
profiling (15.163 s) : 15163000, 15163000
.   : milestone, 15163000,
tracing (15.033 s) : 15033000, 15033000
.   : milestone, 15033000,
section candidate
no_agent (15.018 s) : 15018000, 15018000
.   : milestone, 15018000,
appsec (14.89 s) : 14890000, 14890000
.   : milestone, 14890000,
iast (18.797 s) : 18797000, 18797000
.   : milestone, 18797000,
iast_GLOBAL (17.956 s) : 17956000, 17956000
.   : milestone, 17956000,
profiling (15.972 s) : 15972000, 15972000
.   : milestone, 15972000,
tracing (15.326 s) : 15326000, 15326000
.   : milestone, 15326000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.991 s [14.991 s, 14.991 s] -
appsec 15.288 s [15.288 s, 15.288 s] 297.0 ms (2.0%)
iast 18.871 s [18.871 s, 18.871 s] 3.88 s (25.9%)
iast_GLOBAL 18.05 s [18.05 s, 18.05 s] 3.059 s (20.4%)
profiling 15.163 s [15.163 s, 15.163 s] 172.0 ms (1.1%)
tracing 15.033 s [15.033 s, 15.033 s] 42.0 ms (0.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.018 s [15.018 s, 15.018 s] -
appsec 14.89 s [14.89 s, 14.89 s] -128.0 ms (-0.9%)
iast 18.797 s [18.797 s, 18.797 s] 3.779 s (25.2%)
iast_GLOBAL 17.956 s [17.956 s, 17.956 s] 2.938 s (19.6%)
profiling 15.972 s [15.972 s, 15.972 s] 954.0 ms (6.4%)
tracing 15.326 s [15.326 s, 15.326 s] 308.0 ms (2.1%)

@mcculls mcculls merged commit 0c5f7c2 into master Aug 19, 2024
@mcculls mcculls deleted the mcculls/custom_instrumentation_telemetry branch August 19, 2024 11:36
@github-actions github-actions Bot added this to the 1.39.0 milestone Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amarziali amarziali amarziali approved these changes

@dougqh dougqh Awaiting requested review from dougqh dougqh was automatically assigned from DataDog/apm-java

@nayeem-kamal nayeem-kamal Awaiting requested review from nayeem-kamal nayeem-kamal was automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

comp: telemetry Telemetry inst: opentelemetry OpenTelemetry instrumentation

Projects

None yet

Milestone

1.39.0

Development

Successfully merging this pull request may close these issues.

2 participants

@mcculls @amarziali