Skip to content

Add exclusion predefined redaction keywords#7457

Merged
jpbempel merged 1 commit intomasterfrom
jpbempel/exclude-redaction-ids
Aug 29, 2024
Merged

Add exclusion predefined redaction keywords#7457
jpbempel merged 1 commit intomasterfrom
jpbempel/exclude-redaction-ids

Conversation

@jpbempel
Copy link
Copy Markdown
Member

@jpbempel jpbempel commented Aug 16, 2024 •
edited by atlassian Bot
Loading

What Does This Do

In the list of predefined keywords some of them could be too generic or wanted see the content of a session for example. introduced the config parameter
DD_DYNAMIC_ISTRUMENTATION_REDACTION_EXCLUDED_IDENTIFIERS for a comma list of identifiers you want to exclude from redacted keywords

Motivation

Additional Notes

Contributor Checklist

Jira ticket: DEBUG-2452

@jpbempel jpbempel requested review from a team as code owners August 16, 2024 13:09
@jpbempel jpbempel requested review from mcculls, nayeem-kamal and ojung and removed request for a team August 16, 2024 13:09
@jpbempel jpbempel added comp: debugger Dynamic Instrumentation type: enhancement Enhancements and improvements labels Aug 16, 2024
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Aug 16, 2024 •
edited
Loading

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1724423051 1724423430
end_time 2024-08-23T14:25:24 2024-08-23T14:31:44
git_branch master jpbempel/exclude-redaction-ids
git_commit_sha a4f73e2 c82c35d
start_time 2024-08-23T14:24:12 2024-08-23T14:30:31
See matching parameters
Baseline Candidate
ci_job_id 615326090 615326090
ci_pipeline_id 42686058 42686058
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1724422386 1724422386

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 6 metrics, 9 unstable metrics.

See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-10.336µs; +20.887µs] or [-4.086%; +8.256%]		 unstable
[-20.510µs; +32.304µs] or [-7.142%; +11.250%]		 unstable
[-32.406µs; +42.852µs] or [-10.801%; +14.283%]		 unstable
[-80.441µs; +88.952µs] or [-12.697%; +14.041%]		 same
scenario:basic unstable
[-34.623µs; +13.533µs] or [-12.442%; +4.863%]		 unstable
[-39.746µs; +15.040µs] or [-12.967%; +4.907%]		 unstable
[-43.791µs; +15.064µs] or [-13.791%; +4.744%]		 unstable
[-980.724µs; +322.460µs] or [-105.619%; +34.727%]		 unstable
[-120.129op/s; +255.082op/s] or [-4.685%; +9.948%]
scenario:loop same same same same same
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (287.152 µs) : 264, 310
.   : milestone, 287,
basic (306.525 µs) : 270, 343
.   : milestone, 307,
loop (10.551 ms) : 10431, 10672
.   : milestone, 10551,
section candidate
noprobe (293.049 µs) : 266, 321
.   : milestone, 293,
basic (294.172 µs) : 286, 303
.   : milestone, 294,
loop (10.517 ms) : 10484, 10550
.   : milestone, 10517,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 287.152 µs [264.439 µs, 309.865 µs]
basic 306.525 µs [269.608 µs, 343.441 µs]
loop 10.551 ms [10.431 ms, 10.672 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 293.049 µs [265.584 µs, 320.515 µs]
basic 294.172 µs [285.593 µs, 302.751 µs]
loop 10.517 ms [10.484 ms, 10.55 ms]

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Aug 16, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/exclude-redaction-ids
git_commit_date 1724422468 1724422386
git_commit_sha a4f73e2 c82c35d
release_version 1.39.0-SNAPSHOT~a4f73e2ed0 1.39.0-SNAPSHOT~c82c35d688
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1724424784 1724424784
ci_job_id 615326080 615326080
ci_pipeline_id 42686058 42686058
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 2 performance regressions! Performance is the same for 46 metrics, 15 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:insecure-bank:iast_TELEMETRY_OFF:Remote Config worse
[+28.495µs; +78.675µs] or [+4.975%; +13.735%]		 626.399µs 572.813µs
scenario:startup:petclinic:tracing:Remote Config worse
[+14.191µs; +34.502µs] or [+2.145%; +5.216%]		 685.862µs 661.515µs
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~c82c35d688, baseline=1.39.0-SNAPSHOT~a4f73e2ed0

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.044 s) : 0, 1044040
Total [baseline] (8.48 s) : 0, 8480395
Agent [candidate] (1.044 s) : 0, 1044261
Total [candidate] (8.488 s) : 0, 8488077
section iast
Agent [baseline] (1.173 s) : 0, 1173142
Total [baseline] (8.991 s) : 0, 8990646
Agent [candidate] (1.175 s) : 0, 1174839
Total [candidate] (8.976 s) : 0, 8975575
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.176 s) : 0, 1175628
Total [baseline] (8.951 s) : 0, 8950948
Agent [candidate] (1.183 s) : 0, 1182935
Total [candidate] (9.019 s) : 0, 9018936
section iast_TELEMETRY_OFF
Agent [baseline] (1.168 s) : 0, 1168255
Total [baseline] (9.022 s) : 0, 9022225
Agent [candidate] (1.17 s) : 0, 1170115
Total [candidate] (8.976 s) : 0, 8976141
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.044 s -
Agent iast 1.173 s 129.103 ms (12.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.176 s 131.588 ms (12.6%)
Agent iast_TELEMETRY_OFF 1.168 s 124.216 ms (11.9%)
Total tracing 8.48 s -
Total iast 8.991 s 510.252 ms (6.0%)
Total iast_HARDCODED_SECRET_DISABLED 8.951 s 470.554 ms (5.5%)
Total iast_TELEMETRY_OFF 9.022 s 541.831 ms (6.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.044 s -
Agent iast 1.175 s 130.579 ms (12.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.183 s 138.675 ms (13.3%)
Agent iast_TELEMETRY_OFF 1.17 s 125.855 ms (12.1%)
Total tracing 8.488 s -
Total iast 8.976 s 487.498 ms (5.7%)
Total iast_HARDCODED_SECRET_DISABLED 9.019 s 530.859 ms (6.3%)
Total iast_TELEMETRY_OFF 8.976 s 488.064 ms (5.7%) 
gantt
    title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~c82c35d688, baseline=1.39.0-SNAPSHOT~a4f73e2ed0

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (666.631 ms) : 0, 666631
BytebuddyAgent [candidate] (666.143 ms) : 0, 666143
GlobalTracer [baseline] (304.881 ms) : 0, 304881
GlobalTracer [candidate] (305.781 ms) : 0, 305781
AppSec [baseline] (51.004 ms) : 0, 51004
AppSec [candidate] (50.859 ms) : 0, 50859
Remote Config [baseline] (662.22 µs) : 0, 662
Remote Config [candidate] (684.423 µs) : 0, 684
Telemetry [baseline] (7.45 ms) : 0, 7450
Telemetry [candidate] (7.408 ms) : 0, 7408
section iast
BytebuddyAgent [baseline] (779.05 ms) : 0, 779050
BytebuddyAgent [candidate] (781.435 ms) : 0, 781435
GlobalTracer [baseline] (296.383 ms) : 0, 296383
GlobalTracer [candidate] (295.967 ms) : 0, 295967
AppSec [baseline] (49.306 ms) : 0, 49306
AppSec [candidate] (53.222 ms) : 0, 53222
IAST [baseline] (24.863 ms) : 0, 24863
IAST [candidate] (21.431 ms) : 0, 21431
Remote Config [baseline] (595.44 µs) : 0, 595
Remote Config [candidate] (571.964 µs) : 0, 572
Telemetry [baseline] (9.477 ms) : 0, 9477
Telemetry [candidate] (8.729 ms) : 0, 8729
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (777.903 ms) : 0, 777903
BytebuddyAgent [candidate] (786.544 ms) : 0, 786544
GlobalTracer [baseline] (298.545 ms) : 0, 298545
GlobalTracer [candidate] (298.188 ms) : 0, 298188
AppSec [baseline] (51.145 ms) : 0, 51145
AppSec [candidate] (50.228 ms) : 0, 50228
IAST [baseline] (22.831 ms) : 0, 22831
IAST [candidate] (25.86 ms) : 0, 25860
Remote Config [baseline] (610.015 µs) : 0, 610
Remote Config [candidate] (582.717 µs) : 0, 583
Telemetry [baseline] (11.107 ms) : 0, 11107
Telemetry [candidate] (7.935 ms) : 0, 7935
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (775.568 ms) : 0, 775568
BytebuddyAgent [candidate] (779.48 ms) : 0, 779480
GlobalTracer [baseline] (297.417 ms) : 0, 297417
GlobalTracer [candidate] (296.761 ms) : 0, 296761
AppSec [baseline] (49.84 ms) : 0, 49840
AppSec [candidate] (50.434 ms) : 0, 50434
IAST [baseline] (22.867 ms) : 0, 22867
IAST [candidate] (21.429 ms) : 0, 21429
Remote Config [baseline] (572.813 µs) : 0, 573
Remote Config [candidate] (626.399 µs) : 0, 626
Telemetry [baseline] (8.518 ms) : 0, 8518
Telemetry [candidate] (7.89 ms) : 0, 7890
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~c82c35d688, baseline=1.39.0-SNAPSHOT~a4f73e2ed0

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.048 s) : 0, 1048156
Total [baseline] (10.327 s) : 0, 10327341
Agent [candidate] (1.045 s) : 0, 1045152
Total [candidate] (10.333 s) : 0, 10332806
section appsec
Agent [baseline] (1.181 s) : 0, 1180818
Total [baseline] (10.523 s) : 0, 10523226
Agent [candidate] (1.171 s) : 0, 1171378
Total [candidate] (10.46 s) : 0, 10459945
section iast
Agent [baseline] (1.173 s) : 0, 1173234
Total [baseline] (10.851 s) : 0, 10850796
Agent [candidate] (1.176 s) : 0, 1175830
Total [candidate] (10.955 s) : 0, 10955199
section profiling
Agent [baseline] (1.252 s) : 0, 1251648
Total [baseline] (10.602 s) : 0, 10601903
Agent [candidate] (1.245 s) : 0, 1244964
Total [candidate] (10.596 s) : 0, 10595542
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.048 s -
Agent appsec 1.181 s 132.662 ms (12.7%)
Agent iast 1.173 s 125.077 ms (11.9%)
Agent profiling 1.252 s 203.492 ms (19.4%)
Total tracing 10.327 s -
Total appsec 10.523 s 195.885 ms (1.9%)
Total iast 10.851 s 523.455 ms (5.1%)
Total profiling 10.602 s 274.561 ms (2.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.045 s -
Agent appsec 1.171 s 126.226 ms (12.1%)
Agent iast 1.176 s 130.679 ms (12.5%)
Agent profiling 1.245 s 199.813 ms (19.1%)
Total tracing 10.333 s -
Total appsec 10.46 s 127.139 ms (1.2%)
Total iast 10.955 s 622.393 ms (6.0%)
Total profiling 10.596 s 262.736 ms (2.5%) 
gantt
    title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~c82c35d688, baseline=1.39.0-SNAPSHOT~a4f73e2ed0

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (668.93 ms) : 0, 668930
BytebuddyAgent [candidate] (666.562 ms) : 0, 666562
GlobalTracer [baseline] (306.082 ms) : 0, 306082
GlobalTracer [candidate] (305.694 ms) : 0, 305694
AppSec [baseline] (51.559 ms) : 0, 51559
AppSec [candidate] (51.295 ms) : 0, 51295
Remote Config [baseline] (661.515 µs) : 0, 662
Remote Config [candidate] (685.862 µs) : 0, 686
Telemetry [baseline] (7.477 ms) : 0, 7477
Telemetry [candidate] (7.501 ms) : 0, 7501
section appsec
BytebuddyAgent [baseline] (685.999 ms) : 0, 685999
BytebuddyAgent [candidate] (679.74 ms) : 0, 679740
GlobalTracer [baseline] (302.507 ms) : 0, 302507
GlobalTracer [candidate] (300.723 ms) : 0, 300723
AppSec [baseline] (157.756 ms) : 0, 157756
AppSec [candidate] (157.742 ms) : 0, 157742
Remote Config [baseline] (612.594 µs) : 0, 613
Remote Config [candidate] (604.452 µs) : 0, 604
Telemetry [baseline] (8.671 ms) : 0, 8671
Telemetry [candidate] (8.059 ms) : 0, 8059
IAST [baseline] (23.437 ms) : 0, 23437
IAST [candidate] (21.986 ms) : 0, 21986
section iast
BytebuddyAgent [baseline] (779.089 ms) : 0, 779089
BytebuddyAgent [candidate] (780.529 ms) : 0, 780529
GlobalTracer [baseline] (295.796 ms) : 0, 295796
GlobalTracer [candidate] (297.66 ms) : 0, 297660
AppSec [baseline] (50.397 ms) : 0, 50397
AppSec [candidate] (53.194 ms) : 0, 53194
Remote Config [baseline] (587.112 µs) : 0, 587
Remote Config [candidate] (571.167 µs) : 0, 571
Telemetry [baseline] (9.526 ms) : 0, 9526
Telemetry [candidate] (7.975 ms) : 0, 7975
IAST [baseline] (24.377 ms) : 0, 24377
IAST [candidate] (22.433 ms) : 0, 22433
section profiling
ProfilingAgent [baseline] (94.736 ms) : 0, 94736
ProfilingAgent [candidate] (94.631 ms) : 0, 94631
BytebuddyAgent [baseline] (668.362 ms) : 0, 668362
BytebuddyAgent [candidate] (662.395 ms) : 0, 662395
GlobalTracer [baseline] (390.579 ms) : 0, 390579
GlobalTracer [candidate] (390.791 ms) : 0, 390791
AppSec [baseline] (52.587 ms) : 0, 52587
AppSec [candidate] (51.938 ms) : 0, 51938
Remote Config [baseline] (678.785 µs) : 0, 679
Remote Config [candidate] (670.825 µs) : 0, 671
Telemetry [baseline] (7.405 ms) : 0, 7405
Telemetry [candidate] (7.367 ms) : 0, 7367
Profiling [baseline] (94.76 ms) : 0, 94760
Profiling [candidate] (94.656 ms) : 0, 94656
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-08-23T14:24:06 2024-08-23T14:30:55
git_branch master jpbempel/exclude-redaction-ids
git_commit_date 1724422468 1724422386
git_commit_sha a4f73e2 c82c35d
release_version 1.39.0-SNAPSHOT~a4f73e2ed0 1.39.0-SNAPSHOT~c82c35d688
start_time 2024-08-23T14:23:53 2024-08-23T14:30:41
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1724423800 1724423800
ci_job_id 615326081 615326081
ci_pipeline_id 42686058 42686058
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~c82c35d688, baseline=1.39.0-SNAPSHOT~a4f73e2ed0
    dateFormat X
    axisFormat %s
section baseline
no_agent (370.888 µs) : 351, 390
.   : milestone, 371,
iast (481.099 µs) : 459, 503
.   : milestone, 481,
iast_FULL (550.747 µs) : 529, 573
.   : milestone, 551,
iast_GLOBAL (511.286 µs) : 489, 534
.   : milestone, 511,
iast_HARDCODED_SECRET_DISABLED (484.239 µs) : 462, 506
.   : milestone, 484,
iast_INACTIVE (447.841 µs) : 427, 469
.   : milestone, 448,
iast_TELEMETRY_OFF (469.948 µs) : 449, 491
.   : milestone, 470,
tracing (439.979 µs) : 419, 461
.   : milestone, 440,
section candidate
no_agent (363.965 µs) : 345, 383
.   : milestone, 364,
iast (485.837 µs) : 465, 507
.   : milestone, 486,
iast_FULL (556.809 µs) : 534, 580
.   : milestone, 557,
iast_GLOBAL (514.722 µs) : 491, 538
.   : milestone, 515,
iast_HARDCODED_SECRET_DISABLED (483.884 µs) : 462, 505
.   : milestone, 484,
iast_INACTIVE (460.06 µs) : 437, 483
.   : milestone, 460,
iast_TELEMETRY_OFF (469.888 µs) : 449, 491
.   : milestone, 470,
tracing (448.174 µs) : 428, 469
.   : milestone, 448,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.888 µs [351.359 µs, 390.416 µs] -
iast 481.099 µs [458.774 µs, 503.425 µs] 110.212 µs (29.7%)
iast_FULL 550.747 µs [528.927 µs, 572.568 µs] 179.86 µs (48.5%)
iast_GLOBAL 511.286 µs [488.559 µs, 534.014 µs] 140.399 µs (37.9%)
iast_HARDCODED_SECRET_DISABLED 484.239 µs [462.061 µs, 506.417 µs] 113.352 µs (30.6%)
iast_INACTIVE 447.841 µs [426.941 µs, 468.741 µs] 76.953 µs (20.7%)
iast_TELEMETRY_OFF 469.948 µs [448.951 µs, 490.945 µs] 99.061 µs (26.7%)
tracing 439.979 µs [419.428 µs, 460.53 µs] 69.092 µs (18.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 363.965 µs [344.529 µs, 383.402 µs] -
iast 485.837 µs [464.793 µs, 506.881 µs] 121.872 µs (33.5%)
iast_FULL 556.809 µs [534.118 µs, 579.501 µs] 192.844 µs (53.0%)
iast_GLOBAL 514.722 µs [491.448 µs, 537.996 µs] 150.757 µs (41.4%)
iast_HARDCODED_SECRET_DISABLED 483.884 µs [462.383 µs, 505.385 µs] 119.919 µs (32.9%)
iast_INACTIVE 460.06 µs [437.232 µs, 482.887 µs] 96.094 µs (26.4%)
iast_TELEMETRY_OFF 469.888 µs [448.703 µs, 491.073 µs] 105.923 µs (29.1%)
tracing 448.174 µs [427.702 µs, 468.646 µs] 84.209 µs (23.1%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~c82c35d688, baseline=1.39.0-SNAPSHOT~a4f73e2ed0
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.364 ms) : 1344, 1383
.   : milestone, 1364,
appsec (1.726 ms) : 1703, 1750
.   : milestone, 1726,
appsec_no_iast (1.717 ms) : 1692, 1741
.   : milestone, 1717,
iast (1.473 ms) : 1450, 1495
.   : milestone, 1473,
profiling (1.494 ms) : 1467, 1520
.   : milestone, 1494,
tracing (1.456 ms) : 1432, 1481
.   : milestone, 1456,
section candidate
no_agent (1.346 ms) : 1326, 1366
.   : milestone, 1346,
appsec (1.74 ms) : 1716, 1764
.   : milestone, 1740,
appsec_no_iast (1.731 ms) : 1707, 1755
.   : milestone, 1731,
iast (1.488 ms) : 1465, 1510
.   : milestone, 1488,
profiling (1.499 ms) : 1473, 1525
.   : milestone, 1499,
tracing (1.472 ms) : 1446, 1497
.   : milestone, 1472,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.364 ms [1.344 ms, 1.383 ms] -
appsec 1.726 ms [1.703 ms, 1.75 ms] 362.796 µs (26.6%)
appsec_no_iast 1.717 ms [1.692 ms, 1.741 ms] 353.121 µs (25.9%)
iast 1.473 ms [1.45 ms, 1.495 ms] 109.107 µs (8.0%)
profiling 1.494 ms [1.467 ms, 1.52 ms] 130.274 µs (9.6%)
tracing 1.456 ms [1.432 ms, 1.481 ms] 92.861 µs (6.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.346 ms [1.326 ms, 1.366 ms] -
appsec 1.74 ms [1.716 ms, 1.764 ms] 393.72 µs (29.3%)
appsec_no_iast 1.731 ms [1.707 ms, 1.755 ms] 385.226 µs (28.6%)
iast 1.488 ms [1.465 ms, 1.51 ms] 141.64 µs (10.5%)
profiling 1.499 ms [1.473 ms, 1.525 ms] 153.273 µs (11.4%)
tracing 1.472 ms [1.446 ms, 1.497 ms] 125.845 µs (9.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/exclude-redaction-ids
git_commit_date 1724422468 1724422386
git_commit_sha a4f73e2 c82c35d
release_version 1.39.0-SNAPSHOT~a4f73e2ed0 1.39.0-SNAPSHOT~c82c35d688
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1724424392 1724424392
ci_job_id 615326083 615326083
ci_pipeline_id 42686058 42686058
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~c82c35d688, baseline=1.39.0-SNAPSHOT~a4f73e2ed0
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.399 s) : 15399000, 15399000
.   : milestone, 15399000,
appsec (14.877 s) : 14877000, 14877000
.   : milestone, 14877000,
iast (18.902 s) : 18902000, 18902000
.   : milestone, 18902000,
iast_GLOBAL (17.946 s) : 17946000, 17946000
.   : milestone, 17946000,
profiling (15.357 s) : 15357000, 15357000
.   : milestone, 15357000,
tracing (15.191 s) : 15191000, 15191000
.   : milestone, 15191000,
section candidate
no_agent (14.999 s) : 14999000, 14999000
.   : milestone, 14999000,
appsec (15.061 s) : 15061000, 15061000
.   : milestone, 15061000,
iast (18.628 s) : 18628000, 18628000
.   : milestone, 18628000,
iast_GLOBAL (17.704 s) : 17704000, 17704000
.   : milestone, 17704000,
profiling (14.812 s) : 14812000, 14812000
.   : milestone, 14812000,
tracing (14.871 s) : 14871000, 14871000
.   : milestone, 14871000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.399 s [15.399 s, 15.399 s] -
appsec 14.877 s [14.877 s, 14.877 s] -522.0 ms (-3.4%)
iast 18.902 s [18.902 s, 18.902 s] 3.503 s (22.7%)
iast_GLOBAL 17.946 s [17.946 s, 17.946 s] 2.547 s (16.5%)
profiling 15.357 s [15.357 s, 15.357 s] -42.0 ms (-0.3%)
tracing 15.191 s [15.191 s, 15.191 s] -208.0 ms (-1.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.999 s [14.999 s, 14.999 s] -
appsec 15.061 s [15.061 s, 15.061 s] 62.0 ms (0.4%)
iast 18.628 s [18.628 s, 18.628 s] 3.629 s (24.2%)
iast_GLOBAL 17.704 s [17.704 s, 17.704 s] 2.705 s (18.0%)
profiling 14.812 s [14.812 s, 14.812 s] -187.0 ms (-1.2%)
tracing 14.871 s [14.871 s, 14.871 s] -128.0 ms (-0.9%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~c82c35d688, baseline=1.39.0-SNAPSHOT~a4f73e2ed0
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.451 ms) : 1440, 1463
.   : milestone, 1451,
appsec (2.209 ms) : 2175, 2244
.   : milestone, 2209,
iast (1.97 ms) : 1927, 2014
.   : milestone, 1970,
iast_GLOBAL (2.015 ms) : 1971, 2059
.   : milestone, 2015,
profiling (1.849 ms) : 1814, 1884
.   : milestone, 1849,
tracing (1.827 ms) : 1795, 1860
.   : milestone, 1827,
section candidate
no_agent (1.449 ms) : 1438, 1461
.   : milestone, 1449,
appsec (2.214 ms) : 2179, 2250
.   : milestone, 2214,
iast (1.974 ms) : 1931, 2017
.   : milestone, 1974,
iast_GLOBAL (2.008 ms) : 1965, 2051
.   : milestone, 2008,
profiling (1.843 ms) : 1809, 1877
.   : milestone, 1843,
tracing (1.838 ms) : 1805, 1872
.   : milestone, 1838,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.451 ms [1.44 ms, 1.463 ms] -
appsec 2.209 ms [2.175 ms, 2.244 ms] 757.944 µs (52.2%)
iast 1.97 ms [1.927 ms, 2.014 ms] 519.153 µs (35.8%)
iast_GLOBAL 2.015 ms [1.971 ms, 2.059 ms] 563.695 µs (38.8%)
profiling 1.849 ms [1.814 ms, 1.884 ms] 397.928 µs (27.4%)
tracing 1.827 ms [1.795 ms, 1.86 ms] 376.234 µs (25.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.449 ms [1.438 ms, 1.461 ms] -
appsec 2.214 ms [2.179 ms, 2.25 ms] 765.045 µs (52.8%)
iast 1.974 ms [1.931 ms, 2.017 ms] 524.261 µs (36.2%)
iast_GLOBAL 2.008 ms [1.965 ms, 2.051 ms] 558.487 µs (38.5%)
profiling 1.843 ms [1.809 ms, 1.877 ms] 393.676 µs (27.2%)
tracing 1.838 ms [1.805 ms, 1.872 ms] 389.0 µs (26.8%)

@jpbempel
Add exclusion predefined redaction keywords
c82c35d 
In the list of predefined keywords some of them could be too generic
or wanted see the content of a session for example.
introduced the config parameter
DD_DYNAMIC_ISTRUMENTATION_REDACTION_EXCLUDED_IDENTIFIERS for a
comma list of identifiers you want to exclude from redacted keywords
@jpbempel jpbempel force-pushed the jpbempel/exclude-redaction-ids branch from e5a13fb to c82c35d Compare August 23, 2024 14:13
@jpbempel jpbempel merged commit 770734c into master Aug 29, 2024
@jpbempel jpbempel deleted the jpbempel/exclude-redaction-ids branch August 29, 2024 15:14
@github-actions github-actions Bot added this to the 1.39.0 milestone Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evanchooly evanchooly evanchooly approved these changes

@ojung ojung Awaiting requested review from ojung ojung is a code owner automatically assigned from DataDog/debugger-java

@mcculls mcculls Awaiting requested review from mcculls mcculls is a code owner automatically assigned from DataDog/apm-java

@nayeem-kamal nayeem-kamal Awaiting requested review from nayeem-kamal nayeem-kamal is a code owner automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

comp: debugger Dynamic Instrumentation type: enhancement Enhancements and improvements

Projects

None yet

Milestone

1.39.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jpbempel @evanchooly