Skip to content

Add debug info to tainted objects to troubleshoot null ranges#7455

Merged
manuel-alvarez-alvarez merged 3 commits intomasterfrom
malvarez/iast-troubleshoot-null-ranges
Aug 27, 2024
Merged

Add debug info to tainted objects to troubleshoot null ranges#7455
manuel-alvarez-alvarez merged 3 commits intomasterfrom
malvarez/iast-troubleshoot-null-ranges

Conversation

@manuel-alvarez-alvarez
Copy link
Copy Markdown
Member

@manuel-alvarez-alvarez manuel-alvarez-alvarez commented Aug 16, 2024

What Does This Do

Adds information to troubleshoot and issue with null values in ranges.

Motivation

Recently we've starting receiving issues at:

afterAppend threw
java.lang.NullPointerException: <unknown>
  at com.datadog.iast.taint.Ranges.copyShift(Ranges.java:92)
  at com.datadog.iast.taint.Ranges.copyShift(Ranges.java:75)
  at com.datadog.iast.propagation.StringModuleImpl.onStringBuilderAppend(StringModuleImpl.java:117)

This PR should help us pinpoint the issue.

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@manuel-alvarez-alvarez manuel-alvarez-alvarez added tag: no release notes Changes to exclude from release notes comp: asm iast Application Security Management (IAST) labels Aug 16, 2024
@manuel-alvarez-alvarez manuel-alvarez-alvarez marked this pull request as ready for review August 16, 2024 12:05
@manuel-alvarez-alvarez manuel-alvarez-alvarez requested a review from a team as a code owner August 16, 2024 12:05
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Aug 16, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/iast-troubleshoot-null-ranges
git_commit_date 1724745485 1724746117
git_commit_sha 8eaed7d ac8c8db
release_version 1.39.0-SNAPSHOT~8eaed7d885 1.39.0-SNAPSHOT~ac8c8db3e7
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1724748576 1724748576
ci_job_id 618016353 618016353
ci_pipeline_id 42899437 42899437
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 12 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~ac8c8db3e7, baseline=1.39.0-SNAPSHOT~8eaed7d885

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1047030
Total [baseline] (10.411 s) : 0, 10411030
Agent [candidate] (1.056 s) : 0, 1055507
Total [candidate] (10.441 s) : 0, 10440608
section appsec
Agent [baseline] (1.176 s) : 0, 1175553
Total [baseline] (10.52 s) : 0, 10519875
Agent [candidate] (1.171 s) : 0, 1170760
Total [candidate] (10.533 s) : 0, 10533194
section iast
Agent [baseline] (1.175 s) : 0, 1174639
Total [baseline] (10.813 s) : 0, 10813071
Agent [candidate] (1.175 s) : 0, 1174714
Total [candidate] (10.823 s) : 0, 10822942
section profiling
Agent [baseline] (1.257 s) : 0, 1256636
Total [baseline] (10.61 s) : 0, 10610077
Agent [candidate] (1.247 s) : 0, 1246969
Total [candidate] (10.617 s) : 0, 10617343
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.047 s -
Agent appsec 1.176 s 128.524 ms (12.3%)
Agent iast 1.175 s 127.609 ms (12.2%)
Agent profiling 1.257 s 209.607 ms (20.0%)
Total tracing 10.411 s -
Total appsec 10.52 s 108.845 ms (1.0%)
Total iast 10.813 s 402.041 ms (3.9%)
Total profiling 10.61 s 199.047 ms (1.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.056 s -
Agent appsec 1.171 s 115.253 ms (10.9%)
Agent iast 1.175 s 119.207 ms (11.3%)
Agent profiling 1.247 s 191.462 ms (18.1%)
Total tracing 10.441 s -
Total appsec 10.533 s 92.586 ms (0.9%)
Total iast 10.823 s 382.334 ms (3.7%)
Total profiling 10.617 s 176.736 ms (1.7%) 
gantt
    title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~ac8c8db3e7, baseline=1.39.0-SNAPSHOT~8eaed7d885

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (668.443 ms) : 0, 668443
BytebuddyAgent [candidate] (673.129 ms) : 0, 673129
GlobalTracer [baseline] (305.562 ms) : 0, 305562
GlobalTracer [candidate] (308.884 ms) : 0, 308884
AppSec [baseline] (51.352 ms) : 0, 51352
AppSec [candidate] (51.687 ms) : 0, 51687
Remote Config [baseline] (681.312 µs) : 0, 681
Remote Config [candidate] (679.234 µs) : 0, 679
Telemetry [baseline] (7.472 ms) : 0, 7472
Telemetry [candidate] (7.532 ms) : 0, 7532
section appsec
BytebuddyAgent [baseline] (682.358 ms) : 0, 682358
BytebuddyAgent [candidate] (679.159 ms) : 0, 679159
GlobalTracer [baseline] (301.76 ms) : 0, 301760
GlobalTracer [candidate] (300.132 ms) : 0, 300132
AppSec [baseline] (160.46 ms) : 0, 160460
AppSec [candidate] (160.515 ms) : 0, 160515
Remote Config [baseline] (648.513 µs) : 0, 649
Remote Config [candidate] (636.344 µs) : 0, 636
Telemetry [baseline] (7.464 ms) : 0, 7464
Telemetry [candidate] (7.417 ms) : 0, 7417
IAST [baseline] (18.538 ms) : 0, 18538
IAST [candidate] (18.679 ms) : 0, 18679
section iast
BytebuddyAgent [baseline] (779.464 ms) : 0, 779464
BytebuddyAgent [candidate] (779.81 ms) : 0, 779810
GlobalTracer [baseline] (296.557 ms) : 0, 296557
GlobalTracer [candidate] (296.359 ms) : 0, 296359
AppSec [baseline] (49.609 ms) : 0, 49609
AppSec [candidate] (51.334 ms) : 0, 51334
Remote Config [baseline] (609.163 µs) : 0, 609
Remote Config [candidate] (616.614 µs) : 0, 617
Telemetry [baseline] (8.055 ms) : 0, 8055
Telemetry [candidate] (11.126 ms) : 0, 11126
IAST [baseline] (26.788 ms) : 0, 26788
IAST [candidate] (21.89 ms) : 0, 21890
section profiling
ProfilingAgent [baseline] (96.842 ms) : 0, 96842
ProfilingAgent [candidate] (96.219 ms) : 0, 96219
BytebuddyAgent [baseline] (669.329 ms) : 0, 669329
BytebuddyAgent [candidate] (663.585 ms) : 0, 663585
GlobalTracer [baseline] (392.45 ms) : 0, 392450
GlobalTracer [candidate] (389.886 ms) : 0, 389886
AppSec [baseline] (52.394 ms) : 0, 52394
AppSec [candidate] (52.073 ms) : 0, 52073
Remote Config [baseline] (698.084 µs) : 0, 698
Remote Config [candidate] (678.4 µs) : 0, 678
Telemetry [baseline] (7.384 ms) : 0, 7384
Telemetry [candidate] (7.304 ms) : 0, 7304
Profiling [baseline] (96.867 ms) : 0, 96867
Profiling [candidate] (96.242 ms) : 0, 96242
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~ac8c8db3e7, baseline=1.39.0-SNAPSHOT~8eaed7d885

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1047357
Total [baseline] (8.508 s) : 0, 8507508
Agent [candidate] (1.047 s) : 0, 1046863
Total [candidate] (8.519 s) : 0, 8519183
section iast
Agent [baseline] (1.171 s) : 0, 1171177
Total [baseline] (8.984 s) : 0, 8984173
Agent [candidate] (1.172 s) : 0, 1172147
Total [candidate] (9.011 s) : 0, 9010729
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.172 s) : 0, 1171661
Total [baseline] (8.963 s) : 0, 8963231
Agent [candidate] (1.172 s) : 0, 1171764
Total [candidate] (9.01 s) : 0, 9009916
section iast_TELEMETRY_OFF
Agent [baseline] (1.178 s) : 0, 1177777
Total [baseline] (8.977 s) : 0, 8977281
Agent [candidate] (1.187 s) : 0, 1186831
Total [candidate] (9.027 s) : 0, 9026909
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.047 s -
Agent iast 1.171 s 123.82 ms (11.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.172 s 124.305 ms (11.9%)
Agent iast_TELEMETRY_OFF 1.178 s 130.42 ms (12.5%)
Total tracing 8.508 s -
Total iast 8.984 s 476.665 ms (5.6%)
Total iast_HARDCODED_SECRET_DISABLED 8.963 s 455.723 ms (5.4%)
Total iast_TELEMETRY_OFF 8.977 s 469.773 ms (5.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.047 s -
Agent iast 1.172 s 125.285 ms (12.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.172 s 124.901 ms (11.9%)
Agent iast_TELEMETRY_OFF 1.187 s 139.968 ms (13.4%)
Total tracing 8.519 s -
Total iast 9.011 s 491.546 ms (5.8%)
Total iast_HARDCODED_SECRET_DISABLED 9.01 s 490.733 ms (5.8%)
Total iast_TELEMETRY_OFF 9.027 s 507.726 ms (6.0%) 
gantt
    title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~ac8c8db3e7, baseline=1.39.0-SNAPSHOT~8eaed7d885

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (667.906 ms) : 0, 667906
BytebuddyAgent [candidate] (667.948 ms) : 0, 667948
GlobalTracer [baseline] (306.427 ms) : 0, 306427
GlobalTracer [candidate] (306.074 ms) : 0, 306074
AppSec [baseline] (51.407 ms) : 0, 51407
AppSec [candidate] (51.173 ms) : 0, 51173
Remote Config [baseline] (655.714 µs) : 0, 656
Remote Config [candidate] (660.859 µs) : 0, 661
Telemetry [baseline] (7.441 ms) : 0, 7441
Telemetry [candidate] (7.508 ms) : 0, 7508
section iast
BytebuddyAgent [baseline] (778.586 ms) : 0, 778586
BytebuddyAgent [candidate] (778.608 ms) : 0, 778608
GlobalTracer [baseline] (296.202 ms) : 0, 296202
GlobalTracer [candidate] (296.615 ms) : 0, 296615
AppSec [baseline] (50.62 ms) : 0, 50620
AppSec [candidate] (49.699 ms) : 0, 49699
Remote Config [baseline] (601.849 µs) : 0, 602
Remote Config [candidate] (601.584 µs) : 0, 602
Telemetry [baseline] (9.57 ms) : 0, 9570
Telemetry [candidate] (8.008 ms) : 0, 8008
IAST [baseline] (22.027 ms) : 0, 22027
IAST [candidate] (25.063 ms) : 0, 25063
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (778.355 ms) : 0, 778355
BytebuddyAgent [candidate] (777.358 ms) : 0, 777358
GlobalTracer [baseline] (296.166 ms) : 0, 296166
GlobalTracer [candidate] (295.924 ms) : 0, 295924
AppSec [baseline] (48.272 ms) : 0, 48272
AppSec [candidate] (49.18 ms) : 0, 49180
Remote Config [baseline] (598.833 µs) : 0, 599
Remote Config [candidate] (606.686 µs) : 0, 607
Telemetry [baseline] (9.542 ms) : 0, 9542
Telemetry [candidate] (10.16 ms) : 0, 10160
IAST [baseline] (25.134 ms) : 0, 25134
IAST [candidate] (24.978 ms) : 0, 24978
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (782.469 ms) : 0, 782469
BytebuddyAgent [candidate] (787.552 ms) : 0, 787552
GlobalTracer [baseline] (298.175 ms) : 0, 298175
GlobalTracer [candidate] (300.673 ms) : 0, 300673
AppSec [baseline] (49.857 ms) : 0, 49857
AppSec [candidate] (51.176 ms) : 0, 51176
Remote Config [baseline] (597.559 µs) : 0, 598
Remote Config [candidate] (620.861 µs) : 0, 621
Telemetry [baseline] (8.658 ms) : 0, 8658
Telemetry [candidate] (11.107 ms) : 0, 11107
IAST [baseline] (24.345 ms) : 0, 24345
IAST [candidate] (21.946 ms) : 0, 21946
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-08-27T08:21:20 2024-08-27T08:30:20
git_branch master malvarez/iast-troubleshoot-null-ranges
git_commit_date 1724745485 1724746117
git_commit_sha 8eaed7d ac8c8db
release_version 1.39.0-SNAPSHOT~8eaed7d885 1.39.0-SNAPSHOT~ac8c8db3e7
start_time 2024-08-27T08:21:04 2024-08-27T08:30:04
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1724747878 1724747878
ci_job_id 618016354 618016354
ci_pipeline_id 42899437 42899437
cpu_model Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 6 metrics, 22 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~ac8c8db3e7, baseline=1.39.0-SNAPSHOT~8eaed7d885
    dateFormat X
    axisFormat %s
section baseline
no_agent (449.271 µs) : 421, 478
.   : milestone, 449,
iast (594.803 µs) : 560, 630
.   : milestone, 595,
iast_FULL (680.266 µs) : 648, 712
.   : milestone, 680,
iast_GLOBAL (617.104 µs) : 584, 650
.   : milestone, 617,
iast_HARDCODED_SECRET_DISABLED (586.155 µs) : 553, 619
.   : milestone, 586,
iast_INACTIVE (537.763 µs) : 508, 568
.   : milestone, 538,
iast_TELEMETRY_OFF (568.053 µs) : 535, 601
.   : milestone, 568,
tracing (535.633 µs) : 505, 566
.   : milestone, 536,
section candidate
no_agent (447.921 µs) : 419, 477
.   : milestone, 448,
iast (579.876 µs) : 548, 612
.   : milestone, 580,
iast_FULL (686.384 µs) : 654, 719
.   : milestone, 686,
iast_GLOBAL (620.572 µs) : 589, 652
.   : milestone, 621,
iast_HARDCODED_SECRET_DISABLED (593.232 µs) : 560, 626
.   : milestone, 593,
iast_INACTIVE (535.53 µs) : 505, 566
.   : milestone, 536,
iast_TELEMETRY_OFF (569.888 µs) : 537, 602
.   : milestone, 570,
tracing (527.819 µs) : 498, 558
.   : milestone, 528,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 449.271 µs [420.668 µs, 477.874 µs] -
iast 594.803 µs [559.972 µs, 629.634 µs] 145.532 µs (32.4%)
iast_FULL 680.266 µs [648.056 µs, 712.477 µs] 230.995 µs (51.4%)
iast_GLOBAL 617.104 µs [584.432 µs, 649.777 µs] 167.833 µs (37.4%)
iast_HARDCODED_SECRET_DISABLED 586.155 µs [553.185 µs, 619.125 µs] 136.884 µs (30.5%)
iast_INACTIVE 537.763 µs [507.526 µs, 568.001 µs] 88.492 µs (19.7%)
iast_TELEMETRY_OFF 568.053 µs [535.1 µs, 601.005 µs] 118.782 µs (26.4%)
tracing 535.633 µs [505.369 µs, 565.896 µs] 86.362 µs (19.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 447.921 µs [418.916 µs, 476.925 µs] -
iast 579.876 µs [548.017 µs, 611.734 µs] 131.955 µs (29.5%)
iast_FULL 686.384 µs [653.568 µs, 719.2 µs] 238.463 µs (53.2%)
iast_GLOBAL 620.572 µs [588.669 µs, 652.476 µs] 172.652 µs (38.5%)
iast_HARDCODED_SECRET_DISABLED 593.232 µs [560.267 µs, 626.196 µs] 145.311 µs (32.4%)
iast_INACTIVE 535.53 µs [505.119 µs, 565.942 µs] 87.61 µs (19.6%)
iast_TELEMETRY_OFF 569.888 µs [537.324 µs, 602.453 µs] 121.968 µs (27.2%)
tracing 527.819 µs [497.607 µs, 558.031 µs] 79.899 µs (17.8%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~ac8c8db3e7, baseline=1.39.0-SNAPSHOT~8eaed7d885
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.691 ms) : 1665, 1717
.   : milestone, 1691,
appsec (2.162 ms) : 2131, 2193
.   : milestone, 2162,
appsec_no_iast (2.172 ms) : 2140, 2203
.   : milestone, 2172,
iast (1.895 ms) : 1866, 1925
.   : milestone, 1895,
profiling (1.996 ms) : 1960, 2032
.   : milestone, 1996,
tracing (1.893 ms) : 1861, 1925
.   : milestone, 1893,
section candidate
no_agent (1.719 ms) : 1693, 1745
.   : milestone, 1719,
appsec (2.166 ms) : 2135, 2197
.   : milestone, 2166,
appsec_no_iast (2.212 ms) : 2180, 2244
.   : milestone, 2212,
iast (1.912 ms) : 1882, 1941
.   : milestone, 1912,
profiling (1.961 ms) : 1925, 1996
.   : milestone, 1961,
tracing (1.87 ms) : 1838, 1902
.   : milestone, 1870,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.691 ms [1.665 ms, 1.717 ms] -
appsec 2.162 ms [2.131 ms, 2.193 ms] 471.135 µs (27.9%)
appsec_no_iast 2.172 ms [2.14 ms, 2.203 ms] 480.167 µs (28.4%)
iast 1.895 ms [1.866 ms, 1.925 ms] 204.124 µs (12.1%)
profiling 1.996 ms [1.96 ms, 2.032 ms] 304.456 µs (18.0%)
tracing 1.893 ms [1.861 ms, 1.925 ms] 201.643 µs (11.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.719 ms [1.693 ms, 1.745 ms] -
appsec 2.166 ms [2.135 ms, 2.197 ms] 446.498 µs (26.0%)
appsec_no_iast 2.212 ms [2.18 ms, 2.244 ms] 492.545 µs (28.6%)
iast 1.912 ms [1.882 ms, 1.941 ms] 192.129 µs (11.2%)
profiling 1.961 ms [1.925 ms, 1.996 ms] 241.302 µs (14.0%)
tracing 1.87 ms [1.838 ms, 1.902 ms] 150.53 µs (8.8%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/iast-troubleshoot-null-ranges
git_commit_date 1724745485 1724746117
git_commit_sha 8eaed7d ac8c8db
release_version 1.39.0-SNAPSHOT~8eaed7d885 1.39.0-SNAPSHOT~ac8c8db3e7
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1724748089 1724748089
ci_job_id 618016355 618016355
ci_pipeline_id 42899437 42899437
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~ac8c8db3e7, baseline=1.39.0-SNAPSHOT~8eaed7d885
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.466 ms) : 1454, 1477
.   : milestone, 1466,
appsec (2.229 ms) : 2194, 2265
.   : milestone, 2229,
iast (1.974 ms) : 1931, 2017
.   : milestone, 1974,
iast_GLOBAL (2.029 ms) : 1985, 2073
.   : milestone, 2029,
profiling (1.865 ms) : 1831, 1900
.   : milestone, 1865,
tracing (1.848 ms) : 1815, 1882
.   : milestone, 1848,
section candidate
no_agent (1.459 ms) : 1447, 1470
.   : milestone, 1459,
appsec (2.243 ms) : 2207, 2279
.   : milestone, 2243,
iast (1.966 ms) : 1924, 2008
.   : milestone, 1966,
iast_GLOBAL (2.024 ms) : 1981, 2068
.   : milestone, 2024,
profiling (1.858 ms) : 1823, 1893
.   : milestone, 1858,
tracing (1.836 ms) : 1803, 1869
.   : milestone, 1836,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.466 ms [1.454 ms, 1.477 ms] -
appsec 2.229 ms [2.194 ms, 2.265 ms] 763.728 µs (52.1%)
iast 1.974 ms [1.931 ms, 2.017 ms] 508.336 µs (34.7%)
iast_GLOBAL 2.029 ms [1.985 ms, 2.073 ms] 562.931 µs (38.4%)
profiling 1.865 ms [1.831 ms, 1.9 ms] 399.691 µs (27.3%)
tracing 1.848 ms [1.815 ms, 1.882 ms] 382.551 µs (26.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.459 ms [1.447 ms, 1.47 ms] -
appsec 2.243 ms [2.207 ms, 2.279 ms] 783.964 µs (53.7%)
iast 1.966 ms [1.924 ms, 2.008 ms] 506.766 µs (34.7%)
iast_GLOBAL 2.024 ms [1.981 ms, 2.068 ms] 565.234 µs (38.7%)
profiling 1.858 ms [1.823 ms, 1.893 ms] 399.166 µs (27.4%)
tracing 1.836 ms [1.803 ms, 1.869 ms] 377.083 µs (25.8%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~ac8c8db3e7, baseline=1.39.0-SNAPSHOT~8eaed7d885
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.961 s) : 14961000, 14961000
.   : milestone, 14961000,
appsec (15.107 s) : 15107000, 15107000
.   : milestone, 15107000,
iast (18.71 s) : 18710000, 18710000
.   : milestone, 18710000,
iast_GLOBAL (18.081 s) : 18081000, 18081000
.   : milestone, 18081000,
profiling (14.788 s) : 14788000, 14788000
.   : milestone, 14788000,
tracing (15.194 s) : 15194000, 15194000
.   : milestone, 15194000,
section candidate
no_agent (14.986 s) : 14986000, 14986000
.   : milestone, 14986000,
appsec (15.325 s) : 15325000, 15325000
.   : milestone, 15325000,
iast (18.834 s) : 18834000, 18834000
.   : milestone, 18834000,
iast_GLOBAL (17.856 s) : 17856000, 17856000
.   : milestone, 17856000,
profiling (15.145 s) : 15145000, 15145000
.   : milestone, 15145000,
tracing (14.956 s) : 14956000, 14956000
.   : milestone, 14956000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.961 s [14.961 s, 14.961 s] -
appsec 15.107 s [15.107 s, 15.107 s] 146.0 ms (1.0%)
iast 18.71 s [18.71 s, 18.71 s] 3.749 s (25.1%)
iast_GLOBAL 18.081 s [18.081 s, 18.081 s] 3.12 s (20.9%)
profiling 14.788 s [14.788 s, 14.788 s] -173.0 ms (-1.2%)
tracing 15.194 s [15.194 s, 15.194 s] 233.0 ms (1.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.986 s [14.986 s, 14.986 s] -
appsec 15.325 s [15.325 s, 15.325 s] 339.0 ms (2.3%)
iast 18.834 s [18.834 s, 18.834 s] 3.848 s (25.7%)
iast_GLOBAL 17.856 s [17.856 s, 17.856 s] 2.87 s (19.2%)
profiling 15.145 s [15.145 s, 15.145 s] 159.0 ms (1.1%)
tracing 14.956 s [14.956 s, 14.956 s] -30.0 ms (-0.2%)

@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/iast-troubleshoot-null-ranges branch 3 times, most recently from c87650e to bc7b646 Compare August 26, 2024 09:44
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/iast-troubleshoot-null-ranges branch from bc7b646 to ac8c8db Compare August 27, 2024 08:08
@manuel-alvarez-alvarez manuel-alvarez-alvarez merged commit bb9b598 into master Aug 27, 2024
@manuel-alvarez-alvarez manuel-alvarez-alvarez deleted the malvarez/iast-troubleshoot-null-ranges branch August 27, 2024 08:53
@github-actions github-actions Bot added this to the 1.39.0 milestone Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smola smola smola approved these changes

@ValentinZakharov ValentinZakharov Awaiting requested review from ValentinZakharov ValentinZakharov is a code owner automatically assigned from DataDog/asm-java

Assignees

No one assigned

Labels

comp: asm iast Application Security Management (IAST) tag: no release notes Changes to exclude from release notes

Projects

None yet

Milestone

1.39.0

Development

Successfully merging this pull request may close these issues.

2 participants

@manuel-alvarez-alvarez @smola