Skip to content

[🍒 7444] Backport review feedback from master#7451

Merged
mcculls merged 1 commit intorelease/v1.38.xfrom
mcculls/dropin-fixes-for-r2dbc-backport
Aug 16, 2024
Merged

[🍒 7444] Backport review feedback from master#7451
mcculls merged 1 commit intorelease/v1.38.xfrom
mcculls/dropin-fixes-for-r2dbc-backport

Conversation

@mcculls
Copy link
Copy Markdown
Contributor

@mcculls mcculls commented Aug 16, 2024 •
edited by smola
Loading

(this create method is not used at runtime because this class gets replaced with the OTel version - it's only used for compilation purposes, but we should make it consistent)

#7444

@mcculls mcculls added tag: no release notes Changes to exclude from release notes inst: opentelemetry OpenTelemetry instrumentation labels Aug 16, 2024
@mcculls mcculls requested a review from a team as a code owner August 16, 2024 07:00
@mcculls mcculls requested review from PerfectSlayer and ygree August 16, 2024 07:00
@mcculls mcculls added this to the 1.38.1 milestone Aug 16, 2024
@mcculls mcculls enabled auto-merge (squash) August 16, 2024 07:00
@mcculls mcculls mentioned this pull request Aug 16, 2024
Merged
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Aug 16, 2024

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1723792017 1723792398
end_time 2024-08-16T07:08:11 2024-08-16T07:14:32
git_branch master mcculls/dropin-fixes-for-r2dbc-backport
git_commit_sha ad0cb28 a2576ac
start_time 2024-08-16T07:06:58 2024-08-16T07:13:19
See matching parameters
Baseline Candidate
ci_job_id 606874031 606874031
ci_pipeline_id 41949153 41949153
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1723791433 1723791433

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 7 unstable metrics.

See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-27.474µs; +48.903µs] or [-10.663%; +18.980%]		 unstable
[-33.322µs; +66.580µs] or [-11.402%; +22.782%]		 unstable
[-41.509µs; +80.540µs] or [-13.606%; +26.399%]		 unstable
[-276.454µs; +757.483µs] or [-43.262%; +118.538%]		 same
scenario:basic same same unstable
[-9.730µs; +24.123µs] or [-3.169%; +7.858%]		 unstable
[-67.751µs; +43.520µs] or [-10.861%; +6.977%]		 unstable
[-218.359op/s; +83.406op/s] or [-8.298%; +3.169%]
scenario:loop unsure
[+60.069µs; +217.899µs] or [+0.574%; +2.081%]		 unsure
[+54.743µs; +224.413µs] or [+0.514%; +2.107%]		 unsure
[+43.399µs; +237.773µs] or [+0.404%; +2.212%]		 same unsure
[-2.349op/s; -0.211op/s] or [-2.525%; -0.227%]
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (292.251 µs) : 267, 317
.   : milestone, 292,
basic (298.146 µs) : 291, 306
.   : milestone, 298,
loop (10.649 ms) : 10600, 10698
.   : milestone, 10649,
section candidate
noprobe (308.88 µs) : 246, 371
.   : milestone, 309,
basic (304.063 µs) : 287, 321
.   : milestone, 304,
loop (10.789 ms) : 10689, 10889
.   : milestone, 10789,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 292.251 µs [267.036 µs, 317.466 µs]
basic 298.146 µs [290.543 µs, 305.749 µs]
loop 10.649 ms [10.6 ms, 10.698 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 308.88 µs [246.367 µs, 371.393 µs]
basic 304.063 µs [286.966 µs, 321.16 µs]
loop 10.789 ms [10.689 ms, 10.889 ms]

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Aug 16, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/dropin-fixes-for-r2dbc-backport
git_commit_date 1723791039 1723791433
git_commit_sha ad0cb28 a2576ac
release_version 1.39.0-SNAPSHOT~ad0cb28e09 1.39.0-SNAPSHOT~a2576ace1f
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1723793824 1723793824
ci_job_id 606874025 606874025
ci_pipeline_id 41949153 41949153
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 12 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:insecure-bank:iast_TELEMETRY_OFF:AppSec better
[-9.242ms; -3.996ms] or [-17.325%; -7.491%]		 46.727ms 53.346ms
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~a2576ace1f, baseline=1.39.0-SNAPSHOT~ad0cb28e09

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1050679
Total [baseline] (8.553 s) : 0, 8553361
Agent [candidate] (1.045 s) : 0, 1044745
Total [candidate] (8.527 s) : 0, 8527356
section iast
Agent [baseline] (1.174 s) : 0, 1173549
Total [baseline] (9.002 s) : 0, 9001557
Agent [candidate] (1.17 s) : 0, 1169904
Total [candidate] (8.972 s) : 0, 8971961
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.174 s) : 0, 1174183
Total [baseline] (8.971 s) : 0, 8971289
Agent [candidate] (1.175 s) : 0, 1175427
Total [candidate] (8.953 s) : 0, 8953368
section iast_TELEMETRY_OFF
Agent [baseline] (1.182 s) : 0, 1181638
Total [baseline] (8.999 s) : 0, 8998817
Agent [candidate] (1.169 s) : 0, 1168954
Total [candidate] (8.967 s) : 0, 8967078
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.051 s -
Agent iast 1.174 s 122.87 ms (11.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.174 s 123.505 ms (11.8%)
Agent iast_TELEMETRY_OFF 1.182 s 130.959 ms (12.5%)
Total tracing 8.553 s -
Total iast 9.002 s 448.197 ms (5.2%)
Total iast_HARDCODED_SECRET_DISABLED 8.971 s 417.928 ms (4.9%)
Total iast_TELEMETRY_OFF 8.999 s 445.457 ms (5.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.045 s -
Agent iast 1.17 s 125.158 ms (12.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.175 s 130.682 ms (12.5%)
Agent iast_TELEMETRY_OFF 1.169 s 124.208 ms (11.9%)
Total tracing 8.527 s -
Total iast 8.972 s 444.604 ms (5.2%)
Total iast_HARDCODED_SECRET_DISABLED 8.953 s 426.012 ms (5.0%)
Total iast_TELEMETRY_OFF 8.967 s 439.722 ms (5.2%) 
gantt
    title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~a2576ace1f, baseline=1.39.0-SNAPSHOT~ad0cb28e09

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (670.321 ms) : 0, 670321
BytebuddyAgent [candidate] (667.729 ms) : 0, 667729
GlobalTracer [baseline] (307.74 ms) : 0, 307740
GlobalTracer [candidate] (305.189 ms) : 0, 305189
AppSec [baseline] (51.004 ms) : 0, 51004
AppSec [candidate] (50.32 ms) : 0, 50320
Remote Config [baseline] (685.658 µs) : 0, 686
Remote Config [candidate] (684.315 µs) : 0, 684
Telemetry [baseline] (7.461 ms) : 0, 7461
Telemetry [candidate] (7.387 ms) : 0, 7387
section iast
BytebuddyAgent [baseline] (780.912 ms) : 0, 780912
BytebuddyAgent [candidate] (780.207 ms) : 0, 780207
GlobalTracer [baseline] (295.688 ms) : 0, 295688
GlobalTracer [candidate] (294.543 ms) : 0, 294543
AppSec [baseline] (51.125 ms) : 0, 51125
AppSec [candidate] (51.49 ms) : 0, 51490
IAST [baseline] (21.519 ms) : 0, 21519
IAST [candidate] (22.627 ms) : 0, 22627
Remote Config [baseline] (573.349 µs) : 0, 573
Remote Config [candidate] (577.922 µs) : 0, 578
Telemetry [baseline] (10.306 ms) : 0, 10306
Telemetry [candidate] (7.017 ms) : 0, 7017
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (781.246 ms) : 0, 781246
BytebuddyAgent [candidate] (783.292 ms) : 0, 783292
GlobalTracer [baseline] (296.551 ms) : 0, 296551
GlobalTracer [candidate] (295.306 ms) : 0, 295306
AppSec [baseline] (49.353 ms) : 0, 49353
AppSec [candidate] (52.392 ms) : 0, 52392
IAST [baseline] (22.647 ms) : 0, 22647
IAST [candidate] (23.368 ms) : 0, 23368
Remote Config [baseline] (596.551 µs) : 0, 597
Remote Config [candidate] (575.314 µs) : 0, 575
Telemetry [baseline] (10.326 ms) : 0, 10326
Telemetry [candidate] (6.939 ms) : 0, 6939
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (786.254 ms) : 0, 786254
BytebuddyAgent [candidate] (779.206 ms) : 0, 779206
GlobalTracer [baseline] (299.266 ms) : 0, 299266
GlobalTracer [candidate] (296.0 ms) : 0, 296000
AppSec [baseline] (53.346 ms) : 0, 53346
AppSec [candidate] (46.727 ms) : 0, 46727
IAST [baseline] (21.492 ms) : 0, 21492
IAST [candidate] (25.995 ms) : 0, 25995
Remote Config [baseline] (609.44 µs) : 0, 609
Remote Config [candidate] (599.394 µs) : 0, 599
Telemetry [baseline] (7.064 ms) : 0, 7064
Telemetry [candidate] (6.91 ms) : 0, 6910
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~a2576ace1f, baseline=1.39.0-SNAPSHOT~ad0cb28e09

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1045667
Total [baseline] (10.368 s) : 0, 10367652
Agent [candidate] (1.045 s) : 0, 1045248
Total [candidate] (10.357 s) : 0, 10357317
section appsec
Agent [baseline] (1.171 s) : 0, 1170661
Total [baseline] (10.465 s) : 0, 10464652
Agent [candidate] (1.164 s) : 0, 1163662
Total [candidate] (10.504 s) : 0, 10504225
section iast
Agent [baseline] (1.175 s) : 0, 1174643
Total [baseline] (10.821 s) : 0, 10820514
Agent [candidate] (1.172 s) : 0, 1172296
Total [candidate] (10.75 s) : 0, 10750458
section profiling
Agent [baseline] (1.244 s) : 0, 1244407
Total [baseline] (10.556 s) : 0, 10555820
Agent [candidate] (1.243 s) : 0, 1242815
Total [candidate] (10.667 s) : 0, 10667063
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.046 s -
Agent appsec 1.171 s 124.994 ms (12.0%)
Agent iast 1.175 s 128.976 ms (12.3%)
Agent profiling 1.244 s 198.739 ms (19.0%)
Total tracing 10.368 s -
Total appsec 10.465 s 97.0 ms (0.9%)
Total iast 10.821 s 452.862 ms (4.4%)
Total profiling 10.556 s 188.168 ms (1.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.045 s -
Agent appsec 1.164 s 118.414 ms (11.3%)
Agent iast 1.172 s 127.048 ms (12.2%)
Agent profiling 1.243 s 197.567 ms (18.9%)
Total tracing 10.357 s -
Total appsec 10.504 s 146.909 ms (1.4%)
Total iast 10.75 s 393.141 ms (3.8%)
Total profiling 10.667 s 309.746 ms (3.0%) 
gantt
    title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~a2576ace1f, baseline=1.39.0-SNAPSHOT~ad0cb28e09

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (667.064 ms) : 0, 667064
BytebuddyAgent [candidate] (667.872 ms) : 0, 667872
GlobalTracer [baseline] (306.071 ms) : 0, 306071
GlobalTracer [candidate] (305.615 ms) : 0, 305615
AppSec [baseline] (50.977 ms) : 0, 50977
AppSec [candidate] (50.281 ms) : 0, 50281
Remote Config [baseline] (694.061 µs) : 0, 694
Remote Config [candidate] (684.489 µs) : 0, 684
Telemetry [baseline] (7.467 ms) : 0, 7467
Telemetry [candidate] (7.375 ms) : 0, 7375
section appsec
BytebuddyAgent [baseline] (679.095 ms) : 0, 679095
BytebuddyAgent [candidate] (676.83 ms) : 0, 676830
GlobalTracer [baseline] (300.303 ms) : 0, 300303
GlobalTracer [candidate] (298.773 ms) : 0, 298773
AppSec [baseline] (157.471 ms) : 0, 157471
AppSec [candidate] (155.047 ms) : 0, 155047
Remote Config [baseline] (600.126 µs) : 0, 600
Remote Config [candidate] (599.999 µs) : 0, 600
Telemetry [baseline] (8.712 ms) : 0, 8712
Telemetry [candidate] (7.851 ms) : 0, 7851
IAST [baseline] (21.985 ms) : 0, 21985
IAST [candidate] (22.173 ms) : 0, 22173
section iast
BytebuddyAgent [baseline] (781.135 ms) : 0, 781135
BytebuddyAgent [candidate] (781.177 ms) : 0, 781177
GlobalTracer [baseline] (295.988 ms) : 0, 295988
GlobalTracer [candidate] (294.853 ms) : 0, 294853
AppSec [baseline] (52.349 ms) : 0, 52349
AppSec [candidate] (51.204 ms) : 0, 51204
Remote Config [baseline] (588.346 µs) : 0, 588
Remote Config [candidate] (1.349 ms) : 0, 1349
Telemetry [baseline] (7.106 ms) : 0, 7106
Telemetry [candidate] (6.907 ms) : 0, 6907
IAST [baseline] (23.981 ms) : 0, 23981
IAST [candidate] (23.352 ms) : 0, 23352
section profiling
BytebuddyAgent [baseline] (662.201 ms) : 0, 662201
BytebuddyAgent [candidate] (662.653 ms) : 0, 662653
GlobalTracer [baseline] (390.3 ms) : 0, 390300
GlobalTracer [candidate] (388.414 ms) : 0, 388414
AppSec [baseline] (52.34 ms) : 0, 52340
AppSec [candidate] (51.501 ms) : 0, 51501
Remote Config [baseline] (684.853 µs) : 0, 685
Remote Config [candidate] (711.574 µs) : 0, 712
Telemetry [baseline] (7.387 ms) : 0, 7387
Telemetry [candidate] (7.229 ms) : 0, 7229
ProfilingAgent [baseline] (94.428 ms) : 0, 94428
ProfilingAgent [candidate] (95.193 ms) : 0, 95193
Profiling [baseline] (94.453 ms) : 0, 94453
Profiling [candidate] (95.217 ms) : 0, 95217
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-08-16T07:07:52 2024-08-16T07:14:41
git_branch master mcculls/dropin-fixes-for-r2dbc-backport
git_commit_date 1723791039 1723791433
git_commit_sha ad0cb28 a2576ac
release_version 1.39.0-SNAPSHOT~ad0cb28e09 1.39.0-SNAPSHOT~a2576ace1f
start_time 2024-08-16T07:07:39 2024-08-16T07:14:28
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1723792827 1723792827
ci_job_id 606874026 606874026
ci_pipeline_id 41949153 41949153
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~a2576ace1f, baseline=1.39.0-SNAPSHOT~ad0cb28e09
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.332 ms) : 1312, 1351
.   : milestone, 1332,
appsec (1.698 ms) : 1673, 1722
.   : milestone, 1698,
appsec_no_iast (1.708 ms) : 1684, 1733
.   : milestone, 1708,
iast (1.486 ms) : 1463, 1508
.   : milestone, 1486,
profiling (1.52 ms) : 1495, 1546
.   : milestone, 1520,
tracing (1.471 ms) : 1447, 1495
.   : milestone, 1471,
section candidate
no_agent (1.343 ms) : 1324, 1362
.   : milestone, 1343,
appsec (1.737 ms) : 1710, 1763
.   : milestone, 1737,
appsec_no_iast (1.731 ms) : 1706, 1755
.   : milestone, 1731,
iast (1.49 ms) : 1468, 1512
.   : milestone, 1490,
profiling (1.483 ms) : 1459, 1508
.   : milestone, 1483,
tracing (1.478 ms) : 1454, 1502
.   : milestone, 1478,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.332 ms [1.312 ms, 1.351 ms] -
appsec 1.698 ms [1.673 ms, 1.722 ms] 366.14 µs (27.5%)
appsec_no_iast 1.708 ms [1.684 ms, 1.733 ms] 376.78 µs (28.3%)
iast 1.486 ms [1.463 ms, 1.508 ms] 154.161 µs (11.6%)
profiling 1.52 ms [1.495 ms, 1.546 ms] 188.977 µs (14.2%)
tracing 1.471 ms [1.447 ms, 1.495 ms] 139.519 µs (10.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.343 ms [1.324 ms, 1.362 ms] -
appsec 1.737 ms [1.71 ms, 1.763 ms] 393.609 µs (29.3%)
appsec_no_iast 1.731 ms [1.706 ms, 1.755 ms] 387.629 µs (28.9%)
iast 1.49 ms [1.468 ms, 1.512 ms] 147.242 µs (11.0%)
profiling 1.483 ms [1.459 ms, 1.508 ms] 140.549 µs (10.5%)
tracing 1.478 ms [1.454 ms, 1.502 ms] 134.905 µs (10.0%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~a2576ace1f, baseline=1.39.0-SNAPSHOT~ad0cb28e09
    dateFormat X
    axisFormat %s
section baseline
no_agent (371.099 µs) : 351, 391
.   : milestone, 371,
iast (486.187 µs) : 465, 508
.   : milestone, 486,
iast_FULL (551.25 µs) : 529, 573
.   : milestone, 551,
iast_GLOBAL (503.383 µs) : 481, 526
.   : milestone, 503,
iast_HARDCODED_SECRET_DISABLED (483.593 µs) : 462, 505
.   : milestone, 484,
iast_INACTIVE (459.672 µs) : 437, 483
.   : milestone, 460,
iast_TELEMETRY_OFF (470.911 µs) : 450, 492
.   : milestone, 471,
tracing (446.733 µs) : 426, 467
.   : milestone, 447,
section candidate
no_agent (367.582 µs) : 348, 387
.   : milestone, 368,
iast (482.231 µs) : 461, 503
.   : milestone, 482,
iast_FULL (548.389 µs) : 527, 569
.   : milestone, 548,
iast_GLOBAL (502.256 µs) : 481, 523
.   : milestone, 502,
iast_HARDCODED_SECRET_DISABLED (481.115 µs) : 460, 502
.   : milestone, 481,
iast_INACTIVE (453.3 µs) : 431, 475
.   : milestone, 453,
iast_TELEMETRY_OFF (472.444 µs) : 451, 494
.   : milestone, 472,
tracing (438.011 µs) : 418, 458
.   : milestone, 438,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 371.099 µs [351.491 µs, 390.706 µs] -
iast 486.187 µs [464.502 µs, 507.871 µs] 115.088 µs (31.0%)
iast_FULL 551.25 µs [529.087 µs, 573.412 µs] 180.151 µs (48.5%)
iast_GLOBAL 503.383 µs [480.708 µs, 526.058 µs] 132.284 µs (35.6%)
iast_HARDCODED_SECRET_DISABLED 483.593 µs [462.438 µs, 504.747 µs] 112.494 µs (30.3%)
iast_INACTIVE 459.672 µs [436.805 µs, 482.538 µs] 88.573 µs (23.9%)
iast_TELEMETRY_OFF 470.911 µs [449.753 µs, 492.07 µs] 99.813 µs (26.9%)
tracing 446.733 µs [426.07 µs, 467.396 µs] 75.634 µs (20.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 367.582 µs [348.063 µs, 387.101 µs] -
iast 482.231 µs [460.97 µs, 503.492 µs] 114.649 µs (31.2%)
iast_FULL 548.389 µs [527.389 µs, 569.389 µs] 180.807 µs (49.2%)
iast_GLOBAL 502.256 µs [481.236 µs, 523.276 µs] 134.674 µs (36.6%)
iast_HARDCODED_SECRET_DISABLED 481.115 µs [460.35 µs, 501.881 µs] 113.533 µs (30.9%)
iast_INACTIVE 453.3 µs [431.455 µs, 475.144 µs] 85.718 µs (23.3%)
iast_TELEMETRY_OFF 472.444 µs [451.074 µs, 493.814 µs] 104.862 µs (28.5%)
tracing 438.011 µs [417.608 µs, 458.415 µs] 70.429 µs (19.2%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/dropin-fixes-for-r2dbc-backport
git_commit_date 1723791039 1723791433
git_commit_sha ad0cb28 a2576ac
release_version 1.39.0-SNAPSHOT~ad0cb28e09 1.39.0-SNAPSHOT~a2576ace1f
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1723793337 1723793337
ci_job_id 606874027 606874027
ci_pipeline_id 41949153 41949153
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~a2576ace1f, baseline=1.39.0-SNAPSHOT~ad0cb28e09
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.468 ms) : 1456, 1479
.   : milestone, 1468,
appsec (2.228 ms) : 2193, 2263
.   : milestone, 2228,
iast (1.959 ms) : 1918, 2001
.   : milestone, 1959,
iast_GLOBAL (2.028 ms) : 1984, 2071
.   : milestone, 2028,
profiling (1.864 ms) : 1830, 1898
.   : milestone, 1864,
tracing (1.858 ms) : 1824, 1891
.   : milestone, 1858,
section candidate
no_agent (1.468 ms) : 1456, 1479
.   : milestone, 1468,
appsec (2.215 ms) : 2180, 2249
.   : milestone, 2215,
iast (1.987 ms) : 1944, 2029
.   : milestone, 1987,
iast_GLOBAL (2.013 ms) : 1972, 2055
.   : milestone, 2013,
profiling (1.867 ms) : 1833, 1901
.   : milestone, 1867,
tracing (1.852 ms) : 1818, 1885
.   : milestone, 1852,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.468 ms [1.456 ms, 1.479 ms] -
appsec 2.228 ms [2.193 ms, 2.263 ms] 760.15 µs (51.8%)
iast 1.959 ms [1.918 ms, 2.001 ms] 491.362 µs (33.5%)
iast_GLOBAL 2.028 ms [1.984 ms, 2.071 ms] 559.83 µs (38.1%)
profiling 1.864 ms [1.83 ms, 1.898 ms] 396.299 µs (27.0%)
tracing 1.858 ms [1.824 ms, 1.891 ms] 389.674 µs (26.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.468 ms [1.456 ms, 1.479 ms] -
appsec 2.215 ms [2.18 ms, 2.249 ms] 746.981 µs (50.9%)
iast 1.987 ms [1.944 ms, 2.029 ms] 518.917 µs (35.4%)
iast_GLOBAL 2.013 ms [1.972 ms, 2.055 ms] 545.67 µs (37.2%)
profiling 1.867 ms [1.833 ms, 1.901 ms] 399.602 µs (27.2%)
tracing 1.852 ms [1.818 ms, 1.885 ms] 384.306 µs (26.2%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~a2576ace1f, baseline=1.39.0-SNAPSHOT~ad0cb28e09
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.925 s) : 14925000, 14925000
.   : milestone, 14925000,
appsec (15.206 s) : 15206000, 15206000
.   : milestone, 15206000,
iast (19.002 s) : 19002000, 19002000
.   : milestone, 19002000,
iast_GLOBAL (17.871 s) : 17871000, 17871000
.   : milestone, 17871000,
profiling (15.066 s) : 15066000, 15066000
.   : milestone, 15066000,
tracing (15.104 s) : 15104000, 15104000
.   : milestone, 15104000,
section candidate
no_agent (14.874 s) : 14874000, 14874000
.   : milestone, 14874000,
appsec (14.909 s) : 14909000, 14909000
.   : milestone, 14909000,
iast (18.756 s) : 18756000, 18756000
.   : milestone, 18756000,
iast_GLOBAL (17.806 s) : 17806000, 17806000
.   : milestone, 17806000,
profiling (15.852 s) : 15852000, 15852000
.   : milestone, 15852000,
tracing (14.927 s) : 14927000, 14927000
.   : milestone, 14927000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.925 s [14.925 s, 14.925 s] -
appsec 15.206 s [15.206 s, 15.206 s] 281.0 ms (1.9%)
iast 19.002 s [19.002 s, 19.002 s] 4.077 s (27.3%)
iast_GLOBAL 17.871 s [17.871 s, 17.871 s] 2.946 s (19.7%)
profiling 15.066 s [15.066 s, 15.066 s] 141.0 ms (0.9%)
tracing 15.104 s [15.104 s, 15.104 s] 179.0 ms (1.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.874 s [14.874 s, 14.874 s] -
appsec 14.909 s [14.909 s, 14.909 s] 35.0 ms (0.2%)
iast 18.756 s [18.756 s, 18.756 s] 3.882 s (26.1%)
iast_GLOBAL 17.806 s [17.806 s, 17.806 s] 2.932 s (19.7%)
profiling 15.852 s [15.852 s, 15.852 s] 978.0 ms (6.6%)
tracing 14.927 s [14.927 s, 14.927 s] 53.0 ms (0.4%)

@mcculls mcculls merged commit d5cba79 into release/v1.38.x Aug 16, 2024
@mcculls mcculls deleted the mcculls/dropin-fixes-for-r2dbc-backport branch August 16, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@ygree ygree Awaiting requested review from ygree ygree is a code owner automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

inst: opentelemetry OpenTelemetry instrumentation tag: no release notes Changes to exclude from release notes

Projects

None yet

Milestone

1.38.1

Development

Successfully merging this pull request may close these issues.

2 participants

@mcculls @PerfectSlayer