Skip to content

Avoid NullPointerException when publishing SNS messages to phone numbers#7448

Merged
mcculls merged 2 commits intomasterfrom
mcculls/sns-npe-fix
Aug 15, 2024
Merged

Avoid NullPointerException when publishing SNS messages to phone numbers#7448
mcculls merged 2 commits intomasterfrom
mcculls/sns-npe-fix

Conversation

@mcculls
Copy link
Copy Markdown
Contributor

@mcculls mcculls commented Aug 15, 2024 •
edited by atlassian Bot
Loading

What Does This Do

Avoid NPE when only a phone number is provided in an SNS publish request

Motivation

Both topicArn and targetArn are optional for SNS publish requests: https://docs.aws.amazon.com/sns/latest/api/API_Publish.html

Additional Notes

topicARN is required for SNS publish batch requests: https://docs.aws.amazon.com/sns/latest/api/API_PublishBatch.html so we don't need to change that part of the code.

Jira ticket: APMS-13002

@mcculls mcculls added the inst: aws sdk AWS SDK instrumentation label Aug 15, 2024
@mcculls mcculls marked this pull request as ready for review August 15, 2024 18:47
@mcculls mcculls requested a review from a team as a code owner August 15, 2024 18:47
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Aug 15, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/sns-npe-fix
git_commit_date 1723739593 1723747038
git_commit_sha fcd4bc4 562b65d
release_version 1.39.0-SNAPSHOT~fcd4bc4862 1.39.0-SNAPSHOT~562b65d7bc
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1723749357 1723749357
ci_job_id 606421556 606421556
ci_pipeline_id 41900717 41900717
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 17 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~562b65d7bc, baseline=1.39.0-SNAPSHOT~fcd4bc4862

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1045805
Total [baseline] (8.487 s) : 0, 8487342
Agent [candidate] (1.045 s) : 0, 1045347
Total [candidate] (8.51 s) : 0, 8510076
section iast
Agent [baseline] (1.178 s) : 0, 1177695
Total [baseline] (8.981 s) : 0, 8980613
Agent [candidate] (1.178 s) : 0, 1177674
Total [candidate] (9.0 s) : 0, 9000366
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.175 s) : 0, 1174873
Total [baseline] (8.98 s) : 0, 8979632
Agent [candidate] (1.174 s) : 0, 1174127
Total [candidate] (8.965 s) : 0, 8964950
section iast_TELEMETRY_OFF
Agent [baseline] (1.18 s) : 0, 1180496
Total [baseline] (8.965 s) : 0, 8965005
Agent [candidate] (1.193 s) : 0, 1193101
Total [candidate] (9.057 s) : 0, 9057070
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.046 s -
Agent iast 1.178 s 131.89 ms (12.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.175 s 129.068 ms (12.3%)
Agent iast_TELEMETRY_OFF 1.18 s 134.691 ms (12.9%)
Total tracing 8.487 s -
Total iast 8.981 s 493.271 ms (5.8%)
Total iast_HARDCODED_SECRET_DISABLED 8.98 s 492.29 ms (5.8%)
Total iast_TELEMETRY_OFF 8.965 s 477.663 ms (5.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.045 s -
Agent iast 1.178 s 132.326 ms (12.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.174 s 128.779 ms (12.3%)
Agent iast_TELEMETRY_OFF 1.193 s 147.754 ms (14.1%)
Total tracing 8.51 s -
Total iast 9.0 s 490.29 ms (5.8%)
Total iast_HARDCODED_SECRET_DISABLED 8.965 s 454.874 ms (5.3%)
Total iast_TELEMETRY_OFF 9.057 s 546.994 ms (6.4%) 
gantt
    title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~562b65d7bc, baseline=1.39.0-SNAPSHOT~fcd4bc4862

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (667.2 ms) : 0, 667200
BytebuddyAgent [candidate] (667.453 ms) : 0, 667453
GlobalTracer [baseline] (306.104 ms) : 0, 306104
GlobalTracer [candidate] (305.413 ms) : 0, 305413
AppSec [baseline] (50.955 ms) : 0, 50955
AppSec [candidate] (50.901 ms) : 0, 50901
Remote Config [baseline] (678.551 µs) : 0, 679
Remote Config [candidate] (679.59 µs) : 0, 680
Telemetry [baseline] (7.44 ms) : 0, 7440
Telemetry [candidate] (7.482 ms) : 0, 7482
section iast
BytebuddyAgent [baseline] (782.426 ms) : 0, 782426
BytebuddyAgent [candidate] (783.772 ms) : 0, 783772
GlobalTracer [baseline] (297.705 ms) : 0, 297705
GlobalTracer [candidate] (296.271 ms) : 0, 296271
AppSec [baseline] (53.092 ms) : 0, 53092
AppSec [candidate] (52.235 ms) : 0, 52235
IAST [baseline] (22.406 ms) : 0, 22406
IAST [candidate] (22.479 ms) : 0, 22479
Remote Config [baseline] (584.942 µs) : 0, 585
Remote Config [candidate] (573.18 µs) : 0, 573
Telemetry [baseline] (7.99 ms) : 0, 7990
Telemetry [candidate] (8.825 ms) : 0, 8825
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (780.616 ms) : 0, 780616
BytebuddyAgent [candidate] (781.024 ms) : 0, 781024
GlobalTracer [baseline] (296.183 ms) : 0, 296183
GlobalTracer [candidate] (296.308 ms) : 0, 296308
AppSec [baseline] (49.297 ms) : 0, 49297
AppSec [candidate] (48.717 ms) : 0, 48717
IAST [baseline] (21.948 ms) : 0, 21948
IAST [candidate] (24.5 ms) : 0, 24500
Remote Config [baseline] (591.768 µs) : 0, 592
Remote Config [candidate] (599.463 µs) : 0, 599
Telemetry [baseline] (12.749 ms) : 0, 12749
Telemetry [candidate] (9.46 ms) : 0, 9460
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (784.579 ms) : 0, 784579
BytebuddyAgent [candidate] (793.223 ms) : 0, 793223
GlobalTracer [baseline] (298.55 ms) : 0, 298550
GlobalTracer [candidate] (300.753 ms) : 0, 300753
AppSec [baseline] (52.19 ms) : 0, 52190
AppSec [candidate] (52.323 ms) : 0, 52323
IAST [baseline] (23.148 ms) : 0, 23148
IAST [candidate] (22.83 ms) : 0, 22830
Remote Config [baseline] (615.119 µs) : 0, 615
Remote Config [candidate] (642.002 µs) : 0, 642
Telemetry [baseline] (7.814 ms) : 0, 7814
Telemetry [candidate] (9.594 ms) : 0, 9594
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~562b65d7bc, baseline=1.39.0-SNAPSHOT~fcd4bc4862

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1054614
Total [baseline] (10.408 s) : 0, 10407937
Agent [candidate] (1.055 s) : 0, 1055178
Total [candidate] (10.321 s) : 0, 10320567
section appsec
Agent [baseline] (1.169 s) : 0, 1169133
Total [baseline] (10.417 s) : 0, 10416843
Agent [candidate] (1.174 s) : 0, 1173512
Total [candidate] (10.536 s) : 0, 10535538
section iast
Agent [baseline] (1.186 s) : 0, 1185566
Total [baseline] (10.851 s) : 0, 10851239
Agent [candidate] (1.185 s) : 0, 1184672
Total [candidate] (10.871 s) : 0, 10871239
section profiling
Agent [baseline] (1.248 s) : 0, 1248020
Total [baseline] (10.543 s) : 0, 10542593
Agent [candidate] (1.244 s) : 0, 1244397
Total [candidate] (10.551 s) : 0, 10550986
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.055 s -
Agent appsec 1.169 s 114.519 ms (10.9%)
Agent iast 1.186 s 130.952 ms (12.4%)
Agent profiling 1.248 s 193.407 ms (18.3%)
Total tracing 10.408 s -
Total appsec 10.417 s 8.906 ms (0.1%)
Total iast 10.851 s 443.301 ms (4.3%)
Total profiling 10.543 s 134.656 ms (1.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.055 s -
Agent appsec 1.174 s 118.334 ms (11.2%)
Agent iast 1.185 s 129.494 ms (12.3%)
Agent profiling 1.244 s 189.22 ms (17.9%)
Total tracing 10.321 s -
Total appsec 10.536 s 214.971 ms (2.1%)
Total iast 10.871 s 550.673 ms (5.3%)
Total profiling 10.551 s 230.419 ms (2.2%) 
gantt
    title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~562b65d7bc, baseline=1.39.0-SNAPSHOT~fcd4bc4862

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (673.272 ms) : 0, 673272
BytebuddyAgent [candidate] (673.542 ms) : 0, 673542
GlobalTracer [baseline] (308.304 ms) : 0, 308304
GlobalTracer [candidate] (308.431 ms) : 0, 308431
AppSec [baseline] (51.236 ms) : 0, 51236
AppSec [candidate] (51.416 ms) : 0, 51416
Remote Config [baseline] (692.148 µs) : 0, 692
Remote Config [candidate] (708.289 µs) : 0, 708
Telemetry [baseline] (7.551 ms) : 0, 7551
Telemetry [candidate] (7.53 ms) : 0, 7530
section appsec
BytebuddyAgent [baseline] (678.2 ms) : 0, 678200
BytebuddyAgent [candidate] (680.256 ms) : 0, 680256
GlobalTracer [baseline] (299.723 ms) : 0, 299723
GlobalTracer [candidate] (301.253 ms) : 0, 301253
AppSec [baseline] (157.078 ms) : 0, 157078
AppSec [candidate] (157.559 ms) : 0, 157559
IAST [baseline] (21.505 ms) : 0, 21505
IAST [candidate] (21.12 ms) : 0, 21120
Remote Config [baseline] (600.189 µs) : 0, 600
Remote Config [candidate] (604.534 µs) : 0, 605
Telemetry [baseline] (9.303 ms) : 0, 9303
Telemetry [candidate] (9.738 ms) : 0, 9738
section iast
BytebuddyAgent [baseline] (789.493 ms) : 0, 789493
BytebuddyAgent [candidate] (788.995 ms) : 0, 788995
GlobalTracer [baseline] (298.762 ms) : 0, 298762
GlobalTracer [candidate] (298.444 ms) : 0, 298444
AppSec [baseline] (52.476 ms) : 0, 52476
AppSec [candidate] (52.741 ms) : 0, 52741
IAST [baseline] (21.909 ms) : 0, 21909
IAST [candidate] (21.646 ms) : 0, 21646
Remote Config [baseline] (591.14 µs) : 0, 591
Remote Config [candidate] (582.992 µs) : 0, 583
Telemetry [baseline] (8.736 ms) : 0, 8736
Telemetry [candidate] (8.653 ms) : 0, 8653
section profiling
BytebuddyAgent [baseline] (664.456 ms) : 0, 664456
BytebuddyAgent [candidate] (663.019 ms) : 0, 663019
GlobalTracer [baseline] (391.429 ms) : 0, 391429
GlobalTracer [candidate] (390.839 ms) : 0, 390839
AppSec [baseline] (52.249 ms) : 0, 52249
AppSec [candidate] (51.622 ms) : 0, 51622
Remote Config [baseline] (695.066 µs) : 0, 695
Remote Config [candidate] (684.297 µs) : 0, 684
Telemetry [baseline] (7.423 ms) : 0, 7423
Telemetry [candidate] (7.371 ms) : 0, 7371
ProfilingAgent [baseline] (94.511 ms) : 0, 94511
ProfilingAgent [candidate] (93.674 ms) : 0, 93674
Profiling [baseline] (94.536 ms) : 0, 94536
Profiling [candidate] (93.699 ms) : 0, 93699
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-08-15T18:46:41 2024-08-15T18:53:32
git_branch master mcculls/sns-npe-fix
git_commit_date 1723739593 1723747038
git_commit_sha fcd4bc4 562b65d
release_version 1.39.0-SNAPSHOT~fcd4bc4862 1.39.0-SNAPSHOT~562b65d7bc
start_time 2024-08-15T18:46:28 2024-08-15T18:53:19
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1723748356 1723748356
ci_job_id 606421557 606421557
ci_pipeline_id 41900717 41900717
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~562b65d7bc, baseline=1.39.0-SNAPSHOT~fcd4bc4862
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.327 ms) : 1308, 1346
.   : milestone, 1327,
appsec (1.72 ms) : 1696, 1744
.   : milestone, 1720,
appsec_no_iast (1.731 ms) : 1706, 1755
.   : milestone, 1731,
iast (1.461 ms) : 1438, 1484
.   : milestone, 1461,
profiling (1.488 ms) : 1461, 1514
.   : milestone, 1488,
tracing (1.461 ms) : 1436, 1486
.   : milestone, 1461,
section candidate
no_agent (1.325 ms) : 1305, 1345
.   : milestone, 1325,
appsec (1.697 ms) : 1673, 1721
.   : milestone, 1697,
appsec_no_iast (1.705 ms) : 1680, 1730
.   : milestone, 1705,
iast (1.48 ms) : 1457, 1502
.   : milestone, 1480,
profiling (1.475 ms) : 1449, 1500
.   : milestone, 1475,
tracing (1.461 ms) : 1436, 1485
.   : milestone, 1461,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.327 ms [1.308 ms, 1.346 ms] -
appsec 1.72 ms [1.696 ms, 1.744 ms] 393.34 µs (29.6%)
appsec_no_iast 1.731 ms [1.706 ms, 1.755 ms] 403.663 µs (30.4%)
iast 1.461 ms [1.438 ms, 1.484 ms] 134.51 µs (10.1%)
profiling 1.488 ms [1.461 ms, 1.514 ms] 160.749 µs (12.1%)
tracing 1.461 ms [1.436 ms, 1.486 ms] 133.666 µs (10.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.325 ms [1.305 ms, 1.345 ms] -
appsec 1.697 ms [1.673 ms, 1.721 ms] 371.755 µs (28.0%)
appsec_no_iast 1.705 ms [1.68 ms, 1.73 ms] 379.839 µs (28.7%)
iast 1.48 ms [1.457 ms, 1.502 ms] 154.39 µs (11.6%)
profiling 1.475 ms [1.449 ms, 1.5 ms] 149.235 µs (11.3%)
tracing 1.461 ms [1.436 ms, 1.485 ms] 135.316 µs (10.2%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~562b65d7bc, baseline=1.39.0-SNAPSHOT~fcd4bc4862
    dateFormat X
    axisFormat %s
section baseline
no_agent (364.473 µs) : 343, 385
.   : milestone, 364,
iast (479.853 µs) : 459, 501
.   : milestone, 480,
iast_FULL (554.913 µs) : 532, 578
.   : milestone, 555,
iast_GLOBAL (511.638 µs) : 489, 534
.   : milestone, 512,
iast_HARDCODED_SECRET_DISABLED (479.231 µs) : 458, 501
.   : milestone, 479,
iast_INACTIVE (451.423 µs) : 429, 474
.   : milestone, 451,
iast_TELEMETRY_OFF (466.75 µs) : 446, 488
.   : milestone, 467,
tracing (442.386 µs) : 422, 463
.   : milestone, 442,
section candidate
no_agent (371.683 µs) : 352, 391
.   : milestone, 372,
iast (480.348 µs) : 459, 502
.   : milestone, 480,
iast_FULL (551.279 µs) : 529, 574
.   : milestone, 551,
iast_GLOBAL (503.761 µs) : 482, 526
.   : milestone, 504,
iast_HARDCODED_SECRET_DISABLED (483.103 µs) : 462, 504
.   : milestone, 483,
iast_INACTIVE (459.306 µs) : 436, 483
.   : milestone, 459,
iast_TELEMETRY_OFF (467.756 µs) : 446, 489
.   : milestone, 468,
tracing (440.181 µs) : 420, 460
.   : milestone, 440,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 364.473 µs [343.456 µs, 385.491 µs] -
iast 479.853 µs [458.884 µs, 500.822 µs] 115.38 µs (31.7%)
iast_FULL 554.913 µs [532.253 µs, 577.573 µs] 190.44 µs (52.3%)
iast_GLOBAL 511.638 µs [488.918 µs, 534.359 µs] 147.165 µs (40.4%)
iast_HARDCODED_SECRET_DISABLED 479.231 µs [457.771 µs, 500.692 µs] 114.758 µs (31.5%)
iast_INACTIVE 451.423 µs [429.343 µs, 473.502 µs] 86.949 µs (23.9%)
iast_TELEMETRY_OFF 466.75 µs [445.739 µs, 487.76 µs] 102.276 µs (28.1%)
tracing 442.386 µs [421.81 µs, 462.961 µs] 77.912 µs (21.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 371.683 µs [352.296 µs, 391.07 µs] -
iast 480.348 µs [458.91 µs, 501.786 µs] 108.665 µs (29.2%)
iast_FULL 551.279 µs [528.812 µs, 573.745 µs] 179.596 µs (48.3%)
iast_GLOBAL 503.761 µs [481.97 µs, 525.553 µs] 132.078 µs (35.5%)
iast_HARDCODED_SECRET_DISABLED 483.103 µs [461.747 µs, 504.46 µs] 111.42 µs (30.0%)
iast_INACTIVE 459.306 µs [435.946 µs, 482.667 µs] 87.623 µs (23.6%)
iast_TELEMETRY_OFF 467.756 µs [446.283 µs, 489.229 µs] 96.073 µs (25.8%)
tracing 440.181 µs [420.01 µs, 460.352 µs] 68.498 µs (18.4%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/sns-npe-fix
git_commit_date 1723739593 1723747038
git_commit_sha fcd4bc4 562b65d
release_version 1.39.0-SNAPSHOT~fcd4bc4862 1.39.0-SNAPSHOT~562b65d7bc
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1723748984 1723748984
ci_job_id 606421558 606421558
ci_pipeline_id 41900717 41900717
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~562b65d7bc, baseline=1.39.0-SNAPSHOT~fcd4bc4862
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.468 ms) : 1457, 1480
.   : milestone, 1468,
appsec (2.233 ms) : 2197, 2269
.   : milestone, 2233,
iast (1.992 ms) : 1948, 2035
.   : milestone, 1992,
iast_GLOBAL (2.03 ms) : 1986, 2074
.   : milestone, 2030,
profiling (1.867 ms) : 1832, 1901
.   : milestone, 1867,
tracing (1.847 ms) : 1813, 1880
.   : milestone, 1847,
section candidate
no_agent (1.456 ms) : 1445, 1468
.   : milestone, 1456,
appsec (2.246 ms) : 2210, 2282
.   : milestone, 2246,
iast (1.987 ms) : 1943, 2030
.   : milestone, 1987,
iast_GLOBAL (2.021 ms) : 1977, 2065
.   : milestone, 2021,
profiling (1.877 ms) : 1841, 1913
.   : milestone, 1877,
tracing (1.853 ms) : 1819, 1886
.   : milestone, 1853,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.468 ms [1.457 ms, 1.48 ms] -
appsec 2.233 ms [2.197 ms, 2.269 ms] 764.786 µs (52.1%)
iast 1.992 ms [1.948 ms, 2.035 ms] 523.564 µs (35.7%)
iast_GLOBAL 2.03 ms [1.986 ms, 2.074 ms] 561.672 µs (38.3%)
profiling 1.867 ms [1.832 ms, 1.901 ms] 398.302 µs (27.1%)
tracing 1.847 ms [1.813 ms, 1.88 ms] 378.513 µs (25.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.456 ms [1.445 ms, 1.468 ms] -
appsec 2.246 ms [2.21 ms, 2.282 ms] 789.449 µs (54.2%)
iast 1.987 ms [1.943 ms, 2.03 ms] 530.29 µs (36.4%)
iast_GLOBAL 2.021 ms [1.977 ms, 2.065 ms] 564.746 µs (38.8%)
profiling 1.877 ms [1.841 ms, 1.913 ms] 420.258 µs (28.9%)
tracing 1.853 ms [1.819 ms, 1.886 ms] 396.445 µs (27.2%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~562b65d7bc, baseline=1.39.0-SNAPSHOT~fcd4bc4862
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.005 s) : 15005000, 15005000
.   : milestone, 15005000,
appsec (15.067 s) : 15067000, 15067000
.   : milestone, 15067000,
iast (18.844 s) : 18844000, 18844000
.   : milestone, 18844000,
iast_GLOBAL (17.759 s) : 17759000, 17759000
.   : milestone, 17759000,
profiling (15.507 s) : 15507000, 15507000
.   : milestone, 15507000,
tracing (15.072 s) : 15072000, 15072000
.   : milestone, 15072000,
section candidate
no_agent (15.472 s) : 15472000, 15472000
.   : milestone, 15472000,
appsec (14.826 s) : 14826000, 14826000
.   : milestone, 14826000,
iast (18.895 s) : 18895000, 18895000
.   : milestone, 18895000,
iast_GLOBAL (17.883 s) : 17883000, 17883000
.   : milestone, 17883000,
profiling (15.532 s) : 15532000, 15532000
.   : milestone, 15532000,
tracing (14.846 s) : 14846000, 14846000
.   : milestone, 14846000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.005 s [15.005 s, 15.005 s] -
appsec 15.067 s [15.067 s, 15.067 s] 62.0 ms (0.4%)
iast 18.844 s [18.844 s, 18.844 s] 3.839 s (25.6%)
iast_GLOBAL 17.759 s [17.759 s, 17.759 s] 2.754 s (18.4%)
profiling 15.507 s [15.507 s, 15.507 s] 502.0 ms (3.3%)
tracing 15.072 s [15.072 s, 15.072 s] 67.0 ms (0.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.472 s [15.472 s, 15.472 s] -
appsec 14.826 s [14.826 s, 14.826 s] -646.0 ms (-4.2%)
iast 18.895 s [18.895 s, 18.895 s] 3.423 s (22.1%)
iast_GLOBAL 17.883 s [17.883 s, 17.883 s] 2.411 s (15.6%)
profiling 15.532 s [15.532 s, 15.532 s] 60.0 ms (0.4%)
tracing 14.846 s [14.846 s, 14.846 s] -626.0 ms (-4.0%)

@mcculls mcculls enabled auto-merge (squash) August 15, 2024 19:23
@mcculls mcculls merged commit ca574d1 into master Aug 15, 2024
@mcculls mcculls deleted the mcculls/sns-npe-fix branch August 15, 2024 19:28
@github-actions github-actions Bot added this to the 1.39.0 milestone Aug 15, 2024
@PerfectSlayer PerfectSlayer mentioned this pull request Aug 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nayeem-kamal nayeem-kamal nayeem-kamal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

inst: aws sdk AWS SDK instrumentation

Projects

None yet

Milestone

1.39.0

Development

Successfully merging this pull request may close these issues.

2 participants

@mcculls @nayeem-kamal