Skip to content

OpenTelemetry drop-in fixes for r2dbc#7444

Merged
mcculls merged 6 commits intomasterfrom
mcculls/dropin-fixes-for-r2dbc
Aug 16, 2024
Merged

OpenTelemetry drop-in fixes for r2dbc#7444
mcculls merged 6 commits intomasterfrom
mcculls/dropin-fixes-for-r2dbc

Conversation

@mcculls
Copy link
Copy Markdown
Contributor

@mcculls mcculls commented Aug 15, 2024 •
edited by atlassian Bot
Loading

What Does This Do

Includes some additional semantic types from the incubator required by the OTel R2DBC extension, and redirects requests for sanitization to our existing SQL sanitizer.

Jira ticket: APMS-12994

@mcculls mcculls added the inst: opentelemetry OpenTelemetry instrumentation label Aug 15, 2024
@mcculls mcculls marked this pull request as ready for review August 15, 2024 01:23
@mcculls mcculls requested a review from a team as a code owner August 15, 2024 01:23
@mcculls mcculls requested review from PerfectSlayer and ygree August 15, 2024 01:23
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Aug 15, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/dropin-fixes-for-r2dbc
git_commit_date 1723791039 1723791272
git_commit_sha ad0cb28 e8e4c81
release_version 1.39.0-SNAPSHOT~ad0cb28e09 1.39.0-SNAPSHOT~e8e4c81c45
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1723793466 1723793466
ci_job_id 606873677 606873677
ci_pipeline_id 41949133 41949133
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 14 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:insecure-bank:iast:AppSec better
[-6.372ms; -1.128ms] or [-11.518%; -2.039%]		 51.569ms 55.319ms
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~e8e4c81c45, baseline=1.39.0-SNAPSHOT~ad0cb28e09

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1050761
Total [baseline] (10.481 s) : 0, 10480680
Agent [candidate] (1.049 s) : 0, 1049170
Total [candidate] (10.346 s) : 0, 10345838
section appsec
Agent [baseline] (1.171 s) : 0, 1170904
Total [baseline] (10.467 s) : 0, 10467385
Agent [candidate] (1.171 s) : 0, 1170690
Total [candidate] (10.48 s) : 0, 10480453
section iast
Agent [baseline] (1.179 s) : 0, 1179288
Total [baseline] (10.835 s) : 0, 10835086
Agent [candidate] (1.179 s) : 0, 1179093
Total [candidate] (10.911 s) : 0, 10911437
section profiling
Agent [baseline] (1.25 s) : 0, 1249679
Total [baseline] (10.583 s) : 0, 10582859
Agent [candidate] (1.265 s) : 0, 1265334
Total [candidate] (10.644 s) : 0, 10644127
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.051 s -
Agent appsec 1.171 s 120.143 ms (11.4%)
Agent iast 1.179 s 128.528 ms (12.2%)
Agent profiling 1.25 s 198.919 ms (18.9%)
Total tracing 10.481 s -
Total appsec 10.467 s -13.296 ms (-0.1%)
Total iast 10.835 s 354.405 ms (3.4%)
Total profiling 10.583 s 102.178 ms (1.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.049 s -
Agent appsec 1.171 s 121.52 ms (11.6%)
Agent iast 1.179 s 129.923 ms (12.4%)
Agent profiling 1.265 s 216.164 ms (20.6%)
Total tracing 10.346 s -
Total appsec 10.48 s 134.616 ms (1.3%)
Total iast 10.911 s 565.599 ms (5.5%)
Total profiling 10.644 s 298.289 ms (2.9%) 
gantt
    title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~e8e4c81c45, baseline=1.39.0-SNAPSHOT~ad0cb28e09

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (670.449 ms) : 0, 670449
BytebuddyAgent [candidate] (669.394 ms) : 0, 669394
GlobalTracer [baseline] (307.459 ms) : 0, 307459
GlobalTracer [candidate] (306.98 ms) : 0, 306980
AppSec [baseline] (51.181 ms) : 0, 51181
AppSec [candidate] (51.073 ms) : 0, 51073
Remote Config [baseline] (687.194 µs) : 0, 687
Remote Config [candidate] (691.652 µs) : 0, 692
Telemetry [baseline] (7.527 ms) : 0, 7527
Telemetry [candidate] (7.566 ms) : 0, 7566
section appsec
BytebuddyAgent [baseline] (679.789 ms) : 0, 679789
BytebuddyAgent [candidate] (679.364 ms) : 0, 679364
GlobalTracer [baseline] (300.182 ms) : 0, 300182
GlobalTracer [candidate] (300.461 ms) : 0, 300461
AppSec [baseline] (157.737 ms) : 0, 157737
AppSec [candidate] (157.278 ms) : 0, 157278
Remote Config [baseline] (597.841 µs) : 0, 598
Remote Config [candidate] (603.99 µs) : 0, 604
Telemetry [baseline] (8.376 ms) : 0, 8376
Telemetry [candidate] (9.046 ms) : 0, 9046
IAST [baseline] (21.436 ms) : 0, 21436
IAST [candidate] (20.879 ms) : 0, 20879
section iast
BytebuddyAgent [baseline] (784.65 ms) : 0, 784650
BytebuddyAgent [candidate] (783.757 ms) : 0, 783757
GlobalTracer [baseline] (297.129 ms) : 0, 297129
GlobalTracer [candidate] (297.434 ms) : 0, 297434
AppSec [baseline] (53.092 ms) : 0, 53092
AppSec [candidate] (50.829 ms) : 0, 50829
Remote Config [baseline] (567.288 µs) : 0, 567
Remote Config [candidate] (594.554 µs) : 0, 595
Telemetry [baseline] (7.065 ms) : 0, 7065
Telemetry [candidate] (9.449 ms) : 0, 9449
IAST [baseline] (23.237 ms) : 0, 23237
IAST [candidate] (23.493 ms) : 0, 23493
section profiling
ProfilingAgent [baseline] (94.938 ms) : 0, 94938
ProfilingAgent [candidate] (97.164 ms) : 0, 97164
BytebuddyAgent [baseline] (664.496 ms) : 0, 664496
BytebuddyAgent [candidate] (673.696 ms) : 0, 673696
GlobalTracer [baseline] (392.198 ms) : 0, 392198
GlobalTracer [candidate] (395.859 ms) : 0, 395859
AppSec [baseline] (52.682 ms) : 0, 52682
AppSec [candidate] (52.827 ms) : 0, 52827
Remote Config [baseline] (697.085 µs) : 0, 697
Remote Config [candidate] (701.607 µs) : 0, 702
Telemetry [baseline] (7.367 ms) : 0, 7367
Telemetry [candidate] (7.544 ms) : 0, 7544
Profiling [baseline] (94.962 ms) : 0, 94962
Profiling [candidate] (97.188 ms) : 0, 97188
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~e8e4c81c45, baseline=1.39.0-SNAPSHOT~ad0cb28e09

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.068 s) : 0, 1068466
Total [baseline] (8.569 s) : 0, 8568731
Agent [candidate] (1.055 s) : 0, 1055387
Total [candidate] (8.535 s) : 0, 8535315
section iast
Agent [baseline] (1.177 s) : 0, 1177402
Total [baseline] (8.997 s) : 0, 8997490
Agent [candidate] (1.178 s) : 0, 1177931
Total [candidate] (9.003 s) : 0, 9002565
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.19 s) : 0, 1190269
Total [baseline] (9.013 s) : 0, 9012749
Agent [candidate] (1.179 s) : 0, 1179359
Total [candidate] (8.994 s) : 0, 8993770
section iast_TELEMETRY_OFF
Agent [baseline] (1.176 s) : 0, 1175552
Total [baseline] (8.985 s) : 0, 8984600
Agent [candidate] (1.182 s) : 0, 1181607
Total [candidate] (8.977 s) : 0, 8977186
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.068 s -
Agent iast 1.177 s 108.936 ms (10.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.19 s 121.803 ms (11.4%)
Agent iast_TELEMETRY_OFF 1.176 s 107.085 ms (10.0%)
Total tracing 8.569 s -
Total iast 8.997 s 428.759 ms (5.0%)
Total iast_HARDCODED_SECRET_DISABLED 9.013 s 444.018 ms (5.2%)
Total iast_TELEMETRY_OFF 8.985 s 415.87 ms (4.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.055 s -
Agent iast 1.178 s 122.544 ms (11.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.179 s 123.971 ms (11.7%)
Agent iast_TELEMETRY_OFF 1.182 s 126.22 ms (12.0%)
Total tracing 8.535 s -
Total iast 9.003 s 467.25 ms (5.5%)
Total iast_HARDCODED_SECRET_DISABLED 8.994 s 458.456 ms (5.4%)
Total iast_TELEMETRY_OFF 8.977 s 441.871 ms (5.2%) 
gantt
    title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~e8e4c81c45, baseline=1.39.0-SNAPSHOT~ad0cb28e09

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.951 ms) : 0, 682951
BytebuddyAgent [candidate] (673.689 ms) : 0, 673689
GlobalTracer [baseline] (312.164 ms) : 0, 312164
GlobalTracer [candidate] (308.608 ms) : 0, 308608
AppSec [baseline] (51.464 ms) : 0, 51464
AppSec [candidate] (51.316 ms) : 0, 51316
Remote Config [baseline] (689.745 µs) : 0, 690
Remote Config [candidate] (681.085 µs) : 0, 681
Telemetry [baseline] (7.508 ms) : 0, 7508
Telemetry [candidate] (7.5 ms) : 0, 7500
section iast
BytebuddyAgent [baseline] (783.056 ms) : 0, 783056
BytebuddyAgent [candidate] (783.604 ms) : 0, 783604
GlobalTracer [baseline] (297.282 ms) : 0, 297282
GlobalTracer [candidate] (296.952 ms) : 0, 296952
AppSec [baseline] (55.319 ms) : 0, 55319
AppSec [candidate] (51.569 ms) : 0, 51569
IAST [baseline] (20.644 ms) : 0, 20644
IAST [candidate] (22.07 ms) : 0, 22070
Remote Config [baseline] (557.202 µs) : 0, 557
Remote Config [candidate] (609.655 µs) : 0, 610
Telemetry [baseline] (7.074 ms) : 0, 7074
Telemetry [candidate] (9.62 ms) : 0, 9620
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (790.535 ms) : 0, 790535
BytebuddyAgent [candidate] (783.801 ms) : 0, 783801
GlobalTracer [baseline] (301.012 ms) : 0, 301012
GlobalTracer [candidate] (297.615 ms) : 0, 297615
AppSec [baseline] (49.41 ms) : 0, 49410
AppSec [candidate] (48.938 ms) : 0, 48938
IAST [baseline] (25.461 ms) : 0, 25461
IAST [candidate] (23.74 ms) : 0, 23740
Remote Config [baseline] (598.691 µs) : 0, 599
Remote Config [candidate] (594.227 µs) : 0, 594
Telemetry [baseline] (9.641 ms) : 0, 9641
Telemetry [candidate] (11.124 ms) : 0, 11124
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (781.727 ms) : 0, 781727
BytebuddyAgent [candidate] (786.076 ms) : 0, 786076
GlobalTracer [baseline] (297.462 ms) : 0, 297462
GlobalTracer [candidate] (298.639 ms) : 0, 298639
AppSec [baseline] (53.329 ms) : 0, 53329
AppSec [candidate] (53.94 ms) : 0, 53940
IAST [baseline] (21.893 ms) : 0, 21893
IAST [candidate] (20.782 ms) : 0, 20782
Remote Config [baseline] (609.133 µs) : 0, 609
Remote Config [candidate] (615.091 µs) : 0, 615
Telemetry [baseline] (6.981 ms) : 0, 6981
Telemetry [candidate] (7.935 ms) : 0, 7935
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-08-16T07:04:11 2024-08-16T07:11:00
git_branch master mcculls/dropin-fixes-for-r2dbc
git_commit_date 1723791039 1723791272
git_commit_sha ad0cb28 e8e4c81
release_version 1.39.0-SNAPSHOT~ad0cb28e09 1.39.0-SNAPSHOT~e8e4c81c45
start_time 2024-08-16T07:03:58 2024-08-16T07:10:47
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1723792608 1723792608
ci_job_id 606873678 606873678
ci_pipeline_id 41949133 41949133
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 17 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:profiling worse
[+49.929µs; +104.950µs] or [+3.349%; +7.039%]		 unstable
[-779.755op/s; +305.681op/s] or [-24.367%; +9.553%]		 1.568ms 2962.963op/s 1.491ms 3200.000op/s
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~e8e4c81c45, baseline=1.39.0-SNAPSHOT~ad0cb28e09
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.355 ms) : 1336, 1374
.   : milestone, 1355,
appsec (1.74 ms) : 1717, 1763
.   : milestone, 1740,
appsec_no_iast (1.729 ms) : 1705, 1753
.   : milestone, 1729,
iast (1.476 ms) : 1453, 1498
.   : milestone, 1476,
profiling (1.491 ms) : 1465, 1517
.   : milestone, 1491,
tracing (1.469 ms) : 1445, 1494
.   : milestone, 1469,
section candidate
no_agent (1.364 ms) : 1345, 1384
.   : milestone, 1364,
appsec (1.709 ms) : 1686, 1731
.   : milestone, 1709,
appsec_no_iast (1.728 ms) : 1704, 1752
.   : milestone, 1728,
iast (1.476 ms) : 1453, 1500
.   : milestone, 1476,
profiling (1.568 ms) : 1543, 1593
.   : milestone, 1568,
tracing (1.483 ms) : 1459, 1508
.   : milestone, 1483,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.355 ms [1.336 ms, 1.374 ms] -
appsec 1.74 ms [1.717 ms, 1.763 ms] 385.188 µs (28.4%)
appsec_no_iast 1.729 ms [1.705 ms, 1.753 ms] 374.202 µs (27.6%)
iast 1.476 ms [1.453 ms, 1.498 ms] 120.967 µs (8.9%)
profiling 1.491 ms [1.465 ms, 1.517 ms] 136.243 µs (10.1%)
tracing 1.469 ms [1.445 ms, 1.494 ms] 114.632 µs (8.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.364 ms [1.345 ms, 1.384 ms] -
appsec 1.709 ms [1.686 ms, 1.731 ms] 344.256 µs (25.2%)
appsec_no_iast 1.728 ms [1.704 ms, 1.752 ms] 363.701 µs (26.7%)
iast 1.476 ms [1.453 ms, 1.5 ms] 112.03 µs (8.2%)
profiling 1.568 ms [1.543 ms, 1.593 ms] 204.091 µs (15.0%)
tracing 1.483 ms [1.459 ms, 1.508 ms] 118.78 µs (8.7%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~e8e4c81c45, baseline=1.39.0-SNAPSHOT~ad0cb28e09
    dateFormat X
    axisFormat %s
section baseline
no_agent (376.117 µs) : 356, 396
.   : milestone, 376,
iast (485.128 µs) : 464, 506
.   : milestone, 485,
iast_FULL (548.479 µs) : 526, 571
.   : milestone, 548,
iast_GLOBAL (505.36 µs) : 484, 527
.   : milestone, 505,
iast_HARDCODED_SECRET_DISABLED (479.431 µs) : 458, 501
.   : milestone, 479,
iast_INACTIVE (460.891 µs) : 438, 483
.   : milestone, 461,
iast_TELEMETRY_OFF (472.262 µs) : 451, 494
.   : milestone, 472,
tracing (441.167 µs) : 420, 462
.   : milestone, 441,
section candidate
no_agent (363.689 µs) : 344, 383
.   : milestone, 364,
iast (480.232 µs) : 459, 501
.   : milestone, 480,
iast_FULL (552.35 µs) : 530, 575
.   : milestone, 552,
iast_GLOBAL (510.264 µs) : 487, 534
.   : milestone, 510,
iast_HARDCODED_SECRET_DISABLED (481.407 µs) : 460, 502
.   : milestone, 481,
iast_INACTIVE (453.113 µs) : 430, 476
.   : milestone, 453,
iast_TELEMETRY_OFF (472.43 µs) : 451, 494
.   : milestone, 472,
tracing (444.951 µs) : 424, 465
.   : milestone, 445,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 376.117 µs [355.947 µs, 396.286 µs] -
iast 485.128 µs [463.924 µs, 506.332 µs] 109.012 µs (29.0%)
iast_FULL 548.479 µs [525.997 µs, 570.961 µs] 172.362 µs (45.8%)
iast_GLOBAL 505.36 µs [483.519 µs, 527.202 µs] 129.244 µs (34.4%)
iast_HARDCODED_SECRET_DISABLED 479.431 µs [458.279 µs, 500.584 µs] 103.315 µs (27.5%)
iast_INACTIVE 460.891 µs [438.496 µs, 483.287 µs] 84.775 µs (22.5%)
iast_TELEMETRY_OFF 472.262 µs [450.735 µs, 493.789 µs] 96.146 µs (25.6%)
tracing 441.167 µs [420.265 µs, 462.068 µs] 65.05 µs (17.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 363.689 µs [344.394 µs, 382.984 µs] -
iast 480.232 µs [459.144 µs, 501.32 µs] 116.543 µs (32.0%)
iast_FULL 552.35 µs [530.133 µs, 574.566 µs] 188.66 µs (51.9%)
iast_GLOBAL 510.264 µs [486.832 µs, 533.697 µs] 146.575 µs (40.3%)
iast_HARDCODED_SECRET_DISABLED 481.407 µs [460.325 µs, 502.489 µs] 117.717 µs (32.4%)
iast_INACTIVE 453.113 µs [430.386 µs, 475.841 µs] 89.424 µs (24.6%)
iast_TELEMETRY_OFF 472.43 µs [451.131 µs, 493.729 µs] 108.741 µs (29.9%)
tracing 444.951 µs [424.452 µs, 465.45 µs] 81.261 µs (22.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/dropin-fixes-for-r2dbc
git_commit_date 1723791039 1723791272
git_commit_sha ad0cb28 e8e4c81
release_version 1.39.0-SNAPSHOT~ad0cb28e09 1.39.0-SNAPSHOT~e8e4c81c45
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1723793114 1723793114
ci_job_id 606873679 606873679
ci_pipeline_id 41949133 41949133
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~e8e4c81c45, baseline=1.39.0-SNAPSHOT~ad0cb28e09
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.98 s) : 14980000, 14980000
.   : milestone, 14980000,
appsec (14.949 s) : 14949000, 14949000
.   : milestone, 14949000,
iast (18.834 s) : 18834000, 18834000
.   : milestone, 18834000,
iast_GLOBAL (17.822 s) : 17822000, 17822000
.   : milestone, 17822000,
profiling (15.692 s) : 15692000, 15692000
.   : milestone, 15692000,
tracing (14.908 s) : 14908000, 14908000
.   : milestone, 14908000,
section candidate
no_agent (15.046 s) : 15046000, 15046000
.   : milestone, 15046000,
appsec (15.15 s) : 15150000, 15150000
.   : milestone, 15150000,
iast (18.884 s) : 18884000, 18884000
.   : milestone, 18884000,
iast_GLOBAL (17.989 s) : 17989000, 17989000
.   : milestone, 17989000,
profiling (15.055 s) : 15055000, 15055000
.   : milestone, 15055000,
tracing (15.299 s) : 15299000, 15299000
.   : milestone, 15299000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.98 s [14.98 s, 14.98 s] -
appsec 14.949 s [14.949 s, 14.949 s] -31.0 ms (-0.2%)
iast 18.834 s [18.834 s, 18.834 s] 3.854 s (25.7%)
iast_GLOBAL 17.822 s [17.822 s, 17.822 s] 2.842 s (19.0%)
profiling 15.692 s [15.692 s, 15.692 s] 712.0 ms (4.8%)
tracing 14.908 s [14.908 s, 14.908 s] -72.0 ms (-0.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.046 s [15.046 s, 15.046 s] -
appsec 15.15 s [15.15 s, 15.15 s] 104.0 ms (0.7%)
iast 18.884 s [18.884 s, 18.884 s] 3.838 s (25.5%)
iast_GLOBAL 17.989 s [17.989 s, 17.989 s] 2.943 s (19.6%)
profiling 15.055 s [15.055 s, 15.055 s] 9.0 ms (0.1%)
tracing 15.299 s [15.299 s, 15.299 s] 253.0 ms (1.7%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~e8e4c81c45, baseline=1.39.0-SNAPSHOT~ad0cb28e09
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.451 ms) : 1440, 1463
.   : milestone, 1451,
appsec (2.213 ms) : 2178, 2249
.   : milestone, 2213,
iast (1.98 ms) : 1936, 2023
.   : milestone, 1980,
iast_GLOBAL (2.022 ms) : 1978, 2065
.   : milestone, 2022,
profiling (1.848 ms) : 1814, 1882
.   : milestone, 1848,
tracing (1.836 ms) : 1802, 1870
.   : milestone, 1836,
section candidate
no_agent (1.452 ms) : 1441, 1464
.   : milestone, 1452,
appsec (2.221 ms) : 2186, 2256
.   : milestone, 2221,
iast (1.953 ms) : 1911, 1995
.   : milestone, 1953,
iast_GLOBAL (2.023 ms) : 1979, 2067
.   : milestone, 2023,
profiling (1.866 ms) : 1830, 1902
.   : milestone, 1866,
tracing (1.834 ms) : 1801, 1867
.   : milestone, 1834,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.451 ms [1.44 ms, 1.463 ms] -
appsec 2.213 ms [2.178 ms, 2.249 ms] 761.916 µs (52.5%)
iast 1.98 ms [1.936 ms, 2.023 ms] 528.094 µs (36.4%)
iast_GLOBAL 2.022 ms [1.978 ms, 2.065 ms] 570.31 µs (39.3%)
profiling 1.848 ms [1.814 ms, 1.882 ms] 396.849 µs (27.3%)
tracing 1.836 ms [1.802 ms, 1.87 ms] 384.473 µs (26.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.452 ms [1.441 ms, 1.464 ms] -
appsec 2.221 ms [2.186 ms, 2.256 ms] 768.408 µs (52.9%)
iast 1.953 ms [1.911 ms, 1.995 ms] 500.584 µs (34.5%)
iast_GLOBAL 2.023 ms [1.979 ms, 2.067 ms] 570.609 µs (39.3%)
profiling 1.866 ms [1.83 ms, 1.902 ms] 413.155 µs (28.4%)
tracing 1.834 ms [1.801 ms, 1.867 ms] 381.363 µs (26.3%)

@mcculls mcculls enabled auto-merge (squash) August 15, 2024 07:16
@mcculls mcculls force-pushed the mcculls/dropin-fixes-for-r2dbc branch from d504c88 to 7aa199a Compare August 15, 2024 16:33
PerfectSlayer
PerfectSlayer reviewed Aug 16, 2024
View reviewed changes
Comment thread .../datadog/trace/bootstrap/otel/instrumentation/api/incubator/semconv/db/SqlStatementInfo.java Outdated
private final String table;

public static SqlStatementInfo create(String statement, String operation, String table) {
return null;
Copy link
Copy Markdown
Contributor

@PerfectSlayer PerfectSlayer Aug 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you left it null on purpose?

Copy link
Copy Markdown
Contributor Author

@mcculls mcculls Aug 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No - note it doesn't matter in practice because this class gets overwritten with the real one. This one is only for compilation purposes.

I'll fix this for consistency though, because the real one won't be returning null :)

Copy link
Copy Markdown
Contributor Author

@mcculls mcculls Aug 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e8e4c81 -see also #7451 which backports the same review feedback

Copy link
Copy Markdown
Contributor

@PerfectSlayer PerfectSlayer Aug 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I thought but I was wondering if there were some edge cases when you wanted to be null for testing purpose or something 🤷

@smola smola mentioned this pull request Aug 16, 2024
Merged
@mcculls mcculls merged commit 0c56eb6 into master Aug 16, 2024
@mcculls mcculls deleted the mcculls/dropin-fixes-for-r2dbc branch August 16, 2024 07:42
@github-actions github-actions Bot added this to the 1.39.0 milestone Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@ygree ygree Awaiting requested review from ygree ygree was automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

inst: opentelemetry OpenTelemetry instrumentation

Projects

None yet

Milestone

1.39.0

Development

Successfully merging this pull request may close these issues.

2 participants

@mcculls @PerfectSlayer