Skip to content

Cache separate InstrumentPlugin class-loader for each distinct set of plugins#7435

Merged
mcculls merged 1 commit intomasterfrom
mcculls/gradle-plugin-classpath-fix
Aug 16, 2024
Merged

Cache separate InstrumentPlugin class-loader for each distinct set of plugins#7435
mcculls merged 1 commit intomasterfrom
mcculls/gradle-plugin-classpath-fix

Conversation

@mcculls
Copy link
Copy Markdown
Contributor

@mcculls mcculls commented Aug 14, 2024 •
edited
Loading

What Does This Do

Rather than have a single cached class-loader that we then have to switch based on the plugin class-path, have a class-loader for each distinct set of plugins. This should be more stable and less complicated to manage.

Also avoids a potential concurrency issue where the pluginCL field was being accessed outside the synchronized block and could have been updated in another thread to use a different plugin class-path. Since each plugin set has its own stable class-loader and pluginCL is now a local variable this can no longer occur.

Motivation

More stable builds 🍀

@mcculls mcculls added tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Aug 14, 2024
@mcculls mcculls force-pushed the mcculls/gradle-plugin-classpath-fix branch from a8f709a to 3f95c3d Compare August 14, 2024 12:06
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Aug 14, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/gradle-plugin-classpath-fix
git_commit_date 1723739593 1723739618
git_commit_sha fcd4bc4 f77c73f
release_version 1.39.0-SNAPSHOT~fcd4bc4862 1.39.0-SNAPSHOT~f77c73f34a
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1723741997 1723741997
ci_job_id 606261862 606261862
ci_pipeline_id 41884672 41884672
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 16 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~f77c73f34a, baseline=1.39.0-SNAPSHOT~fcd4bc4862

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1049193
Total [baseline] (10.395 s) : 0, 10394962
Agent [candidate] (1.049 s) : 0, 1048866
Total [candidate] (10.338 s) : 0, 10338384
section appsec
Agent [baseline] (1.176 s) : 0, 1175928
Total [baseline] (10.502 s) : 0, 10502400
Agent [candidate] (1.176 s) : 0, 1175779
Total [candidate] (10.513 s) : 0, 10513207
section iast
Agent [baseline] (1.176 s) : 0, 1175533
Total [baseline] (10.849 s) : 0, 10849053
Agent [candidate] (1.175 s) : 0, 1174651
Total [candidate] (10.872 s) : 0, 10871847
section profiling
Agent [baseline] (1.245 s) : 0, 1244967
Total [baseline] (10.575 s) : 0, 10574708
Agent [candidate] (1.244 s) : 0, 1244072
Total [candidate] (10.634 s) : 0, 10633633
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.049 s -
Agent appsec 1.176 s 126.735 ms (12.1%)
Agent iast 1.176 s 126.34 ms (12.0%)
Agent profiling 1.245 s 195.773 ms (18.7%)
Total tracing 10.395 s -
Total appsec 10.502 s 107.438 ms (1.0%)
Total iast 10.849 s 454.091 ms (4.4%)
Total profiling 10.575 s 179.746 ms (1.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.049 s -
Agent appsec 1.176 s 126.913 ms (12.1%)
Agent iast 1.175 s 125.785 ms (12.0%)
Agent profiling 1.244 s 195.206 ms (18.6%)
Total tracing 10.338 s -
Total appsec 10.513 s 174.823 ms (1.7%)
Total iast 10.872 s 533.463 ms (5.2%)
Total profiling 10.634 s 295.249 ms (2.9%) 
gantt
    title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~f77c73f34a, baseline=1.39.0-SNAPSHOT~fcd4bc4862

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (669.373 ms) : 0, 669373
BytebuddyAgent [candidate] (668.973 ms) : 0, 668973
GlobalTracer [baseline] (306.981 ms) : 0, 306981
GlobalTracer [candidate] (307.166 ms) : 0, 307166
AppSec [baseline] (51.185 ms) : 0, 51185
AppSec [candidate] (51.052 ms) : 0, 51052
Remote Config [baseline] (696.776 µs) : 0, 697
Remote Config [candidate] (685.298 µs) : 0, 685
Telemetry [baseline] (7.529 ms) : 0, 7529
Telemetry [candidate] (7.531 ms) : 0, 7531
section appsec
BytebuddyAgent [baseline] (682.505 ms) : 0, 682505
BytebuddyAgent [candidate] (683.553 ms) : 0, 683553
GlobalTracer [baseline] (301.557 ms) : 0, 301557
GlobalTracer [candidate] (301.746 ms) : 0, 301746
AppSec [baseline] (157.803 ms) : 0, 157803
AppSec [candidate] (157.738 ms) : 0, 157738
IAST [baseline] (20.418 ms) : 0, 20418
IAST [candidate] (20.856 ms) : 0, 20856
Remote Config [baseline] (605.47 µs) : 0, 605
Remote Config [candidate] (606.442 µs) : 0, 606
Telemetry [baseline] (9.704 ms) : 0, 9704
Telemetry [candidate] (8.135 ms) : 0, 8135
section iast
BytebuddyAgent [baseline] (782.002 ms) : 0, 782002
BytebuddyAgent [candidate] (780.834 ms) : 0, 780834
GlobalTracer [baseline] (296.549 ms) : 0, 296549
GlobalTracer [candidate] (296.081 ms) : 0, 296081
AppSec [baseline] (51.602 ms) : 0, 51602
AppSec [candidate] (50.526 ms) : 0, 50526
IAST [baseline] (23.304 ms) : 0, 23304
IAST [candidate] (25.215 ms) : 0, 25215
Remote Config [baseline] (593.043 µs) : 0, 593
Remote Config [candidate] (598.675 µs) : 0, 599
Telemetry [baseline] (8.027 ms) : 0, 8027
Telemetry [candidate] (7.95 ms) : 0, 7950
section profiling
BytebuddyAgent [baseline] (663.158 ms) : 0, 663158
BytebuddyAgent [candidate] (662.297 ms) : 0, 662297
GlobalTracer [baseline] (390.712 ms) : 0, 390712
GlobalTracer [candidate] (390.259 ms) : 0, 390259
AppSec [baseline] (51.704 ms) : 0, 51704
AppSec [candidate] (52.024 ms) : 0, 52024
Remote Config [baseline] (689.855 µs) : 0, 690
Remote Config [candidate] (680.767 µs) : 0, 681
Telemetry [baseline] (7.379 ms) : 0, 7379
Telemetry [candidate] (7.391 ms) : 0, 7391
ProfilingAgent [baseline] (94.222 ms) : 0, 94222
ProfilingAgent [candidate] (94.318 ms) : 0, 94318
Profiling [baseline] (94.247 ms) : 0, 94247
Profiling [candidate] (94.343 ms) : 0, 94343
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~f77c73f34a, baseline=1.39.0-SNAPSHOT~fcd4bc4862

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1047494
Total [baseline] (8.499 s) : 0, 8499122
Agent [candidate] (1.045 s) : 0, 1045224
Total [candidate] (8.5 s) : 0, 8500457
section iast
Agent [baseline] (1.175 s) : 0, 1175171
Total [baseline] (8.983 s) : 0, 8982658
Agent [candidate] (1.175 s) : 0, 1175011
Total [candidate] (9.011 s) : 0, 9010927
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.181 s) : 0, 1180937
Total [baseline] (8.994 s) : 0, 8993612
Agent [candidate] (1.178 s) : 0, 1178246
Total [candidate] (8.984 s) : 0, 8983894
section iast_TELEMETRY_OFF
Agent [baseline] (1.173 s) : 0, 1173345
Total [baseline] (8.984 s) : 0, 8984079
Agent [candidate] (1.174 s) : 0, 1174429
Total [candidate] (8.977 s) : 0, 8977246
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.047 s -
Agent iast 1.175 s 127.678 ms (12.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.181 s 133.443 ms (12.7%)
Agent iast_TELEMETRY_OFF 1.173 s 125.851 ms (12.0%)
Total tracing 8.499 s -
Total iast 8.983 s 483.536 ms (5.7%)
Total iast_HARDCODED_SECRET_DISABLED 8.994 s 494.49 ms (5.8%)
Total iast_TELEMETRY_OFF 8.984 s 484.957 ms (5.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.045 s -
Agent iast 1.175 s 129.787 ms (12.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.178 s 133.022 ms (12.7%)
Agent iast_TELEMETRY_OFF 1.174 s 129.205 ms (12.4%)
Total tracing 8.5 s -
Total iast 9.011 s 510.47 ms (6.0%)
Total iast_HARDCODED_SECRET_DISABLED 8.984 s 483.438 ms (5.7%)
Total iast_TELEMETRY_OFF 8.977 s 476.79 ms (5.6%) 
gantt
    title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~f77c73f34a, baseline=1.39.0-SNAPSHOT~fcd4bc4862

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (668.274 ms) : 0, 668274
BytebuddyAgent [candidate] (667.274 ms) : 0, 667274
GlobalTracer [baseline] (306.6 ms) : 0, 306600
GlobalTracer [candidate] (305.633 ms) : 0, 305633
AppSec [baseline] (51.018 ms) : 0, 51018
AppSec [candidate] (50.759 ms) : 0, 50759
Remote Config [baseline] (687.482 µs) : 0, 687
Remote Config [candidate] (681.246 µs) : 0, 681
Telemetry [baseline] (7.538 ms) : 0, 7538
Telemetry [candidate] (7.458 ms) : 0, 7458
section iast
BytebuddyAgent [baseline] (781.112 ms) : 0, 781112
BytebuddyAgent [candidate] (782.179 ms) : 0, 782179
GlobalTracer [baseline] (296.312 ms) : 0, 296312
GlobalTracer [candidate] (295.975 ms) : 0, 295975
AppSec [baseline] (54.204 ms) : 0, 54204
AppSec [candidate] (52.232 ms) : 0, 52232
IAST [baseline] (21.572 ms) : 0, 21572
IAST [candidate] (21.788 ms) : 0, 21788
Remote Config [baseline] (571.828 µs) : 0, 572
Remote Config [candidate] (577.573 µs) : 0, 578
Telemetry [baseline] (7.946 ms) : 0, 7946
Telemetry [candidate] (8.818 ms) : 0, 8818
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (785.752 ms) : 0, 785752
BytebuddyAgent [candidate] (783.133 ms) : 0, 783133
GlobalTracer [baseline] (297.416 ms) : 0, 297416
GlobalTracer [candidate] (297.34 ms) : 0, 297340
AppSec [baseline] (49.627 ms) : 0, 49627
AppSec [candidate] (47.935 ms) : 0, 47935
IAST [baseline] (26.06 ms) : 0, 26060
IAST [candidate] (23.776 ms) : 0, 23776
Remote Config [baseline] (600.707 µs) : 0, 601
Remote Config [candidate] (584.704 µs) : 0, 585
Telemetry [baseline] (7.945 ms) : 0, 7945
Telemetry [candidate] (11.956 ms) : 0, 11956
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (779.713 ms) : 0, 779713
BytebuddyAgent [candidate] (780.521 ms) : 0, 780521
GlobalTracer [baseline] (296.963 ms) : 0, 296963
GlobalTracer [candidate] (297.45 ms) : 0, 297450
AppSec [baseline] (54.182 ms) : 0, 54182
AppSec [candidate] (52.192 ms) : 0, 52192
IAST [baseline] (21.322 ms) : 0, 21322
IAST [candidate] (21.479 ms) : 0, 21479
Remote Config [baseline] (620.729 µs) : 0, 621
Remote Config [candidate] (613.034 µs) : 0, 613
Telemetry [baseline] (7.064 ms) : 0, 7064
Telemetry [candidate] (8.645 ms) : 0, 8645
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-08-15T16:43:59 2024-08-15T16:50:46
git_branch master mcculls/gradle-plugin-classpath-fix
git_commit_date 1723739593 1723739618
git_commit_sha fcd4bc4 f77c73f
release_version 1.39.0-SNAPSHOT~fcd4bc4862 1.39.0-SNAPSHOT~f77c73f34a
start_time 2024-08-15T16:43:46 2024-08-15T16:50:33
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1723740990 1723740990
ci_job_id 606261864 606261864
ci_pipeline_id 41884672 41884672
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~f77c73f34a, baseline=1.39.0-SNAPSHOT~fcd4bc4862
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.344 ms) : 1325, 1364
.   : milestone, 1344,
appsec (1.724 ms) : 1701, 1746
.   : milestone, 1724,
appsec_no_iast (1.716 ms) : 1691, 1741
.   : milestone, 1716,
iast (1.452 ms) : 1430, 1475
.   : milestone, 1452,
profiling (1.468 ms) : 1444, 1493
.   : milestone, 1468,
tracing (1.456 ms) : 1432, 1479
.   : milestone, 1456,
section candidate
no_agent (1.336 ms) : 1316, 1356
.   : milestone, 1336,
appsec (1.721 ms) : 1698, 1744
.   : milestone, 1721,
appsec_no_iast (1.702 ms) : 1677, 1726
.   : milestone, 1702,
iast (1.465 ms) : 1442, 1487
.   : milestone, 1465,
profiling (1.521 ms) : 1496, 1547
.   : milestone, 1521,
tracing (1.446 ms) : 1421, 1471
.   : milestone, 1446,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.344 ms [1.325 ms, 1.364 ms] -
appsec 1.724 ms [1.701 ms, 1.746 ms] 379.071 µs (28.2%)
appsec_no_iast 1.716 ms [1.691 ms, 1.741 ms] 371.683 µs (27.6%)
iast 1.452 ms [1.43 ms, 1.475 ms] 107.729 µs (8.0%)
profiling 1.468 ms [1.444 ms, 1.493 ms] 123.927 µs (9.2%)
tracing 1.456 ms [1.432 ms, 1.479 ms] 111.232 µs (8.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.336 ms [1.316 ms, 1.356 ms] -
appsec 1.721 ms [1.698 ms, 1.744 ms] 385.178 µs (28.8%)
appsec_no_iast 1.702 ms [1.677 ms, 1.726 ms] 365.384 µs (27.3%)
iast 1.465 ms [1.442 ms, 1.487 ms] 128.438 µs (9.6%)
profiling 1.521 ms [1.496 ms, 1.547 ms] 185.316 µs (13.9%)
tracing 1.446 ms [1.421 ms, 1.471 ms] 109.572 µs (8.2%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~f77c73f34a, baseline=1.39.0-SNAPSHOT~fcd4bc4862
    dateFormat X
    axisFormat %s
section baseline
no_agent (373.957 µs) : 354, 394
.   : milestone, 374,
iast (482.774 µs) : 461, 505
.   : milestone, 483,
iast_FULL (548.921 µs) : 526, 571
.   : milestone, 549,
iast_GLOBAL (499.396 µs) : 478, 521
.   : milestone, 499,
iast_HARDCODED_SECRET_DISABLED (481.67 µs) : 460, 503
.   : milestone, 482,
iast_INACTIVE (451.735 µs) : 429, 474
.   : milestone, 452,
iast_TELEMETRY_OFF (468.364 µs) : 447, 490
.   : milestone, 468,
tracing (434.97 µs) : 415, 455
.   : milestone, 435,
section candidate
no_agent (367.955 µs) : 348, 388
.   : milestone, 368,
iast (478.404 µs) : 457, 499
.   : milestone, 478,
iast_FULL (548.691 µs) : 526, 571
.   : milestone, 549,
iast_GLOBAL (503.563 µs) : 481, 526
.   : milestone, 504,
iast_HARDCODED_SECRET_DISABLED (475.371 µs) : 454, 496
.   : milestone, 475,
iast_INACTIVE (454.054 µs) : 431, 477
.   : milestone, 454,
iast_TELEMETRY_OFF (463.779 µs) : 442, 485
.   : milestone, 464,
tracing (439.342 µs) : 419, 459
.   : milestone, 439,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 373.957 µs [354.398 µs, 393.515 µs] -
iast 482.774 µs [461.046 µs, 504.503 µs] 108.818 µs (29.1%)
iast_FULL 548.921 µs [526.4 µs, 571.441 µs] 174.964 µs (46.8%)
iast_GLOBAL 499.396 µs [477.521 µs, 521.272 µs] 125.44 µs (33.5%)
iast_HARDCODED_SECRET_DISABLED 481.67 µs [460.288 µs, 503.052 µs] 107.713 µs (28.8%)
iast_INACTIVE 451.735 µs [429.205 µs, 474.265 µs] 77.778 µs (20.8%)
iast_TELEMETRY_OFF 468.364 µs [447.215 µs, 489.512 µs] 94.407 µs (25.2%)
tracing 434.97 µs [414.876 µs, 455.064 µs] 61.014 µs (16.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 367.955 µs [347.645 µs, 388.265 µs] -
iast 478.404 µs [457.437 µs, 499.372 µs] 110.45 µs (30.0%)
iast_FULL 548.691 µs [526.191 µs, 571.192 µs] 180.736 µs (49.1%)
iast_GLOBAL 503.563 µs [480.915 µs, 526.21 µs] 135.608 µs (36.9%)
iast_HARDCODED_SECRET_DISABLED 475.371 µs [454.427 µs, 496.315 µs] 107.416 µs (29.2%)
iast_INACTIVE 454.054 µs [431.463 µs, 476.644 µs] 86.099 µs (23.4%)
iast_TELEMETRY_OFF 463.779 µs [442.094 µs, 485.464 µs] 95.824 µs (26.0%)
tracing 439.342 µs [419.253 µs, 459.432 µs] 71.388 µs (19.4%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/gradle-plugin-classpath-fix
git_commit_date 1723739593 1723739618
git_commit_sha fcd4bc4 f77c73f
release_version 1.39.0-SNAPSHOT~fcd4bc4862 1.39.0-SNAPSHOT~f77c73f34a
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1723741529 1723741529
ci_job_id 606261866 606261866
ci_pipeline_id 41884672 41884672
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~f77c73f34a, baseline=1.39.0-SNAPSHOT~fcd4bc4862
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.459 ms) : 1447, 1470
.   : milestone, 1459,
appsec (2.227 ms) : 2192, 2263
.   : milestone, 2227,
iast (1.968 ms) : 1925, 2010
.   : milestone, 1968,
iast_GLOBAL (2.025 ms) : 1981, 2069
.   : milestone, 2025,
profiling (1.857 ms) : 1822, 1893
.   : milestone, 1857,
tracing (1.845 ms) : 1811, 1878
.   : milestone, 1845,
section candidate
no_agent (1.461 ms) : 1449, 1472
.   : milestone, 1461,
appsec (2.245 ms) : 2209, 2281
.   : milestone, 2245,
iast (1.976 ms) : 1933, 2018
.   : milestone, 1976,
iast_GLOBAL (2.027 ms) : 1983, 2071
.   : milestone, 2027,
profiling (1.851 ms) : 1816, 1887
.   : milestone, 1851,
tracing (1.846 ms) : 1813, 1880
.   : milestone, 1846,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.459 ms [1.447 ms, 1.47 ms] -
appsec 2.227 ms [2.192 ms, 2.263 ms] 768.702 µs (52.7%)
iast 1.968 ms [1.925 ms, 2.01 ms] 508.939 µs (34.9%)
iast_GLOBAL 2.025 ms [1.981 ms, 2.069 ms] 566.145 µs (38.8%)
profiling 1.857 ms [1.822 ms, 1.893 ms] 398.736 µs (27.3%)
tracing 1.845 ms [1.811 ms, 1.878 ms] 386.003 µs (26.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.461 ms [1.449 ms, 1.472 ms] -
appsec 2.245 ms [2.209 ms, 2.281 ms] 784.409 µs (53.7%)
iast 1.976 ms [1.933 ms, 2.018 ms] 515.006 µs (35.3%)
iast_GLOBAL 2.027 ms [1.983 ms, 2.071 ms] 565.96 µs (38.7%)
profiling 1.851 ms [1.816 ms, 1.887 ms] 390.545 µs (26.7%)
tracing 1.846 ms [1.813 ms, 1.88 ms] 385.67 µs (26.4%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~f77c73f34a, baseline=1.39.0-SNAPSHOT~fcd4bc4862
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.418 s) : 15418000, 15418000
.   : milestone, 15418000,
appsec (14.943 s) : 14943000, 14943000
.   : milestone, 14943000,
iast (18.842 s) : 18842000, 18842000
.   : milestone, 18842000,
iast_GLOBAL (17.804 s) : 17804000, 17804000
.   : milestone, 17804000,
profiling (15.04 s) : 15040000, 15040000
.   : milestone, 15040000,
tracing (15.119 s) : 15119000, 15119000
.   : milestone, 15119000,
section candidate
no_agent (15.098 s) : 15098000, 15098000
.   : milestone, 15098000,
appsec (15.221 s) : 15221000, 15221000
.   : milestone, 15221000,
iast (18.82 s) : 18820000, 18820000
.   : milestone, 18820000,
iast_GLOBAL (17.859 s) : 17859000, 17859000
.   : milestone, 17859000,
profiling (15.242 s) : 15242000, 15242000
.   : milestone, 15242000,
tracing (15.046 s) : 15046000, 15046000
.   : milestone, 15046000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.418 s [15.418 s, 15.418 s] -
appsec 14.943 s [14.943 s, 14.943 s] -475.0 ms (-3.1%)
iast 18.842 s [18.842 s, 18.842 s] 3.424 s (22.2%)
iast_GLOBAL 17.804 s [17.804 s, 17.804 s] 2.386 s (15.5%)
profiling 15.04 s [15.04 s, 15.04 s] -378.0 ms (-2.5%)
tracing 15.119 s [15.119 s, 15.119 s] -299.0 ms (-1.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.098 s [15.098 s, 15.098 s] -
appsec 15.221 s [15.221 s, 15.221 s] 123.0 ms (0.8%)
iast 18.82 s [18.82 s, 18.82 s] 3.722 s (24.7%)
iast_GLOBAL 17.859 s [17.859 s, 17.859 s] 2.761 s (18.3%)
profiling 15.242 s [15.242 s, 15.242 s] 144.0 ms (1.0%)
tracing 15.046 s [15.046 s, 15.046 s] -52.0 ms (-0.3%)

@mcculls mcculls changed the title [WIP] Cache separate InstrumentPlugin class-loader for each distinct set of plugins Cache separate InstrumentPlugin class-loader for each distinct set of plugins Aug 14, 2024
@mcculls mcculls marked this pull request as ready for review August 14, 2024 12:58
@mcculls mcculls requested a review from a team as a code owner August 14, 2024 12:58
@mcculls mcculls requested review from PerfectSlayer and ygree August 14, 2024 12:58
@mcculls
Copy link
Copy Markdown
Contributor Author

mcculls commented Aug 14, 2024

Note the GradleDaemonSmokeTest failures are expected and also occur on master (since Gradle 8.10 was released)

@mcculls mcculls force-pushed the mcculls/gradle-plugin-classpath-fix branch from 3f95c3d to 09a6c33 Compare August 14, 2024 17:30
@mcculls mcculls force-pushed the mcculls/gradle-plugin-classpath-fix branch from 09a6c33 to f77c73f Compare August 15, 2024 16:33
@mcculls mcculls enabled auto-merge (squash) August 15, 2024 18:58
PerfectSlayer
PerfectSlayer approved these changes Aug 16, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix! Thanks a lot 🤝

@mcculls mcculls merged commit 2fa95bf into master Aug 16, 2024
@mcculls mcculls deleted the mcculls/gradle-plugin-classpath-fix branch August 16, 2024 06:03
@github-actions github-actions Bot added this to the 1.39.0 milestone Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@ygree ygree Awaiting requested review from ygree ygree is a code owner automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes

Projects

None yet

Milestone

1.39.0

Development

Successfully merging this pull request may close these issues.

2 participants

@mcculls @PerfectSlayer