Skip to content

Improving crash tracking script initialization error handling#7427

Merged
PerfectSlayer merged 1 commit intomasterfrom
bbujon/crashtracking
Aug 27, 2024
Merged

Improving crash tracking script initialization error handling#7427
PerfectSlayer merged 1 commit intomasterfrom
bbujon/crashtracking

Conversation

@PerfectSlayer
Copy link
Copy Markdown
Contributor

@PerfectSlayer PerfectSlayer commented Aug 14, 2024 •
edited by atlassian Bot
Loading

What Does This Do

Improve Crash Tracking and OOME notification scripts initialization to capture and explain as much as possible setup issues and avoid to add stacktraces in log events.
It also splits Crash Tracking and OOME Notifier initialization logic for readability.

Motivation

Having stacktraces in startup log events bother the customers and creates escalations.

Additional Notes

Contributor Checklist

Jira ticket: APMS-12931

@PerfectSlayer
feat: Improving error handling
01d0360 
Try to capture and explain as much as possible initialization error.
Avoid to throw stacktraces in log events.
Split crash tracking and OOME notifier initialization for readibility.
@PerfectSlayer PerfectSlayer requested a review from a team as a code owner August 14, 2024 06:14
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Aug 14, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/crashtracking
git_commit_date 1723583620 1723615602
git_commit_sha 4c58087 01d0360
release_version 1.39.0-SNAPSHOT~4c58087c38 1.39.0-SNAPSHOT~01d0360b9f
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1723618127 1723618127
ci_job_id 604457697 604457697
ci_pipeline_id 41725774 41725774
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 15 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~01d0360b9f, baseline=1.39.0-SNAPSHOT~4c58087c38

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.053 s) : 0, 1052574
Total [baseline] (8.504 s) : 0, 8504393
Agent [candidate] (1.047 s) : 0, 1046576
Total [candidate] (8.478 s) : 0, 8477567
section iast
Agent [baseline] (1.174 s) : 0, 1173913
Total [baseline] (8.971 s) : 0, 8971256
Agent [candidate] (1.178 s) : 0, 1177620
Total [candidate] (8.991 s) : 0, 8990883
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.175 s) : 0, 1174660
Total [baseline] (8.965 s) : 0, 8965286
Agent [candidate] (1.183 s) : 0, 1183039
Total [candidate] (8.973 s) : 0, 8972819
section iast_TELEMETRY_OFF
Agent [baseline] (1.178 s) : 0, 1177870
Total [baseline] (9.003 s) : 0, 9003457
Agent [candidate] (1.179 s) : 0, 1178675
Total [candidate] (9.019 s) : 0, 9019450
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.053 s -
Agent iast 1.174 s 121.339 ms (11.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.175 s 122.086 ms (11.6%)
Agent iast_TELEMETRY_OFF 1.178 s 125.296 ms (11.9%)
Total tracing 8.504 s -
Total iast 8.971 s 466.863 ms (5.5%)
Total iast_HARDCODED_SECRET_DISABLED 8.965 s 460.892 ms (5.4%)
Total iast_TELEMETRY_OFF 9.003 s 499.064 ms (5.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.047 s -
Agent iast 1.178 s 131.045 ms (12.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.183 s 136.464 ms (13.0%)
Agent iast_TELEMETRY_OFF 1.179 s 132.099 ms (12.6%)
Total tracing 8.478 s -
Total iast 8.991 s 513.317 ms (6.1%)
Total iast_HARDCODED_SECRET_DISABLED 8.973 s 495.253 ms (5.8%)
Total iast_TELEMETRY_OFF 9.019 s 541.883 ms (6.4%) 
gantt
    title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~01d0360b9f, baseline=1.39.0-SNAPSHOT~4c58087c38

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (671.418 ms) : 0, 671418
BytebuddyAgent [candidate] (667.391 ms) : 0, 667391
GlobalTracer [baseline] (308.221 ms) : 0, 308221
GlobalTracer [candidate] (306.51 ms) : 0, 306510
AppSec [baseline] (51.28 ms) : 0, 51280
AppSec [candidate] (51.092 ms) : 0, 51092
Remote Config [baseline] (698.886 µs) : 0, 699
Remote Config [candidate] (681.346 µs) : 0, 681
Telemetry [baseline] (7.493 ms) : 0, 7493
Telemetry [candidate] (7.526 ms) : 0, 7526
section iast
BytebuddyAgent [baseline] (781.596 ms) : 0, 781596
BytebuddyAgent [candidate] (784.308 ms) : 0, 784308
GlobalTracer [baseline] (295.382 ms) : 0, 295382
GlobalTracer [candidate] (295.901 ms) : 0, 295901
AppSec [baseline] (52.797 ms) : 0, 52797
AppSec [candidate] (53.151 ms) : 0, 53151
IAST [baseline] (22.322 ms) : 0, 22322
IAST [candidate] (21.545 ms) : 0, 21545
Remote Config [baseline] (573.779 µs) : 0, 574
Remote Config [candidate] (576.415 µs) : 0, 576
Telemetry [baseline] (7.804 ms) : 0, 7804
Telemetry [candidate] (8.616 ms) : 0, 8616
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (781.234 ms) : 0, 781234
BytebuddyAgent [candidate] (786.708 ms) : 0, 786708
GlobalTracer [baseline] (296.205 ms) : 0, 296205
GlobalTracer [candidate] (298.936 ms) : 0, 298936
AppSec [baseline] (48.111 ms) : 0, 48111
AppSec [candidate] (48.581 ms) : 0, 48581
IAST [baseline] (23.779 ms) : 0, 23779
IAST [candidate] (25.096 ms) : 0, 25096
Remote Config [baseline] (599.992 µs) : 0, 600
Remote Config [candidate] (579.43 µs) : 0, 579
Telemetry [baseline] (11.227 ms) : 0, 11227
Telemetry [candidate] (9.513 ms) : 0, 9513
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (783.323 ms) : 0, 783323
BytebuddyAgent [candidate] (785.085 ms) : 0, 785085
GlobalTracer [baseline] (298.117 ms) : 0, 298117
GlobalTracer [candidate] (298.933 ms) : 0, 298933
AppSec [baseline] (50.925 ms) : 0, 50925
AppSec [candidate] (51.639 ms) : 0, 51639
IAST [baseline] (23.34 ms) : 0, 23340
IAST [candidate] (20.845 ms) : 0, 20845
Remote Config [baseline] (637.37 µs) : 0, 637
Remote Config [candidate] (629.715 µs) : 0, 630
Telemetry [baseline] (8.003 ms) : 0, 8003
Telemetry [candidate] (7.968 ms) : 0, 7968
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~01d0360b9f, baseline=1.39.0-SNAPSHOT~4c58087c38

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1050070
Total [baseline] (10.411 s) : 0, 10411210
Agent [candidate] (1.048 s) : 0, 1047544
Total [candidate] (10.318 s) : 0, 10318057
section appsec
Agent [baseline] (1.166 s) : 0, 1165780
Total [baseline] (10.467 s) : 0, 10466976
Agent [candidate] (1.177 s) : 0, 1176577
Total [candidate] (10.505 s) : 0, 10505445
section iast
Agent [baseline] (1.174 s) : 0, 1174238
Total [baseline] (10.807 s) : 0, 10807082
Agent [candidate] (1.174 s) : 0, 1174290
Total [candidate] (10.773 s) : 0, 10772690
section profiling
Agent [baseline] (1.243 s) : 0, 1243008
Total [baseline] (10.595 s) : 0, 10595265
Agent [candidate] (1.241 s) : 0, 1241040
Total [candidate] (10.504 s) : 0, 10503686
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.05 s -
Agent appsec 1.166 s 115.71 ms (11.0%)
Agent iast 1.174 s 124.167 ms (11.8%)
Agent profiling 1.243 s 192.938 ms (18.4%)
Total tracing 10.411 s -
Total appsec 10.467 s 55.766 ms (0.5%)
Total iast 10.807 s 395.872 ms (3.8%)
Total profiling 10.595 s 184.055 ms (1.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.048 s -
Agent appsec 1.177 s 129.033 ms (12.3%)
Agent iast 1.174 s 126.746 ms (12.1%)
Agent profiling 1.241 s 193.496 ms (18.5%)
Total tracing 10.318 s -
Total appsec 10.505 s 187.388 ms (1.8%)
Total iast 10.773 s 454.633 ms (4.4%)
Total profiling 10.504 s 185.629 ms (1.8%) 
gantt
    title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~01d0360b9f, baseline=1.39.0-SNAPSHOT~4c58087c38

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (670.13 ms) : 0, 670130
BytebuddyAgent [candidate] (668.253 ms) : 0, 668253
GlobalTracer [baseline] (307.285 ms) : 0, 307285
GlobalTracer [candidate] (306.619 ms) : 0, 306619
AppSec [baseline] (50.999 ms) : 0, 50999
AppSec [candidate] (51.026 ms) : 0, 51026
Remote Config [baseline] (688.725 µs) : 0, 689
Remote Config [candidate] (692.091 µs) : 0, 692
Telemetry [baseline] (7.5 ms) : 0, 7500
Telemetry [candidate] (7.513 ms) : 0, 7513
section appsec
BytebuddyAgent [baseline] (676.102 ms) : 0, 676102
BytebuddyAgent [candidate] (682.307 ms) : 0, 682307
GlobalTracer [baseline] (299.091 ms) : 0, 299091
GlobalTracer [candidate] (301.459 ms) : 0, 301459
AppSec [baseline] (157.122 ms) : 0, 157122
AppSec [candidate] (158.09 ms) : 0, 158090
IAST [baseline] (20.135 ms) : 0, 20135
IAST [candidate] (21.624 ms) : 0, 21624
Remote Config [baseline] (600.693 µs) : 0, 601
Remote Config [candidate] (612.476 µs) : 0, 612
Telemetry [baseline] (9.35 ms) : 0, 9350
Telemetry [candidate] (9.706 ms) : 0, 9706
section iast
BytebuddyAgent [baseline] (782.397 ms) : 0, 782397
BytebuddyAgent [candidate] (781.177 ms) : 0, 781177
GlobalTracer [baseline] (296.743 ms) : 0, 296743
GlobalTracer [candidate] (296.136 ms) : 0, 296136
AppSec [baseline] (52.313 ms) : 0, 52313
AppSec [candidate] (53.238 ms) : 0, 53238
IAST [baseline] (21.555 ms) : 0, 21555
IAST [candidate] (21.784 ms) : 0, 21784
Remote Config [baseline] (569.643 µs) : 0, 570
Remote Config [candidate] (576.171 µs) : 0, 576
Telemetry [baseline] (7.157 ms) : 0, 7157
Telemetry [candidate] (7.912 ms) : 0, 7912
section profiling
BytebuddyAgent [baseline] (661.094 ms) : 0, 661094
BytebuddyAgent [candidate] (660.758 ms) : 0, 660758
GlobalTracer [baseline] (390.232 ms) : 0, 390232
GlobalTracer [candidate] (389.103 ms) : 0, 389103
AppSec [baseline] (52.049 ms) : 0, 52049
AppSec [candidate] (51.548 ms) : 0, 51548
Remote Config [baseline] (680.094 µs) : 0, 680
Remote Config [candidate] (714.027 µs) : 0, 714
Telemetry [baseline] (7.38 ms) : 0, 7380
Telemetry [candidate] (7.387 ms) : 0, 7387
ProfilingAgent [baseline] (94.502 ms) : 0, 94502
ProfilingAgent [candidate] (94.461 ms) : 0, 94461
Profiling [baseline] (94.528 ms) : 0, 94528
Profiling [candidate] (94.485 ms) : 0, 94485
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-08-14T06:17:30 2024-08-14T06:24:16
git_branch master bbujon/crashtracking
git_commit_date 1723583620 1723615602
git_commit_sha 4c58087 01d0360
release_version 1.39.0-SNAPSHOT~4c58087c38 1.39.0-SNAPSHOT~01d0360b9f
start_time 2024-08-14T06:17:17 2024-08-14T06:24:03
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1723616999 1723616999
ci_job_id 604457698 604457698
ci_pipeline_id 41725774 41725774
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~01d0360b9f, baseline=1.39.0-SNAPSHOT~4c58087c38
    dateFormat X
    axisFormat %s
section baseline
no_agent (366.039 µs) : 347, 385
.   : milestone, 366,
iast (473.681 µs) : 452, 495
.   : milestone, 474,
iast_FULL (552.063 µs) : 530, 574
.   : milestone, 552,
iast_GLOBAL (505.706 µs) : 483, 528
.   : milestone, 506,
iast_HARDCODED_SECRET_DISABLED (475.438 µs) : 454, 497
.   : milestone, 475,
iast_INACTIVE (446.911 µs) : 425, 469
.   : milestone, 447,
iast_TELEMETRY_OFF (472.39 µs) : 451, 494
.   : milestone, 472,
tracing (429.798 µs) : 409, 450
.   : milestone, 430,
section candidate
no_agent (365.239 µs) : 345, 385
.   : milestone, 365,
iast (478.26 µs) : 457, 500
.   : milestone, 478,
iast_FULL (544.713 µs) : 522, 567
.   : milestone, 545,
iast_GLOBAL (501.731 µs) : 479, 524
.   : milestone, 502,
iast_HARDCODED_SECRET_DISABLED (473.554 µs) : 452, 495
.   : milestone, 474,
iast_INACTIVE (443.284 µs) : 421, 465
.   : milestone, 443,
iast_TELEMETRY_OFF (457.862 µs) : 437, 479
.   : milestone, 458,
tracing (434.338 µs) : 414, 455
.   : milestone, 434,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 366.039 µs [346.654 µs, 385.424 µs] -
iast 473.681 µs [452.414 µs, 494.947 µs] 107.641 µs (29.4%)
iast_FULL 552.063 µs [529.818 µs, 574.307 µs] 186.023 µs (50.8%)
iast_GLOBAL 505.706 µs [483.214 µs, 528.197 µs] 139.667 µs (38.2%)
iast_HARDCODED_SECRET_DISABLED 475.438 µs [454.005 µs, 496.871 µs] 109.399 µs (29.9%)
iast_INACTIVE 446.911 µs [424.725 µs, 469.096 µs] 80.871 µs (22.1%)
iast_TELEMETRY_OFF 472.39 µs [450.889 µs, 493.892 µs] 106.351 µs (29.1%)
tracing 429.798 µs [409.456 µs, 450.139 µs] 63.759 µs (17.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 365.239 µs [345.086 µs, 385.391 µs] -
iast 478.26 µs [456.942 µs, 499.579 µs] 113.021 µs (30.9%)
iast_FULL 544.713 µs [522.372 µs, 567.054 µs] 179.475 µs (49.1%)
iast_GLOBAL 501.731 µs [479.175 µs, 524.287 µs] 136.492 µs (37.4%)
iast_HARDCODED_SECRET_DISABLED 473.554 µs [452.469 µs, 494.64 µs] 108.316 µs (29.7%)
iast_INACTIVE 443.284 µs [421.162 µs, 465.405 µs] 78.045 µs (21.4%)
iast_TELEMETRY_OFF 457.862 µs [437.106 µs, 478.619 µs] 92.623 µs (25.4%)
tracing 434.338 µs [413.537 µs, 455.139 µs] 69.1 µs (18.9%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~01d0360b9f, baseline=1.39.0-SNAPSHOT~4c58087c38
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.331 ms) : 1311, 1350
.   : milestone, 1331,
appsec (1.726 ms) : 1703, 1749
.   : milestone, 1726,
appsec_no_iast (1.729 ms) : 1705, 1753
.   : milestone, 1729,
iast (1.473 ms) : 1450, 1495
.   : milestone, 1473,
profiling (1.483 ms) : 1458, 1508
.   : milestone, 1483,
tracing (1.443 ms) : 1418, 1467
.   : milestone, 1443,
section candidate
no_agent (1.335 ms) : 1315, 1354
.   : milestone, 1335,
appsec (1.729 ms) : 1705, 1754
.   : milestone, 1729,
appsec_no_iast (1.715 ms) : 1690, 1740
.   : milestone, 1715,
iast (1.477 ms) : 1455, 1499
.   : milestone, 1477,
profiling (1.502 ms) : 1477, 1527
.   : milestone, 1502,
tracing (1.453 ms) : 1429, 1477
.   : milestone, 1453,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.331 ms [1.311 ms, 1.35 ms] -
appsec 1.726 ms [1.703 ms, 1.749 ms] 395.35 µs (29.7%)
appsec_no_iast 1.729 ms [1.705 ms, 1.753 ms] 398.609 µs (30.0%)
iast 1.473 ms [1.45 ms, 1.495 ms] 142.153 µs (10.7%)
profiling 1.483 ms [1.458 ms, 1.508 ms] 152.225 µs (11.4%)
tracing 1.443 ms [1.418 ms, 1.467 ms] 111.96 µs (8.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.335 ms [1.315 ms, 1.354 ms] -
appsec 1.729 ms [1.705 ms, 1.754 ms] 394.452 µs (29.5%)
appsec_no_iast 1.715 ms [1.69 ms, 1.74 ms] 380.266 µs (28.5%)
iast 1.477 ms [1.455 ms, 1.499 ms] 141.853 µs (10.6%)
profiling 1.502 ms [1.477 ms, 1.527 ms] 167.241 µs (12.5%)
tracing 1.453 ms [1.429 ms, 1.477 ms] 118.358 µs (8.9%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/crashtracking
git_commit_date 1723583620 1723615602
git_commit_sha 4c58087 01d0360
release_version 1.39.0-SNAPSHOT~4c58087c38 1.39.0-SNAPSHOT~01d0360b9f
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1723617646 1723617646
ci_job_id 604457699 604457699
ci_pipeline_id 41725774 41725774
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~01d0360b9f, baseline=1.39.0-SNAPSHOT~4c58087c38
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.462 ms) : 1450, 1473
.   : milestone, 1462,
appsec (2.21 ms) : 2176, 2244
.   : milestone, 2210,
iast (1.959 ms) : 1917, 2001
.   : milestone, 1959,
iast_GLOBAL (2.001 ms) : 1958, 2043
.   : milestone, 2001,
profiling (2.315 ms) : 2142, 2489
.   : milestone, 2315,
tracing (1.836 ms) : 1803, 1868
.   : milestone, 1836,
section candidate
no_agent (1.458 ms) : 1447, 1470
.   : milestone, 1458,
appsec (2.217 ms) : 2182, 2251
.   : milestone, 2217,
iast (1.951 ms) : 1910, 1993
.   : milestone, 1951,
iast_GLOBAL (2.007 ms) : 1965, 2048
.   : milestone, 2007,
profiling (1.86 ms) : 1824, 1895
.   : milestone, 1860,
tracing (1.83 ms) : 1798, 1863
.   : milestone, 1830,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.462 ms [1.45 ms, 1.473 ms] -
appsec 2.21 ms [2.176 ms, 2.244 ms] 748.412 µs (51.2%)
iast 1.959 ms [1.917 ms, 2.001 ms] 497.179 µs (34.0%)
iast_GLOBAL 2.001 ms [1.958 ms, 2.043 ms] 539.169 µs (36.9%)
profiling 2.315 ms [2.142 ms, 2.489 ms] 853.754 µs (58.4%)
tracing 1.836 ms [1.803 ms, 1.868 ms] 373.803 µs (25.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.458 ms [1.447 ms, 1.47 ms] -
appsec 2.217 ms [2.182 ms, 2.251 ms] 758.446 µs (52.0%)
iast 1.951 ms [1.91 ms, 1.993 ms] 492.968 µs (33.8%)
iast_GLOBAL 2.007 ms [1.965 ms, 2.048 ms] 548.155 µs (37.6%)
profiling 1.86 ms [1.824 ms, 1.895 ms] 401.232 µs (27.5%)
tracing 1.83 ms [1.798 ms, 1.863 ms] 371.991 µs (25.5%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~01d0360b9f, baseline=1.39.0-SNAPSHOT~4c58087c38
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.117 s) : 15117000, 15117000
.   : milestone, 15117000,
appsec (15.275 s) : 15275000, 15275000
.   : milestone, 15275000,
iast (18.936 s) : 18936000, 18936000
.   : milestone, 18936000,
iast_GLOBAL (17.696 s) : 17696000, 17696000
.   : milestone, 17696000,
profiling (15.842 s) : 15842000, 15842000
.   : milestone, 15842000,
tracing (14.97 s) : 14970000, 14970000
.   : milestone, 14970000,
section candidate
no_agent (15.397 s) : 15397000, 15397000
.   : milestone, 15397000,
appsec (14.862 s) : 14862000, 14862000
.   : milestone, 14862000,
iast (18.56 s) : 18560000, 18560000
.   : milestone, 18560000,
iast_GLOBAL (18.173 s) : 18173000, 18173000
.   : milestone, 18173000,
profiling (15.077 s) : 15077000, 15077000
.   : milestone, 15077000,
tracing (15.2 s) : 15200000, 15200000
.   : milestone, 15200000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.117 s [15.117 s, 15.117 s] -
appsec 15.275 s [15.275 s, 15.275 s] 158.0 ms (1.0%)
iast 18.936 s [18.936 s, 18.936 s] 3.819 s (25.3%)
iast_GLOBAL 17.696 s [17.696 s, 17.696 s] 2.579 s (17.1%)
profiling 15.842 s [15.842 s, 15.842 s] 725.0 ms (4.8%)
tracing 14.97 s [14.97 s, 14.97 s] -147.0 ms (-1.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.397 s [15.397 s, 15.397 s] -
appsec 14.862 s [14.862 s, 14.862 s] -535.0 ms (-3.5%)
iast 18.56 s [18.56 s, 18.56 s] 3.163 s (20.5%)
iast_GLOBAL 18.173 s [18.173 s, 18.173 s] 2.776 s (18.0%)
profiling 15.077 s [15.077 s, 15.077 s] -320.0 ms (-2.1%)
tracing 15.2 s [15.2 s, 15.2 s] -197.0 ms (-1.3%)

dougqh
dougqh reviewed Aug 26, 2024
View reviewed changes
Comment thread ...nt-crashtracking/src/main/java/com/datadog/crashtracking/CrashUploaderScriptInitializer.java

Path scriptPath = Paths.get(onErrorVal.replace(" %p", ""));
boolean isDDCrashUploader =
scriptPath.getFileName().toString().toLowerCase(ROOT).contains("dd_crash_uploader");
Copy link
Copy Markdown
Contributor

@dougqh dougqh Aug 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this check acts as a check that it was set by us? Nice

@PerfectSlayer PerfectSlayer merged commit 2b7a97c into master Aug 27, 2024
@PerfectSlayer PerfectSlayer deleted the bbujon/crashtracking branch August 27, 2024 06:08
@github-actions github-actions Bot added this to the 1.39.0 milestone Aug 27, 2024
@jbachorik jbachorik mentioned this pull request Aug 27, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dougqh dougqh dougqh approved these changes

Assignees

No one assigned

Labels

comp: crash tracking Crash Tracking type: refactoring

Projects

None yet

Milestone

1.39.0

Development

Successfully merging this pull request may close these issues.

2 participants

@PerfectSlayer @dougqh