Skip to content

Add support for enum value comparison#7418

Merged
jpbempel merged 1 commit intomasterfrom
jpbempel/fix-enum-el
Aug 29, 2024
Merged

Add support for enum value comparison#7418
jpbempel merged 1 commit intomasterfrom
jpbempel/fix-enum-el

Conversation

@jpbempel
Copy link
Copy Markdown
Member

@jpbempel jpbempel commented Aug 13, 2024 •
edited by atlassian Bot
Loading

What Does This Do

enum value is expressed as string with either fully qualified name, simple name with enum class of just the enum value.

Motivation

Add support for enum values

Additional Notes

Contributor Checklist

Jira ticket: DEBUG-2455

@jpbempel
Add support for enum value comparison
35b0726 
enum value is expressed as string with either fully qualified name,
simple name with enum class of just the enum value.
@jpbempel jpbempel requested a review from a team as a code owner August 13, 2024 09:30
@jpbempel jpbempel requested review from ojung and removed request for a team August 13, 2024 09:30
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Aug 13, 2024

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1723541056 1723541462
end_time 2024-08-13T09:25:45 2024-08-13T09:32:31
git_branch master jpbempel/fix-enum-el
git_commit_sha 594de2e 35b0726
start_time 2024-08-13T09:24:18 2024-08-13T09:31:04
See matching parameters
Baseline Candidate
ci_job_id 602960188 602960188
ci_pipeline_id 41568651 41568651
cpu_model Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
git_commit_date 1723540455 1723540455

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 5 unstable metrics.

See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-29.753µs; +24.819µs] or [-9.756%; +8.138%]		 unstable
[-46.431µs; +42.599µs] or [-13.401%; +12.295%]		 unstable
[-63.178µs; +58.628µs] or [-17.365%; +16.114%]		 unstable
[-148.451µs; +132.607µs] or [-14.891%; +13.302%]		 same
scenario:basic same same same unstable
[-51.006µs; +71.610µs] or [-5.224%; +7.335%]		 same
scenario:loop unsure
[-120.903µs; -85.077µs] or [-1.111%; -0.782%]		 unsure
[-173.412µs; -30.240µs] or [-1.549%; -0.270%]		 same same same
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (346.472 µs) : 302, 390
.   : milestone, 346,
basic (345.561 µs) : 335, 356
.   : milestone, 346,
loop (11.198 ms) : 11131, 11264
.   : milestone, 11198,
section candidate
noprobe (344.556 µs) : 304, 385
.   : milestone, 345,
basic (344.112 µs) : 333, 355
.   : milestone, 344,
loop (11.096 ms) : 11029, 11163
.   : milestone, 11096,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 346.472 µs [302.446 µs, 390.498 µs]
basic 345.561 µs [334.848 µs, 356.273 µs]
loop 11.198 ms [11.131 ms, 11.264 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 344.556 µs [304.067 µs, 385.045 µs]
basic 344.112 µs [333.381 µs, 354.843 µs]
loop 11.096 ms [11.029 ms, 11.163 ms]

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Aug 13, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/fix-enum-el
git_commit_date 1723512885 1723540455
git_commit_sha 594de2e 35b0726
release_version 1.39.0-SNAPSHOT~594de2e160 1.39.0-SNAPSHOT~35b0726dd1
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1723542819 1723542819
ci_job_id 602960179 602960179
ci_pipeline_id 41568651 41568651
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 16 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~35b0726dd1, baseline=1.39.0-SNAPSHOT~594de2e160

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1046286
Total [baseline] (8.48 s) : 0, 8480165
Agent [candidate] (1.049 s) : 0, 1048887
Total [candidate] (8.531 s) : 0, 8530910
section iast
Agent [baseline] (1.176 s) : 0, 1175925
Total [baseline] (9.017 s) : 0, 9016519
Agent [candidate] (1.176 s) : 0, 1176400
Total [candidate] (9.012 s) : 0, 9011986
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.176 s) : 0, 1176090
Total [baseline] (8.969 s) : 0, 8969162
Agent [candidate] (1.185 s) : 0, 1185466
Total [candidate] (8.992 s) : 0, 8991639
section iast_TELEMETRY_OFF
Agent [baseline] (1.187 s) : 0, 1186787
Total [baseline] (9.002 s) : 0, 9002084
Agent [candidate] (1.172 s) : 0, 1171691
Total [candidate] (9.025 s) : 0, 9025076
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.046 s -
Agent iast 1.176 s 129.639 ms (12.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.176 s 129.804 ms (12.4%)
Agent iast_TELEMETRY_OFF 1.187 s 140.502 ms (13.4%)
Total tracing 8.48 s -
Total iast 9.017 s 536.354 ms (6.3%)
Total iast_HARDCODED_SECRET_DISABLED 8.969 s 488.997 ms (5.8%)
Total iast_TELEMETRY_OFF 9.002 s 521.919 ms (6.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.049 s -
Agent iast 1.176 s 127.513 ms (12.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.185 s 136.579 ms (13.0%)
Agent iast_TELEMETRY_OFF 1.172 s 122.804 ms (11.7%)
Total tracing 8.531 s -
Total iast 9.012 s 481.075 ms (5.6%)
Total iast_HARDCODED_SECRET_DISABLED 8.992 s 460.728 ms (5.4%)
Total iast_TELEMETRY_OFF 9.025 s 494.166 ms (5.8%) 
gantt
    title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~35b0726dd1, baseline=1.39.0-SNAPSHOT~594de2e160

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (667.439 ms) : 0, 667439
BytebuddyAgent [candidate] (668.774 ms) : 0, 668774
GlobalTracer [baseline] (306.166 ms) : 0, 306166
GlobalTracer [candidate] (307.322 ms) : 0, 307322
AppSec [baseline] (51.006 ms) : 0, 51006
AppSec [candidate] (51.121 ms) : 0, 51121
Remote Config [baseline] (678.535 µs) : 0, 679
Remote Config [candidate] (682.645 µs) : 0, 683
Telemetry [baseline] (7.587 ms) : 0, 7587
Telemetry [candidate] (7.505 ms) : 0, 7505
section iast
BytebuddyAgent [baseline] (781.867 ms) : 0, 781867
BytebuddyAgent [candidate] (781.986 ms) : 0, 781986
GlobalTracer [baseline] (296.029 ms) : 0, 296029
GlobalTracer [candidate] (296.604 ms) : 0, 296604
AppSec [baseline] (51.871 ms) : 0, 51871
AppSec [candidate] (52.501 ms) : 0, 52501
Remote Config [baseline] (580.624 µs) : 0, 581
Remote Config [candidate] (589.955 µs) : 0, 590
Telemetry [baseline] (8.692 ms) : 0, 8692
Telemetry [candidate] (7.173 ms) : 0, 7173
IAST [baseline] (23.429 ms) : 0, 23429
IAST [candidate] (24.045 ms) : 0, 24045
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (781.836 ms) : 0, 781836
BytebuddyAgent [candidate] (787.789 ms) : 0, 787789
GlobalTracer [baseline] (296.919 ms) : 0, 296919
GlobalTracer [candidate] (298.89 ms) : 0, 298890
AppSec [baseline] (49.292 ms) : 0, 49292
AppSec [candidate] (52.341 ms) : 0, 52341
Remote Config [baseline] (571.087 µs) : 0, 571
Remote Config [candidate] (583.471 µs) : 0, 583
Telemetry [baseline] (8.792 ms) : 0, 8792
Telemetry [candidate] (8.037 ms) : 0, 8037
IAST [baseline] (25.135 ms) : 0, 25135
IAST [candidate] (24.186 ms) : 0, 24186
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (789.482 ms) : 0, 789482
BytebuddyAgent [candidate] (779.427 ms) : 0, 779427
GlobalTracer [baseline] (299.578 ms) : 0, 299578
GlobalTracer [candidate] (296.925 ms) : 0, 296925
AppSec [baseline] (49.293 ms) : 0, 49293
AppSec [candidate] (49.319 ms) : 0, 49319
Remote Config [baseline] (610.22 µs) : 0, 610
Remote Config [candidate] (630.476 µs) : 0, 630
Telemetry [baseline] (9.466 ms) : 0, 9466
Telemetry [candidate] (7.949 ms) : 0, 7949
IAST [baseline] (24.707 ms) : 0, 24707
IAST [candidate] (23.933 ms) : 0, 23933
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~35b0726dd1, baseline=1.39.0-SNAPSHOT~594de2e160

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1054556
Total [baseline] (10.262 s) : 0, 10262200
Agent [candidate] (1.048 s) : 0, 1047547
Total [candidate] (10.306 s) : 0, 10305620
section appsec
Agent [baseline] (1.176 s) : 0, 1176264
Total [baseline] (10.533 s) : 0, 10532809
Agent [candidate] (1.171 s) : 0, 1170946
Total [candidate] (10.533 s) : 0, 10532727
section iast
Agent [baseline] (1.179 s) : 0, 1179311
Total [baseline] (10.773 s) : 0, 10773102
Agent [candidate] (1.177 s) : 0, 1176983
Total [candidate] (10.736 s) : 0, 10736410
section profiling
Agent [baseline] (1.253 s) : 0, 1253310
Total [baseline] (10.653 s) : 0, 10653274
Agent [candidate] (1.244 s) : 0, 1244432
Total [candidate] (10.57 s) : 0, 10570271
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.055 s -
Agent appsec 1.176 s 121.708 ms (11.5%)
Agent iast 1.179 s 124.755 ms (11.8%)
Agent profiling 1.253 s 198.754 ms (18.8%)
Total tracing 10.262 s -
Total appsec 10.533 s 270.609 ms (2.6%)
Total iast 10.773 s 510.902 ms (5.0%)
Total profiling 10.653 s 391.074 ms (3.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.048 s -
Agent appsec 1.171 s 123.399 ms (11.8%)
Agent iast 1.177 s 129.437 ms (12.4%)
Agent profiling 1.244 s 196.885 ms (18.8%)
Total tracing 10.306 s -
Total appsec 10.533 s 227.108 ms (2.2%)
Total iast 10.736 s 430.79 ms (4.2%)
Total profiling 10.57 s 264.651 ms (2.6%) 
gantt
    title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~35b0726dd1, baseline=1.39.0-SNAPSHOT~594de2e160

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (673.031 ms) : 0, 673031
BytebuddyAgent [candidate] (667.895 ms) : 0, 667895
GlobalTracer [baseline] (308.68 ms) : 0, 308680
GlobalTracer [candidate] (306.958 ms) : 0, 306958
AppSec [baseline] (51.102 ms) : 0, 51102
AppSec [candidate] (51.073 ms) : 0, 51073
Remote Config [baseline] (692.958 µs) : 0, 693
Remote Config [candidate] (681.019 µs) : 0, 681
Telemetry [baseline] (7.517 ms) : 0, 7517
Telemetry [candidate] (7.501 ms) : 0, 7501
section appsec
BytebuddyAgent [baseline] (682.785 ms) : 0, 682785
BytebuddyAgent [candidate] (680.48 ms) : 0, 680480
GlobalTracer [baseline] (302.507 ms) : 0, 302507
GlobalTracer [candidate] (301.234 ms) : 0, 301234
AppSec [baseline] (157.429 ms) : 0, 157429
AppSec [candidate] (156.748 ms) : 0, 156748
Remote Config [baseline] (606.849 µs) : 0, 607
Remote Config [candidate] (608.006 µs) : 0, 608
Telemetry [baseline] (8.819 ms) : 0, 8819
Telemetry [candidate] (8.121 ms) : 0, 8121
IAST [baseline] (21.061 ms) : 0, 21061
IAST [candidate] (20.428 ms) : 0, 20428
section iast
BytebuddyAgent [baseline] (782.683 ms) : 0, 782683
BytebuddyAgent [candidate] (783.273 ms) : 0, 783273
GlobalTracer [baseline] (298.241 ms) : 0, 298241
GlobalTracer [candidate] (296.839 ms) : 0, 296839
AppSec [baseline] (54.525 ms) : 0, 54525
AppSec [candidate] (52.483 ms) : 0, 52483
Remote Config [baseline] (575.376 µs) : 0, 575
Remote Config [candidate] (578.27 µs) : 0, 578
Telemetry [baseline] (7.155 ms) : 0, 7155
Telemetry [candidate] (8.709 ms) : 0, 8709
IAST [baseline] (22.628 ms) : 0, 22628
IAST [candidate] (21.596 ms) : 0, 21596
section profiling
BytebuddyAgent [baseline] (667.801 ms) : 0, 667801
BytebuddyAgent [candidate] (662.627 ms) : 0, 662627
GlobalTracer [baseline] (391.818 ms) : 0, 391818
GlobalTracer [candidate] (390.215 ms) : 0, 390215
AppSec [baseline] (52.639 ms) : 0, 52639
AppSec [candidate] (51.933 ms) : 0, 51933
Remote Config [baseline] (699.336 µs) : 0, 699
Remote Config [candidate] (692.849 µs) : 0, 693
Telemetry [baseline] (7.449 ms) : 0, 7449
Telemetry [candidate] (7.368 ms) : 0, 7368
ProfilingAgent [baseline] (95.418 ms) : 0, 95418
ProfilingAgent [candidate] (94.418 ms) : 0, 94418
Profiling [baseline] (95.443 ms) : 0, 95443
Profiling [candidate] (94.443 ms) : 0, 94443
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-08-13T09:24:24 2024-08-13T09:31:16
git_branch master jpbempel/fix-enum-el
git_commit_date 1723512885 1723540455
git_commit_sha 594de2e 35b0726
release_version 1.39.0-SNAPSHOT~594de2e160 1.39.0-SNAPSHOT~35b0726dd1
start_time 2024-08-13T09:24:11 2024-08-13T09:31:03
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1723541822 1723541822
ci_job_id 602960180 602960180
ci_pipeline_id 41568651 41568651
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 18 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~35b0726dd1, baseline=1.39.0-SNAPSHOT~594de2e160
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.359 ms) : 1340, 1378
.   : milestone, 1359,
appsec (1.703 ms) : 1678, 1727
.   : milestone, 1703,
appsec_no_iast (1.733 ms) : 1709, 1757
.   : milestone, 1733,
iast (1.489 ms) : 1467, 1512
.   : milestone, 1489,
profiling (1.529 ms) : 1503, 1554
.   : milestone, 1529,
tracing (1.457 ms) : 1432, 1482
.   : milestone, 1457,
section candidate
no_agent (1.346 ms) : 1327, 1365
.   : milestone, 1346,
appsec (1.718 ms) : 1692, 1743
.   : milestone, 1718,
appsec_no_iast (1.694 ms) : 1669, 1719
.   : milestone, 1694,
iast (1.487 ms) : 1464, 1509
.   : milestone, 1487,
profiling (1.533 ms) : 1506, 1559
.   : milestone, 1533,
tracing (1.461 ms) : 1436, 1486
.   : milestone, 1461,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.359 ms [1.34 ms, 1.378 ms] -
appsec 1.703 ms [1.678 ms, 1.727 ms] 343.686 µs (25.3%)
appsec_no_iast 1.733 ms [1.709 ms, 1.757 ms] 373.931 µs (27.5%)
iast 1.489 ms [1.467 ms, 1.512 ms] 130.325 µs (9.6%)
profiling 1.529 ms [1.503 ms, 1.554 ms] 169.779 µs (12.5%)
tracing 1.457 ms [1.432 ms, 1.482 ms] 98.247 µs (7.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.346 ms [1.327 ms, 1.365 ms] -
appsec 1.718 ms [1.692 ms, 1.743 ms] 371.991 µs (27.6%)
appsec_no_iast 1.694 ms [1.669 ms, 1.719 ms] 348.469 µs (25.9%)
iast 1.487 ms [1.464 ms, 1.509 ms] 141.09 µs (10.5%)
profiling 1.533 ms [1.506 ms, 1.559 ms] 186.9 µs (13.9%)
tracing 1.461 ms [1.436 ms, 1.486 ms] 115.151 µs (8.6%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~35b0726dd1, baseline=1.39.0-SNAPSHOT~594de2e160
    dateFormat X
    axisFormat %s
section baseline
no_agent (374.837 µs) : 355, 395
.   : milestone, 375,
iast (481.782 µs) : 461, 503
.   : milestone, 482,
iast_FULL (555.047 µs) : 533, 578
.   : milestone, 555,
iast_GLOBAL (516.561 µs) : 493, 540
.   : milestone, 517,
iast_HARDCODED_SECRET_DISABLED (480.506 µs) : 459, 502
.   : milestone, 481,
iast_INACTIVE (455.74 µs) : 434, 478
.   : milestone, 456,
iast_TELEMETRY_OFF (478.925 µs) : 457, 501
.   : milestone, 479,
tracing (446.037 µs) : 425, 467
.   : milestone, 446,
section candidate
no_agent (367.33 µs) : 347, 387
.   : milestone, 367,
iast (478.392 µs) : 457, 500
.   : milestone, 478,
iast_FULL (549.557 µs) : 527, 572
.   : milestone, 550,
iast_GLOBAL (517.635 µs) : 493, 542
.   : milestone, 518,
iast_HARDCODED_SECRET_DISABLED (482.499 µs) : 461, 504
.   : milestone, 482,
iast_INACTIVE (455.68 µs) : 433, 478
.   : milestone, 456,
iast_TELEMETRY_OFF (472.369 µs) : 451, 493
.   : milestone, 472,
tracing (448.635 µs) : 428, 469
.   : milestone, 449,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 374.837 µs [354.7 µs, 394.975 µs] -
iast 481.782 µs [460.598 µs, 502.966 µs] 106.944 µs (28.5%)
iast_FULL 555.047 µs [532.509 µs, 577.584 µs] 180.209 µs (48.1%)
iast_GLOBAL 516.561 µs [493.366 µs, 539.756 µs] 141.723 µs (37.8%)
iast_HARDCODED_SECRET_DISABLED 480.506 µs [459.466 µs, 501.546 µs] 105.668 µs (28.2%)
iast_INACTIVE 455.74 µs [433.589 µs, 477.891 µs] 80.903 µs (21.6%)
iast_TELEMETRY_OFF 478.925 µs [456.738 µs, 501.112 µs] 104.087 µs (27.8%)
tracing 446.037 µs [424.769 µs, 467.306 µs] 71.2 µs (19.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 367.33 µs [347.275 µs, 387.384 µs] -
iast 478.392 µs [457.141 µs, 499.643 µs] 111.062 µs (30.2%)
iast_FULL 549.557 µs [527.218 µs, 571.896 µs] 182.227 µs (49.6%)
iast_GLOBAL 517.635 µs [492.795 µs, 542.474 µs] 150.305 µs (40.9%)
iast_HARDCODED_SECRET_DISABLED 482.499 µs [460.938 µs, 504.059 µs] 115.169 µs (31.4%)
iast_INACTIVE 455.68 µs [433.254 µs, 478.106 µs] 88.35 µs (24.1%)
iast_TELEMETRY_OFF 472.369 µs [451.422 µs, 493.315 µs] 105.039 µs (28.6%)
tracing 448.635 µs [428.294 µs, 468.976 µs] 81.305 µs (22.1%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/fix-enum-el
git_commit_date 1723512885 1723540455
git_commit_sha 594de2e 35b0726
release_version 1.39.0-SNAPSHOT~594de2e160 1.39.0-SNAPSHOT~35b0726dd1
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1723542319 1723542319
ci_job_id 602960181 602960181
ci_pipeline_id 41568651 41568651
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~35b0726dd1, baseline=1.39.0-SNAPSHOT~594de2e160
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.13 s) : 15130000, 15130000
.   : milestone, 15130000,
appsec (15.039 s) : 15039000, 15039000
.   : milestone, 15039000,
iast (18.594 s) : 18594000, 18594000
.   : milestone, 18594000,
iast_GLOBAL (17.779 s) : 17779000, 17779000
.   : milestone, 17779000,
profiling (15.198 s) : 15198000, 15198000
.   : milestone, 15198000,
tracing (15.203 s) : 15203000, 15203000
.   : milestone, 15203000,
section candidate
no_agent (15.131 s) : 15131000, 15131000
.   : milestone, 15131000,
appsec (15.003 s) : 15003000, 15003000
.   : milestone, 15003000,
iast (18.746 s) : 18746000, 18746000
.   : milestone, 18746000,
iast_GLOBAL (18.067 s) : 18067000, 18067000
.   : milestone, 18067000,
profiling (15.827 s) : 15827000, 15827000
.   : milestone, 15827000,
tracing (14.926 s) : 14926000, 14926000
.   : milestone, 14926000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.13 s [15.13 s, 15.13 s] -
appsec 15.039 s [15.039 s, 15.039 s] -91.0 ms (-0.6%)
iast 18.594 s [18.594 s, 18.594 s] 3.464 s (22.9%)
iast_GLOBAL 17.779 s [17.779 s, 17.779 s] 2.649 s (17.5%)
profiling 15.198 s [15.198 s, 15.198 s] 68.0 ms (0.4%)
tracing 15.203 s [15.203 s, 15.203 s] 73.0 ms (0.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.131 s [15.131 s, 15.131 s] -
appsec 15.003 s [15.003 s, 15.003 s] -128.0 ms (-0.8%)
iast 18.746 s [18.746 s, 18.746 s] 3.615 s (23.9%)
iast_GLOBAL 18.067 s [18.067 s, 18.067 s] 2.936 s (19.4%)
profiling 15.827 s [15.827 s, 15.827 s] 696.0 ms (4.6%)
tracing 14.926 s [14.926 s, 14.926 s] -205.0 ms (-1.4%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~35b0726dd1, baseline=1.39.0-SNAPSHOT~594de2e160
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.459 ms) : 1448, 1471
.   : milestone, 1459,
appsec (2.225 ms) : 2189, 2260
.   : milestone, 2225,
iast (1.972 ms) : 1929, 2014
.   : milestone, 1972,
iast_GLOBAL (2.022 ms) : 1980, 2064
.   : milestone, 2022,
profiling (1.859 ms) : 1825, 1892
.   : milestone, 1859,
tracing (1.84 ms) : 1807, 1874
.   : milestone, 1840,
section candidate
no_agent (1.465 ms) : 1454, 1477
.   : milestone, 1465,
appsec (2.216 ms) : 2181, 2251
.   : milestone, 2216,
iast (1.965 ms) : 1924, 2007
.   : milestone, 1965,
iast_GLOBAL (2.02 ms) : 1977, 2063
.   : milestone, 2020,
profiling (1.87 ms) : 1836, 1904
.   : milestone, 1870,
tracing (1.845 ms) : 1811, 1878
.   : milestone, 1845,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.459 ms [1.448 ms, 1.471 ms] -
appsec 2.225 ms [2.189 ms, 2.26 ms] 765.255 µs (52.4%)
iast 1.972 ms [1.929 ms, 2.014 ms] 512.352 µs (35.1%)
iast_GLOBAL 2.022 ms [1.98 ms, 2.064 ms] 562.669 µs (38.6%)
profiling 1.859 ms [1.825 ms, 1.892 ms] 399.147 µs (27.4%)
tracing 1.84 ms [1.807 ms, 1.874 ms] 381.118 µs (26.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.465 ms [1.454 ms, 1.477 ms] -
appsec 2.216 ms [2.181 ms, 2.251 ms] 750.389 µs (51.2%)
iast 1.965 ms [1.924 ms, 2.007 ms] 499.764 µs (34.1%)
iast_GLOBAL 2.02 ms [1.977 ms, 2.063 ms] 554.182 µs (37.8%)
profiling 1.87 ms [1.836 ms, 1.904 ms] 404.578 µs (27.6%)
tracing 1.845 ms [1.811 ms, 1.878 ms] 379.101 µs (25.9%)

@jpbempel jpbempel added type: enhancement Enhancements and improvements comp: debugger Dynamic Instrumentation labels Aug 13, 2024
@jpbempel jpbempel merged commit f3954c9 into master Aug 29, 2024
@jpbempel jpbempel deleted the jpbempel/fix-enum-el branch August 29, 2024 15:13
@github-actions github-actions Bot added this to the 1.39.0 milestone Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evanchooly evanchooly evanchooly approved these changes

@ojung ojung Awaiting requested review from ojung ojung is a code owner automatically assigned from DataDog/debugger-java

Assignees

No one assigned

Labels

comp: debugger Dynamic Instrumentation type: enhancement Enhancements and improvements

Projects

None yet

Milestone

1.39.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jpbempel @evanchooly