Skip to content

Bump byte-buddy to 1.14.18#7415

Merged
mcculls merged 1 commit intomasterfrom
mcculls/byte-buddy-1.14.18
Aug 13, 2024
Merged

Bump byte-buddy to 1.14.18#7415
mcculls merged 1 commit intomasterfrom
mcculls/byte-buddy-1.14.18

Conversation

@mcculls
Copy link
Copy Markdown
Contributor

@mcculls mcculls commented Aug 12, 2024

Motivation

Fixes of interest to us:

  • Avoid verification error if constructor advice meets dropped implicit this frame and throw exception during instrumentation instead.
  • Make sure CircularityLock implementations never load classes during locking.
  • Avoid locking entire class loader when child-first class loader loads shadowed class and parallel class loading is supported.

https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.14.18

@mcculls mcculls added the tag: dependencies Dependencies related changes label Aug 12, 2024
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Aug 12, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/byte-buddy-1.14.18
git_commit_date 1723457525 1723499739
git_commit_sha 93ecbc6 9dea864
release_version 1.39.0-SNAPSHOT~93ecbc62b2 1.39.0-SNAPSHOT~9dea864e70
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1723502344 1723502344
ci_job_id 602659589 602659589
ci_pipeline_id 41545897 41545897
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 18 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~9dea864e70, baseline=1.39.0-SNAPSHOT~93ecbc62b2

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1052225
Total [baseline] (10.441 s) : 0, 10441153
Agent [candidate] (1.046 s) : 0, 1046141
Total [candidate] (10.288 s) : 0, 10287882
section appsec
Agent [baseline] (1.174 s) : 0, 1173950
Total [baseline] (10.496 s) : 0, 10495940
Agent [candidate] (1.167 s) : 0, 1167346
Total [candidate] (10.504 s) : 0, 10504403
section iast
Agent [baseline] (1.176 s) : 0, 1175894
Total [baseline] (10.808 s) : 0, 10808277
Agent [candidate] (1.17 s) : 0, 1170134
Total [candidate] (10.721 s) : 0, 10720599
section profiling
Agent [baseline] (1.244 s) : 0, 1243601
Total [baseline] (10.57 s) : 0, 10569702
Agent [candidate] (1.254 s) : 0, 1254205
Total [candidate] (10.577 s) : 0, 10577092
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.052 s -
Agent appsec 1.174 s 121.725 ms (11.6%)
Agent iast 1.176 s 123.669 ms (11.8%)
Agent profiling 1.244 s 191.375 ms (18.2%)
Total tracing 10.441 s -
Total appsec 10.496 s 54.786 ms (0.5%)
Total iast 10.808 s 367.123 ms (3.5%)
Total profiling 10.57 s 128.548 ms (1.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.046 s -
Agent appsec 1.167 s 121.205 ms (11.6%)
Agent iast 1.17 s 123.993 ms (11.9%)
Agent profiling 1.254 s 208.064 ms (19.9%)
Total tracing 10.288 s -
Total appsec 10.504 s 216.521 ms (2.1%)
Total iast 10.721 s 432.718 ms (4.2%)
Total profiling 10.577 s 289.21 ms (2.8%) 
gantt
    title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~9dea864e70, baseline=1.39.0-SNAPSHOT~93ecbc62b2

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (671.388 ms) : 0, 671388
BytebuddyAgent [candidate] (667.091 ms) : 0, 667091
GlobalTracer [baseline] (307.792 ms) : 0, 307792
GlobalTracer [candidate] (305.987 ms) : 0, 305987
AppSec [baseline] (51.399 ms) : 0, 51399
AppSec [candidate] (51.511 ms) : 0, 51511
Remote Config [baseline] (691.492 µs) : 0, 691
Remote Config [candidate] (686.032 µs) : 0, 686
Telemetry [baseline] (7.489 ms) : 0, 7489
Telemetry [candidate] (7.434 ms) : 0, 7434
section appsec
BytebuddyAgent [baseline] (681.259 ms) : 0, 681259
BytebuddyAgent [candidate] (678.142 ms) : 0, 678142
GlobalTracer [baseline] (301.431 ms) : 0, 301431
GlobalTracer [candidate] (300.192 ms) : 0, 300192
AppSec [baseline] (156.851 ms) : 0, 156851
AppSec [candidate] (156.361 ms) : 0, 156361
Remote Config [baseline] (599.905 µs) : 0, 600
Remote Config [candidate] (608.386 µs) : 0, 608
Telemetry [baseline] (8.944 ms) : 0, 8944
Telemetry [candidate] (8.751 ms) : 0, 8751
IAST [baseline] (22.672 ms) : 0, 22672
IAST [candidate] (19.597 ms) : 0, 19597
section iast
BytebuddyAgent [baseline] (781.695 ms) : 0, 781695
BytebuddyAgent [candidate] (779.709 ms) : 0, 779709
GlobalTracer [baseline] (296.102 ms) : 0, 296102
GlobalTracer [candidate] (294.698 ms) : 0, 294698
AppSec [baseline] (51.039 ms) : 0, 51039
AppSec [candidate] (52.168 ms) : 0, 52168
Remote Config [baseline] (581.158 µs) : 0, 581
Remote Config [candidate] (588.856 µs) : 0, 589
Telemetry [baseline] (9.648 ms) : 0, 9648
Telemetry [candidate] (7.096 ms) : 0, 7096
IAST [baseline] (23.326 ms) : 0, 23326
IAST [candidate] (22.439 ms) : 0, 22439
section profiling
BytebuddyAgent [baseline] (662.324 ms) : 0, 662324
BytebuddyAgent [candidate] (668.157 ms) : 0, 668157
GlobalTracer [baseline] (389.646 ms) : 0, 389646
GlobalTracer [candidate] (392.162 ms) : 0, 392162
AppSec [baseline] (52.178 ms) : 0, 52178
AppSec [candidate] (52.35 ms) : 0, 52350
Remote Config [baseline] (685.796 µs) : 0, 686
Remote Config [candidate] (712.567 µs) : 0, 713
Telemetry [baseline] (7.418 ms) : 0, 7418
Telemetry [candidate] (7.48 ms) : 0, 7480
ProfilingAgent [baseline] (94.256 ms) : 0, 94256
ProfilingAgent [candidate] (95.843 ms) : 0, 95843
Profiling [baseline] (94.28 ms) : 0, 94280
Profiling [candidate] (95.868 ms) : 0, 95868
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~9dea864e70, baseline=1.39.0-SNAPSHOT~93ecbc62b2

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1048856
Total [baseline] (8.52 s) : 0, 8519502
Agent [candidate] (1.044 s) : 0, 1044071
Total [candidate] (8.505 s) : 0, 8505496
section iast
Agent [baseline] (1.173 s) : 0, 1172695
Total [baseline] (8.954 s) : 0, 8953812
Agent [candidate] (1.182 s) : 0, 1182083
Total [candidate] (9.017 s) : 0, 9016799
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.182 s) : 0, 1181508
Total [baseline] (8.961 s) : 0, 8961449
Agent [candidate] (1.185 s) : 0, 1184512
Total [candidate] (9.003 s) : 0, 9002629
section iast_TELEMETRY_OFF
Agent [baseline] (1.17 s) : 0, 1170383
Total [baseline] (8.955 s) : 0, 8955434
Agent [candidate] (1.17 s) : 0, 1169703
Total [candidate] (8.964 s) : 0, 8963961
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.049 s -
Agent iast 1.173 s 123.839 ms (11.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.182 s 132.653 ms (12.6%)
Agent iast_TELEMETRY_OFF 1.17 s 121.528 ms (11.6%)
Total tracing 8.52 s -
Total iast 8.954 s 434.31 ms (5.1%)
Total iast_HARDCODED_SECRET_DISABLED 8.961 s 441.946 ms (5.2%)
Total iast_TELEMETRY_OFF 8.955 s 435.932 ms (5.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.044 s -
Agent iast 1.182 s 138.012 ms (13.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.185 s 140.441 ms (13.5%)
Agent iast_TELEMETRY_OFF 1.17 s 125.632 ms (12.0%)
Total tracing 8.505 s -
Total iast 9.017 s 511.303 ms (6.0%)
Total iast_HARDCODED_SECRET_DISABLED 9.003 s 497.133 ms (5.8%)
Total iast_TELEMETRY_OFF 8.964 s 458.465 ms (5.4%) 
gantt
    title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~9dea864e70, baseline=1.39.0-SNAPSHOT~93ecbc62b2

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (669.396 ms) : 0, 669396
BytebuddyAgent [candidate] (665.952 ms) : 0, 665952
GlobalTracer [baseline] (306.718 ms) : 0, 306718
GlobalTracer [candidate] (305.677 ms) : 0, 305677
AppSec [baseline] (51.123 ms) : 0, 51123
AppSec [candidate] (50.972 ms) : 0, 50972
Remote Config [baseline] (688.538 µs) : 0, 689
Remote Config [candidate] (680.322 µs) : 0, 680
Telemetry [baseline] (7.509 ms) : 0, 7509
Telemetry [candidate] (7.4 ms) : 0, 7400
section iast
BytebuddyAgent [baseline] (780.509 ms) : 0, 780509
BytebuddyAgent [candidate] (786.728 ms) : 0, 786728
GlobalTracer [baseline] (294.895 ms) : 0, 294895
GlobalTracer [candidate] (297.244 ms) : 0, 297244
AppSec [baseline] (50.641 ms) : 0, 50641
AppSec [candidate] (51.815 ms) : 0, 51815
Remote Config [baseline] (588.942 µs) : 0, 589
Remote Config [candidate] (571.399 µs) : 0, 571
Telemetry [baseline] (9.478 ms) : 0, 9478
Telemetry [candidate] (7.967 ms) : 0, 7967
IAST [baseline] (23.141 ms) : 0, 23141
IAST [candidate] (24.252 ms) : 0, 24252
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (786.573 ms) : 0, 786573
BytebuddyAgent [candidate] (787.877 ms) : 0, 787877
GlobalTracer [baseline] (298.07 ms) : 0, 298070
GlobalTracer [candidate] (298.996 ms) : 0, 298996
AppSec [baseline] (52.24 ms) : 0, 52240
AppSec [candidate] (52.667 ms) : 0, 52667
Remote Config [baseline] (564.866 µs) : 0, 565
Remote Config [candidate] (592.298 µs) : 0, 592
Telemetry [baseline] (7.111 ms) : 0, 7111
Telemetry [candidate] (8.838 ms) : 0, 8838
IAST [baseline] (23.36 ms) : 0, 23360
IAST [candidate] (21.937 ms) : 0, 21937
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (779.001 ms) : 0, 779001
BytebuddyAgent [candidate] (778.443 ms) : 0, 778443
GlobalTracer [baseline] (296.173 ms) : 0, 296173
GlobalTracer [candidate] (296.458 ms) : 0, 296458
AppSec [baseline] (50.31 ms) : 0, 50310
AppSec [candidate] (51.796 ms) : 0, 51796
Remote Config [baseline] (622.06 µs) : 0, 622
Remote Config [candidate] (602.814 µs) : 0, 603
Telemetry [baseline] (8.606 ms) : 0, 8606
Telemetry [candidate] (7.777 ms) : 0, 7777
IAST [baseline] (22.186 ms) : 0, 22186
IAST [candidate] (21.168 ms) : 0, 21168
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-08-12T22:09:53 2024-08-12T22:16:39
git_branch master mcculls/byte-buddy-1.14.18
git_commit_date 1723457525 1723499739
git_commit_sha 93ecbc6 9dea864
release_version 1.39.0-SNAPSHOT~93ecbc62b2 1.39.0-SNAPSHOT~9dea864e70
start_time 2024-08-12T22:09:40 2024-08-12T22:16:26
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1723501342 1723501342
ci_job_id 602659590 602659590
ci_pipeline_id 41545897 41545897
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~9dea864e70, baseline=1.39.0-SNAPSHOT~93ecbc62b2
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.331 ms) : 1313, 1349
.   : milestone, 1331,
appsec (1.678 ms) : 1654, 1702
.   : milestone, 1678,
appsec_no_iast (1.695 ms) : 1672, 1719
.   : milestone, 1695,
iast (1.465 ms) : 1442, 1487
.   : milestone, 1465,
profiling (1.485 ms) : 1461, 1510
.   : milestone, 1485,
tracing (1.448 ms) : 1423, 1472
.   : milestone, 1448,
section candidate
no_agent (1.326 ms) : 1307, 1345
.   : milestone, 1326,
appsec (1.715 ms) : 1691, 1739
.   : milestone, 1715,
appsec_no_iast (1.692 ms) : 1668, 1717
.   : milestone, 1692,
iast (1.472 ms) : 1450, 1494
.   : milestone, 1472,
profiling (1.524 ms) : 1497, 1551
.   : milestone, 1524,
tracing (1.464 ms) : 1440, 1488
.   : milestone, 1464,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.331 ms [1.313 ms, 1.349 ms] -
appsec 1.678 ms [1.654 ms, 1.702 ms] 346.724 µs (26.0%)
appsec_no_iast 1.695 ms [1.672 ms, 1.719 ms] 364.258 µs (27.4%)
iast 1.465 ms [1.442 ms, 1.487 ms] 133.476 µs (10.0%)
profiling 1.485 ms [1.461 ms, 1.51 ms] 154.181 µs (11.6%)
tracing 1.448 ms [1.423 ms, 1.472 ms] 116.748 µs (8.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.326 ms [1.307 ms, 1.345 ms] -
appsec 1.715 ms [1.691 ms, 1.739 ms] 388.988 µs (29.3%)
appsec_no_iast 1.692 ms [1.668 ms, 1.717 ms] 366.365 µs (27.6%)
iast 1.472 ms [1.45 ms, 1.494 ms] 145.98 µs (11.0%)
profiling 1.524 ms [1.497 ms, 1.551 ms] 197.574 µs (14.9%)
tracing 1.464 ms [1.44 ms, 1.488 ms] 137.625 µs (10.4%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~9dea864e70, baseline=1.39.0-SNAPSHOT~93ecbc62b2
    dateFormat X
    axisFormat %s
section baseline
no_agent (367.131 µs) : 347, 387
.   : milestone, 367,
iast (481.858 µs) : 460, 503
.   : milestone, 482,
iast_FULL (546.657 µs) : 524, 569
.   : milestone, 547,
iast_GLOBAL (504.09 µs) : 481, 527
.   : milestone, 504,
iast_HARDCODED_SECRET_DISABLED (476.314 µs) : 455, 497
.   : milestone, 476,
iast_INACTIVE (451.922 µs) : 430, 474
.   : milestone, 452,
iast_TELEMETRY_OFF (473.749 µs) : 452, 495
.   : milestone, 474,
tracing (438.926 µs) : 418, 460
.   : milestone, 439,
section candidate
no_agent (364.21 µs) : 343, 385
.   : milestone, 364,
iast (475.161 µs) : 454, 497
.   : milestone, 475,
iast_FULL (543.68 µs) : 521, 566
.   : milestone, 544,
iast_GLOBAL (510.282 µs) : 487, 533
.   : milestone, 510,
iast_HARDCODED_SECRET_DISABLED (477.206 µs) : 456, 498
.   : milestone, 477,
iast_INACTIVE (450.914 µs) : 428, 473
.   : milestone, 451,
iast_TELEMETRY_OFF (471.486 µs) : 450, 493
.   : milestone, 471,
tracing (431.896 µs) : 412, 452
.   : milestone, 432,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 367.131 µs [347.123 µs, 387.139 µs] -
iast 481.858 µs [460.236 µs, 503.48 µs] 114.727 µs (31.2%)
iast_FULL 546.657 µs [524.314 µs, 569.0 µs] 179.526 µs (48.9%)
iast_GLOBAL 504.09 µs [481.182 µs, 526.998 µs] 136.959 µs (37.3%)
iast_HARDCODED_SECRET_DISABLED 476.314 µs [455.164 µs, 497.463 µs] 109.183 µs (29.7%)
iast_INACTIVE 451.922 µs [429.515 µs, 474.33 µs] 84.791 µs (23.1%)
iast_TELEMETRY_OFF 473.749 µs [452.021 µs, 495.477 µs] 106.618 µs (29.0%)
tracing 438.926 µs [417.561 µs, 460.292 µs] 71.796 µs (19.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 364.21 µs [343.074 µs, 385.345 µs] -
iast 475.161 µs [453.545 µs, 496.777 µs] 110.951 µs (30.5%)
iast_FULL 543.68 µs [521.169 µs, 566.191 µs] 179.47 µs (49.3%)
iast_GLOBAL 510.282 µs [487.219 µs, 533.345 µs] 146.072 µs (40.1%)
iast_HARDCODED_SECRET_DISABLED 477.206 µs [456.081 µs, 498.331 µs] 112.996 µs (31.0%)
iast_INACTIVE 450.914 µs [428.424 µs, 473.404 µs] 86.705 µs (23.8%)
iast_TELEMETRY_OFF 471.486 µs [450.247 µs, 492.725 µs] 107.276 µs (29.5%)
tracing 431.896 µs [411.792 µs, 452.0 µs] 67.686 µs (18.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/byte-buddy-1.14.18
git_commit_date 1723457525 1723499739
git_commit_sha 93ecbc6 9dea864
release_version 1.39.0-SNAPSHOT~93ecbc62b2 1.39.0-SNAPSHOT~9dea864e70
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1723501851 1723501851
ci_job_id 602659591 602659591
ci_pipeline_id 41545897 41545897
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~9dea864e70, baseline=1.39.0-SNAPSHOT~93ecbc62b2
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.969 s) : 14969000, 14969000
.   : milestone, 14969000,
appsec (15.425 s) : 15425000, 15425000
.   : milestone, 15425000,
iast (18.667 s) : 18667000, 18667000
.   : milestone, 18667000,
iast_GLOBAL (17.903 s) : 17903000, 17903000
.   : milestone, 17903000,
profiling (15.056 s) : 15056000, 15056000
.   : milestone, 15056000,
tracing (15.413 s) : 15413000, 15413000
.   : milestone, 15413000,
section candidate
no_agent (15.021 s) : 15021000, 15021000
.   : milestone, 15021000,
appsec (14.802 s) : 14802000, 14802000
.   : milestone, 14802000,
iast (18.671 s) : 18671000, 18671000
.   : milestone, 18671000,
iast_GLOBAL (17.843 s) : 17843000, 17843000
.   : milestone, 17843000,
profiling (15.796 s) : 15796000, 15796000
.   : milestone, 15796000,
tracing (14.968 s) : 14968000, 14968000
.   : milestone, 14968000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.969 s [14.969 s, 14.969 s] -
appsec 15.425 s [15.425 s, 15.425 s] 456.0 ms (3.0%)
iast 18.667 s [18.667 s, 18.667 s] 3.698 s (24.7%)
iast_GLOBAL 17.903 s [17.903 s, 17.903 s] 2.934 s (19.6%)
profiling 15.056 s [15.056 s, 15.056 s] 87.0 ms (0.6%)
tracing 15.413 s [15.413 s, 15.413 s] 444.0 ms (3.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.021 s [15.021 s, 15.021 s] -
appsec 14.802 s [14.802 s, 14.802 s] -219.0 ms (-1.5%)
iast 18.671 s [18.671 s, 18.671 s] 3.65 s (24.3%)
iast_GLOBAL 17.843 s [17.843 s, 17.843 s] 2.822 s (18.8%)
profiling 15.796 s [15.796 s, 15.796 s] 775.0 ms (5.2%)
tracing 14.968 s [14.968 s, 14.968 s] -53.0 ms (-0.4%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~9dea864e70, baseline=1.39.0-SNAPSHOT~93ecbc62b2
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.458 ms) : 1446, 1469
.   : milestone, 1458,
appsec (2.224 ms) : 2188, 2259
.   : milestone, 2224,
iast (1.965 ms) : 1922, 2007
.   : milestone, 1965,
iast_GLOBAL (2.009 ms) : 1966, 2052
.   : milestone, 2009,
profiling (1.861 ms) : 1827, 1895
.   : milestone, 1861,
tracing (1.835 ms) : 1803, 1868
.   : milestone, 1835,
section candidate
no_agent (1.46 ms) : 1448, 1471
.   : milestone, 1460,
appsec (2.215 ms) : 2180, 2249
.   : milestone, 2215,
iast (1.988 ms) : 1945, 2031
.   : milestone, 1988,
iast_GLOBAL (2.01 ms) : 1967, 2052
.   : milestone, 2010,
profiling (1.855 ms) : 1820, 1890
.   : milestone, 1855,
tracing (1.83 ms) : 1798, 1862
.   : milestone, 1830,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.458 ms [1.446 ms, 1.469 ms] -
appsec 2.224 ms [2.188 ms, 2.259 ms] 766.002 µs (52.6%)
iast 1.965 ms [1.922 ms, 2.007 ms] 507.18 µs (34.8%)
iast_GLOBAL 2.009 ms [1.966 ms, 2.052 ms] 551.494 µs (37.8%)
profiling 1.861 ms [1.827 ms, 1.895 ms] 403.339 µs (27.7%)
tracing 1.835 ms [1.803 ms, 1.868 ms] 377.55 µs (25.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.46 ms [1.448 ms, 1.471 ms] -
appsec 2.215 ms [2.18 ms, 2.249 ms] 754.989 µs (51.7%)
iast 1.988 ms [1.945 ms, 2.031 ms] 528.751 µs (36.2%)
iast_GLOBAL 2.01 ms [1.967 ms, 2.052 ms] 550.361 µs (37.7%)
profiling 1.855 ms [1.82 ms, 1.89 ms] 395.782 µs (27.1%)
tracing 1.83 ms [1.798 ms, 1.862 ms] 370.38 µs (25.4%)

@mcculls mcculls marked this pull request as ready for review August 13, 2024 11:04
@mcculls mcculls requested a review from a team as a code owner August 13, 2024 11:04
PerfectSlayer
PerfectSlayer approved these changes Aug 13, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Should we set this as inst: others or exclude it from release notes?

@mcculls
Copy link
Copy Markdown
Contributor Author

mcculls commented Aug 13, 2024 •
edited
Loading

Should we set this as inst: others or exclude it from release notes?

We should document dependency updates in the release notes - this is a core dependency, not so much an instrumentation itself so labelling it inst: others feels wrong. Does it need to have another label in addition to dependencies?

@mcculls mcculls merged commit 88ff5a6 into master Aug 13, 2024
@mcculls mcculls deleted the mcculls/byte-buddy-1.14.18 branch August 13, 2024 13:48
@github-actions github-actions Bot added this to the 1.39.0 milestone Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@nayeem-kamal nayeem-kamal Awaiting requested review from nayeem-kamal nayeem-kamal is a code owner automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

tag: dependencies Dependencies related changes

Projects

None yet

Milestone

1.39.0

Development

Successfully merging this pull request may close these issues.

2 participants

@mcculls @PerfectSlayer