Skip to content

Make cws-tls use the same JNA dependency as instrumentations#7412

Merged
bantonsson merged 1 commit intomasterfrom
ban/embed-cwstls-always
Aug 14, 2024
Merged

Make cws-tls use the same JNA dependency as instrumentations#7412
bantonsson merged 1 commit intomasterfrom
ban/embed-cwstls-always

Conversation

@bantonsson
Copy link
Copy Markdown
Contributor

@bantonsson bantonsson commented Aug 12, 2024 •
edited
Loading

What Does This Do

Makes the cws-tls module use the same JNA dependency as the instrumentations in the final packaged jar, and includes it by default.

Motivation

The cws-tls module was not included by default since it was under development and added significantly to the overall jar size. The JNA dependency used has since been included by other instrumentations and the cws-tls module can now be included.

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@bantonsson bantonsson force-pushed the ban/embed-cwstls-always branch from 65186e7 to 729a2cb Compare August 12, 2024 10:37
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Aug 12, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master ban/embed-cwstls-always
git_commit_date 1723583620 1723619867
git_commit_sha 4c58087 048905f
release_version 1.39.0-SNAPSHOT~4c58087c38 1.39.0-SNAPSHOT~048905fbf0
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1723622251 1723622251
ci_job_id 604477625 604477625
ci_pipeline_id 41727727 41727727
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~048905fbf0, baseline=1.39.0-SNAPSHOT~4c58087c38

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1050270
Total [baseline] (10.279 s) : 0, 10278896
Agent [candidate] (1.049 s) : 0, 1048760
Total [candidate] (10.337 s) : 0, 10337429
section appsec
Agent [baseline] (1.172 s) : 0, 1171624
Total [baseline] (10.45 s) : 0, 10449794
Agent [candidate] (1.172 s) : 0, 1172039
Total [candidate] (10.477 s) : 0, 10476687
section iast
Agent [baseline] (1.185 s) : 0, 1185124
Total [baseline] (10.868 s) : 0, 10868151
Agent [candidate] (1.18 s) : 0, 1180035
Total [candidate] (10.842 s) : 0, 10842439
section profiling
Agent [baseline] (1.257 s) : 0, 1257261
Total [baseline] (10.592 s) : 0, 10592318
Agent [candidate] (1.257 s) : 0, 1256820
Total [candidate] (10.664 s) : 0, 10663786
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.05 s -
Agent appsec 1.172 s 121.355 ms (11.6%)
Agent iast 1.185 s 134.854 ms (12.8%)
Agent profiling 1.257 s 206.992 ms (19.7%)
Total tracing 10.279 s -
Total appsec 10.45 s 170.897 ms (1.7%)
Total iast 10.868 s 589.255 ms (5.7%)
Total profiling 10.592 s 313.422 ms (3.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.049 s -
Agent appsec 1.172 s 123.278 ms (11.8%)
Agent iast 1.18 s 131.274 ms (12.5%)
Agent profiling 1.257 s 208.06 ms (19.8%)
Total tracing 10.337 s -
Total appsec 10.477 s 139.258 ms (1.3%)
Total iast 10.842 s 505.01 ms (4.9%)
Total profiling 10.664 s 326.357 ms (3.2%) 
gantt
    title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~048905fbf0, baseline=1.39.0-SNAPSHOT~4c58087c38

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (669.73 ms) : 0, 669730
BytebuddyAgent [candidate] (668.729 ms) : 0, 668729
GlobalTracer [baseline] (307.558 ms) : 0, 307558
GlobalTracer [candidate] (307.267 ms) : 0, 307267
AppSec [baseline] (51.31 ms) : 0, 51310
AppSec [candidate] (51.151 ms) : 0, 51151
Remote Config [baseline] (687.048 µs) : 0, 687
Remote Config [candidate] (684.556 µs) : 0, 685
Telemetry [baseline] (7.489 ms) : 0, 7489
Telemetry [candidate] (7.476 ms) : 0, 7476
section appsec
BytebuddyAgent [baseline] (679.256 ms) : 0, 679256
BytebuddyAgent [candidate] (680.276 ms) : 0, 680276
GlobalTracer [baseline] (300.596 ms) : 0, 300596
GlobalTracer [candidate] (301.24 ms) : 0, 301240
AppSec [baseline] (157.344 ms) : 0, 157344
AppSec [candidate] (157.88 ms) : 0, 157880
Remote Config [baseline] (602.06 µs) : 0, 602
Remote Config [candidate] (606.906 µs) : 0, 607
Telemetry [baseline] (9.775 ms) : 0, 9775
Telemetry [candidate] (8.068 ms) : 0, 8068
IAST [baseline] (21.025 ms) : 0, 21025
IAST [candidate] (20.82 ms) : 0, 20820
section iast
BytebuddyAgent [baseline] (789.679 ms) : 0, 789679
BytebuddyAgent [candidate] (784.44 ms) : 0, 784440
GlobalTracer [baseline] (296.906 ms) : 0, 296906
GlobalTracer [candidate] (297.572 ms) : 0, 297572
AppSec [baseline] (52.202 ms) : 0, 52202
AppSec [candidate] (53.491 ms) : 0, 53491
Remote Config [baseline] (617.994 µs) : 0, 618
Remote Config [candidate] (586.977 µs) : 0, 587
Telemetry [baseline] (7.918 ms) : 0, 7918
Telemetry [candidate] (7.983 ms) : 0, 7983
IAST [baseline] (24.182 ms) : 0, 24182
IAST [candidate] (22.458 ms) : 0, 22458
section profiling
BytebuddyAgent [baseline] (669.965 ms) : 0, 669965
BytebuddyAgent [candidate] (669.21 ms) : 0, 669210
GlobalTracer [baseline] (394.439 ms) : 0, 394439
GlobalTracer [candidate] (393.646 ms) : 0, 393646
AppSec [baseline] (52.049 ms) : 0, 52049
AppSec [candidate] (52.765 ms) : 0, 52765
Remote Config [baseline] (698.933 µs) : 0, 699
Remote Config [candidate] (687.6 µs) : 0, 688
Telemetry [baseline] (7.433 ms) : 0, 7433
Telemetry [candidate] (7.502 ms) : 0, 7502
ProfilingAgent [baseline] (95.124 ms) : 0, 95124
ProfilingAgent [candidate] (95.549 ms) : 0, 95549
Profiling [baseline] (95.149 ms) : 0, 95149
Profiling [candidate] (95.574 ms) : 0, 95574
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~048905fbf0, baseline=1.39.0-SNAPSHOT~4c58087c38

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.048 s) : 0, 1047803
Total [baseline] (8.484 s) : 0, 8484311
Agent [candidate] (1.045 s) : 0, 1045147
Total [candidate] (8.475 s) : 0, 8474662
section iast
Agent [baseline] (1.178 s) : 0, 1177591
Total [baseline] (9.026 s) : 0, 9026030
Agent [candidate] (1.186 s) : 0, 1185517
Total [candidate] (8.986 s) : 0, 8985580
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.176 s) : 0, 1175931
Total [baseline] (9.013 s) : 0, 9012834
Agent [candidate] (1.176 s) : 0, 1176341
Total [candidate] (8.991 s) : 0, 8991146
section iast_TELEMETRY_OFF
Agent [baseline] (1.18 s) : 0, 1180108
Total [baseline] (9.016 s) : 0, 9015679
Agent [candidate] (1.184 s) : 0, 1183873
Total [candidate] (8.995 s) : 0, 8994866
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.048 s -
Agent iast 1.178 s 129.788 ms (12.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.176 s 128.129 ms (12.2%)
Agent iast_TELEMETRY_OFF 1.18 s 132.305 ms (12.6%)
Total tracing 8.484 s -
Total iast 9.026 s 541.718 ms (6.4%)
Total iast_HARDCODED_SECRET_DISABLED 9.013 s 528.523 ms (6.2%)
Total iast_TELEMETRY_OFF 9.016 s 531.368 ms (6.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.045 s -
Agent iast 1.186 s 140.37 ms (13.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.176 s 131.193 ms (12.6%)
Agent iast_TELEMETRY_OFF 1.184 s 138.725 ms (13.3%)
Total tracing 8.475 s -
Total iast 8.986 s 510.917 ms (6.0%)
Total iast_HARDCODED_SECRET_DISABLED 8.991 s 516.483 ms (6.1%)
Total iast_TELEMETRY_OFF 8.995 s 520.203 ms (6.1%) 
gantt
    title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~048905fbf0, baseline=1.39.0-SNAPSHOT~4c58087c38

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (668.451 ms) : 0, 668451
BytebuddyAgent [candidate] (666.721 ms) : 0, 666721
GlobalTracer [baseline] (306.672 ms) : 0, 306672
GlobalTracer [candidate] (305.745 ms) : 0, 305745
AppSec [baseline] (50.948 ms) : 0, 50948
AppSec [candidate] (51.066 ms) : 0, 51066
Remote Config [baseline] (688.619 µs) : 0, 689
Remote Config [candidate] (683.676 µs) : 0, 684
Telemetry [baseline] (7.612 ms) : 0, 7612
Telemetry [candidate] (7.492 ms) : 0, 7492
section iast
BytebuddyAgent [baseline] (783.777 ms) : 0, 783777
BytebuddyAgent [candidate] (789.164 ms) : 0, 789164
GlobalTracer [baseline] (295.863 ms) : 0, 295863
GlobalTracer [candidate] (298.628 ms) : 0, 298628
AppSec [baseline] (52.479 ms) : 0, 52479
AppSec [candidate] (50.532 ms) : 0, 50532
IAST [baseline] (24.147 ms) : 0, 24147
IAST [candidate] (24.047 ms) : 0, 24047
Remote Config [baseline] (588.87 µs) : 0, 589
Remote Config [candidate] (605.608 µs) : 0, 606
Telemetry [baseline] (7.159 ms) : 0, 7159
Telemetry [candidate] (8.909 ms) : 0, 8909
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (782.189 ms) : 0, 782189
BytebuddyAgent [candidate] (782.312 ms) : 0, 782312
GlobalTracer [baseline] (296.6 ms) : 0, 296600
GlobalTracer [candidate] (297.381 ms) : 0, 297381
AppSec [baseline] (47.966 ms) : 0, 47966
AppSec [candidate] (48.601 ms) : 0, 48601
IAST [baseline] (25.474 ms) : 0, 25474
IAST [candidate] (25.134 ms) : 0, 25134
Remote Config [baseline] (595.449 µs) : 0, 595
Remote Config [candidate] (581.421 µs) : 0, 581
Telemetry [baseline] (9.549 ms) : 0, 9549
Telemetry [candidate] (8.758 ms) : 0, 8758
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (784.479 ms) : 0, 784479
BytebuddyAgent [candidate] (787.444 ms) : 0, 787444
GlobalTracer [baseline] (298.148 ms) : 0, 298148
GlobalTracer [candidate] (299.469 ms) : 0, 299469
AppSec [baseline] (52.974 ms) : 0, 52974
AppSec [candidate] (52.603 ms) : 0, 52603
IAST [baseline] (23.189 ms) : 0, 23189
IAST [candidate] (23.014 ms) : 0, 23014
Remote Config [baseline] (616.998 µs) : 0, 617
Remote Config [candidate] (616.314 µs) : 0, 616
Telemetry [baseline] (7.11 ms) : 0, 7110
Telemetry [candidate] (7.055 ms) : 0, 7055
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-08-14T07:28:17 2024-08-14T07:35:05
git_branch master ban/embed-cwstls-always
git_commit_date 1723583620 1723619867
git_commit_sha 4c58087 048905f
release_version 1.39.0-SNAPSHOT~4c58087c38 1.39.0-SNAPSHOT~048905fbf0
start_time 2024-08-14T07:28:04 2024-08-14T07:34:52
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1723621251 1723621251
ci_job_id 604477626 604477626
ci_pipeline_id 41727727 41727727
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 17 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:profiling worse
[+31.388µs; +94.035µs] or [+2.114%; +6.334%]		 unstable
[-792.695op/s; +318.621op/s] or [-24.772%; +9.957%]		 1.547ms 2962.963op/s 1.485ms 3200.000op/s
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~048905fbf0, baseline=1.39.0-SNAPSHOT~4c58087c38
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.347 ms) : 1328, 1367
.   : milestone, 1347,
appsec (1.716 ms) : 1692, 1741
.   : milestone, 1716,
appsec_no_iast (1.71 ms) : 1685, 1735
.   : milestone, 1710,
iast (1.469 ms) : 1446, 1492
.   : milestone, 1469,
profiling (1.485 ms) : 1460, 1509
.   : milestone, 1485,
tracing (1.481 ms) : 1457, 1505
.   : milestone, 1481,
section candidate
no_agent (1.333 ms) : 1314, 1352
.   : milestone, 1333,
appsec (1.723 ms) : 1699, 1747
.   : milestone, 1723,
appsec_no_iast (1.714 ms) : 1689, 1738
.   : milestone, 1714,
iast (1.483 ms) : 1461, 1505
.   : milestone, 1483,
profiling (1.547 ms) : 1514, 1581
.   : milestone, 1547,
tracing (1.46 ms) : 1436, 1485
.   : milestone, 1460,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.347 ms [1.328 ms, 1.367 ms] -
appsec 1.716 ms [1.692 ms, 1.741 ms] 369.044 µs (27.4%)
appsec_no_iast 1.71 ms [1.685 ms, 1.735 ms] 362.605 µs (26.9%)
iast 1.469 ms [1.446 ms, 1.492 ms] 121.221 µs (9.0%)
profiling 1.485 ms [1.46 ms, 1.509 ms] 137.244 µs (10.2%)
tracing 1.481 ms [1.457 ms, 1.505 ms] 133.64 µs (9.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.333 ms [1.314 ms, 1.352 ms] -
appsec 1.723 ms [1.699 ms, 1.747 ms] 390.183 µs (29.3%)
appsec_no_iast 1.714 ms [1.689 ms, 1.738 ms] 380.771 µs (28.6%)
iast 1.483 ms [1.461 ms, 1.505 ms] 150.583 µs (11.3%)
profiling 1.547 ms [1.514 ms, 1.581 ms] 214.61 µs (16.1%)
tracing 1.46 ms [1.436 ms, 1.485 ms] 127.736 µs (9.6%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~048905fbf0, baseline=1.39.0-SNAPSHOT~4c58087c38
    dateFormat X
    axisFormat %s
section baseline
no_agent (368.143 µs) : 349, 388
.   : milestone, 368,
iast (481.981 µs) : 461, 503
.   : milestone, 482,
iast_FULL (545.812 µs) : 523, 568
.   : milestone, 546,
iast_GLOBAL (506.904 µs) : 484, 529
.   : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (474.817 µs) : 454, 496
.   : milestone, 475,
iast_INACTIVE (447.318 µs) : 425, 469
.   : milestone, 447,
iast_TELEMETRY_OFF (473.586 µs) : 452, 495
.   : milestone, 474,
tracing (434.992 µs) : 415, 455
.   : milestone, 435,
section candidate
no_agent (366.036 µs) : 345, 387
.   : milestone, 366,
iast (487.572 µs) : 465, 510
.   : milestone, 488,
iast_FULL (551.713 µs) : 529, 574
.   : milestone, 552,
iast_GLOBAL (504.704 µs) : 482, 527
.   : milestone, 505,
iast_HARDCODED_SECRET_DISABLED (480.74 µs) : 460, 502
.   : milestone, 481,
iast_INACTIVE (457.234 µs) : 434, 480
.   : milestone, 457,
iast_TELEMETRY_OFF (468.002 µs) : 447, 489
.   : milestone, 468,
tracing (434.081 µs) : 414, 454
.   : milestone, 434,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 368.143 µs [348.666 µs, 387.62 µs] -
iast 481.981 µs [460.564 µs, 503.398 µs] 113.839 µs (30.9%)
iast_FULL 545.812 µs [523.446 µs, 568.177 µs] 177.669 µs (48.3%)
iast_GLOBAL 506.904 µs [484.415 µs, 529.392 µs] 138.761 µs (37.7%)
iast_HARDCODED_SECRET_DISABLED 474.817 µs [453.629 µs, 496.004 µs] 106.674 µs (29.0%)
iast_INACTIVE 447.318 µs [425.275 µs, 469.362 µs] 79.176 µs (21.5%)
iast_TELEMETRY_OFF 473.586 µs [451.878 µs, 495.294 µs] 105.443 µs (28.6%)
tracing 434.992 µs [414.706 µs, 455.278 µs] 66.849 µs (18.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 366.036 µs [345.256 µs, 386.815 µs] -
iast 487.572 µs [465.165 µs, 509.979 µs] 121.537 µs (33.2%)
iast_FULL 551.713 µs [529.276 µs, 574.15 µs] 185.677 µs (50.7%)
iast_GLOBAL 504.704 µs [482.309 µs, 527.1 µs] 138.669 µs (37.9%)
iast_HARDCODED_SECRET_DISABLED 480.74 µs [459.531 µs, 501.949 µs] 114.704 µs (31.3%)
iast_INACTIVE 457.234 µs [434.406 µs, 480.062 µs] 91.198 µs (24.9%)
iast_TELEMETRY_OFF 468.002 µs [446.825 µs, 489.18 µs] 101.967 µs (27.9%)
tracing 434.081 µs [413.939 µs, 454.223 µs] 68.045 µs (18.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master ban/embed-cwstls-always
git_commit_date 1723583620 1723619867
git_commit_sha 4c58087 048905f
release_version 1.39.0-SNAPSHOT~4c58087c38 1.39.0-SNAPSHOT~048905fbf0
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1723621753 1723621753
ci_job_id 604477627 604477627
ci_pipeline_id 41727727 41727727
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~048905fbf0, baseline=1.39.0-SNAPSHOT~4c58087c38
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.008 s) : 15008000, 15008000
.   : milestone, 15008000,
appsec (15.116 s) : 15116000, 15116000
.   : milestone, 15116000,
iast (18.747 s) : 18747000, 18747000
.   : milestone, 18747000,
iast_GLOBAL (17.947 s) : 17947000, 17947000
.   : milestone, 17947000,
profiling (15.169 s) : 15169000, 15169000
.   : milestone, 15169000,
tracing (14.961 s) : 14961000, 14961000
.   : milestone, 14961000,
section candidate
no_agent (15.502 s) : 15502000, 15502000
.   : milestone, 15502000,
appsec (15.273 s) : 15273000, 15273000
.   : milestone, 15273000,
iast (18.588 s) : 18588000, 18588000
.   : milestone, 18588000,
iast_GLOBAL (17.82 s) : 17820000, 17820000
.   : milestone, 17820000,
profiling (15.19 s) : 15190000, 15190000
.   : milestone, 15190000,
tracing (15.125 s) : 15125000, 15125000
.   : milestone, 15125000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.008 s [15.008 s, 15.008 s] -
appsec 15.116 s [15.116 s, 15.116 s] 108.0 ms (0.7%)
iast 18.747 s [18.747 s, 18.747 s] 3.739 s (24.9%)
iast_GLOBAL 17.947 s [17.947 s, 17.947 s] 2.939 s (19.6%)
profiling 15.169 s [15.169 s, 15.169 s] 161.0 ms (1.1%)
tracing 14.961 s [14.961 s, 14.961 s] -47.0 ms (-0.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.502 s [15.502 s, 15.502 s] -
appsec 15.273 s [15.273 s, 15.273 s] -229.0 ms (-1.5%)
iast 18.588 s [18.588 s, 18.588 s] 3.086 s (19.9%)
iast_GLOBAL 17.82 s [17.82 s, 17.82 s] 2.318 s (15.0%)
profiling 15.19 s [15.19 s, 15.19 s] -312.0 ms (-2.0%)
tracing 15.125 s [15.125 s, 15.125 s] -377.0 ms (-2.4%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~048905fbf0, baseline=1.39.0-SNAPSHOT~4c58087c38
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.462 ms) : 1451, 1474
.   : milestone, 1462,
appsec (2.213 ms) : 2178, 2247
.   : milestone, 2213,
iast (1.951 ms) : 1910, 1992
.   : milestone, 1951,
iast_GLOBAL (2.011 ms) : 1969, 2054
.   : milestone, 2011,
profiling (2.344 ms) : 2160, 2529
.   : milestone, 2344,
tracing (1.84 ms) : 1807, 1873
.   : milestone, 1840,
section candidate
no_agent (1.455 ms) : 1444, 1467
.   : milestone, 1455,
appsec (2.222 ms) : 2187, 2257
.   : milestone, 2222,
iast (1.957 ms) : 1916, 1998
.   : milestone, 1957,
iast_GLOBAL (2.022 ms) : 1979, 2066
.   : milestone, 2022,
profiling (1.862 ms) : 1828, 1896
.   : milestone, 1862,
tracing (1.83 ms) : 1797, 1862
.   : milestone, 1830,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.462 ms [1.451 ms, 1.474 ms] -
appsec 2.213 ms [2.178 ms, 2.247 ms] 750.531 µs (51.3%)
iast 1.951 ms [1.91 ms, 1.992 ms] 488.784 µs (33.4%)
iast_GLOBAL 2.011 ms [1.969 ms, 2.054 ms] 549.213 µs (37.6%)
profiling 2.344 ms [2.16 ms, 2.529 ms] 882.179 µs (60.3%)
tracing 1.84 ms [1.807 ms, 1.873 ms] 377.594 µs (25.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.455 ms [1.444 ms, 1.467 ms] -
appsec 2.222 ms [2.187 ms, 2.257 ms] 766.513 µs (52.7%)
iast 1.957 ms [1.916 ms, 1.998 ms] 501.741 µs (34.5%)
iast_GLOBAL 2.022 ms [1.979 ms, 2.066 ms] 567.018 µs (39.0%)
profiling 1.862 ms [1.828 ms, 1.896 ms] 406.389 µs (27.9%)
tracing 1.83 ms [1.797 ms, 1.862 ms] 374.386 µs (25.7%)

@bantonsson bantonsson force-pushed the ban/embed-cwstls-always branch from 729a2cb to cc29543 Compare August 12, 2024 15:31
@bantonsson bantonsson force-pushed the ban/embed-cwstls-always branch from cc29543 to 048905f Compare August 14, 2024 07:17
@bantonsson bantonsson added the comp: cws Cloud Workload Security (CWS) label Aug 14, 2024
@bantonsson bantonsson marked this pull request as ready for review August 14, 2024 07:24
@bantonsson bantonsson requested a review from a team as a code owner August 14, 2024 07:24
PerfectSlayer
PerfectSlayer approved these changes Aug 14, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Are you aware of any down side enabling cws-tls by default?

@bantonsson
Copy link
Copy Markdown
Contributor Author

bantonsson commented Aug 14, 2024

@PerfectSlayer It's only included in the jar file. It's still opt-in to enable.

@bantonsson bantonsson merged commit 3374733 into master Aug 14, 2024
@bantonsson bantonsson deleted the ban/embed-cwstls-always branch August 14, 2024 13:07
@github-actions github-actions Bot added this to the 1.39.0 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@mcculls mcculls Awaiting requested review from mcculls mcculls is a code owner automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

comp: cws Cloud Workload Security (CWS)

Projects

None yet

Milestone

1.39.0

Development

Successfully merging this pull request may close these issues.

2 participants

@bantonsson @PerfectSlayer