Reduce telemetry log messages per minute to 10#7410
Merged
Conversation
This is plenty for most organizations and services, while it keeps misbehaving services under control.
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 16 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~11fa41acaa, baseline=1.39.0-SNAPSHOT~0e0a715784
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1054997
Total [baseline] (8.551 s) : 0, 8550546
Agent [candidate] (1.047 s) : 0, 1046807
Total [candidate] (8.491 s) : 0, 8491323
section iast
Agent [baseline] (1.198 s) : 0, 1198069
Total [baseline] (9.037 s) : 0, 9036644
Agent [candidate] (1.179 s) : 0, 1178935
Total [candidate] (8.972 s) : 0, 8972301
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.184 s) : 0, 1183595
Total [baseline] (9.032 s) : 0, 9032390
Agent [candidate] (1.185 s) : 0, 1185066
Total [candidate] (9.005 s) : 0, 9004718
section iast_TELEMETRY_OFF
Agent [baseline] (1.172 s) : 0, 1171841
Total [baseline] (8.983 s) : 0, 8983114
Agent [candidate] (1.175 s) : 0, 1175373
Total [candidate] (9.022 s) : 0, 9022253
gantt
title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~11fa41acaa, baseline=1.39.0-SNAPSHOT~0e0a715784
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (673.308 ms) : 0, 673308
BytebuddyAgent [candidate] (667.802 ms) : 0, 667802
GlobalTracer [baseline] (308.727 ms) : 0, 308727
GlobalTracer [candidate] (306.519 ms) : 0, 306519
AppSec [baseline] (51.223 ms) : 0, 51223
AppSec [candidate] (50.952 ms) : 0, 50952
Remote Config [baseline] (682.399 µs) : 0, 682
Remote Config [candidate] (680.42 µs) : 0, 680
Telemetry [baseline] (7.549 ms) : 0, 7549
Telemetry [candidate] (7.439 ms) : 0, 7439
section iast
BytebuddyAgent [baseline] (799.574 ms) : 0, 799574
BytebuddyAgent [candidate] (783.839 ms) : 0, 783839
GlobalTracer [baseline] (300.515 ms) : 0, 300515
GlobalTracer [candidate] (297.048 ms) : 0, 297048
AppSec [baseline] (53.714 ms) : 0, 53714
AppSec [candidate] (51.917 ms) : 0, 51917
Remote Config [baseline] (615.26 µs) : 0, 615
Remote Config [candidate] (571.119 µs) : 0, 571
Telemetry [baseline] (7.254 ms) : 0, 7254
Telemetry [candidate] (7.77 ms) : 0, 7770
IAST [baseline] (22.663 ms) : 0, 22663
IAST [candidate] (24.282 ms) : 0, 24282
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (788.757 ms) : 0, 788757
BytebuddyAgent [candidate] (788.569 ms) : 0, 788569
GlobalTracer [baseline] (299.365 ms) : 0, 299365
GlobalTracer [candidate] (298.865 ms) : 0, 298865
AppSec [baseline] (51.306 ms) : 0, 51306
AppSec [candidate] (49.076 ms) : 0, 49076
Remote Config [baseline] (583.813 µs) : 0, 584
Remote Config [candidate] (591.922 µs) : 0, 592
Telemetry [baseline] (7.32 ms) : 0, 7320
Telemetry [candidate] (9.719 ms) : 0, 9719
IAST [baseline] (22.675 ms) : 0, 22675
IAST [candidate] (24.632 ms) : 0, 24632
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (778.451 ms) : 0, 778451
BytebuddyAgent [candidate] (781.008 ms) : 0, 781008
GlobalTracer [baseline] (296.915 ms) : 0, 296915
GlobalTracer [candidate] (296.94 ms) : 0, 296940
AppSec [baseline] (54.356 ms) : 0, 54356
AppSec [candidate] (52.261 ms) : 0, 52261
Remote Config [baseline] (591.348 µs) : 0, 591
Remote Config [candidate] (613.056 µs) : 0, 613
Telemetry [baseline] (6.996 ms) : 0, 6996
Telemetry [candidate] (8.602 ms) : 0, 8602
IAST [baseline] (21.09 ms) : 0, 21090
IAST [candidate] (22.402 ms) : 0, 22402
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~11fa41acaa, baseline=1.39.0-SNAPSHOT~0e0a715784
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1049516
Total [baseline] (10.365 s) : 0, 10364870
Agent [candidate] (1.05 s) : 0, 1049609
Total [candidate] (10.358 s) : 0, 10358184
section appsec
Agent [baseline] (1.169 s) : 0, 1169337
Total [baseline] (10.521 s) : 0, 10521492
Agent [candidate] (1.172 s) : 0, 1172010
Total [candidate] (10.504 s) : 0, 10503600
section iast
Agent [baseline] (1.175 s) : 0, 1174520
Total [baseline] (10.827 s) : 0, 10827252
Agent [candidate] (1.177 s) : 0, 1176731
Total [candidate] (10.822 s) : 0, 10821741
section profiling
Agent [baseline] (1.246 s) : 0, 1246395
Total [baseline] (10.636 s) : 0, 10635634
Agent [candidate] (1.249 s) : 0, 1248698
Total [candidate] (10.713 s) : 0, 10712768
gantt
title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~11fa41acaa, baseline=1.39.0-SNAPSHOT~0e0a715784
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (669.338 ms) : 0, 669338
BytebuddyAgent [candidate] (669.65 ms) : 0, 669650
GlobalTracer [baseline] (307.339 ms) : 0, 307339
GlobalTracer [candidate] (307.235 ms) : 0, 307235
AppSec [baseline] (51.122 ms) : 0, 51122
AppSec [candidate] (51.006 ms) : 0, 51006
Remote Config [baseline] (692.359 µs) : 0, 692
Remote Config [candidate] (692.679 µs) : 0, 693
Telemetry [baseline] (7.566 ms) : 0, 7566
Telemetry [candidate] (7.575 ms) : 0, 7575
section appsec
BytebuddyAgent [baseline] (678.497 ms) : 0, 678497
BytebuddyAgent [candidate] (680.376 ms) : 0, 680376
GlobalTracer [baseline] (300.31 ms) : 0, 300310
GlobalTracer [candidate] (301.16 ms) : 0, 301160
AppSec [baseline] (156.605 ms) : 0, 156605
AppSec [candidate] (156.83 ms) : 0, 156830
Remote Config [baseline] (603.446 µs) : 0, 603
Remote Config [candidate] (607.721 µs) : 0, 608
Telemetry [baseline] (9.392 ms) : 0, 9392
Telemetry [candidate] (9.032 ms) : 0, 9032
IAST [baseline] (20.838 ms) : 0, 20838
IAST [candidate] (20.923 ms) : 0, 20923
section iast
BytebuddyAgent [baseline] (781.102 ms) : 0, 781102
BytebuddyAgent [candidate] (782.373 ms) : 0, 782373
GlobalTracer [baseline] (296.605 ms) : 0, 296605
GlobalTracer [candidate] (297.339 ms) : 0, 297339
AppSec [baseline] (53.286 ms) : 0, 53286
AppSec [candidate] (51.598 ms) : 0, 51598
Remote Config [baseline] (572.553 µs) : 0, 573
Remote Config [candidate] (590.807 µs) : 0, 591
Telemetry [baseline] (8.771 ms) : 0, 8771
Telemetry [candidate] (8.883 ms) : 0, 8883
IAST [baseline] (20.705 ms) : 0, 20705
IAST [candidate] (22.466 ms) : 0, 22466
section profiling
BytebuddyAgent [baseline] (663.546 ms) : 0, 663546
BytebuddyAgent [candidate] (664.174 ms) : 0, 664174
GlobalTracer [baseline] (389.686 ms) : 0, 389686
GlobalTracer [candidate] (392.253 ms) : 0, 392253
AppSec [baseline] (52.614 ms) : 0, 52614
AppSec [candidate] (52.268 ms) : 0, 52268
Remote Config [baseline] (688.284 µs) : 0, 688
Remote Config [candidate] (671.964 µs) : 0, 672
Telemetry [baseline] (7.407 ms) : 0, 7407
Telemetry [candidate] (7.394 ms) : 0, 7394
ProfilingAgent [baseline] (95.315 ms) : 0, 95315
ProfilingAgent [candidate] (94.791 ms) : 0, 94791
Profiling [baseline] (95.339 ms) : 0, 95339
Profiling [candidate] (94.816 ms) : 0, 94816
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~11fa41acaa, baseline=1.39.0-SNAPSHOT~0e0a715784
dateFormat X
axisFormat %s
section baseline
no_agent (1.344 ms) : 1325, 1364
. : milestone, 1344,
appsec (1.72 ms) : 1698, 1743
. : milestone, 1720,
appsec_no_iast (1.723 ms) : 1699, 1747
. : milestone, 1723,
iast (1.473 ms) : 1451, 1496
. : milestone, 1473,
profiling (1.524 ms) : 1498, 1550
. : milestone, 1524,
tracing (1.478 ms) : 1454, 1503
. : milestone, 1478,
section candidate
no_agent (1.324 ms) : 1305, 1344
. : milestone, 1324,
appsec (1.732 ms) : 1709, 1756
. : milestone, 1732,
appsec_no_iast (1.728 ms) : 1705, 1752
. : milestone, 1728,
iast (1.479 ms) : 1456, 1502
. : milestone, 1479,
profiling (1.491 ms) : 1467, 1516
. : milestone, 1491,
tracing (1.464 ms) : 1440, 1488
. : milestone, 1464,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~11fa41acaa, baseline=1.39.0-SNAPSHOT~0e0a715784
dateFormat X
axisFormat %s
section baseline
no_agent (371.512 µs) : 352, 391
. : milestone, 372,
iast (480.448 µs) : 459, 502
. : milestone, 480,
iast_FULL (554.945 µs) : 532, 578
. : milestone, 555,
iast_GLOBAL (518.151 µs) : 496, 540
. : milestone, 518,
iast_HARDCODED_SECRET_DISABLED (485.617 µs) : 464, 507
. : milestone, 486,
iast_INACTIVE (458.451 µs) : 436, 481
. : milestone, 458,
iast_TELEMETRY_OFF (472.028 µs) : 451, 493
. : milestone, 472,
tracing (435.83 µs) : 416, 456
. : milestone, 436,
section candidate
no_agent (366.757 µs) : 347, 386
. : milestone, 367,
iast (478.4 µs) : 457, 500
. : milestone, 478,
iast_FULL (551.264 µs) : 529, 573
. : milestone, 551,
iast_GLOBAL (513.799 µs) : 491, 537
. : milestone, 514,
iast_HARDCODED_SECRET_DISABLED (487.741 µs) : 466, 509
. : milestone, 488,
iast_INACTIVE (454.358 µs) : 432, 477
. : milestone, 454,
iast_TELEMETRY_OFF (472.227 µs) : 451, 494
. : milestone, 472,
tracing (442.589 µs) : 422, 463
. : milestone, 443,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~11fa41acaa, baseline=1.39.0-SNAPSHOT~0e0a715784
dateFormat X
axisFormat %s
section baseline
no_agent (15.371 s) : 15371000, 15371000
. : milestone, 15371000,
appsec (15.182 s) : 15182000, 15182000
. : milestone, 15182000,
iast (18.635 s) : 18635000, 18635000
. : milestone, 18635000,
iast_GLOBAL (17.97 s) : 17970000, 17970000
. : milestone, 17970000,
profiling (15.199 s) : 15199000, 15199000
. : milestone, 15199000,
tracing (15.127 s) : 15127000, 15127000
. : milestone, 15127000,
section candidate
no_agent (14.996 s) : 14996000, 14996000
. : milestone, 14996000,
appsec (15.124 s) : 15124000, 15124000
. : milestone, 15124000,
iast (18.795 s) : 18795000, 18795000
. : milestone, 18795000,
iast_GLOBAL (17.76 s) : 17760000, 17760000
. : milestone, 17760000,
profiling (15.718 s) : 15718000, 15718000
. : milestone, 15718000,
tracing (15.127 s) : 15127000, 15127000
. : milestone, 15127000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~11fa41acaa, baseline=1.39.0-SNAPSHOT~0e0a715784
dateFormat X
axisFormat %s
section baseline
no_agent (1.459 ms) : 1447, 1470
. : milestone, 1459,
appsec (2.215 ms) : 2180, 2249
. : milestone, 2215,
iast (1.959 ms) : 1917, 2000
. : milestone, 1959,
iast_GLOBAL (2.004 ms) : 1962, 2047
. : milestone, 2004,
profiling (1.855 ms) : 1821, 1889
. : milestone, 1855,
tracing (1.835 ms) : 1802, 1868
. : milestone, 1835,
section candidate
no_agent (1.459 ms) : 1447, 1470
. : milestone, 1459,
appsec (2.211 ms) : 2175, 2247
. : milestone, 2211,
iast (1.978 ms) : 1936, 2021
. : milestone, 1978,
iast_GLOBAL (2.009 ms) : 1966, 2052
. : milestone, 2009,
profiling (1.862 ms) : 1827, 1898
. : milestone, 1862,
tracing (1.838 ms) : 1805, 1871
. : milestone, 1838,
|
mcculls
approved these changes
Aug 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Reduce maximum number of unique telemetry logs per minute from 1024 to 10.
Motivation
This is plenty for most organizations and services, while it keeps misbehaving services under control.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issue[ ] Update the public documentation in case of new configuration flag or behaviorJira ticket: APPSEC-53432 (partially)