Skip to content

Fix ClassNotFoundException: net.jpountz.lz4.LZ4JavaSafeCompressor when instrumenting Kafka 3.7 with Quarkus native#7404

Merged
mcculls merged 1 commit intomasterfrom
mcculls/relocate-embedded-jpountz-classes
Aug 9, 2024
Merged

Fix ClassNotFoundException: net.jpountz.lz4.LZ4JavaSafeCompressor when instrumenting Kafka 3.7 with Quarkus native#7404
mcculls merged 1 commit intomasterfrom
mcculls/relocate-embedded-jpountz-classes

Conversation

@mcculls
Copy link
Copy Markdown
Contributor

@mcculls mcculls commented Aug 9, 2024 •
edited by atlassian Bot
Loading

What Does This Do

Relocate embedded jpountz classes to avoid conflict with flat class-path when using GraalVM native-images.

In this case both the Java tracer and Kafka 3.7 contained net.jpountz LZ4 classes at slightly different versions.

Jira ticket: APMS-12871

@mcculls mcculls added the comp: native-image GraalVM native-image label Aug 9, 2024
@mcculls mcculls mentioned this pull request Aug 9, 2024
Closed
@mcculls mcculls marked this pull request as ready for review August 9, 2024 01:09
@mcculls mcculls requested a review from a team as a code owner August 9, 2024 01:09
@mcculls mcculls requested review from dougqh and ygree August 9, 2024 01:09
@mcculls mcculls enabled auto-merge (squash) August 9, 2024 01:19
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Aug 9, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/relocate-embedded-jpountz-classes
git_commit_date 1723137935 1723164218
git_commit_sha bec85d9 de920b4
release_version 1.39.0-SNAPSHOT~bec85d9b82 1.39.0-SNAPSHOT~de920b4469
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1723166866 1723166866
ci_job_id 599686377 599686377
ci_pipeline_id 41298030 41298030
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 18 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~de920b4469, baseline=1.39.0-SNAPSHOT~bec85d9b82

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1046461
Total [baseline] (10.313 s) : 0, 10312857
Agent [candidate] (1.055 s) : 0, 1054648
Total [candidate] (10.298 s) : 0, 10298482
section appsec
Agent [baseline] (1.169 s) : 0, 1168934
Total [baseline] (10.514 s) : 0, 10514394
Agent [candidate] (1.172 s) : 0, 1171770
Total [candidate] (10.463 s) : 0, 10462674
section iast
Agent [baseline] (1.182 s) : 0, 1181921
Total [baseline] (10.74 s) : 0, 10740122
Agent [candidate] (1.185 s) : 0, 1185226
Total [candidate] (10.827 s) : 0, 10827000
section profiling
Agent [baseline] (1.246 s) : 0, 1245733
Total [baseline] (10.562 s) : 0, 10562178
Agent [candidate] (1.255 s) : 0, 1254661
Total [candidate] (10.639 s) : 0, 10639268
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.046 s -
Agent appsec 1.169 s 122.473 ms (11.7%)
Agent iast 1.182 s 135.461 ms (12.9%)
Agent profiling 1.246 s 199.272 ms (19.0%)
Total tracing 10.313 s -
Total appsec 10.514 s 201.536 ms (2.0%)
Total iast 10.74 s 427.265 ms (4.1%)
Total profiling 10.562 s 249.321 ms (2.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.055 s -
Agent appsec 1.172 s 117.123 ms (11.1%)
Agent iast 1.185 s 130.578 ms (12.4%)
Agent profiling 1.255 s 200.014 ms (19.0%)
Total tracing 10.298 s -
Total appsec 10.463 s 164.192 ms (1.6%)
Total iast 10.827 s 528.518 ms (5.1%)
Total profiling 10.639 s 340.786 ms (3.3%) 
gantt
    title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~de920b4469, baseline=1.39.0-SNAPSHOT~bec85d9b82

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (668.058 ms) : 0, 668058
BytebuddyAgent [candidate] (673.569 ms) : 0, 673569
GlobalTracer [baseline] (306.646 ms) : 0, 306646
GlobalTracer [candidate] (308.946 ms) : 0, 308946
AppSec [baseline] (50.343 ms) : 0, 50343
AppSec [candidate] (50.526 ms) : 0, 50526
Remote Config [baseline] (693.048 µs) : 0, 693
Remote Config [candidate] (696.597 µs) : 0, 697
Telemetry [baseline] (7.295 ms) : 0, 7295
Telemetry [candidate] (7.366 ms) : 0, 7366
section appsec
BytebuddyAgent [baseline] (679.52 ms) : 0, 679520
BytebuddyAgent [candidate] (681.384 ms) : 0, 681384
GlobalTracer [baseline] (300.254 ms) : 0, 300254
GlobalTracer [candidate] (301.464 ms) : 0, 301464
AppSec [baseline] (155.491 ms) : 0, 155491
AppSec [candidate] (155.45 ms) : 0, 155450
Remote Config [baseline] (599.755 µs) : 0, 600
Remote Config [candidate] (606.57 µs) : 0, 607
Telemetry [baseline] (7.871 ms) : 0, 7871
Telemetry [candidate] (8.574 ms) : 0, 8574
IAST [baseline] (23.398 ms) : 0, 23398
IAST [candidate] (21.462 ms) : 0, 21462
section iast
BytebuddyAgent [baseline] (787.237 ms) : 0, 787237
BytebuddyAgent [candidate] (789.973 ms) : 0, 789973
GlobalTracer [baseline] (297.75 ms) : 0, 297750
GlobalTracer [candidate] (298.562 ms) : 0, 298562
AppSec [baseline] (51.718 ms) : 0, 51718
AppSec [candidate] (51.964 ms) : 0, 51964
Remote Config [baseline] (579.426 µs) : 0, 579
Remote Config [candidate] (580.14 µs) : 0, 580
Telemetry [baseline] (7.711 ms) : 0, 7711
Telemetry [candidate] (6.987 ms) : 0, 6987
IAST [baseline] (23.375 ms) : 0, 23375
IAST [candidate] (23.521 ms) : 0, 23521
section profiling
BytebuddyAgent [baseline] (664.254 ms) : 0, 664254
BytebuddyAgent [candidate] (668.801 ms) : 0, 668801
GlobalTracer [baseline] (390.842 ms) : 0, 390842
GlobalTracer [candidate] (393.755 ms) : 0, 393755
AppSec [baseline] (51.262 ms) : 0, 51262
AppSec [candidate] (52.007 ms) : 0, 52007
Remote Config [baseline] (696.453 µs) : 0, 696
Remote Config [candidate] (707.607 µs) : 0, 708
Telemetry [baseline] (7.164 ms) : 0, 7164
Telemetry [candidate] (7.257 ms) : 0, 7257
ProfilingAgent [baseline] (94.365 ms) : 0, 94365
ProfilingAgent [candidate] (94.689 ms) : 0, 94689
Profiling [baseline] (94.39 ms) : 0, 94390
Profiling [candidate] (94.714 ms) : 0, 94714
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~de920b4469, baseline=1.39.0-SNAPSHOT~bec85d9b82

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1049623
Total [baseline] (8.509 s) : 0, 8509077
Agent [candidate] (1.046 s) : 0, 1045501
Total [candidate] (8.478 s) : 0, 8477979
section iast
Agent [baseline] (1.183 s) : 0, 1183283
Total [baseline] (8.991 s) : 0, 8990502
Agent [candidate] (1.185 s) : 0, 1185157
Total [candidate] (9.005 s) : 0, 9005344
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.194 s) : 0, 1193968
Total [baseline] (9.076 s) : 0, 9076199
Agent [candidate] (1.175 s) : 0, 1174592
Total [candidate] (8.959 s) : 0, 8958676
section iast_TELEMETRY_OFF
Agent [baseline] (1.173 s) : 0, 1172715
Total [baseline] (8.975 s) : 0, 8975281
Agent [candidate] (1.173 s) : 0, 1172768
Total [candidate] (8.988 s) : 0, 8988396
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.05 s -
Agent iast 1.183 s 133.66 ms (12.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.194 s 144.346 ms (13.8%)
Agent iast_TELEMETRY_OFF 1.173 s 123.093 ms (11.7%)
Total tracing 8.509 s -
Total iast 8.991 s 481.425 ms (5.7%)
Total iast_HARDCODED_SECRET_DISABLED 9.076 s 567.122 ms (6.7%)
Total iast_TELEMETRY_OFF 8.975 s 466.204 ms (5.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.046 s -
Agent iast 1.185 s 139.657 ms (13.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.175 s 129.091 ms (12.3%)
Agent iast_TELEMETRY_OFF 1.173 s 127.267 ms (12.2%)
Total tracing 8.478 s -
Total iast 9.005 s 527.365 ms (6.2%)
Total iast_HARDCODED_SECRET_DISABLED 8.959 s 480.698 ms (5.7%)
Total iast_TELEMETRY_OFF 8.988 s 510.417 ms (6.0%) 
gantt
    title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~de920b4469, baseline=1.39.0-SNAPSHOT~bec85d9b82

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (669.793 ms) : 0, 669793
BytebuddyAgent [candidate] (667.278 ms) : 0, 667278
GlobalTracer [baseline] (307.792 ms) : 0, 307792
GlobalTracer [candidate] (306.723 ms) : 0, 306723
AppSec [baseline] (50.511 ms) : 0, 50511
AppSec [candidate] (50.126 ms) : 0, 50126
Remote Config [baseline] (699.001 µs) : 0, 699
Remote Config [candidate] (680.039 µs) : 0, 680
Telemetry [baseline] (7.384 ms) : 0, 7384
Telemetry [candidate] (7.28 ms) : 0, 7280
section iast
BytebuddyAgent [baseline] (788.019 ms) : 0, 788019
BytebuddyAgent [candidate] (789.891 ms) : 0, 789891
GlobalTracer [baseline] (298.115 ms) : 0, 298115
GlobalTracer [candidate] (298.954 ms) : 0, 298954
AppSec [baseline] (51.639 ms) : 0, 51639
AppSec [candidate] (52.614 ms) : 0, 52614
IAST [baseline] (23.61 ms) : 0, 23610
IAST [candidate] (21.69 ms) : 0, 21690
Remote Config [baseline] (580.274 µs) : 0, 580
Remote Config [candidate] (597.281 µs) : 0, 597
Telemetry [baseline] (7.772 ms) : 0, 7772
Telemetry [candidate] (7.805 ms) : 0, 7805
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (795.764 ms) : 0, 795764
BytebuddyAgent [candidate] (781.345 ms) : 0, 781345
GlobalTracer [baseline] (300.693 ms) : 0, 300693
GlobalTracer [candidate] (297.184 ms) : 0, 297184
AppSec [baseline] (50.843 ms) : 0, 50843
AppSec [candidate] (50.933 ms) : 0, 50933
IAST [baseline] (23.613 ms) : 0, 23613
IAST [candidate] (23.992 ms) : 0, 23992
Remote Config [baseline] (596.457 µs) : 0, 596
Remote Config [candidate] (597.342 µs) : 0, 597
Telemetry [baseline] (8.753 ms) : 0, 8753
Telemetry [candidate] (6.987 ms) : 0, 6987
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (780.088 ms) : 0, 780088
BytebuddyAgent [candidate] (779.96 ms) : 0, 779960
GlobalTracer [baseline] (296.694 ms) : 0, 296694
GlobalTracer [candidate] (297.311 ms) : 0, 297311
AppSec [baseline] (49.529 ms) : 0, 49529
AppSec [candidate] (46.751 ms) : 0, 46751
IAST [baseline] (24.567 ms) : 0, 24567
IAST [candidate] (27.74 ms) : 0, 27740
Remote Config [baseline] (616.349 µs) : 0, 616
Remote Config [candidate] (599.006 µs) : 0, 599
Telemetry [baseline] (7.731 ms) : 0, 7731
Telemetry [candidate] (6.901 ms) : 0, 6901
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-08-09T01:00:47 2024-08-09T01:07:35
git_branch master mcculls/relocate-embedded-jpountz-classes
git_commit_date 1723137935 1723164218
git_commit_sha bec85d9 de920b4
release_version 1.39.0-SNAPSHOT~bec85d9b82 1.39.0-SNAPSHOT~de920b4469
start_time 2024-08-09T01:00:34 2024-08-09T01:07:22
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1723165998 1723165998
ci_job_id 599686378 599686378
ci_pipeline_id 41298030 41298030
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~de920b4469, baseline=1.39.0-SNAPSHOT~bec85d9b82
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.326 ms) : 1307, 1345
.   : milestone, 1326,
appsec (1.72 ms) : 1697, 1744
.   : milestone, 1720,
appsec_no_iast (1.695 ms) : 1670, 1720
.   : milestone, 1695,
iast (1.474 ms) : 1452, 1497
.   : milestone, 1474,
profiling (1.548 ms) : 1522, 1574
.   : milestone, 1548,
tracing (1.457 ms) : 1433, 1481
.   : milestone, 1457,
section candidate
no_agent (1.346 ms) : 1326, 1366
.   : milestone, 1346,
appsec (1.692 ms) : 1668, 1717
.   : milestone, 1692,
appsec_no_iast (1.704 ms) : 1679, 1729
.   : milestone, 1704,
iast (1.464 ms) : 1442, 1487
.   : milestone, 1464,
profiling (1.516 ms) : 1490, 1543
.   : milestone, 1516,
tracing (1.424 ms) : 1400, 1449
.   : milestone, 1424,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.326 ms [1.307 ms, 1.345 ms] -
appsec 1.72 ms [1.697 ms, 1.744 ms] 394.332 µs (29.7%)
appsec_no_iast 1.695 ms [1.67 ms, 1.72 ms] 369.066 µs (27.8%)
iast 1.474 ms [1.452 ms, 1.497 ms] 148.499 µs (11.2%)
profiling 1.548 ms [1.522 ms, 1.574 ms] 221.952 µs (16.7%)
tracing 1.457 ms [1.433 ms, 1.481 ms] 131.194 µs (9.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.346 ms [1.326 ms, 1.366 ms] -
appsec 1.692 ms [1.668 ms, 1.717 ms] 346.599 µs (25.8%)
appsec_no_iast 1.704 ms [1.679 ms, 1.729 ms] 357.767 µs (26.6%)
iast 1.464 ms [1.442 ms, 1.487 ms] 118.318 µs (8.8%)
profiling 1.516 ms [1.49 ms, 1.543 ms] 170.505 µs (12.7%)
tracing 1.424 ms [1.4 ms, 1.449 ms] 78.297 µs (5.8%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~de920b4469, baseline=1.39.0-SNAPSHOT~bec85d9b82
    dateFormat X
    axisFormat %s
section baseline
no_agent (367.507 µs) : 345, 390
.   : milestone, 368,
iast (473.788 µs) : 452, 495
.   : milestone, 474,
iast_FULL (544.53 µs) : 523, 566
.   : milestone, 545,
iast_GLOBAL (499.505 µs) : 478, 521
.   : milestone, 500,
iast_HARDCODED_SECRET_DISABLED (482.438 µs) : 461, 504
.   : milestone, 482,
iast_INACTIVE (444.977 µs) : 424, 466
.   : milestone, 445,
iast_TELEMETRY_OFF (473.007 µs) : 452, 494
.   : milestone, 473,
tracing (433.238 µs) : 412, 454
.   : milestone, 433,
section candidate
no_agent (362.447 µs) : 343, 382
.   : milestone, 362,
iast (482.69 µs) : 461, 505
.   : milestone, 483,
iast_FULL (550.798 µs) : 530, 572
.   : milestone, 551,
iast_GLOBAL (509.194 µs) : 486, 533
.   : milestone, 509,
iast_HARDCODED_SECRET_DISABLED (470.53 µs) : 450, 491
.   : milestone, 471,
iast_INACTIVE (441.909 µs) : 420, 463
.   : milestone, 442,
iast_TELEMETRY_OFF (468.793 µs) : 448, 490
.   : milestone, 469,
tracing (444.431 µs) : 423, 466
.   : milestone, 444,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 367.507 µs [344.781 µs, 390.234 µs] -
iast 473.788 µs [452.316 µs, 495.261 µs] 106.281 µs (28.9%)
iast_FULL 544.53 µs [523.346 µs, 565.715 µs] 177.023 µs (48.2%)
iast_GLOBAL 499.505 µs [478.422 µs, 520.589 µs] 131.998 µs (35.9%)
iast_HARDCODED_SECRET_DISABLED 482.438 µs [460.779 µs, 504.097 µs] 114.931 µs (31.3%)
iast_INACTIVE 444.977 µs [423.738 µs, 466.217 µs] 77.47 µs (21.1%)
iast_TELEMETRY_OFF 473.007 µs [451.673 µs, 494.341 µs] 105.5 µs (28.7%)
tracing 433.238 µs [412.148 µs, 454.329 µs] 65.731 µs (17.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 362.447 µs [343.02 µs, 381.874 µs] -
iast 482.69 µs [460.783 µs, 504.597 µs] 120.243 µs (33.2%)
iast_FULL 550.798 µs [529.667 µs, 571.928 µs] 188.351 µs (52.0%)
iast_GLOBAL 509.194 µs [485.68 µs, 532.709 µs] 146.748 µs (40.5%)
iast_HARDCODED_SECRET_DISABLED 470.53 µs [449.821 µs, 491.239 µs] 108.083 µs (29.8%)
iast_INACTIVE 441.909 µs [420.494 µs, 463.323 µs] 79.462 µs (21.9%)
iast_TELEMETRY_OFF 468.793 µs [447.587 µs, 489.999 µs] 106.346 µs (29.3%)
tracing 444.431 µs [422.864 µs, 465.998 µs] 81.984 µs (22.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/relocate-embedded-jpountz-classes
git_commit_date 1723137935 1723164218
git_commit_sha bec85d9 de920b4
release_version 1.39.0-SNAPSHOT~bec85d9b82 1.39.0-SNAPSHOT~de920b4469
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1723166508 1723166508
ci_job_id 599686379 599686379
ci_pipeline_id 41298030 41298030
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~de920b4469, baseline=1.39.0-SNAPSHOT~bec85d9b82
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.019 s) : 15019000, 15019000
.   : milestone, 15019000,
appsec (15.167 s) : 15167000, 15167000
.   : milestone, 15167000,
iast (18.828 s) : 18828000, 18828000
.   : milestone, 18828000,
iast_GLOBAL (17.834 s) : 17834000, 17834000
.   : milestone, 17834000,
profiling (15.717 s) : 15717000, 15717000
.   : milestone, 15717000,
tracing (14.99 s) : 14990000, 14990000
.   : milestone, 14990000,
section candidate
no_agent (15.043 s) : 15043000, 15043000
.   : milestone, 15043000,
appsec (15.069 s) : 15069000, 15069000
.   : milestone, 15069000,
iast (18.744 s) : 18744000, 18744000
.   : milestone, 18744000,
iast_GLOBAL (17.728 s) : 17728000, 17728000
.   : milestone, 17728000,
profiling (15.291 s) : 15291000, 15291000
.   : milestone, 15291000,
tracing (15.057 s) : 15057000, 15057000
.   : milestone, 15057000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.019 s [15.019 s, 15.019 s] -
appsec 15.167 s [15.167 s, 15.167 s] 148.0 ms (1.0%)
iast 18.828 s [18.828 s, 18.828 s] 3.809 s (25.4%)
iast_GLOBAL 17.834 s [17.834 s, 17.834 s] 2.815 s (18.7%)
profiling 15.717 s [15.717 s, 15.717 s] 698.0 ms (4.6%)
tracing 14.99 s [14.99 s, 14.99 s] -29.0 ms (-0.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.043 s [15.043 s, 15.043 s] -
appsec 15.069 s [15.069 s, 15.069 s] 26.0 ms (0.2%)
iast 18.744 s [18.744 s, 18.744 s] 3.701 s (24.6%)
iast_GLOBAL 17.728 s [17.728 s, 17.728 s] 2.685 s (17.8%)
profiling 15.291 s [15.291 s, 15.291 s] 248.0 ms (1.6%)
tracing 15.057 s [15.057 s, 15.057 s] 14.0 ms (0.1%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~de920b4469, baseline=1.39.0-SNAPSHOT~bec85d9b82
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.46 ms) : 1449, 1471
.   : milestone, 1460,
appsec (2.226 ms) : 2191, 2262
.   : milestone, 2226,
iast (1.979 ms) : 1937, 2021
.   : milestone, 1979,
iast_GLOBAL (2.018 ms) : 1975, 2061
.   : milestone, 2018,
profiling (1.857 ms) : 1823, 1891
.   : milestone, 1857,
tracing (1.828 ms) : 1796, 1860
.   : milestone, 1828,
section candidate
no_agent (1.464 ms) : 1452, 1475
.   : milestone, 1464,
appsec (2.215 ms) : 2180, 2250
.   : milestone, 2215,
iast (1.963 ms) : 1921, 2005
.   : milestone, 1963,
iast_GLOBAL (2.018 ms) : 1975, 2062
.   : milestone, 2018,
profiling (1.849 ms) : 1814, 1884
.   : milestone, 1849,
tracing (1.839 ms) : 1806, 1871
.   : milestone, 1839,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.46 ms [1.449 ms, 1.471 ms] -
appsec 2.226 ms [2.191 ms, 2.262 ms] 766.2 µs (52.5%)
iast 1.979 ms [1.937 ms, 2.021 ms] 518.686 µs (35.5%)
iast_GLOBAL 2.018 ms [1.975 ms, 2.061 ms] 557.801 µs (38.2%)
profiling 1.857 ms [1.823 ms, 1.891 ms] 397.06 µs (27.2%)
tracing 1.828 ms [1.796 ms, 1.86 ms] 368.024 µs (25.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.464 ms [1.452 ms, 1.475 ms] -
appsec 2.215 ms [2.18 ms, 2.25 ms] 751.632 µs (51.4%)
iast 1.963 ms [1.921 ms, 2.005 ms] 498.995 µs (34.1%)
iast_GLOBAL 2.018 ms [1.975 ms, 2.062 ms] 554.602 µs (37.9%)
profiling 1.849 ms [1.814 ms, 1.884 ms] 385.117 µs (26.3%)
tracing 1.839 ms [1.806 ms, 1.871 ms] 375.154 µs (25.6%)

PerfectSlayer
PerfectSlayer approved these changes Aug 9, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mcculls mcculls merged commit deba36c into master Aug 9, 2024
@mcculls mcculls deleted the mcculls/relocate-embedded-jpountz-classes branch August 9, 2024 05:37
@github-actions github-actions Bot added this to the 1.39.0 milestone Aug 9, 2024
@PerfectSlayer PerfectSlayer mentioned this pull request Aug 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@dougqh dougqh Awaiting requested review from dougqh dougqh is a code owner automatically assigned from DataDog/apm-java

@ygree ygree Awaiting requested review from ygree ygree is a code owner automatically assigned from DataDog/apm-java

+1 more reviewer

@luneo7 luneo7 luneo7 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

comp: native-image GraalVM native-image

Projects

None yet

Milestone

1.39.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mcculls @PerfectSlayer @luneo7