Skip to content

Remove unused arguments and methods from async AdviceUtils#7397

Merged
mcculls merged 1 commit intomasterfrom
mcculls/cleanup-async-utils
Aug 13, 2024
Merged

Remove unused arguments and methods from async AdviceUtils#7397
mcculls merged 1 commit intomasterfrom
mcculls/cleanup-async-utils

Conversation

@mcculls
Copy link
Copy Markdown
Contributor

@mcculls mcculls commented Aug 7, 2024

No description provided.

@mcculls mcculls added tag: no release notes Changes to exclude from release notes type: refactoring labels Aug 7, 2024
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Aug 7, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/cleanup-async-utils
git_commit_date 1723545115 1723547125
git_commit_sha 7172606 f7a83d7
release_version 1.39.0-SNAPSHOT~7172606b27 1.39.0-SNAPSHOT~f7a83d769b
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1723549494 1723549494
ci_job_id 603080275 603080275
ci_pipeline_id 41577627 41577627
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 17 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~f7a83d769b, baseline=1.39.0-SNAPSHOT~7172606b27

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1046056
Total [baseline] (8.49 s) : 0, 8490056
Agent [candidate] (1.054 s) : 0, 1053964
Total [candidate] (8.51 s) : 0, 8509974
section iast
Agent [baseline] (1.192 s) : 0, 1191968
Total [baseline] (9.026 s) : 0, 9025577
Agent [candidate] (1.175 s) : 0, 1175270
Total [candidate] (8.97 s) : 0, 8970100
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.178 s) : 0, 1177881
Total [baseline] (8.964 s) : 0, 8963736
Agent [candidate] (1.176 s) : 0, 1176239
Total [candidate] (8.963 s) : 0, 8962616
section iast_TELEMETRY_OFF
Agent [baseline] (1.188 s) : 0, 1187702
Total [baseline] (9.025 s) : 0, 9025489
Agent [candidate] (1.18 s) : 0, 1180027
Total [candidate] (9.01 s) : 0, 9010391
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.046 s -
Agent iast 1.192 s 145.912 ms (13.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.178 s 131.825 ms (12.6%)
Agent iast_TELEMETRY_OFF 1.188 s 141.647 ms (13.5%)
Total tracing 8.49 s -
Total iast 9.026 s 535.521 ms (6.3%)
Total iast_HARDCODED_SECRET_DISABLED 8.964 s 473.68 ms (5.6%)
Total iast_TELEMETRY_OFF 9.025 s 535.433 ms (6.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.054 s -
Agent iast 1.175 s 121.306 ms (11.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.176 s 122.275 ms (11.6%)
Agent iast_TELEMETRY_OFF 1.18 s 126.063 ms (12.0%)
Total tracing 8.51 s -
Total iast 8.97 s 460.126 ms (5.4%)
Total iast_HARDCODED_SECRET_DISABLED 8.963 s 452.642 ms (5.3%)
Total iast_TELEMETRY_OFF 9.01 s 500.418 ms (5.9%) 
gantt
    title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~f7a83d769b, baseline=1.39.0-SNAPSHOT~7172606b27

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (666.956 ms) : 0, 666956
BytebuddyAgent [candidate] (672.171 ms) : 0, 672171
GlobalTracer [baseline] (306.542 ms) : 0, 306542
GlobalTracer [candidate] (308.692 ms) : 0, 308692
AppSec [baseline] (50.931 ms) : 0, 50931
AppSec [candidate] (51.346 ms) : 0, 51346
Remote Config [baseline] (693.271 µs) : 0, 693
Remote Config [candidate] (685.482 µs) : 0, 685
Telemetry [baseline] (7.529 ms) : 0, 7529
Telemetry [candidate] (7.551 ms) : 0, 7551
section iast
BytebuddyAgent [baseline] (793.864 ms) : 0, 793864
BytebuddyAgent [candidate] (782.578 ms) : 0, 782578
GlobalTracer [baseline] (299.992 ms) : 0, 299992
GlobalTracer [candidate] (296.862 ms) : 0, 296862
AppSec [baseline] (52.247 ms) : 0, 52247
AppSec [candidate] (51.195 ms) : 0, 51195
IAST [baseline] (22.818 ms) : 0, 22818
IAST [candidate] (20.964 ms) : 0, 20964
Remote Config [baseline] (583.39 µs) : 0, 583
Remote Config [candidate] (599.358 µs) : 0, 599
Telemetry [baseline] (8.838 ms) : 0, 8838
Telemetry [candidate] (9.575 ms) : 0, 9575
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (783.383 ms) : 0, 783383
BytebuddyAgent [candidate] (782.142 ms) : 0, 782142
GlobalTracer [baseline] (297.331 ms) : 0, 297331
GlobalTracer [candidate] (296.798 ms) : 0, 296798
AppSec [baseline] (53.499 ms) : 0, 53499
AppSec [candidate] (50.167 ms) : 0, 50167
IAST [baseline] (20.756 ms) : 0, 20756
IAST [candidate] (22.642 ms) : 0, 22642
Remote Config [baseline] (577.02 µs) : 0, 577
Remote Config [candidate] (586.873 µs) : 0, 587
Telemetry [baseline] (8.79 ms) : 0, 8790
Telemetry [candidate] (10.384 ms) : 0, 10384
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (789.715 ms) : 0, 789715
BytebuddyAgent [candidate] (782.792 ms) : 0, 782792
GlobalTracer [baseline] (300.027 ms) : 0, 300027
GlobalTracer [candidate] (300.6 ms) : 0, 300600
AppSec [baseline] (53.056 ms) : 0, 53056
AppSec [candidate] (50.331 ms) : 0, 50331
IAST [baseline] (23.42 ms) : 0, 23420
IAST [candidate] (24.907 ms) : 0, 24907
Remote Config [baseline] (626.671 µs) : 0, 627
Remote Config [candidate] (619.694 µs) : 0, 620
Telemetry [baseline] (7.209 ms) : 0, 7209
Telemetry [candidate] (7.245 ms) : 0, 7245
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~f7a83d769b, baseline=1.39.0-SNAPSHOT~7172606b27

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1047463
Total [baseline] (10.381 s) : 0, 10381304
Agent [candidate] (1.047 s) : 0, 1046901
Total [candidate] (10.349 s) : 0, 10348775
section appsec
Agent [baseline] (1.179 s) : 0, 1178839
Total [baseline] (10.515 s) : 0, 10515007
Agent [candidate] (1.167 s) : 0, 1167276
Total [candidate] (10.471 s) : 0, 10470872
section iast
Agent [baseline] (1.194 s) : 0, 1194012
Total [baseline] (10.986 s) : 0, 10985526
Agent [candidate] (1.188 s) : 0, 1187550
Total [candidate] (10.823 s) : 0, 10823235
section profiling
Agent [baseline] (1.247 s) : 0, 1246590
Total [baseline] (10.662 s) : 0, 10662170
Agent [candidate] (1.249 s) : 0, 1248844
Total [candidate] (10.602 s) : 0, 10601874
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.047 s -
Agent appsec 1.179 s 131.377 ms (12.5%)
Agent iast 1.194 s 146.55 ms (14.0%)
Agent profiling 1.247 s 199.128 ms (19.0%)
Total tracing 10.381 s -
Total appsec 10.515 s 133.703 ms (1.3%)
Total iast 10.986 s 604.222 ms (5.8%)
Total profiling 10.662 s 280.866 ms (2.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.047 s -
Agent appsec 1.167 s 120.376 ms (11.5%)
Agent iast 1.188 s 140.65 ms (13.4%)
Agent profiling 1.249 s 201.944 ms (19.3%)
Total tracing 10.349 s -
Total appsec 10.471 s 122.097 ms (1.2%)
Total iast 10.823 s 474.46 ms (4.6%)
Total profiling 10.602 s 253.099 ms (2.4%) 
gantt
    title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~f7a83d769b, baseline=1.39.0-SNAPSHOT~7172606b27

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (667.425 ms) : 0, 667425
BytebuddyAgent [candidate] (667.134 ms) : 0, 667134
GlobalTracer [baseline] (307.552 ms) : 0, 307552
GlobalTracer [candidate] (307.163 ms) : 0, 307163
AppSec [baseline] (50.872 ms) : 0, 50872
AppSec [candidate] (50.992 ms) : 0, 50992
Remote Config [baseline] (686.8 µs) : 0, 687
Remote Config [candidate] (688.327 µs) : 0, 688
Telemetry [baseline] (7.508 ms) : 0, 7508
Telemetry [candidate] (7.486 ms) : 0, 7486
section appsec
BytebuddyAgent [baseline] (683.591 ms) : 0, 683591
BytebuddyAgent [candidate] (677.885 ms) : 0, 677885
GlobalTracer [baseline] (302.423 ms) : 0, 302423
GlobalTracer [candidate] (300.263 ms) : 0, 300263
AppSec [baseline] (157.287 ms) : 0, 157287
AppSec [candidate] (156.52 ms) : 0, 156520
IAST [baseline] (20.844 ms) : 0, 20844
IAST [candidate] (19.531 ms) : 0, 19531
Remote Config [baseline] (608.839 µs) : 0, 609
Remote Config [candidate] (605.929 µs) : 0, 606
Telemetry [baseline] (10.939 ms) : 0, 10939
Telemetry [candidate] (8.74 ms) : 0, 8740
section iast
BytebuddyAgent [baseline] (796.371 ms) : 0, 796371
BytebuddyAgent [candidate] (790.042 ms) : 0, 790042
GlobalTracer [baseline] (300.647 ms) : 0, 300647
GlobalTracer [candidate] (298.843 ms) : 0, 298843
AppSec [baseline] (52.139 ms) : 0, 52139
AppSec [candidate] (53.853 ms) : 0, 53853
IAST [baseline] (23.425 ms) : 0, 23425
IAST [candidate] (22.617 ms) : 0, 22617
Remote Config [baseline] (584.821 µs) : 0, 585
Remote Config [candidate] (581.498 µs) : 0, 581
Telemetry [baseline] (7.161 ms) : 0, 7161
Telemetry [candidate] (7.964 ms) : 0, 7964
section profiling
BytebuddyAgent [baseline] (663.225 ms) : 0, 663225
BytebuddyAgent [candidate] (664.457 ms) : 0, 664457
GlobalTracer [baseline] (391.269 ms) : 0, 391269
GlobalTracer [candidate] (391.671 ms) : 0, 391671
AppSec [baseline] (52.315 ms) : 0, 52315
AppSec [candidate] (52.31 ms) : 0, 52310
Remote Config [baseline] (684.132 µs) : 0, 684
Remote Config [candidate] (710.53 µs) : 0, 711
Telemetry [baseline] (7.421 ms) : 0, 7421
Telemetry [candidate] (7.418 ms) : 0, 7418
ProfilingAgent [baseline] (94.527 ms) : 0, 94527
ProfilingAgent [candidate] (94.978 ms) : 0, 94978
Profiling [baseline] (94.553 ms) : 0, 94553
Profiling [candidate] (95.003 ms) : 0, 95003
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-08-13T11:15:36 2024-08-13T11:22:24
git_branch master mcculls/cleanup-async-utils
git_commit_date 1723545115 1723547125
git_commit_sha 7172606 f7a83d7
release_version 1.39.0-SNAPSHOT~7172606b27 1.39.0-SNAPSHOT~f7a83d769b
start_time 2024-08-13T11:15:23 2024-08-13T11:22:11
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1723548489 1723548489
ci_job_id 603080276 603080276
ci_pipeline_id 41577627 41577627
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~f7a83d769b, baseline=1.39.0-SNAPSHOT~7172606b27
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.334 ms) : 1315, 1354
.   : milestone, 1334,
appsec (1.711 ms) : 1689, 1734
.   : milestone, 1711,
appsec_no_iast (1.702 ms) : 1677, 1726
.   : milestone, 1702,
iast (1.495 ms) : 1473, 1518
.   : milestone, 1495,
profiling (1.483 ms) : 1458, 1507
.   : milestone, 1483,
tracing (1.469 ms) : 1445, 1493
.   : milestone, 1469,
section candidate
no_agent (1.345 ms) : 1326, 1365
.   : milestone, 1345,
appsec (1.713 ms) : 1691, 1735
.   : milestone, 1713,
appsec_no_iast (1.719 ms) : 1695, 1743
.   : milestone, 1719,
iast (1.467 ms) : 1445, 1490
.   : milestone, 1467,
profiling (1.485 ms) : 1460, 1510
.   : milestone, 1485,
tracing (1.47 ms) : 1446, 1493
.   : milestone, 1470,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.334 ms [1.315 ms, 1.354 ms] -
appsec 1.711 ms [1.689 ms, 1.734 ms] 376.973 µs (28.3%)
appsec_no_iast 1.702 ms [1.677 ms, 1.726 ms] 367.319 µs (27.5%)
iast 1.495 ms [1.473 ms, 1.518 ms] 161.073 µs (12.1%)
profiling 1.483 ms [1.458 ms, 1.507 ms] 148.323 µs (11.1%)
tracing 1.469 ms [1.445 ms, 1.493 ms] 134.843 µs (10.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.345 ms [1.326 ms, 1.365 ms] -
appsec 1.713 ms [1.691 ms, 1.735 ms] 367.669 µs (27.3%)
appsec_no_iast 1.719 ms [1.695 ms, 1.743 ms] 373.062 µs (27.7%)
iast 1.467 ms [1.445 ms, 1.49 ms] 121.867 µs (9.1%)
profiling 1.485 ms [1.46 ms, 1.51 ms] 139.622 µs (10.4%)
tracing 1.47 ms [1.446 ms, 1.493 ms] 124.074 µs (9.2%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~f7a83d769b, baseline=1.39.0-SNAPSHOT~7172606b27
    dateFormat X
    axisFormat %s
section baseline
no_agent (372.722 µs) : 353, 393
.   : milestone, 373,
iast (480.657 µs) : 460, 502
.   : milestone, 481,
iast_FULL (557.628 µs) : 535, 581
.   : milestone, 558,
iast_GLOBAL (505.531 µs) : 483, 528
.   : milestone, 506,
iast_HARDCODED_SECRET_DISABLED (481.449 µs) : 460, 503
.   : milestone, 481,
iast_INACTIVE (459.03 µs) : 436, 482
.   : milestone, 459,
iast_TELEMETRY_OFF (470.526 µs) : 449, 492
.   : milestone, 471,
tracing (445.766 µs) : 425, 467
.   : milestone, 446,
section candidate
no_agent (372.34 µs) : 353, 392
.   : milestone, 372,
iast (480.764 µs) : 460, 502
.   : milestone, 481,
iast_FULL (550.43 µs) : 528, 573
.   : milestone, 550,
iast_GLOBAL (514.36 µs) : 492, 537
.   : milestone, 514,
iast_HARDCODED_SECRET_DISABLED (476.279 µs) : 455, 497
.   : milestone, 476,
iast_INACTIVE (451.133 µs) : 429, 473
.   : milestone, 451,
iast_TELEMETRY_OFF (478.577 µs) : 457, 500
.   : milestone, 479,
tracing (432.135 µs) : 412, 452
.   : milestone, 432,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 372.722 µs [352.819 µs, 392.625 µs] -
iast 480.657 µs [459.554 µs, 501.76 µs] 107.936 µs (29.0%)
iast_FULL 557.628 µs [534.632 µs, 580.623 µs] 184.906 µs (49.6%)
iast_GLOBAL 505.531 µs [482.847 µs, 528.214 µs] 132.809 µs (35.6%)
iast_HARDCODED_SECRET_DISABLED 481.449 µs [460.366 µs, 502.533 µs] 108.728 µs (29.2%)
iast_INACTIVE 459.03 µs [436.165 µs, 481.894 µs] 86.308 µs (23.2%)
iast_TELEMETRY_OFF 470.526 µs [449.183 µs, 491.868 µs] 97.804 µs (26.2%)
tracing 445.766 µs [424.708 µs, 466.824 µs] 73.044 µs (19.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 372.34 µs [353.163 µs, 391.517 µs] -
iast 480.764 µs [459.657 µs, 501.87 µs] 108.423 µs (29.1%)
iast_FULL 550.43 µs [527.99 µs, 572.87 µs] 178.09 µs (47.8%)
iast_GLOBAL 514.36 µs [491.754 µs, 536.966 µs] 142.02 µs (38.1%)
iast_HARDCODED_SECRET_DISABLED 476.279 µs [455.325 µs, 497.233 µs] 103.939 µs (27.9%)
iast_INACTIVE 451.133 µs [428.951 µs, 473.314 µs] 78.793 µs (21.2%)
iast_TELEMETRY_OFF 478.577 µs [456.956 µs, 500.198 µs] 106.237 µs (28.5%)
tracing 432.135 µs [412.276 µs, 451.994 µs] 59.795 µs (16.1%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/cleanup-async-utils
git_commit_date 1723545115 1723547125
git_commit_sha 7172606 f7a83d7
release_version 1.39.0-SNAPSHOT~7172606b27 1.39.0-SNAPSHOT~f7a83d769b
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1723549014 1723549014
ci_job_id 603080277 603080277
ci_pipeline_id 41577627 41577627
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~f7a83d769b, baseline=1.39.0-SNAPSHOT~7172606b27
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.462 ms) : 1450, 1473
.   : milestone, 1462,
appsec (2.232 ms) : 2196, 2268
.   : milestone, 2232,
iast (1.983 ms) : 1941, 2025
.   : milestone, 1983,
iast_GLOBAL (2.027 ms) : 1983, 2071
.   : milestone, 2027,
profiling (2.309 ms) : 2134, 2485
.   : milestone, 2309,
tracing (1.837 ms) : 1805, 1870
.   : milestone, 1837,
section candidate
no_agent (1.471 ms) : 1460, 1483
.   : milestone, 1471,
appsec (2.216 ms) : 2181, 2251
.   : milestone, 2216,
iast (1.987 ms) : 1944, 2030
.   : milestone, 1987,
iast_GLOBAL (2.019 ms) : 1976, 2063
.   : milestone, 2019,
profiling (1.874 ms) : 1838, 1909
.   : milestone, 1874,
tracing (1.839 ms) : 1806, 1872
.   : milestone, 1839,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.462 ms [1.45 ms, 1.473 ms] -
appsec 2.232 ms [2.196 ms, 2.268 ms] 770.314 µs (52.7%)
iast 1.983 ms [1.941 ms, 2.025 ms] 521.055 µs (35.6%)
iast_GLOBAL 2.027 ms [1.983 ms, 2.071 ms] 565.471 µs (38.7%)
profiling 2.309 ms [2.134 ms, 2.485 ms] 847.572 µs (58.0%)
tracing 1.837 ms [1.805 ms, 1.87 ms] 375.631 µs (25.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.471 ms [1.46 ms, 1.483 ms] -
appsec 2.216 ms [2.181 ms, 2.251 ms] 744.558 µs (50.6%)
iast 1.987 ms [1.944 ms, 2.03 ms] 515.451 µs (35.0%)
iast_GLOBAL 2.019 ms [1.976 ms, 2.063 ms] 548.237 µs (37.3%)
profiling 1.874 ms [1.838 ms, 1.909 ms] 402.589 µs (27.4%)
tracing 1.839 ms [1.806 ms, 1.872 ms] 368.138 µs (25.0%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~f7a83d769b, baseline=1.39.0-SNAPSHOT~7172606b27
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.055 s) : 15055000, 15055000
.   : milestone, 15055000,
appsec (15.141 s) : 15141000, 15141000
.   : milestone, 15141000,
iast (18.778 s) : 18778000, 18778000
.   : milestone, 18778000,
iast_GLOBAL (17.935 s) : 17935000, 17935000
.   : milestone, 17935000,
profiling (15.233 s) : 15233000, 15233000
.   : milestone, 15233000,
tracing (15.125 s) : 15125000, 15125000
.   : milestone, 15125000,
section candidate
no_agent (15.042 s) : 15042000, 15042000
.   : milestone, 15042000,
appsec (14.962 s) : 14962000, 14962000
.   : milestone, 14962000,
iast (18.379 s) : 18379000, 18379000
.   : milestone, 18379000,
iast_GLOBAL (17.911 s) : 17911000, 17911000
.   : milestone, 17911000,
profiling (15.917 s) : 15917000, 15917000
.   : milestone, 15917000,
tracing (14.777 s) : 14777000, 14777000
.   : milestone, 14777000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.055 s [15.055 s, 15.055 s] -
appsec 15.141 s [15.141 s, 15.141 s] 86.0 ms (0.6%)
iast 18.778 s [18.778 s, 18.778 s] 3.723 s (24.7%)
iast_GLOBAL 17.935 s [17.935 s, 17.935 s] 2.88 s (19.1%)
profiling 15.233 s [15.233 s, 15.233 s] 178.0 ms (1.2%)
tracing 15.125 s [15.125 s, 15.125 s] 70.0 ms (0.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.042 s [15.042 s, 15.042 s] -
appsec 14.962 s [14.962 s, 14.962 s] -80.0 ms (-0.5%)
iast 18.379 s [18.379 s, 18.379 s] 3.337 s (22.2%)
iast_GLOBAL 17.911 s [17.911 s, 17.911 s] 2.869 s (19.1%)
profiling 15.917 s [15.917 s, 15.917 s] 875.0 ms (5.8%)
tracing 14.777 s [14.777 s, 14.777 s] -265.0 ms (-1.8%)

@mcculls mcculls force-pushed the mcculls/cleanup-async-utils branch from d1d4d9d to 7de6782 Compare August 8, 2024 14:08
@mcculls mcculls force-pushed the mcculls/cleanup-async-utils branch from 7de6782 to f7a83d7 Compare August 13, 2024 11:05
@mcculls mcculls marked this pull request as ready for review August 13, 2024 11:06
@mcculls mcculls requested review from a team as code owners August 13, 2024 11:06
PerfectSlayer
PerfectSlayer approved these changes Aug 13, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed it too while working on context.
Thanks for the refactoring 👍

@mcculls mcculls merged commit 22e9fef into master Aug 13, 2024
@mcculls mcculls deleted the mcculls/cleanup-async-utils branch August 13, 2024 13:49
@github-actions github-actions Bot added this to the 1.39.0 milestone Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@nayeem-kamal nayeem-kamal Awaiting requested review from nayeem-kamal nayeem-kamal is a code owner automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Milestone

1.39.0

Development

Successfully merging this pull request may close these issues.

2 participants

@mcculls @PerfectSlayer