Catch invalid patterns exception from dd.data.jobs.command.pattern#7383
Merged
paul-laffon-dd merged 1 commit intomasterfrom Aug 5, 2024
Merged
Conversation
PerfectSlayer
approved these changes
Aug 5, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.38.0-SNAPSHOT~26a24b5efc, baseline=1.38.0-SNAPSHOT~c08dc4f3c9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.544 s) : 0, 1543735
Total [baseline] (11.789 s) : 0, 11788602
Agent [candidate] (1.551 s) : 0, 1551449
Total [candidate] (11.842 s) : 0, 11841658
section iast
Agent [baseline] (1.727 s) : 0, 1727415
Total [baseline] (12.514 s) : 0, 12514037
Agent [candidate] (1.718 s) : 0, 1717925
Total [candidate] (12.508 s) : 0, 12508035
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.724 s) : 0, 1723837
Total [baseline] (12.437 s) : 0, 12437109
Agent [candidate] (1.722 s) : 0, 1721999
Total [candidate] (12.488 s) : 0, 12488004
section iast_TELEMETRY_OFF
Agent [baseline] (1.711 s) : 0, 1710735
Total [baseline] (12.494 s) : 0, 12494362
Agent [candidate] (1.72 s) : 0, 1720294
Total [candidate] (12.514 s) : 0, 12514288
gantt
title insecure-bank - break down per module: candidate=1.38.0-SNAPSHOT~26a24b5efc, baseline=1.38.0-SNAPSHOT~c08dc4f3c9
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (990.219 ms) : 0, 990219
BytebuddyAgent [candidate] (994.225 ms) : 0, 994225
GlobalTracer [baseline] (452.349 ms) : 0, 452349
GlobalTracer [candidate] (455.564 ms) : 0, 455564
AppSec [baseline] (70.861 ms) : 0, 70861
AppSec [candidate] (71.11 ms) : 0, 71110
Remote Config [baseline] (842.429 µs) : 0, 842
Remote Config [candidate] (853.535 µs) : 0, 854
Telemetry [baseline] (9.537 ms) : 0, 9537
Telemetry [candidate] (9.625 ms) : 0, 9625
section iast
BytebuddyAgent [baseline] (1.159 s) : 0, 1158790
BytebuddyAgent [candidate] (1.153 s) : 0, 1152542
GlobalTracer [baseline] (435.597 ms) : 0, 435597
GlobalTracer [candidate] (434.429 ms) : 0, 434429
AppSec [baseline] (72.789 ms) : 0, 72789
AppSec [candidate] (72.869 ms) : 0, 72869
Remote Config [baseline] (859.755 µs) : 0, 860
Remote Config [candidate] (723.241 µs) : 0, 723
Telemetry [baseline] (9.131 ms) : 0, 9131
Telemetry [candidate] (9.047 ms) : 0, 9047
IAST [baseline] (30.134 ms) : 0, 30134
IAST [candidate] (28.24 ms) : 0, 28240
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (1.157 s) : 0, 1156606
BytebuddyAgent [candidate] (1.154 s) : 0, 1154359
GlobalTracer [baseline] (436.466 ms) : 0, 436466
GlobalTracer [candidate] (436.579 ms) : 0, 436579
AppSec [baseline] (69.307 ms) : 0, 69307
AppSec [candidate] (72.498 ms) : 0, 72498
Remote Config [baseline] (757.973 µs) : 0, 758
Remote Config [candidate] (741.901 µs) : 0, 742
Telemetry [baseline] (9.223 ms) : 0, 9223
Telemetry [candidate] (9.159 ms) : 0, 9159
IAST [baseline] (31.331 ms) : 0, 31331
IAST [candidate] (28.414 ms) : 0, 28414
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (1.147 s) : 0, 1146882
BytebuddyAgent [candidate] (1.153 s) : 0, 1152946
GlobalTracer [baseline] (434.241 ms) : 0, 434241
GlobalTracer [candidate] (436.144 ms) : 0, 436144
AppSec [baseline] (67.81 ms) : 0, 67810
AppSec [candidate] (68.274 ms) : 0, 68274
Remote Config [baseline] (769.711 µs) : 0, 770
Remote Config [candidate] (766.613 µs) : 0, 767
Telemetry [baseline] (9.715 ms) : 0, 9715
Telemetry [candidate] (8.921 ms) : 0, 8921
IAST [baseline] (31.276 ms) : 0, 31276
IAST [candidate] (33.042 ms) : 0, 33042
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.38.0-SNAPSHOT~26a24b5efc, baseline=1.38.0-SNAPSHOT~c08dc4f3c9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.55 s) : 0, 1550194
Total [baseline] (14.177 s) : 0, 14176841
Agent [candidate] (1.544 s) : 0, 1544416
Total [candidate] (14.294 s) : 0, 14294131
section appsec
Agent [baseline] (1.734 s) : 0, 1734429
Total [baseline] (14.371 s) : 0, 14371158
Agent [candidate] (1.736 s) : 0, 1735512
Total [candidate] (14.456 s) : 0, 14455720
section iast
Agent [baseline] (1.717 s) : 0, 1717323
Total [baseline] (14.786 s) : 0, 14785900
Agent [candidate] (1.724 s) : 0, 1723752
Total [candidate] (14.81 s) : 0, 14809620
section profiling
Agent [baseline] (1.863 s) : 0, 1863019
Total [baseline] (14.671 s) : 0, 14670505
Agent [candidate] (1.875 s) : 0, 1875146
Total [candidate] (14.812 s) : 0, 14812104
gantt
title petclinic - break down per module: candidate=1.38.0-SNAPSHOT~26a24b5efc, baseline=1.38.0-SNAPSHOT~c08dc4f3c9
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (994.113 ms) : 0, 994113
BytebuddyAgent [candidate] (990.59 ms) : 0, 990590
GlobalTracer [baseline] (454.833 ms) : 0, 454833
GlobalTracer [candidate] (452.794 ms) : 0, 452794
AppSec [baseline] (70.895 ms) : 0, 70895
AppSec [candidate] (70.634 ms) : 0, 70634
Remote Config [baseline] (848.925 µs) : 0, 849
Remote Config [candidate] (842.43 µs) : 0, 842
Telemetry [baseline] (9.572 ms) : 0, 9572
Telemetry [candidate] (9.539 ms) : 0, 9539
section appsec
BytebuddyAgent [baseline] (1.01 s) : 0, 1009667
BytebuddyAgent [candidate] (1.011 s) : 0, 1011193
GlobalTracer [baseline] (447.759 ms) : 0, 447759
GlobalTracer [candidate] (446.453 ms) : 0, 446453
AppSec [baseline] (232.693 ms) : 0, 232693
AppSec [candidate] (233.335 ms) : 0, 233335
Remote Config [baseline] (774.293 µs) : 0, 774
Remote Config [candidate] (766.15 µs) : 0, 766
Telemetry [baseline] (10.436 ms) : 0, 10436
Telemetry [candidate] (11.217 ms) : 0, 11217
IAST [baseline] (26.206 ms) : 0, 26206
IAST [candidate] (24.829 ms) : 0, 24829
section iast
BytebuddyAgent [baseline] (1.152 s) : 0, 1152129
BytebuddyAgent [candidate] (1.157 s) : 0, 1157332
GlobalTracer [baseline] (433.886 ms) : 0, 433886
GlobalTracer [candidate] (435.755 ms) : 0, 435755
AppSec [baseline] (72.284 ms) : 0, 72284
AppSec [candidate] (72.18 ms) : 0, 72180
Remote Config [baseline] (742.758 µs) : 0, 743
Remote Config [candidate] (744.007 µs) : 0, 744
Telemetry [baseline] (9.085 ms) : 0, 9085
Telemetry [candidate] (9.136 ms) : 0, 9136
IAST [baseline] (29.211 ms) : 0, 29211
IAST [candidate] (28.446 ms) : 0, 28446
section profiling
ProfilingAgent [baseline] (149.853 ms) : 0, 149853
ProfilingAgent [candidate] (152.821 ms) : 0, 152821
BytebuddyAgent [baseline] (988.712 ms) : 0, 988712
BytebuddyAgent [candidate] (993.988 ms) : 0, 993988
GlobalTracer [baseline] (585.868 ms) : 0, 585868
GlobalTracer [candidate] (588.938 ms) : 0, 588938
AppSec [baseline] (72.518 ms) : 0, 72518
AppSec [candidate] (72.87 ms) : 0, 72870
Remote Config [baseline] (913.123 µs) : 0, 913
Remote Config [candidate] (923.429 µs) : 0, 923
Telemetry [baseline] (9.339 ms) : 0, 9339
Telemetry [candidate] (9.376 ms) : 0, 9376
Profiling [baseline] (149.922 ms) : 0, 149922
Profiling [candidate] (152.899 ms) : 0, 152899
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 6 metrics, 22 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~26a24b5efc, baseline=1.38.0-SNAPSHOT~c08dc4f3c9
dateFormat X
axisFormat %s
section baseline
no_agent (451.358 µs) : 422, 480
. : milestone, 451,
iast (588.684 µs) : 557, 620
. : milestone, 589,
iast_FULL (678.418 µs) : 647, 709
. : milestone, 678,
iast_GLOBAL (614.138 µs) : 581, 647
. : milestone, 614,
iast_HARDCODED_SECRET_DISABLED (583.628 µs) : 553, 615
. : milestone, 584,
iast_INACTIVE (555.2 µs) : 523, 587
. : milestone, 555,
iast_TELEMETRY_OFF (573.878 µs) : 542, 606
. : milestone, 574,
tracing (537.585 µs) : 508, 567
. : milestone, 538,
section candidate
no_agent (445.27 µs) : 416, 474
. : milestone, 445,
iast (595.032 µs) : 563, 627
. : milestone, 595,
iast_FULL (680.818 µs) : 648, 713
. : milestone, 681,
iast_GLOBAL (620.821 µs) : 590, 652
. : milestone, 621,
iast_HARDCODED_SECRET_DISABLED (583.844 µs) : 552, 616
. : milestone, 584,
iast_INACTIVE (556.378 µs) : 524, 589
. : milestone, 556,
iast_TELEMETRY_OFF (571.373 µs) : 539, 603
. : milestone, 571,
tracing (533.376 µs) : 504, 563
. : milestone, 533,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~26a24b5efc, baseline=1.38.0-SNAPSHOT~c08dc4f3c9
dateFormat X
axisFormat %s
section baseline
no_agent (1.716 ms) : 1691, 1742
. : milestone, 1716,
appsec (2.198 ms) : 2167, 2229
. : milestone, 2198,
appsec_no_iast (2.194 ms) : 2162, 2226
. : milestone, 2194,
iast (1.875 ms) : 1846, 1904
. : milestone, 1875,
profiling (1.894 ms) : 1862, 1926
. : milestone, 1894,
tracing (1.871 ms) : 1840, 1903
. : milestone, 1871,
section candidate
no_agent (1.691 ms) : 1667, 1716
. : milestone, 1691,
appsec (2.175 ms) : 2144, 2207
. : milestone, 2175,
appsec_no_iast (2.136 ms) : 2104, 2168
. : milestone, 2136,
iast (1.898 ms) : 1868, 1928
. : milestone, 1898,
profiling (1.9 ms) : 1867, 1933
. : milestone, 1900,
tracing (1.879 ms) : 1847, 1910
. : milestone, 1879,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~26a24b5efc, baseline=1.38.0-SNAPSHOT~c08dc4f3c9
dateFormat X
axisFormat %s
section baseline
no_agent (20.627 s) : 20627000, 20627000
. : milestone, 20627000,
appsec (20.72 s) : 20720000, 20720000
. : milestone, 20720000,
iast (24.686 s) : 24686000, 24686000
. : milestone, 24686000,
iast_GLOBAL (24.977 s) : 24977000, 24977000
. : milestone, 24977000,
profiling (21.269 s) : 21269000, 21269000
. : milestone, 21269000,
tracing (20.447 s) : 20447000, 20447000
. : milestone, 20447000,
section candidate
no_agent (20.626 s) : 20626000, 20626000
. : milestone, 20626000,
appsec (21.833 s) : 21833000, 21833000
. : milestone, 21833000,
iast (24.138 s) : 24138000, 24138000
. : milestone, 24138000,
iast_GLOBAL (24.934 s) : 24934000, 24934000
. : milestone, 24934000,
profiling (21.042 s) : 21042000, 21042000
. : milestone, 21042000,
tracing (20.503 s) : 20503000, 20503000
. : milestone, 20503000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~26a24b5efc, baseline=1.38.0-SNAPSHOT~c08dc4f3c9
dateFormat X
axisFormat %s
section baseline
no_agent (1.54 ms) : 1527, 1552
. : milestone, 1540,
appsec (2.7 ms) : 2638, 2762
. : milestone, 2700,
iast (2.355 ms) : 2283, 2426
. : milestone, 2355,
iast_GLOBAL (2.422 ms) : 2348, 2497
. : milestone, 2422,
profiling (2.221 ms) : 2158, 2284
. : milestone, 2221,
tracing (2.181 ms) : 2121, 2241
. : milestone, 2181,
section candidate
no_agent (1.539 ms) : 1526, 1551
. : milestone, 1539,
appsec (2.704 ms) : 2641, 2766
. : milestone, 2704,
iast (2.376 ms) : 2303, 2450
. : milestone, 2376,
iast_GLOBAL (2.432 ms) : 2357, 2507
. : milestone, 2432,
profiling (2.227 ms) : 2163, 2291
. : milestone, 2227,
tracing (2.177 ms) : 2118, 2236
. : milestone, 2177,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Catch exception when compiling data jobs command pattern
Motivation
Not failing tracer installation if the pattern is invalid
Additional Notes
dd.data.jobs.command.patternwas introduced in this PR: #7366Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]