-
Notifications
You must be signed in to change notification settings - Fork 320
Fix Gradle dependency automation #7362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcculls
approved these changes
Jul 26, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.38.0-SNAPSHOT~4694cdf2d0, baseline=1.38.0-SNAPSHOT~4e62826c5c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.542 s) : 0, 1542178
Total [baseline] (11.801 s) : 0, 11801201
Agent [candidate] (1.544 s) : 0, 1543619
Total [candidate] (11.798 s) : 0, 11797598
section iast
Agent [baseline] (1.716 s) : 0, 1716121
Total [baseline] (12.502 s) : 0, 12501946
Agent [candidate] (1.714 s) : 0, 1713692
Total [candidate] (12.474 s) : 0, 12473789
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.715 s) : 0, 1714802
Total [baseline] (12.419 s) : 0, 12419083
Agent [candidate] (1.72 s) : 0, 1720038
Total [candidate] (12.415 s) : 0, 12415082
section iast_TELEMETRY_OFF
Agent [baseline] (1.713 s) : 0, 1713419
Total [baseline] (12.473 s) : 0, 12472629
Agent [candidate] (1.71 s) : 0, 1709674
Total [candidate] (12.456 s) : 0, 12456066
gantt
title insecure-bank - break down per module: candidate=1.38.0-SNAPSHOT~4694cdf2d0, baseline=1.38.0-SNAPSHOT~4e62826c5c
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (990.15 ms) : 0, 990150
BytebuddyAgent [candidate] (990.117 ms) : 0, 990117
GlobalTracer [baseline] (451.201 ms) : 0, 451201
GlobalTracer [candidate] (452.322 ms) : 0, 452322
AppSec [baseline] (70.315 ms) : 0, 70315
AppSec [candidate] (70.568 ms) : 0, 70568
Remote Config [baseline] (921.128 µs) : 0, 921
Remote Config [candidate] (850.672 µs) : 0, 851
Telemetry [baseline] (9.671 ms) : 0, 9671
Telemetry [candidate] (9.796 ms) : 0, 9796
section iast
BytebuddyAgent [baseline] (1.152 s) : 0, 1151630
BytebuddyAgent [candidate] (1.149 s) : 0, 1148859
GlobalTracer [baseline] (434.745 ms) : 0, 434745
GlobalTracer [candidate] (433.407 ms) : 0, 433407
AppSec [baseline] (71.354 ms) : 0, 71354
AppSec [candidate] (72.247 ms) : 0, 72247
IAST [baseline] (28.483 ms) : 0, 28483
IAST [candidate] (28.751 ms) : 0, 28751
Remote Config [baseline] (745.49 µs) : 0, 745
Remote Config [candidate] (1.503 ms) : 0, 1503
Telemetry [baseline] (9.207 ms) : 0, 9207
Telemetry [candidate] (8.987 ms) : 0, 8987
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (1.15 s) : 0, 1150271
BytebuddyAgent [candidate] (1.153 s) : 0, 1153040
GlobalTracer [baseline] (434.069 ms) : 0, 434069
GlobalTracer [candidate] (434.899 ms) : 0, 434899
AppSec [baseline] (70.885 ms) : 0, 70885
AppSec [candidate] (72.831 ms) : 0, 72831
IAST [baseline] (29.498 ms) : 0, 29498
IAST [candidate] (29.293 ms) : 0, 29293
Remote Config [baseline] (762.031 µs) : 0, 762
Remote Config [candidate] (725.102 µs) : 0, 725
Telemetry [baseline] (9.249 ms) : 0, 9249
Telemetry [candidate] (9.182 ms) : 0, 9182
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (1.148 s) : 0, 1147881
BytebuddyAgent [candidate] (1.145 s) : 0, 1145147
GlobalTracer [baseline] (435.736 ms) : 0, 435736
GlobalTracer [candidate] (434.055 ms) : 0, 434055
AppSec [baseline] (67.191 ms) : 0, 67191
AppSec [candidate] (67.087 ms) : 0, 67087
IAST [baseline] (32.981 ms) : 0, 32981
IAST [candidate] (32.937 ms) : 0, 32937
Remote Config [baseline] (717.917 µs) : 0, 718
Remote Config [candidate] (723.87 µs) : 0, 724
Telemetry [baseline] (8.922 ms) : 0, 8922
Telemetry [candidate] (9.688 ms) : 0, 9688
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.38.0-SNAPSHOT~4694cdf2d0, baseline=1.38.0-SNAPSHOT~4e62826c5c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.548 s) : 0, 1548005
Total [baseline] (14.287 s) : 0, 14286793
Agent [candidate] (1.543 s) : 0, 1543028
Total [candidate] (14.205 s) : 0, 14204502
section appsec
Agent [baseline] (1.728 s) : 0, 1727592
Total [baseline] (14.382 s) : 0, 14382379
Agent [candidate] (1.73 s) : 0, 1729733
Total [candidate] (14.408 s) : 0, 14408363
section iast
Agent [baseline] (1.72 s) : 0, 1720028
Total [baseline] (14.789 s) : 0, 14789037
Agent [candidate] (1.715 s) : 0, 1714714
Total [candidate] (14.747 s) : 0, 14746834
section profiling
Agent [baseline] (1.849 s) : 0, 1848604
Total [baseline] (14.598 s) : 0, 14597987
Agent [candidate] (1.854 s) : 0, 1853778
Total [candidate] (14.632 s) : 0, 14631510
gantt
title petclinic - break down per module: candidate=1.38.0-SNAPSHOT~4694cdf2d0, baseline=1.38.0-SNAPSHOT~4e62826c5c
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (993.46 ms) : 0, 993460
BytebuddyAgent [candidate] (990.13 ms) : 0, 990130
GlobalTracer [baseline] (453.477 ms) : 0, 453477
GlobalTracer [candidate] (451.656 ms) : 0, 451656
AppSec [baseline] (70.378 ms) : 0, 70378
AppSec [candidate] (70.578 ms) : 0, 70578
Remote Config [baseline] (921.758 µs) : 0, 922
Remote Config [candidate] (921.588 µs) : 0, 922
Telemetry [baseline] (9.752 ms) : 0, 9752
Telemetry [candidate] (9.757 ms) : 0, 9757
section appsec
BytebuddyAgent [baseline] (1.006 s) : 0, 1006232
BytebuddyAgent [candidate] (1.009 s) : 0, 1008859
GlobalTracer [baseline] (445.708 ms) : 0, 445708
GlobalTracer [candidate] (445.964 ms) : 0, 445964
AppSec [baseline] (231.303 ms) : 0, 231303
AppSec [candidate] (231.436 ms) : 0, 231436
Remote Config [baseline] (792.421 µs) : 0, 792
Remote Config [candidate] (783.933 µs) : 0, 784
Telemetry [baseline] (10.424 ms) : 0, 10424
Telemetry [candidate] (10.455 ms) : 0, 10455
IAST [baseline] (26.312 ms) : 0, 26312
IAST [candidate] (24.26 ms) : 0, 24260
section iast
BytebuddyAgent [baseline] (1.156 s) : 0, 1155676
BytebuddyAgent [candidate] (1.151 s) : 0, 1151406
GlobalTracer [baseline] (435.834 ms) : 0, 435834
GlobalTracer [candidate] (434.22 ms) : 0, 434220
AppSec [baseline] (68.554 ms) : 0, 68554
AppSec [candidate] (69.244 ms) : 0, 69244
Remote Config [baseline] (726.424 µs) : 0, 726
Remote Config [candidate] (731.719 µs) : 0, 732
Telemetry [baseline] (9.177 ms) : 0, 9177
Telemetry [candidate] (9.159 ms) : 0, 9159
IAST [baseline] (30.002 ms) : 0, 30002
IAST [candidate] (29.894 ms) : 0, 29894
section profiling
BytebuddyAgent [baseline] (983.584 ms) : 0, 983584
BytebuddyAgent [candidate] (985.044 ms) : 0, 985044
GlobalTracer [baseline] (582.178 ms) : 0, 582178
GlobalTracer [candidate] (583.059 ms) : 0, 583059
AppSec [baseline] (71.881 ms) : 0, 71881
AppSec [candidate] (72.445 ms) : 0, 72445
Remote Config [baseline] (913.349 µs) : 0, 913
Remote Config [candidate] (891.624 µs) : 0, 892
Telemetry [baseline] (9.256 ms) : 0, 9256
Telemetry [candidate] (9.299 ms) : 0, 9299
ProfilingAgent [baseline] (146.164 ms) : 0, 146164
ProfilingAgent [candidate] (148.298 ms) : 0, 148298
Profiling [baseline] (146.218 ms) : 0, 146218
Profiling [candidate] (148.374 ms) : 0, 148374
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 18 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~4694cdf2d0, baseline=1.38.0-SNAPSHOT~4e62826c5c
dateFormat X
axisFormat %s
section baseline
no_agent (1.348 ms) : 1328, 1368
. : milestone, 1348,
appsec (1.73 ms) : 1706, 1754
. : milestone, 1730,
appsec_no_iast (1.697 ms) : 1672, 1722
. : milestone, 1697,
iast (1.471 ms) : 1449, 1494
. : milestone, 1471,
profiling (1.534 ms) : 1508, 1561
. : milestone, 1534,
tracing (1.469 ms) : 1443, 1494
. : milestone, 1469,
section candidate
no_agent (1.349 ms) : 1330, 1368
. : milestone, 1349,
appsec (1.718 ms) : 1694, 1742
. : milestone, 1718,
appsec_no_iast (1.71 ms) : 1685, 1735
. : milestone, 1710,
iast (1.471 ms) : 1448, 1494
. : milestone, 1471,
profiling (1.474 ms) : 1449, 1498
. : milestone, 1474,
tracing (1.463 ms) : 1439, 1487
. : milestone, 1463,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~4694cdf2d0, baseline=1.38.0-SNAPSHOT~4e62826c5c
dateFormat X
axisFormat %s
section baseline
no_agent (364.173 µs) : 344, 384
. : milestone, 364,
iast (484.266 µs) : 462, 507
. : milestone, 484,
iast_FULL (545.612 µs) : 524, 567
. : milestone, 546,
iast_GLOBAL (504.489 µs) : 484, 525
. : milestone, 504,
iast_HARDCODED_SECRET_DISABLED (477.944 µs) : 457, 499
. : milestone, 478,
iast_INACTIVE (451.81 µs) : 429, 474
. : milestone, 452,
iast_TELEMETRY_OFF (463.977 µs) : 443, 485
. : milestone, 464,
tracing (437.634 µs) : 417, 458
. : milestone, 438,
section candidate
no_agent (367.661 µs) : 347, 389
. : milestone, 368,
iast (475.572 µs) : 454, 497
. : milestone, 476,
iast_FULL (541.031 µs) : 520, 562
. : milestone, 541,
iast_GLOBAL (493.829 µs) : 473, 515
. : milestone, 494,
iast_HARDCODED_SECRET_DISABLED (474.407 µs) : 453, 495
. : milestone, 474,
iast_INACTIVE (458.864 µs) : 436, 481
. : milestone, 459,
iast_TELEMETRY_OFF (469.841 µs) : 448, 492
. : milestone, 470,
tracing (442.7 µs) : 421, 464
. : milestone, 443,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~4694cdf2d0, baseline=1.38.0-SNAPSHOT~4e62826c5c
dateFormat X
axisFormat %s
section baseline
no_agent (1.459 ms) : 1447, 1470
. : milestone, 1459,
appsec (2.226 ms) : 2190, 2261
. : milestone, 2226,
iast (1.978 ms) : 1936, 2020
. : milestone, 1978,
iast_GLOBAL (2.005 ms) : 1963, 2047
. : milestone, 2005,
profiling (1.852 ms) : 1819, 1886
. : milestone, 1852,
tracing (1.838 ms) : 1804, 1871
. : milestone, 1838,
section candidate
no_agent (1.46 ms) : 1448, 1471
. : milestone, 1460,
appsec (2.214 ms) : 2179, 2248
. : milestone, 2214,
iast (1.968 ms) : 1927, 2009
. : milestone, 1968,
iast_GLOBAL (2.013 ms) : 1970, 2056
. : milestone, 2013,
profiling (1.849 ms) : 1814, 1884
. : milestone, 1849,
tracing (1.842 ms) : 1808, 1875
. : milestone, 1842,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~4694cdf2d0, baseline=1.38.0-SNAPSHOT~4e62826c5c
dateFormat X
axisFormat %s
section baseline
no_agent (15.692 s) : 15692000, 15692000
. : milestone, 15692000,
appsec (15.297 s) : 15297000, 15297000
. : milestone, 15297000,
iast (18.573 s) : 18573000, 18573000
. : milestone, 18573000,
iast_GLOBAL (17.895 s) : 17895000, 17895000
. : milestone, 17895000,
profiling (14.94 s) : 14940000, 14940000
. : milestone, 14940000,
tracing (14.996 s) : 14996000, 14996000
. : milestone, 14996000,
section candidate
no_agent (15.464 s) : 15464000, 15464000
. : milestone, 15464000,
appsec (15.086 s) : 15086000, 15086000
. : milestone, 15086000,
iast (18.595 s) : 18595000, 18595000
. : milestone, 18595000,
iast_GLOBAL (18.207 s) : 18207000, 18207000
. : milestone, 18207000,
profiling (15.248 s) : 15248000, 15248000
. : milestone, 15248000,
tracing (15.072 s) : 15072000, 15072000
. : milestone, 15072000,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: tooling
Build & Tooling
tag: no release notes
Changes to exclude from release notes
type: bug
Bug report and fix
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR should fix the gradle dependency automation by creating signed commit.
It also brings permissions configuration for the coming permission limitation.
Motivation
The original solution was creating non-signed commits that can't be merged 😞
Additional Notes
This uses a rather complicated setup that leverages a CLI tool to make GraphQL calls to create commits on a remote branch.
As the new file content must be (base64) encoded and added to the GraphQL mutation query payload, I had to:
Then, create a PR using another CLI to target master from the built branch.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]