Fix package resolution for non-Java source files#7356
Merged
nikita-tkachenko-datadog merged 2 commits intomasterfrom Jul 26, 2024
Merged
Fix package resolution for non-Java source files#7356nikita-tkachenko-datadog merged 2 commits intomasterfrom
nikita-tkachenko-datadog merged 2 commits intomasterfrom
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 12 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.38.0-SNAPSHOT~5cdf8481ed, baseline=1.38.0-SNAPSHOT~598bb20490
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1046173
Total [baseline] (8.499 s) : 0, 8499326
Agent [candidate] (1.044 s) : 0, 1043661
Total [candidate] (8.481 s) : 0, 8480755
section iast
Agent [baseline] (1.174 s) : 0, 1174028
Total [baseline] (8.978 s) : 0, 8977851
Agent [candidate] (1.172 s) : 0, 1172329
Total [candidate] (8.962 s) : 0, 8961894
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.169 s) : 0, 1169187
Total [baseline] (8.969 s) : 0, 8969330
Agent [candidate] (1.191 s) : 0, 1190902
Total [candidate] (9.001 s) : 0, 9000607
section iast_TELEMETRY_OFF
Agent [baseline] (1.17 s) : 0, 1169732
Total [baseline] (8.975 s) : 0, 8974967
Agent [candidate] (1.169 s) : 0, 1169302
Total [candidate] (8.963 s) : 0, 8962551
gantt
title insecure-bank - break down per module: candidate=1.38.0-SNAPSHOT~5cdf8481ed, baseline=1.38.0-SNAPSHOT~598bb20490
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (669.048 ms) : 0, 669048
BytebuddyAgent [candidate] (666.573 ms) : 0, 666573
GlobalTracer [baseline] (305.562 ms) : 0, 305562
GlobalTracer [candidate] (305.085 ms) : 0, 305085
AppSec [baseline] (49.852 ms) : 0, 49852
AppSec [candidate] (50.217 ms) : 0, 50217
Remote Config [baseline] (706.701 µs) : 0, 707
Remote Config [candidate] (673.261 µs) : 0, 673
Telemetry [baseline] (7.583 ms) : 0, 7583
Telemetry [candidate] (7.693 ms) : 0, 7693
section iast
BytebuddyAgent [baseline] (782.336 ms) : 0, 782336
BytebuddyAgent [candidate] (779.887 ms) : 0, 779887
GlobalTracer [baseline] (294.866 ms) : 0, 294866
GlobalTracer [candidate] (295.786 ms) : 0, 295786
AppSec [baseline] (52.614 ms) : 0, 52614
AppSec [candidate] (47.391 ms) : 0, 47391
IAST [baseline] (22.558 ms) : 0, 22558
IAST [candidate] (28.317 ms) : 0, 28317
Remote Config [baseline] (567.067 µs) : 0, 567
Remote Config [candidate] (572.322 µs) : 0, 572
Telemetry [baseline] (7.648 ms) : 0, 7648
Telemetry [candidate] (6.948 ms) : 0, 6948
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (780.505 ms) : 0, 780505
BytebuddyAgent [candidate] (793.784 ms) : 0, 793784
GlobalTracer [baseline] (295.84 ms) : 0, 295840
GlobalTracer [candidate] (300.08 ms) : 0, 300080
AppSec [baseline] (49.219 ms) : 0, 49219
AppSec [candidate] (48.665 ms) : 0, 48665
IAST [baseline] (21.753 ms) : 0, 21753
IAST [candidate] (26.893 ms) : 0, 26893
Remote Config [baseline] (568.977 µs) : 0, 569
Remote Config [candidate] (587.209 µs) : 0, 587
Telemetry [baseline] (7.813 ms) : 0, 7813
Telemetry [candidate] (7.165 ms) : 0, 7165
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (780.435 ms) : 0, 780435
BytebuddyAgent [candidate] (779.815 ms) : 0, 779815
GlobalTracer [baseline] (295.862 ms) : 0, 295862
GlobalTracer [candidate] (296.019 ms) : 0, 296019
AppSec [baseline] (47.272 ms) : 0, 47272
AppSec [candidate] (47.461 ms) : 0, 47461
IAST [baseline] (25.021 ms) : 0, 25021
IAST [candidate] (24.937 ms) : 0, 24937
Remote Config [baseline] (581.675 µs) : 0, 582
Remote Config [candidate] (578.463 µs) : 0, 578
Telemetry [baseline] (7.079 ms) : 0, 7079
Telemetry [candidate] (6.996 ms) : 0, 6996
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.38.0-SNAPSHOT~5cdf8481ed, baseline=1.38.0-SNAPSHOT~598bb20490
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1046916
Total [baseline] (10.299 s) : 0, 10298742
Agent [candidate] (1.044 s) : 0, 1044217
Total [candidate] (10.347 s) : 0, 10347016
section appsec
Agent [baseline] (1.168 s) : 0, 1168286
Total [baseline] (10.521 s) : 0, 10520520
Agent [candidate] (1.163 s) : 0, 1162639
Total [candidate] (10.473 s) : 0, 10472798
section iast
Agent [baseline] (1.175 s) : 0, 1174714
Total [baseline] (10.8 s) : 0, 10799707
Agent [candidate] (1.173 s) : 0, 1172706
Total [candidate] (10.823 s) : 0, 10822947
section profiling
Agent [baseline] (1.247 s) : 0, 1246599
Total [baseline] (10.609 s) : 0, 10609341
Agent [candidate] (1.248 s) : 0, 1247599
Total [candidate] (10.657 s) : 0, 10657175
gantt
title petclinic - break down per module: candidate=1.38.0-SNAPSHOT~5cdf8481ed, baseline=1.38.0-SNAPSHOT~598bb20490
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (669.12 ms) : 0, 669120
BytebuddyAgent [candidate] (666.932 ms) : 0, 666932
GlobalTracer [baseline] (305.936 ms) : 0, 305936
GlobalTracer [candidate] (305.413 ms) : 0, 305413
AppSec [baseline] (50.052 ms) : 0, 50052
AppSec [candidate] (50.083 ms) : 0, 50083
Remote Config [baseline] (716.035 µs) : 0, 716
Remote Config [candidate] (669.004 µs) : 0, 669
Telemetry [baseline] (7.625 ms) : 0, 7625
Telemetry [candidate] (7.64 ms) : 0, 7640
section appsec
BytebuddyAgent [baseline] (680.565 ms) : 0, 680565
BytebuddyAgent [candidate] (676.609 ms) : 0, 676609
GlobalTracer [baseline] (299.452 ms) : 0, 299452
GlobalTracer [candidate] (298.557 ms) : 0, 298557
AppSec [baseline] (154.326 ms) : 0, 154326
AppSec [candidate] (153.996 ms) : 0, 153996
IAST [baseline] (23.032 ms) : 0, 23032
IAST [candidate] (21.719 ms) : 0, 21719
Remote Config [baseline] (629.655 µs) : 0, 630
Remote Config [candidate] (623.426 µs) : 0, 623
Telemetry [baseline] (8.278 ms) : 0, 8278
Telemetry [candidate] (8.524 ms) : 0, 8524
section iast
BytebuddyAgent [baseline] (782.743 ms) : 0, 782743
BytebuddyAgent [candidate] (781.996 ms) : 0, 781996
GlobalTracer [baseline] (295.043 ms) : 0, 295043
GlobalTracer [candidate] (295.703 ms) : 0, 295703
AppSec [baseline] (49.074 ms) : 0, 49074
AppSec [candidate] (47.494 ms) : 0, 47494
IAST [baseline] (26.665 ms) : 0, 26665
IAST [candidate] (26.29 ms) : 0, 26290
Remote Config [baseline] (575.585 µs) : 0, 576
Remote Config [candidate] (595.675 µs) : 0, 596
Telemetry [baseline] (7.08 ms) : 0, 7080
Telemetry [candidate] (7.128 ms) : 0, 7128
section profiling
BytebuddyAgent [baseline] (664.12 ms) : 0, 664120
BytebuddyAgent [candidate] (668.446 ms) : 0, 668446
GlobalTracer [baseline] (390.118 ms) : 0, 390118
GlobalTracer [candidate] (388.854 ms) : 0, 388854
AppSec [baseline] (52.003 ms) : 0, 52003
AppSec [candidate] (51.617 ms) : 0, 51617
Remote Config [baseline] (660.341 µs) : 0, 660
Remote Config [candidate] (661.237 µs) : 0, 661
Telemetry [baseline] (7.43 ms) : 0, 7430
Telemetry [candidate] (7.426 ms) : 0, 7426
ProfilingAgent [baseline] (95.456 ms) : 0, 95456
ProfilingAgent [candidate] (94.267 ms) : 0, 94267
Profiling [baseline] (95.48 ms) : 0, 95480
Profiling [candidate] (94.291 ms) : 0, 94291
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~5cdf8481ed, baseline=1.38.0-SNAPSHOT~598bb20490
dateFormat X
axisFormat %s
section baseline
no_agent (1.348 ms) : 1329, 1368
. : milestone, 1348,
appsec (1.71 ms) : 1687, 1734
. : milestone, 1710,
appsec_no_iast (1.714 ms) : 1690, 1739
. : milestone, 1714,
iast (1.478 ms) : 1455, 1501
. : milestone, 1478,
profiling (1.489 ms) : 1465, 1513
. : milestone, 1489,
tracing (1.462 ms) : 1438, 1487
. : milestone, 1462,
section candidate
no_agent (1.343 ms) : 1325, 1362
. : milestone, 1343,
appsec (1.724 ms) : 1701, 1747
. : milestone, 1724,
appsec_no_iast (1.73 ms) : 1706, 1754
. : milestone, 1730,
iast (1.482 ms) : 1460, 1504
. : milestone, 1482,
profiling (1.486 ms) : 1461, 1512
. : milestone, 1486,
tracing (1.459 ms) : 1435, 1484
. : milestone, 1459,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~5cdf8481ed, baseline=1.38.0-SNAPSHOT~598bb20490
dateFormat X
axisFormat %s
section baseline
no_agent (367.249 µs) : 347, 388
. : milestone, 367,
iast (485.787 µs) : 465, 507
. : milestone, 486,
iast_FULL (550.205 µs) : 529, 571
. : milestone, 550,
iast_GLOBAL (501.628 µs) : 481, 523
. : milestone, 502,
iast_HARDCODED_SECRET_DISABLED (476.169 µs) : 455, 497
. : milestone, 476,
iast_INACTIVE (457.697 µs) : 435, 480
. : milestone, 458,
iast_TELEMETRY_OFF (472.278 µs) : 451, 494
. : milestone, 472,
tracing (441.638 µs) : 421, 462
. : milestone, 442,
section candidate
no_agent (367.965 µs) : 349, 387
. : milestone, 368,
iast (483.378 µs) : 462, 505
. : milestone, 483,
iast_FULL (553.701 µs) : 533, 575
. : milestone, 554,
iast_GLOBAL (501.947 µs) : 481, 523
. : milestone, 502,
iast_HARDCODED_SECRET_DISABLED (485.066 µs) : 464, 506
. : milestone, 485,
iast_INACTIVE (457.9 µs) : 435, 480
. : milestone, 458,
iast_TELEMETRY_OFF (471.425 µs) : 450, 493
. : milestone, 471,
tracing (443.99 µs) : 423, 465
. : milestone, 444,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~5cdf8481ed, baseline=1.38.0-SNAPSHOT~598bb20490
dateFormat X
axisFormat %s
section baseline
no_agent (15.086 s) : 15086000, 15086000
. : milestone, 15086000,
appsec (14.883 s) : 14883000, 14883000
. : milestone, 14883000,
iast (18.881 s) : 18881000, 18881000
. : milestone, 18881000,
iast_GLOBAL (17.962 s) : 17962000, 17962000
. : milestone, 17962000,
profiling (15.249 s) : 15249000, 15249000
. : milestone, 15249000,
tracing (14.985 s) : 14985000, 14985000
. : milestone, 14985000,
section candidate
no_agent (15.377 s) : 15377000, 15377000
. : milestone, 15377000,
appsec (14.931 s) : 14931000, 14931000
. : milestone, 14931000,
iast (18.747 s) : 18747000, 18747000
. : milestone, 18747000,
iast_GLOBAL (17.868 s) : 17868000, 17868000
. : milestone, 17868000,
profiling (15.418 s) : 15418000, 15418000
. : milestone, 15418000,
tracing (15.043 s) : 15043000, 15043000
. : milestone, 15043000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~5cdf8481ed, baseline=1.38.0-SNAPSHOT~598bb20490
dateFormat X
axisFormat %s
section baseline
no_agent (1.453 ms) : 1441, 1464
. : milestone, 1453,
appsec (2.2 ms) : 2166, 2235
. : milestone, 2200,
iast (1.964 ms) : 1922, 2006
. : milestone, 1964,
iast_GLOBAL (2.007 ms) : 1966, 2049
. : milestone, 2007,
profiling (1.86 ms) : 1824, 1895
. : milestone, 1860,
tracing (1.84 ms) : 1807, 1873
. : milestone, 1840,
section candidate
no_agent (1.456 ms) : 1445, 1467
. : milestone, 1456,
appsec (2.218 ms) : 2183, 2252
. : milestone, 2218,
iast (1.969 ms) : 1927, 2011
. : milestone, 1969,
iast_GLOBAL (2.012 ms) : 1969, 2056
. : milestone, 2012,
profiling (1.862 ms) : 1827, 1896
. : milestone, 1862,
tracing (1.835 ms) : 1802, 1869
. : milestone, 1835,
|
anmarchenko
approved these changes
Jul 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Updates logic that resolves packages and source roots when building repository index.
Motivation
In non-Java sources it is possible to declare a package whose name does not correspond to the folder(s) where the source file is located.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: SDTEST-624