Implement trace origin header and propagation support#731
Conversation
b3c1c71 to
af41c7e
Compare
There was a problem hiding this comment.
Could you please explain why this is needed?
There was a problem hiding this comment.
I added that so I could run all the integration tests with a single command. I could remove it if you don't like it.
There was a problem hiding this comment.
No, I do not have a strong preference about it being there - but if you decide to keep it just please add a small comment explaining why it's there so later we know :)
There was a problem hiding this comment.
Maybe instead of doing one more special case here you could initialize origin inside this if statement:
if (parentContext instanceof TagContext) {
tags.putAll(((TagContext) parentContext).getTags());
}
This may simplify some of this code, I think - you might be able to set origin to null by default and then read it from context only if context supports this.
There was a problem hiding this comment.
I considered that, but thought this would be cleaner... I'll try reimplementing and see if that works better.
There was a problem hiding this comment.
No, I reordered it so it was consistent with other parts of the code... (see deletion below.)
There was a problem hiding this comment.
Ah, I missed that, thanks!
af41c7e to
99f2d97
Compare
Used by Synthetics to prioritize sampling.