Skip to content

Preserve original types before passing data to the WAF#7220

Merged
smola merged 3 commits into
masterfrom
smola/waf-serialization-improvements
Jun 21, 2024
Merged

Preserve original types before passing data to the WAF#7220
smola merged 3 commits into
masterfrom
smola/waf-serialization-improvements

Conversation

@smola

@smola smola commented Jun 19, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

What Does This Do

  • When converting parsed body or grpc messages, preserve types to the extent that they are supported by libddwaf. Rules that apply only to strings can be skipped for numbers, booleans, etc.
  • For anything that is not supported by libddwaf, such as non-string keys in maps, just convert to strings.
  • When a key cannot be converted, use invalid_key:$i string
  • Skip fields that are known to be useless, such as memoizedHashCode and memoizedSize in protobuf.

Motivation

Originally motivated by spurious matches of internal protobuf fields, then also realized there are several cases where we are doing unnecessary work. This turns out to be the first of a possible series of performance optimizations.

Additional Notes

Jira ticket: APPSEC-53469

Future work:

  • When an object cannot be converted correctly, do not use anything that will be extraneous to the WAF (such as MyClass@1234). Fall back should to be an invalid object, which is a well defined type in the WAF. We'll need to change libddwaf-java a bit to expose the invalid object type.
  • Emit further metrics or logs when we hit this sort of edge case.

@smola smola added the comp: asm waf Application Security Management (WAF) label Jun 19, 2024
@pr-commenter

pr-commenter Bot commented Jun 19, 2024 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master smola/waf-serialization-improvements
git_commit_date 1718873384 1718880664
git_commit_sha 01fd984 ca5aa26
release_version 1.36.0-SNAPSHOT~01fd984c16 1.36.0-SNAPSHOT~ca5aa26267
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1718883681 1718883681
ci_job_id 548761563 548761563
ci_pipeline_id 37157900 37157900
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.36.0-SNAPSHOT~ca5aa26267, baseline=1.36.0-SNAPSHOT~01fd984c16

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1059485
Total [baseline] (10.427 s) : 0, 10426566
Agent [candidate] (1.06 s) : 0, 1060327
Total [candidate] (10.329 s) : 0, 10329011
section appsec
Agent [baseline] (1.184 s) : 0, 1184353
Total [baseline] (10.49 s) : 0, 10490431
Agent [candidate] (1.185 s) : 0, 1184627
Total [candidate] (10.448 s) : 0, 10448153
section iast
Agent [baseline] (1.169 s) : 0, 1169094
Total [baseline] (10.67 s) : 0, 10670286
Agent [candidate] (1.174 s) : 0, 1174457
Total [candidate] (10.68 s) : 0, 10679600
section profiling
Agent [baseline] (1.259 s) : 0, 1259367
Total [baseline] (10.588 s) : 0, 10588448
Agent [candidate] (1.261 s) : 0, 1260853
Total [candidate] (10.635 s) : 0, 10635176
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.059 s -
Agent appsec 1.184 s 124.868 ms (11.8%)
Agent iast 1.169 s 109.609 ms (10.3%)
Agent profiling 1.259 s 199.882 ms (18.9%)
Total tracing 10.427 s -
Total appsec 10.49 s 63.866 ms (0.6%)
Total iast 10.67 s 243.721 ms (2.3%)
Total profiling 10.588 s 161.882 ms (1.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.06 s -
Agent appsec 1.185 s 124.299 ms (11.7%)
Agent iast 1.174 s 114.13 ms (10.8%)
Agent profiling 1.261 s 200.526 ms (18.9%)
Total tracing 10.329 s -
Total appsec 10.448 s 119.143 ms (1.2%)
Total iast 10.68 s 350.589 ms (3.4%)
Total profiling 10.635 s 306.166 ms (3.0%) 
gantt
    title petclinic - break down per module: candidate=1.36.0-SNAPSHOT~ca5aa26267, baseline=1.36.0-SNAPSHOT~01fd984c16

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (664.004 ms) : 0, 664004
BytebuddyAgent [candidate] (664.366 ms) : 0, 664366
GlobalTracer [baseline] (303.011 ms) : 0, 303011
GlobalTracer [candidate] (303.521 ms) : 0, 303521
AppSec [baseline] (49.947 ms) : 0, 49947
AppSec [candidate] (49.898 ms) : 0, 49898
Remote Config [baseline] (680.774 µs) : 0, 681
Remote Config [candidate] (681.995 µs) : 0, 682
Telemetry [baseline] (7.548 ms) : 0, 7548
Telemetry [candidate] (7.494 ms) : 0, 7494
section appsec
BytebuddyAgent [baseline] (679.27 ms) : 0, 679270
BytebuddyAgent [candidate] (677.546 ms) : 0, 677546
GlobalTracer [baseline] (297.184 ms) : 0, 297184
GlobalTracer [candidate] (298.269 ms) : 0, 298269
AppSec [baseline] (154.098 ms) : 0, 154098
AppSec [candidate] (154.236 ms) : 0, 154236
Remote Config [baseline] (631.634 µs) : 0, 632
Remote Config [candidate] (640.692 µs) : 0, 641
Telemetry [baseline] (7.77 ms) : 0, 7770
Telemetry [candidate] (9.415 ms) : 0, 9415
IAST [baseline] (21.701 ms) : 0, 21701
IAST [candidate] (19.867 ms) : 0, 19867
section iast
BytebuddyAgent [baseline] (779.157 ms) : 0, 779157
BytebuddyAgent [candidate] (783.683 ms) : 0, 783683
GlobalTracer [baseline] (292.921 ms) : 0, 292921
GlobalTracer [candidate] (294.838 ms) : 0, 294838
AppSec [baseline] (47.131 ms) : 0, 47131
AppSec [candidate] (47.105 ms) : 0, 47105
Remote Config [baseline] (636.787 µs) : 0, 637
Remote Config [candidate] (638.233 µs) : 0, 638
Telemetry [baseline] (6.864 ms) : 0, 6864
Telemetry [candidate] (7.694 ms) : 0, 7694
IAST [baseline] (29.064 ms) : 0, 29064
IAST [candidate] (27.159 ms) : 0, 27159
section profiling
BytebuddyAgent [baseline] (661.714 ms) : 0, 661714
BytebuddyAgent [candidate] (662.285 ms) : 0, 662285
GlobalTracer [baseline] (385.273 ms) : 0, 385273
GlobalTracer [candidate] (385.319 ms) : 0, 385319
AppSec [baseline] (51.491 ms) : 0, 51491
AppSec [candidate] (51.458 ms) : 0, 51458
Remote Config [baseline] (730.856 µs) : 0, 731
Remote Config [candidate] (737.625 µs) : 0, 738
Telemetry [baseline] (7.36 ms) : 0, 7360
Telemetry [candidate] (7.376 ms) : 0, 7376
ProfilingAgent [baseline] (95.939 ms) : 0, 95939
ProfilingAgent [candidate] (96.623 ms) : 0, 96623
Profiling [baseline] (95.964 ms) : 0, 95964
Profiling [candidate] (96.648 ms) : 0, 96648
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.36.0-SNAPSHOT~ca5aa26267, baseline=1.36.0-SNAPSHOT~01fd984c16

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1061589
Total [baseline] (8.594 s) : 0, 8594110
Agent [candidate] (1.059 s) : 0, 1059211
Total [candidate] (8.532 s) : 0, 8531923
section iast
Agent [baseline] (1.181 s) : 0, 1180853
Total [baseline] (9.024 s) : 0, 9024189
Agent [candidate] (1.168 s) : 0, 1167786
Total [candidate] (9.004 s) : 0, 9004110
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.166 s) : 0, 1165906
Total [baseline] (8.986 s) : 0, 8986161
Agent [candidate] (1.167 s) : 0, 1166872
Total [candidate] (8.996 s) : 0, 8995891
section iast_TELEMETRY_OFF
Agent [baseline] (1.17 s) : 0, 1170300
Total [baseline] (8.972 s) : 0, 8971954
Agent [candidate] (1.162 s) : 0, 1162455
Total [candidate] (8.985 s) : 0, 8984763
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.062 s -
Agent iast 1.181 s 119.264 ms (11.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.166 s 104.317 ms (9.8%)
Agent iast_TELEMETRY_OFF 1.17 s 108.711 ms (10.2%)
Total tracing 8.594 s -
Total iast 9.024 s 430.079 ms (5.0%)
Total iast_HARDCODED_SECRET_DISABLED 8.986 s 392.051 ms (4.6%)
Total iast_TELEMETRY_OFF 8.972 s 377.844 ms (4.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.059 s -
Agent iast 1.168 s 108.574 ms (10.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.167 s 107.66 ms (10.2%)
Agent iast_TELEMETRY_OFF 1.162 s 103.243 ms (9.7%)
Total tracing 8.532 s -
Total iast 9.004 s 472.187 ms (5.5%)
Total iast_HARDCODED_SECRET_DISABLED 8.996 s 463.967 ms (5.4%)
Total iast_TELEMETRY_OFF 8.985 s 452.84 ms (5.3%) 
gantt
    title insecure-bank - break down per module: candidate=1.36.0-SNAPSHOT~ca5aa26267, baseline=1.36.0-SNAPSHOT~01fd984c16

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (665.138 ms) : 0, 665138
BytebuddyAgent [candidate] (663.584 ms) : 0, 663584
GlobalTracer [baseline] (303.542 ms) : 0, 303542
GlobalTracer [candidate] (302.902 ms) : 0, 302902
AppSec [baseline] (50.219 ms) : 0, 50219
AppSec [candidate] (50.195 ms) : 0, 50195
Remote Config [baseline] (688.552 µs) : 0, 689
Remote Config [candidate] (677.789 µs) : 0, 678
Telemetry [baseline] (7.634 ms) : 0, 7634
Telemetry [candidate] (7.564 ms) : 0, 7564
section iast
BytebuddyAgent [baseline] (789.184 ms) : 0, 789184
BytebuddyAgent [candidate] (778.599 ms) : 0, 778599
GlobalTracer [baseline] (294.745 ms) : 0, 294745
GlobalTracer [candidate] (292.648 ms) : 0, 292648
AppSec [baseline] (47.107 ms) : 0, 47107
AppSec [candidate] (46.895 ms) : 0, 46895
IAST [baseline] (28.952 ms) : 0, 28952
IAST [candidate] (28.871 ms) : 0, 28871
Remote Config [baseline] (588.381 µs) : 0, 588
Remote Config [candidate] (593.129 µs) : 0, 593
Telemetry [baseline] (6.878 ms) : 0, 6878
Telemetry [candidate] (6.908 ms) : 0, 6908
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (777.067 ms) : 0, 777067
BytebuddyAgent [candidate] (777.235 ms) : 0, 777235
GlobalTracer [baseline] (292.955 ms) : 0, 292955
GlobalTracer [candidate] (292.787 ms) : 0, 292787
AppSec [baseline] (47.001 ms) : 0, 47001
AppSec [candidate] (46.99 ms) : 0, 46990
IAST [baseline] (27.367 ms) : 0, 27367
IAST [candidate] (29.056 ms) : 0, 29056
Remote Config [baseline] (597.928 µs) : 0, 598
Remote Config [candidate] (590.389 µs) : 0, 590
Telemetry [baseline] (7.644 ms) : 0, 7644
Telemetry [candidate] (6.906 ms) : 0, 6906
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (779.792 ms) : 0, 779792
BytebuddyAgent [candidate] (775.083 ms) : 0, 775083
GlobalTracer [baseline] (293.699 ms) : 0, 293699
GlobalTracer [candidate] (292.778 ms) : 0, 292778
AppSec [baseline] (47.201 ms) : 0, 47201
AppSec [candidate] (47.082 ms) : 0, 47082
IAST [baseline] (27.269 ms) : 0, 27269
IAST [candidate] (24.455 ms) : 0, 24455
Remote Config [baseline] (604.944 µs) : 0, 605
Remote Config [candidate] (594.49 µs) : 0, 594
Telemetry [baseline] (8.349 ms) : 0, 8349
Telemetry [candidate] (9.135 ms) : 0, 9135
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-06-20T11:12:10 2024-06-20T11:19:03
git_branch master smola/waf-serialization-improvements
git_commit_date 1718873384 1718880664
git_commit_sha 01fd984 ca5aa26
release_version 1.36.0-SNAPSHOT~01fd984c16 1.36.0-SNAPSHOT~ca5aa26267
start_time 2024-06-20T11:11:57 2024-06-20T11:18:50
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1718882693 1718882693
ci_job_id 548761564 548761564
ci_pipeline_id 37157900 37157900
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~ca5aa26267, baseline=1.36.0-SNAPSHOT~01fd984c16
    dateFormat X
    axisFormat %s
section baseline
no_agent (370.494 µs) : 351, 390
.   : milestone, 370,
iast (492.333 µs) : 471, 514
.   : milestone, 492,
iast_FULL (559.117 µs) : 538, 580
.   : milestone, 559,
iast_GLOBAL (513.756 µs) : 492, 535
.   : milestone, 514,
iast_HARDCODED_SECRET_DISABLED (492.216 µs) : 471, 514
.   : milestone, 492,
iast_INACTIVE (457.235 µs) : 436, 478
.   : milestone, 457,
iast_TELEMETRY_OFF (484.3 µs) : 462, 506
.   : milestone, 484,
tracing (448.831 µs) : 427, 470
.   : milestone, 449,
section candidate
no_agent (376.224 µs) : 356, 397
.   : milestone, 376,
iast (486.442 µs) : 465, 508
.   : milestone, 486,
iast_FULL (558.345 µs) : 537, 579
.   : milestone, 558,
iast_GLOBAL (515.317 µs) : 494, 537
.   : milestone, 515,
iast_HARDCODED_SECRET_DISABLED (487.378 µs) : 466, 509
.   : milestone, 487,
iast_INACTIVE (459.401 µs) : 438, 480
.   : milestone, 459,
iast_TELEMETRY_OFF (484.06 µs) : 462, 506
.   : milestone, 484,
tracing (447.832 µs) : 427, 468
.   : milestone, 448,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.494 µs [350.785 µs, 390.202 µs] -
iast 492.333 µs [470.74 µs, 513.927 µs] 121.84 µs (32.9%)
iast_FULL 559.117 µs [537.951 µs, 580.284 µs] 188.624 µs (50.9%)
iast_GLOBAL 513.756 µs [492.215 µs, 535.297 µs] 143.263 µs (38.7%)
iast_HARDCODED_SECRET_DISABLED 492.216 µs [470.821 µs, 513.612 µs] 121.723 µs (32.9%)
iast_INACTIVE 457.235 µs [436.168 µs, 478.303 µs] 86.741 µs (23.4%)
iast_TELEMETRY_OFF 484.3 µs [462.375 µs, 506.225 µs] 113.807 µs (30.7%)
tracing 448.831 µs [427.334 µs, 470.329 µs] 78.338 µs (21.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 376.224 µs [355.697 µs, 396.752 µs] -
iast 486.442 µs [465.381 µs, 507.503 µs] 110.217 µs (29.3%)
iast_FULL 558.345 µs [537.224 µs, 579.466 µs] 182.121 µs (48.4%)
iast_GLOBAL 515.317 µs [494.076 µs, 536.557 µs] 139.092 µs (37.0%)
iast_HARDCODED_SECRET_DISABLED 487.378 µs [466.014 µs, 508.742 µs] 111.154 µs (29.5%)
iast_INACTIVE 459.401 µs [438.448 µs, 480.353 µs] 83.176 µs (22.1%)
iast_TELEMETRY_OFF 484.06 µs [462.487 µs, 505.632 µs] 107.835 µs (28.7%)
tracing 447.832 µs [427.375 µs, 468.288 µs] 71.607 µs (19.0%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~ca5aa26267, baseline=1.36.0-SNAPSHOT~01fd984c16
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.368 ms) : 1348, 1388
.   : milestone, 1368,
appsec (1.743 ms) : 1719, 1767
.   : milestone, 1743,
appsec_no_iast (1.733 ms) : 1707, 1758
.   : milestone, 1733,
iast (1.481 ms) : 1458, 1505
.   : milestone, 1481,
profiling (1.51 ms) : 1485, 1535
.   : milestone, 1510,
tracing (1.499 ms) : 1475, 1523
.   : milestone, 1499,
section candidate
no_agent (1.37 ms) : 1351, 1390
.   : milestone, 1370,
appsec (1.72 ms) : 1695, 1744
.   : milestone, 1720,
appsec_no_iast (1.749 ms) : 1725, 1773
.   : milestone, 1749,
iast (1.482 ms) : 1460, 1505
.   : milestone, 1482,
profiling (1.561 ms) : 1536, 1585
.   : milestone, 1561,
tracing (1.485 ms) : 1461, 1508
.   : milestone, 1485,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.368 ms [1.348 ms, 1.388 ms] -
appsec 1.743 ms [1.719 ms, 1.767 ms] 374.945 µs (27.4%)
appsec_no_iast 1.733 ms [1.707 ms, 1.758 ms] 364.561 µs (26.6%)
iast 1.481 ms [1.458 ms, 1.505 ms] 113.466 µs (8.3%)
profiling 1.51 ms [1.485 ms, 1.535 ms] 142.131 µs (10.4%)
tracing 1.499 ms [1.475 ms, 1.523 ms] 130.937 µs (9.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.37 ms [1.351 ms, 1.39 ms] -
appsec 1.72 ms [1.695 ms, 1.744 ms] 349.297 µs (25.5%)
appsec_no_iast 1.749 ms [1.725 ms, 1.773 ms] 378.83 µs (27.6%)
iast 1.482 ms [1.46 ms, 1.505 ms] 111.973 µs (8.2%)
profiling 1.561 ms [1.536 ms, 1.585 ms] 190.678 µs (13.9%)
tracing 1.485 ms [1.461 ms, 1.508 ms] 114.316 µs (8.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master smola/waf-serialization-improvements
git_commit_date 1718873384 1718880664
git_commit_sha 01fd984 ca5aa26
release_version 1.36.0-SNAPSHOT~01fd984c16 1.36.0-SNAPSHOT~ca5aa26267
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1718883078 1718883078
ci_job_id 548761565 548761565
ci_pipeline_id 37157900 37157900
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~ca5aa26267, baseline=1.36.0-SNAPSHOT~01fd984c16
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.459 ms) : 1447, 1470
.   : milestone, 1459,
appsec (2.195 ms) : 2161, 2229
.   : milestone, 2195,
iast (1.956 ms) : 1915, 1997
.   : milestone, 1956,
iast_GLOBAL (1.998 ms) : 1957, 2039
.   : milestone, 1998,
profiling (1.853 ms) : 1819, 1886
.   : milestone, 1853,
tracing (1.823 ms) : 1791, 1855
.   : milestone, 1823,
section candidate
no_agent (1.46 ms) : 1448, 1471
.   : milestone, 1460,
appsec (2.194 ms) : 2160, 2228
.   : milestone, 2194,
iast (1.963 ms) : 1922, 2004
.   : milestone, 1963,
iast_GLOBAL (1.994 ms) : 1954, 2035
.   : milestone, 1994,
profiling (1.843 ms) : 1810, 1876
.   : milestone, 1843,
tracing (1.814 ms) : 1783, 1846
.   : milestone, 1814,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.459 ms [1.447 ms, 1.47 ms] -
appsec 2.195 ms [2.161 ms, 2.229 ms] 736.028 µs (50.5%)
iast 1.956 ms [1.915 ms, 1.997 ms] 497.763 µs (34.1%)
iast_GLOBAL 1.998 ms [1.957 ms, 2.039 ms] 539.417 µs (37.0%)
profiling 1.853 ms [1.819 ms, 1.886 ms] 393.988 µs (27.0%)
tracing 1.823 ms [1.791 ms, 1.855 ms] 364.755 µs (25.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.46 ms [1.448 ms, 1.471 ms] -
appsec 2.194 ms [2.16 ms, 2.228 ms] 734.714 µs (50.3%)
iast 1.963 ms [1.922 ms, 2.004 ms] 503.344 µs (34.5%)
iast_GLOBAL 1.994 ms [1.954 ms, 2.035 ms] 534.561 µs (36.6%)
profiling 1.843 ms [1.81 ms, 1.876 ms] 383.721 µs (26.3%)
tracing 1.814 ms [1.783 ms, 1.846 ms] 354.5 µs (24.3%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~ca5aa26267, baseline=1.36.0-SNAPSHOT~01fd984c16
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.985 s) : 14985000, 14985000
.   : milestone, 14985000,
appsec (15.206 s) : 15206000, 15206000
.   : milestone, 15206000,
iast (18.755 s) : 18755000, 18755000
.   : milestone, 18755000,
iast_GLOBAL (17.831 s) : 17831000, 17831000
.   : milestone, 17831000,
profiling (15.465 s) : 15465000, 15465000
.   : milestone, 15465000,
tracing (15.114 s) : 15114000, 15114000
.   : milestone, 15114000,
section candidate
no_agent (15.039 s) : 15039000, 15039000
.   : milestone, 15039000,
appsec (14.81 s) : 14810000, 14810000
.   : milestone, 14810000,
iast (18.872 s) : 18872000, 18872000
.   : milestone, 18872000,
iast_GLOBAL (17.837 s) : 17837000, 17837000
.   : milestone, 17837000,
profiling (15.133 s) : 15133000, 15133000
.   : milestone, 15133000,
tracing (15.04 s) : 15040000, 15040000
.   : milestone, 15040000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.985 s [14.985 s, 14.985 s] -
appsec 15.206 s [15.206 s, 15.206 s] 221.0 ms (1.5%)
iast 18.755 s [18.755 s, 18.755 s] 3.77 s (25.2%)
iast_GLOBAL 17.831 s [17.831 s, 17.831 s] 2.846 s (19.0%)
profiling 15.465 s [15.465 s, 15.465 s] 480.0 ms (3.2%)
tracing 15.114 s [15.114 s, 15.114 s] 129.0 ms (0.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.039 s [15.039 s, 15.039 s] -
appsec 14.81 s [14.81 s, 14.81 s] -229.0 ms (-1.5%)
iast 18.872 s [18.872 s, 18.872 s] 3.833 s (25.5%)
iast_GLOBAL 17.837 s [17.837 s, 17.837 s] 2.798 s (18.6%)
profiling 15.133 s [15.133 s, 15.133 s] 94.0 ms (0.6%)
tracing 15.04 s [15.04 s, 15.04 s] 1.0 ms (0.0%)

@smola
smola force-pushed the smola/waf-serialization-improvements branch from 2594133 to 90db8f6 Compare June 19, 2024 16:01
@smola
smola marked this pull request as ready for review June 19, 2024 16:09
@smola
smola requested a review from a team as a code owner June 19, 2024 16:09
@smola
smola force-pushed the smola/waf-serialization-improvements branch from 90db8f6 to 80780dc Compare June 20, 2024 09:00
manuel-alvarez-alvarez
manuel-alvarez-alvarez approved these changes Jun 20, 2024
View reviewed changes
Comment thread ...appsec/src/test/groovy/com/datadog/appsec/event/data/ObjectIntrospectionSpecification.groovy Outdated
Comment thread dd-java-agent/appsec/src/main/java/com/datadog/appsec/event/data/ObjectIntrospection.java
@smola
smola merged commit 901334b into master Jun 21, 2024
@smola
smola deleted the smola/waf-serialization-improvements branch June 21, 2024 10:49
@github-actions github-actions Bot added this to the 1.36.0 milestone Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manuel-alvarez-alvarez manuel-alvarez-alvarez manuel-alvarez-alvarez approved these changes
@ValentinZakharov ValentinZakharov Awaiting requested review from ValentinZakharov ValentinZakharov is a code owner automatically assigned from DataDog/asm-java

Assignees

No one assigned

Labels

comp: asm waf Application Security Management (WAF)

Projects

None yet

Milestone

1.36.0

Development

Successfully merging this pull request may close these issues.

2 participants

@smola @manuel-alvarez-alvarez