Skip to content

Set _dd.p.dm to -5 for IAST and AppSec spans#7219

Merged
jandro996 merged 4 commits into
masterfrom
alejandro.gonzalez/asm_keep
Jun 20, 2024
Merged

Set _dd.p.dm to -5 for IAST and AppSec spans#7219
jandro996 merged 4 commits into
masterfrom
alejandro.gonzalez/asm_keep

Conversation

@jandro996

@jandro996 jandro996 commented Jun 19, 2024 •
edited by atlassian Bot
Loading

Copy link
Copy Markdown
Member

What Does This Do

Add new asm.keep tag to be able to set PrioritySampling.USER_KEEP with SamplingMechanism.APPSEC

Motivation

Current implementation is using manual.keep tag to force keep spans, this is not correct as is setting a SamplingMechanism.MANUAL (4) instead of SamplingMechanism.APPSEC(5)

Additional Notes

Jira ticket: APPSEC-52909

@jandro996
jandro996 requested review from a team as code owners June 19, 2024 12:37
@pr-commenter

pr-commenter Bot commented Jun 19, 2024 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master alejandro.gonzalez/asm_keep
git_commit_date 1718873384 1718890669
git_commit_sha 01fd984 7f39991
release_version 1.36.0-SNAPSHOT~01fd984c16 1.36.0-SNAPSHOT~7f39991f2d
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1718893890 1718893890
ci_job_id 549003970 549003970
ci_pipeline_id 37175903 37175903
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.36.0-SNAPSHOT~7f39991f2d, baseline=1.36.0-SNAPSHOT~01fd984c16

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1065335
Total [baseline] (8.538 s) : 0, 8537929
Agent [candidate] (1.068 s) : 0, 1068073
Total [candidate] (8.531 s) : 0, 8531363
section iast
Agent [baseline] (1.175 s) : 0, 1174536
Total [baseline] (8.987 s) : 0, 8986595
Agent [candidate] (1.171 s) : 0, 1171048
Total [candidate] (8.993 s) : 0, 8993192
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.168 s) : 0, 1167822
Total [baseline] (8.961 s) : 0, 8961223
Agent [candidate] (1.167 s) : 0, 1166782
Total [candidate] (8.976 s) : 0, 8975782
section iast_TELEMETRY_OFF
Agent [baseline] (1.169 s) : 0, 1168939
Total [baseline] (9.003 s) : 0, 9002754
Agent [candidate] (1.162 s) : 0, 1161504
Total [candidate] (9.009 s) : 0, 9008759
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.065 s -
Agent iast 1.175 s 109.201 ms (10.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.168 s 102.487 ms (9.6%)
Agent iast_TELEMETRY_OFF 1.169 s 103.604 ms (9.7%)
Total tracing 8.538 s -
Total iast 8.987 s 448.666 ms (5.3%)
Total iast_HARDCODED_SECRET_DISABLED 8.961 s 423.294 ms (5.0%)
Total iast_TELEMETRY_OFF 9.003 s 464.825 ms (5.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.068 s -
Agent iast 1.171 s 102.975 ms (9.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.167 s 98.709 ms (9.2%)
Agent iast_TELEMETRY_OFF 1.162 s 93.431 ms (8.7%)
Total tracing 8.531 s -
Total iast 8.993 s 461.829 ms (5.4%)
Total iast_HARDCODED_SECRET_DISABLED 8.976 s 444.419 ms (5.2%)
Total iast_TELEMETRY_OFF 9.009 s 477.396 ms (5.6%) 
gantt
    title insecure-bank - break down per module: candidate=1.36.0-SNAPSHOT~7f39991f2d, baseline=1.36.0-SNAPSHOT~01fd984c16

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (668.283 ms) : 0, 668283
BytebuddyAgent [candidate] (669.494 ms) : 0, 669494
GlobalTracer [baseline] (303.86 ms) : 0, 303860
GlobalTracer [candidate] (304.969 ms) : 0, 304969
AppSec [baseline] (50.44 ms) : 0, 50440
AppSec [candidate] (50.705 ms) : 0, 50705
Remote Config [baseline] (688.467 µs) : 0, 688
Remote Config [candidate] (703.159 µs) : 0, 703
Telemetry [baseline] (7.605 ms) : 0, 7605
Telemetry [candidate] (7.613 ms) : 0, 7613
section iast
BytebuddyAgent [baseline] (784.806 ms) : 0, 784806
BytebuddyAgent [candidate] (781.704 ms) : 0, 781704
GlobalTracer [baseline] (294.135 ms) : 0, 294135
GlobalTracer [candidate] (292.195 ms) : 0, 292195
AppSec [baseline] (47.357 ms) : 0, 47357
AppSec [candidate] (47.061 ms) : 0, 47061
IAST [baseline] (27.358 ms) : 0, 27358
IAST [candidate] (29.235 ms) : 0, 29235
Remote Config [baseline] (596.276 µs) : 0, 596
Remote Config [candidate] (662.922 µs) : 0, 663
Telemetry [baseline] (6.926 ms) : 0, 6926
Telemetry [candidate] (6.868 ms) : 0, 6868
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (778.218 ms) : 0, 778218
BytebuddyAgent [candidate] (777.425 ms) : 0, 777425
GlobalTracer [baseline] (292.904 ms) : 0, 292904
GlobalTracer [candidate] (292.792 ms) : 0, 292792
AppSec [baseline] (47.373 ms) : 0, 47373
AppSec [candidate] (47.139 ms) : 0, 47139
IAST [baseline] (28.342 ms) : 0, 28342
IAST [candidate] (27.714 ms) : 0, 27714
Remote Config [baseline] (651.562 µs) : 0, 652
Remote Config [candidate] (627.983 µs) : 0, 628
Telemetry [baseline] (7.007 ms) : 0, 7007
Telemetry [candidate] (7.785 ms) : 0, 7785
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (778.665 ms) : 0, 778665
BytebuddyAgent [candidate] (774.899 ms) : 0, 774899
GlobalTracer [baseline] (294.987 ms) : 0, 294987
GlobalTracer [candidate] (292.327 ms) : 0, 292327
AppSec [baseline] (47.327 ms) : 0, 47327
AppSec [candidate] (47.078 ms) : 0, 47078
IAST [baseline] (27.074 ms) : 0, 27074
IAST [candidate] (26.364 ms) : 0, 26364
Remote Config [baseline] (601.592 µs) : 0, 602
Remote Config [candidate] (599.832 µs) : 0, 600
Telemetry [baseline] (6.949 ms) : 0, 6949
Telemetry [candidate] (6.924 ms) : 0, 6924
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.36.0-SNAPSHOT~7f39991f2d, baseline=1.36.0-SNAPSHOT~01fd984c16

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1061668
Total [baseline] (10.296 s) : 0, 10296444
Agent [candidate] (1.067 s) : 0, 1067086
Total [candidate] (10.353 s) : 0, 10353317
section appsec
Agent [baseline] (1.18 s) : 0, 1180071
Total [baseline] (10.464 s) : 0, 10464293
Agent [candidate] (1.187 s) : 0, 1186963
Total [candidate] (10.517 s) : 0, 10517102
section iast
Agent [baseline] (1.176 s) : 0, 1176221
Total [baseline] (10.668 s) : 0, 10668227
Agent [candidate] (1.187 s) : 0, 1186512
Total [candidate] (10.73 s) : 0, 10729584
section profiling
Agent [baseline] (1.259 s) : 0, 1259397
Total [baseline] (10.633 s) : 0, 10633258
Agent [candidate] (1.276 s) : 0, 1275918
Total [candidate] (10.675 s) : 0, 10675015
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.062 s -
Agent appsec 1.18 s 118.403 ms (11.2%)
Agent iast 1.176 s 114.553 ms (10.8%)
Agent profiling 1.259 s 197.729 ms (18.6%)
Total tracing 10.296 s -
Total appsec 10.464 s 167.849 ms (1.6%)
Total iast 10.668 s 371.784 ms (3.6%)
Total profiling 10.633 s 336.814 ms (3.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.067 s -
Agent appsec 1.187 s 119.877 ms (11.2%)
Agent iast 1.187 s 119.426 ms (11.2%)
Agent profiling 1.276 s 208.832 ms (19.6%)
Total tracing 10.353 s -
Total appsec 10.517 s 163.785 ms (1.6%)
Total iast 10.73 s 376.266 ms (3.6%)
Total profiling 10.675 s 321.698 ms (3.1%) 
gantt
    title petclinic - break down per module: candidate=1.36.0-SNAPSHOT~7f39991f2d, baseline=1.36.0-SNAPSHOT~01fd984c16

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (665.503 ms) : 0, 665503
BytebuddyAgent [candidate] (669.297 ms) : 0, 669297
GlobalTracer [baseline] (303.464 ms) : 0, 303464
GlobalTracer [candidate] (304.579 ms) : 0, 304579
AppSec [baseline] (50.156 ms) : 0, 50156
AppSec [candidate] (50.283 ms) : 0, 50283
Remote Config [baseline] (688.962 µs) : 0, 689
Remote Config [candidate] (684.433 µs) : 0, 684
Telemetry [baseline] (7.501 ms) : 0, 7501
Telemetry [candidate] (7.601 ms) : 0, 7601
section appsec
BytebuddyAgent [baseline] (674.972 ms) : 0, 674972
BytebuddyAgent [candidate] (678.066 ms) : 0, 678066
GlobalTracer [baseline] (296.514 ms) : 0, 296514
GlobalTracer [candidate] (298.729 ms) : 0, 298729
AppSec [baseline] (153.661 ms) : 0, 153661
AppSec [candidate] (154.372 ms) : 0, 154372
IAST [baseline] (22.913 ms) : 0, 22913
IAST [candidate] (22.865 ms) : 0, 22865
Remote Config [baseline] (633.095 µs) : 0, 633
Remote Config [candidate] (647.347 µs) : 0, 647
Telemetry [baseline] (8.448 ms) : 0, 8448
Telemetry [candidate] (9.152 ms) : 0, 9152
section iast
BytebuddyAgent [baseline] (784.813 ms) : 0, 784813
BytebuddyAgent [candidate] (791.374 ms) : 0, 791374
GlobalTracer [baseline] (294.841 ms) : 0, 294841
GlobalTracer [candidate] (297.856 ms) : 0, 297856
AppSec [baseline] (47.346 ms) : 0, 47346
AppSec [candidate] (47.744 ms) : 0, 47744
IAST [baseline] (28.332 ms) : 0, 28332
IAST [candidate] (27.579 ms) : 0, 27579
Remote Config [baseline] (596.21 µs) : 0, 596
Remote Config [candidate] (626.114 µs) : 0, 626
Telemetry [baseline] (6.93 ms) : 0, 6930
Telemetry [candidate] (7.855 ms) : 0, 7855
section profiling
BytebuddyAgent [baseline] (662.084 ms) : 0, 662084
BytebuddyAgent [candidate] (671.455 ms) : 0, 671455
GlobalTracer [baseline] (384.751 ms) : 0, 384751
GlobalTracer [candidate] (389.38 ms) : 0, 389380
AppSec [baseline] (51.359 ms) : 0, 51359
AppSec [candidate] (51.78 ms) : 0, 51780
Remote Config [baseline] (742.299 µs) : 0, 742
Remote Config [candidate] (748.743 µs) : 0, 749
Telemetry [baseline] (7.357 ms) : 0, 7357
Telemetry [candidate] (7.508 ms) : 0, 7508
ProfilingAgent [baseline] (96.234 ms) : 0, 96234
ProfilingAgent [candidate] (97.403 ms) : 0, 97403
Profiling [baseline] (96.259 ms) : 0, 96259
Profiling [candidate] (97.427 ms) : 0, 97427
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-06-20T14:02:16 2024-06-20T14:09:05
git_branch master alejandro.gonzalez/asm_keep
git_commit_date 1718873384 1718890669
git_commit_sha 01fd984 7f39991
release_version 1.36.0-SNAPSHOT~01fd984c16 1.36.0-SNAPSHOT~7f39991f2d
start_time 2024-06-20T14:02:03 2024-06-20T14:08:52
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1718892891 1718892891
ci_job_id 549003971 549003971
ci_pipeline_id 37175903 37175903
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~7f39991f2d, baseline=1.36.0-SNAPSHOT~01fd984c16
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.339 ms) : 1320, 1358
.   : milestone, 1339,
appsec (1.722 ms) : 1697, 1747
.   : milestone, 1722,
appsec_no_iast (1.703 ms) : 1678, 1728
.   : milestone, 1703,
iast (1.488 ms) : 1466, 1510
.   : milestone, 1488,
profiling (1.523 ms) : 1497, 1549
.   : milestone, 1523,
tracing (1.449 ms) : 1425, 1472
.   : milestone, 1449,
section candidate
no_agent (1.337 ms) : 1318, 1357
.   : milestone, 1337,
appsec (1.712 ms) : 1688, 1737
.   : milestone, 1712,
appsec_no_iast (1.703 ms) : 1677, 1728
.   : milestone, 1703,
iast (1.501 ms) : 1478, 1523
.   : milestone, 1501,
profiling (1.538 ms) : 1512, 1564
.   : milestone, 1538,
tracing (1.465 ms) : 1441, 1489
.   : milestone, 1465,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.339 ms [1.32 ms, 1.358 ms] -
appsec 1.722 ms [1.697 ms, 1.747 ms] 382.614 µs (28.6%)
appsec_no_iast 1.703 ms [1.678 ms, 1.728 ms] 363.613 µs (27.2%)
iast 1.488 ms [1.466 ms, 1.51 ms] 149.246 µs (11.1%)
profiling 1.523 ms [1.497 ms, 1.549 ms] 183.51 µs (13.7%)
tracing 1.449 ms [1.425 ms, 1.472 ms] 109.679 µs (8.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.337 ms [1.318 ms, 1.357 ms] -
appsec 1.712 ms [1.688 ms, 1.737 ms] 375.07 µs (28.0%)
appsec_no_iast 1.703 ms [1.677 ms, 1.728 ms] 365.52 µs (27.3%)
iast 1.501 ms [1.478 ms, 1.523 ms] 163.247 µs (12.2%)
profiling 1.538 ms [1.512 ms, 1.564 ms] 200.704 µs (15.0%)
tracing 1.465 ms [1.441 ms, 1.489 ms] 127.636 µs (9.5%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~7f39991f2d, baseline=1.36.0-SNAPSHOT~01fd984c16
    dateFormat X
    axisFormat %s
section baseline
no_agent (366.241 µs) : 347, 386
.   : milestone, 366,
iast (472.698 µs) : 452, 494
.   : milestone, 473,
iast_FULL (546.566 µs) : 525, 568
.   : milestone, 547,
iast_GLOBAL (506.714 µs) : 484, 529
.   : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (482.118 µs) : 461, 503
.   : milestone, 482,
iast_INACTIVE (451.782 µs) : 429, 474
.   : milestone, 452,
iast_TELEMETRY_OFF (461.185 µs) : 440, 482
.   : milestone, 461,
tracing (435.379 µs) : 414, 456
.   : milestone, 435,
section candidate
no_agent (370.578 µs) : 350, 391
.   : milestone, 371,
iast (473.623 µs) : 452, 495
.   : milestone, 474,
iast_FULL (546.287 µs) : 525, 568
.   : milestone, 546,
iast_GLOBAL (496.568 µs) : 476, 517
.   : milestone, 497,
iast_HARDCODED_SECRET_DISABLED (476.666 µs) : 455, 498
.   : milestone, 477,
iast_INACTIVE (446.908 µs) : 426, 468
.   : milestone, 447,
iast_TELEMETRY_OFF (463.38 µs) : 443, 484
.   : milestone, 463,
tracing (436.697 µs) : 416, 457
.   : milestone, 437,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 366.241 µs [346.889 µs, 385.594 µs] -
iast 472.698 µs [451.727 µs, 493.669 µs] 106.456 µs (29.1%)
iast_FULL 546.566 µs [525.491 µs, 567.64 µs] 180.324 µs (49.2%)
iast_GLOBAL 506.714 µs [484.235 µs, 529.193 µs] 140.473 µs (38.4%)
iast_HARDCODED_SECRET_DISABLED 482.118 µs [460.756 µs, 503.48 µs] 115.876 µs (31.6%)
iast_INACTIVE 451.782 µs [429.443 µs, 474.121 µs] 85.541 µs (23.4%)
iast_TELEMETRY_OFF 461.185 µs [440.156 µs, 482.214 µs] 94.944 µs (25.9%)
tracing 435.379 µs [414.497 µs, 456.26 µs] 69.137 µs (18.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.578 µs [349.758 µs, 391.397 µs] -
iast 473.623 µs [452.309 µs, 494.937 µs] 103.045 µs (27.8%)
iast_FULL 546.287 µs [525.036 µs, 567.538 µs] 175.709 µs (47.4%)
iast_GLOBAL 496.568 µs [475.68 µs, 517.455 µs] 125.99 µs (34.0%)
iast_HARDCODED_SECRET_DISABLED 476.666 µs [455.351 µs, 497.98 µs] 106.088 µs (28.6%)
iast_INACTIVE 446.908 µs [425.908 µs, 467.908 µs] 76.33 µs (20.6%)
iast_TELEMETRY_OFF 463.38 µs [442.628 µs, 484.132 µs] 92.802 µs (25.0%)
tracing 436.697 µs [416.421 µs, 456.974 µs] 66.12 µs (17.8%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master alejandro.gonzalez/asm_keep
git_commit_date 1718873384 1718890669
git_commit_sha 01fd984 7f39991
release_version 1.36.0-SNAPSHOT~01fd984c16 1.36.0-SNAPSHOT~7f39991f2d
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1718893343 1718893343
ci_job_id 549003972 549003972
ci_pipeline_id 37175903 37175903
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~7f39991f2d, baseline=1.36.0-SNAPSHOT~01fd984c16
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.406 s) : 15406000, 15406000
.   : milestone, 15406000,
appsec (14.952 s) : 14952000, 14952000
.   : milestone, 14952000,
iast (18.797 s) : 18797000, 18797000
.   : milestone, 18797000,
iast_GLOBAL (18.133 s) : 18133000, 18133000
.   : milestone, 18133000,
profiling (15.103 s) : 15103000, 15103000
.   : milestone, 15103000,
tracing (14.931 s) : 14931000, 14931000
.   : milestone, 14931000,
section candidate
no_agent (14.878 s) : 14878000, 14878000
.   : milestone, 14878000,
appsec (14.998 s) : 14998000, 14998000
.   : milestone, 14998000,
iast (18.857 s) : 18857000, 18857000
.   : milestone, 18857000,
iast_GLOBAL (18.037 s) : 18037000, 18037000
.   : milestone, 18037000,
profiling (15.689 s) : 15689000, 15689000
.   : milestone, 15689000,
tracing (15.117 s) : 15117000, 15117000
.   : milestone, 15117000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.406 s [15.406 s, 15.406 s] -
appsec 14.952 s [14.952 s, 14.952 s] -454.0 ms (-2.9%)
iast 18.797 s [18.797 s, 18.797 s] 3.391 s (22.0%)
iast_GLOBAL 18.133 s [18.133 s, 18.133 s] 2.727 s (17.7%)
profiling 15.103 s [15.103 s, 15.103 s] -303.0 ms (-2.0%)
tracing 14.931 s [14.931 s, 14.931 s] -475.0 ms (-3.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.878 s [14.878 s, 14.878 s] -
appsec 14.998 s [14.998 s, 14.998 s] 120.0 ms (0.8%)
iast 18.857 s [18.857 s, 18.857 s] 3.979 s (26.7%)
iast_GLOBAL 18.037 s [18.037 s, 18.037 s] 3.159 s (21.2%)
profiling 15.689 s [15.689 s, 15.689 s] 811.0 ms (5.5%)
tracing 15.117 s [15.117 s, 15.117 s] 239.0 ms (1.6%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~7f39991f2d, baseline=1.36.0-SNAPSHOT~01fd984c16
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.464 ms) : 1452, 1475
.   : milestone, 1464,
appsec (2.214 ms) : 2179, 2248
.   : milestone, 2214,
iast (1.959 ms) : 1918, 1999
.   : milestone, 1959,
iast_GLOBAL (2.0 ms) : 1959, 2041
.   : milestone, 2000,
profiling (1.847 ms) : 1812, 1881
.   : milestone, 1847,
tracing (1.831 ms) : 1799, 1863
.   : milestone, 1831,
section candidate
no_agent (1.466 ms) : 1454, 1477
.   : milestone, 1466,
appsec (2.218 ms) : 2184, 2253
.   : milestone, 2218,
iast (1.972 ms) : 1931, 2013
.   : milestone, 1972,
iast_GLOBAL (2.021 ms) : 1978, 2064
.   : milestone, 2021,
profiling (1.864 ms) : 1830, 1897
.   : milestone, 1864,
tracing (1.834 ms) : 1802, 1867
.   : milestone, 1834,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.464 ms [1.452 ms, 1.475 ms] -
appsec 2.214 ms [2.179 ms, 2.248 ms] 749.877 µs (51.2%)
iast 1.959 ms [1.918 ms, 1.999 ms] 494.835 µs (33.8%)
iast_GLOBAL 2.0 ms [1.959 ms, 2.041 ms] 536.279 µs (36.6%)
profiling 1.847 ms [1.812 ms, 1.881 ms] 382.696 µs (26.1%)
tracing 1.831 ms [1.799 ms, 1.863 ms] 367.33 µs (25.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.466 ms [1.454 ms, 1.477 ms] -
appsec 2.218 ms [2.184 ms, 2.253 ms] 752.58 µs (51.3%)
iast 1.972 ms [1.931 ms, 2.013 ms] 505.948 µs (34.5%)
iast_GLOBAL 2.021 ms [1.978 ms, 2.064 ms] 555.431 µs (37.9%)
profiling 1.864 ms [1.83 ms, 1.897 ms] 397.684 µs (27.1%)
tracing 1.834 ms [1.802 ms, 1.867 ms] 368.463 µs (25.1%)

@smola smola changed the title Properly set _dd.p.dm to -5 for IAST and AppSec manually kept spans Set _dd.p.dm to -5 for IAST and AppSec manually kept spans Jun 19, 2024
@smola smola changed the title Set _dd.p.dm to -5 for IAST and AppSec manually kept spans Set _dd.p.dm to -5 for IAST and AppSec spans Jun 19, 2024
@smola smola added the comp: asm waf Application Security Management (WAF) label Jun 19, 2024
PerfectSlayer
PerfectSlayer approved these changes Jun 20, 2024
View reviewed changes

@PerfectSlayer PerfectSlayer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just minor comment.
Sorry for the delay 🙏

Comment thread dd-trace-core/src/main/java/datadog/trace/core/DDSpanContext.java
@jandro996

jandro996 commented Jun 20, 2024

Copy link
Copy Markdown
Member Author

LGTM! Just minor comment. Sorry for the delay 🙏

No problem! thanks for the review 👍

@jandro996
jandro996 merged commit f6d95fd into master Jun 20, 2024
@jandro996
jandro996 deleted the alejandro.gonzalez/asm_keep branch June 20, 2024 14:55
@github-actions github-actions Bot added this to the 1.36.0 milestone Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smola smola smola approved these changes
@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes
@manuel-alvarez-alvarez manuel-alvarez-alvarez manuel-alvarez-alvarez approved these changes
@am312 am312 Awaiting requested review from am312 am312 is a code owner automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

comp: asm waf Application Security Management (WAF)

Projects

None yet

Milestone

1.36.0

Development

Successfully merging this pull request may close these issues.

4 participants

@jandro996 @smola @PerfectSlayer @manuel-alvarez-alvarez